Hi, > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, May 11, 2018 12:32 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Trahe, Fiona > <fiona.tr...@intel.com>; Jozwiak, TomaszX <tomaszx.jozw...@intel.com> > Subject: [PATCH 2/5] crypto/qat: move to dynamic logging for non-dp trace > > From: Tomasz Jozwiak <tomaszx.jozw...@intel.com> > > For all trace not on the data-path move to dynamic logging. > > Signed-off-by: Tomasz Jozwiak <tomaszx.jozw...@intel.com> > Signed-off-by: Fiona Trahe <fiona.tr...@intel.com>
... > +++ b/drivers/crypto/qat/qat_logs.c > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > + > +#include <rte_log.h> > + > +int qat_gen_logtype; > + > +static void > +qat_pci_init_log(void) > +{ > + /* Non-data-path logging for pci device and all services */ > + qat_gen_logtype = rte_log_register("pmd.qat_general"); > + if (qat_gen_logtype >= 0) > + rte_log_set_level(qat_gen_logtype, RTE_LOG_NOTICE); } > + > +RTE_INIT(qat_pci_init_log); I am seeing a compilation error on clang: drivers/crypto/qat/qat_logs.c:18:1: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] RTE_INIT(qat_pci_init_log); ^ Thanks, Pablo