Re: [dpdk-dev] [PATCH 1/4] mbuf: add accessor function for private data area

2018-06-08 Thread Dan Gora
Hi All, Thanks for the feedback. >> Just a nit... >> As I understand 'md' here follows previous function which is >> rte_mbuf_to_baddr() and works with direct mbuf - that's why >> parameter is named 'md' (mbuf direct). The most of functions >> in the header use just 'm' for any mbuf. Ok, I'll fi

[dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size functions

2018-06-08 Thread Pablo de Lara
Removed rte_cryptodev_get_header_session_size and rte_cryptodev_get_private_session_size functions, as they have been substituted with functions specific for symmetric operations, with _sym_ word after "rte_cryptodev_". Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst

[dpdk-dev] [PATCH 6/6] cryptodev: replace mbuf scatter gather flag

2018-06-08 Thread Pablo de Lara
The current mbuf scatter gatter feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not. Therefore, two new flags will replace this flag: RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER_IN and RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER_OUT. Signed-off-by

[dpdk-dev] [PATCH 4/6] cryptodev: remove queue start/stop functions

2018-06-08 Thread Pablo de Lara
Removed cryptodev queue start/stop functions, as they were marked deprecated in 18.05, since they were not implemented by any driver. Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst | 4 -- doc/guides/rel_notes/release_18_08.rst| 5 +++ drivers/crypto/aes

[dpdk-dev] [PATCH 0/6] Cryptodev API changes

2018-06-08 Thread Pablo de Lara
API changes in the cryptodev library, announced in the previous release, 18.05. Pablo de Lara (6): cryptodev: replace bus specific struct with generic dev cryptodev: remove max number of sessions per queue cryptodev: remove max number of sessions cryptodev: remove queue start/stop functio

[dpdk-dev] [PATCH 3/6] cryptodev: remove max number of sessions

2018-06-08 Thread Pablo de Lara
Sessions are not created and stored in the crypto device anymore, since now the session mempool is created at the application level. Therefore the limitation of the maximum number of sessions that can be created should not be dependent of the crypto device. Signed-off-by: Pablo de Lara --- conf

[dpdk-dev] [PATCH 2/6] cryptodev: remove max number of sessions per queue

2018-06-08 Thread Pablo de Lara
The cryptodev info structure currently contains the maximum number of sessions that can be used in a queue pair. This is only set in DPAA_SEC PMD, and since it is calculated based on the maximum number of sessions (which is not used anymore), this field can be removed. Signed-off-by: Pablo de Lara

[dpdk-dev] [PATCH 1/6] cryptodev: replace bus specific struct with generic dev

2018-06-08 Thread Pablo de Lara
Structure rte_cryptodev_info has currently PCI device information ("struct rte_pci_device") in it. This information is not generic to all devices, so this gets replaced with the generic "rte_device" structure, compatible with all crypto devices. Signed-off-by: Pablo de Lara --- doc/guides/prog_

[dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC

2018-06-08 Thread Ferruh Yigit
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release default behavior in PMDs is to keep the CRC until this flag removed Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: - Setting both KEEP_CRC & CRC_STRIP is INVALID - Setting only CRC_STRIP PMD sh

Re: [dpdk-dev] [RFC] ethdev: remove all offload API

2018-06-08 Thread Ferruh Yigit
On 6/8/2018 11:41 PM, Ferruh Yigit wrote: > Cc: Shahaf Shuler > > Signed-off-by: Ferruh Yigit Correction: Patch title should be "*old* offloading API", not *all* J [RFC] ethdev: remove old offload API

[dpdk-dev] [RFC] ethdev: remove all offload API

2018-06-08 Thread Ferruh Yigit
Cc: Shahaf Shuler Signed-off-by: Ferruh Yigit --- app/test-eventdev/test_perf_common.c | 6 -- app/test-eventdev/test_pipeline_common.c | 1 - app/test-pmd/testpmd.c | 3 - doc/guides/nics/features.rst | 1 - doc/

[dpdk-dev] [PATCH v2 15/15] net/vhost: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Tetsuya Mukawa CC: Maxime Coquelin Signed-off-by: Bruce Richardson --- drivers/net/meson.build | 2 +- drivers/net/vhost/meson.build | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 drivers/net/vhost/meson.build diff --git a/drivers/net/meson.build b/d

[dpdk-dev] [PATCH v2 09/15] net/ifcvf: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Xiao Wang Signed-off-by: Bruce Richardson --- drivers/net/ifcvf/meson.build | 7 +++ drivers/net/meson.build | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ifcvf/meson.build diff --git a/drivers/net/ifcvf/meson.build b/drivers/net/ifcvf/mes

[dpdk-dev] [PATCH v2 13/15] net/softnic: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Jasvinder Singh CC: Cristian Dumitrescu Signed-off-by: Bruce Richardson --- drivers/net/meson.build| 3 ++- drivers/net/softnic/Makefile | 2 +- drivers/net/softnic/meson.build| 7 +++ ...eth_s

[dpdk-dev] [PATCH v2 14/15] net/szedata2: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Matej Vido Signed-off-by: Bruce Richardson --- drivers/net/meson.build | 2 +- drivers/net/szedata2/meson.build | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 drivers/net/szedata2/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson

[dpdk-dev] [PATCH v2 10/15] net/kni: add to meson build

2018-06-08 Thread Bruce Richardson
Since the kni library is an optional library, we need to add a check here to ensure that the kni wrapper PMD is only built when the main kni lib is being built. CC: Ferruh Yigit Signed-off-by: Bruce Richardson --- drivers/net/kni/meson.build | 8 drivers/net/meson.build | 3 ++- 2

[dpdk-dev] [PATCH v2 12/15] net/nfp: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Alejandro Lucero Signed-off-by: Bruce Richardson --- drivers/net/meson.build | 2 +- drivers/net/nfp/meson.build | 16 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 drivers/net/nfp/meson.build diff --git a/drivers/net/meson.build b/drivers/net/me

[dpdk-dev] [PATCH v2 11/15] net/liquidio: add to meson build

2018-06-08 Thread Bruce Richardson
Signed-off-by: Bruce Richardson Acked-by: Shijith Thotton --- drivers/net/liquidio/Makefile | 2 +- drivers/net/liquidio/meson.build | 8 ...e_pmd_lio_version.map => rte_pmd_liquidio_version.map} | 0 drivers/net/meson.build

[dpdk-dev] [PATCH v2 06/15] net/ena: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Marcin Wojtas CC: Michal Krawczyk CC: Guy Tzalik CC: Evgeny Schemeilin Signed-off-by: Bruce Richardson --- drivers/net/ena/meson.build | 8 drivers/net/meson.build | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ena/meson.build diff

[dpdk-dev] [PATCH v2 08/15] net/ifc: rename to ifcvf

2018-06-08 Thread Bruce Richardson
All files in the directory and the resulting driver have prefix of ifcvf, not just ifc, so rename directory for accuracy. Also rename the map file to standard name for meson build in the process. CC: Xiao Wang Signed-off-by: Bruce Richardson --- MAINTAINERS

[dpdk-dev] [PATCH v2 07/15] net/failsafe: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Gaetan Rivet Signed-off-by: Bruce Richardson --- drivers/net/failsafe/meson.build | 23 +++ drivers/net/meson.build | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 drivers/net/failsafe/meson.build diff --git a/drivers/net/failsafe/m

[dpdk-dev] [PATCH v2 05/15] net/cxgbe: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Rahul Lakkireddy Signed-off-by: Bruce Richardson --- drivers/net/cxgbe/meson.build | 11 +++ drivers/net/meson.build | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 drivers/net/cxgbe/meson.build diff --git a/drivers/net/cxgbe/meson.build b/drivers

[dpdk-dev] [PATCH v2 04/15] net/bnxt: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Ajit Khaparde CC: Somnath Kotur Signed-off-by: Bruce Richardson --- app/test-pmd/meson.build | 3 +++ drivers/net/bnxt/meson.build | 18 ++ drivers/net/meson.build | 2 +- 3 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 drivers/net/bnxt/meson.

[dpdk-dev] [PATCH v2 02/15] net/avp: add to meson build

2018-06-08 Thread Bruce Richardson
Signed-off-by: Bruce Richardson Acked-by: Allain Legacy --- drivers/net/avp/meson.build | 5 + drivers/net/meson.build | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 drivers/net/avp/meson.build diff --git a/drivers/net/avp/meson.build b/drivers/net/avp/m

[dpdk-dev] [PATCH v2 03/15] net/bnx2x: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Harish Patil CC: Rasesh Mody Signed-off-by: Bruce Richardson --- drivers/net/bnx2x/meson.build | 14 ++ drivers/net/meson.build | 3 ++- 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 drivers/net/bnx2x/meson.build diff --git a/drivers/net/bnx2x/meso

[dpdk-dev] [PATCH v2 01/15] net/ark: add to meson build

2018-06-08 Thread Bruce Richardson
CC: Shepard Siegel CC: Ed Czeck CC: John Miller Signed-off-by: Bruce Richardson --- drivers/net/ark/meson.build | 13 + drivers/net/meson.build | 3 ++- 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ark/meson.build diff --git a/drivers/net/a

[dpdk-dev] [PATCH v2 00/15] add meson support for more net drivers

2018-06-08 Thread Bruce Richardson
A number of net drivers require pretty minimal meson.build files to build successfully with meson. This set adds support for 14 net drivers to the build. V2: Small change to net/kni patch to ensure 32-bit builds ok. Bruce Richardson (15): net/ark: add to meson build net/avp: add to meson buil

Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules

2018-06-08 Thread Stephen Hemminger
On Thu, 31 May 2018 13:44:30 +0100 Ferruh Yigit wrote: > The error path was disabled in previous release to let apps to be more > flexible. > > But this release they are enabled, applications have to obey offload API > rules otherwise they will get errors from following APIs: > rte_eth_dev_confi

Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules

2018-06-08 Thread Thomas Monjalon
08/06/2018 21:51, Ferruh Yigit: > On 5/31/2018 1:44 PM, Ferruh Yigit wrote: > > The error path was disabled in previous release to let apps to be more > > flexible. > > > > But this release they are enabled, applications have to obey offload API > > rules otherwise they will get errors from follow

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: add missing ids in xstats

2018-06-08 Thread Ferruh Yigit
On 6/8/2018 8:57 PM, Ferruh Yigit wrote: > On 6/7/2018 10:34 PM, Ajit Khaparde wrote: >> On Wed, Jun 6, 2018 at 10:36 PM, David Marchand >> wrote: >> >>> The xstats api expects that the driver fills both values and ids for each >>> filled entries. >>> >>> Fixes: bfb9c2260be2 ("net/bnxt: support xs

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: add missing ids in xstats

2018-06-08 Thread Ferruh Yigit
On 6/7/2018 10:34 PM, Ajit Khaparde wrote: > On Wed, Jun 6, 2018 at 10:36 PM, David Marchand > wrote: > >> The xstats api expects that the driver fills both values and ids for each >> filled entries. >> >> Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") >> >> Signed-off-by: David March

Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules

2018-06-08 Thread Ferruh Yigit
On 5/31/2018 1:44 PM, Ferruh Yigit wrote: > The error path was disabled in previous release to let apps to be more > flexible. > > But this release they are enabled, applications have to obey offload API > rules otherwise they will get errors from following APIs: > rte_eth_dev_configure > rte_eth_

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix unused header reference

2018-06-08 Thread Ferruh Yigit
On 6/8/2018 11:40 AM, Alejandro Lucero wrote: > Apart from not being used, this is causing problem when compiling > DPDK with the musl library as reported by bugzilla. If this is fixing a bugzilla issue, can you please use defined syntax to document it: Bugzilla ID: ### Fixes: ("

Re: [dpdk-dev] [PATCH v3 01/27] net/ena: change version number to 1.1.0

2018-06-08 Thread Ferruh Yigit
On 6/7/2018 10:42 AM, Michal Krawczyk wrote: > The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD > and the version number is updated accordingly. Does it make sense to add a release notes update to announce driver update? > > Signed-off-by: Michal Krawczyk <...>

Re: [dpdk-dev] [PATCH v3 02/27] net/ena: update ena_com to the newer version

2018-06-08 Thread Ferruh Yigit
On 6/7/2018 10:42 AM, Michal Krawczyk wrote: > ena_com is the HAL provided by the vendor and it shouldn't be modified > by the driver developers. > > The PMD and platform file was adjusted for the new version of the > ena_com: > * Do not use deprecated meta descriptor fields > * Add empty

Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format

2018-06-08 Thread Thomas Monjalon
17/04/2018 23:49, Stephen Hemminger: > Since DPDK developers have decided to use a different tag format > than the kernel developers, ignore warnings about SPDX tags. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH v3 27/27] net/ena: set link speed as none

2018-06-08 Thread Ferruh Yigit
On 6/7/2018 10:43 AM, Michal Krawczyk wrote: > From: Rafal Kozik > > Link speed should is not limited to 10Gb/s and it shouldn't be hardcoded. > > They link speed is set to none instead and the applications shouldn't > rely on this value when using ENA PMD. Why not able to set link speed? And

Re: [dpdk-dev] DPDK checkpatch and SPDX tags?

2018-06-08 Thread Thomas Monjalon
08/06/2018 19:15, Stephen Hemminger: > What ever happened to my patch to fix the DPDK checkpatch wrapper ignore > fields? > Is the build bot using current version? There was a discussion about implementing more checks, and I did not apply your patch. It is a mistake because even if we need to imp

Re: [dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency for linking

2018-06-08 Thread Ferruh Yigit
On 6/7/2018 10:43 AM, Michal Krawczyk wrote: > ENA PMD is required to use librte_timer. The appropriate depndency must > be added ifin case the DPDK will be built as shared library. > > Signed-off-by: Michal Krawczyk > --- > drivers/net/ena/Makefile | 1 + > mk/rte.app.mk| 1 + > 2 f

Re: [dpdk-dev] [PATCH] doc: update qede management firmware guide

2018-06-08 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, June 08, 2018 11:10 AM > > On 6/1/2018 11:57 PM, Rasesh Mody wrote: > > Fixes: c49a438fce90 ("doc: update qede guide and features") > > Fixes: db86fbe54d90 ("doc: update qede PMD NIC guide") > > Cc: sta...@dpdk.org > > > > Signed

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix incorrect link status update

2018-06-08 Thread Ferruh Yigit
On 6/7/2018 5:30 PM, Rasesh Mody wrote: > From: Shahed Shaikh > > qede_link_update() always returns -1 i.e. link not changed, > becasue it compares the variables which always hold same value. > > Fix this function by using rte_eth_linkstatus_set(). > > Fixes: 2ea6f76aff40 ("qede: add core drive

Re: [dpdk-dev] 18.02.2 patches review and test

2018-06-08 Thread Ray Cai
Hi Luca: We did some basic testing with testpmd and pktgen 3.5.0 on Azure environment with this DPDK version. We didn't see any problems. Thanks, -Ray -Original Message- From: dev On Behalf Of Luca Boccassi Sent: Friday, June 8, 2018 2:16 AM To: dpdk stable Cc: dev@dpdk.org Subject: R

[dpdk-dev] [PATCH] eventdev: add callback for Rx adapter SW transfers

2018-06-08 Thread Nikhil Rao
Add ability for application to register a callback function for SW transfers, the callback can decide which packets can be enqueued to the event device. Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.h | 78 ++ lib/librte_eventdev/rte_event_eth

[dpdk-dev] [PATCH v1 4/4] eventdev: add interrupt driven queues in Rx event adapter

2018-06-08 Thread Nikhil Rao
Add support for interrupt driven queues when eth device is configured for rxq interrupts and servicing weight for the queue is configured to be zero. A interrupt driven packet received counter has been added to rte_event_eth_rx_adapter_stats. Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rt

[dpdk-dev] [PATCH v1 3/4] eventdev: move Rx adapter eth Rx to separate function

2018-06-08 Thread Nikhil Rao
Create a separate function that handles eth receive and enqueue to event buffer. This function will also be called for interrupt driven receive queues. Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 67 ++ 1 file changed, 47 insertions(+),

[dpdk-dev] [PATCH v1 2/4] eventdev: improve err handling for Rx adapter queue add/del

2018-06-08 Thread Nikhil Rao
The new WRR sequence applicable after queue add/del is set up after setting the new queue state, so a memory allocation failure will leave behind an incorrect state. This change separates the memory sizing + allocation for the Rx poll and WRR array from calculation of the WRR sequence. If there is

[dpdk-dev] [PATCH v1 3/4] eventdev: move Rx adapter eth receive code to separate function

2018-06-08 Thread Nikhil Rao
Create a separate function that handles eth receive and enqueue to event buffer. This function will also be called for interrupt driven receive queues. Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 67 ++ 1 file changed, 47 insertions(+),

[dpdk-dev] [PATCH v1 1/4] eventdev: standardize Rx adapter internal function names

2018-06-08 Thread Nikhil Rao
Add a common prefix to function names and rename few to better match functionality Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 167 - 1 file changed, 80 insertions(+), 87 deletions(-) diff --git a/lib/librte_eventdev/rte_event_eth_rx_ad

[dpdk-dev] [PATCH v1 0/4] eventdev: add interrupt driven queues to Rx adapter

2018-06-08 Thread Nikhil Rao
This patch series adds support for interrupt driven queues to the ethernet Rx adapter, the first 3 patches prepare the code to handle both poll and interrupt driven Rx queues and the final patch has code changes specific to interrupt driven queues. This patch series is to be applied on top of the

Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support

2018-06-08 Thread Stephen Hemminger
On Fri, 8 Jun 2018 17:15:04 + "Wiles, Keith" wrote: > > On Jun 8, 2018, at 9:59 AM, Stephen Hemminger > > wrote: > > > > Since uuid functions may not be available everywhere, implement > > uuid functions in DPDK. These are based off the BSD licensed > > libuuid in util-link. > > > > Signe

Re: [dpdk-dev] [PATCH] doc: update qede management firmware guide

2018-06-08 Thread Ferruh Yigit
On 6/1/2018 11:57 PM, Rasesh Mody wrote: > Fixes: c49a438fce90 ("doc: update qede guide and features") > Fixes: db86fbe54d90 ("doc: update qede PMD NIC guide") > Cc: sta...@dpdk.org > > Signed-off-by: Rasesh Mody > --- > doc/guides/nics/qede.rst | 12 ++-- > 1 file changed, 6 insertion

Re: [dpdk-dev] [PATCH] net/qede: fix memory alloc for multiple port reconfig

2018-06-08 Thread Ferruh Yigit
On 6/8/2018 12:56 PM, Kevin Traynor wrote: > On 06/07/2018 05:30 PM, Rasesh Mody wrote: >> Multiple port reconfigurations can lead to memory allocation failures >> due to hitting RTE memzone limit or no more room in config while >> reserving memzone. >> >> When freeing memzones, update the memzone

[dpdk-dev] [PATCH 7/7] net/cxgbe: implement flow flush operation

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Add API to flush all the filters under specified port. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.h | 1 + drivers/net/cxgbe/cxgbe_flow.c | 40 +++-

[dpdk-dev] [PATCH 4/7] net/cxgbe: implement flow create operation

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Define filter work request API used to construct filter operations to be communicated with firmware. These requests are sent via control queue and completions come asynchronously in firmware event queue. Implement flow create operation to create filters in LE-TCAM (maskfull)

[dpdk-dev] [PATCH 6/7] net/cxgbe: implement flow query operation

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Add API to query filter hit and byte counts from hardware. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h | 1 + drivers/net/cxgbe/base/common.h | 15 +++ drivers/net/cxgbe/base/t4_hw.c

[dpdk-dev] [PATCH 5/7] net/cxgbe: implement flow destroy operation

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Add API to construct delete filter work request to remove filter at specified index in LE-TCAM (maskfull) region. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.c | 114 +++

[dpdk-dev] [PATCH 3/7] net/cxgbe: add control queue to communicate filter requests

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Add control queue to communicate filter creation/deletion requests with firmware. This API will be used by subsequent patches. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h| 15 +++

[dpdk-dev] [PATCH 2/7] net/cxgbe: parse and validate flows

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Introduce rte_flow skeleton and implement validate operation. Parse and convert , , into hardware specification. Perform validation, including basic sanity tests and underlying device's supported filter capability checks. Currently add support for: : IPv4, IPv6, TCP, and U

[dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Fetch available filter resources from firmware and allocate table for book-keeping and managing filters in hardware. Also define the hardware filter specification (ch_filter_specification) used to describe each filter rule. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar

[dpdk-dev] [PATCH 0/7] cxgbe: add support to offload flows via rte_flow

2018-06-08 Thread Rahul Lakkireddy
This series add basic support to offload flows to Chelsio T5/T6 NICs via rte_flow API. Chelsio NICs can support wildcard (maskfull) filters and exact (maskless) filters. Filters can be created in two regions available on Chelsio NICs. The smaller LE-TCAM region can support both maskfull and maskles

[dpdk-dev] [PATCH v1 3/3] hash: add new API function to query the key count

2018-06-08 Thread Yipeng Wang
Add a new function, rte_hash_count, to return the number of keys that are currently stored in the hash table. Corresponding test functions are added into hash_test and hash_multiwriter test. Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.c| 39 +++-

[dpdk-dev] [PATCH v1 2/3] test: add test case for read write concurrency

2018-06-08 Thread Yipeng Wang
This commit adds a new test case for testing read/write concurrency. Signed-off-by: Yipeng Wang --- test/test/Makefile | 1 + test/test/test_hash_perf.c | 36 ++- test/test/test_hash_readwrite.c | 649 3 files changed, 675 insertions(

[dpdk-dev] [PATCH v1 1/3] hash: add read and write concurrency support

2018-06-08 Thread Yipeng Wang
The existing implementation of librte_hash does not support read-write concurrency. This commit implements read-write safety using rte_rwlock and rte_rwlock TM version if hardware transactional memory is available. Both multi-writer and read-write concurrency is protected by rte_rwlock now. The x8

[dpdk-dev] [PATCH v1 0/3] Add read-write concurrency to rte_hash library

2018-06-08 Thread Yipeng Wang
This patch set adds the read-write concurrency support in rte_hash. A new flag value is added to indicate if read-write concurrency is needed during creation time. Test cases are implemented to do functional and performance tests. The new concurrency model is based on rte_rwlock. When Intel TSX is

Re: [dpdk-dev] 18.08 Intel Roadmap

2018-06-08 Thread Ferruh Yigit
On 6/8/2018 6:24 PM, Rosen, Rami wrote: > Hi, Tim, > Thanks for posting the planned 18.08 roadmap, I hope other > vendors will follow! > >> Allow Setup/Reconfiguration/Tear Down of Queues at Run Time - >Currently, to >> configure a DPDK ethdev, the application specifies how >many Tx and Rx >> q

[dpdk-dev] [PATCH 17/20] eventdev: add routine to access eventmode link info

2018-06-08 Thread Anoob Joseph
When the application is drafted for single stage eventmode, it will be efficient to have the loop in the application space, rather than passing it on to the helper. But application would need to have info on the links to be able to do that efficiently. This function exposes the links to that applic

[dpdk-dev] [PATCH 16/20] eventdev: add routines to display the eventmode conf

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- lib/librte_eventdev/Makefile | 1 + lib/librte_eventdev/rte_eventmode_helper.c| 3 + lib/librte_eventdev/rte_eventmode_helper.h| 10 ++ lib/librte_eventdev/rte_eventmode_helper_prints.c | 161 ++ 4 files

[dpdk-dev] [PATCH 20/20] examples/l2fwd: add eventmode for l2fwd

2018-06-08 Thread Anoob Joseph
Adding eventmode support in l2fwd. This uses rte_eventmode_helper APIs to setup and use the eventmode capabilties. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 815 +- examples/l2fwd/main.c | 64 +++- 2 files changed, 864 insert

[dpdk-dev] [PATCH 19/20] eventdev: add routine to launch eventmode workers

2018-06-08 Thread Anoob Joseph
With eventmode, workers could be drafted differently according to the capabilities of the underlying event device. The added function would receive an array of such workers and probes the eventmode properties to choose the worker. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode

[dpdk-dev] [PATCH 18/20] eventdev: add routine to access event queue for eth Tx

2018-06-08 Thread Anoob Joseph
When the application is drafted for single stage eventmode, it will be efficient to have the loop in the application space, rather than passing it on to the helper. When the application's stage is in ORDERED sched mode, the application will have to change the sched type of the event to ATOMIC befo

[dpdk-dev] [PATCH 15/20] eventdev: add default conf for event port-lcore link

2018-06-08 Thread Anoob Joseph
Generate a default conf for event port-lcore link, if not specified in the conf. This routine will check the number of available ports and then create links according to the number of cores available. This patch also adds a new entry in the eventmode conf to denote that all queues is to be linked

[dpdk-dev] [PATCH 12/20] eventdev: add routine to validate conf

2018-06-08 Thread Anoob Joseph
Adding routine to validate event mode conf. This function will verify the conf requested by the user and would populate other fields with default values. Presently, the function acts as placeholder for the above mentioned actions. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode

[dpdk-dev] [PATCH 11/20] eventdev: add Rx adapter init in eventmode

2018-06-08 Thread Anoob Joseph
Adding rx adapter conf. The helper init routine would be initializing the rx adapter according to the conf. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 122 + .../rte_eventmode_helper_internal.h| 27 + 2 files chan

[dpdk-dev] [PATCH 14/20] eventdev: add default conf for Rx adapter conf

2018-06-08 Thread Anoob Joseph
Generate a default conf for Rx adapter, if not specified in the conf. This routine will check the available eth ports and event queues, and maps them 1:1. So one eth port will be connected to one event queue. This way, event queue ID could be used to figure out the port on which the packet came in.

[dpdk-dev] [PATCH 13/20] eventdev: add default conf for event devs field in conf

2018-06-08 Thread Anoob Joseph
Generate a default conf for event devs, if it's not specified in the conf. This routine will check the available event devices and it's properties and sets the conf accordingly. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 67 ++ 1 file

[dpdk-dev] [PATCH 09/20] eventdev: add option to specify schedule mode for app stage

2018-06-08 Thread Anoob Joseph
Scheduling mode for each event queue is dependent on the same of app stage. Configure event queue taking this also into account. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 23 -- .../rte_eventmode_helper_internal.h| 10

[dpdk-dev] [PATCH 10/20] eventdev: add placeholder for ethdev init

2018-06-08 Thread Anoob Joseph
Presently, all the applications would do ethdev init and then pass control to eventmode helper init. So not doing any "real" initialization. But this would be expanded once applications are modified to pass the eth init task also to the helper routine. Signed-off-by: Anoob Joseph --- lib/librte_

[dpdk-dev] [PATCH 08/20] eventdev: add eventdev port-lcore link

2018-06-08 Thread Anoob Joseph
Adding eventdev port-lcore link. In addition, this will also specify which event queue need to be connected to the event port. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 56 ++ lib/librte_eventdev/rte_eventmode_helper.h | 12 +

[dpdk-dev] [PATCH 07/20] eventdev: add eventdevice init for eventmode

2018-06-08 Thread Anoob Joseph
Adding routines to initialize event devs. The internal conf structure would be used to track device configuration. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 129 + .../rte_eventmode_helper_internal.h| 16 ++- 2 files

[dpdk-dev] [PATCH 06/20] eventdev: add common initialize routine for eventmode devs

2018-06-08 Thread Anoob Joseph
Adding framework for common initialization routine for event mode. Event mode would involve initialization of multiple devices, like eventdev, ethdev etc and this routine would be the placeholder for all initialization to come in. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode

[dpdk-dev] [PATCH 05/20] eventdev: add framework for eventmode conf

2018-06-08 Thread Anoob Joseph
Adding eventmode conf which would have all required configuration for the event mode. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 16 lib/librte_eventdev/rte_eventmode_helper_internal.h | 5 + 2 files changed, 21 insertions(+) diff

[dpdk-dev] [PATCH 02/20] eventdev: add routines for logging eventmode helper

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- config/common_base | 1 + lib/librte_eal/common/eal_common_log.c | 1 + lib/librte_eal/common/include/rte_log.h| 1 + .../rte_eventmode_helper_internal.h| 24 ++ 4 files

[dpdk-dev] [PATCH 04/20] eventdev: allow application to set ethernet portmask

2018-06-08 Thread Anoob Joseph
Application would be required to restrict helper functions to use only certain ports. The field eth_portmask field in the conf could be used for this. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 3 +++ lib/librte_eventdev/rte_eventmode_helper.h | 7 +++ 2 fil

[dpdk-dev] [PATCH 03/20] eventdev: add eventmode CL options framework

2018-06-08 Thread Anoob Joseph
Adding usage prints and CL parsing routines for eventmode. Option to select packet transfer mode is also added. Signed-off-by: Anoob Joseph --- lib/librte_eventdev/rte_eventmode_helper.c | 128 + lib/librte_eventdev/rte_eventmode_helper.h | 50 +++ 2 files ch

[dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- lib/librte_eventdev/Makefile| 2 ++ lib/librte_eventdev/rte_eventmode_helper.c | 7 +++ lib/librte_eventdev/rte_eventmode_helper.h | 6 ++ lib/librte_eventdev/rte_eventmode_helper_internal.h | 6 ++ 4 files chan

[dpdk-dev] [PATCH 00/20] add eventmode helper functions

2018-06-08 Thread Anoob Joseph
This patchset adds common initialization code required for using applications in event mode. The APIs exposed, abstracts the complex configuration options exposed by eventdev, ethdev & eth rx adapter. Also, this enables the usage of multiple workers fine tuned for the features of the underlying har

Re: [dpdk-dev] 18.08 Intel Roadmap

2018-06-08 Thread Rosen, Rami
Hi, Tim, Thanks for posting the planned 18.08 roadmap, I hope other vendors will follow! >Allow Setup/Reconfiguration/Tear Down of Queues at Run Time - >Currently, to >configure a DPDK ethdev, the application specifies how >many Tx and Rx queues >to include prior to starting the device. This >f

Re: [dpdk-dev] [PATCH v2] net/i40e: illagel pactket checking

2018-06-08 Thread Wiles, Keith
> On Jun 7, 2018, at 8:54 PM, Yanglong Wu wrote: > > Some illegal packets will lead to TX/RX hang and > can't recover automatically. This pacth check those > illegal packets and protect TX/RX from hanging. The subject line has a number of spelling mistakes and that is used in the comments, p

Re: [dpdk-dev] [PATCH 1/4] mbuf: add accessor function for private data area

2018-06-08 Thread Wiles, Keith
> On Jun 8, 2018, at 2:06 AM, Andrew Rybchenko > wrote: > > On 06/08/2018 02:54 AM, Dan Gora wrote: >> Add an inline accessor function to return the starting address of >> the private data area in the supplied mbuf. >> >> If the user did not allocate space for a private data area in the >> mb

[dpdk-dev] DPDK checkpatch and SPDX tags?

2018-06-08 Thread Stephen Hemminger
What ever happened to my patch to fix the DPDK checkpatch wrapper ignore fields? Is the build bot using current version? Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/40880 _coding style issues_ WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in l

Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support

2018-06-08 Thread Wiles, Keith
> On Jun 8, 2018, at 9:59 AM, Stephen Hemminger > wrote: > > Since uuid functions may not be available everywhere, implement > uuid functions in DPDK. These are based off the BSD licensed > libuuid in util-link. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/bsdapp/eal/Makefile

[dpdk-dev] [PATCH 14/15] examples/l2fwd: use fprint instead of printf for usage print

2018-06-08 Thread Anoob Joseph
Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 05f9d28..3b697d1 100644 --- a/ex

[dpdk-dev] [PATCH 15/15] examples/l2fwd: improvements to the usage print

2018-06-08 Thread Anoob Joseph
Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 3b697d1

[dpdk-dev] [PATCH 13/15] examples/l2fwd: move pkt send code to a new function

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 9ba78f6..56e0bdb 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2

[dpdk-dev] [PATCH 10/15] examples/l2fwd: optimize check for master core

2018-06-08 Thread Anoob Joseph
Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index ee2de58..f73de

[dpdk-dev] [PATCH 11/15] examples/l2fwd: move periodic tasks to new function

2018-06-08 Thread Anoob Joseph
Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 83 --- examples/l2fwd/l2fwd_worker.h | 6 2 files changed, 52 insertions(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH 12/15] examples/l2fwd: skip timer updates for non master cores

2018-06-08 Thread Anoob Joseph
The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/examples/l2

[dpdk-dev] [PATCH 09/15] examples/l2fwd: move drain buffers to new function

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 8298005..ee2de58 100644 --- a/examples/l2fwd/l2fwd_worker.c ++

[dpdk-dev] [PATCH 08/15] examples/l2fwd: remove unused header includes

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 12 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 1f97911..8298005 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c @@ -13

Re: [dpdk-dev] [PATCH 3/7] net/sfc: disable for 32-bit builds

2018-06-08 Thread Andrew Rybchenko
On 06/08/2018 07:38 PM, Bruce Richardson wrote: The sfc driver is not supported on 32-bit so disable in meson in those cases. Signed-off-by: Bruce Richardson Acked-by: Andrew Rybchenko

  1   2   3   >