On 6/7/2018 10:43 AM, Michal Krawczyk wrote:
> From: Rafal Kozik <r...@semihalf.com>
>
> Link speed should is not limited to 10Gb/s and it shouldn't be hardcoded.
>
> They link speed is set to none instead and the applications shouldn't
> rely on this value when using ENA PMD.
Why not able to set link speed?
And what is the link_autoneg, ETH_LINK_FIXED? What is the point of setting link
speed FIXED and later speed value NONE?
>
> Fixes: 1173fca ("ena: add polling-mode driver")
For next time can you please use git alias to have consistent Fixes format
>
> Signed-off-by: Rafal Kozik <r...@semihalf.com>
> Acked-by: Michal Krawczyk <m...@semihalf.com>
> ---
> drivers/net/ena/ena_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 5c3b6494f..9ae73e331 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -848,7 +848,7 @@ static int ena_link_update(struct rte_eth_dev *dev,
> adapter = (struct ena_adapter *)(dev->data->dev_private);
>
> link->link_status = adapter->link_status ? ETH_LINK_UP : ETH_LINK_DOWN;
> - link->link_speed = ETH_SPEED_NUM_10G;
> + link->link_speed = ETH_SPEED_NUM_NONE;
> link->link_duplex = ETH_LINK_FULL_DUPLEX;
>
> return 0;
>
