Re: [dpdk-dev] [PATCH] net/mlx5: fix port dead lock when port shutdown

2018-05-24 Thread Xueming(Steven) Li
Please bypass this patch, new patch submitted at: http://www.dpdk.org/dev/patchwork/patch/40412/ > -Original Message- > From: Xueming(Steven) Li > Sent: Friday, May 25, 2018 2:04 PM > To: Yongseok Koh > Cc: Shahaf Shuler ; dev@dpdk.org; Adrien Mazarguil > > Subject: RE: [PATCH]

Re: [dpdk-dev] [PATCH] net/mlx5: fix memory region cache init

2018-05-24 Thread Xueming(Steven) Li
Hi Shahaf, Please note that this patch depends on Adrien's patch: http://dpdk.org/dev/patchwork/patch/40404/ > -Original Message- > From: Xueming Li > Sent: Friday, May 25, 2018 2:36 PM > To: Shahaf Shuler ; Yongseok Koh > Cc: Xueming(Steven) Li ; dev@dpdk.org > Subject: [PATCH]

[dpdk-dev] [PATCH] net/mlx5: fix memory region cache init

2018-05-24 Thread Xueming Li
This patch moved MR cache init from device configuration function to probe function to make sure init only once. Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") Cc: ys...@mellanox.com Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5.c| 11 +++ drivers/net/mlx5

Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro

2018-05-24 Thread Andrew Rybchenko
On 05/25/2018 04:20 AM, Yongseok Koh wrote: Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html Signed-off-by: Yongseok Koh --- v2: * modify removal deadline and add more comments in the deprecation note * mark deprecation on the comment of the macro in rte_mbuf.h doc/guides/rel_no

[dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide

2018-05-24 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- doc/guides/nics/virtio.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 8922f9c0b..a42d1bb30 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -234,7 +23

Re: [dpdk-dev] [PATCH] net/mlx5: fix port dead lock when port shutdown

2018-05-24 Thread Xueming(Steven) Li
> -Original Message- > From: Yongseok Koh > Sent: Friday, May 25, 2018 2:30 AM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org; Adrien Mazarguil > > Subject: Re: [PATCH] net/mlx5: fix port dead lock when port shutdown > > > > On May 24, 2018, at 8:20 AM, Xueming Li wrote

[dpdk-dev] [PATCH] lib/librte_rawdev: fix compile error when using sanitizer

2018-05-24 Thread Liu Hongbo
Otherwise, make will report the following error: rte_rawdevs is not flagged as experimental but is listed in version map By command: EXTRA_CFLAGS="-fsanitize=address" make Fixes: c88b3f2558 ("rawdev: introduce raw device library") Cc: shreyansh.j...@nxp.com Signed-off-by: Liu Hongbo ---

Re: [dpdk-dev] [PATCH V2] librte_hash: new hash del abi to return stored value

2018-05-24 Thread Honnappa Nagarahalli
Hi Yipeng, Can you please elaborate on the read-write concurrency changes you are making? I am looking at few changes myself, want to see how we can align. Issues that I am looking at are: 1) The delete APIs are not multithread safe - from writers perspective 2) Memory ordering between wr

[dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro

2018-05-24 Thread Yongseok Koh
Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html Signed-off-by: Yongseok Koh --- v2: * modify removal deadline and add more comments in the deprecation note * mark deprecation on the comment of the macro in rte_mbuf.h doc/guides/rel_notes/deprecation.rst | 7 +++ lib/librte_mbu

[dpdk-dev] [PATCH] doc: announce removal of indirect mbuf check macro

2018-05-24 Thread Yongseok Koh
Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html Signed-off-by: Yongseok Koh --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 1e2443c76..44da16445 10064

Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional limitation

2018-05-24 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, May 25, 2018 1:06 AM > To: Varghese, Vipin > Cc: dev@dpdk.org; Zhang, Qi Z ; Kovacevic, Marko > ; Jain, Deepak K ; > Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v1] doc/eth: update document for

Re: [dpdk-dev] [PATCH v1] net/tap: fix keep-alive queue not detached

2018-05-24 Thread Wiles, Keith
> On May 24, 2018, at 6:10 PM, Ophir Munk wrote: > > The TAP keep-alive queue was created in order to keep the TAP device > in Linux even in case all of its Rx/Tx queues are released (in Linux > terminology: even in case all of the TAP device file descriptors are > closed), however, the keep-al

[dpdk-dev] [PATCH v1] net/tap: fix keep-alive queue not detached

2018-05-24 Thread Ophir Munk
The TAP keep-alive queue was created in order to keep the TAP device in Linux even in case all of its Rx/Tx queues are released (in Linux terminology: even in case all of the TAP device file descriptors are closed), however, the keep-alive queue itself is attached to the TAP device like all other R

Re: [dpdk-dev] [PATCH] gitignore: ignore top level build/ directory

2018-05-24 Thread Stephen Hemminger
On Tue, 22 May 2018 23:45:31 +0200 Thomas Monjalon wrote: > 19/12/2016 18:14, Bruce Richardson: > > On Mon, Dec 19, 2016 at 04:50:57PM +, Mcnamara, John wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > > > On Mon, Dec 19, 2016 at 03:05:20PM +0100, Tho

Re: [dpdk-dev] [dpdk-stable] [PATCH] eventdev: fix eth port in eth Rx adapter internal function

2018-05-24 Thread Thomas Monjalon
23/05/2018 07:51, Jerin Jacob: > -Original Message- > > Date: Wed, 23 May 2018 02:36:42 +0530 > > From: Nikhil Rao > > To: jerin.ja...@caviumnetworks.com > > CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org > > Subject: [PATCH] eventdev: fix eth port in eth Rx adapter internal function > > X

Re: [dpdk-dev] [PATCH] doc: add kernel version deprecation notice

2018-05-24 Thread Thomas Monjalon
There was no decision about changing the kernel requirements. We need to restart the discussion and take a decision for the beginning of 18.08 cycle. Decision can be taken in technical board (Cc). 14/02/2018 12:44, Bruce Richardson: > On Wed, Feb 14, 2018 at 10:54:44AM +, Luca Boccassi wrote:

Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling from x86

2018-05-24 Thread Thomas Monjalon
24/05/2018 19:16, Jerin Jacob: > From: Thomas Monjalon > > 24/05/2018 13:17, Jerin Jacob: > > > From: Gavin Hu > > > > doc/cross_compiling_sdk.txt | 58 > > > > + > > > > > > I think, instead of keeping it as a orphan document, IMO, it should > > > l

Re: [dpdk-dev] Critical fixes for next-net-mlx

2018-05-24 Thread Shahaf Shuler
Thursday, May 24, 2018 7:56 PM, Ferruh Yigit: > Subject: Re: Critical fixes for next-net-mlx > > On 5/24/2018 3:11 PM, Shahaf Shuler wrote: > > Hi Ferruh, > > > > In next-net-mlx and for “next-net” there are several critical fixes: > > * fecb5cb net/mlx4: drop support in Mellanox OFED 4.2 Small do

Re: [dpdk-dev] [PATCH V2] librte_hash: new hash del abi to return stored value

2018-05-24 Thread Guvva, Vijaya
Hi Yipeng, Sure, It will be great help if you can include these changes in the patches you are proposing with the necessary locks. Thanks, Vijay -Original Message- From: Wang, Yipeng1 Sent: Thursday, May 24, 2018 10:47 AM To: De Lara Guarch, Pablo ; Guvva, Vijaya ; Richardson, Bruce

Re: [dpdk-dev] [PATCH] net/mlx5: fix port dead lock when port shutdown

2018-05-24 Thread Yongseok Koh
> On May 24, 2018, at 11:29 AM, Yongseok Koh wrote: > >> >> On May 24, 2018, at 8:20 AM, Xueming Li wrote: >> >> This patch add check to avoid init device MR data twcie which caused >> priv data linked to itself in list. > > A typo. > >> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region

Re: [dpdk-dev] [PATCH] net/mlx5: fix crash when configure is not called

2018-05-24 Thread Yongseok Koh
> On May 24, 2018, at 11:21 AM, Yongseok Koh wrote: > > >> On May 24, 2018, at 7:36 AM, Adrien Mazarguil >> wrote: >> >> Although uncommon, applications may destroy a device immediately after >> probing it without going through dev_configure() first. >> >> This patch addresses a crash which

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix errno object in probe code (minor)

2018-05-24 Thread Yongseok Koh
> On May 24, 2018, at 5:17 AM, Adrien Mazarguil > wrote: > > Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") > Cc: Nélio Laranjeiro > > Signed-off-by: Adrien Mazarguil > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing errno in probe code (minor)

2018-05-24 Thread Yongseok Koh
> On May 24, 2018, at 5:17 AM, Adrien Mazarguil > wrote: > > Fixes: b43802b4bdfe ("net/mlx5: support 16 hardware priorities") > Cc: Xueming Li > > Signed-off-by: Adrien Mazarguil > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH] net/mlx5: fix port dead lock when port shutdown

2018-05-24 Thread Yongseok Koh
> On May 24, 2018, at 8:20 AM, Xueming Li wrote: > > This patch add check to avoid init device MR data twcie which caused > priv data linked to itself in list. A typo. > Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") > Cc: ys...@mellanox.com > > Signed-off-by: Xueming Li > -

Re: [dpdk-dev] [PATCH] net/mlx5: fix crash when configure is not called

2018-05-24 Thread Yongseok Koh
> On May 24, 2018, at 7:36 AM, Adrien Mazarguil > wrote: > > Although uncommon, applications may destroy a device immediately after > probing it without going through dev_configure() first. > > This patch addresses a crash which occurs when mlx5_dev_close() calls > mlx5_mr_release() due to an

Re: [dpdk-dev] [PATCH] net/qede: fix slow path completion timeout

2018-05-24 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, May 24, 2018 10:22 AM > > On 5/23/2018 7:48 PM, Rasesh Mody wrote: > > From: Shahed Shaikh > > > > In 100G mode, we poll firmware slow path completion for every 1 > > second, which is not enough and may result in c

[dpdk-dev] [PATCH v2] net/mlx5: fix GRE flow rule

2018-05-24 Thread Yongseok Koh
Creating a flow having pattern from the middle of a packet is allowed. For example, testpmd> flow create 0 ingress pattern vxlan vni is 20 / end actions ... Device can parse GRE protocol number in outer IP header but specifying from GRE header can't differentiate it from VxLAN tunnel. As a resu

Re: [dpdk-dev] [PATCH V2] librte_hash: new hash del abi to return stored value

2018-05-24 Thread Wang, Yipeng1
Hi, Vijaya, Thanks for contributing the new API. We actually have a patch to support read-write concurrency for rte_hash coming in a couple of weeks. The new del function you proposed may need to be protected under the new concurrency scheme as well. If you like, we could collaborate togethe

Re: [dpdk-dev] rte_hash thread safe

2018-05-24 Thread Wang, Yipeng1
Hi, Brijesh and all, Thanks for bringing this up. We actually have a read-write concurrency support patch coming in a couple of weeks for rte_hash aiming this release. More changes are on the way for future releases. :) Thanks Yipeng >-Original Message- >From: dev [mailto:dev-boun...

Re: [dpdk-dev] [PATCH] net/qede: fix slow path completion timeout

2018-05-24 Thread Ferruh Yigit
On 5/23/2018 7:48 PM, Rasesh Mody wrote: > From: Shahed Shaikh > > In 100G mode, we poll firmware slow path completion for every 1 second, > which is not enough and may result in completion timeout if > driver misses that window. > > Patch "eal: set affinity for control threads" exposed this iss

Re: [dpdk-dev] [PATCH] net/cxgbe: report configured link auto-negotiation

2018-05-24 Thread Ferruh Yigit
On 5/23/2018 7:00 PM, Rahul Lakkireddy wrote: > Report current configured link auto-negotiation. Also initialize > rte_eth_link. > > Coverity issue: 280648 > Fixes: f5b3c7b29357 ("net/cxgbevf: fix inter-VM traffic when physical link > down") > > Signed-off-by: Rahul Lakkireddy Will postpone to

Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling from x86

2018-05-24 Thread Jerin Jacob
-Original Message- > Date: Thu, 24 May 2018 15:54:00 +0200 > From: Thomas Monjalon > To: Gavin Hu > Cc: dev@dpdk.org, Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross > compiling from x86 > > 24/05/2018 13:17, Jerin Jacob: > > -Original Message-

Re: [dpdk-dev] [PATCH] net/nfp: fix lock file usage

2018-05-24 Thread Alejandro Lucero
On Thu, May 24, 2018 at 5:30 PM, Ferruh Yigit wrote: > On 5/24/2018 4:39 PM, Alejandro Lucero wrote: > > > > > > On Thu, May 24, 2018 at 3:15 PM, Ferruh Yigit > > wrote: > > > > On 5/24/2018 3:13 PM, Ferruh Yigit wrote: > > > On 5/24/2018 3:02 PM, Alejandro

Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional limitation

2018-05-24 Thread Thomas Monjalon
23/05/2018 12:05, Vipin Varghese: > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1479,6 +1479,9 @@ int rte_eth_dev_attach(const char *devargs, uint16_t > *port_id); > * This function must be called when the device is in the > * closed state. > * > + * Not

Re: [dpdk-dev] [PATCH v2] doc: update contribution guideline for dependent work

2018-05-24 Thread Thomas Monjalon
09/01/2018 16:44, Ferruh Yigit: > +* If changes effect other parts of the project, update all those parts as > well unless updating requires special knowledge. > + For the cases where not all the effected code is updated, the submitter > should ensure that changes don't break existing code. We

Re: [dpdk-dev] Critical fixes for next-net-mlx

2018-05-24 Thread Ferruh Yigit
On 5/24/2018 3:11 PM, Shahaf Shuler wrote: > Hi Ferruh, > > In next-net-mlx and for “next-net” there are several critical fixes: > * fecb5cb net/mlx4: drop support in Mellanox OFED 4.2 > Small doc update to notify all users – this is for next-net. Documentation patches are accepted for rc6, ok fo

Re: [dpdk-dev] [PATCH v3 1/2] doc: add guidelines for coverity tags

2018-05-24 Thread Thomas Monjalon
13/02/2018 12:59, Ferruh Yigit: > On 1/16/2018 4:37 PM, Mcnamara, John wrote: > > > > > >> -Original Message- > >> From: Kovacevic, Marko > >> Sent: Tuesday, January 16, 2018 9:13 AM > >> To: dev@dpdk.org > >> Cc: Mcnamara, John ; Yigit, Ferruh > >> ; hemant.agra...@nxp.com; Kovacevic, Ma

Re: [dpdk-dev] [PATCH] net/nfp: fix lock file usage

2018-05-24 Thread Ferruh Yigit
On 5/24/2018 4:39 PM, Alejandro Lucero wrote: > > > On Thu, May 24, 2018 at 3:15 PM, Ferruh Yigit > wrote: > > On 5/24/2018 3:13 PM, Ferruh Yigit wrote: > > On 5/24/2018 3:02 PM, Alejandro Lucero wrote: > >> > >> > >> On Thu, May 24, 2018 at 11

[dpdk-dev] DPDK Release Status Meeting 24/05/2018

2018-05-24 Thread Mcnamara, John
The DPDK Release Status Meeting is mainly intended for DPDK Committers to discuss the status of the master and sub-trees. It is also intended as an update for project managers who need to track progress or milestone dates. The meeting occurs on Thursdays at 8:30 UTC. If you wish to attend just sen

Re: [dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2018-05-24 Thread Thomas Monjalon
23/05/2018 13:54, Raslan Darawsheh: > Signed-off-by: Raslan Darawsheh Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2018-05-24 Thread Thomas Monjalon
22/05/2018 11:34, Yulong Pei: > Add tested Intel platforms with Intel NICs to the release note. > > Signed-off-by: Yulong Pei Applied, thanks

Re: [dpdk-dev] [PATCH] doc: update qede guide and features

2018-05-24 Thread Ferruh Yigit
On 5/23/2018 1:09 AM, Rasesh Mody wrote: > Add LINUX VFIO support to feature list. > > Add GRE tunneling offload to supported feature list. > > Update firmware references to use newer FW imgae 8.33.12.0. Update > management FW version as well to 8.34.x.x. > > Signed-off-by: Rasesh Mody Applied

Re: [dpdk-dev] [PATCH] net/nfp: fix lock file usage

2018-05-24 Thread Alejandro Lucero
On Thu, May 24, 2018 at 3:15 PM, Ferruh Yigit wrote: > On 5/24/2018 3:13 PM, Ferruh Yigit wrote: > > On 5/24/2018 3:02 PM, Alejandro Lucero wrote: > >> > >> > >> On Thu, May 24, 2018 at 11:18 AM, Ferruh Yigit >> > wrote: > >> > >> On 5/23/2018 5:50 PM, Alejandr

[dpdk-dev] [PATCH] net/mlx5: fix port dead lock when port shutdown

2018-05-24 Thread Xueming Li
This patch add check to avoid init device MR data twcie which caused priv data linked to itself in list. Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") Cc: ys...@mellanox.com Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_ethdev.c | 2 ++ drivers/net/mlx5/mlx5_mr.c | 1

Re: [dpdk-dev] [RFC] hot plug failure handle mechanism

2018-05-24 Thread Matan Azrad
Hi Guo Some questions. From: Guo Jia > As we know, hot plug is an importance feature whenever it use for the > datacenter device's fail-safe and consumption management , or use for the > dynamic deployment and SRIOV Live Migration in SDN/NFV, it could be bring > the higher flexibility and contin

Re: [dpdk-dev] [PATCH] doc: drop support in Mellanox OFED 4.2

2018-05-24 Thread Ferruh Yigit
On 5/24/2018 2:47 PM, Shahaf Shuler wrote: > Signed-off-by: Shahaf Shuler Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] doc: remove deprecated terms from liquidio documentation

2018-05-24 Thread Ferruh Yigit
On 5/23/2018 6:35 PM, Shijith Thotton wrote: > Remove reference to deprecated ethdev offload parameter from liquidio > documentation. > > Fixes: dd6aab16711c ("net/liquidio: move to new offload API") > > Signed-off-by: Shijith Thotton Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] doc: remove deprecated terms from thunderx documentation

2018-05-24 Thread Ferruh Yigit
On 5/24/2018 3:36 PM, Ferruh Yigit wrote: > On 5/24/2018 9:08 AM, Jerin Jacob wrote: >> Remove reference to deprecated ethdev offload parameter from thunderx >> documentation. >> >> Fixes: c97da2cbc2c2 ("net/thunderx: convert to new offload API") >> Cc: sta...@dpdk.org >> Signed-off-by: Jerin Jacob

[dpdk-dev] [PATCH] net/mlx5: fix crash when configure is not called

2018-05-24 Thread Adrien Mazarguil
Although uncommon, applications may destroy a device immediately after probing it without going through dev_configure() first. This patch addresses a crash which occurs when mlx5_dev_close() calls mlx5_mr_release() due to an uninitialized entry in the private structure. Fixes: 974f1e7ef146 ("net/

Re: [dpdk-dev] [PATCH 1/2] doc: remove deprecated terms from thunderx documentation

2018-05-24 Thread Ferruh Yigit
On 5/24/2018 9:08 AM, Jerin Jacob wrote: > Remove reference to deprecated ethdev offload parameter from thunderx > documentation. > > Fixes: c97da2cbc2c2 ("net/thunderx: convert to new offload API") > Cc: sta...@dpdk.org > Signed-off-by: Jerin Jacob Series applied to dpdk-next-net/master, thanks

Re: [dpdk-dev] [PATCH 1/2] doc/ixgbe: convert to new offload API

2018-05-24 Thread Ferruh Yigit
On 5/23/2018 3:56 AM, Qi Zhang wrote: > Cleanup document to convert old rxmode flags to new offload > bit mask. > > Signed-off-by: Qi Zhang Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/nfp: fix lock file usage

2018-05-24 Thread Ferruh Yigit
On 5/24/2018 3:13 PM, Ferruh Yigit wrote: > On 5/24/2018 3:02 PM, Alejandro Lucero wrote: >> >> >> On Thu, May 24, 2018 at 11:18 AM, Ferruh Yigit > > wrote: >> >> On 5/23/2018 5:50 PM, Alejandro Lucero wrote: >> > >> > >> > On Wed, May 23, 2018 at 4:

Re: [dpdk-dev] [PATCH] net/nfp: fix lock file usage

2018-05-24 Thread Ferruh Yigit
On 5/24/2018 3:02 PM, Alejandro Lucero wrote: > > > On Thu, May 24, 2018 at 11:18 AM, Ferruh Yigit > wrote: > > On 5/23/2018 5:50 PM, Alejandro Lucero wrote: > > > > > > On Wed, May 23, 2018 at 4:57 PM, Ferruh Yigit

[dpdk-dev] Critical fixes for next-net-mlx

2018-05-24 Thread Shahaf Shuler
Hi Ferruh, In next-net-mlx and for "next-net" there are several critical fixes: * fecb5cb net/mlx4: drop support in Mellanox OFED 4.2 Small doc update to notify all users - this is for next-net. * 995b985 net/mlx5: fix generic tunnel offloading compatibility check w/o it we cannot compile on R

Re: [dpdk-dev] [PATCH] net/nfp: fix lock file usage

2018-05-24 Thread Alejandro Lucero
On Thu, May 24, 2018 at 11:18 AM, Ferruh Yigit wrote: > On 5/23/2018 5:50 PM, Alejandro Lucero wrote: > > > > > > On Wed, May 23, 2018 at 4:57 PM, Ferruh Yigit > > wrote: > > > > On 5/23/2018 1:28 PM, Alejandro Lucero wrote: > > > DPDK apps can be executed

Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling from x86

2018-05-24 Thread Thomas Monjalon
24/05/2018 13:17, Jerin Jacob: > -Original Message- > > Date: Wed, 23 May 2018 23:38:47 -0400 > > From: Gavin Hu > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling > > from x86 > > X-Mailer: git-send-email 2.1.4 > > > > Signed-off-by: Gavin

[dpdk-dev] [PATCH] doc: drop support in Mellanox OFED 4.2

2018-05-24 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx4.rst | 2 +- doc/guides/rel_notes/release_18_05.rst | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst index a6317547a0..491106a929 100644 --- a/doc/guides/nics

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] mk: fix cross build errors

2018-05-24 Thread Thomas Monjalon
24/05/2018 05:38, Gavin Hu: > +ifeq ($(shell test $(USE_HOST) -e 1 && test $(HOST_GCC_VERSION) -gt 70 && > echo 1), 1) I think there is an error above. -e should be -eq, isn't it?

Re: [dpdk-dev] [PATCH] net/nfp: remove reference to old offload API

2018-05-24 Thread Ferruh Yigit
On 5/23/2018 4:52 PM, Ferruh Yigit wrote: > On 5/23/2018 11:14 AM, Alejandro Lucero wrote: >> This was missed in a previous patch for using new offload API. >> >> It turns out the line can be removed because that internal PMD >> crc_len data is not being used. >> >> Fixes: a922c6a789ff ("net/nfp: s

Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling from x86

2018-05-24 Thread Bruce Richardson
On Thu, May 24, 2018 at 04:47:56PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Wed, 23 May 2018 23:38:47 -0400 > > From: Gavin Hu > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling > > from x86 > > X-Mailer: git-send-email 2.1.4

[dpdk-dev] [PATCH v3] baseband/turbo_sw: internal buffers names changed

2018-05-24 Thread Kamil Chalupnik
Internal buffers names have been shortened to meet ring names size requirements after device name changed. Fixes: 7ce00bf31bbe ("bbdev: change names of baseband devices") Signed-off-by: Kamil Chalupnik Acked-by: Amr Mokhtar --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 10 +-

Re: [dpdk-dev] [PATCH v2] doc: add note for MAX QUEUES macro in vhost sample

2018-05-24 Thread Maxime Coquelin
On 05/24/2018 02:05 PM, Xiao Wang wrote: If the NIC has a queue number larger than 128, then we need to change the ``MAX_QUEUES`` to a larger number to make sure we allocate a big enough memory pool for device setup. Signed-off-by: Xiao Wang Acked-by: Maxime Coquelin Acked-by: Marko Kovacevi

Re: [dpdk-dev] [PATCH v2] net/virtio: fix add pointer checking for rxvq

2018-05-24 Thread Maxime Coquelin
On 05/24/2018 05:51 PM, zhiyong.y...@intel.com wrote: For virtio-user server mode, one use case comes across segmentation fault. step 1: Launch vhost side as client firstly. step 2: launch virtio-user side as server. The cause is: after registering virtio_interrupt_handler into eal-intr-thread

[dpdk-dev] [PATCH 2/2] net/mlx5: fix missing errno in probe code (minor)

2018-05-24 Thread Adrien Mazarguil
Fixes: b43802b4bdfe ("net/mlx5: support 16 hardware priorities") Cc: Xueming Li Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index bbe78de28..36d72f757 100644 --- a/drivers/net/m

[dpdk-dev] [PATCH 1/2] net/mlx5: fix errno object in probe code (minor)

2018-05-24 Thread Adrien Mazarguil
Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Cc: Nélio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 8d1c2347e..bbe78de2

[dpdk-dev] [PATCH v2] doc: add note for MAX QUEUES macro in vhost sample

2018-05-24 Thread Xiao Wang
If the NIC has a queue number larger than 128, then we need to change the ``MAX_QUEUES`` to a larger number to make sure we allocate a big enough memory pool for device setup. Signed-off-by: Xiao Wang Acked-by: Maxime Coquelin Acked-by: Marko Kovacevic --- v2: - Fix unexpected indentation warni

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix generic tunnel offloading compatibility check

2018-05-24 Thread Shahaf Shuler
Thursday, May 24, 2018 8:46 AM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: fix generic tunnel offloading compatibility > check > > > > On May 23, 2018, at 10:28 PM, Shahaf Shuler > wrote: > > > > On some distros, the inbox rdma-core tree can contain the Software > > Parser enum while the

Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling from x86

2018-05-24 Thread Jerin Jacob
-Original Message- > Date: Wed, 23 May 2018 23:38:47 -0400 > From: Gavin Hu > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling > from x86 > X-Mailer: git-send-email 2.1.4 > > Signed-off-by: Gavin Hu > Reviewed-by: Steve Capper > Reviewed-by: H

[dpdk-dev] [PATCH v2] doc/compress: add compression level guide for ISA-L

2018-05-24 Thread Lee Daly
This expands the ISA-L documentation to give more a detailed explanation of the mapping between the compressdev API levels and PMD levels. Signed-off-by: Lee Daly Acked-by: Marko Kovacevic

[dpdk-dev] [PATCH] doc/ip_pipeline: update sample app user guide

2018-05-24 Thread Jasvinder Singh
Update sample app user guide with ip pipeline documentation. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- doc/guides/sample_app_ug/ip_pipeline.rst | 1448 +- 1 file changed, 403 insertions(+), 1045 deletions(-)

Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling from x86

2018-05-24 Thread Kovacevic, Marko
Auto spell corrected my text Spelling: ohter / other > > +2. Unzip and add into the PATH > > +-- > > +$ tar -xvf gcc-linaro-7.2.1-2017.11-x86_64_aarch64-linux-gnu.tar.xz > > +$ export PATH=$PATH: > +dir>/gcc-linaro-7.2.1-2017.11-x86_64_aarch64-linux-gnu/bin > > +Note:

Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling from x86

2018-05-24 Thread Kovacevic, Marko
> Signed-off-by: Gavin Hu > Reviewed-by: Steve Capper > Reviewed-by: Honnappa Nagarahalli > --- > doc/cross_compiling_sdk.txt | 58 > + > 1 file changed, 58 insertions(+) > create mode 100644 doc/cross_compiling_sdk.txt > <...> > + > +2. Unzip an

Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: internal buffers names changed

2018-05-24 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Thursday 24 May 2018 10:20 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [PATCH v2] baseband/turbo_sw: internal buffers names changed > > Internal buffers names have been shortened t

Re: [dpdk-dev] [PATCH] doc: add note for MAX QUEUES macro in vhost sample

2018-05-24 Thread Kovacevic, Marko
> If the NIC has a queue number larger than 128, then we need to change the > ``MAX_QUEUES`` to a larger number to make sure we allocate a big enough > memory pool for device setup. > > Signed-off-by: Xiao Wang > --- > doc/guides/sample_app_ug/vhost.rst | 10 ++ > 1 file changed, 10 inse

Re: [dpdk-dev] [PATCH] net/nfp: fix lock file usage

2018-05-24 Thread Ferruh Yigit
On 5/23/2018 5:50 PM, Alejandro Lucero wrote: > > > On Wed, May 23, 2018 at 4:57 PM, Ferruh Yigit > wrote: > > On 5/23/2018 1:28 PM, Alejandro Lucero wrote: > > DPDK apps can be executed as non-root users but current NFP lock > > file for avoiding conc

Re: [dpdk-dev] [PATCH] eal: deprecate function to set default mbuf pool

2018-05-24 Thread Hemant Agrawal
> Deprecate rte_eal_mbuf_default_mempool_ops(), it shall be replaced by > rte_mbuf_best_mempool_ops(). > > Cc: Hemant Agrawal > Cc: Jerin Jacob > > Signed-off-by: Olivier Matz Acked-by: Jerin Jacob Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] eal: deprecate function to set default mbuf pool

2018-05-24 Thread Jerin Jacob
-Original Message- > Date: Thu, 24 May 2018 11:44:07 +0200 > From: Olivier Matz > To: dev@dpdk.org > CC: Hemant Agrawal , Jerin Jacob > > Subject: [PATCH] eal: deprecate function to set default mbuf pool > X-Mailer: git-send-email 2.11.0 > > Deprecate rte_eal_mbuf_default_mempool_ops(),

[dpdk-dev] [PATCH] eal: deprecate function to set default mbuf pool

2018-05-24 Thread Olivier Matz
Deprecate rte_eal_mbuf_default_mempool_ops(), it shall be replaced by rte_mbuf_best_mempool_ops(). Cc: Hemant Agrawal Cc: Jerin Jacob Signed-off-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst| 4 ++-- lib/librte_eal/common/include/rte_eal.h | 2 ++ 2 files changed, 4 insertions

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2018-05-24 Thread Andriy Berestovskyy
Hi Shahaf, > On 23 May 2018, at 07:21, Shahaf Shuler wrote: > I think this patch addressing just small issue in a bigger problem. > The way I see it all application needs to specify is the max packet size it > expects to receive, nothing else(!). [...] > IMO The "jumbo_frame" bit can be set b

[dpdk-dev] [PATCH v2] baseband/turbo_sw: internal buffers names changed

2018-05-24 Thread Kamil Chalupnik
Internal buffers names have been shortened to meet ring names size requirements after device name changed. Signed-off-by: Kamil Chalupnik --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/turbo_sw/

Re: [dpdk-dev] [PATCH] doc/compress: add compression level guide for ISA-L

2018-05-24 Thread Kovacevic, Marko
> This expands the ISA-L documentation to give more a detailed explanation of > the mapping between the compressdev API levels and PMD levels. > > Signed-off-by: Lee Daly > --- > doc/guides/compressdevs/isal.rst | 63 > +++- > 1 file changed, 55 insertions(+),

[dpdk-dev] [PATCH v2] net/virtio: fix add pointer checking for rxvq

2018-05-24 Thread zhiyong . yang
For virtio-user server mode, one use case comes across segmentation fault. step 1: Launch vhost side as client firstly. step 2: launch virtio-user side as server. The cause is: after registering virtio_interrupt_handler into eal-intr-thread, two threads (main thread and eal-intr-thread) have sync

[dpdk-dev] [PATCH 1/2] doc: remove deprecated terms from thunderx documentation

2018-05-24 Thread Jerin Jacob
Remove reference to deprecated ethdev offload parameter from thunderx documentation. Fixes: c97da2cbc2c2 ("net/thunderx: convert to new offload API") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- doc/guides/nics/thunderx.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --gi

[dpdk-dev] [PATCH 2/2] doc: remove deprecated terms from octeontx documentation

2018-05-24 Thread Jerin Jacob
Remove reference to deprecated ethdev offload parameter from octeontx documentation. Fixes: a92870896b4a ("net/octeontx: use the new offload APIs") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- doc/guides/nics/octeontx.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH] baseband/turbo_sw: internal buffers names changed

2018-05-24 Thread Kamil Chalupnik
Internal buffers names have been shortened to meet ring names size requirements after device name changed. Signed-off-by: Kamil Chalupnik --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/turbo_sw/bbdev

Re: [dpdk-dev] [PATCH] net/virtio-user: fix add pointer checking for rxvq

2018-05-24 Thread Maxime Coquelin
Hi, I would use net/virtio prefix instead, as IIUC, the impacted code can also be called by Virtio PMD. On 05/24/2018 03:04 PM, zhiyong.y...@intel.com wrote: For virtio-user server mode, One use case comes across segmentation fault. step 1: Launch vhost side as client firstly. step 2: launch vi

Re: [dpdk-dev] [PATCH] doc: add note for MAX QUEUES macro in vhost sample

2018-05-24 Thread Maxime Coquelin
On 05/24/2018 08:11 AM, Xiao Wang wrote: If the NIC has a queue number larger than 128, then we need to change the ``MAX_QUEUES`` to a larger number to make sure we allocate a big enough memory pool for device setup. Signed-off-by: Xiao Wang --- doc/guides/sample_app_ug/vhost.rst | 10 ++