Hi Vipin,
Thanks for the patch, I have a suggestion below.
On 5/17/2018 1:49 PM, Vipin Varghese wrote:
rte_event_eth_rx_adapter_create allocates eth_devices for currently
available eth devices. For dynamically created eth devices a new instance
for rx adapter has to be created.
Signed-off-by:
Hi Vipin,
Thanks for the patch, looks good overall, a few comments below
On 5/17/2018 3:47 PM, Vipin Varghese wrote:
Add a new test to enhance the test suite, to allow multiple eth
ports rx queue to be added to rx bridge adapter. Update the test
to allow rx queues from multiple ports to be add
Change adds extra information on name parameter for API
rte_eth_dev_get_name_by_port and rte_eth_dev_get_port_by_name.
Signed-off-by: Vipin Varghese
---
lib/librte_ethdev/rte_ethdev.h | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib
Thanks you for the corrections, I had sent the diff from the wrong folder. Will
be sending out V2 for the corrected one.
> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, May 17, 2018 6:03 PM
> To: Varghese, Vipin ; dev@dpdk.org; Mcnamara,
> John ; Daly, Lee ; Jain,
> Deepak K
> -Original Message-
> From: Yang, Zhiyong
> Sent: Friday, May 18, 2018 6:00 PM
> To: dev@dpdk.org
> Cc: maxime.coque...@redhat.com; Yigit, Ferruh ;
> Bie, Tiwei ; Yao, Lei A ;
> Iremonger, Bernard ; sta...@dpdk.org;
> Yang, Zhiyong
> Subject: [PATCH v2] app/testpmd: fix pmd_test_exit fu
> -Original Message-
> From: Li, Xiaoyun
> Sent: Thursday, May 17, 2018 7:24 PM
> To: Wu, Jingjing ; Lu, Wenzhuo
> Cc: dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org
> Subject: [PATCH] net/avf: fix AVF traffic blocked issue
>
> When resetting ports, traffic will be blocked. There is a mist
> -Original Message-
> From: Yang, Qiming
> Sent: Thursday, May 17, 2018 9:23 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing ; Lu, Wenzhuo ;
> Yang,
> Qiming ; sta...@dpdk.org
> Subject: [PATCH] net/ixgbe: fix dcb configuration issue
>
> This patch removed unnecessary check in ixgbe_check_mq_
Hi all,
I'm using OVS2.8.0+DPDK17.05+Intel_82599_IXGBE for test, the vf driver is
ixgbevf-4.0.3.
I use sriov follow like this:
echo 1 > /sys/bus/pci/devices/:01:00.0/max_vfs
Then test l3fwd-vf demo, it is OK.
Then test OVS2.8.0, and assign pf for ovs like this:
ovs-vsctl add-port br_t dpdk-
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org]
> Sent: Friday, May 18, 2018 5:52 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z ; Yang, Qiming
> ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue
>
> This patch removed unnecessary check
eth_dev_last_created_port is used to store port id type and should
be extended to 16bits corresponding to ethdev port id range.
Cc: sta...@dpdk.org
Cc: ferruh.yi...@intel.com
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang
---
lib/librte_ethdev/rte_ethdev.c |
> -Original Message-
> From: Guo, Jia
> Sent: Friday, May 18, 2018 10:05 AM
> To: Zhang, Qi Z ; Xing, Beilei
> Cc: dev@dpdk.org; Guo, Jia
> Subject: [PATCH] net/i40e: fix link up failure issue
>
> In case of the known issue, that DPDK PHY config can't synchronous with
> kernel driver and
For vdev, just calling rte_eth_dev_close() isn't enough to free all
the resources allocated during device probe, e.g. for virtio-user,
virtio_user_pmd_remove(), i.e. the remove() method of a vdev driver,
needs to be called to unlink the socket file created during device
probe. So this patch calls t
This patch removed unnecessary check in ixgbe_check_mq_mode,
fixed historical issue.
Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
drivers")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Yang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 10 --
1 file changed, 10 delet
In case of the known issue, that DPDK PHY config can't synchronous with
kernel driver and firmware, this will result of the nic can't link up
after rebind to the kernel driver. This patch propose to work around it
by don't config PHY and don't set link down when stop device.
Fixes: 6e145fcc754b ("
Hi, Maxime
Any idea for this performance drop? Will we improve it in this release
or it will be long term work? Thanks.
BRs
Lei
> -Original Message-
> From: Yao, Lei A
> Sent: Wednesday, May 2, 2018 8:10 PM
> To: Maxime Coquelin ; dev@dpdk.org
> Cc: Bie, Tiwei
> Subject: RE: [dpdk-dev]
In case of the known issue, that DPDK PHY config can't synchronous with
kernel driver and firmware, this will result of the nic can't link up
after rebind to the kernel driver. This patch propose to work around it
by don't config PHY and don't set link down when stop device.
Fixes: 6e145fcc754b ("
Hi Bruce,
> -Original Message-
> From: Richardson, Bruce
> Sent: Friday, May 18, 2018 4:15 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce ; Wang, Xiao W
>
> Subject: [PATCH-18.08 08/15] net/ifc: rename to ifcvf
>
> All files in the directory and the resulting driver have prefix of ifcvf,
I'll send v2 later.
> -Original Message-
> From: Zhang, Qi Z
> Sent: Thursday, May 17, 2018 9:19 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing ; Lu, Wenzhuo
> ; Yang, Qiming ;
> sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
>
> Hi Qiming
>
> > -O
The function rte_pci_probe_one is private to PCI and is
not used anywhere in current code base. Remove dead code.
Signed-off-by: Stephen Hemminger
---
drivers/bus/pci/pci_common.c | 38
drivers/bus/pci/private.h| 15 --
2 files changed, 53 del
Signed-off-by: Changpeng Liu
---
examples/vhost_scsi/vhost_scsi.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c
index 2908ff6..a1d542b 100644
--- a/examples/vhost_scsi/vhost_scsi.c
+++ b/examples/vhos
From: Chas Williams
rte_eth_bond_8023ad_slave_info() wasn't exported in the original work.
Useful to extract information about the current 802.3ad state.
Fixes: 46fb43683679 ("bond: add mode 4")
Cc: sta...@dpdk.org
Signed-off-by: Chas Williams
---
drivers/net/bonding/rte_pmd_bond_version.map
Signed-off-by: Changpeng Liu
---
examples/vhost_scsi/scsi.c | 23 ---
examples/vhost_scsi/vhost_scsi.c | 5 +++--
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c
index 0c2fa3e..1572098 100644
--- a
From: Chas Williams
When the first ETH_LINK_UP slave is added to a bonding device, it is
immediately activated. If these are polling slaves, there will be a
later link state event, when last_link_status doesn't match link_status.
But because this slave is already activated, the bonding device's
Signed-off-by: Bruce Richardson
---
CC: Tetsuya Mukawa
CC: Maxime Coquelin
---
drivers/net/meson.build | 2 +-
drivers/net/vhost/meson.build | 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/vhost/meson.build
diff --git a/drivers/net/meson.build
Signed-off-by: Bruce Richardson
---
CC: Jasvinder Singh
CC: Cristian Dumitrescu
---
drivers/net/meson.build| 3 ++-
drivers/net/softnic/Makefile | 2 +-
drivers/net/softnic/meson.build
Signed-off-by: Bruce Richardson
---
CC: Matej Vido
---
drivers/net/meson.build | 2 +-
drivers/net/szedata2/meson.build | 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/szedata2/meson.build
diff --git a/drivers/net/meson.build b/drivers/net/m
Signed-off-by: Bruce Richardson
---
CC: Alejandro Lucero
---
drivers/net/meson.build | 2 +-
drivers/net/nfp/meson.build | 16
2 files changed, 17 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/nfp/meson.build
diff --git a/drivers/net/meson.build b/drivers/ne
Signed-off-by: Bruce Richardson
---
CC: Ferruh Yigit
---
drivers/net/kni/meson.build | 6 ++
drivers/net/meson.build | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/kni/meson.build
diff --git a/drivers/net/kni/meson.build b/drivers/net/kni/meson.
Signed-off-by: Bruce Richardson
---
CC: Shijith Thotton
CC: Srisivasubramanian Srinivasan
---
drivers/net/liquidio/Makefile | 2 +-
drivers/net/liquidio/meson.build | 8
.../{rte_pmd_lio_version.map => rte_pmd_liquid
All files in the directory and the resulting driver have prefix of ifcvf,
not just ifc, so rename directory for accuracy. Also rename the map file
to standard name for meson build in the process.
Signed-off-by: Bruce Richardson
---
CC: Xiao Wang
---
MAINTAINERS
Signed-off-by: Bruce Richardson
---
CC: Xiao Wang
---
drivers/net/ifcvf/meson.build | 7 +++
drivers/net/meson.build | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/ifcvf/meson.build
diff --git a/drivers/net/ifcvf/meson.build b/drivers/net/ifcvf
Signed-off-by: Bruce Richardson
---
CC: Marcin Wojtas
CC: Michal Krawczyk
CC: Guy Tzalik
CC: Evgeny Schemeilin
---
drivers/net/ena/meson.build | 8
drivers/net/meson.build | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/ena/meson.build
d
Signed-off-by: Bruce Richardson
---
CC: Gaetan Rivet
---
drivers/net/failsafe/meson.build | 23 +++
drivers/net/meson.build | 2 +-
2 files changed, 24 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/failsafe/meson.build
diff --git a/drivers/net/failsa
Signed-off-by: Bruce Richardson
---
CC: Rahul Lakkireddy
---
drivers/net/cxgbe/meson.build | 11 +++
drivers/net/meson.build | 2 +-
2 files changed, 12 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/cxgbe/meson.build
diff --git a/drivers/net/cxgbe/meson.build b/dri
Signed-off-by: Bruce Richardson
---
CC: Ajit Khaparde
CC: Somnath Kotur
---
app/test-pmd/meson.build | 3 +++
drivers/net/bnxt/meson.build | 18 ++
drivers/net/meson.build | 2 +-
3 files changed, 22 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/bnxt/me
Signed-off-by: Bruce Richardson
---
CC: Harish Patil
CC: Rasesh Mody
---
drivers/net/bnx2x/meson.build | 14 ++
drivers/net/meson.build | 3 ++-
2 files changed, 16 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/bnx2x/meson.build
diff --git a/drivers/net/bnx2x/
Signed-off-by: Bruce Richardson
---
CC: Allain Legacy
CC: Matt Peters
---
drivers/net/avp/meson.build | 5 +
drivers/net/meson.build | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
create mode 100644 drivers/net/avp/meson.build
diff --git a/drivers/net/avp/meson.build b/dri
Signed-off-by: Bruce Richardson
---
CC: Shepard Siegel
CC: Ed Czeck
CC: John Miller
---
drivers/net/ark/meson.build | 13 +
drivers/net/meson.build | 3 ++-
2 files changed, 15 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/ark/meson.build
diff --git a/drivers/n
A number of net drivers require pretty minimal meson.build files to build
successfully with meson. This set adds support for 14 net drivers to the
build.
Bruce Richardson (15):
net/ark: add to meson build
net/avp: add to meson build
net/bnx2x: add to meson build
net/bnxt: add to meson buil
17/05/2018 18:16, Montorsi, Francesco:
> Hi all,
> I'd like to build DPDK on Centos 7.5... I found a commit
> (http://dpdk.org/browse/dpdk-stable/commit/?h=17.11&id=3ee847054cc9ab62fa2c9c6dc6ba68899d620e3a)
> that allows that, but it will go into DPDK 17.11.3 right?
> Is there a release date for
On Thu, May 17, 2018 at 07:39:12AM -0700, Stephen Hemminger wrote:
> On Thu, 17 May 2018 14:23:46 +0100
> Ferruh Yigit wrote:
>
> > On 5/16/2018 12:47 PM, Neil Horman wrote:
> > > On Tue, May 15, 2018 at 05:56:12PM +0100, Ferruh Yigit wrote:
> > >> When EFI secure boot is enabled, it is possibl
When the fail-safe device is reconfigured, it attempts to register
again for the sub-devices LSC and RMV events.
Prevent an event registration if it is already done.
Fixes: 598fb8aec6f6 ("net/failsafe: support device removal")
Cc: sta...@dpdk.org
Signed-off-by: Matan Azrad
---
drivers/net/fail
The fail-safe PMD registers to RMV event for each removable sub-device
port in order to cleanup the sub-device resources and switch the Tx
sub-device directly when it is plugged-out.
In the removal time, the fail-safe PMD stops and closes the sub-device
but it doesn't unregister the LSC and RMV ca
On Thu, May 17, 2018 at 02:26:12PM +0100, Ferruh Yigit wrote:
> On 5/17/2018 12:34 PM, Neil Horman wrote:
> > On Wed, May 16, 2018 at 03:42:20PM +0100, Ferruh Yigit wrote:
> >> When EFI secure boot is enabled, it is possible to lock down kernel and
> >> prevent accessing device BARs and this makes
Hi Adrien,
I like the idea of having one conversion function from dpdk to verbs and vice
versa.
I have some comments inline regarding the implementation.
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Tuesday, May 15, 2018 6:51 PM
> To: Shahaf Sh
On 5/16/2018 3:21 PM, Andrew Rybchenko wrote:
> From: Roman Zhukov
>
> The value of rte_errno must be positive in case of an error.
>
> Fixes: d77d07391d4d ("net/sfc: support flow API RSS action")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Roman Zhukov
> Signed-off-by: Andrew Rybchenko
Applied
On 5/15/2018 1:21 PM, Wiles, Keith wrote:
>
>
>> On May 10, 2018, at 12:30 PM, Ophir Munk wrote:
>>
>> Add RSS hash update callback to eth_dev_ops.
>>
>> Signed-off-by: Ophir Munk
>> ---
>> v1:
>> Initial release
>> v2:
>> typo fix
>>
>
> Acked by: Keith Wiles
Applied to dpdk-next-net/master,
On 5/10/2018 7:55 AM, Qi Zhang wrote:
> Add updates for runtime queue setup.
>
> Signed-off-by: Qi Zhang
Applied to dpdk-next-net/master, thanks.
I have developed a new open source software as a result of a scientific
research and I want to share my study with scientists and/or software
developers.
ThreadStack is an innovative software which produces a class library for
C++ multi-thread programming and the outcome of the ThreadStack acts as
> -Original Message-
> From: Kovacevic, Marko
> Sent: Wednesday, May 16, 2018 9:28 AM
> To: De Lara Guarch, Pablo ; Doherty, Declan
>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2] crypto/aesni_mb: fix capabilities
>
> > Missing AES-CMAC supported parameters
> > in PMD capabilities.
> >
>
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Wednesday, May 16, 2018 1:28 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ;
> tho...@monjalon.net; Jerin Jacob ;
> Doherty, Declan ; a...@warmcat.com;
> sta...@dpdk.org
> Subject: [dpdk-dev] [PAT
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Wednesday, May 16, 2018 1:28 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ;
> tho...@monjalon.net; Jerin Jacob ;
> Doherty, Declan ; a...@warmcat.com;
> sta...@dpdk.org
> Subject: [dpdk-dev] [PAT
Hi all,
I'd like to build DPDK on Centos 7.5... I found a commit
(http://dpdk.org/browse/dpdk-stable/commit/?h=17.11&id=3ee847054cc9ab62fa2c9c6dc6ba68899d620e3a)
that allows that, but it will go into DPDK 17.11.3 right?
Is there a release date for 17.11.3 already defined?
Thanks,
Francesco Mont
> -Original Message-
> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Pattan, Reshma
> Sent: Thursday, May 17, 2018 12:24 PM
> To: Rybalchenko, Kirill ; dev@dpdk.org
> Cc: sta...@dpdk.org; Rybalchenko, Kirill ;
> Zhang,
> Roy Fan
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATC
> -Original Message-
> From: Mokhtar, Amr
> Sent: Thursday, May 17, 2018 1:41 PM
> To: Chalupnik, KamilX ; De Lara Guarch, Pablo
>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] app/testbbdev: fix unchecked return value
>
>
> > -Original Message-
> > From: Chalupnik, KamilX
> > Sent
> -Original Message-
> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Wednesday, May 16, 2018 2:56 PM
> To: Zhang, Roy Fan ; dev@dpdk.org
> Cc: Rybalchenko, Kirill ; sta...@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] crypto/scheduler: fix p
On Thu, May 17, 2018 at 02:51:43PM +, Iremonger, Bernard wrote:
> Hi Adrien, Ferruh,
>
>
>
> > (Another patch will separate testpmd_flow.rst? and add maintainership for
> > it)
>
> There is also a lot of flow related code in dpdk/app/test-pmd/config.c (lines
> 985 to 1623), maybe this sh
Hi Yanglong:
> -Original Message-
> From: Wu, Yanglong
> Sent: Thursday, May 17, 2018 1:52 PM
> To: dev@dpdk.org
> Cc: Dai, Wei ; Zhang, Qi Z ; Wu,
> Yanglong
> Subject: [PATCH] net/ixgbe: fix VLAN strip setting fail for per port
>
> VLAN-strip should be set by both per port and per queu
Wednesday, May 16, 2018 7:21 PM, Adrien Mazarguil:
> Subject: [PATCH] net/mlx4: fix shifts of signed values
>
> This patch addresses the following issues reported by cppcheck:
>
> [drivers/net/mlx4/mlx4_rxtx.c:266]: (error) Shifting signed 32-bit value
> by 31 bits is undefined behaviour
>
Thursday, May 17, 2018 4:32 PM, Nélio Laranjeiro:
> Subject: Re: [PATCH] net/mlx5: fix default RSS level
>
> On Tue, May 15, 2018 at 04:23:24PM +0300, Shahaf Shuler wrote:
> > Using inner RSS by default for GRE leads to memory corruption as the
> > extra flow items added for the inner RSS are not
On Thu, May 17, 2018 at 07:40:16AM -0700, Stephen Hemminger wrote:
> On Thu, 17 May 2018 21:49:02 +0800
> Andy Green wrote:
>
> > In file included from ./dpdk/dpdk.c:88:
> > /projects/lagopus/src/dpdk/build/include/rte_string_fns.h: In
> > function 'rte_strlcpy':
> > /projects/lagopus/src/dpdk/bu
On 5/16/2018 2:24 PM, Andrew Rybchenko wrote:
> From: Ivan Malov
>
> Such a message could be generated by two places
> in the code, and there is a difference in the
> text albeit there is no difference in the meaning.
> These two messages must be the same so that
> automated error log comparison
On 5/16/2018 1:35 PM, Andrew Rybchenko wrote:
> Number of descriptors in equal stride super-buffer Rx mode defines
> number of packet buffers to be used. Each HW Rx descriptor has
> many packet buffers and the number depends on total size of mbuf
> and CONFIG_RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB value
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Helin
> Sent: Thursday, May 17, 2018 10:54 PM
> To: Li, Xiaoyun; Wu, Jingjing; Lu, Wenzhuo
> Cc: dev@dpdk.org; Li, Xiaoyun; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaoyun Li
> Sent: Thursday, May 17, 2018 7:24 PM
> To: Wu, Jingjing; Lu, Wenzhuo
> Cc: dev@dpdk.org; Li, Xiaoyun; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue
>
> When res
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Thursday, May 17, 2018 9:47 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Cc: Lu, Wenzhuo; Luo, Michael
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix too many interrupts
>
> > -Original Message-
Hi Adrien, Ferruh,
> (Another patch will separate testpmd_flow.rst? and add maintainership for it)
There is also a lot of flow related code in dpdk/app/test-pmd/config.c (lines
985 to 1623), maybe this should be moved to a separate file also, with
maintainership added for the new file?
Rega
On 5/17/2018 12:26 PM, Iremonger, Bernard wrote:
> Hi Adrien,
>
>
>
>
>> Subject: [PATCH] maintainers: fix responsibility of flow API
>> bits
>>
>> The following commits lack MAINTAINERS entries for this mess.
>>
>> Fixes: 4d73b6fb9907 ("doc: add generic flow API guide")
Hi Adrien,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil
> Sent: Wednesday, May 16, 2018 4:42 PM
> To: Yigit, Ferruh
> Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z
> Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: fix copy of raw flow item
>
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Tuesday, May 15, 2018 8:36 PM
> To: Xing, Beilei; Wu, Jingjing
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue
>
> > -Orig
On Thu, 17 May 2018 21:49:02 +0800
Andy Green wrote:
> In file included from ./dpdk/dpdk.c:88:
> /projects/lagopus/src/dpdk/build/include/rte_string_fns.h: In
> function 'rte_strlcpy':
> /projects/lagopus/src/dpdk/build/include/rte_string_fns.h:58:9:
> warning: conversion to 'size_t' {aka 'long u
On Thu, 17 May 2018 14:23:46 +0100
Ferruh Yigit wrote:
> On 5/16/2018 12:47 PM, Neil Horman wrote:
> > On Tue, May 15, 2018 at 05:56:12PM +0100, Ferruh Yigit wrote:
> >> When EFI secure boot is enabled, it is possible to lock down kernel and
> >> prevent accessing device BARs and this makes igb
Bernard,
Thanks for your review.
> -Original Message-
> From: Iremonger, Bernard
> Sent: Thursday, May 17, 2018 7:23 PM
> To: Yang, Zhiyong ; dev@dpdk.org
> Cc: maxime.coque...@redhat.com; Yigit, Ferruh ; Bie,
> Tiwei ; Yao, Lei A ; Yang, Zhiyong
>
> Subject: RE: [dpdk-dev] [PATCH] app/t
On Thu, May 17, 2018 at 10:17:04PM +0800, Andy Green wrote:
>
>
> On 05/17/2018 09:54 PM, Bruce Richardson wrote:
> > On Mon, May 14, 2018 at 01:10:43PM +0800, Andy Green wrote:
> > > Signed-off-by: Andy Green
> > > ---
> > > lib/librte_ethdev/rte_ethdev.h | 25 +++--
> >
On 05/17/2018 09:54 PM, Bruce Richardson wrote:
On Mon, May 14, 2018 at 01:10:43PM +0800, Andy Green wrote:
Signed-off-by: Andy Green
---
lib/librte_ethdev/rte_ethdev.h | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
While I dislike the changes below,
On 5/14/2018 11:46 PM, Wiles, Keith wrote:
>
>
>> On May 14, 2018, at 5:26 PM, Ophir Munk wrote:
>>
>> Running testpmd command "flow isolae 0" (i.e. disabling flow
>> isolation) followed by command "flow isolate 1" (i.e. enabling
>> flow isolation) may result in a TAP error:
>> PMD: Kernel ref
On 05/17/2018 09:55 PM, Bruce Richardson wrote:
On Thu, May 17, 2018 at 09:48:57PM +0800, Andy Green wrote:
Signed-off-by: Andy Green
---
What's the reason for this change of type?
I was asked to do it on the list... the original patch I sent was
triggered by gcc8 warnings and just caste
In file included from ./dpdk/dpdk.c:88:
/projects/lagopus/src/dpdk/build/include/rte_string_fns.h: In
function 'rte_strlcpy':
/projects/lagopus/src/dpdk/build/include/rte_string_fns.h:58:9:
warning: conversion to 'size_t' {aka 'long unsigned int'} from
'int' may change the sign of the result [-Wsig
On 5/17/2018 1:47 PM, Wiles, Keith wrote:
>
>
>> On May 17, 2018, at 2:44 AM, Pascal Mazon wrote:
>>
>> I have unfortunately no longer time enough for maintaining Tap PMD.
>> Keith has kindly volunteered to take over maintainership. He's been at
>> the origin of this PMD and knows well how it wo
On Thu, May 17, 2018 at 09:49:02PM +0800, Andy Green wrote:
> In file included from ./dpdk/dpdk.c:88:
> /projects/lagopus/src/dpdk/build/include/rte_string_fns.h: In
> function 'rte_strlcpy':
> /projects/lagopus/src/dpdk/build/include/rte_string_fns.h:58:9:
> warning: conversion to 'size_t' {aka 'l
On Thu, May 17, 2018 at 09:48:57PM +0800, Andy Green wrote:
> Signed-off-by: Andy Green
> ---
What's the reason for this change of type?
On Mon, May 14, 2018 at 01:10:43PM +0800, Andy Green wrote:
> Signed-off-by: Andy Green
> ---
> lib/librte_ethdev/rte_ethdev.h | 25 +++--
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
While I dislike the changes below, since I believe it's always more
readable to
On Thu, 2018-05-17 at 15:12 +0200, Thomas Monjalon wrote:
> 16/05/2018 19:03, Luca Boccassi:
> > On Wed, 2018-05-16 at 16:19 +0100, Kevin Traynor wrote:
> > > On 05/16/2018 03:31 PM, luca.bocca...@gmail.com wrote:
> > > > From: Luca Boccassi
> > > >
> > > > We have many stable branches being main
From: Luca Boccassi
We have many stable branches being maintained at the same time, and
sometimes it's not clear which branch a patch is being backported for.
Note in the guidelines that it should be specified via the cover letter,
annotation or using --subject-prefix.
Also note to send only to s
/projects/lagopus/src/dpdk/build/include/generic/
rte_byteorder.h: In function 'rte_constant_bswap16':
/projects/lagopus/src/dpdk/build/include/generic/
rte_byteorder.h:54:45: warning: conversion from
'int' to 'uint16_t' {aka 'short unsigned int'}
may change value [-Wconversion]
uint16_t)(v)
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h:
In function 'rte_eth_rx_burst':
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h:
3836:18: warning: conversion to 'int16_t' {aka 'short
int'} from 'uint16_t' {aka 'short unsigned int'} may
change the sign of the result [-Wsign-conversion]
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
In function 'rte_pktmbuf_detach':
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
1583:17: warning: conversion from 'uint32_t' {aka
'unsigned int'} to 'uint16_t' {aka
'short unsigned int'} may change value [-Wconversion]
m->priv_size = pri
/projects/lagopus/src/dpdk/build/include/rte_ip.h:
In function 'rte_ipv4_udptcp_cksum':
/projects/lagopus/src/dpdk/build/include/rte_byteorder.h:
51:24: warning: conversion from 'long unsigned int' to
'uint32_t' {aka 'unsigned int'} may change value
[-Wconversion]
#define rte_bswap16(x) ((uint16_t
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
In function 'rte_pktmbuf_detach':
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
1580:14: warning: conversion from 'long unsigned int'
to 'uint32_t' {aka 'unsigned int'} may change
value [-Wconversion]
mbuf_size = sizeof(struct rte_mbuf)
In file included from /projects/lagopus/src/dpdk/
build/include/rte_ether.h:24,
from /projects/lagopus/src/dpdk/
build/include/rte_ethdev.h:158,
from ./dpdk/worker.c:90:
/projects/lagopus/src/dpdk/build/include/rte_ip.h:
In function 'rte_raw_cksum_mbuf':
/projects/
/projects/lagopus/src/dpdk/build/include/rte_ip.h:
In function 'rte_ipv6_phdr_cksum':
/projects/lagopus/src/dpdk/build/include/rte_ip.h:
378:18: warning: conversion to 'uint32_t' {aka
'unsigned int'} from 'int' may change the sign of
the result [-Wsign-conversion]
psd_hdr.proto = (ipv6_hdr->proto
In file included from ./dpdk/worker.c:94:
/projects/lagopus/src/dpdk/build/include/rte_ip.h:
332:9: warning: conversion from 'uint32_t'
{aka 'unsigned int'} to 'uint16_t' {aka 'short
unsigned int'} may change value [-Wconversion]
return cksum;
^
/projects/lagopus/src/dpdk/build/incl
/projects/lagopus/src/dpdk/build/include/
rte_ip.h: In function 'rte_ipv4_cksum':
/projects/lagopus/src/dpdk/build/include/
rte_ip.h:256:35: warning: conversion from
'int' to 'uint16_t' {aka 'short unsigned int'}
may change value [-Wconversion]
return (cksum == 0x) ? cksum : ~cksum;
In file included from /projects/lagopus/src/dpdk/
build/include/rte_rwlock.h:12,
from ./mgr/lock.h:24,
from ./mgr/sock_io.c:54:
/projects/lagopus/src/dpdk/build/include/generic/
rte_rwlock.h: In function 'rte_rwlock_read_lock':
/projects/lagopus/src/dpdk/build/incl
/projects/lagopus/src/dpdk/build/include/rte_common.h:141:34:
warning: conversion from 'long unsigned int' to 'uint16_t'
{aka 'short unsigned int'} may change value [-Wconversion]
#define RTE_PTR_DIFF(ptr1, ptr2) ((uintptr_t)(ptr1) -
(uintptr_t)(ptr2))
^
/projects
/projects/lagopus/src/dpdk/build/include/rte_ether.h:213:13:
warning: conversion from 'int' to 'uint8_t'
{aka 'unsigned char'} may change value [-Wconversion]
addr[0] &= ~ETHER_GROUP_ADDR;
/* clear multicast bit */
Signed-off-by: Andy Green
Acked-by: Bruce Richardson
---
lib/librte_net/rte_et
/projects/lagopus/src/dpdk/build/include/rte_common.h:384:2:
warning: conversion from 'int' to 'uint16_t'
{aka 'short unsigned int'} may change value [-Wconversion]
__extension__ ({ \
^
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h:1204:16:
note: in expansion of macro 'RTE_MIN
differences to the atomic16 are signed, but the
atomic16 itself is unsigned. It needs to be
made explicit with casts.
Signed-off-by: Andy Green
If we want it for 18.05:
Acked-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
d
"1 + value", where value is an uint16_t causes promotion
to a signed int. The compiler complained that we are
shoving an int into a uint16_t return type with different
size and sign.
Bumping and returning value directly instead removes the
promotion and the problem.
Signed-off-by: Andy Green
--
/projects/lagopus/src/dpdk/build/include/rte_ring.h:350:46:
warning: conversion to 'uint32_t' {aka 'unsigned int'}
from 'int' may change the sign of the result
[-Wsign-conversion]
update_tail(&r->prod, prod_head, prod_next, is_sp, 1);
The visible apis take unsigned int, then call a private
api t
1 - 100 of 171 matches
Mail list logo
