[dpdk-dev] [PATCH v2] net/mlx5: fix flow director drop rule deletion crash

2018-05-14 Thread Shahaf Shuler
Drop flow rules are created on the ETH queue even though the parser layer matches the flow rule layer (L3/L4) Fixes: 6f2f4948b236 ("net/mlx5: fix flow director rule deletion crash") Cc: sta...@dpdk.org Cc: adrien.mazarg...@6wind.com Signed-off-by: Shahaf Shuler --- On v2: - Instead of override

[dpdk-dev] [PATCH v2] net/mlx5: add bluefield device ID

2018-05-14 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- On v2: - Updated mlx5 docs to include Bluefield product. - PCI_DEVICE_ID_MELLANOX_BLUEFIELD -> PCI_DEVICE_ID_MELLANOX_CONNECTX5BF --- config/common_base | 3 ++- doc/guides/nics/mlx5.rst | 58 ++-- drivers/net

Re: [dpdk-dev] [PATCH v3 3/3] memzone: improve zero-length memzone reserve

2018-05-14 Thread Remy Horton
On 14/05/2018 12:29, Burakov, Anatoly wrote: [..] This failure is not caused by this patchset, and you should get similar failures on master if you get these while testing my patchset. I am not able to reproduce this issue, but i'll double-check the bounded reserve code with a fine-toothed comb

Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code

2018-05-14 Thread Yao, Lei A
Hi, Andy This patch will break the vfio-pci driver on my server. I can't launch NIC with vfio-pci using testpmd. Could you have a check on this? Thanks a lot! My server info: OS: Ubuntu 16.04 LTS gcc: 5.4.0 kernel: 4.4.0 CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz NIC: Ethernet Controller X

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated

2018-05-14 Thread Pattan, Reshma
Hi Thomas, > Can it be fixed with strlcpy? > > I wonder why recent patch from Reshma is not touching these lines: > http://dpdk.org/commit/21ce8e44b8d > Yes, I remembered now, I fixed only gcc 8.0.1 compilation issues of this file, in which the lines of code this patch is fixing is not

[dpdk-dev] [PATCH v7 5/5] bus/vmbus and net/netvsc: add meson build support

2018-05-14 Thread Stephen Hemminger
From: Stephen Hemminger Update meson build files for new netvsc and vmbus drivers. Signed-off-by: Stephen Hemminger --- config/meson.build | 7 +++ drivers/bus/meson.build| 2 +- drivers/bus/vmbus/meson.build | 16 drivers/net/meson.build| 2

[dpdk-dev] [PATCH v7 3/5] net/netvsc: add hyper-v netvsc network device

2018-05-14 Thread Stephen Hemminger
The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). This version supports the latest NetVSP 6.1

[dpdk-dev] [PATCH v7 4/5] net/netvsc: add documentation

2018-05-14 Thread Stephen Hemminger
From: Stephen Hemminger Matching documentation for new netvsc device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/netvsc.ini| 23 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst | 103 + doc/guides/rel

[dpdk-dev] [PATCH v7 2/5] bus/vmbus: add hyper-v virtual bus support

2018-05-14 Thread Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported at present, but the code

[dpdk-dev] [PATCH v7 1/5] eal: add rte_uuid support

2018-05-14 Thread Stephen Hemminger
Since uuid functions may not be available everywhere, implement uuid functions in DPDK. These are based off the FreeBSD source of libc, without the annoying DCE style function signature. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/

[dpdk-dev] [PATCH v7 0/5] Hyper-V netvsc PMD and VMBus support

2018-05-14 Thread Stephen Hemminger
his is a revised version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only

[dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue

2018-05-14 Thread Beilei Xing
If flow directory is enabled, FDIR Tx queue can't be disabled when exiting application. Root cause is FDIR Tx queue is not disabled before removing HMC backing store. Fixes: 71d35259ff67 ("i40e: tear down flow director") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_e

Re: [dpdk-dev] release candidate 18.05-rc3

2018-05-14 Thread Andy Green
On 05/15/2018 07:18 AM, Ferruh Yigit wrote: A new DPDK release candidate is ready for testing: https://dpdk.org/browse/dpdk/tag/?id=v18.05-rc3 The release notes should be complete now: http://dpdk.org/doc/guides/rel_notes/release_18_05.html What's new in -rc3? - proper

Re: [dpdk-dev] [dpdk-announce] release candidate 18.05-rc3

2018-05-14 Thread Thomas Monjalon
15/05/2018 01:24, Stephen Hemminger: > > > Some planned features are postponed to 18.08: > > - Hyper-V bus and NetVSC driver > > I am disappointed by this. > Were you just overloaded or was it the meson build without uuid library? Yes it is because of meson build which was broken. I had no t

Re: [dpdk-dev] [dpdk-announce] release candidate 18.05-rc3

2018-05-14 Thread Stephen Hemminger
> Some planned features are postponed to 18.08: > - Hyper-V bus and NetVSC driver I am disappointed by this. Were you just overloaded or was it the meson build without uuid library? It is an experimental feature and because you blocked it, it means that other changes are likely to break su

[dpdk-dev] [dpdk-announce] release candidate 18.05-rc3

2018-05-14 Thread Ferruh Yigit
A new DPDK release candidate is ready for testing: https://dpdk.org/browse/dpdk/tag/?id=v18.05-rc3 The release notes should be complete now: http://dpdk.org/doc/guides/rel_notes/release_18_05.html What's new in -rc3? - proper runtime directory - consistent checks i

Re: [dpdk-dev] [PATCH v6 10/16] net/qede: solve broken strncpy

2018-05-14 Thread Andy Green
On 05/15/2018 05:14 AM, Ferruh Yigit wrote: On 5/14/2018 9:20 PM, Ferruh Yigit wrote: On 5/14/2018 6:00 AM, Andy Green wrote: /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function ‘qed_slowpath_start’: /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: error: ‘strnc

Re: [dpdk-dev] [PATCH v3] net/tap: fix isolation mode toggling

2018-05-14 Thread Wiles, Keith
> On May 14, 2018, at 5:26 PM, Ophir Munk wrote: > > Running testpmd command "flow isolae 0" (i.e. disabling flow > isolation) followed by command "flow isolate 1" (i.e. enabling > flow isolation) may result in a TAP error: > PMD: Kernel refused TC filter rule creation (17): File exists > >

Re: [dpdk-dev] [PATCH v3 0/4] Clean up EAL runtime data paths

2018-05-14 Thread Thomas Monjalon
14/05/2018 18:27, Anatoly Burakov: > As has been suggested [1], all DPDK runtime paths should be put > into a single place. This patchset accomplishes exactly that. > > If running as root, all files will be put under /var/run/dpdk/, > otherwise they will be put under $XDG_RUNTIME_PATH/dpdk/, or, i

Re: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

2018-05-14 Thread Wiles, Keith
>> >> Using double negation is not very readable IMO, I would prefer this >> converted to a true boolean type if required. >> > > Double negation usage was eliminated. Thanks I acked already. > >> variable ‘set' here should a 0 or 1 already, please expand this code to not >> use >> !!, usi

Re: [dpdk-dev] [PATCH] net/tap: perform proto field update for tun only

2018-05-14 Thread Wiles, Keith
> On May 13, 2018, at 11:53 PM, Vipin Varghese wrote: > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > type field will ensure the TAP PMD will always have protocol field as 0. > > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 50 +++

[dpdk-dev] [PATCH v3] net/tap: fix isolation mode toggling

2018-05-14 Thread Ophir Munk
Running testpmd command "flow isolae 0" (i.e. disabling flow isolation) followed by command "flow isolate 1" (i.e. enabling flow isolation) may result in a TAP error: PMD: Kernel refused TC filter rule creation (17): File exists Root cause analysis: when disabling flow isolation we keep the loca

Re: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

2018-05-14 Thread Ophir Munk
Hi Keith, > -Original Message- > From: Wiles, Keith [mailto:keith.wi...@intel.com] > Sent: Monday, May 14, 2018 3:33 PM > To: Ophir Munk > Cc: dev@dpdk.org; Pascal Mazon ; Thomas > Monjalon ; Olga Shern ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode t

Re: [dpdk-dev] [PATCH v2] net/tap: fix isolation mode toggling

2018-05-14 Thread Ophir Munk
v2 has a typo (/raw/row/) Re-sending as v3. > -Original Message- > From: Wiles, Keith [mailto:keith.wi...@intel.com] > Sent: Tuesday, May 15, 2018 1:18 AM > To: Ophir Munk > Cc: DPDK ; Pascal Mazon ; > Thomas Monjalon ; Olga Shern > ; Shahaf Shuler ; > sta...@dpdk.org > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH v2] net/tap: fix isolation mode toggling

2018-05-14 Thread Wiles, Keith
> On May 14, 2018, at 5:11 PM, Ophir Munk wrote: > > Running testpmd command "flow isolae 0" (i.e. disabling flow > isolation) followed by command "flow isolate 1" (i.e. enabling > flow isolation) may result in a TAP error: > PMD: Kernel refused TC filter rule creation (17): File exists > >

Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

2018-05-14 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, May 14, 2018 4:17 AM > To: Andy Green ; dev@dpdk.org; Patil, Harish > ; Mody, Rasesh > Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable > comparison > > On 5/14/2018 6:04 AM, Andy Green wrote: > > /home/agree

Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

2018-05-14 Thread Mody, Rasesh
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Sunday, May 13, 2018 10:05 PM > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: > In function ‘elink_check_kr2_wa’: > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28: > error: bitwise comparison always

[dpdk-dev] [PATCH v2] net/tap: fix isolation mode toggling

2018-05-14 Thread Ophir Munk
Running testpmd command "flow isolae 0" (i.e. disabling flow isolation) followed by command "flow isolate 1" (i.e. enabling flow isolation) may result in a TAP error: PMD: Kernel refused TC filter rule creation (17): File exists Root cause analysis: when disabling flow isolation we keep the loca

Re: [dpdk-dev] [PATCH v6 00/16] Fix default build on gcc8.0.1

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 5:59 AM, Andy Green wrote: > This series allows dpdk master to build on Fedora 28, > with the x86_64 default config. > > Acked-by: Neil Horman > --- > > Andy Green (16): > devtools/check-git: provide more generic grep pattern > net/nfp: solve buffer overflow > bus/

Re: [dpdk-dev] [PATCH v6 10/16] net/qede: solve broken strncpy

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 9:20 PM, Ferruh Yigit wrote: > On 5/14/2018 6:00 AM, Andy Green wrote: >> /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function >> ‘qed_slowpath_start’: >> /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: >> error: ‘strncpy’ output may be truncated copying

[dpdk-dev] [PATCH v2] app/testpmd: fix burst stat reporting

2018-05-14 Thread Daniel Shelepov
When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects burst statistics and includes them in the port stats report. The summary should include top 2 most frequent burst sizes, but there is a bug in finding the top-2. During the scan of burst size counts, the top-2 can change only if to

[dpdk-dev] [PATCH] librte_hash: new hash del abi to returns stored value

2018-05-14 Thread Vijaya Mohan Guvva
Add a new key delete interface rte_hash_del_key_with_hash_data to delete the key from hash and return the value stored. This is useful for hash users to free the data stored in the table after key delete and to avoid maintaining a user data array in the dpdk application. Signed-off-by: Vijaya Moha

Re: [dpdk-dev] [PATCH v6 16/16] app/test-bbdev: strcpy ok for allocated string

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 6:01 AM, Andy Green wrote: .../app/test-bbdev/test_bbdev_vector.c:917:5: error: ‘strncat’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] strncat(entry, line, strlen(line)); ^~

Re: [dpdk-dev] [PATCH v6 15/16] app/test-bbdev: strcpy ok for allocated string

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 9:56 PM, Ferruh Yigit wrote: > On 5/14/2018 9:42 PM, Ferruh Yigit wrote: >> On 5/14/2018 6:01 AM, Andy Green wrote: >>> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") >>> Cc: sta...@dpdk.org >>> Signed-off-by: Andy Green Reviewed-by: Ferruh Yigit >>> --- >

Re: [dpdk-dev] [PATCH v6 15/16] app/test-bbdev: strcpy ok for allocated string

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 9:42 PM, Ferruh Yigit wrote: > On 5/14/2018 6:01 AM, Andy Green wrote: >> Signed-off-by: Andy Green >> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") >> Cc: sta...@dpdk.org >> --- >> app/test-bbdev/test_bbdev_vector.c |2 +- >> 1 file changed, 1 insertion(+

Re: [dpdk-dev] [PATCH v6 15/16] app/test-bbdev: strcpy ok for allocated string

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 6:01 AM, Andy Green wrote: > Signed-off-by: Andy Green > Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") > Cc: sta...@dpdk.org > --- > app/test-bbdev/test_bbdev_vector.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-bbdev/

Re: [dpdk-dev] [PATCH v6 14/16] app/proc-info: sprintf overrun bug

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 6:01 AM, Andy Green wrote: > /home/agreen/projects/dpdk/app/proc-info/main.c: In function > ‘nic_xstats_display’: > /home/agreen/projects/dpdk/app/proc-info/main.c:495:45: > error: ‘%s’ directive writing up to 255 bytes into a region > of size between 165 and 232 [-Werror=format-overfl

Re: [dpdk-dev] [PATCH v6 10/16] net/qede: solve broken strncpy

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 6:00 AM, Andy Green wrote: > /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function > ‘qed_slowpath_start’: > /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: > error: ‘strncpy’ output may be truncated copying 12 bytes from a > string of length 127 [-Werror=

Re: [dpdk-dev] [PATCH v6 09/16] net/qede: strncpy length constant and NUL

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 6:00 AM, Andy Green wrote: > Fixes: 8427c6647964 ("net/qede/base: add attention formatting string") > Cc: sta...@dpdk.org > Signed-off-by: Andy Green Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip frag process log

2018-05-14 Thread Thomas Monjalon
14/05/2018 13:05, Ananyev, Konstantin: > > > -Original Message- > > From: Li Han [mailto:han@zte.com.cn] > > Sent: Wednesday, April 18, 2018 9:52 AM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org; Li Han > > Subject: [PATCH] lib/librte_ip_frag:fix ip frag process log > > > > in ip

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated

2018-05-14 Thread Thomas Monjalon
22/09/2017 15:09, Michal Jastrzebski: > From: Jacek Piasecki > > Fix size of buffer in strcpy. There was possible to get > not terminated string after copy operation. > > Coverity issue: 158629 > Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") > Cc: changpeng@intel.co

Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population

2018-05-14 Thread Thomas Monjalon
14/05/2018 18:06, Anatoly Burakov: > Currently, populate_virt will check if mempool is already populated. > This will cause inability to reserve multi-chunk mempools if > contiguous memory is not a hard requirement, because if allocating > all-contiguous memory fails, mempool will retry with virtua

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

2018-05-14 Thread Thomas Monjalon
> > Patch adding configurable locking has reshuffled some init stages, but did > > not > > put them back in correct order. Fix order of init by moving everything that > > was before arguments parsing into correct places. > > > > Fixes: e505d84c64ab ("app/testpmd: make locking memory configurable"

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

2018-05-14 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Monday, May 14, 2018 4:47 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing ; > tho...@monjalon.net; Yigit, Ferruh > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initializa

Re: [dpdk-dev] show-stopper bug before releasing -rc3

2018-05-14 Thread Burakov, Anatoly
On 14-May-18 3:20 PM, Thomas Monjalon wrote: Hi, We have just discovered an issue in master branch when starting testpmd. The core number is wrongly detected after this commit: http://dpdk.org/commit/e505d84c64 Command used for the test: /x86_64-native-linuxapp-gcc/build/app/test-pmd/te

Re: [dpdk-dev] [PATCH] doc/guides/rel_notes: Add known issue for IOMMU attributes read

2018-05-14 Thread Burakov, Anatoly
On 14-May-18 11:44 AM, Rosen Xu wrote: Read IOMMU attributes from linux kernle 4.10.0 error. s/kernle/kernel :) Cc: sta...@dpdk.org Signed-off-by: Rosen Xu --- doc/guides/rel_notes/known_issues.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/guides/rel

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

2018-05-14 Thread Ali Alnubani
Tested-by: Ali Alnubani > -Original Message- > From: dev On Behalf Of Anatoly Burakov > Sent: Monday, May 14, 2018 6:47 PM > To: dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Thomas Monjalon ; > ferruh.yi...@intel.com > Subject: [dpdk-dev] [PATCH] app/testpmd: fix testpmd initializatio

Re: [dpdk-dev] [PATCH v6 01/16] devtools/check-git: provide more generic grep pattern

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 5:59 AM, Andy Green wrote: > On Fedora 28, every patch is faulted for > "Wrong headline uppercase", because [A-Z] is not > always case sensitive. > > Change to use [[:upper:]] > > Signed-off-by: Andy Green Tested-by: Ferruh Yigit

[dpdk-dev] [PATCH v3 3/4] eal: add directory for DPDK runtime data

2018-05-14 Thread Anatoly Burakov
Currently, during runtime, DPDK will store a bunch of files here and there (in /var/run, /tmp or in $HOME). Fix it by creating a DPDK-specific runtime directory, under which all runtime data will be placed. The template for creating this runtime directory is the following: /dpdk// Where is set

[dpdk-dev] [PATCH v3 2/4] eal: rename function returning hugepage data path

2018-05-14 Thread Anatoly Burakov
The original name for this path was not too descriptive and confusing. Rename it to a more appropriate and descriptive name: it stores data about hugepages, so name it eal_hugepage_data_path(). Signed-off-by: Anatoly Burakov Reviewed-by: Reshma Pattan --- lib/librte_eal/common/eal_filesystem.h

[dpdk-dev] [PATCH v3 4/4] eal: move all runtime data into DPDK runtime dir

2018-05-14 Thread Anatoly Burakov
Fix all calls to functions in eal_filesystem to produce paths residing inside dedicated DPDK runtime directory. Leaving DPDK runtime config in place as 3rd-party applications within the DPDK ecosystem might rely on this path to determine whether DPDK is running, so moving that will be postponed to

[dpdk-dev] [PATCH v3 1/4] eal: remove unused define

2018-05-14 Thread Anatoly Burakov
The define was a leftover from IVSHMEM library. Fixes: c711ccb30987 ("ivshmem: remove library and its EAL integration") Cc: david.march...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Reviewed-by: David Marchand --- lib/librte_eal/common/eal_filesystem.h | 2 -- 1 file changed,

[dpdk-dev] [PATCH v3 0/4] Clean up EAL runtime data paths

2018-05-14 Thread Anatoly Burakov
As has been suggested [1], all DPDK runtime paths should be put into a single place. This patchset accomplishes exactly that. If running as root, all files will be put under /var/run/dpdk/, otherwise they will be put under $XDG_RUNTIME_PATH/dpdk/, or, if that environment variable is not defined, a

Re: [dpdk-dev] [PATCH v2] net/tap: add default name to tun

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 5:01 PM, Ferruh Yigit wrote: > On 5/12/2018 7:21 AM, Vipin Varghese wrote: >> The change adds default name to reflect TUN PMD instance. if option >> name is not passed, the default dtun is taken. >> >> Signed-off-by: Vipin Varghese > > Reviewed-by: Ferruh Yigit Applied to dpdk-next

[dpdk-dev] [PATCH] mempool: fix virt address mempool population

2018-05-14 Thread Anatoly Burakov
Currently, populate_virt will check if mempool is already populated. This will cause inability to reserve multi-chunk mempools if contiguous memory is not a hard requirement, because if allocating all-contiguous memory fails, mempool will retry with virtual addresses and will call populate_virt. It

Re: [dpdk-dev] [PATCH v2] net/tap: add default name to tun

2018-05-14 Thread Ferruh Yigit
On 5/12/2018 7:21 AM, Vipin Varghese wrote: > The change adds default name to reflect TUN PMD instance. if option > name is not passed, the default dtun is taken. > > Signed-off-by: Vipin Varghese Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v3 2/2] ethdev: convert static logtype usage to dynamic

2018-05-14 Thread Ferruh Yigit
Replace RTE_PMD_DEBUG_TRACE with RTE_ETHDEV_LOG. RTE_PMD_DEBUG_TRACE is using hardcoded PMD logtype and ERR log level, controlled by compile time flags. RTE_ETHDEV_LOG is using dynamic ethdev_logtype. Also a few minor cleanups, like - use %u for unsigned values like port_id which is uint16_t - us

[dpdk-dev] [PATCH v3 1/2] ethdev: move log macro to header

2018-05-14 Thread Ferruh Yigit
Macro moved to header to be able to convert logging usage in header. And since it has been moved to public header changed naming and added RTE prefix, ethdev_log -> RTE_ETHDEV_LOG Signed-off-by: Ferruh Yigit --- v2: * updated commit log --- lib/librte_ethdev/rte_ethdev.c | 25 +++

[dpdk-dev] [PATCH] app/testpmd: fix testpmd initialization

2018-05-14 Thread Anatoly Burakov
Patch adding configurable locking has reshuffled some init stages, but did not put them back in correct order. Fix order of init by moving everything that was before arguments parsing into correct places. Fixes: e505d84c64ab ("app/testpmd: make locking memory configurable") Reported-by: Thomas Mo

Re: [dpdk-dev] [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap

2018-05-14 Thread Mohammad Abdul Awal
On 14/05/2018 11:35, Iremonger, Bernard wrote: Hi Awal, -Original Message- From: Awal, Mohammad Abdul Sent: Friday, May 11, 2018 6:14 PM To: dev@dpdk.org; Iremonger, Bernard ; adrien.mazarg...@6wind.com Subject: [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre

Re: [dpdk-dev] [PATCH v2 30/31] doc/qat: specify QAT driver and device name formats

2018-05-14 Thread Kovacevic, Marko
> Document the driver and device naming formats. > > Signed-off-by: Fiona Trahe > --- > doc/guides/cryptodevs/qat.rst | 12 > 1 file changed, 12 insertions(+) > > diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst > index 8c8fefaa0..67176bd81 100644 > --- a/

Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags

2018-05-14 Thread Thomas Monjalon
14/05/2018 15:15, Konstantin Ananyev: > - add EXPERIMENTAL tag for the section in MAINTAINERS. > - add EXPERIMENTAL tag to BPF public API files. > - add attribute __rte_experimental to BPF public API declarations. > > Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework") > Fixes: 5d

Re: [dpdk-dev] [PATCH] test/test_table_pipeline: fix incorrect function parameter

2018-05-14 Thread Thomas Monjalon
14/05/2018 15:35, Jasvinder Singh: > Fixes the wrong argument in table action miss function. > Fixes: 4c387fcdf777 ("pipeline: add new functions for action handlers") Cc: sta...@dpdk.org > Signed-off-by: Jasvinder Singh Applied, thanks

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

2018-05-14 Thread Thomas Monjalon
14/05/2018 17:26, Pattan, Reshma: > Hi Thomas, > > > > 2. Fixed in autotest_test_funcs.py to handle test cases which returns > > > "Skipped" as result. > > > The issue was skipped test cases got timed out, causing delay in > > > sanity script execution. > > > 3. Enhanced support for FreeBSD, > >

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

2018-05-14 Thread Pattan, Reshma
Hi Thomas, > > 2. Fixed in autotest_test_funcs.py to handle test cases which returns > > "Skipped" as result. > > The issue was skipped test cases got timed out, causing delay in > > sanity script execution. > > 3. Enhanced support for FreeBSD, > > as FreeBSD doesn't support socket-mem, file-pre

Re: [dpdk-dev] [PATCH] nfp: restore the unlink operation

2018-05-14 Thread Eelco Chaudron
On 14/05/18 16:46, Aaron Conole wrote: For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit 515933ad8385 ("nfp: allow for non-root user") inadvertently removed the unlink() call. Acked-by: Eelco Chaudron

Re: [dpdk-dev] Please revert: [PATCH 2/2] net/mlx4: fix useless default in RSS converter

2018-05-14 Thread Adrien Mazarguil
On Wed, May 09, 2018 at 09:57:31AM +, Shahaf Shuler wrote: > Wednesday, May 9, 2018 11:47 AM, Ophir Munk: > > Subject: Please revert: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default > > in RSS converter > > > > Hi Shahaf, Adrien, > > > > This commit (in next-net/master since 8-May-18) is

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously

2018-05-14 Thread Chas Williams
There's possibly an issue here: /* If the device isn't started don't handle interrupts */ if (!bonded_eth_dev->data->dev_started) return rc; /* verify that port_id is a valid slave of bonded port */ for (i = 0; i < internals->slave_count; i++) {

Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags

2018-05-14 Thread Thomas Monjalon
14/05/2018 16:55, Ananyev, Konstantin: > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, May 14, 2018 3:31 PM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags > > > > 14/

Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags

2018-05-14 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, May 14, 2018 3:31 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags > > 14/05/2018 15:15, Konstantin Ananyev: > > - add EXPERIMENTA

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: fail if requested offload is not supported

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 8:51 AM, Shahaf Shuler wrote: > Monday, May 14, 2018 10:36 AM, Andrew Rybchenko: >> Subject: [PATCH v2 0/3] ethdev: fail if requested offload is not supported >> >> The series has fixes for problems discussed in [1]. >> >> Basically it does not allow unsupported offloads to pass. >> >>

[dpdk-dev] [PATCH] nfp: restore the unlink operation

2018-05-14 Thread Aaron Conole
For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit 515933ad8385 ("nfp: allow for non-root user") inadvertently removed the unlink() call. Fixes: 515933ad8385 ("nfp: allow for non-root user") Cc: Alejandro

Re: [dpdk-dev] [PATCH v14] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 3:11 PM, Thomas Monjalon wrote: > 14/05/2018 15:20, Wei Dai: >> Signed-off-by: Wei Dai >> Signed-off-by: Ferruh Yigit >> Signed-off-by: Qi Zhang > > [...] >> * hasn't been set in the input argument eth_conf->rxmode.offloads >> * to rte_eth_dev_configure(), it is a new added

Re: [dpdk-dev] [PATCH] net/enic: fix missing offload capabilities

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 3:11 PM, Hyong Youb Kim wrote: > Add the following missing flags to the advertised offloads. > - DEV_RX_OFFLOAD_CRC_STRIP > CRC is always stripped. > - DEV_RX_OFFLOAD_JUMBO_FRAME > Jumbo support is always enabled on the NIC. > - DEV_RX_OFFLOAD_SCATTER > Scatter Rx is currently su

Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags

2018-05-14 Thread Thomas Monjalon
14/05/2018 15:15, Konstantin Ananyev: > - add EXPERIMENTAL tag for the section in MAINTAINERS. > - add EXPERIMENTAL tag to BPF public API files. > - add attribute __rte_experimental to BPF public API declarations. > > Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework") > Fixes: 5d

Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags

2018-05-14 Thread Thomas Monjalon
14/05/2018 16:20, Ferruh Yigit: > On 5/14/2018 2:15 PM, Konstantin Ananyev wrote: > > - add EXPERIMENTAL tag for the section in MAINTAINERS. > > - add EXPERIMENTAL tag to BPF public API files. > > - add attribute __rte_experimental to BPF public API declarations. > > > > Fixes: 94972f35a02e ("bpf:

[dpdk-dev] [PATCH] librte_ip_frag: mbuf count, expiration

2018-05-14 Thread Alex Kiselev
Hi. This patch adds two features to the librte_ip_frag library: 1) it keeps track of number of mbufs holded in the fragmentation table. rte_frag_table_mbuf_count() There might be situations (kind of attack when a lot of fragmented packets are sent to a dpdk application in order to flood the fr

Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 2:15 PM, Konstantin Ananyev wrote: > - add EXPERIMENTAL tag for the section in MAINTAINERS. > - add EXPERIMENTAL tag to BPF public API files. > - add attribute __rte_experimental to BPF public API declarations. > > Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework") >

[dpdk-dev] show-stopper bug before releasing -rc3

2018-05-14 Thread Thomas Monjalon
Hi, We have just discovered an issue in master branch when starting testpmd. The core number is wrongly detected after this commit: http://dpdk.org/commit/e505d84c64 Command used for the test: /x86_64-native-linuxapp-gcc/build/app/test-pmd/testpmd -n 4 -w 00:07.0,l3_vxlan_en=1,rx_vec_en=

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-14 Thread Thomas Monjalon
14/05/2018 16:10, Ferruh Yigit: > On 5/14/2018 11:19 AM, Shahaf Shuler wrote: > > Monday, May 14, 2018 1:00 PM, Ferruh Yigit: > >>> > >>> It depends on which PMD is used. Yes, it was no checks in ethdev before. > >>> If PMD does not support multi-segment Tx, some checksum or VLAN > >>> insertion of

[dpdk-dev] [PATCH] net/enic: fix missing offload capabilities

2018-05-14 Thread Hyong Youb Kim
Add the following missing flags to the advertised offloads. - DEV_RX_OFFLOAD_CRC_STRIP CRC is always stripped. - DEV_RX_OFFLOAD_JUMBO_FRAME Jumbo support is always enabled on the NIC. - DEV_RX_OFFLOAD_SCATTER Scatter Rx is currently supported. - DEV_TX_OFFLOAD_MULTI_SEGS Multiple-segment tr

Re: [dpdk-dev] [PATCH v14] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Thomas Monjalon
14/05/2018 15:20, Wei Dai: > Signed-off-by: Wei Dai > Signed-off-by: Ferruh Yigit > Signed-off-by: Qi Zhang [...] > * hasn't been set in the input argument eth_conf->rxmode.offloads > * to rte_eth_dev_configure(), it is a new added offloading, it must be > * per-queue type and it is

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 11:19 AM, Shahaf Shuler wrote: > Monday, May 14, 2018 1:00 PM, Ferruh Yigit: >>> >>> It depends on which PMD is used. Yes, it was no checks in ethdev before. >>> If PMD does not support multi-segment Tx, some checksum or VLAN >>> insertion offload, but application requests it and rely

Re: [dpdk-dev] [PATCH v5 1/3] malloc: add biggest free IOVA-contiguous element to stats

2018-05-14 Thread Shreyansh Jain
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Monday, May 14, 2018 7:17 PM > To: dev@dpdk.org > Cc: remy.hor...@intel.com > Subject: [dpdk-dev] [PATCH v5 1/3] malloc: add biggest free IOVA- > contiguous element to stats > > User might b

[dpdk-dev] [PATCH v5 3/3] memzone: improve zero-length memzone reserve

2018-05-14 Thread Anatoly Burakov
Currently, reserving zero-length memzones is done by looking at malloc statistics, and reserving biggest sized element found in those statistics. This has two issues. First, there is a race condition. The heap is unlocked between the time we check stats, and the time we reserve malloc element for

[dpdk-dev] [PATCH v5 0/3] Improve zero-length memzone allocation

2018-05-14 Thread Anatoly Burakov
This patchset does two things. First, it enables reserving memzones of zero-length that are IOVA-contiguous. Second, it fixes a long-standing race condition in reserving zero-length memzones, where malloc heap is not locked between stats collection and reservation, and will instead allocate biggest

[dpdk-dev] [PATCH v5 1/3] malloc: add biggest free IOVA-contiguous element to stats

2018-05-14 Thread Anatoly Burakov
User might be interested to find out what is the biggest chunk of IOVA-contiguous free space that can be allocated from malloc. Add relevant malloc-internal functions and expose this through malloc stats calculation call. Signed-off-by: Anatoly Burakov Acked-by: Remy Horton --- Notes: v4:

[dpdk-dev] [PATCH v5 2/3] malloc: allow reserving biggest element

2018-05-14 Thread Anatoly Burakov
Add an internal-only function to allocate biggest element from the heap. Nominally, it supports SOCKET_ID_ANY as its socket argument, but it's essentially useless because other sockets will only be allocated from if the entire heap on current or specified socket is busy. Still, asking to reserve a

[dpdk-dev] [PATCH] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

2018-05-14 Thread Matan Azrad
Add support for MPLS over GRE and MPLS over UDP tunnel types as described in the next RFCs: 1. https://tools.ietf.org/html/rfc4023 2. https://tools.ietf.org/html/rfc7510 3. https://tools.ietf.org/html/rfc4385 Signed-off-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 4 +- drivers/net/mlx5/

[dpdk-dev] [PATCH v14] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure() and [rt]x_conf->offloads to rte_et

[dpdk-dev] [PATCH] test/test_table_pipeline: fix incorrect function parameter

2018-05-14 Thread Jasvinder Singh
Fixes the wrong argument in table action miss function. Fixes: 4c387fcdf777 ("pipeline: add new functions for action handlers") Signed-off-by: Jasvinder Singh --- test/test/test_table_pipeline.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/test/test_table_p

Re: [dpdk-dev] [PATCH v13] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Dai, Wei
Hi, Thomas Thanks for your quick feedback. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, May 14, 2018 8:54 PM > To: Dai, Wei > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v13] ethdev: new Rx/Tx offloads API

[dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags

2018-05-14 Thread Konstantin Ananyev
- add EXPERIMENTAL tag for the section in MAINTAINERS. - add EXPERIMENTAL tag to BPF public API files. - add attribute __rte_experimental to BPF public API declarations. Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework") Fixes: 5dba93ae5f2d ("bpf: add ability to load eBPF program

Re: [dpdk-dev] [PATCH v13] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Thomas Monjalon
14/05/2018 14:00, Wei Dai: > --- a/doc/guides/prog_guide/poll_mode_drv.rst > +++ b/doc/guides/prog_guide/poll_mode_drv.rst > @@ -303,12 +303,12 @@ In the DPDK offload API, offloads are divided into > per-port and per-queue offloa > * A pure per-port offloading can't be enabled on a queue and disa

Re: [dpdk-dev] [PATCH 1/5] net/qede: convert to new Rx/Tx offloads API

2018-05-14 Thread Ferruh Yigit
On 5/11/2018 10:16 AM, Andrew Rybchenko wrote: > On 03/28/2018 03:15 AM, Rasesh Mody wrote: >> From: Harish Patil >> >> Ethdev RX/TX offloads API has changed since: >> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") >> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 12:45 PM, Doherty, Declan wrote: > On 24/04/2018 12:29 PM, Matan Azrad wrote: >> The bonding PMD decides to activate\deactivate its slaves according to >> the slaves link statuses. >> Thus, it registers to the LSC events of the slaves ports and >> activates\deactivates them from its LS

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/avf: fix Rx interrupt mapping

2018-05-14 Thread Ferruh Yigit
On 5/11/2018 4:09 PM, Jingjing Wu wrote: > Vector used for rx mapping is different if WB_ON_ITR > is supported. The mapping table need to be updated. > > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") > > Signed-off-by: Jingjing Wu > Cc: sta...@dpdk.org Applied to dpdk-next-net/master, th

Re: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

2018-05-14 Thread Wiles, Keith
> On May 7, 2018, at 3:36 AM, Ophir Munk wrote: > > Running testpmd command "flow isolae 0" (i.e. disabling flow > isolation) followed by command "flow isolate 1" (i.e. enabling > flow isolation) may result in a TAP error: > PMD: Kernel refused TC filter rule creation (17): File exists > > R

Re: [dpdk-dev] [PATCH] net/dpaa2: change vlan strip value to offload flag

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 11:58 AM, Shreyansh Jain wrote: > Fixes: 0ebce6129bc6 ("net/dpaa2: support new ethdev offload APIs") > Cc: sunil.k...@nxp.com > > Signed-off-by: Shreyansh Jain Applied to dpdk-next-net/master, thanks. > --- > Note: Though checkpatch produces a warning for 80 char, this is more rea

Re: [dpdk-dev] [PATCH v3 3/3] memzone: improve zero-length memzone reserve

2018-05-14 Thread Burakov, Anatoly
On 14-May-18 12:29 PM, Burakov, Anatoly wrote: On 14-May-18 9:21 AM, Burakov, Anatoly wrote: On 11-May-18 11:25 AM, Remy Horton wrote: On 03/05/2018 18:18, Anatoly Burakov wrote: [..] Also, fixup unit tests to account for the new behavior. Tried running the tests but it fails on a boundary

  1   2   >