14/05/2018 16:55, Ananyev, Konstantin: > > > -----Original Message----- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, May 14, 2018 3:31 PM > > To: Ananyev, Konstantin <konstantin.anan...@intel.com> > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags > > > > 14/05/2018 15:15, Konstantin Ananyev: > > > - add EXPERIMENTAL tag for the section in MAINTAINERS. > > > - add EXPERIMENTAL tag to BPF public API files. > > > - add attribute __rte_experimental to BPF public API declarations. > > > > > > Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework") > > > Fixes: 5dba93ae5f2d ("bpf: add ability to load eBPF program from ELF") > > > Fixes: a93ff62a8938 ("bpf: add BPF loading and execution framework") > > > > > > Reported-by: Thomas Monjalon <tho...@monjalon.net> > > > Signed-off-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > > --- > > > MAINTAINERS | 2 +- > > > lib/librte_bpf/rte_bpf.h | 26 ++++++++++++++++---------- > > > lib/librte_bpf/rte_bpf_ethdev.h | 15 ++++++++++----- > > > 3 files changed, 27 insertions(+), 16 deletions(-) > > > > You need to add __rte_experimental in function definitions too (.c file). > > I believe that was done in initial commit.
I did not check, sorry. > > There is a tool to check it: buildtools/check-experimental-syms.sh > > > > ./buildtools/check-experimental-syms.sh lib/librte_bpf/rte_bpf_version.map > x86_64-native-linuxapp-gcc-meson/lib/librte_bpf.a > > Don't produce any errors/warnings for me. > Do I miss something here? No, it's me doing wrong assumption :)
