[dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

2018-05-11 Thread Vipin Varghese
Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") Enables TUN PMD sharing by attaching the port from the shared data. Cc: zhihong.w...@intel.com Cc: ferruh.yi...@intel.com Signed-off-by: Vipin Varghese --- --- drivers/net/tap/rte_eth_tap.c | 13 + 1 file cha

[dpdk-dev] [PATCH] net/tap: update tap index to unsgined

2018-05-11 Thread Vipin Varghese
Updating the logic to reflect unsigned integer as index for TAP PMD. Signed-off-by: Vipin Varghese --- drivers/net/tap/rte_eth_tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 48c61b3..db397d6 100644

Re: [dpdk-dev] [PATCH] net/tap: add default name to tun

2018-05-11 Thread Varghese, Vipin
Thanks Stephen, for pointing this out. I have shared a V2 for the same. > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, May 11, 2018 8:55 PM > To: Varghese, Vipin > Cc: Yigit, Ferruh ; Wang, Zhihong > ; dev@dpdk.org > Subject: Re: [dpdk-d

[dpdk-dev] [PATCH v2] net/tap: add default name to tun

2018-05-11 Thread Vipin Varghese
The change adds default name to reflect TUN PMD instance. if option name is not passed, the default dtun is taken. Signed-off-by: Vipin Varghese --- Changes in V2: unsigned instead of signed for dev_index - Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 5 - 1 file changed, 4 inserti

[dpdk-dev] [PATCH v3 23/24] rte_hash_crc.h: explicit casts for truncation

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_hash_crc.h: In function 'crc32c_sse42_u64_mimic': /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:402:40: warning: conversion from 'uint64_t' {aka 'long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion] init_val

[dpdk-dev] [PATCH v3 24/24] test_table_pipeline: repair munged indirection level

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- test/test/test_table_pipeline.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test/test_table_pipeline.c b/test/test/test_table_pipeline.c index 055a1a4e7..d007d55ce 100644 --- a/test/test/test_table_pipeline.c +++ b/test/test/test_t

[dpdk-dev] [PATCH v3 20/24] rte_ethdev.h: align sign and scope of temp var

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_ethdev/rte_ethdev.h | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 7ccf4bae6..2487e1d2d 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++

[dpdk-dev] [PATCH v3 19/24] rte_ether.h: stack vars declared at top of function

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ether.h: In function 'rte_vlan_strip': /projects/lagopus/src/dpdk/build/include/rte_ether.h:357:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] struct vlan_hdr *vh = (struct vlan_hdr *)(eh + 1); Signed-off-by: A

[dpdk-dev] [PATCH v3 21/24] rte_ethdev.h: explicit cast for truncation

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h: In function 'rte_eth_tx_buffer_flush': /projects/lagopus/src/dpdk/build/include/rte_ethdev.h:4248:55: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] buffer->error_callback(&buffer->pkt

[dpdk-dev] [PATCH v3 22/24] rte_hash_crc.h: stack vars declared at top of function

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_hash_crc.h: In function 'crc32c_2words': /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:347:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] uint32_t crc, term1, term2; Signed-off-by: Andy Green --- li

[dpdk-dev] [PATCH v3 17/24] rte_byteorder.h: explicit cast for return promotion

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- .../common/include/generic/rte_byteorder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/generic/rte_byteorder.h b/lib/librte_eal/common/include/generic/rte_byteorder.h index 9bed85cca..8ffbac394 100644

[dpdk-dev] [PATCH v3 14/24] rte_mbuf.h: explicit cast restricting ptrdiff to uint16

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_common.h:141:34: warning: conversion from 'long unsigned int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] #define RTE_PTR_DIFF(ptr1, ptr2) ((uintptr_t)(ptr1) - (uintptr_t)(ptr2)) ^ /projects

[dpdk-dev] [PATCH v3 18/24] rte_ether.h: explicit cast avoiding truncation warning

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ether.h:213:13: warning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion] addr[0] &= ~ETHER_GROUP_ADDR; /* clear multicast bit */ Signed-off-by: Andy Green --- lib/librte_net/rte_ether.h |2 +- 1 file chan

[dpdk-dev] [PATCH v3 11/24] rte_mbuf.h: avoid warnings from inadvertant promotion

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 4fd9a0d9e..a2a37a311 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@

[dpdk-dev] [PATCH v3 16/24] rte_mbuf.h: explicit casts to uint16 to avoid warnings

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 169f3d3b0..3cd76abbc 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.

[dpdk-dev] [PATCH v3 15/24] rte_mbuf.h: explicit cast for size type to uint32

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 0580ec8a0..169f3d3b0 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -1577,7 +1

[dpdk-dev] [PATCH v3 13/24] rte_mbuf.h: make sure RTE-MIN compares same types

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_common.h:384:2: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] __extension__ ({ \ ^ /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:1204:16: note: in expansion of macro 'RTE_MIN

[dpdk-dev] [PATCH v3 12/24] rte_mbuf.h: explicit casts for int16 to uint16

2018-05-11 Thread Andy Green
differences to the atomic16 are signed, but the atomic16 itself is unsigned. It needs to be made explicit with casts. Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/libr

[dpdk-dev] [PATCH v3 10/24] rte_dev.h: stack declaration at top of own basic block

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_dev.h:54:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; Signed-off-by: Andy Green --- lib/librte_eal/common/include/rte_dev.h | 15 +-- 1 file chang

[dpdk-dev] [PATCH v3 09/24] rte_ring.h: remove signed type flipflopping

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ring.h:350:46: warning: conversion to 'uint32_t' {aka 'unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] update_tail(&r->prod, prod_head, prod_next, is_sp, 1); The visible apis take unsigned int, then call a private api t

[dpdk-dev] [PATCH v3 07/24] rte_spinlock.h: stack declarations before code

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_spinlock.h: In function 'rte_try_tm': /projects/lagopus/src/dpdk/build/include/rte_spinlock.h:82:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] int retries = RTE_RTM_MAX_RETRIES; Signed-off-by: Andy Green ---

[dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: In function '__rte_ring_move_prod_head': /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] const uint32_t cons_tail = r->cons.tail;

[dpdk-dev] [PATCH v3 04/24] lib/librte_eal: explicit tmp cast

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- .../common/include/arch/x86/rte_memcpy.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h index 5ead68ab2..f9ea0ab69 100

[dpdk-dev] [PATCH v3 06/24] /lib/librte_eal: stage cast from uint64 to long

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_random.h: In function 'rte_srand': /projects/lagopus/src/dpdk/build/include/rte_random.h:34:10: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion] srand48((long unsigned int)seedval); /proj

[dpdk-dev] [PATCH v3 05/24] lib/librte_eal: explicit cast for signed change

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_lcore.h: In function 'rte_lcore_index': /projects/lagopus/src/dpdk/build/include/rte_lcore.h:122:14: warning: conversion to 'int' from 'unsigned int' may change the sign of the result [-Wsign-conversion] lcore_id = rte_lcore_id(); Signed-off-by: Andy

[dpdk-dev] [PATCH v3 03/24] rte_common.h: cast gcc builtin result to avoid complaints

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_common.h:416:9: warning: conversion to 'uint32_t' {aka 'unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] return __builtin_ctz(v); ^~~~ The builtin is defined to return int, but we want to return it a

[dpdk-dev] [PATCH v3 00/24] Fixes for GCC8 against lagopus

2018-05-11 Thread Andy Green
The following series fixes build problems in dpdk master headers, found when using it as the dpdk subproject in lagopus. These errors are coming when you try to use the dpdk headers, not when you build dpdk itself. Reviewed-by: Stephen Hemminger --- Andy Green (24): lib/librte_eal: impor

[dpdk-dev] [PATCH v3 02/24] lib/librte_ethdev: change eth-dev-ops API to return int

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/ark/ark_ethdev_rx.c |4 ++-- drivers/net/ark/ark_ethdev_rx.h |3 +-- drivers/net/avf/avf_rxtx.c |4 ++-- drivers/net/avf/avf_rxtx.h |2 +- drivers/net/bnxt/bnxt_ethdev.c |5 +++-- drivers/net/dpaa/dpaa_et

[dpdk-dev] [PATCH v3 01/24] lib/librte_eal: import libbsd strlcpy

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_eal/common/eal_common_string_fns.c | 34 lib/librte_eal/common/include/rte_string_fns.h |7 + 2 files changed, 36 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/common/eal_common_string_fns.c b/lib/librte_ea

[dpdk-dev] [PATCH v2 4/4] net/bnx2x: solve overruns

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Acked-by: Pablo de Lara --- drivers/net/bnx2x/bnx2x.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index bfd9cce51..3892934

[dpdk-dev] [PATCH v2 2/4] net/bnx2x: correct unmeetable comparison

2018-05-11 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: In function ‘elink_check_kr2_wa’: /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] ((next_page & 0xe0) == 0x2; This was fixed elsewhere

[dpdk-dev] [PATCH v2 3/4] net/mlx5: solve var may be used uninitialized

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") Acked-by: Pablo de Lara --- drivers/net/mlx5/mlx5.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 8f983061a..4d379f

[dpdk-dev] [PATCH v2 0/4] GCC8 fixes for MLX4/5/BNX2X PMD

2018-05-11 Thread Andy Green
The following series fixes build breakage if you additionally enable CONFIG_RTE_LIBRTE_MLX4_PMD CONFIG_RTE_LIBRTE_MLX5_PMD CONFIG_RTE_LIBRTE_BNX2X_PMD Signed-off-bys and various list comment integrated since v1 --- Andy Green (4): net/bnx2x: do not cast function pointers as a policy

[dpdk-dev] [PATCH v2 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-11 Thread Andy Green
This is stopping the compiler telling you when you have done something stupid... that is something none of us can afford... Now gcc 8.x can tell you did something stupid despite trying to hide the evidence. Remove all the "black magic" casts. Fix the actual problems. Signed-off-by: Andy Green

[dpdk-dev] [PATCH v5 15/16] app/test-bbdev: strcpy ok for allocated string

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org --- app/test-bbdev/test_bbdev_vector.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.

[dpdk-dev] [PATCH v5 16/16] app/test-bbdev: strcpy ok for allocated string

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org --- app/test-bbdev/test_bbdev_vector.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vec

[dpdk-dev] [PATCH v5 12/16] net/vdev_netvsc: readlink inputs cannot be aliased

2018-05-11 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/vdev_netvsc/ vdev_netvsc.c:335:2:error: passing argument 2 to restrict- qualified parameter aliases with argument 1 [-Werror=restrict] ret = readlink(buf, buf, size); ^~~ Signed-off-by: Andy Green Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core fun

[dpdk-dev] [PATCH v5 14/16] app/proc-info: sprintf overrun bug

2018-05-11 Thread Andy Green
/home/agreen/projects/dpdk/app/proc-info/main.c: In function ‘nic_xstats_display’: /home/agreen/projects/dpdk/app/proc-info/main.c:495:45: error: ‘%s’ directive writing up to 255 bytes into a region of size between 165 and 232 [-Werror=format-overflow=] sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/

[dpdk-dev] [PATCH v5 11/16] net/sfc: make sure that copied stats name is NUL-terminated

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green Acked-by: Andrew Rybchenko Fixes: 73280c1e4ff2 ("net/sfc: support xstats retrieval by ID") Fixes: 7b9891769f4b ("net/sfc: support extended statistics") Cc: sta...@dpdk.org --- drivers/net/sfc/sfc_ethdev.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) d

[dpdk-dev] [PATCH v5 13/16] net/vdev_netvsc: 3 x strncpy misuse

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality") Cc: sta...@dpdk.org Acked-by: Pablo de Lara --- drivers/net/vdev_netvsc/vdev_netvsc.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.

[dpdk-dev] [PATCH v5 10/16] net/qede: solve broken strncpy

2018-05-11 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function ‘qed_slowpath_start’: /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: error: ‘strncpy’ output may be truncated copying 12 bytes from a string of length 127 [-Werror=stringop-truncation] strncpy((char *)drv_versio

[dpdk-dev] [PATCH v5 07/16] net/nfp/nfpcore: off-by-one and no NUL on strncpy use

2018-05-11 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c: 76:2:error: ‘strncpy’ output may be truncated copying 8 bytes from a string of length 8 [-Werror=stringop-truncation] strncpy(name_pad, res->name, sizeof(name_pad)); Signed-off-by: Andy Green Fixes: c7e9729da6b5 ("net/nfp: suppo

[dpdk-dev] [PATCH v5 09/16] net/qede: strncpy length constant and NUL

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green Fixes: 8427c6647964 ("net/qede/base: add attention formatting string") Cc: sta...@dpdk.org --- drivers/net/qede/base/ecore_int.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecor

[dpdk-dev] [PATCH v5 06/16] net/nfp/nfpcore: solve strncpy misuse

2018-05-11 Thread Andy Green
Signed-off-by: Andy Green Acked-by: Alejandro Lucero Tested-by: Alejandro Lucero Fixes: c7e9729da6b5 ("net/nfp: support CPP") --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/dr

[dpdk-dev] [PATCH v5 05/16] net/axgbe: solve broken eeprom string comp

2018-05-11 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/axgbe/axgbe_phy_impl.c:576:6: error: ‘__builtin_memcmp_eq’ reading 16 bytes from a region of size 9 [-Werror=stringop-overflow=] if (memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_NAME], ^ AXGBE

[dpdk-dev] [PATCH v5 08/16] net/nfp: don't memcpy out of source range

2018-05-11 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2: error: ‘memcpy’ forming offset [5, 6] is out of the bounds [0, 4] of object ‘tmp’ with type ‘uint32_t’ {aka ‘unsigned int’} [-Werror=array-bounds] memcpy(&hw->mac_addr[0], &tmp, sizeof(struct ether_addr)); Signed-off-by: Andy Green Acke

[dpdk-dev] [PATCH v5 01/16] devtools/check-git: provide more generic grep pattern

2018-05-11 Thread Andy Green
On Fedora 28, every patch is faulted for "Wrong headline uppercase", because [A-Z] is not always case sensitive. Change to use [[:upper:]] Signed-off-by: Andy Green --- devtools/check-git-log.sh |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devtools/check-git-log.sh

[dpdk-dev] [PATCH v5 04/16] bus/dpaa: solve inconsistent struct alignment

2018-05-11 Thread Andy Green
The actual descriptor for qm_mr_entry is 64-byte aligned. But the original code plays a trick, and puts a u8 common to the three descriptor subtypes in the union afterwards outside their structure definitions. Unfortunately since they compose a struct qm_fd with alignment 8, this trick destroys t

[dpdk-dev] [PATCH v5 02/16] net/nfp: solve buffer overflow

2018-05-11 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In function ‘nfp_pf_pci_probe’: /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3160: 23: error: ‘%s’ directive writing up to 99 bytes into a region of size 76 [-Werror=format-overflow=] sprintf(fw_name, "%s/%s.nffw", DEFAULT_FW_PATH, ser

[dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code

2018-05-11 Thread Andy Green
In function ‘pci_get_kernel_driver_by_path’, inlined from ‘pci_scan_one.isra.1’ at /home/agreen/projects/dpdk/ drivers/bus/pci/linux/pci.c:317:8: /home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:57:3: error: ‘strncpy’ specified bound depends on the length of the source argument [-

[dpdk-dev] [PATCH v5 00/16] Fix default build on gcc8.0.1

2018-05-11 Thread Andy Green
This series allows dpdk master to build on Fedora 28, with the x86_64 default config. Acked-by: Neil Horman --- Andy Green (16): devtools/check-git: provide more generic grep pattern net/nfp: solve buffer overflow bus/pci: replace strncpy dangerous code bus/dpaa: solve i

Re: [dpdk-dev] [PATCH v4 18/18] app/test-bbdev: strcpy ok for allocated string

2018-05-11 Thread Andy Green
On 05/11/2018 09:02 PM, De Lara Guarch, Pablo wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green Sent: Friday, May 11, 2018 2:47 AM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v4 18/18] app/test-bbdev: strcpy ok for allocated string Signed-off-

[dpdk-dev] [PATCH 4/4] net/mlx5: use correct field in a union structure

2018-05-11 Thread Yongseok Koh
This is not a bug but it is better to use semantically correct field. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 587b22fc2..de3f869ed 100644 --- a/

[dpdk-dev] [PATCH 2/4] net/mlx5: fix potential buffer overflow

2018-05-11 Thread Yongseok Koh
Fixes: f0d61f8f8953 ("net/mlx5: add Multi-Packet Rx support") Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 387463792..c887d550f

[dpdk-dev] [PATCH 3/4] net/mlx5: use coherent I/O memory barrier

2018-05-11 Thread Yongseok Koh
Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index c887d550f..7605e2620 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c

[dpdk-dev] [PATCH 1/4] net/mlx5: fix offset calculation of Multi-Packet Rx

2018-05-11 Thread Yongseok Koh
Offset in a MPRQ buffer must be calculated before updating the stride index. Fixes: f0d61f8f8953 ("net/mlx5: add Multi-Packet Rx support") Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxt

Re: [dpdk-dev] [PATCH v4 16/18] app/proc-info: sprintf overrun bug

2018-05-11 Thread Andy Green
On 05/11/2018 08:26 PM, De Lara Guarch, Pablo wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green Sent: Friday, May 11, 2018 2:47 AM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v4 16/18] app/proc-info: sprintf overrun bug /home/agreen/projects/d

Re: [dpdk-dev] [PATCH v4 12/18] net/sfc: solve strncpy size and NUL

2018-05-11 Thread Andy Green
On 05/11/2018 06:55 PM, De Lara Guarch, Pablo wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green Sent: Friday, May 11, 2018 2:46 AM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v4 12/18] net/sfc: solve strncpy size and NUL Signed-off-by: Andy Gr

Re: [dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length

2018-05-11 Thread Andy Green
On 05/11/2018 06:51 PM, De Lara Guarch, Pablo wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green Sent: Friday, May 11, 2018 2:46 AM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length Signed-off-by: Andy Green

Re: [dpdk-dev] [PATCH v4 07/18] net/nfp/nfpcore: off-by-one and no NUL on strncpy use

2018-05-11 Thread Andy Green
On 05/11/2018 06:33 PM, De Lara Guarch, Pablo wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green Sent: Friday, May 11, 2018 2:46 AM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v4 07/18] net/nfp/nfpcore: off-by-one and no NUL on strncpy use /hom

Re: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison

2018-05-11 Thread Andy Green
On 05/12/2018 02:10 AM, Stephen Hemminger wrote: On Fri, 11 May 2018 16:32:24 + "De Lara Guarch, Pablo" wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green Sent: Friday, May 11, 2018 2:51 AM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH 2/4] ne

Re: [dpdk-dev] [PATCH v4 15/18] app: can't find include

2018-05-11 Thread Andy Green
On 05/11/2018 09:20 PM, De Lara Guarch, Pablo wrote: -Original Message- From: Andy Green [mailto:a...@warmcat.com] Sent: Friday, May 11, 2018 12:13 PM To: De Lara Guarch, Pablo ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 15/18] app: can't find include On 05/11/2018 07:04 PM,

Re: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-11 Thread Andy Green
On 05/12/2018 12:03 AM, Ferruh Yigit wrote: On 5/11/2018 2:51 AM, Andy Green wrote: This is stopping the compiler telling you when you have done something stupid... that is something none of us can afford... Now gcc 8.x can tell you did something stupid despite trying to hide the evidence. R

Re: [dpdk-dev] [PATCH v6 0/9] add framework to load and execute BPF code

2018-05-11 Thread Thomas Monjalon
11/05/2018 16:23, Ferruh Yigit: > On 5/10/2018 11:23 AM, Konstantin Ananyev wrote: > > Konstantin Ananyev (9): > > bpf: add BPF loading and execution framework > > bpf: add ability to load eBPF program from ELF object file > > bpf: add more logic into bpf_validate> bpf: add JIT compilation

Re: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison

2018-05-11 Thread Stephen Hemminger
On Fri, 11 May 2018 16:32:24 + "De Lara Guarch, Pablo" wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > > Sent: Friday, May 11, 2018 2:51 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable compari

[dpdk-dev] [PATCH v2] net/mlx5: fix inlining segmented TSO packet

2018-05-11 Thread Yongseok Koh
When a multi-segmented packet is inlined, data can be further inlined even after the first segment. In case of TSO packet, extra inline data after TSO header should be carried by an inline DSEG which has 4B inline header recording the length of the inline data. If more than one segment is inlined,

Re: [dpdk-dev] [PATCH v6 0/4] Hyper-V netvsc PMD and VMBus support

2018-05-11 Thread Stephen Hemminger
On Fri, 11 May 2018 17:50:37 +0100 Ferruh Yigit wrote: > On 5/9/2018 1:26 AM, Stephen Hemminger wrote: > > This is a revised version of the Hyper-V native bus (VMBus) > > and network device (netvsc) drivers. This virtual device > > is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 >

[dpdk-dev] [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap

2018-05-11 Thread Mohammad Abdul Awal
Updated the testpmd user guide documentation with how to used new action types RTE_FLOW_ACTION_VXLAN_ENCAP, RTE_FLOW_ACTION_VXLAN_DECAP, RTE_FLOW_ACTION_NVGRE_ENCAP, RTE_FLOW_ACTION_NVGRE_DECAP capabilities. Signed-off-by: Mohammad Abdul Awal --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 50

[dpdk-dev] [PATCH v2 1/2] app/testpmd: enabled vxlan and nvgre encap/decap support for rte_flow

2018-05-11 Thread Mohammad Abdul Awal
We have enabled testpmd application with ability to create a flow with vxlan/nvgre tunnel types and with encapsulation/decapsulation functionalities. Signed-off-by: Mohammad Abdul Awal --- app/test-pmd/cmdline_flow.c | 937 1 file changed, 937 inserti

[dpdk-dev] [PATCH v2 0/2] Added vxlan/nvgre encap/decap support to testpmd

2018-05-11 Thread Mohammad Abdul Awal
Changes in v2: * Added documentation in testpmd user guide. * Added vlan header for vxlan/nvgre encap. * Fixed other comments. In this patch set we have enabled testpmd application with ability to create a flow with vxlan/nvgre tunnel types and with encapsulation/decapsulation functionalities. W

Re: [dpdk-dev] [PATCH v4 09/18] net/qede: strncpy length constant and NUL

2018-05-11 Thread Shaikh, Shahed
> > >> > > >> +#include > > >> + > > >> #include "bcm_osal.h" > > >> #include "ecore.h" > > >> #include "ecore_spq.h" > > >> @@ -1104,9 +1106,9 @@ static enum _ecore_status_t > > >> ecore_int_deassertion(struct ecore_hwfn *p_hwfn, > > >>

Re: [dpdk-dev] [PATCH v6 0/4] Hyper-V netvsc PMD and VMBus support

2018-05-11 Thread Ferruh Yigit
On 5/9/2018 1:26 AM, Stephen Hemminger wrote: > This is a revised version of the Hyper-V native bus (VMBus) > and network device (netvsc) drivers. This virtual device > is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 > and Azure. Most of this code was extracted from FreeBSD and some

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] examples/ipsec-secgw: replace strncpy with strlcpy

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Reshma Pattan > Sent: Wednesday, May 9, 2018 5:11 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; sta...@dpdk.org; Zhang, > Roy Fan ; Pattan, Reshma > > Subject: [dpdk-stable] [PATCH v3] examples/ipsec-secg

Re: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Friday, May 11, 2018 2:51 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a > policy > > This is stopping the compiler telling you when you h

Re: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Friday, May 11, 2018 2:51 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: > In function

Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 4:36 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler >> Sent: Thursday, May 10, 2018 5:39 AM >> To: Yigit, Ferruh ; Lu, Wenzhuo >> ; Wu, Jingjing >> Cc: dev@dpdk.org; Dai, Wei ; Zhang, Qi Z >> >> Subjec

[dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all

2018-05-11 Thread Andrew Rybchenko
Do not allow to request unsupported Tx offload since all checks are removed from PMDs because of consistency check in ethdev. Otherwise application may rely on offload which is not actually supported and send traffic with, for example, wrong checksums, truncated packets or packets with garbage. Fi

[dpdk-dev] [PATCH 3/3] ethdev: fail if Rx queue offload is not supported

2018-05-11 Thread Andrew Rybchenko
Return of error was removed to mitigate possible breakage of old applications which are not converted to the new offload API yet. However, old Rx offload API has no per queue controls and Rx queue offloads are derived from the device Rx mode bitfields exactly in the same way as it is done on config

[dpdk-dev] [PATCH 0/3] ethdev: fail if requested offload is not supported

2018-05-11 Thread Andrew Rybchenko
The series has fixes for problems discussed in [1]. Basically it does not allow unsupported offloads to pass. If fixes regressions for PMDs which carefully check offloads before, but these checks are removed now in favor of checks in ethdev. It may break applications which request some offload w

[dpdk-dev] [PATCH 1/3] ethdev: fail configure if requested offload is not supported

2018-05-11 Thread Andrew Rybchenko
Do not allow allow unsupported offload to be passed to PMD since in can result in inconsistent NIC configuration and processing in the driver. All PMDs are converted to the new offload API and must report its capabilties correctly. Both device and queue offloads are listed in [rt]x_offload_capa so

Re: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Friday, May 11, 2018 2:51 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized > > > --- Missing signed-off-by and fixes line: Fixes: ccdcba5

Re: [dpdk-dev] [PATCH 4/4] net/bnx2x: solve overruns

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Friday, May 11, 2018 2:52 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 4/4] net/bnx2x: solve overruns > As Ferruh said, Signed-off-by is missing, plus fixes line and Cc stable Fixes: 540

Re: [dpdk-dev] [PATCH v1] net/failsafe: add an RSS hash update callback

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 9:31 AM, Gaëtan Rivet wrote: > Hi Ophir, > > On Thu, May 10, 2018 at 02:38:10PM +, Ophir Munk wrote: >> Add an RSS hash update callback to eth_dev_ops. >> >> Signed-off-by: Ophir Munk > > Thank you for submitting this, the patch is clean. > > Acked-by: Gaetan Rivet Applied to

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: improve doc for name by port ID API

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 5:09 PM, Ferruh Yigit wrote: > On 5/11/2018 3:05 PM, Andrew Rybchenko wrote: >> From: Ivan Malov >> >> Description of rte_eth_dev_get_name_by_port() calls >> port ID argument a pointer, which is misleading. >> Also, output buffer minimal size is not mentioned. >> These points need to

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix slave port detection

2018-05-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, April 22, 2018 11:58 PM > To: Lu, Wenzhuo ; Doherty, Declan > > Cc: sta...@dpdk.org; Matan Azrad ; dev@dpdk.org; > Yigit, Ferruh > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app

Re: [dpdk-dev] [PATCH] ethdev: improve doc for name by port ID API

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 3:05 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Description of rte_eth_dev_get_name_by_port() calls > port ID argument a pointer, which is misleading. > Also, output buffer minimal size is not mentioned. > These points need to be improved. > > Fixes: bde516d5a85a ("ethdev: g

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-11 Thread Andrew Rybchenko
On 05/11/2018 05:22 PM, Ferruh Yigit wrote: On 5/11/2018 8:07 AM, Andrew Rybchenko wrote: Hi all, I think that Rx/Tx offloads checks behaviour is inconsistent in next-net as of today. Consistency checks are removed from PMDs and substituted with error logs in ethdev. Yes. Basically applicat

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix missing Port Representor data-path

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 3:04 PM, Mohammad Abdul Awal wrote: > > > On 11/05/2018 13:28, Remy Horton wrote: >> This patch adds Rx and Tx burst functions to the i40e Port >> Representors, so that the implementation within this PMD >> can be tested using applications such as testpmd which >> require data-path f

Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix missing Port Representor data-path

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 3:04 PM, Mohammad Abdul Awal wrote: > > > On 11/05/2018 13:28, Remy Horton wrote: >> This patch adds Rx and Tx burst functions to the ixgbe >> Port Representors, so that the implementation within >> ixgbe PMD can be tested using applications such as >> testpmd which require data-path

Re: [dpdk-dev] [PATCH 0/4] GCC8 fixes for MLX4/5/BNX2X PMD

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 2:51 AM, Andy Green wrote: > The following series fixes build breakage if you > additionally enable > > CONFIG_RTE_LIBRTE_MLX4_PMD > CONFIG_RTE_LIBRTE_MLX5_PMD > CONFIG_RTE_LIBRTE_BNX2X_PMD > > --- > > Andy Green (4): > net/bnx2x: do not cast function pointers as a policy >

Re: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 2:51 AM, Andy Green wrote: > This is stopping the compiler telling you when you have > done something stupid... that is something none of us > can afford... > > Now gcc 8.x can tell you did something stupid despite > trying to hide the evidence. > > Remove all the "black magic" casts

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/quota_watermark: fix gcc 8.0.1 cast between incompatible types

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Reshma Pattan > Sent: Wednesday, May 9, 2018 12:35 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Pattan, Reshma > Subject: [dpdk-stable] [PATCH] examples/quota_watermark: fix gcc 8.0.1 cast > between incompa

Re: [dpdk-dev] [PATCH] examples: fix typdef in performance thread app

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, May 10, 2018 6:31 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; Hunt, David > > Subject: [dpdk-dev] [PATCH] examples: fix typdef in performance thread app > > The function pthread_cre

Re: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue status

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 10:51 AM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Zhang, Qi Z >> Sent: Friday, May 11, 2018 10:24 AM >> To: Ananyev, Konstantin ; Wu, Yanglong >> ; dev@dpdk.org >> Cc: Lu, Wenzhuo ; Wu, Yanglong >> Subject: RE: [dpdk-dev] [PATCH] ethdev: fix checking R

Re: [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, May 10, 2018 8:38 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Hunt, David > > Subject: [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test > > New warning with g

Re: [dpdk-dev] [PATCH v4 13/18] net/vdev_netvsc: readlink inputs cannot be aliased

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Friday, May 11, 2018 2:46 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 13/18] net/vdev_netvsc: readlink inputs cannot > be aliased > > /home/agreen/projects/dpdk/drivers/net/vdev_netvs

Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported

2018-05-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Thursday, May 10, 2018 5:39 AM > To: Yigit, Ferruh ; Lu, Wenzhuo > ; Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC stri

[dpdk-dev] [PATCH v2] net/avf: fix Rx interrupt mapping

2018-05-11 Thread Jingjing Wu
Vector used for rx mapping is different if WB_ON_ITR is supported. The mapping table need to be updated. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-by: Jingjing Wu Cc: sta...@dpdk.org --- v2 change: - replace vector 0 constant by msix_base drivers/net/avf/avf_ethdev.c | 7

Re: [dpdk-dev] [PATCH] net/tap: add default name to tun

2018-05-11 Thread Stephen Hemminger
On Fri, 11 May 2018 14:11:59 +0530 Vipin Varghese wrote: > The change adds default name to reflect TUN PMD instance. if option > name is not passed, the default dtun is taken. > > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 3 +++ > 1 file changed, 3 insertions(+) >

[dpdk-dev] [PATCH v2] net/avf: fix Rx interrupt mapping

2018-05-11 Thread Jingjing Wu
Vector used for rx mapping is different if WB_ON_ITR is supported. The mapping table need to be updated. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-by: Jingjing Wu Cc: sta...@dpdk.org --- v2 change: - replace vector 0 constant by msix_base drivers/net/avf/avf_ethdev.c | 7

  1   2   3   >