> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, April 22, 2018 11:58 PM > To: Lu, Wenzhuo <wenzhuo...@intel.com>; Doherty, Declan > <declan.dohe...@intel.com> > Cc: sta...@dpdk.org; Matan Azrad <ma...@mellanox.com>; dev@dpdk.org; > Yigit, Ferruh <ferruh.yi...@intel.com> > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix slave port > detection > > Wenzhuo, Declan, > Any comment or ack, please? > > 28/03/2018 13:17, Matan Azrad: > > Testpmd allows to create and control bonding devices by run time > > command lines using the bonding PMD API. > > > > Some bonding device slaves operations(close, stop, etc) should not be > > used by the application and must be managed by the bonding PMD. > > > > Thus, Testpmd manages slave flags to prevent the special operations > > calls and when a slave is added to bonding device by a run time > > command line, the flag is set. > > > > There is one more way to define the slaves for a bonding device using > > EAL command line and Testpmd doesn't set the slave flag in this case > > what causes to the special operations to be called by Testpmd. > > > > Add one more check to detect bonding slave device. > > > > Fixes: 41b05095c4d1 ("app/testpmd: fix bonding start") > > Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in > > bonding") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Matan Azrad <ma...@mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremon...@intel.com>
