Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-08 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Ravi Kumar [mailto:ravi1.ku...@amd.com] >> Sent: Thursday, May 3, 2018 6:57 AM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; >> tho...@monjalon.net; hemant.agra...@nxp.com >> Subject: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver

Re: [dpdk-dev] [PATCH net-next v4 0/4] set ixgbe/ixgbevf EITR for performance

2018-05-08 Thread Zhang, Qi Z
> -Original Message- > From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] > Sent: Saturday, April 28, 2018 11:04 AM > To: Zhang, Qi Z ; Yigit, Ferruh > ; > Zhang, Helin ; Xing, Beilei ; > Dai, Wei > Cc: dev@dpdk.org; Tonghao Zhang > Subject: [PATCH net-next v4 0/4] set ix

Re: [dpdk-dev] [PATCH 1/5] bus/dpaa: support device blacklisting

2018-05-08 Thread Shreyansh Jain
On Wednesday 25 April 2018 06:26 PM, Hemant Agrawal wrote: Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa_sec.rst | 13 + doc/guides/nics/dpaa.rst | 10 drivers/bus/dpaa/dpaa_bus.c| 101 ++--- drivers/bus/dpaa/rte_dp

Re: [dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping

2018-05-08 Thread Lu, Wenzhuo
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Thursday, May 3, 2018 11:09 AM > To: Lu, Wenzhuo > Cc: Wu, Jingjing ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/avf: fix Rx interrupt mapping > > Vector used for rx mapping is different if WB_ON_ITR is supported. T

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix feature setting with vhost-net backend

2018-05-08 Thread Yao, Lei A
> -Original Message- > From: Hu, Jiayu > Sent: Tuesday, May 8, 2018 4:15 PM > To: dev@dpdk.org > Cc: Bie, Tiwei ; Yang, Zhiyong > ; maxime.coque...@redhat.com; Yao, Lei A > ; Hu, Jiayu > Subject: [PATCH v2] net/virtio-user: fix feature setting with vhost-net > backend > > When the backe

Re: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers

2018-05-08 Thread Jerin Jacob
-Original Message- > Date: Tue, 8 May 2018 07:49:01 + > From: Ali Alnubani > To: 'Pavan Nikhilesh' , > "jerin.ja...@caviumnetworks.com" , > "santosh.shu...@caviumnetworks.com" , > "ferruh.yi...@intel.com" , Shahaf Shuler > > CC: "dev@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH] dr

Re: [dpdk-dev] [v4, 5/5] doc: add event crypto adapter documentation

2018-05-08 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 01:16:04 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

[dpdk-dev] [PATCH v2 17/18] app/test-bbdev: test-bbdev: strcpy ok for allocated string

2018-05-08 Thread Andy Green
Signed-off-by: Andy Green --- app/test-bbdev/test_bbdev_vector.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index addef0572..5ad2a6535 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/tes

[dpdk-dev] [PATCH v2 18/18] app/test-bbdev: strcpy ok for allocated string

2018-05-08 Thread Andy Green
Signed-off-by: Andy Green --- app/test-bbdev/test_bbdev_vector.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index 5ad2a6535..373f94984 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/t

[dpdk-dev] [PATCH v2 07/18] drivers/net/nfp: don't memcpy out of source range

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2: error: ‘memcpy’ forming offset [5, 6] is out of the bounds [0, 4] of object ‘tmp’ with type ‘uint32_t’ {aka ‘unsigned int’} [-Werror=array-bounds] memcpy(&hw->mac_addr[0], &tmp, sizeof(struct ether_addr)); Signed-off-by: Andy Green ---

[dpdk-dev] [PATCH v2 06/18] drivers/net/nfp/nfpcore: fix off-by-one and no NUL on strncpy use

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c: 76:2:error: ‘strncpy’ output may be truncated copying 8 bytes from a string of length 8 [-Werror=stringop-truncation] strncpy(name_pad, res->name, sizeof(name_pad)); Signed-off-by: Andy Green --- drivers/net/nfp/nfpcore/nfp_res

Re: [dpdk-dev] [v4, 3/5] eventdev: add crypto adapter implementation

2018-05-08 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 01:16:02 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

Re: [dpdk-dev] [v4, 2/5] eventdev: add APIs and PMD callbacks for crypto adapter

2018-05-08 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 01:16:01 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

Re: [dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter

2018-05-08 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 01:16:00 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

[dpdk-dev] [PATCH v2 11/18] drivers/net/sfc: fix strncpy length

2018-05-08 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/sfc/sfc_ethdev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index e42d55350..ef5e9ecb2 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c

[dpdk-dev] [PATCH v2 12/18] drivers/net/sfc: fix strncpy size and NUL

2018-05-08 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/sfc/sfc_ethdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index ef5e9ecb2..a8c0f8e19 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@

[dpdk-dev] [PATCH v2 08/18] drivers/net/nfp: fix buffer overflow in fw_name

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In function ‘nfp_pf_pci_probe’: /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3160: 23: error: ‘%s’ directive writing up to 99 bytes into a region of size 76 [-Werror=format-overflow=] sprintf(fw_name, "%s/%s.nffw", DEFAULT_FW_PATH, ser

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Dai, Wei
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Wednesday, May 9, 2018 1:52 AM > To: Dai, Wei ; Yigit, Ferruh ; > tho...@monjalon.net; shah...@mellanox.com; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx of

[dpdk-dev] [Bug 41] testpmd failed with net_failsafe error

2018-05-08 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=41 Bug ID: 41 Summary: testpmd failed with net_failsafe error Product: DPDK Version: 18.05 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal Prio

Re: [dpdk-dev] [PATCH] event/octeontx: fix clang 6 linker error

2018-05-08 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 02:56:00 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > arybche...@solarflare.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] event/octeontx: fix clang 6 linker err

[dpdk-dev] [PATCH v2 10/18] drivers/net/qede: fix broken strncpy

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function ‘qed_slowpath_start’: /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: error: ‘strncpy’ output may be truncated copying 12 bytes from a string of length 127 [-Werror=stringop-truncation] strncpy((char *)drv_versio

[dpdk-dev] [PATCH v2 03/18] drivers/bus/dpaa: fix inconsistent struct alignment

2018-05-08 Thread Andy Green
The actual descriptor for qm_mr_entry is 64-byte aligned. But the original code plays a trick, and puts a u8 common to the three descriptor subtypes in the union afterwards outside their structure definitions. Unfortunately since they compose a struct qm_fd with alignment 8, this trick destroys t

[dpdk-dev] [PATCH v2 09/18] drivers/net/qede: fix strncpy constant and NUL

2018-05-08 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/qede/base/ecore_int.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c index f43781ba4..d9e22b5ed 100644 --- a/drivers/net/qede/base/ecore_int.c +++ b/dri

[dpdk-dev] [PATCH v2 16/18] app/proc-info: fix sprintf overrun bug

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/app/proc-info/main.c: In function ‘nic_xstats_display’: /home/agreen/projects/dpdk/app/proc-info/main.c:495:45: error: ‘%s’ directive writing up to 255 bytes into a region of size between 165 and 232 [-Werror=format-overflow=] sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/

[dpdk-dev] [PATCH v2 04/18] drivers/net/axgbe: fix broken eeprom string comp

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/axgbe/axgbe_phy_impl.c:576:6: error: ‘__builtin_memcmp_eq’ reading 16 bytes from a region of size 9 [-Werror=stringop-overflow=] if (memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_NAME], ^ AXGBE

[dpdk-dev] [PATCH v2 05/18] drivers/net/nfp/nfpcore: fix strncpy misuse

2018-05-08 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c index 4e6c66624..52b294888 100644 --- a/drivers/net/nfp/nfpco

[dpdk-dev] [PATCH v2 13/18] drivers/net/vdev: readlink inputs cannot be aliased

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/vdev_netvsc/ vdev_netvsc.c:335:2:error: passing argument 2 to restrict- qualified parameter aliases with argument 1 [-Werror=restrict] ret = readlink(buf, buf, size); ^~~ Signed-off-by: Andy Green --- drivers/net/vdev_netvsc/vdev_netvsc.c |8 +--

[dpdk-dev] [PATCH v2 15/18] app/test-pmd: can't find include

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10: fatal error: rte_pmd_dpaa.h: No such file or directory #include ^~~~ Signed-off-by: Andy Green --- app/test-pmd/Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Ma

[dpdk-dev] [PATCH v2 14/18] drivers/net/vdev: fix 3 x strncpy misuse

2018-05-08 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/vdev_netvsc/vdev_netvsc.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index e0d3c1c7c..41662304b 100644 --- a/drivers/net/vdev_netvsc/vdev_net

[dpdk-dev] [PATCH v2 00/18] Fix build on gcc8 and various bugs

2018-05-08 Thread Andy Green
The following series gets current master able to build on Fedora 28 + x86_64 using gcc 8.0.1. There were a surprising number of problems, mostly around correct string processing. Of the two major issues, one around struct alignment in dpaa I think is properly fixed by the patch 3/18 here, but for

[dpdk-dev] [PATCH v2 02/18] drivers/bus/pci: fix strncpy dangerous code

2018-05-08 Thread Andy Green
In function ‘pci_get_kernel_driver_by_path’, inlined from ‘pci_scan_one.isra.1’ at /home/agreen/projects/dpdk/ drivers/bus/pci/linux/pci.c:317:8: /home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:57:3: error: ‘strncpy’ specified bound depends on the length of the source argument [-

[dpdk-dev] [PATCH v2 01/18] lib/libtre_table: workaround hash function cast error

2018-05-08 Thread Andy Green
/home/agreen/projects/dpdk/lib/librte_table/rte_table_hash_cuckoo.c: 110:16: error: cast between incompatible function types from ‘rte_table_hash_op_hash’ {aka ‘long unsigned int (*)(void *, void *, unsigned int, long unsigned int)’} to ‘uint32_t (*)(const void *, uint32_t, uint32_t)’ {aka ‘unsig

Re: [dpdk-dev] [PATCH v9 1/4] bus/ifpga: Add Intel FPGA BUS Library

2018-05-08 Thread Xu, Rosen
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, May 08, 2018 22:43 > To: Xu, Rosen > Cc: dev@dpdk.org; Doherty, Declan ; > Richardson, Bruce ; shreyansh.j...@nxp.com; > Yigit, Ferruh ; Ananyev, Konstantin > ; Zhang, Tianfei ; > Liu, So

Re: [dpdk-dev] [PATCH v9 2/4] iFPGA: Add Intel FPGA OPAE Share Code

2018-05-08 Thread Xu, Rosen
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, May 08, 2018 22:45 > To: Xu, Rosen > Cc: dev@dpdk.org; Doherty, Declan ; > Richardson, Bruce ; shreyansh.j...@nxp.com; > Yigit, Ferruh ; Ananyev, Konstantin > ; Zhang, Tianfei ; > Liu, So

[dpdk-dev] [PATCH v1 3/3] net/mlx5: fix SW parser enabling

2018-05-08 Thread Xueming Li
Fixes: 5f8ba81c4228 ("net/mlx5: support generic tunnel offloading") Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_ethdev.c | 4 +++- drivers/net/mlx5/mlx5_txq.c| 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx

2018-05-08 Thread Xueming Li
Add document for hw header parsing and SWP. Signed-off-by: Xueming Li --- doc/guides/nics/mlx5.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 853c48f81..bc08515cf 100644 --- a/doc/guides/nics/mlx5.rst +++ b/do

[dpdk-dev] [PATCH v1 2/3] net/mlx5: fix SW parsing feature detection

2018-05-08 Thread Xueming Li
Fixes: 5f8ba81c4228 ("net/mlx5: support generic tunnel offloading") Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 5190b9fcd..3885b0bf0 100644 --- a/drivers/net/mlx5

[dpdk-dev] [PATCH v6 2/4] net/netvsc: add hyper-v netvsc network device

2018-05-08 Thread Stephen Hemminger
The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). Signed-off-by: Stephen Hemminger --- MAIN

[dpdk-dev] [PATCH v6 3/4] net/netvsc: add documentation

2018-05-08 Thread Stephen Hemminger
From: Stephen Hemminger Matching documentation for new netvsc device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/netvsc.ini| 23 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst | 98 ++ doc/guides/rel_n

[dpdk-dev] [PATCH v6 1/4] bus/vmbus: add hyper-v virtual bus support

2018-05-08 Thread Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported at present, but the code

[dpdk-dev] [PATCH v4 4/4] bus/vmbus and net/netvsc: add meson build support

2018-05-08 Thread Stephen Hemminger
From: Stephen Hemminger Update meson build files for new netvsc and vmbus drivers. Signed-off-by: Stephen Hemminger --- config/meson.build | 7 +++ drivers/bus/meson.build| 2 +- drivers/bus/vmbus/meson.build | 16 drivers/net/meson.build| 2

[dpdk-dev] [PATCH v6 0/4] Hyper-V netvsc PMD and VMBus support

2018-05-08 Thread Stephen Hemminger
This is a revised version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Onl

Re: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL

2018-05-08 Thread Shaikh, Shahed
> >>> I think you can retain OSAL_STRNCPY and just replace 30 with > >> 'bit_name[sizeof(bit_name) - 1' and then set last byte with '\0' just > >> like you > did. > >> > >> Can that actually be fixed inside OSAL_STRNCPY itself, rather than > >> having each use needing to explicitly null-terminat

Re: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL

2018-05-08 Thread Andy Green
On 05/09/2018 04:02 AM, Shaikh, Shahed wrote: -Original Message- From: dev On Behalf Of Bruce Richardson Sent: Tuesday, May 8, 2018 2:53 PM To: dev-boun...@dpdk.org Cc: Andy Green ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL On

[dpdk-dev] [PATCH] event/octeontx: fix clang 6 linker error

2018-05-08 Thread Pavan Nikhilesh
Clang 6 & 7 fail to naturally align packed structs due to this clang can't use 8byte atomic primitives and splits them into lesser atomic primitives. To use lesser atomic primitives we need to link libatomic (-latomic), instead supply alignment attribute to the compiler. timvf_worker.c:(.text+0x49

Re: [dpdk-dev] [PATCH v4 0/5] Initial compressdev unit tests

2018-05-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, May 4, 2018 11:22 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Daly, Lee ; > shally.ve...@cavium.com; ahmed.mans...@nxp.com; > ashish.gu...@cavium.com; De Lara Guarch, Pablo > > Subject: [PATCH v4 0/5] Initial compressdev u

Re: [dpdk-dev] [PATCH v6 00/14] Implement compression API

2018-05-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, April 27, 2018 2:24 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; shally.ve...@cavium.com; > ahmed.mans...@nxp.com; ashish.gu...@cavium.com; De Lara Guarch, Pablo > ; Shally Verma > ; Ashish Gupta > > Subject: [PATCH v6 00/1

Re: [dpdk-dev] [PATCH] crypto/ccp: add meson build

2018-05-08 Thread Bruce Richardson
On Thu, May 03, 2018 at 03:19:23AM -0400, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar > --- Acked-by: Bruce Richardson Applied to dpdk-next-build Thanks, /Bruce

Re: [dpdk-dev] [PATCH v2 0/3] small improvements to meson build

2018-05-08 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 03:37:10PM +0100, Luca Boccassi wrote: > On Fri, 2018-04-27 at 14:49 +0100, Bruce Richardson wrote: > > A few small improvements and fixes for the meson build system, > > including > > improved behaviour for building kmods - especially on cross-compile, > > a fix > > for our

Re: [dpdk-dev] [PATCH v2 2/2] mem: unmap unneeded space

2018-05-08 Thread Thomas Monjalon
02/05/2018 23:00, Thomas Monjalon: > 30/04/2018 14:50, Bruce Richardson: > > On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote: > > > When we ask to reserve virtual areas, we usually include > > > alignment in the mapping size, and that memory ends up > > > being wasted. Wasting a gig

Re: [dpdk-dev] [PATCH 18.05-RC3 v2] mem: add argument to mem event callbacks

2018-05-08 Thread Thomas Monjalon
04/05/2018 09:35, Maxime Coquelin: > Hi Anatoly, > > On 05/03/2018 10:28 AM, Anatoly Burakov wrote: > > It may be useful to pass arbitrary data to the callback (such > > as device pointers), so add this to the mem event callback API. > > > > Signed-off-by: Anatoly Burakov > > Suggested-by: Maxim

Re: [dpdk-dev] [PATCH] net/i40e: fix missing defines for non-AVX builds

2018-05-08 Thread Bruce Richardson
On Tue, May 08, 2018 at 09:10:17PM +0100, Bruce Richardson wrote: > For non-AVX builds, the cflags used for compiling the i40e driver files > are not passed to the call to build the AVX-specific code path. This can > cause build failures. > > ../drivers/net/i40e/i40e_ethdev.h:888:42: error: ‘I40E_

[dpdk-dev] [PATCH] net/i40e: fix missing defines for non-AVX builds

2018-05-08 Thread Bruce Richardson
For non-AVX builds, the cflags used for compiling the i40e driver files are not passed to the call to build the AVX-specific code path. This can cause build failures. ../drivers/net/i40e/i40e_ethdev.h:888:42: error: ‘I40E_PFQF_HKEY_MAX_INDEX’ undeclared here (not in a function) Fixes: e940646b20

Re: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL

2018-05-08 Thread Shaikh, Shahed
> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Tuesday, May 8, 2018 2:53 PM > To: dev-boun...@dpdk.org > Cc: Andy Green ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant > and NUL > > On Tue, May 08, 2018 at 05:59:47PM

Re: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL

2018-05-08 Thread Bruce Richardson
On Tue, May 08, 2018 at 05:59:47PM +, dev-boun...@dpdk.org wrote: > > > > -Original Message- > > From: dev On Behalf Of Andy Green > > Sent: Monday, May 7, 2018 11:30 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant > > and > > N

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-05-08 Thread Bruce Richardson
On Tue, May 08, 2018 at 02:28:25PM +, Dumitrescu, Cristian wrote: > > > > -Original Message- > > From: Zhang, Roy Fan > > Sent: Monday, April 16, 2018 12:03 PM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > > > Subject: [PATCH] examples/ip_pipeline: fix buff

[dpdk-dev] [v4,5/5] doc: add event crypto adapter documentation

2018-05-08 Thread Abhinandan Gujjar
Add entries in the programmer's guide, API index, maintainer's file and release notes for the event crypto adapter. Signed-off-by: Abhinandan Gujjar Acked-by: Jerin Jacob --- MAINTAINERS|1 + doc/api/doxy-api-index.md |1 +

[dpdk-dev] [v4, 2/5] eventdev: add APIs and PMD callbacks for crypto adapter

2018-05-08 Thread Abhinandan Gujjar
Signed-off-by: Abhinandan Gujjar Acked-by: Jerin Jacob --- drivers/event/sw/sw_evdev.c | 13 ++ lib/librte_eventdev/rte_eventdev.c | 25 lib/librte_eventdev/rte_eventdev.h | 53 +++- lib/librte_eventdev/rte_eventdev_pmd.h | 187 +

[dpdk-dev] [v4,4/5] test: add event crypto adapter auto-test

2018-05-08 Thread Abhinandan Gujjar
Signed-off-by: Abhinandan Gujjar --- MAINTAINERS | 1 + test/test/Makefile| 2 + test/test/test_event_crypto_adapter.c | 927 ++ 3 files changed, 930 insertions(+) create mode 100644 test/test/test_event_crypto_ada

[dpdk-dev] [v4,3/5] eventdev: add crypto adapter implementation

2018-05-08 Thread Abhinandan Gujjar
Event crypto adapter is added to the meson build system Signed-off-by: Abhinandan Gujjar Signed-off-by: Nikhil Rao Signed-off-by: Gage Eads --- config/common_base |1 + config/rte_config.h|1 + lib/Makefile

[dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter

2018-05-08 Thread Abhinandan Gujjar
Signed-off-by: Abhinandan Gujjar Signed-off-by: Nikhil Rao Signed-off-by: Gage Eads --- MAINTAINERS| 5 + lib/librte_eventdev/rte_event_crypto_adapter.h | 575 + 2 files changed, 580 insertions(+) create mode 100644 lib/librte_event

[dpdk-dev] [v4,0/5] eventdev: cover letter - crypto adapter

2018-05-08 Thread Abhinandan Gujjar
This patchset introduces the event crypto adapter which is intended to bridge between event devices and crypto devices. Addition of the event crypto adapter into eventdev library extends the event driven programming model with crypto devices. This patchset has dependency on below cryptodev patchse

Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error

2018-05-08 Thread Yongseok Koh
> On May 8, 2018, at 2:11 AM, Raslan Darawsheh wrote: > > If something went wrong in mlx5 pci prop the allocated eth dev > will cause a memory leak. > > This commit release the eth dev that was previously allocated. > > Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4

Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling

2018-05-08 Thread Yongseok Koh
> On May 8, 2018, at 2:11 AM, Raslan Darawsheh wrote: > > When attr_ctx is NULL it will attempt to free the list of devices twice. > Avoid double freeing the list by directly going to error handling. > > Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 > adapters") > Cc

[dpdk-dev] [PATCH] net/mlx5: fix calculation of Tx TSO inline room size

2018-05-08 Thread Yongseok Koh
rdma-core doesn't add up max_tso_header size to max_inline_data size. The library takes bigger value between the two. Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_txq.c | 12 --

Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-05-08 Thread De Lara Guarch, Pablo
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Tuesday, May 8, 2018 11:58 AM > To: Trahe, Fiona ; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish ; > dev@dpdk.org; Sahu, Sunila ; Gu

[dpdk-dev] [PATCH v1] net/failsafe: report on supported RSS functions

2018-05-08 Thread Ophir Munk
Report on failsafe supported RSS functions as part of dev_infos_get callback. Set failsafe default RSS hash functions to be: ETH_RSS_IP, ETH_RSS_UDP and ETH_RSS_TCP. The net result of failsafe RSS hash functions is the logical AND of the RSS hash functions among all failsafe sub_devices and failsaf

Re: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL

2018-05-08 Thread Shaikh, Shahed
> -Original Message- > From: dev On Behalf Of Andy Green > Sent: Monday, May 7, 2018 11:30 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and > NUL > > > --- > drivers/net/qede/base/ecore_int.c | 10 ++ > 1 file changed, 6

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Andrew Rybchenko
On 05/08/2018 01:10 PM, Wei Dai wrote: This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_confi

[dpdk-dev] [pull-request] next-tm 18.05 pre-rc3

2018-05-08 Thread Cristian Dumitrescu
The following changes since commit 211992f3b7df5d6d8f1dbefc48bc37a6d5398fbc: examples/flow_classify: fix validation in port init (2018-04-30 15:48:26 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-qos for you to fetch changes up to 06e2b9d59f4e1d85b4131e

[dpdk-dev] [PATCH v2] net/tap: report on supported RSS hash functions

2018-05-08 Thread Ophir Munk
Report on TAP supported RSS functions as part of dev_infos_get callback: ETH_RSS_IP, ETH_RSS_UDP and ETH_RSS_TCP. Known limitation: TAP supports all of the above hash functions together and not in partial combinations. Previous to this commit RSS support was reported as none. Since the introduction

[dpdk-dev] [pull-request] next-pipeline 18.05 pre-rc3

2018-05-08 Thread Cristian Dumitrescu
The following changes since commit e2077a158e22451144d1b023f949f3232cfa62b3: doc: add DPAA2 QDMA rawdev guide (2018-05-08 12:21:13 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to 93428c4929c97f9cd7b8cbf449070a2924501

[dpdk-dev] [PATCH v1] net/tap: report on supported RSS hash functions

2018-05-08 Thread Ophir Munk
Report on TAP supported RSS functions as part of dev_infos_get callback: ETH_RSS_IP, ETH_RSS_UDP and ETH_RSS_TCP. Known limitation: TAP supports all of the above hash functions together and not in partial combinations. Previous to this commit RSS support was reported as none. Since the introduction

Re: [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload

2018-05-08 Thread Ferruh Yigit
On 5/7/2018 6:08 AM, Xing, Beilei wrote: > > >> -Original Message- >> From: Zhang, Qi Z >> Sent: Monday, May 7, 2018 9:26 AM >> To: Yigit, Ferruh >> Cc: Xing, Beilei ; dev@dpdk.org; Zhang, Qi Z >> >> Subject: [PATCH] net/i40e: fix missing mbuf fast free offload >> >> Expose the missing

Re: [dpdk-dev] [PATCH] table: add dedicated params struct for cuckoo hash

2018-05-08 Thread Dumitrescu, Cristian
From: Andy Green [mailto:a...@warmcat.com] Sent: Tuesday, May 8, 2018 3:35 PM To: dev@dpdk.org; Singh, Jasvinder Cc: Dumitrescu, Cristian Subject: Re: [dpdk-dev] [PATCH] table: add dedicated params struct for cuckoo hash On May 8, 2018 10:17:18 PM GMT+08:00, Jasvinder Singh mailto:jasvinde

Re: [dpdk-dev] [PATCH 00/12] bnxt patchset

2018-05-08 Thread Ferruh Yigit
On 5/1/2018 2:06 AM, Ajit Khaparde wrote: > Patchset against dpdk-next-net. > Please apply. > > Ajit Khaparde (3): > net/bnxt: fix MTU calculation > net/bnxt: fix to reset status of initialization > net/bnxt: fix usage of vnic id > > Jay Ding (2): > net/bnxt: return EINVAL instead of ENOS

Re: [dpdk-dev] armv8 counter - kernel module

2018-05-08 Thread Thomas Monjalon
08/05/2018 18:18, Hemant Agrawal: > HI Jerin/Thomas, > > We now have the different folder for kernel modules. > > Do you think it make sense to have armv8_pmu counter module to be part of > dpdk tree instead of a github based individual repo? > > The current location is: > https://github.com/je

[dpdk-dev] armv8 counter - kernel module

2018-05-08 Thread Hemant Agrawal
HI Jerin/Thomas, We now have the different folder for kernel modules. Do you think it make sense to have armv8_pmu counter module to be part of dpdk tree instead of a github based individual repo? The current location is: https://github.com/jerinjacobk/armv8_pmu_cycle_counter

Re: [dpdk-dev] [PATCH 2/2] crypto/scheduler: fix memory leak

2018-05-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, May 8, 2018 1:45 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH 2/2] crypto/scheduler: fix memory leak > > > > > -Original Message- > > From: De Lara Guarch, Pablo > > Sent:

Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after freeing

2018-05-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, May 8, 2018 12:29 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH 1/2] crypto/scheduler: set null pointer after freeing > > > > > -Original Message- > > From: De Lara Guarch,

Re: [dpdk-dev] [PATCH v4 0/5] Initial compressdev unit tests

2018-05-08 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, May 4, 2018 11:22 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Daly, Lee ; > shally.ve...@cavium.com; > ahmed.mans...@nxp.com; ashish.gu...@cavium.com; De Lara Guarch, Pablo > > Subject: [PATCH v4 0/5] Initial compressdev

[dpdk-dev] [PATCH v1] net/mlx4: report on supported RSS hash functions

2018-05-08 Thread Ophir Munk
Report on mlx4 supported RSS functions as part of dev_infos_get callback. Previous to this commit RSS support was reported as none. Since the introduction of [1] it is required that all RSS configurations will be verified. [1] commit 8863a1fbfc66 ("ethdev: add supported hash function check") Sign

Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd: add new commands to test new Tx/Rx offloads

2018-05-08 Thread Ferruh Yigit
On 5/8/2018 2:30 PM, Dai, Wei wrote: > Hi, Ferruh > > Thanks for your feedback. > I lost your mail but I can found it in > http://dpdk.org/ml/archives/dev/2018-April/096900.html > I will update new version of this patch for new offload API in my v8 big > patch for ethdev: check offloads. > As my

Re: [dpdk-dev] [PATCH V21 2/4] eal: add failure handle mechanism for hot plug

2018-05-08 Thread Ananyev, Konstantin
> -Original Message- > From: Guo, Jia > Sent: Tuesday, May 8, 2018 3:57 PM > To: Ananyev, Konstantin ; > step...@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; > gaetan.ri...@6wind.com; Wu, Jingjing > ; tho...@monjalon.net; mo...@mellanox.com; > ma...@mellanox.com; Van Haare

Re: [dpdk-dev] [PATCH v2 1/6] lib/cryptodev: add asymmetric algos in cryptodev

2018-05-08 Thread Trahe, Fiona
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, April 5, 2018 12:25 PM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan ; Trahe, Fiona > ; > pathr...@caviumnetworks.com; ss...@caviumnetworks.com; > agu...@caviumnetworks.com; > dev@d

[dpdk-dev] [PATCH 0/3] net/sfc: fix Rx/Tx offload checks

2018-05-08 Thread Andrew Rybchenko
The patch series applies net/sfc review notes in [1]. Feel free to sqaush these fixes into [1] on apply. Fixes reference is incorrect (since [1] is not applied yet) and provided just as a hint. [1] https://dpdk.org/ml/archives/dev/2018-May/100465.html Andrew Rybchenko (3): net/sfc: avoid Rx/Tx

[dpdk-dev] [PATCH 1/3] net/sfc: avoid Rx/Tx queue init prototype changes

2018-05-08 Thread Andrew Rybchenko
Fixes: 0a8c8a0b8ccc ("ethdev: check Rx/Tx offloads") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 9 ++--- drivers/net/sfc/sfc_rx.c | 6 -- drivers/net/sfc/sfc_rx.h | 3 +-- drivers/net/sfc/sfc_tx.c | 6 -- drivers/net/sfc/sfc_tx.h | 3 +-- 5 fil

[dpdk-dev] [PATCH 2/3] net/sfc: rely on supported device Tx offload check in ethdev

2018-05-08 Thread Andrew Rybchenko
Fixes: 0a8c8a0b8ccc ("ethdev: check Rx/Tx offloads") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_tx.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c index 9836600f9..579bfab7e 100644 --- a/drivers/net/

[dpdk-dev] [PATCH 3/3] net/sfc: rely on supported device Rx offload check in ethdev

2018-05-08 Thread Andrew Rybchenko
Fixes: 0a8c8a0b8ccc ("ethdev: check Rx/Tx offloads") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_rx.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index 1e533b551..cc76a5b15 100644 --- a/drivers/net/

Re: [dpdk-dev] [PATCH v2 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-05-08 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, April 5, 2018 12:25 PM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan ; Trahe, Fiona > ; > pathr...@caviumnetworks.com; ss...@caviumnetworks.com; > agu...@caviumnetworks.co

Re: [dpdk-dev] [PATCH V21 2/4] eal: add failure handle mechanism for hot plug

2018-05-08 Thread Guo, Jia
On 5/4/2018 11:56 PM, Ananyev, Konstantin wrote: Hi Jeff, This patch introduces a failure handler mechanism to handle device hot unplug event. When device be hot plug out, the device resource become invalid, if this resource is still be unexpected read/write, system will crash. This patch let

Re: [dpdk-dev] [PATCH v9 4/4] iFPGA: add document for iFPGA driver

2018-05-08 Thread Thomas Monjalon
08/05/2018 16:19, Xu, Rosen: > From: Rosen Xu > > add some introduction, motivation and usage for iFPGA driver. > > Signed-off-by: Rosen Xu > Signed-off-by: Figo Zhang > --- > doc/guides/rawdevs/ifpga_rawdev.rst| 112 > + > doc/guides/rawdevs/index.rst

Re: [dpdk-dev] [PATCH v9 2/4] iFPGA: Add Intel FPGA OPAE Share Code

2018-05-08 Thread Thomas Monjalon
08/05/2018 16:19, Xu, Rosen: > --- /dev/null > +++ b/drivers/raw/ifpga_rawdev/base/README > @@ -0,0 +1,31 @@ > +.. > + > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2010-2018 Intel Corporation > + */ > + > +Intel® iFPGA driver > +== There is a strange character in

Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-05-08 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, April 5, 2018 12:25 PM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan ; Trahe, Fiona > ; > pathr...@caviumnetworks.com; ss...@caviumnetworks.com; > agu...@caviumnetworks.c

Re: [dpdk-dev] [PATCH v9 1/4] bus/ifpga: Add Intel FPGA BUS Library

2018-05-08 Thread Thomas Monjalon
08/05/2018 16:19, Xu, Rosen: > --- /dev/null > +++ b/drivers/bus/ifpga/rte_bus_ifpga_version.map > + ifpga_get_integer32_arg; > + ifpga_get_string_arg; > + rte_ifpga_driver_register; > + rte_ifpga_driver_unregister; All exported symbols must start with rte_ > --- a/drivers/bus/me

Re: [dpdk-dev] [PATCH] table: add dedicated params struct for cuckoo hash

2018-05-08 Thread Andy Green
On May 8, 2018 10:17:18 PM GMT+08:00, Jasvinder Singh wrote: >Add dedicated parameter structure for cuckoo hash. The cuckoo hash from >librte_hash uses slightly different prototype for the hash function (no >key_mask parameter, 32-bit seed and return value) that require either >of the following

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.

2018-05-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, April 17, 2018 10:46 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > Subject: [PATCH v2] examples/ip_pipeline: fix buffer not null terminated. > > Coverity issue: 272563 > Fixes: 8245472c58c8 ("examples

Re: [dpdk-dev] [PATCH] table: add dedicated params struct for cuckoo hash

2018-05-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, May 8, 2018 3:17 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] table: add dedicated params struct for cuckoo hash > > Add dedicated parameter structure for cuckoo hash. The cuckoo hash from > librte_has

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated

2018-05-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, April 17, 2018 5:40 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Richardson, Bruce > > Subject: [PATCH v2] examples/ip_pipeline: fix buffer not null terminated > > The destination string may not have a null termination

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix memory leak

2018-05-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, April 16, 2018 5:03 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/ip_pipeline: fix memory leak > > Close the file stream before returning from the function to avoid > memory leak. > > Fixes: 2b

  1   2   >