Hi Shally,
> -----Original Message-----
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Tuesday, May 8, 2018 11:58 AM
> To: Trahe, Fiona <fiona.tr...@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>
> Cc: Doherty, Declan <declan.dohe...@intel.com>; Athreya, Narayana Prasad
> <narayanaprasad.athr...@cavium.com>; Sahu, Sunila
> <sunila.s...@cavium.com>; Gupta, Ashish <ashish.gu...@cavium.com>;
> dev@dpdk.org; Sahu, Sunila <sunila.s...@cavium.com>; Gupta, Ashish
> <ashish.gu...@cavium.com>; Kotamarthy, Kanaka
> <kanaka.kotamar...@cavium.com>; Marisetti, Balaji
> <balaji.marise...@cavium.com>
> Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev
>
> Hi Fiona
>
> >-----Original Message-----
> >From: Trahe, Fiona [mailto:fiona.tr...@intel.com]
> >Sent: 08 May 2018 16:22
> >To: Verma, Shally <shally.ve...@cavium.com>; De Lara Guarch, Pablo
> ><pablo.de.lara.gua...@intel.com>
> >Cc: Doherty, Declan <declan.dohe...@intel.com>; Athreya, Narayana
> >Prasad <narayanaprasad.athr...@cavium.com>; Sahu, Sunila
> ><sunila.s...@cavium.com>; Gupta, Ashish <ashish.gu...@cavium.com>;
> >dev@dpdk.org; Sahu, Sunila <sunila.s...@cavium.com>; Gupta, Ashish
> ><ashish.gu...@cavium.com>; Trahe, Fiona <fiona.tr...@intel.com>
> >Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in
> >cryptodev
> >
> >Hi Shally,
> >
> >Reviewing the asymm v2 patch - quick comment:
> >
> >> List of TBDs:
> >> - change PMD ops session_get_size, session_configure, session_clear
> >> to sym_session_* APIs
> >> - change external get_session_private_size to sym_get_session_*
> >> - per-service stats update
> >[Fiona] You'll need to send a deprecation notice for any changes to
> >existing cryptodev APIs in
> >18.05 if you want the changes applied in 18.08
>
> Thanks for info. However, assume API name change is not blocker for spec to be
> in 18.08. So, I planned to do it at later stage after spec get stabilize and
> accepted.
> Do you have any other thoughts to it?
Any modifications to the API, including name changes, require a deprecation
notice.
Making this change will break the compilation of all the apps using it.
What I would suggest is renaming the function and creating a wrapper with the
current name,
calling the new function, and marking it as rte_deprecated.
Something like:
/*
* @deprecated ...
*/
__rte_deprecated
unsigned
rte_cryptodev_get_session_private_size(...) {
return rte_cryptodev_get_sym_session_private_size(...);
}
This way, we can give users time to change to the new API, without breaking
directly the code.
Thanks,
Pablo
>
> Shally
