Re: [dpdk-dev] [PATCH] bus/fslmc: use PRIu64 instead of llX in format specifier

2018-04-12 Thread Shreyansh Jain
On Friday 13 April 2018 10:34 AM, Gowrishankar wrote: From: Gowrishankar Muthukrishnan Instead of llX, use C99 standard "PRIu64" in format specifier. Former one breaks compile in ppc64le. Fixes: c2c167fdb3 ("bus/fslmc: support memory event callbacks for VFIO") Signed-off-by: Gowrishankar Muth

Re: [dpdk-dev] [PATCH 1/2] testpmd: add parameters buffersize-before-send and flush-timeout

2018-04-12 Thread Jens Freimann
On Thu, Apr 12, 2018 at 05:30:54PM +0100, Ferruh Yigit wrote: On 4/12/2018 3:57 PM, Ananyev, Konstantin wrote: Hi, Create a fifo to buffer received packets. Once it flows over put those packets into the actual tx queue. The fifo is created per tx queue and its size can be set with the --buffe

Re: [dpdk-dev] [PATCH] event/dpaa: fix integer overflow on max_event_ports at compile time

2018-04-12 Thread Sunil Kumar Kori
> -Original Message- > From: Gowrishankar [mailto:gowrishanka...@linux.vnet.ibm.com] > Sent: Friday, April 13, 2018 10:37 AM > To: Sunil Kumar Kori ; Shreyansh Jain > > Cc: Anatoly Burakov ; dev@dpdk.org; Thomas > Monjalon ; Gowrishankar Muthukrishnan > > Subject: [PATCH] event/dpaa: fix

[dpdk-dev] [PATCH] net/tap: fix the protocol field for non ip

2018-04-12 Thread Vipin Varghese
When non IP packets are sent on TUN interface, the logic put Ipv6 as protocol field in header. With the current patch, the check is modified for ipv4, ipv6 and non ip. Fixes: 5a3efcfffd06 ("net/tap: add tun support") Cc: vipin.vargh...@intel.com Suggested-by: Ophir Munk Signed-off-by: Vipin Varg

[dpdk-dev] [PATCH] event/dpaa: fix integer overflow on max_event_ports at compile time

2018-04-12 Thread Gowrishankar
From: Gowrishankar Muthukrishnan dev_info->max_event_ports is uint8_t. dpaa_event_dev_info_get assigns DPAA_EVENT_MAX_EVENT_PORT (which is RTE_MAX_LCORE, upto 256 in ppc64le) into this variable, which breaks compile in ppc64le. Fixes: 9caac5dd1e ("event/dpaa: introduce PMD") Signed-off-by: Gowr

[dpdk-dev] [PATCH] bus/fslmc: use PRIu64 instead of llX in format specifier

2018-04-12 Thread Gowrishankar
From: Gowrishankar Muthukrishnan Instead of llX, use C99 standard "PRIu64" in format specifier. Former one breaks compile in ppc64le. Fixes: c2c167fdb3 ("bus/fslmc: support memory event callbacks for VFIO") Signed-off-by: Gowrishankar Muthukrishnan -- In file included from dpdk/drivers/bus/fsl

Re: [dpdk-dev] [PATCH 0/8] net/vmxnet3: fix offload issues

2018-04-12 Thread Yong Wang
On 3/28/18, 8:44 AM, "dev on behalf of Didier Pallard" wrote: This patchset fixes several issues found in vmxnet3 driver when enabling LRO offload support: - Rx offload information are not correctly gathered in multisegmented packets, leading to inconsistent packet type an

Re: [dpdk-dev] [PATCH 1/2] net/tap: add tun support

2018-04-12 Thread Varghese, Vipin
Hi Ophir, Please find my answers inline to the queries. > -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Thursday, April 12, 2018 5:19 PM > To: Varghese, Vipin ; dev@dpdk.org; > pascal.ma...@6wind.com; Yigit, Ferruh ; Thomas > Monjalon ; Olga Shern ; > Shahaf

Re: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for MDIO

2018-04-12 Thread Zhang, Qi Z
Hi Choudaha: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shweta Choudaha > Sent: Wednesday, April 11, 2018 10:00 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Helin ; Yigit, > Ferruh ; shweta.choud...@att.com > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-12 Thread Thomas Monjalon
12/04/2018 16:13, Burakov, Anatoly: > On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: > > a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n > > > > == Build lib/librte_eal/linuxapp/eal > >CC eal_vfio.o > > /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no

Re: [dpdk-dev] [PATCH v2 0/5] allow procinfo and pdump on eth vdev

2018-04-12 Thread Thomas Monjalon
Hi Jinafeng, 05/04/2018 19:44, Jianfeng Tan: > As we know, we have below limitations in vdev: > - dpdk-procinfo cannot get the stats of (most) vdev in primary process; > - dpdk-pdump cannot dump the packets for (most) vdev in primary proces; > - secondary process cannot use (most) vdev in pr

Re: [dpdk-dev] [PATCH v6] vfio: change to use generic multi-process channel

2018-04-12 Thread Thomas Monjalon
05/04/2018 16:26, Tan, Jianfeng: > Hi Anatoly, > > An obvious action would be change rte_mp_request to > rte_mp_request_sync(). Before sending out the new patch, do you have any > other comments for this patch? > > Hi Thomas, > > Several patches will change vfio; may I know the your preferred

Re: [dpdk-dev] [PATCH] vfio: fix device hotplug when several devices per group

2018-04-12 Thread Thomas Monjalon
10/04/2018 12:23, Anatoly Burakov: > We only need to perform DMA mapping for first device in first group. > At the time of mapping, we haven't yet added the device into the group, > so the count is expected to be zero. > > Fixes: 810bfa64c673 ("vfio: fix index for tracking devices in a group") > F

Re: [dpdk-dev] [PATCH v6 2/2] eal/vfio: export internal vfio functions

2018-04-12 Thread Thomas Monjalon
12/04/2018 08:23, Hemant Agrawal: > This patch moves some of the internal vfio functions from > eal_vfio.h to rte_vfio.h for common uses with "rte_" prefix. > > This patch also change the FSLMC bus usages from the internal > VFIO functions to external ones with "rte_" prefix > > Signed-off-by: He

[dpdk-dev] [RFC 1/2] nfp: unlink the appropriate lock file

2018-04-12 Thread Aaron Conole
The nfpu_close needs to unlink the lock file associated with the nfp descriptor, not lock file 0. Fixes: d12206e00590 ("net/nfp: add NSP user space interface") Cc: sta...@dpdk.org Signed-off-by: Aaron Conole --- drivers/net/nfp/nfp_nfpu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(

[dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-12 Thread Aaron Conole
Currently, the nfp lock files are taken from the global lock file location, which will work when the user is running as root. However, some distributions and applications (notably ovs 2.8+ on RHEL/Fedora) run as a non-root user. Signed-off-by: Aaron Conole --- drivers/net/nfp/nfp_nfpu.c | 23 ++

[dpdk-dev] [RFC 0/2] nfp driver fixes

2018-04-12 Thread Aaron Conole
Two fixes, one which is fairly obvious (1/2), the other which may allow support of non-root users. These patches are only compile tested which is why they are submitted as RFC. After a proper test, will resubmit them as PATCH (with any suggested / recommended changes). Aaron Conole (2): nfp: u

[dpdk-dev] [dpdk-announce] release 18.05 delayed

2018-04-12 Thread Thomas Monjalon
Hi, The integration deadline is passed by one week, and the first release candidate is still far from being ready. This time it is really, really late. We will try to do this RC1 on the 20th of April, but no guarantee. Then we may have a lot of new drivers or features to integrate in the next rel

Re: [dpdk-dev] [PATCH v5 02/21] eal: list acceptable init priorities

2018-04-12 Thread Gaëtan Rivet
Hello Neil, On Thu, Apr 12, 2018 at 07:28:26AM -0400, Neil Horman wrote: > On Wed, Apr 11, 2018 at 02:04:03AM +0200, Gaetan Rivet wrote: > > Build a central list to quickly see each used priorities for > > constructors, allowing to verify that they are both above 100 and in the > > proper order. >

Re: [dpdk-dev] [PATCH] net/vmxnet3: change the SPDX tag style

2018-04-12 Thread Yong Wang
On 4/9/18, 2:00 AM, "dev on behalf of Hemant Agrawal" wrote: Cc: skh...@vmware.com Signed-off-by: Hemant Agrawal --- Acked-by: Yong Wang drivers/net/vmxnet3/base/upt1_defs.h| 7 ++- drivers/net/vmxnet3/base/vmxnet3_defs.h | 7 ++- 2 files changed, 4 in

Re: [dpdk-dev] [PATCH v2 1/6] mbuf: add buffer offset field for flexible indirection

2018-04-12 Thread Yongseok Koh
On Thu, Apr 12, 2018 at 04:34:56PM +, Ananyev, Konstantin wrote: > > > > > > > > > > > > > > > On Mon, Apr 09, 2018 at 06:04:34PM +0200, Olivier Matz wrote: > > > > > > > Hi Yongseok, > > > > > > > > > > > > > > On Tue, Apr 03, 2018 at 05:12:06PM -0700, Yongseok Koh wrote: > > > > > > > > On Tu

Re: [dpdk-dev] [PATCH] net/nfp: add support for hardware RSS v2

2018-04-12 Thread Ferruh Yigit
On 4/11/2018 2:10 PM, Alejandro Lucero wrote: > hained metadata instead of prepend metadata was added in > firmware version 4. However, it could be old firmwares evolving > but not supporting chained metadata. > > This patch adds support for an old firmware being updated and > getting a firmware v

[dpdk-dev] virtio: rte_ethdev port_ids consumed by rte_eal_init()

2018-04-12 Thread Dennis Montgomery
Hi, I've run into a problem with DPDK v17.08, when built with CONFIG_RTE_LIBRTE_VIRTIO_PMD=y. After rte_eal_init() calls rte_bus_probe() we end up with the first several entries (matching the number of virtio-pci eth devices on the system) in rte_eth_devices[] showing state == RTE_ETH_DEV_ATTACHE

Re: [dpdk-dev] [PATCH] net/nfp: support LSO offload version 2

2018-04-12 Thread Ferruh Yigit
On 4/11/2018 11:33 AM, Alejandro Lucero wrote: > This new LSO offload version facilitates how firmware implements > this functionality and helps improving the performance. > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 0/2] Support for new Ethdev offload APIs

2018-04-12 Thread Ferruh Yigit
On 4/11/2018 12:05 PM, Sunil Kumar Kori wrote: > Patchset contains changes to support ethdev offload APIs for DPAA and DPAA2 > drivers. > > Offloading support is categoriesed in following logical parts: > 1. If requested offloading features is not supported then returned error. > 2. If requested o

Re: [dpdk-dev] [PATCH] net/sfc: use default FEC mode

2018-04-12 Thread Ferruh Yigit
On 4/10/2018 1:48 PM, Andrew Rybchenko wrote: > All FEC modes are supported and allowed, but none are explicitly > requested. > > This effectively means that FEC mode is determined solely form cable > requirements and link partner capabilities / requirements. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()

2018-04-12 Thread Ferruh Yigit
On 4/9/2018 3:02 PM, Ferruh Yigit wrote: > On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote: >>> This patch fixes a tirvial error in assigning max Rx/Tx queues in >>> axgbe_dev_info_get() of the axgbe PMD driver. >>> >>> Signed-off-by: Rami Rosen >>> --- >>> drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- >>>

Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd: add new commands to test new Tx/Rx offloads

2018-04-12 Thread Ferruh Yigit
On 4/3/2018 9:57 AM, Wei Dai wrote: > Existed testpmd commands can't support per queue offload configuration. > And there are different commands to enable or disable different offloading. > This patch set add following commands to support new Tx/Rx offloading API > test. > > To get Rx offload cap

Re: [dpdk-dev] [PATCH] net/bonding: add rte flow support

2018-04-12 Thread Ferruh Yigit
On 3/28/2018 12:16 PM, Matan Azrad wrote: > Ethernet devices which are grouped by bonding PMD, aka slaves, are > sharing the same queues and RSS configurations and their Rx burst > functions must be managed by the bonding PMD according to the bonding > architectuer. > > So, it makes sense to confi

Re: [dpdk-dev] [PATCH v2 1/6] mbuf: add buffer offset field for flexible indirection

2018-04-12 Thread Ananyev, Konstantin
> > > > > > > > > > > > On Mon, Apr 09, 2018 at 06:04:34PM +0200, Olivier Matz wrote: > > > > > > Hi Yongseok, > > > > > > > > > > > > On Tue, Apr 03, 2018 at 05:12:06PM -0700, Yongseok Koh wrote: > > > > > > > On Tue, Apr 03, 2018 at 10:26:15AM +0200, Olivier Matz wrote: > > > > > > > > Hi, > > >

Re: [dpdk-dev] [PATCH 1/2] testpmd: add parameters buffersize-before-send and flush-timeout

2018-04-12 Thread Ferruh Yigit
On 4/12/2018 3:57 PM, Ananyev, Konstantin wrote: > Hi, > >> >> Create a fifo to buffer received packets. Once it flows over put >> those packets into the actual tx queue. The fifo is created per tx >> queue and its size can be set with the --buffersize-before-sending >> commandline parameter. >> >

Re: [dpdk-dev] [PATCH v6 1/4] eal/vfio: add multiple container support

2018-04-12 Thread Burakov, Anatoly
On 12-Apr-18 5:07 PM, Wang, Xiao W wrote: Hi Anatoly, <...> Also, why providing DMA type? There's already a VFIO type pointer in vfio_config - you can set this pointer for every new created container, so the user wouldn't have to care about IOMMU type. Is it not possible to figure out DMA t

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-12 Thread Ferruh Yigit
On 4/5/2018 6:49 PM, Thomas Monjalon wrote: > Pascal, Moti, Ophir, > please comment. Hi Moti, Any comment? This has been asked many times now. > > 22/03/2018 19:28, Ferruh Yigit: >> It is not clear if tap PMD supports queue specific offloads, removing >> the related code. >> >> Fixes: 95ae196ae

Re: [dpdk-dev] [PATCH v2 2/3] net/szedata2: add support for new NIC

2018-04-12 Thread Ferruh Yigit
On 4/12/2018 8:41 AM, Matej Vido wrote: > + if (pci_dev->id.device_id == PCI_DEVICE_ID_NETCOPE_NFB200G2QL) { > + unsigned int i; > + unsigned int rx_queues = max_rx_queues / max_ports; > + unsigned int tx_queues = max_tx_queues / max_ports; > + > +

Re: [dpdk-dev] [PATCH v6 1/4] eal/vfio: add multiple container support

2018-04-12 Thread Wang, Xiao W
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Thursday, April 12, 2018 10:04 PM > To: Wang, Xiao W ; Yigit, Ferruh > > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Wang, Zhihong > ; Bie, Tiwei ; Tan, Jianfeng > ; Liang, Cunming ; Daly, > Dan ; tho...@monjalon.net; gae

Re: [dpdk-dev] [PATCH v6] vfio: change to use generic multi-process channel

2018-04-12 Thread Burakov, Anatoly
On 20-Mar-18 8:50 AM, Jianfeng Tan wrote: Previously, vfio uses its own private channel for the secondary process to get container fd and group fd from the primary process. This patch changes to use the generic mp channel. Test: 1. Bind two NICs to vfio-pci. 2. Start the primary and seco

Re: [dpdk-dev] [PATCH v3 04/11] mempool: add op to calculate memory size to be allocated

2018-04-12 Thread Burakov, Anatoly
On 26-Mar-18 5:09 PM, Andrew Rybchenko wrote: Size of memory chunk required to populate mempool objects depends on how objects are stored in the memory. Different mempool drivers may have different requirements and a new operation allows to calculate memory size in accordance with driver requirem

Re: [dpdk-dev] [PATCH 1/2] testpmd: add parameters buffersize-before-send and flush-timeout

2018-04-12 Thread Ananyev, Konstantin
Hi, > > Create a fifo to buffer received packets. Once it flows over put > those packets into the actual tx queue. The fifo is created per tx > queue and its size can be set with the --buffersize-before-sending > commandline parameter. > > A second commandline parameter is used to set a timeout

Re: [dpdk-dev] [PATCH v2 01/15] net/mlx5: support 16 hardware priorities

2018-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Thursday, April 12, 2018 10:03 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 01/15] net/mlx5: support 16 hardware priorities > > On Thu, Apr 12, 2018 at 01:43:04PM +, Xueming(Steven) Li

Re: [dpdk-dev] [PATCH] eal: add request to map reserved physical memory

2018-04-12 Thread Burakov, Anatoly
On 28-Mar-18 5:51 AM, Ajit Khaparde wrote: From: Srinath Mannam Reserved physical memory is requested from kernel and it will be mapped to user space. This memory will be mapped to IOVA using VFIO. And this memory will be provided to SPDK to allocate NVMe CQs. Signed-off-by: Srinath Mannam Si

[dpdk-dev] [PATCH 2/2] testpmd: add code to simulate noisy neighbour memory usage

2018-04-12 Thread Jens Freimann
Add several options to simulate route lookups (memory reads) in tables that can be quite large, as well as route hit statistics update. These options simulates the while stack traversal and will trash the cache. Memory access is random. Options to simulate route lookups: --memory-footprint [size]

[dpdk-dev] [PATCH 1/2] testpmd: add parameters buffersize-before-send and flush-timeout

2018-04-12 Thread Jens Freimann
Create a fifo to buffer received packets. Once it flows over put those packets into the actual tx queue. The fifo is created per tx queue and its size can be set with the --buffersize-before-sending commandline parameter. A second commandline parameter is used to set a timeout in milliseconds afte

[dpdk-dev] [PATCH 0/2] testpmd: simulating noisy host environment

2018-04-12 Thread Jens Freimann
This patch set proposes enhancements to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The goal is to enable simple of measuring performance impact on cache and memory footprint utilization from va

[dpdk-dev] [PATCH 2/2] net/mlx5: fix flow director mask

2018-04-12 Thread Nelio Laranjeiro
During the transition to resurrect flow director on top of rte_flow, mask handling was removed by mistake. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 59 ++

[dpdk-dev] [PATCH 1/2] net/mlx5: split L3/L4 in flow director

2018-04-12 Thread Nelio Laranjeiro
This will help to bring back the mask handler which was removed when this feature was rewritten on top of rte_flow. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 112 --- 1 file changed, 37 insertions(+), 75 deletio

[dpdk-dev] [PATCH 0/2] net/mlx5: fix flow director mask

2018-04-12 Thread Nelio Laranjeiro
Flow director mask as been mistakenly removed from mlx5 PMD. This series brings it back. Nelio Laranjeiro (2): net/mlx5: split L3/L4 in flow director net/mlx5: fix flow director mask drivers/net/mlx5/mlx5_flow.c | 155 --- 1 file changed, 69 insertions(+), 86

Re: [dpdk-dev] [PATCH] lib/librte_hash: fix incorrect comment for lookup

2018-04-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Thursday, April 12, 2018 1:34 PM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Shreyansh Jain > Subject: [PATCH] lib/librte_hash: fix incorrect comment for lookup > > rte_hash_lo

Re: [dpdk-dev] [PATCH v2 04/15] net/mlx5: support Rx tunnel type identification

2018-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Thursday, April 12, 2018 5:51 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 04/15] net/mlx5: support Rx tunnel type > identification > > On Wed, Apr 11, 2018 at 08:11:50AM +, Xueming(Ste

Re: [dpdk-dev] [PATCH] examples/l3fwd: adding event queue support

2018-04-12 Thread Jerin Jacob
-Original Message- > Date: Thu, 12 Apr 2018 15:03:22 +0100 > From: Bruce Richardson > To: Sunil Kumar Kori > CC: "dev@dpdk.org" , Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: adding event queue support > User-Agent: Mutt/1.9.4 (2018-02-28) > > On Thu, Apr 12, 2018 at

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-12 Thread Burakov, Anatoly
On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n == Build lib/librte_eal/linuxapp/eal CC eal_vfio.o /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no previous prototype for 'rte_vfio_dma_map' [-Werror=missi

Re: [dpdk-dev] [PATCH v6 1/4] eal/vfio: add multiple container support

2018-04-12 Thread Burakov, Anatoly
On 12-Apr-18 8:19 AM, Xiao Wang wrote: Currently eal vfio framework binds vfio group fd to the default container fd during rte_vfio_setup_device, while in some cases, e.g. vDPA (vhost data path acceleration), we want to put vfio group to a separate container and program IOMMU via this container.

Re: [dpdk-dev] [PATCH] examples/l3fwd: adding event queue support

2018-04-12 Thread Bruce Richardson
On Thu, Apr 12, 2018 at 06:09:04AM +, Sunil Kumar Kori wrote: > Gentle reminder to review the RFC. > > Regards > Sunil Kumar > Hi, sorry for the delay in review. /Bruce > -Original Message- > From: Sunil Kumar Kori [mailto:sunil.k...@nxp.com] > Sent: Monday, March 19, 2018 7:15 P

Re: [dpdk-dev] [PATCH v2 01/15] net/mlx5: support 16 hardware priorities

2018-04-12 Thread Nélio Laranjeiro
On Thu, Apr 12, 2018 at 01:43:04PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Thursday, April 12, 2018 5:09 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 01/15] net/mlx5: support 16 har

Re: [dpdk-dev] [PATCH] net/i40e: update tx_free_threshold to improve zero copy performance

2018-04-12 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, April 12, 2018 2:12 PM > To: Zhang, Qi Z > Cc: Ananyev, Konstantin ; Chen, Junjie J > ; Xing, Beilei ; > dev@dpdk.org; c...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: update tx_free_threshold to improve > zero c

Re: [dpdk-dev] [PATCH v2 01/15] net/mlx5: support 16 hardware priorities

2018-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Thursday, April 12, 2018 5:09 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 01/15] net/mlx5: support 16 hardware priorities > > On Tue, Apr 10, 2018 at 03:22:46PM +, Xueming(Steven) Li w

[dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-12 Thread Shahaf Shuler
a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n == Build lib/librte_eal/linuxapp/eal CC eal_vfio.o /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no previous prototype for 'rte_vfio_dma_map' [-Werror=missing-prototypes] rte_vfio_dma_map(uint64_t __rt

Re: [dpdk-dev] [PATCH] net/i40e: update tx_free_threshold to improve zero copy performance

2018-04-12 Thread Bruce Richardson
On Thu, Apr 12, 2018 at 12:20:07PM +, Zhang, Qi Z wrote: > Hi Junjie: > > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Thursday, April 12, 2018 7:52 PM > > To: Chen, Junjie J ; Xing, Beilei > > ; Zhang, Qi Z > > Cc: dev@dpdk.org; Chen, Junjie J ; c...@dpdk.org > > Subj

Re: [dpdk-dev] [PATCHv2] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases

2018-04-12 Thread Thomas Monjalon
12/04/2018 14:05, Burakov, Anatoly: > On 12-Apr-18 12:16 PM, Neil Horman wrote: > > https://dpdk.org/tracker/show_bug.cgi?id=18 > > > > Indicated that several mmap call sites in the [linux|bsd]app eal code > > set fd that was not -1 in their calls while using MAP_ANONYMOUS. While > > probably not

Re: [dpdk-dev] [PATCH v4 00/11] event/octeontx: add event timer adapter driver

2018-04-12 Thread Jerin Jacob
-Original Message- > Date: Tue, 10 Apr 2018 02:30:24 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > erik.g.carri...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4 00/11] event/octeontx: add event tim

Re: [dpdk-dev] [PATCH v6 2/2] net/vhost: update license to SPDX format

2018-04-12 Thread Maxime Coquelin
On 04/12/2018 06:43 PM, Junjie Chen wrote: Update license to SPDX, also add Intel license. Signed-off-by: Junjie Chen --- drivers/net/vhost/rte_eth_vhost.c | 34 +++--- drivers/net/vhost/rte_eth_vhost.h | 35 +++ 2 files changed,

Re: [dpdk-dev] [PATCH] net/i40e: update tx_free_threshold to improve zero copy performance

2018-04-12 Thread Zhang, Qi Z
Hi Junjie: > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, April 12, 2018 7:52 PM > To: Chen, Junjie J ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Chen, Junjie J ; c...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: update tx_free_threshold to > improve zer

[dpdk-dev] [PATCH] lib/librte_hash: fix incorrect comment for lookup

2018-04-12 Thread Shreyansh Jain
rte_hash_lookup_with_hash() has wrong comment for its 'sig' param. Fixes: 1a9f648be291 ("hash: fix for multi-process apps") Signed-off-by: Shreyansh Jain --- lib/librte_hash/rte_hash.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_ha

Re: [dpdk-dev] [PATCH v6 1/2] vhost: add support for interrupt mode

2018-04-12 Thread Tan, Jianfeng
On 4/13/2018 12:28 AM, Junjie Chen wrote: In some cases we want vhost dequeue work in interrupt mode to release cpus to others when no data to transmit. So we install interrupt handler of vhost device and interrupt vectors for each rx queue when creating new backend according to vhost intrerupt

Re: [dpdk-dev] [PATCHv2] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases

2018-04-12 Thread Burakov, Anatoly
On 12-Apr-18 12:16 PM, Neil Horman wrote: https://dpdk.org/tracker/show_bug.cgi?id=18 Indicated that several mmap call sites in the [linux|bsd]app eal code set fd that was not -1 in their calls while using MAP_ANONYMOUS. While probably not a huge deal, the man page does say the fd should be -1

Re: [dpdk-dev] [PATCH v3 4/5] app/testpmd: introduce new tunnel VXLAN-GPE

2018-04-12 Thread Adrien Mazarguil
On Thu, Apr 12, 2018 at 03:33:23PM +0800, Xueming Li wrote: > Add VXLAN-GPE support to csum forwarding engine and rte flow. > > Signed-off-by: Xueming Li This commit still misses testpmd documentation for the new flow command parameters ("Pattern items" section in doc/guides/testpmd_app_ug/testp

Re: [dpdk-dev] [PATCH v3 2/5] ethdev: introduce new tunnel VXLAN-GPE

2018-04-12 Thread Adrien Mazarguil
On Thu, Apr 12, 2018 at 03:33:21PM +0800, Xueming Li wrote: > VXLAN-GPE enables VXLAN for all protocols. Protocol link: > https://www.ietf.org/id/draft-ietf-nvo3-vxlan-gpe-05.txt > > Signed-off-by: Xueming Li A couple of remaining minor comments, see below. Once addressed: Acked-by: Adrien Maza

Re: [dpdk-dev] [PATCH] net/i40e: update tx_free_threshold to improve zero copy performance

2018-04-12 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Junjie Chen > Sent: Thursday, April 12, 2018 6:32 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Chen, Junjie J ; c...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: update tx_free_threshold to improve

Re: [dpdk-dev] [PATCH 1/2] net/tap: add tun support

2018-04-12 Thread Ophir Munk
Hi Vipin, This patch (adding TUN to TAP) has been Acked and accepted in next-net branch. I have some questions regarding the implementation (please find below). > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Vipin Varghese > Sent: Tuesday, April 03, 2018 12:38

Re: [dpdk-dev] [PATCH v5 02/21] eal: list acceptable init priorities

2018-04-12 Thread Neil Horman
On Wed, Apr 11, 2018 at 02:04:03AM +0200, Gaetan Rivet wrote: > Build a central list to quickly see each used priorities for > constructors, allowing to verify that they are both above 100 and in the > proper order. > > Signed-off-by: Gaetan Rivet > Acked-by: Neil Horman > Acked-by: Shreyansh Ja

[dpdk-dev] [PATCHv2] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases

2018-04-12 Thread Neil Horman
https://dpdk.org/tracker/show_bug.cgi?id=18 Indicated that several mmap call sites in the [linux|bsd]app eal code set fd that was not -1 in their calls while using MAP_ANONYMOUS. While probably not a huge deal, the man page does say the fd should be -1 for portability, as some implementations don

Re: [dpdk-dev] [PATCH v2 4/4] ether: add packet modification aciton in flow API

2018-04-12 Thread Adrien Mazarguil
On Thu, Apr 12, 2018 at 08:50:14AM +, Zhang, Qi Z wrote: > Hi Adrien > > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Thursday, April 12, 2018 3:04 PM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; Doherty, Declan ; Chandran, > > Sugesh ; Gl

Re: [dpdk-dev] [PATCH v2 3/4] ether: add more protocol support in flow API

2018-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, April 12, 2018 5:20 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Doherty, Declan ; Chandran, > Sugesh ; Glynn, Michael J > ; Liu, Yu Y ; Ananyev, > Konstantin ; Richardson, Bruce > > Subject:

Re: [dpdk-dev] [PATCH v2 04/15] net/mlx5: support Rx tunnel type identification

2018-04-12 Thread Nélio Laranjeiro
On Wed, Apr 11, 2018 at 08:11:50AM +, Xueming(Steven) Li wrote: > Hi Nelio, > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Tuesday, April 10, 2018 11:17 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 04/15] net/mlx5: suppo

Re: [dpdk-dev] [PATCH v2 3/4] ether: add more protocol support in flow API

2018-04-12 Thread Adrien Mazarguil
On Thu, Apr 12, 2018 at 05:12:08AM +, Zhang, Qi Z wrote: > Hi Adrien: > > Thank you so much for your careful review and helpful suggestions! > I agree with most of your comments, except couple question about > RTE_FLOW_ITEM_TYPE_TGT_ADDR and RTE_FLOW_ITEM_IPV6_EXT_HDR > Plea

Re: [dpdk-dev] [PATCH v2 01/15] net/mlx5: support 16 hardware priorities

2018-04-12 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 03:22:46PM +, Xueming(Steven) Li wrote: > Hi Nelio, > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Tuesday, April 10, 2018 10:42 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 01/15] net/mlx5: suppo

[dpdk-dev] [PATCH v6 2/2] net/vhost: update license to SPDX format

2018-04-12 Thread Junjie Chen
Update license to SPDX, also add Intel license. Signed-off-by: Junjie Chen --- drivers/net/vhost/rte_eth_vhost.c | 34 +++--- drivers/net/vhost/rte_eth_vhost.h | 35 +++ 2 files changed, 6 insertions(+), 63 deletions(-) diff --git a/dr

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-12 Thread Shreyansh Jain
On Friday 30 March 2018 07:17 PM, Thomas Monjalon wrote: There are some discussions about a specific part of the offload API: "To enable per-port offload, the offload should be set on both device configuration and queue setup." It means the application must repeat the port offloa

[dpdk-dev] [PATCH v6 2/2] net/vhost: update license to SPDX format

2018-04-12 Thread Junjie Chen
Update license to SPDX, also add Intel license. Signed-off-by: Junjie Chen --- drivers/net/vhost/rte_eth_vhost.c | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 8b

Re: [dpdk-dev] [PATCH v2 4/4] ether: add packet modification aciton in flow API

2018-04-12 Thread Zhang, Qi Z
Hi Adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, April 12, 2018 3:04 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Doherty, Declan ; Chandran, > Sugesh ; Glynn, Michael J > ; Liu, Yu Y ; Ananyev, > Konstantin ; Richardson, Bruce > >

[dpdk-dev] [PATCH v6 1/2] vhost: add support for interrupt mode

2018-04-12 Thread Junjie Chen
In some cases we want vhost dequeue work in interrupt mode to release cpus to others when no data to transmit. So we install interrupt handler of vhost device and interrupt vectors for each rx queue when creating new backend according to vhost intrerupt configuration. Thus, applications could regis

[dpdk-dev] [PATCH] maintainers: add backup maintainer for next-crypto tree

2018-04-12 Thread Akhil Goyal
Signed-off-by: Akhil Goyal --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e54c1f0..b46d04a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -45,6 +45,7 @@ T: git://dpdk.org/next/dpdk-next-virtio Next-crypto Tree M: Pablo de Lara +M: Akhil Goy

Re: [dpdk-dev] [PATCH V21 2/4] eal: add device event monitor framework

2018-04-12 Thread Thomas Monjalon
06/04/2018 05:55, Jeff Guo: > v21->v20: This is a very high number of revisions. I cannot see them in my mail client because they are too much nested and indented in the thread representation. Tip: when sending a new revision, it is better to thread it with the first revision, so we do not have an

[dpdk-dev] [PATCH v2 3/3] net/szedata2: add kernel module dependency

2018-04-12 Thread Matej Vido
New kernel module dependency is required to support NFB-200G2QL card. Signed-off-by: Matej Vido --- drivers/net/szedata2/rte_eth_szedata2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c index

[dpdk-dev] [PATCH v2 2/3] net/szedata2: add support for new NIC

2018-04-12 Thread Matej Vido
This patch adds support for new NIC NFB-200G2QL. At the probing stage numa nodes for the DMA queues are identified and the appropriate number of ports is allocated. DMA queues residing on the same numa node are grouped in the same port. Signed-off-by: Matej Vido --- v2: Rebased on top of dpdk-ne

[dpdk-dev] [PATCH v2 1/3] net/szedata2: do not affect Ethernet interfaces

2018-04-12 Thread Matej Vido
NFB cards employ multiple Ethernet ports. Until now, Ethernet port-related operations were performed on all of them (since the whole card was represented as a single port). With new NFB-200G2QL card, this is no longer viable. Since there is no fixed mapping between the queues and Ethernet ports, a

[dpdk-dev] [PATCH v2 0/3] net/szedata2: patch set for new card support

2018-04-12 Thread Matej Vido
This patch set adds support for new card NFB-200G2QL. v2: Rebased on top of dpdk-next-net/master (conflict in release notes for patch 2). Svg image in patch 1 replaced by redrawn image to avoid too long lines. Matej Vido (3): net/szedata2: do not affect Ethernet interfaces net/szedata2: add s

Re: [dpdk-dev] [PATCH v3] net/vhost: fix vhost invalid state

2018-04-12 Thread Maxime Coquelin
On 04/12/2018 09:35 AM, Maxime Coquelin wrote: On 04/12/2018 09:34 AM, Chen, Junjie J wrote: On 04/12/2018 09:21 AM, Tan, Jianfeng wrote: On 4/12/2018 1:02 AM, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is a

Re: [dpdk-dev] [PATCH 1/3] net/szedata2: do not affect Ethernet interfaces

2018-04-12 Thread Matej Vido
On 11.04.2018 12:51, Ferruh Yigit wrote: On 4/11/2018 10:36 AM, Matej Vido wrote: On 10.04.2018 17:28, Ferruh Yigit wrote: On 4/6/2018 3:12 PM, Matej Vido wrote: NFB cards employ multiple Ethernet ports. Until now, Ethernet port-related operations were performed on all of them (since the whole

Re: [dpdk-dev] [PATCH v3] net/vhost: fix vhost invalid state

2018-04-12 Thread Tan, Jianfeng
On 4/12/2018 3:29 PM, Maxime Coquelin wrote: On 04/12/2018 09:21 AM, Tan, Jianfeng wrote: On 4/12/2018 1:02 AM, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero w

Re: [dpdk-dev] [PATCH v3] net/vhost: fix vhost invalid state

2018-04-12 Thread Maxime Coquelin
On 04/12/2018 09:34 AM, Chen, Junjie J wrote: On 04/12/2018 09:21 AM, Tan, Jianfeng wrote: On 4/12/2018 1:02 AM, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero

Re: [dpdk-dev] [PATCH v3] net/vhost: fix vhost invalid state

2018-04-12 Thread Chen, Junjie J
> > > > On 04/12/2018 09:21 AM, Tan, Jianfeng wrote: > > > > > > On 4/12/2018 1:02 AM, Junjie Chen wrote: > >> dev_start sets *dev_attached* after setup queues, this sets device to > >> invalid state since no frontend is attached. Also destroy_device set > >> *started* to zero which makes *allow

[dpdk-dev] [PATCH v3 4/5] app/testpmd: introduce new tunnel VXLAN-GPE

2018-04-12 Thread Xueming Li
Add VXLAN-GPE support to csum forwarding engine and rte flow. Signed-off-by: Xueming Li --- app/test-pmd/cmdline_flow.c | 24 ++ app/test-pmd/config.c | 2 + app/test-pmd/csumonly.c | 83 +-- app/test-pmd/parameters

[dpdk-dev] [PATCH v3 3/5] ethdev: introduce tunnel type MPLS-in-GRE and MPLS-in-UDP

2018-04-12 Thread Xueming Li
This patch adds new tunnel type for MPLS-in-GRE and MPLS-in-UDP. MPLS-in-GRE protocol link: https://tools.ietf.org/html/rfc4023 MPLS-in-UDP protocol link: https://tools.ietf.org/html/rfc7510 Signed-off-by: Xueming Li Acked-by: Adrien Mazarguil --- lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib

[dpdk-dev] [PATCH v3 2/5] ethdev: introduce new tunnel VXLAN-GPE

2018-04-12 Thread Xueming Li
VXLAN-GPE enables VXLAN for all protocols. Protocol link: https://www.ietf.org/id/draft-ietf-nvo3-vxlan-gpe-05.txt Signed-off-by: Xueming Li --- doc/guides/prog_guide/rte_flow.rst | 12 lib/librte_ether/rte_eth_ctrl.h| 3 ++- lib/librte_ether/rte_flow.c| 1 + lib/librt

[dpdk-dev] [PATCH v3 5/5] app/testpmd: add more GRE extension support to csum engine

2018-04-12 Thread Xueming Li
This patch adds GRE checksum and sequence extension supports in addtion to key extension to csum forwarding engine. Signed-off-by: Xueming Li --- app/test-pmd/csumonly.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-p

[dpdk-dev] [PATCH v3 1/5] doc: remove RSS configuration change announcement

2018-04-12 Thread Xueming Li
Remove deprecation as implementation of RSS level provided in Adrien's patch set: http://www.dpdk.org/dev/patchwork/patch/37399/ Signed-off-by: Xueming Li Acked-by: Adrien Mazarguil --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 deletions(-) diff --git a/doc/guides/rel_no

[dpdk-dev] [PATCH v3 0/5] introduce new tunnel types

2018-04-12 Thread Xueming Li
v3: - Change VXLAN-GPE definition order to avoid ABI compatibility issue. v2: - Split patch set into public and mlx5 two series, this one is the first. v1: - Support new tunnel type MPLS-in-GRE and MPLS-in-UDP - Remove deprecation notes of rss level This patchset introduced new tunnel type and rel

Re: [dpdk-dev] [PATCH v3] net/vhost: fix vhost invalid state

2018-04-12 Thread Maxime Coquelin
On 04/12/2018 09:21 AM, Tan, Jianfeng wrote: On 4/12/2018 1:02 AM, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero which makes *allow_queuing* always zero until dev

[dpdk-dev] [PATCH v6 2/4] net/virtio: skip device probe in vdpa mode

2018-04-12 Thread Xiao Wang
If we want a virtio device to work in vDPA (vhost data path acceleration) mode, we could add a "vdpa=1" devarg for this device to specify the mode. This patch let virtio pmd skip device probe when detecting this parameter. Signed-off-by: Xiao Wang Reviewed-by: Maxime Coquelin Reviewed-by: Ferru

[dpdk-dev] [PATCH v6 0/4] add ifcvf vdpa driver

2018-04-12 Thread Xiao Wang
IFCVF driver The IFCVF vDPA (vhost data path acceleration) driver provides support for the Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it works as a HW vhost backend which can send/receive packets to/from virtio directly by DMA. Besides, it supports dirty pa

  1   2   >