Hi Choudaha:
> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shweta Choudaha
> Sent: Wednesday, April 11, 2018 10:00 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; Zhang, Helin <helin.zh...@intel.com>; Yigit,
> Ferruh <ferruh.yi...@intel.com>; shweta.choud...@att.com
> Subject: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for
> MDIO
Nitpick: title should not start with uppercase.
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_pmd_ixgbe_lock_mdio;
> + rte_pmd_ixgbe_unlock_mdio;
Can we rename to rte_pmd_ixgbe_mdio_lock and rte_pmd_ixgbe_mdio_unlock, so all
mdio functions can be list closely when follow the alphabet sequence?
> + rte_pmd_ixgbe_mdio_read_unlocked;
> + rte_pmd_ixgbe_mdio_write_unlocked;
And this could be rte_pmd_ixgbe_mdio_unlocked_read/write to follow the same
pattern that action after object
Regards
Qi
> +} DPDK_18.05;
> --
> 2.11.0
