Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

2018-04-06 Thread Ferruh Yigit
On 4/6/2018 7:10 PM, Scott Branden wrote: > Hi Ferruh, > > Somehow I did not receive your other email so Ajit fowarded it to me.  So I am > responding to it here. > > Sorry for the previous confusion:  RTE_KERNELDIR_OUT specifies the location of > the output of the kernel artifacts, not the outpu

Re: [dpdk-dev] [PATCH v3 3/4] ethdev: Add group action type to rte_flow

2018-04-06 Thread Adrien Mazarguil
On Fri, Apr 06, 2018 at 01:24:02PM +0100, Declan Doherty wrote: > Add group action type which defines a terminating action which > allows a matched flow to be redirect to a group. This allows logical > flow table hierarchies to be managed through rte_flow. > > Signed-off-by: Declan Doherty OK, I

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Adrien Mazarguil
On Fri, Apr 06, 2018 at 01:24:03PM +0100, Declan Doherty wrote: > Introduces a new action type RTE_FLOW_ACTION_TYPE_METADATA which enables > metadata extraction from a packet into a specified metadata container > for consumption on further pipeline stages or for propagation to the host > interface.

Re: [dpdk-dev] [PATCH v3 2/4] ethdev: Add tunnel encap/decap actions

2018-04-06 Thread Adrien Mazarguil
On Fri, Apr 06, 2018 at 01:24:01PM +0100, Declan Doherty wrote: > Add new flow action types and associated action data structures to > support the encapsulation and decapsulation of the virtual tunnel > endpoints. > > The RTE_FLOW_ACTION_TYPE_TUNNEL_ENCAP action will cause the matching > flow to b

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add group counter support to rte_flow

2018-04-06 Thread Adrien Mazarguil
On Fri, Apr 06, 2018 at 01:24:00PM +0100, Declan Doherty wrote: > Add new RTE_FLOW_ACTION_TYPE_GROUP_COUNT action type to enable shared > counters across multiple flows on a single port or across multiple > flows on multiple ports within the same switch domain. > > Introduce new API rte_flow_query

Re: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup

2018-04-06 Thread Rosen, Rami
Hi Qi, Thanks for these patches. See my comment below. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang Sent: Monday, April 02, 2018 06:00 To: tho...@monjalon.net; Ananyev, Konstantin Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing ; Lu, Wenzhuo ; Zhang, Qi

[dpdk-dev] [PATCH 29/30] crypto/qat: add MAX PCI DEVICES flag to config file

2018-04-06 Thread Fiona Trahe
Added CONFIG_RTE_PMD_QAT_MAX_PCI_DEVICES to build config files. Signed-off-by: Tomasz Jozwiak --- config/common_base | 4 config/rte_config.h | 2 ++ drivers/crypto/qat/qat_device.c | 8 drivers/crypto/qat/qat_device.h | 2 -- 4 files changed, 10 insertion

[dpdk-dev] [PATCH 30/30] crypto/qat: add performance improvement into qat crypto dev.

2018-04-06 Thread Fiona Trahe
From: Tomasz Jozwiak - removed unused args. from process_response function - changed adf_modulo function - changed qat_sym_process_response into static inline version Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 29 +--

[dpdk-dev] [PATCH 28/30] crypto/qat: create appropriately named device for registration

2018-04-06 Thread Fiona Trahe
For every QAT pci device probed, populate a local rte_device containing an rte_driver. The rte_driver was created in a previous patch to provide a crypto-specific driver name: "crypto_qat". This was previously only used for driver registration, now it's also used in device creation. This allows app

[dpdk-dev] [PATCH 27/30] crypto/qat: cleanups

2018-04-06 Thread Fiona Trahe
- renamed sgl_cookie to cookie - renamed qp_gen_config to qat_gen_config as it is intended to hold more than just qp data. - removed unused macro - ALIGN_POW2 - moved 64_BYTE_ALIGN to qat_common.h - removed crypto reference in common debug msg - free cookie pool on qp creation error Signe

[dpdk-dev] [PATCH 22/30] crypto/qat: use common stats structures

2018-04-06 Thread Fiona Trahe
Split qat_sym_stats_get/reset into 2 functions, a wrapper function calling a new qat_stats_get/reset function which can be called per service. Remove cryptodev stats struct from qat_qp, replace with qat_common_stats. Add links for qat_qp into qat_pci_device using an array per service to avoid need

[dpdk-dev] [PATCH 26/30] crypto/qat: remove incorrect usage of bundle number

2018-04-06 Thread Fiona Trahe
As bundle_num is included in qat_gen1_qps static array there shouldn't be a multiplier used in qat_qps_per_service() Then removed ADF_NUM_BUNDLES_PER_DEV as no longer used. Also renamed ADF_MAX_QPS_PER_BUNDLE to ADF_MAX_QPS_ON_ANY_SERVICE and reduced from 4 to 2 which is enough for all current devi

[dpdk-dev] [PATCH 25/30] crypto/qat: add lock around csr access and change logic

2018-04-06 Thread Fiona Trahe
Add lock around accesses to the arbiter CSR and use & instead of ^ as ^ not safe if arb_disable called when already disabled. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH 23/30] crypto/qat: rename functions which depend on cryptodev

2018-04-06 Thread Fiona Trahe
Rename all device functions which depend on cryptodev structs. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_device.c| 8 drivers/crypto/qat/qat_device.h| 8 drivers/crypto/qat/rte_qat_cryptodev.c | 8 3 files changed, 12 insertions(+), 12 dele

[dpdk-dev] [PATCH 24/30] crypto/qat: move code into appropriate files

2018-04-06 Thread Fiona Trahe
Move all code into appropriate files, no actual code changes. Specifically: - Rename rte_qat_cryptodev.c to qat_sym_pmd.c - Create qat_sym_pmd.h and populate with fn prototypes for qat_sym_pmd.c - Create qat_comp_pmd.c/.h and populate with placeholder functions - Create qat_asym_pmd.c/.h and po

[dpdk-dev] [PATCH 21/30] crypto/qat: move to using new device structure

2018-04-06 Thread Fiona Trahe
Struct qat_pmd_private held the data needed by cryptodev, common code now gets most data from struct qat_pci_device instead. qat_pmd_private is trimmed to hold only sym crypto data and renamed qat_sym_private to reflect its usage. Specifically - remove max_nb_queue_pairs from qat_pmd_private, get

[dpdk-dev] [PATCH 20/30] crypto/qat: separate the name used for PCI reg from crypto name

2018-04-06 Thread Fiona Trahe
The QAT PMD used to register with PCI using the name "crypto_qat". Keep this name for the driver registered with cryptodev and use a more generic name "qat" for the PCI registration. This paves the way for the PCI device to host other services. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/

[dpdk-dev] [PATCH 19/30] crypto/qat: add QAT PCI device struct

2018-04-06 Thread Fiona Trahe
- Added struct qat_pci_device to use internally in QAT PMD to avoid dependencies on rte_cryptodev or rte_compressdev - Added a global array of these - Restructured probe/release to separate QAT common init/clear from crypto pmd create/destroy. - In QAT common part allocated a qat_pci_devi

[dpdk-dev] [PATCH 17/30] crypto/qat: rename sgl related objects

2018-04-06 Thread Fiona Trahe
Change SGL (Scatter-Gather List) related structs and member names Signed-off-by: ArkadiuszX Kusztal --- drivers/crypto/qat/qat_common.h | 10 +- drivers/crypto/qat/qat_sym.c| 28 ++-- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/cr

[dpdk-dev] [PATCH 18/30] crypto/qat: move sgl related element to appropriate files

2018-04-06 Thread Fiona Trahe
Move SGL (Scatter-Gather List) related functions to common file Move qat_sym_op_cookie struct to sym header file Signed-off-by: ArkadiuszX Kusztal Signed-off-by: Fiona Trahe --- drivers/crypto/qat/Makefile | 1 + drivers/crypto/qat/meson.build | 1 + drivers/crypto/qat/qat_common.c | 53

[dpdk-dev] [PATCH 16/30] crypto/qat: create data structures to support different generations

2018-04-06 Thread Fiona Trahe
Create data structures to support different generations of qat hardware supplying services through different queue pairs. - Add two new structs qat_gen_hw_data and qat_qp_hw_dat - Add a qat_service_type enum An array of qat_qp_hw_data elements is initialised with constants, these are arranged so

[dpdk-dev] [PATCH 11/30] crypto/qat: move generic qp fn to qp file

2018-04-06 Thread Fiona Trahe
Move the generic enqueue and dequeue fns from the qat_sym.c file to the qat_qp.c file Move generic qp structs to a new qat_qp.h file Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 152 +++ drivers/crypto/qat/qat_qp.h | 63

[dpdk-dev] [PATCH 15/30] crypto/qat: move defines from sym to qp header file

2018-04-06 Thread Fiona Trahe
Move defines related to coalescing from sym header file to qp header file as these will be common for all services. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.h | 7 +++ drivers/crypto/qat/qat_sym.h | 7 --- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/d

[dpdk-dev] [PATCH 13/30] crypto/qat: move sym-specific qp code to sym file

2018-04-06 Thread Fiona Trahe
Move sym qp setup code from qat_qp.c to qat_sym.c Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 78 ++-- drivers/crypto/qat/qat_qp.h | 6 drivers/crypto/qat/qat_sym.c | 75 ++ 3 files changed,

[dpdk-dev] [PATCH 12/30] crypto/qat: separate sym-specific from generic qp setup

2018-04-06 Thread Fiona Trahe
Extracted all sym-specific code from qp setup fns, leaving generic qat_qp_setup fn and helper fns. Created a new meta-data struct qat_qp_config to hold all the data needed to create a qp, filled this out in the sym-specific code and passed to the generic qp_setup fn. No need now for rx and tx queue

[dpdk-dev] [PATCH 14/30] crypto/qat: remove dependencies on cryptodev from common

2018-04-06 Thread Fiona Trahe
Remove dependence on rte_cryptodev from common qp code to facilitate being used by other device types in future. Transferred required data into qat-specific structures. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_device.h| 11 +- drivers/crypto/qat/qat_qp.c| 67

[dpdk-dev] [PATCH 10/30] crypto/qat: make dequeue function generic

2018-04-06 Thread Fiona Trahe
Queue-handling code in dequeue is made generic, so it can be used by other services in future. This is done by - Removing all sym-specific refs in input params - replace with void ptrs. - Wrapping this generic dequeue with the sym-specific dequeue called through the API. - extracting the sym-

[dpdk-dev] [PATCH 09/30] crypto/qat: make enqueue function generic

2018-04-06 Thread Fiona Trahe
Queue-handling code in enqueue is made generic, so it can be used by other services in future. This is done by - Removing all sym-specific refs in input params - replace with void ptrs. - Wrapping this generic enqueue with the sym-specific enqueue called through the API. - Setting a fn ptr fo

[dpdk-dev] [PATCH 08/30] crypto/qat: renamed sym-specific structs

2018-04-06 Thread Fiona Trahe
qat_session -> qat_sym_session qat_crypto_proto_flag -> qat_sym_proto_flag qat_alg_cd-> qat_sym_cd qat_crypto_op_cookie -> qat_sym_op_cookie qat_gen1_capabilities -> qat_gen1_sym_capabilities qat_gen2_capabilities -> qat_gen2_sym_capabilities Signed-off-by: Fiona Trahe ---

[dpdk-dev] [PATCH 07/30] crypto/qat: rename fns for consistency

2018-04-06 Thread Fiona Trahe
Rename fn names to shorten them, i.e. qat_crypto_sym_xxx to qat_sym_xxx _content_desc_ to _cd_ Renaming symmetric crypto specific with consistent names: qat_crypto_set_session_parameters->qat_sym_set_session_parameters qat_write_hw_desc_entry()->qat_sym_build_request() qat_alg_xxx ->qat_s

[dpdk-dev] [PATCH 06/30] crypto/qat: change filename crypto to sym

2018-04-06 Thread Fiona Trahe
This commit renames qat_crypto.c/h to qat_sym.c/h And makes a few whitespace changes to resolve line-length issues. Signed-off-by: ArkadiuszX Kusztal Signed-off-by: Fiona Trahe --- drivers/crypto/qat/Makefile| 2 +- drivers/crypto/qat/meson.build | 2 +- dr

[dpdk-dev] [PATCH 01/30] crypto/qat: use SPDX license

2018-04-06 Thread Fiona Trahe
Use SPDK license for dual-licensed files and update license date in all files Signed-off-by: Fiona Trahe --- drivers/crypto/qat/Makefile| 2 +- drivers/crypto/qat/meson.build | 2 +- .../qat/qat_adf/adf_transport_access_macros.h | 47 +--

[dpdk-dev] [PATCH 05/30] crypto/qat: add symmetric session file

2018-04-06 Thread Fiona Trahe
This commit adds qat_sym_session.c/h files and moves objects from qat_algs_build_desc and qat_algs.h Following objects were moved: qat_adf/qat_algs_build_desc.c => qat_sym_session.c - all objects - qat_adf/qat_algs.h => qat_sym_session.h - enum qat_crypto_proto_flag - struct qat_alg_cd - struct qa

[dpdk-dev] [PATCH 04/30] crypto/qat: remove unused includes

2018-04-06 Thread Fiona Trahe
This commit removes unused includes from qat_crypto.c Signed-off-by: ArkadiuszX Kusztal Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_crypto.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c ind

[dpdk-dev] [PATCH 03/30] crypto/qat: add qat device files

2018-04-06 Thread Fiona Trahe
This commit adds new qat_device file. Following objects were moved: qat_crypto.h => qat_device.h - struct qat_pmd_private - uint8_t cryptodev_qat_driver_id - int qat_crypto_sym_qp_release (EXTERN) - int qat_dev_config() - int qat_dev_start() - void qat_dev_stop() - int qat_dev_close() - void qat_d

[dpdk-dev] [PATCH 02/30] crypto/qat: add qat common header

2018-04-06 Thread Fiona Trahe
This commit adds qat_common.h header file. Following objects were moved to it: qat_algs.h =>. qat_common.h - struct qat_alg_buf - struct qat_alg_buf_list - struct qat_crypto_op_cookie - QAT_SGL_MAX_NUMBER qat_crypto.h => qat_common.h - CRYPTODEV_NAME_QAT_SYM_PMD Signed-off-by: ArkadiuszX Kusztal

[dpdk-dev] [PATCH 00/30] crypto/qat: refactor to support multiple service

2018-04-06 Thread Fiona Trahe
The QAT crypto PMD was peppered with references to rte_cryptodev artefacts. Also the pci device it presented to the API layer was entirely owned by the one cryptodev device instance created by the probe. This patchset refactors the PMD so one pci device can present out multiple different device in

[dpdk-dev] [PATCH v3 09/10] doc: add librte_bpf related info

2018-04-06 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/api/doxy-api-index.md | 3 ++- doc/api/doxy-api.conf | 1 + doc/guides/prog_guide/bpf_lib.rst | 37 + doc/guides/prog_guide/index.rst | 1 + 4 files changed, 41 insertions(+), 1 deletion(-) cre

[dpdk-dev] [PATCH v3 08/10] test: introduce functional test for librte_bpf

2018-04-06 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- test/test/Makefile| 2 + test/test/meson.build | 2 + test/test/test_bpf.c | 633 ++ 3 files changed, 637 insertions(+) create mode 100644 test/test/test_bpf.c diff --git a/test/test/Makefile b/test/t

[dpdk-dev] [PATCH v3 07/10] test: add few eBPF samples

2018-04-06 Thread Konstantin Ananyev
Add few simple eBPF programs as an example. Signed-off-by: Konstantin Ananyev --- test/bpf/dummy.c | 20 ++ test/bpf/mbuf.h | 578 +++ test/bpf/t1.c| 52 + test/bpf/t2.c| 31 +++ test/bpf/t3.c| 36 5 files changed, 717

[dpdk-dev] [PATCH v3 06/10] testpmd: new commands to load/unload BPF filters

2018-04-06 Thread Konstantin Ananyev
Introduce new testpmd commands to load/unload RX/TX BPF-based filters. Signed-off-by: Konstantin Ananyev --- app/test-pmd/bpf_sup.h | 25 app/test-pmd/cmdline.c | 146 +++ app/test-pmd/meson.build | 2 +- 3 files changed, 172 insertions

[dpdk-dev] [PATCH v3 05/10] bpf: introduce basic RX/TX BPF filters

2018-04-06 Thread Konstantin Ananyev
Introduce API to install BPF based filters on ethdev RX/TX path. Current implementation is pure SW one, based on ethdev RX/TX callback mechanism. Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/Makefile| 2 + lib/librte_bpf/bpf_pkt.c | 607 +++

[dpdk-dev] [PATCH v3 01/10] net: move BPF related definitions into librte_net

2018-04-06 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/tap/tap_bpf.h | 80 +- lib/librte_net/Makefile| 1 + lib/librte_net/bpf_def.h | 370 + lib/librte_net/meson.build | 3 +- 4 files changed, 374 insertions(+), 80 deletions(-) create m

[dpdk-dev] [PATCH v3 04/10] bpf: add JIT compilation for x86_64 ISA

2018-04-06 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/Makefile |3 + lib/librte_bpf/bpf.c |5 + lib/librte_bpf/bpf_jit_x86.c | 1368 ++ lib/librte_bpf/meson.build |4 + 4 files changed, 1380 insertions(+) create mode 100644 lib/li

[dpdk-dev] [PATCH v3 03/10] bpf: add more logic into bpf_validate()

2018-04-06 Thread Konstantin Ananyev
Add checks for: - all instructions are valid ones (known opcodes, correct syntax, valid reg/off/imm values, etc.) - no unreachable instructions - no loops - basic stack boundaries checks - division by zero Still need to add checks for: - use/return only initialized registers and stack dat

[dpdk-dev] [PATCH v3 02/10] bpf: add BPF loading and execution framework

2018-04-06 Thread Konstantin Ananyev
librte_bpf provides a framework to load and execute eBPF bytecode inside user-space dpdk based applications. It supports basic set of features from eBPF spec (https://www.kernel.org/doc/Documentation/networking/filter.txt). Not currently supported features: - JIT - cBPF - tail-pointer call - e

[dpdk-dev] [PATCH v3 00/10] add framework to load and execute BPF code

2018-04-06 Thread Konstantin Ananyev
BPF is used quite intensively inside Linux (and BSD) kernels for various different purposes and proved to be extremely useful. BPF inside DPDK might also be used in a lot of places for a lot of similar things. As an example to: - packet filtering/tracing (aka tcpdump) - packet classification - st

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-06 Thread Pavan Nikhilesh
On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > 06/04/2018 13:01, Pavan Nikhilesh: > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > Please, could you provide a log of the error? CC ea

[dpdk-dev] [PATCH v2] compress/isal: ISA-L compression PMD

2018-04-06 Thread Lee Daly
Compression PMD, which utilizes Intel’s ISA-L compression library. The driver written under the DPDK compression API, compressdev, and therefore has dependencies on it, as well as the Intel's ISA-L library. V2: - Changes to keep in compliance with compressdev API, - Enable meson build system.

Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

2018-04-06 Thread Scott Branden
Hi Ferruh, Somehow I did not receive your other email so Ajit fowarded it to me.  So I am responding to it here. Sorry for the previous confusion:  RTE_KERNELDIR_OUT specifies the location of the output of the kernel artifacts, not the output of the DPDK build artifacts. Here is an example

[dpdk-dev] [PATCH v3 13/13] compressdev: get device id from name

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Added API to retrieve the device id provided the device name. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 18 ++ lib/librte_compress

[dpdk-dev] [PATCH v3 10/13] compressdev: add compression service feature flags

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 31 +++ lib/librte_compressdev/rte_compressdev.h | 45 ++ lib/l

[dpdk-dev] [PATCH v3 12/13] compressdev: add device capabilities

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Added structure which each PMD will fill out, providing the capabilities of each driver (containing mainly which compression services it supports). Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librt

[dpdk-dev] [PATCH v3 09/13] compressdev: add device feature flags

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 21 ++ lib/librte_compressdev/rte_compressdev.h | 33 ++ lib/li

[dpdk-dev] [PATCH v3 11/13] compressdev: add device stats

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 41 ++ lib/librte_compressdev/rte_compressdev.h | 39

[dpdk-dev] [PATCH v3 07/13] compressdev: support stateful operations

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Added stream data (stream) in compression operation, which will contain the private data from each PMD to support stateful operations. Also, added functions to create/free this data. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-o

[dpdk-dev] [PATCH v3 08/13] compressdev: support hash operations

2018-04-06 Thread Pablo de Lara
From: Shally Verma - Added hash algo enumeration and params in xform and rte_comp_op - Updated compress/decompress xform to input hash algorithm - Updated struct rte_comp_op to input hash buffer User in capability query will know about support hashes via device info comp_feature_flag. If support

[dpdk-dev] [PATCH v3 05/13] compressdev: add operation management

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Added functions to allocate and free compression operations. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_comp.h | 195 + lib/librte_compr

[dpdk-dev] [PATCH v3 06/13] compressdev: support stateless operations

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Added private transform data (priv_xform) in compression operation, which will contain the private data from each PMD to support stateless operations. Also, added functions to create/free this data. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally

[dpdk-dev] [PATCH v3 04/13] compressdev: add enqueue/dequeue functions

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.h | 121 +++ 1 file changed, 121 insertions(+) diff --git a/lib/librte_compressdev/rte_com

[dpdk-dev] [PATCH v3 02/13] compressdev: add queue pair management

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Add functions to manage device queue pairs. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 135 + lib/librte_compressdev/rte_compre

[dpdk-dev] [PATCH v3 03/13] compressdev: add compression specific data

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Added structures and enums specific to compression, including the compression operation structure and the different supported algorithms, checksums and compression levels. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashi

[dpdk-dev] [PATCH v3 01/13] compressdev: add basic device management

2018-04-06 Thread Pablo de Lara
From: Fiona Trahe Add basic functions to manage compress devices, including driver and device allocation, and the basic interface with compressdev PMDs. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS

[dpdk-dev] [PATCH v3 00/13] Implement compression API

2018-04-06 Thread Pablo de Lara
With the vast amounts of data being transported around networks and stored in storage systems, reducing data size is becoming ever more important. There are both software libraries and hardware devices available that provide compression, but no common API. Such an API is proposed in this patchset

Re: [dpdk-dev] [PATCH] doc: sort qede feature list

2018-04-06 Thread Ferruh Yigit
On 3/22/2018 6:17 PM, Ferruh Yigit wrote: > Sort list to be same order as default.ini. No value changed. > > Signed-off-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-04-06 Thread Ferruh Yigit
On 3/13/2018 6:05 PM, Ferruh Yigit wrote: > Update link status related feature document items and minor updates in > some link status related functions. > > Signed-off-by: Ferruh Yigit > --- > doc/guides/nics/features/fm10k.ini | 2 ++ > doc/guides/nics/features/fm10k_vf.ini | 2 ++ > doc

Re: [dpdk-dev] vmxnet3 RX VLAN Strip offload incorrect behaviour

2018-04-06 Thread Yong Wang
Padam, As far as I know, this feature works. What DPDK version did you use? Is there any port reconfiguration (stop/start/mtu change, etc) that could lose your vlan offload settings (a dump of the port config at runtime will be able to confirm this)? Can you also post a snippet of packet cap

Re: [dpdk-dev] [PATCH v3 0/5] net/sfc: support choice of FW subvariant without Tx checksum

2018-04-06 Thread Ferruh Yigit
On 4/4/2018 3:23 PM, Andrew Rybchenko wrote: > A couple of base driver patches have checkpatches.sh warnings because > of coding standard difference. > > v2 -> v3: > - fix invalid E-mail in net/sfc/base: report no Tx checksum FW >subvariant support > > v1 -> v2: > - add lost bits to net/sfc

Re: [dpdk-dev] [PATCH] net/enic: add primary mac address handler

2018-04-06 Thread Ferruh Yigit
On 2/20/2018 12:16 PM, Hyong Youb Kim wrote: > On Tue, Feb 20, 2018 at 10:17:34AM +0100, David Marchand wrote: > [...] >> Btw, I had forgotten about the deprecation notice [1] sent by Olivier. >> Just discussed it with him, let's wait for this change before looking >> at the issue again. >> >> >> 1

[dpdk-dev] [PATCH 3/7] net/sfc/base: honour packed stream RSS restriction

2018-04-06 Thread Andrew Rybchenko
From: Ivan Malov Packed stream firmware variant on EF10 adapters has a number of properties which must be taken into account: - Only one exclusive RSS context is available per port. - Only IP addresses can contribute to the hash value. Huntington and Medford have one more limitation which is

[dpdk-dev] [PATCH 7/7] net/sfc: convert to the advanced EFX RSS interface

2018-04-06 Thread Andrew Rybchenko
From: Ivan Malov The current code has the following drawbacks: - It is assumed that TCP 4-tuple hash is always supported, which is untrue in the case of packed stream FW variant. - The driver is unaware of UDP hash support available with latest firmware. In order to cope with the ment

[dpdk-dev] [PATCH 5/7] net/sfc: remove conditional compilation for RSS

2018-04-06 Thread Andrew Rybchenko
From: Ivan Malov RSS is one of the most valuable features in the driver, and one would hardly need to disable it at build time. This patch withdraws unnecessary conditionals for RSS snippets. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc.c| 10 -

[dpdk-dev] [PATCH 6/7] net/sfc: factor out RSS fields from adapter info

2018-04-06 Thread Andrew Rybchenko
From: Ivan Malov RSS handling will need more sophisticated fields in the adapter context storage in future patches. This patch groups existing fields in a dedicated structure and updates the rest of the code. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc.c

[dpdk-dev] [PATCH 1/7] net/sfc/base: add a new means to control RSS hash

2018-04-06 Thread Andrew Rybchenko
From: Ivan Malov Currently, libefx has no support for additional RSS modes available with later controllers. In order to support this, libefx should be able to list available hash configurations. This patch provides basic infrastructure for the new interface. The client drivers will be able to q

[dpdk-dev] [PATCH 4/7] net/sfc: process RSS settings on Rx configure step

2018-04-06 Thread Andrew Rybchenko
From: Ivan Malov One may submit advanced RSS settings as part of rte_eth_conf to customise RSS configuration from the very beginning. Currently the driver does not check that piece of settings and proceeds with default choices for RSS hash functions and RSS key. This patch implements the require

[dpdk-dev] [PATCH 2/7] net/sfc/base: support more RSS hash configurations

2018-04-06 Thread Andrew Rybchenko
From: Ivan Malov Modern firmwares on EF10 adapters have support for more traffic classes eligible for hash computation. Also, it has become possible to adjust hashing per individual class and select distinct packet fields which will be able to contribute to the hash value. This patch adds suppor

[dpdk-dev] [PATCH 0/7] net/sfc: RSS improvements

2018-04-06 Thread Andrew Rybchenko
The patch series should be applied on top of [1] and [2]. checkpatches.sh warnings are bacause of positive errno used inside the driver. checkpatches.sh checks are OK. [1] https://dpdk.org/ml/archives/dev/2018-April/095762.html [2] https://dpdk.org/ml/archives/dev/2018-April/095774.html Ivan Mal

Re: [dpdk-dev] [PATCH 1/2] net/tap: add tun support

2018-04-06 Thread Ferruh Yigit
On 4/6/2018 6:11 PM, Ferruh Yigit wrote: > On 4/2/2018 10:37 PM, Vipin Varghese wrote: >> The change adds functional TUN PMD logic to the existing TAP PMD. >> TUN PMD can be initialized with 'net_tunX' where 'X' represents unique id. >> PMD supports argument interface, while MAC address and remote

Re: [dpdk-dev] [PATCH v2 10/15] ethdev: refine TPID handling in flow API

2018-04-06 Thread Andrew Rybchenko
On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: TPID handling in rte_flow VLAN and E_TAG pattern item definitions is not consistent with the normal stacking order of pattern items, which is confusing to applications. Problem is that when followed by one of these layers, the EtherType field of th

Re: [dpdk-dev] [PATCH 1/2] net/tap: add tun support

2018-04-06 Thread Ferruh Yigit
On 4/2/2018 10:37 PM, Vipin Varghese wrote: > The change adds functional TUN PMD logic to the existing TAP PMD. > TUN PMD can be initialized with 'net_tunX' where 'X' represents unique id. > PMD supports argument interface, while MAC address and remote are not > supported. > > Signed-off-by: Vipin

Re: [dpdk-dev] [PATCH v5 0/4] ethdev: add per-PMD tuning of RxTx parmeters

2018-04-06 Thread Ferruh Yigit
On 4/6/2018 3:49 PM, Remy Horton wrote: > The optimal values of several transmission & reception related parameters, > such as burst sizes, descriptor ring sizes, and number of queues, varies > between different network interface devices. This patchset allows individual > PMDs to specify their pref

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Mohammad Abdul Awal
On 06/04/2018 16:57, Thomas Monjalon wrote: 06/04/2018 15:47, Mohammad Abdul Awal: On 05/04/2018 17:49, Thomas Monjalon wrote: 05/04/2018 15:51, Declan Doherty: +struct rte_flow_item_metadata { + uint32_t id;/**< field identifier */ + uint32_t size; /**< fiel

Re: [dpdk-dev] [PATCH] doc: add meter API change to release notes

2018-04-06 Thread Thomas Monjalon
05/04/2018 14:03, Dumitrescu, Cristian: > From: Singh, Jasvinder > > > > Update the release notes with meter api change to support configuration > > profiles. > > > > Signed-off-by: Jasvinder Singh > > --- > > --- a/doc/guides/rel_notes/release_18_05.rst > > +++ b/doc/guides/rel_notes/release_18

Re: [dpdk-dev] [pull-request] next-pipeline 18.05 PRE-RC1

2018-04-06 Thread Thomas Monjalon
05/04/2018 13:00, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 30/03/2018 14:45, Cristian Dumitrescu: > > > > > http://dpdk.org/git/next/dpdk-next-pipeline > > > > > > > > I saw 2 issues: > > > > - table_index is wrongly placed in doxygen index > > >

Re: [dpdk-dev] [PATCH] doc: update the enic guide and features

2018-04-06 Thread Ferruh Yigit
On 4/5/2018 12:54 AM, John Daley wrote: > From: Hyong Youb Kim > > Documentation updates including for 1400 series VIC adapters. > > Remove VLAN filter from the features file as the driver does not > support that API. Hardware does support VLAN filtering, but it is not > controlled through the d

Re: [dpdk-dev] [PATCH] net/enic: support the drop flow action

2018-04-06 Thread Ferruh Yigit
On 4/5/2018 12:54 AM, John Daley wrote: > From: Hyong Youb Kim > > 1330 and 1400 series adapters support the drop action. Check for its > availability and set the necessary flag when creating NIC filters. > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley Applied to dpdk-next-net/mas

Re: [dpdk-dev] [PATCH] net/enic: fix seg fault on MTU update with non-setup queues

2018-04-06 Thread Ferruh Yigit
On 4/5/2018 12:54 AM, John Daley wrote: > The enic code called from rte_eth_dev_set_mtu() was assuming that the > Rx queues are already set up via a call to rte_eth_tx_queue_setup(). > OVS calls rte_eth_dev_set_mtu() before rte_eth_rx_queue_setup() and > a null pointer was dereferenced. > > Fixes:

Re: [dpdk-dev] [PATCH] net/enic: support UDP RSS on 1400 series adapters

2018-04-06 Thread Ferruh Yigit
On 4/5/2018 12:54 AM, John Daley wrote: > Recent models support IPv4/IPv6 UDP RSS. There is no control bit to > enable UDP RSS alone. Instead, the NIC enables/disables TCP and UDP > RSS together. > > Signed-off-by: John Daley > Reviewed-by: Hyong Youb Kim Applied to dpdk-next-net/master, thanks

Re: [dpdk-dev] [PATCH] net/enic: do not flush descriptor cache when opening vNIC

2018-04-06 Thread Ferruh Yigit
On 4/5/2018 12:54 AM, John Daley wrote: > From: Hyong Youb Kim > > The firmware on new hardware models flushes the global descriptor > cache by default. Use CMD_OPENF_IG_DESCCACHE to avoid cache > flushing. This flag has no effect on older models. > > Signed-off-by: Hyong Youb Kim > Suggested-b

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-06 Thread Thomas Monjalon
06/04/2018 13:01, Pavan Nikhilesh: > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") Please, could you provide a log of the error? Why __atomic_exchange_n is fixing the compilation?

Re: [dpdk-dev] [PATCH] net/enic: enable overlay offload for VXLAN and GENEVE

2018-04-06 Thread Ferruh Yigit
On 4/5/2018 12:54 AM, John Daley wrote: > From: Hyong Youb Kim > > Recent NIC models support overlay offload. The overlay offload > feature enables the following on the NIC. > - Rx/Tx checksum offloads for both inner and outer packets. > - Rx inner packet type classification. > - TSO. > - Inner R

Re: [dpdk-dev] [PATCH v3] ethdev: return diagnostic when setting MAC address

2018-04-06 Thread Ferruh Yigit
On 4/6/2018 4:34 PM, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addrs[0] > only if the op

Re: [dpdk-dev] [PATCH] net/i40e/vf: reset scatter_rx flag when configuration complies

2018-04-06 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Helin > Sent: Friday, April 6, 2018 11:54 PM > To: Zhang, Qi Z ; eduse...@gmail.com > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/i40e/vf: reset scatter_rx flag when configuration > complies > > > > > -Original Message- > > From: Zhang, Helin

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-04-06 Thread Zhang, Qi Z
Hi Helin: > -Original Message- > From: Zhang, Helin > Sent: Friday, April 6, 2018 10:52 PM > To: Chas Williams <3ch...@gmail.com>; Zhang, Qi Z > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin ; Charles (Chas) Williams > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: update data->eth

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Thomas Monjalon
06/04/2018 15:47, Mohammad Abdul Awal: > > On 05/04/2018 17:49, Thomas Monjalon wrote: > > 05/04/2018 15:51, Declan Doherty: > >> +struct rte_flow_item_metadata { > >> + uint32_t id;/**< field identifier */ > >> + uint32_t size; /**< field size */ > >> + uint

Re: [dpdk-dev] [PATCH v5 01/18] net/axgbe: add minimal dev init and uninit support

2018-04-06 Thread Ferruh Yigit
On 4/6/2018 1:36 PM, Ravi Kumar wrote: > Add ethernet poll mode driver for AMD 10G devices embedded in > AMD EPYC™ EMBEDDED 3000 family processors. > > Signed-off-by: Ravi Kumar Series applied to dpdk-next-net/master, thanks. Welcome to DPDK!

Re: [dpdk-dev] [PATCH] net/i40e/vf: reset scatter_rx flag when configuration complies

2018-04-06 Thread Zhang, Helin
> -Original Message- > From: Zhang, Helin > Sent: Friday, April 6, 2018 4:46 PM > To: Zhang, Qi Z; eduse...@gmail.com > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/i40e/vf: reset scatter_rx flag when configuration > complies > > > > > -Original Message- > > From: dev [mailto:de

Re: [dpdk-dev] [PATCH v3 11/11] mempool: support flushing the default cache of the mempool

2018-04-06 Thread Olivier Matz
On Mon, Mar 26, 2018 at 05:09:51PM +0100, Andrew Rybchenko wrote: > From: "Artem V. Andreev" > > Mempool get/put API cares about cache itself, but sometimes it is > required to flush the cache explicitly. > > The function is moved in the file since it now requires > rte_mempool_default_cache().

Re: [dpdk-dev] [PATCH v3 10/11] mempool: remove callback to register memory area

2018-04-06 Thread Olivier Matz
On Mon, Mar 26, 2018 at 05:09:50PM +0100, Andrew Rybchenko wrote: > The callback is not required any more since there is a new callback > to populate objects using provided memory area which provides > the same information. > > Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v3 07/11] mempool: deprecate xmem functions

2018-04-06 Thread Olivier Matz
On Mon, Mar 26, 2018 at 05:09:47PM +0100, Andrew Rybchenko wrote: > Move rte_mempool_xmem_size() code to internal helper function > since it is required in two places: deprecated rte_mempool_xmem_size() > and non-deprecated rte_mempool_op_calc_mem_size_default(). > > Suggested-by: Olivier Matz >

  1   2   3   >