Re: [dpdk-dev] mlx5 and secondary processes

2018-01-31 Thread Xueming(Steven) Li
Hi Olivier, Your issue looks like an issue fixed recently: http://www.dpdk.org/dev/patchwork/patch/34477/ Best Regards, Xueming > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Gournet > Sent: Tuesday, November 14, 2017 5:58 PM > To: dev@dpdk.org > Subj

Re: [dpdk-dev] [RFC v2 02/17] mempool: add op to calculate memory size to be allocated

2018-01-31 Thread Andrew Rybchenko
On 01/31/2018 07:45 PM, Olivier Matz wrote: On Tue, Jan 23, 2018 at 01:15:57PM +, Andrew Rybchenko wrote: diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index e783b9a..1f54f95 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-01-31 Thread Andrew Rybchenko
On 02/01/2018 08:05 AM, santosh wrote: On Wednesday 31 January 2018 10:15 PM, Olivier Matz wrote: On Tue, Jan 23, 2018 at 01:15:56PM +, Andrew Rybchenko wrote: There is not specified dependency between rte_mempool_populate_default() and rte_mempool_populate_iova(). So, the second should not

Re: [dpdk-dev] [PATCH] doc: announce API/ABI changes for mempool

2018-01-31 Thread Jerin Jacob
-Original Message- > Date: Wed, 31 Jan 2018 17:46:51 +0100 > From: Olivier Matz > To: Andrew Rybchenko > CC: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce API/ABI changes for mempool > User-Agent: NeoMutt/20170113 (1.7.2) > > On Tue, Jan 23, 2018 at 01:23:04PM +, Andre

Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail

2018-01-31 Thread Shahaf Shuler
Thursday, February 1, 2018 3:27 AM, Yanglong Wu: > And-operartion with a constant will > always lead to fail for vlan filter. It will work after dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER , right? I don't understand what this patch tries to fix. > > fix:0074d02fc(conve

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-01-31 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 01 February 2018 00:33 >To: Ahmed Mansour ; Verma, Shally >; dev@dpdk.org >Cc: Athreya, Narayana Prasad ; Gupta, >Ashish ; Sahu, Sunila >; De Lara Guarch, Pablo >; Challa, Mahipal >; Jain, Deepak K ; Hemant

[dpdk-dev] [PATCH] bnxt: Fix to set timestamp flag as well in the offload flags for the recieved pkt in case of PTP offload

2018-01-31 Thread Somnath Kotur
Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 82c93d6..430990d 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -459,7 +4

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-01-31 Thread santosh
On Wednesday 31 January 2018 10:15 PM, Olivier Matz wrote: > On Tue, Jan 23, 2018 at 01:15:56PM +, Andrew Rybchenko wrote: >> There is not specified dependency between rte_mempool_populate_default() >> and rte_mempool_populate_iova(). So, the second should not rely on the >> fact that the firs

[dpdk-dev] [PATCH] net/tap: fix ICC compilation fails

2018-01-31 Thread Zhiyong Yang
The following error is reported when compiling 18.02-rc2 usng ICC, "transfer of control bypasses initialization of". The patch fixes the issue. Fixes: 1911c5edc6cd ("net/tap: fix eBPF RSS map key handling") Cc: sta...@dpdk.org Cc: pascal.ma...@6wind.com Cc: ferruh.yi...@intel.com Cc: tho...@monjal

Re: [dpdk-dev] [PATCH v2 06/10] net/virtio: fix queue setup consistency

2018-01-31 Thread Yao, Lei A
Hi, Olivier This is Lei from DPDK validation team in Intel. During our DPDK 18.02-rc1 test, I find the following patch will cause one serious issue with virtio vector path: the traffic can't resume after stop/start the virtio device. The step like following: 1. Launch vhost-user port using tes

[dpdk-dev] [dpdk-announce] release candidate 18.02-rc2

2018-01-31 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v18.02-rc2 The release notes have been updated: http://dpdk.org/doc/guides/rel_notes/release_18_02.html What's new in RC2? - rawdev device class - ethdev port ownership -

Re: [dpdk-dev] [PATCH v1] doc: add note in proc info for stats retrieval

2018-01-31 Thread Thomas Monjalon
24/01/2018 17:47, Marko Kovacevic: > Note added to outline that using > proc_info for virtual devices is not supported > > Signed-off-by: Marko Kovacevic > --- > +.. NOTE:: > + NOTE: Stats retrieval using ``proc_info`` is not supported for virtual > devices like PCAP and TAP > Reworded a lit

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: update procinfo for shared library

2018-01-31 Thread Thomas Monjalon
30/01/2018 14:39, Kovacevic, Marko: > > added note category to procinfo guide, to intimate users in shared library > > mode. > > Procinfo requires same NIC libraries to probe the NIC devices as Primary > > Application. > > > > Signed-off-by: Vipin Varghese > > > > doc/guides/tools/proc_info.rst

Re: [dpdk-dev] [PATCH v3] doc: add a restriction to multi-process support

2018-01-31 Thread Thomas Monjalon
> > This patch add a restriction to multi-process support: secondary processes > > should only run alongside primary process with same DPDK version, so that > > secondary processes can use the same hugepage mmap layout as primary > > process. > > > > Signed-off-by: Junjie Chen > > Acked-by: John

[dpdk-dev] [PATCH] net/i40e:fix VSI stats error

2018-01-31 Thread Yanglong Wu
In VF, the number of ibytes read from register have been stripped out CRC already, but in stats, it subtracts CRC bytes again. So it lead to RX bytes is smaller than TX bytes. Fixes: 98abce23(fix VF statistics) Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c | 4 1 file change

Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail

2018-01-31 Thread Thomas Monjalon
01/02/2018 02:26, Yanglong Wu: > And-operartion with a constant will > always lead to fail for vlan filter. > > fix:0074d02fc(convert to new Rx offloads API) > Signed-off-by: Yanglong Wu [...] > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -2288,7 +2288,7 @@ rte_

Re: [dpdk-dev] [PATCH] lpm: fix allocation of an existing object

2018-01-31 Thread Yang, Zhiyong
Hi Pavan, Good catch! Thank you for fixing it. It's my negligence. Thanks Zhiyong > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, January 31, 2018 2:52 AM > To: tho...@monjalon.net; Yang, Zhiyong ; Yigit, > Ferruh ; olivier.m..

Re: [dpdk-dev] [PATCH] event/opdl: fix license header and SPDX tags

2018-01-31 Thread Thomas Monjalon
23/01/2018 15:17, Liang, Ma: > On 23 Jan 14:11, Bruce Richardson wrote: > > This patch ensures that the OPDL files all contain correct SPDX tags. > > The following changes were made to achieve this: > > * replace license text with SPDX tag > > * correct occurances where SPDX tag was not on first li

Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk

2018-01-31 Thread Neil Horman
On Thu, Feb 01, 2018 at 01:31:34AM +0100, Thomas Monjalon wrote: > 05/01/2018 11:53, Thomas Monjalon: > > 04/12/2017 16:55, Neil Horman: > > > +#SPDX-License-Identifier:BSD-3-Clause > > > +#Copyright(c) 2015 Neil Horman. All rights reserved. > > > +#Copyright(c) 2017

Re: [dpdk-dev] [PATCH] doc: replace license text with SPDX tags on SVG images

2018-01-31 Thread Thomas Monjalon
23/01/2018 14:33, Bruce Richardson: > Signed-off-by: Bruce Richardson Applied, thanks

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow priority on queue action

2018-01-31 Thread Yongseok Koh
> On Jan 31, 2018, at 8:13 AM, Nelio Laranjeiro > wrote: > > A single queue should have the same verbs priority as an RSS one. > > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") > Cc: sta...@dpdk.org > > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Ko

Re: [dpdk-dev] [PATCH] config: replace Intel license headers with SPDX tags

2018-01-31 Thread Thomas Monjalon
23/01/2018 15:21, Bruce Richardson: > Signed-off-by: Bruce Richardson > --- > config/common_base| 33 > ++- > config/common_bsdapp | 33 > ++- > config/common_linuxapp| 3

Re: [dpdk-dev] [PATCH 00/17] use SPDX tags on 6WIND copyrighted files

2018-01-31 Thread Thomas Monjalon
30/01/2018 15:06, Hemant Agrawal: > On 1/29/2018 6:41 PM, Olivier Matz wrote: > > This patchset updates the license on files that contain a 6WIND copyright > > to use a SPDX tag. > > It applies on master + https://dpdk.org/dev/patchwork/patch/34604/ > > > > For components I am maintaining (mempool

[dpdk-dev] [PATCH] app/testpmd:vlan filter fail

2018-01-31 Thread Yanglong Wu
And-operartion with a constant will always lead to fail for vlan filter. fix:0074d02fc(convert to new Rx offloads API) Signed-off-by: Yanglong Wu --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether

[dpdk-dev] [PATCH] pci/uio: enable prefetchable resources mapping

2018-01-31 Thread Changpeng Liu
For PCI prefetchable resources, Linux will create a write combined file as well, the library will try to map resourceX_wc file first, if the file does not exist, then it will map resourceX as usual. Signed-off-by: Changpeng Liu --- drivers/bus/pci/linux/pci_uio.c | 19 ++- 1 file

Re: [dpdk-dev] [PATCH] ring: convert license headers to SPDX tags

2018-01-31 Thread Thomas Monjalon
> > Signed-off-by: Jia He > > Acked-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk

2018-01-31 Thread Thomas Monjalon
05/01/2018 11:53, Thomas Monjalon: > 04/12/2017 16:55, Neil Horman: > > +# SPDX-License-Identifier:BSD-3-Clause > > +# Copyright(c) 2015 Neil Horman. All rights reserved. > > +# Copyright(c) 2017 6WIND S.A. > > +# All rights reserved > [...] > > /*- > > - * BSD LICENSE > > + * SPDX

Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specific TSC freq query

2018-01-31 Thread Thomas Monjalon
30/01/2018 09:59, Gowrishankar: > From: Gowrishankar Muthukrishnan > > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3 > (eal/ppc64: implement arch-specific TSC freq query). We intended > to derive pkt/sec estimation with cpu clock frequency. As timebase > register serves the timer p

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

2018-01-31 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Thursday, February 1, 2018 1:48 AM > To: dev@dpdk.org > Cc: Chen, Junjie J ; Yuanhan Liu > ; > Liu, Changpeng ; Maxime Coquelin > ; Stefan Hajnoczi > Subject: [PATCH] examples/vhost_scsi: drop unimplemente

Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add delay during updating link status

2018-01-31 Thread Thomas Monjalon
> > Add up to 9s delay for getting link status to make sure NIC updates > > link status successfully, just like other applications such as > > testpmd and l2fwd. > > > > Signed-off-by: Beilei Xing > > Acked-by: Ori Kam Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] examples/bond: add mbuf alloc check

2018-01-31 Thread Thomas Monjalon
24/01/2018 14:16, Radu Nicolau: > Fixes: cc7e8ae84faa ("examples/bond: add example application for link bonding > mode 6") > Coverity issue: 257008 > Cc: sta...@dpdk.org > > Signed-off-by: Radu Nicolau Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/vm_power_manager: fix set VF MAC address

2018-01-31 Thread Thomas Monjalon
23/01/2018 15:32, Hunt, David: > Hi David, > > On 23/1/2018 2:14 PM, David Coyle wrote: > > Current code only sets mac address of first VF. Fix code so that it > > continues through the loop and sets the mac address of each VF. > > > > Fixes: c9a4779135c9 ("examples/vm_power_mgr: set MAC address o

Re: [dpdk-dev] [PATCH v2 1/2] test/memzone: add test for memzone count in eal mem config

2018-01-31 Thread Thomas Monjalon
31/01/2018 16:29, Anatoly Burakov: > Ensure that memzone count in eal mem config is incremented and > decremented whenever memzones are allocated and freed. > > Signed-off-by: Anatoly Burakov Please report acks from previous version.

Re: [dpdk-dev] [PATCH v3 1/6] test: fix memory leak in bitmap test

2018-01-31 Thread Thomas Monjalon
17/01/2018 12:15, Anatoly Burakov: > Acked-by: Cristian Dumitrescu > > Fixes: c7e4a134e769 ("test: verify bitmap operations") > Cc: pbhagavat...@caviumnetworks.com > > Signed-off-by: Anatoly Burakov I think you missed to report some previous acks in this series.

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/pmd-perf: declare variables as static

2018-01-31 Thread Thomas Monjalon
19/01/2018 15:37, Pablo de Lara: > Some variables in the PMD perf test were declared as global, > but they are only used in this test, so they should actually > be declared as static. > > Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx") > Cc: sta...@dpdk.org > > Signed-off-by:

Re: [dpdk-dev] [PATCH v3 1/3] kni: support for MAC addr change

2018-01-31 Thread Thomas Monjalon
22/01/2018 16:48, Ferruh Yigit: > >> On 1/18/2018 6:12 AM, Hemant Agrawal wrote: > >>> This patch adds following: > >>> 1. Option to configure the mac address during create. Generate random > >>>address only if the user has not provided any valid address. > >>> 2. Inform usespace, if mac addres

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] power: switching to unbuffered access for /sys files

2018-01-31 Thread Thomas Monjalon
01/12/2017 22:01, Radoslaw Biernacki: > Hi David, > > Sorry for log delay. > I will make V3 with your suggestions. > Thanks. Hi, Any news?

Re: [dpdk-dev] [PATCH] lpm: fix allocation of an existing object

2018-01-31 Thread Thomas Monjalon
31/01/2018 14:30, Burakov, Anatoly: > On 30-Jan-18 6:51 PM, Pavan Nikhilesh wrote: > > Fix rte_lpm_create_*() functions to return NULL and set rte_errno to > > EEXIST when lpm object name already exists. > > This is the behavior described in the API documentation in the header > > file. > > > > Fi

Re: [dpdk-dev] [PATCH v4] crypto/qat: add null point check and fix mem leak

2018-01-31 Thread Thomas Monjalon
> > There are several func calls to rte_zmalloc() which don't do null > > point check on the return value. And before return, the memory is not > > freed. Fix it by adding null point check and rte_free(). > > > > Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") > > Fixes: e09231eaa2

Re: [dpdk-dev] [PATCH v2 0/3] Increase default RX/TX ring sizes

2018-01-31 Thread Thomas Monjalon
30/01/2018 14:48, Adrien Mazarguil: > On Mon, Jan 29, 2018 at 04:25:00PM +, Bruce Richardson wrote: > > On Tue, Jan 16, 2018 at 02:13:19PM +0100, Adrien Mazarguil wrote: > > > Hi Kevin, > > > > > > On Fri, Jan 12, 2018 at 10:48:43AM +, Kevin Laatz wrote: > > > > Increasing the RX/TX defaul

Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table

2018-01-31 Thread Thomas Monjalon
30/01/2018 11:00, Adrien Mazarguil: > On Sun, Jan 28, 2018 at 12:58:39PM +0100, Tomasz Duszynski wrote: > > Since METER action is supported by the testpmd application > > suitable entry should exist in flow actions information table. > > > > Without that testpmd will return error on adding a new f

Re: [dpdk-dev] [PATCH] app/testpmd: add missing args to TM show cap cmd

2018-01-31 Thread Thomas Monjalon
> > Command used for querying node or level capabilities requires argument > > which specifies which set of capabilities to show. > > > > Thus trying to show node/level capabilities using current documentation will > > not work. Fix that by adding missing arguments to command documentation. > > >

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-31 Thread Thomas Monjalon
25/01/2018 07:54, Shahaf Shuler: > Hi Jiayu Hu, > > Good fix, thanks. > > Thursday, January 25, 2018 4:14 AM, Jiayu Hu: > > In current design, we can't enable SW checksum calculation for the devices > > which don't have checksum offloading abilities via the command "csum set > > ip|tcp|udp|sctp|o

Re: [dpdk-dev] [PATCH] app/testpmd: fix dereference null return valiue

2018-01-31 Thread Thomas Monjalon
22/01/2018 16:45, Jasvinder Singh: > Calloc() function might returns NULL due to insufficient space. Therefore, > check for handling memory allocation failure is added. > > Coverity issue: 257030 > Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") > > Signed-off-by: Jasv

Re: [dpdk-dev] [PATCH] app/testpmd: fix dereference null return valiue

2018-01-31 Thread Thomas Monjalon
22/01/2018 16:15, Jasvinder Singh: > Malloc() function might return NULL due to insufficient space. Therefore, > check for handling memory allocation failure is added. > > Coverity issue: 257039 > Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") > > Signed-off-by: Jasvind

Re: [dpdk-dev] [PATCH v1] testpmd: fix incorrect port_id word size

2018-01-31 Thread Thomas Monjalon
20/01/2018 14:33, Ferruh Yigit: > On 1/19/2018 1:27 PM, Remy Horton wrote: > > "app/testpmd: fix incorrect port id word size" ? > > > The word size of port_id is now 16 bits, but there were parsing directives > > that assumed it was still of type UINT8, resulting in incorrect commandline > > pars

Re: [dpdk-dev] [PATCH] app/testpmd: move variables definition in source

2018-01-31 Thread Thomas Monjalon
24/01/2018 12:53, Georgios P. Katsikas: > From: Georgios Katsikas > > This patch moves the definition of 3 variables in testpmd.h > into the respective .c file. The idea behind this move is > to allow external applications to compile against testpmd > without throwing compilation errors related t

Re: [dpdk-dev] [PATCH v2] app/testpmd: change log level at run time

2018-01-31 Thread Thomas Monjalon
22/01/2018 23:09, Elza Mathew: > Introduced a run time command to change the > log level for a given log type. Added the > necessary documentation. > > V2: Changed the position of the command in > the documentation since generic commands > are placed at the beginning. > > Signed-off-by: Elza Math

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-31 Thread Ravi Kerur
On Wed, Jan 31, 2018 at 1:59 AM, Burakov, Anatoly wrote: > On 29-Jan-18 10:35 PM, Ravi Kerur wrote: > >> Hi Burakov, >> >> When using vfio-pci on host both VF and PF interfaces works fine with >> dpdk i.e. I don't see DMAR fault messages anymore. However, when I attach a >> VF interface to a VM a

Re: [dpdk-dev] [PATCH v7] app/testpmd: removed preconf Rx VLAN offloads

2018-01-31 Thread Thomas Monjalon
31/01/2018 18:32, Moti Haimovsky: > Removed the hardcoded preconfigured Rx VLAN offload configuration > from testpmd and changed the Rx offload command line parameters from > disable to enable. > It has been decided by the Technical Board that testers who wish to > use these offloads will now have

Re: [dpdk-dev] [PATCH v5 0/5] Introducing Wirless Base Band Device (bbdev) abstraction library

2018-01-31 Thread Thomas Monjalon
31/01/2018 21:29, Mokhtar, Amr: > From: Thomas Monjalon > > 11/01/2018 20:23, Amr Mokhtar: > > > Hello, > > > Latest update for Wireless Device abstraction library. > > > > Applied with few changes: > > - fixed title formats > > - moved bbdev between ethdev and cryptodev in lists > > - added in te

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detach

2018-01-31 Thread Thomas Monjalon
30/01/2018 15:13, Matan Azrad: > Using registration to all ports includes also the ports which should not > be used by the application. > > It is nice to print each port event by testpmd but in case of RMV > event, testpmd tries to detach the port and this case is problematic > when the port shoul

Re: [dpdk-dev] [PATCH v5 0/5] Introducing Wirless Base Band Device (bbdev) abstraction library

2018-01-31 Thread Mokhtar, Amr
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday 19 January 2018 00:45 > To: Mokhtar, Amr > Cc: dev@dpdk.org; Yigit, Ferruh ; Burakov, Anatoly > ; De Lara Guarch, Pablo > ; Power, Niall ; > Macnamara, Chris > Subject: Re: [dpdk-dev] [PATCH v5 0/5]

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: remove speed parameter from TAP args

2018-01-31 Thread Ferruh Yigit
On 1/26/2018 5:20 PM, Ferruh Yigit wrote: > On 1/26/2018 10:27 PM, Vipin Varghese wrote: >> TAP is a virtual device created on Kernel. The speed of interface is >> set by Kernel to a fixed static value. But this does not prevent using >> RX or TX to rate limit. Hence removing the option from user a

Re: [dpdk-dev] [PATCH v5 0/7] Port ownership and synchronization

2018-01-31 Thread Thomas Monjalon
29/01/2018 12:21, Matan Azrad: > > Hi all > > Since there is not agreement for testpmd to be ownership aware by using the > new ownership mechanism, > I think we can drop testpmd patch for now(app/testpmd: adjust ethdev port > ownership). It has been agreed today by the Technical Board. First

Re: [dpdk-dev] [PATCH] net/octeontx: register fpa as platform HW mempool

2018-01-31 Thread Ferruh Yigit
On 1/22/2018 3:45 PM, Pavan Nikhilesh wrote: > Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is > used. > > Signed-off-by: Pavan Nikhilesh > --- > > This patch depends on http://dpdk.org/dev/patchwork/patch/34239 patchset. This patch was waiting dependent patch, which se

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/bond: fix vdev name in bond sample app

2018-01-31 Thread Ferruh Yigit
On 1/26/2018 8:12 AM, De Lara Guarch, Pablo wrote: > > >> -Original Message- >> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Radu Nicolau >> Sent: Thursday, January 25, 2018 4:26 PM >> To: dev@dpdk.org >> Cc: Doherty, Declan ; Nicolau, Radu >> ; sta...@dpdk.org >> Subject: [

Re: [dpdk-dev] [PATCH] test/virtual_pmd: add set MAC address dev op

2018-01-31 Thread Ferruh Yigit
On 1/29/2018 2:23 PM, Radu Nicolau wrote: > Needed if used with net/bonding > > Signed-off-by: Radu Nicolau > --- > test/test/virtual_pmd.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c > index 7a7adbb..2b5383a 1

Re: [dpdk-dev] [PATCH] test/bonding: assign non-zero MAC to null devices

2018-01-31 Thread Ferruh Yigit
On 1/29/2018 2:26 PM, Radu Nicolau wrote: Hi Radu, Can you please describe why this is needed? > Signed-off-by: Radu Nicolau > --- > test/test/test_link_bonding_rssconf.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/test/test/test_link_bonding_rssconf.c > b/test/test/test_l

Re: [dpdk-dev] [PATCH] net/bonding: fix burst hash computation

2018-01-31 Thread Ferruh Yigit
On 1/29/2018 2:36 PM, Radu Nicolau wrote: > Fixes: 09150784a776 ("net/bonding: burst mode hash calculation") > Cc: sta...@dpdk.org > > Wrong function was used for l23 and l34 hashing > slave index was incremented twice. > > Signed-off-by: Radu Nicolau Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/avf: fix unchecked return value issue

2018-01-31 Thread Ferruh Yigit
On 1/30/2018 9:10 AM, Jingjing Wu wrote: > This patch fixes the coverity CHECKED_RETURN issue. > > Coverity issue: 257045 > Fixes: 48de41ca11f0 ("net/avf: enable link status update") > > Reported-by: John McNamara > Signed-off-by: Jingjing Wu Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] net/avf: fix uninitialized variables issue

2018-01-31 Thread Ferruh Yigit
On 1/30/2018 3:32 AM, Jingjing Wu wrote: > This patch fixes the coverity UNINIT issue. > > Coverity issue: 257016, 257036 > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > > Reported-by: John McNamara > Signed-off-by: Jingjing Wu Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/null: add set MAC address dev op

2018-01-31 Thread Ferruh Yigit
On 1/29/2018 2:20 PM, Radu Nicolau wrote: > Needed if used with net/bonding > > Signed-off-by: Radu Nicolau > --- > drivers/net/null/rte_eth_null.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index 7cd5c71..

Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC

2018-01-31 Thread Ferruh Yigit
On 1/30/2018 6:06 AM, Andrew Rybchenko wrote: > On 01/29/2018 08:13 PM, Olivier Matz wrote: >> Announce internal PMD API change in the function to set the default MAC >> address. The objective is to be able to notify errors occurring in the >> PMD. >> >> Link: https://dpdk.org/dev/patchwork/patch/3

Re: [dpdk-dev] [PATCH v2] net/dpaa2: fix the err with testpmd in Tx only mode

2018-01-31 Thread Ferruh Yigit
On 1/30/2018 3:24 PM, Hemant Agrawal wrote: > Fixes: 043b36f621dd ("net/dpaa2: support more than 16 burst size in Rx") > > Signed-off-by: Hemant Agrawal Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-01-31 Thread Trahe, Fiona
Hi Ahmed, Shally, ///snip/// > > D.1.1 Stateless and OUT_OF_SPACE > > > > OUT_OF_SPACE is a condition when output buffer runs out of space > >> and > where PMD still has more data to produce. If PMD run into such > >> condition, > >

Re: [dpdk-dev] [PATCH v2 0/2] fix eBPF TAP RSS leakage and map key handling

2018-01-31 Thread Ferruh Yigit
On 1/30/2018 4:10 PM, Pascal Mazon wrote: > The patches look good to me. > Good catch. > > On 30/01/2018 17:00, Ophir Munk wrote: >> v2: >> fix eBPF RSS map key handling >> >> v1: >> fix eBPF file descriptors leakage >> >> Ophir Munk (2): >> net/tap: fix eBPF file descriptors leakage >> net/ta

Re: [dpdk-dev] [PATCH] ethdev: fix MTU setup error

2018-01-31 Thread Ferruh Yigit
On 1/31/2018 6:34 PM, Ferruh Yigit wrote: > On 1/31/2018 2:08 AM, Mallesh Koujalagi wrote: > > net/null: support MTU update > >> NULL device is failed to attach ovs, reported operation not supported >> and configuration failed. >> >> To attach ovs: >> $VSCTL add-port ovs-br dpdk1 -- set Interface

Re: [dpdk-dev] [PATCH] ethdev: fix MTU setup error

2018-01-31 Thread Ferruh Yigit
On 1/31/2018 2:08 AM, Mallesh Koujalagi wrote: net/null: support MTU update > NULL device is failed to attach ovs, reported operation not supported > and configuration failed. > > To attach ovs: > $VSCTL add-port ovs-br dpdk1 -- set Interface dpdk1 type=dpdk \ > options:dpdk-devargs=eth_

[dpdk-dev] [PATCH] net/tap: allow user MAC to be passed as args

2018-01-31 Thread Vipin Varghese
Allow TAP PMD to pass user desired MAC address as argument. The argument value is processed as string, where each 2 bytes are converted to HEX MAC address after validation. Signed-off-by: Vipin Varghese --- doc/guides/nics/tap.rst | 6 + drivers/net/tap/rte_eth_tap.c | 62

Re: [dpdk-dev] [PATCH v5 3/5] bbdev: software turbo driver

2018-01-31 Thread Mokhtar, Amr
Hi Thomas, Thanks for adding that.. The env variable (DIR_WIRELESS_SDK) is needed by FLEXRAN SDK itself. Best regards, Amr -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Friday 19 January 2018 00:24 To: Mokhtar, Amr Cc: dev@dpdk.org; Yigit, Ferruh ; Burakov,

Re: [dpdk-dev] [PATCH v1] net/tap: fix build on ARM

2018-01-31 Thread Thomas Monjalon
31/01/2018 17:03, Ophir Munk: > This commit adds eBPF system call definitions for ARM architecture. > Old Linux header files may not define eBPF system call numbers. > In order to successful compile eBPF on all Linux platforms - the > missing ARM system call definition is explicitly added. > > Fix

Re: [dpdk-dev] [PATCH 2/2] vhost: only drop vqs with built-in virtio_net.c driver

2018-01-31 Thread Maxime Coquelin
Hi Stefan, On 01/31/2018 06:46 PM, Stefan Hajnoczi wrote: Commit e29109323595beb3884da58126ebb3b878cb66f5 ("vhost: destroy unused virtqueues when multiqueue not negotiated") broke vhost-scsi by removing virtqueues when the virtio-net-specific VIRTIO_NET_F_MQ feature bit is missing. The vhost_us

Re: [dpdk-dev] [PATCH v2] crypto/scheduler: fix strncpy

2018-01-31 Thread Thomas Monjalon
> > The coverity issue was not completely fixed, since strncpy should not be > > called with max length. > > Instead, snprintf is used as a safer option. > > > > Coverity issue: 143431 > > Fixes: d040aca67170 ("crypto/scheduler: fix strings not null terminated") > > Cc: sta...@dpdk.org > > > > Si

[dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

2018-01-31 Thread Stefan Hajnoczi
The vhost_scsi example application negotiates the VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing vrings. In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost: support virtqueue interrupt/notification suppression") broke vring call because vq->last_used_i

[dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage

2018-01-31 Thread Stefan Hajnoczi
These patches fix a recent regression in librte_vhost that breaks the vhost_scsi example application. vhost_user.c assumes all devices are vhost net backends when handling the VIRTIO_NET_F_MQ feature bit. The code is triggered by vhost scsi devices and causes virtqueues to be removed. See Patch

[dpdk-dev] [PATCH 2/2] vhost: only drop vqs with built-in virtio_net.c driver

2018-01-31 Thread Stefan Hajnoczi
Commit e29109323595beb3884da58126ebb3b878cb66f5 ("vhost: destroy unused virtqueues when multiqueue not negotiated") broke vhost-scsi by removing virtqueues when the virtio-net-specific VIRTIO_NET_F_MQ feature bit is missing. The vhost_user.c code shouldn't assume all devices are vhost net device b

[dpdk-dev] [PATCH 1/2] vhost: add flag for built-in virtio_net.c driver

2018-01-31 Thread Stefan Hajnoczi
The librte_vhost API is used in two ways: 1. As a vhost net device backend via rte_vhost_enqueue/dequeue_burst(). 2. As a library for implementing vhost device backends. There is no distinction between the two at the API level or in the librte_vhost implementation. For example, device state is ke

[dpdk-dev] [PATCH 6/6] examples: fix meson build on FreeBSD

2018-01-31 Thread Bruce Richardson
Fixes: 89f0711f9ddf ("examples: build some samples with meson") Signed-off-by: Bruce Richardson --- examples/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/meson.build b/examples/meson.build index 5658fbe04..2c6b3f889 100644 --- a/examples/meson.build

[dpdk-dev] [PATCH 5/6] test/test: fix dependency on KNI lib for BSD meson build

2018-01-31 Thread Bruce Richardson
The KNI library is not built on FreeBSD, so it needs to be an optional rather than a mandatory dependency for building the autotest binary. Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") Signed-off-by: Bruce Richardson --- test/test/meson.build | 3 +++ 1 file changed, 3 insert

[dpdk-dev] [PATCH 3/6] test/test: mark tests as skipped when required lib not available

2018-01-31 Thread Bruce Richardson
The power management and KNI libraries are not compiled on a FreeBSD platform, which means that the tests can't run. Add in stub code for these cases, allowing the tests to still be compiled, but to report as skipped in those cases. Signed-off-by: Bruce Richardson CC: Ferruh Yigit CC: David Hunt

[dpdk-dev] [PATCH 4/6] test/test: fix dependency on power lib for BSD meson build

2018-01-31 Thread Bruce Richardson
The power library is not built on FreeBSD, so it needs to be an optional rather than a mandatory dependency for building the autotest binary. Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") Signed-off-by: Bruce Richardson --- test/test/meson.build | 4 +++- 1 file changed, 3 ins

[dpdk-dev] [PATCH 2/6] build: add dependency on execinfo for BSD meson builds

2018-01-31 Thread Bruce Richardson
The binaries and apps in DPDK all need to be linked against the execinfo library on FreeBSD so add this as a dependency in cases where it is found. It's available by default on BSD, but not at all on Linux Signed-off-by: Bruce Richardson --- app/test-eventdev/meson.build | 1 + app/test-pmd/meso

[dpdk-dev] [PATCH 1/6] eal/bsdapp: fix building kernel modules

2018-01-31 Thread Bruce Richardson
The kernel module source file directory passed via VPATH was wrong, which caused the source files to be not found via make. Rather than explicitly passing VPATH, make use of the fact that the full path to the source files is passed by meson, so split that into directory part - to be used as VPATH -

[dpdk-dev] [PATCH 0/6] Fix meson build on FreeBSD

2018-01-31 Thread Bruce Richardson
There are a few issues with building DPDK for FreeBSD using the meson build system, specifically: * the kernel modules aren't compiling due to an incorrect VPATH * a number of unit tests depend on libraries not supported on BSD * applications and examples need to be linked with execinfo library. B

[dpdk-dev] [PATCH v7] app/testpmd: removed preconf Rx VLAN offloads

2018-01-31 Thread Moti Haimovsky
Removed the hardcoded preconfigured Rx VLAN offload configuration from testpmd and changed the Rx offload command line parameters from disable to enable. It has been decided by the Technical Board that testers who wish to use these offloads will now have to explicitly write them in the command-line

Re: [dpdk-dev] [PATCH] examples/bbdev: fix unchecked return value

2018-01-31 Thread Thomas Monjalon
31/01/2018 15:40, Amr Mokhtar: > Added a check on rte_bbdev_stats_get() return before > printing out the statistics results. > > Coverity issue: 257018 > Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") > > Signed-off-by: Amr Mokhtar Applied, thanks

Re: [dpdk-dev] [PATCH] examples/bbdev: fix memory leak

2018-01-31 Thread Thomas Monjalon
31/01/2018 15:30, Amr Mokhtar: > xstats and xstats_names buffers were allocated for > the purpose of printing eth_xstats, but were not > freed before exit. > A fix is added to free before exit points. > > Coverity issue: 257013 > Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") > > Signed-o

Re: [dpdk-dev] [PATCH] examples/bbdev: fix out-of-bounds access

2018-01-31 Thread Thomas Monjalon
31/01/2018 15:19, Amr Mokhtar: > eth_address was improperly accessed in bbdev example > app, this patch removes the use of port_id, it is > irrelevant here. > > Coverity issue: 257021 > Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") > > Signed-off-by: Amr Mokhtar Applied, thanks

[dpdk-dev] [PATCH v3] checkpatches.sh: Add checks for ABI symbol addition

2018-01-31 Thread Neil Horman
Recently, some additional patches were added to allow for programmatic marking of C symbols as experimental. The addition of these markers is dependent on the manual addition of exported symbols to the EXPERIMENTAL section of the corresponding libraries version map file. The consensus on review i

Re: [dpdk-dev] [PATCH v3] doc: update flow filtering document

2018-01-31 Thread Ferruh Yigit
On 1/31/2018 2:12 AM, Wei Zhao wrote: > This patch will update example application of flow_filtering document. > It add Tx queues configuration related comment. > > Signed-off-by: Wei Zhao > Reviewed-by: Ori Kam Hi Wei, This patch is causing documentation warning: ...dpdk/doc/guides/sample_app

Re: [dpdk-dev] [PATCH v6] app/testpmd: no Rx or Tx offloads by default

2018-01-31 Thread Thomas Monjalon
31/01/2018 17:59, Moti Haimovsky: > Removed the hardcoded preconfigured Rx and Tx offload configuration > from testpmd and changed the Rx offload command line parameters from > disable to enable. The description must be updated because v6 does not remove the last default Tx offload. > Testers who

[dpdk-dev] [PATCH] net/i40e: fix missing deps for avx2 code in meson

2018-01-31 Thread Bruce Richardson
The AVX2 code path includes files from the ethdev, hash and kvargs libs. These are not listed as dependencies in the case where AVX2 is not in the default instruction set for the build e.g. machine=nehalem. This leads to compiler errors as the header files needed cannot be found. Fixes: e940646b20

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-31 Thread Matan Azrad
Hi Adrien From: Adrien Mazarguil , Sent: Wednesday, January 31, 2018 4:32 PM > Hi Matan, > > On Wed, Jan 31, 2018 at 01:44:41PM +, Matan Azrad wrote: > > Hi Adrien > > > > From: Adrien Mazarguil, Sent: Wednesday, January 31, 2018 12:44 PM > > > On Wed, Jan 31, 2018 at 10:08:06AM +, Matan

[dpdk-dev] [PATCH v6] app/testpmd: no Rx or Tx offloads by default

2018-01-31 Thread Moti Haimovsky
Removed the hardcoded preconfigured Rx and Tx offload configuration from testpmd and changed the Rx offload command line parameters from disable to enable. Testers who wish to use these offloads will now have to explicitly write them in the command-line when running testpmd. The above does not appl

Re: [dpdk-dev] [PATCH] doc: announce API/ABI changes for mempool

2018-01-31 Thread Olivier Matz
On Tue, Jan 23, 2018 at 01:23:04PM +, Andrew Rybchenko wrote: > An API/ABI changes are planned for 18.05 [1]: > > * Allow to customize how mempool objects are stored in memory. > * Deprecate mempool XMEM API. > * Add mempool driver ops to get information from mempool driver and >dequeue

[dpdk-dev] [PATCH v1] doc: update definition of lcore id and lcore index

2018-01-31 Thread Marko Kovacevic
Added examples in lcore index for better explanation on various examples, Sited examples for lcore id. Signed-off-by: Marko Kovacevic --- lib/librte_eal/common/include/rte_lcore.h | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include

Re: [dpdk-dev] [RFC v2 11/17] mempool: ensure the mempool is initialized before populating

2018-01-31 Thread Olivier Matz
On Tue, Jan 23, 2018 at 01:16:06PM +, Andrew Rybchenko wrote: > From: "Artem V. Andreev" > > Callback to calculate required memory area size may require mempool > driver data to be already allocated and initialized. > > Signed-off-by: Artem V. Andreev > Signed-off-by: Andrew Rybchenko > --

Re: [dpdk-dev] [RFC v2 04/17] mempool: add op to populate objects using provided memory

2018-01-31 Thread Olivier Matz
On Tue, Jan 23, 2018 at 01:15:59PM +, Andrew Rybchenko wrote: > The callback allows to customize how objects are stored in the > memory chunk. Default implementation of the callback which simply > puts objects one by one is available. > > Suggested-by: Olivier Matz > Signed-off-by: Andrew Ryb

Re: [dpdk-dev] [RFC v2 02/17] mempool: add op to calculate memory size to be allocated

2018-01-31 Thread Olivier Matz
On Tue, Jan 23, 2018 at 01:15:57PM +, Andrew Rybchenko wrote: > Size of memory chunk required to populate mempool objects depends > on how objects are stored in the memory. Different mempool drivers > may have different requirements and a new operation allows to > calculate memory size in accor

  1   2   >