On 1/30/2018 6:06 AM, Andrew Rybchenko wrote: > On 01/29/2018 08:13 PM, Olivier Matz wrote: >> Announce internal PMD API change in the function to set the default MAC >> address. The objective is to be able to notify errors occurring in the >> PMD. >> >> Link: https://dpdk.org/dev/patchwork/patch/32284/ >> >> Signed-off-by: Olivier Matz <olivier.m...@6wind.com> >> --- >> doc/guides/rel_notes/deprecation.rst | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst >> b/doc/guides/rel_notes/deprecation.rst >> index 43a39d827..8ad4407c2 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -76,3 +76,11 @@ Deprecation Notices >> * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are >> respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old >> names will be removed in v18.08. >> + >> +* ethdev: The prototype and the behavior of >> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code >> + will be added to notify the caller if an error occurred in the PMD. In >> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address >> + will be copied in ``dev->data->mac_addrs[0]`` only if the operation is >> + succesfull. This modification will only impact the PMDs, not the >> + applications. > > Acked-by: Andrew Rybchenko <arybche...@solarflare.com>
Acked-by: Ferruh Yigit <ferruh.yi...@intel.com>