22/01/2018 05:41, Jia He:
> Changelog:
> V9: remove the SPDX tag and refine commit logs
Why did you remove the SPDX tag?
You need to fix the licensing issue.
BSD-2-Clause is uncommon in DPDK.
Hi,
22/01/2018 03:53, wang.yon...@zte.com.cn:
> Hi,
> I've sent this patch again and it is accepted.
> The other 3 pathes have no conflict with the latest master version and the
> titles have described the modification of the patches.
> So I need not send the patches for v3, right?
Please re-sen
On 2018/1/19 22:37, Yuanhan Liu wrote:
On Thu, Dec 21, 2017 at 05:15:40PM +0800, Bing Zhao wrote:
In the fdset_move, after copying the fd&rwfds from the src to the dst, the fd
should be set to -1. Or else in some cases, there will be a fault missing. E.g:
Before: 1 -1 3 4 -1 6 7 -1 9 10
After:
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Saturday, January 20, 2018 11:50 PM
> To: Zhoujian (jay)
> Cc: dev@dpdk.org; Zhang, Roy Fan ;
> y...@fridaylinux.org; maxime.coque...@redhat.com; Gonglei (Arei)
> ; Zeng, Xin ; Huangweidong (C)
>
On Fri, Jan 12, 2018 at 01:07:34PM +, Singh, Jasvinder wrote:
>
>
> > -Original Message-
> > From: Dumitrescu, Cristian
> > Sent: Thursday, January 11, 2018 6:34 PM
> > To: Tomasz Duszynski ; dev@dpdk.org
> > Cc: Lu, Wenzhuo ; Wu, Jingjing
> > ; Singh, Jasvinder
> > Subject: RE: [dpdk-
Hi Herbert,
Thanks for the review, will add a default entry for generic arm.
On Mon, Jan 22, 2018 at 05:52:36AM +, Herbert Guan wrote:
> Hi, Pavan
>
> Please see my notes inline.
>
> Best regards,
> Herbert
>
> > -Original Message-
> > From: Pavan Nikhilesh [mailto:pbhagavat...@cavium
Signed-off-by: Jia He
---
lib/librte_ring/rte_ring.c | 66 +++---
lib/librte_ring/rte_ring.h | 66 +++---
lib/librte_ring/rte_ring_c11_mem.h | 65 +++--
lib/librte_ring/rte_ring_generic
I add this code line to align same style and same action taken in ixgbe VF and
i40e VF.
In ixgbe VF or i40e VF, without this line, the initialization of Rx queue
interrupt mapping to VFIO-PCI vectors would fail.
I have tested it in ixgbe PF port with example/l3fwd-power and
found the interrupt
Hi All,
> -Original Message-
> From: Gujjar, Abhinandan S
> Sent: Thursday, January 18, 2018 12:22 PM
> To: Akhil Goyal ; De Lara Guarch, Pablo
> ; Doherty, Declan
> ; Jacob, Jerin
>
> Cc: dev@dpdk.org; Vangati, Narender ; Rao,
> Nikhil
> Subject: RE: [PATCH 1/2] lib/cryptodev: add suppo
Hi Ferruh,
On 1/22/2018 3:37 AM, Ferruh Yigit wrote:
On 1/18/2018 6:12 AM, Hemant Agrawal wrote:
This patch adds following:
1. Option to configure the mac address during create. Generate random
address only if the user has not provided any valid address.
2. Inform usespace, if mac address is
This patch implements driver specific log type doing away with
usage of RTE_LOG() for logging.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h | 8 ++
drivers/net/bnxt/bnxt_cpr.c | 10 +-
drivers/net/bnxt/bnxt_ethdev.c | 233 +---
drive
Currently this is implemented entirely in the PMD as there is no explicit
support in the HW. Re-program the RSS Table without this queue on stop
and add it back to the table on start.
Signed-off-by: Somnath Kotur
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 125
In certain cases the MAC address of a port could be all zeros.
Catch it early, log a message and fail the initiaization.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 10 ++
drivers/net/bnxt/bnxt_filter.c | 2 +-
drivers/net/bnxt/bnxt_filter.h | 1 +
3 files changed
Register for async events from the FW.
New events we are registering for include Link speed config changes,
PF driver unload and VF config change. Also log a message when the
async event arrives on the completion ring.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_cpr.c | 11 ++
Please consider applying this patchset.
Ajit Khaparde (4):
net/bnxt: fix size of tx ring in HW
net/bnxt: use driver specific dynamic log type
net/bnxt: register for more async events
net/bnxt: check if MAC address is all zeros
Somnath Kotur (1):
net/bnxt: Support for rx/tx_queue_start/s
During Tx ring allocation, the actual ring size configured in the HW
ends up being twice the number of txd parameter specified to the driver.
The power of 2 ring size wrongly adds a +1 while sending the ring
create command to the FW.
Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Signed-off
Hi hermant
On 1/22/2018 1:15 PM, Hemant Agrawal Wrote:
Hi Jia,
On 1/22/2018 7:23 AM, Jia He wrote:
This is BSD-2-freebsd, which is not a approved license for DPDK.
Can you ask Kip Macy, if he/she is ok to re-license it with BSD-3?
Please check with legal, if you can just keep the copyright o
Hi, Pavan
Please see my notes inline.
Best regards,
Herbert
> -Original Message-
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com]
> Sent: Saturday, January 20, 2018 2:24
> To: jerin.ja...@caviumnetworks.com; bruce.richard...@intel.com;
> harry.van.haa...@intel.com; Herber
HI, Thomas
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Friday, January 19, 2018 5:17 PM
> To: Zhao1, Wei
> Cc: Zhang, Helin ; dev@dpdk.org; Mcnamara, John
> ; Yigit, Ferruh ; Xing,
> Beilei
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region
Thank you for your help!
I have commit a v5 patch https://dpdk.org/dev/patchwork/patch/34211/
> -Original Message-
> From: Mcnamara, John
> Sent: Monday, January 22, 2018 5:22 AM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: RE: [PATCH v4] doc: add queue region feature
This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.
Signed-off-by: Wei Zhao
---
v2:
-change this information to v18.02 release notes.
v3:
-rework it on dpdk-next-net-intel su
This patch is to support C11 memory model barrier in librte_ring.
There are 2 barrier implementation options in librte_ring (suggested
by Jerin).
1. use rte_smp_rmb
2. use load_acquire/store_release(refer to [1]).
The reason why providing 2 options is the performance benchmark
difference in differ
Move the common part of rte_ring.h into rte_ring_generic.h.
Move the memory barrier part into update_tail().
No functional changes here.
Signed-off-by: Jia He
Suggested-by: Jerin Jacob
Suggested-by: Ananyev Konstantin
Acked-by: Jerin Jacob
Acked-by: Olivier Matz
---
lib/librte_eventdev/rte_
for the code as follows:
if (condition)
rte_smp_rmb();
else
rte_smp_wmb();
Without this patch, compiler will report this error:
error: 'else' without a previous 'if'
Fixes: 84733fd0d75e ("eal/arm64: fix memory barrier definition")
Signed-off-by: Jia He
Acked-by: Jerin Jacob
---
There are 2 model barrier options in librte_ring suggested by Jerin:
1. use rte_smp_rmb
2. use load_acquire/store_release
CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided for supporting C11 memory
model barrier in librte_ring. By default it is "y" on arm64, "n" on any
other architectures so far.
Alr
On Fri, Jan 19, 2018 at 04:55:53PM +0100, Olivier Matz wrote:
> When using vector Rx mode (use_simple_rx = 1), vq->vq_descx[] is not
> kept up to date. To properly detach the mbufs in this case, browse
> sw_ring[] instead, as it's done in virtqueue_rxvq_flush().
>
> Since we need virtio_get_queue_
Hi,
I've sent this patch again and it is accepted.
The other 3 pathes have no conflict with the latest master version and the
titles have described the modification of the patches.
So I need not send the patches for v3, right?
--origin--
From ： ;
to ：wang.yon...
On 1/21/2018 5:05 PM, Andrew Rybchenko wrote:
> From: Ivan Malov
>
> Fixes: a5279180f510 ("eal: change several log levels matching a regexp")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ivan Malov
> Signed-off-by: Andrew Rybchenko
Reviewed-by: Ferruh Yigit
22/01/2018 02:54, Neil Horman:
> On Sun, Jan 21, 2018 at 09:29:18PM +0100, Thomas Monjalon wrote:
> > > $verbose || printf '\n### %s\n\n' "$3"
> > > printf '%s\n' "$report" | sed -n '1,/^total:.*lines checked$/p'
> > > +
> > > + echo
> > > + echo "Checking API additions/removals:"
> >
> > You
A new DPDK release candidate is ready for testing:
http://dpdk.org/browse/dpdk/tag/?id=v18.02-rc1
Special attention was paid to not break the ABI in this release.
It means 18.02 could replace 17.11 without rebuilding the applications.
However it is advised to keep using 17.11 LTS for long
Ok, good idea, v5 will come later.
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Friday, January 19, 2018 5:17 PM
> To: Zhao1, Wei
> Cc: Zhang, Helin ; dev@dpdk.org; Mcnamara, John
> ; Yigit, Ferruh ; Xing,
> Beilei
> Subject: Re: [dpdk-dev] [PATCH v3]
On Sun, Jan 21, 2018 at 09:29:18PM +0100, Thomas Monjalon wrote:
> Hi,
>
> 16/01/2018 19:22, Neil Horman:
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > Developers and Maintainers Tools
> > M: Thomas Monjalon
> > +M: Neil Horman
> > F: MAINTAINERS
> > F: devtools/check-dup-includes.sh
> >
Hi Hermant
On 1/20/2018 12:47 AM, Hemant Agrawal Wrote:
Hi Olivier,
On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote:
Hi Jia,
On 1/17/2018 9:33 AM, Jia He wrote:
Move the common part of rte_ring.h into rte_ring_generic.h.
Move the memory barrier part into update_tail().
No f
The __rte_experimental macro tags a given exported function as being part of
the EXPERIMENTAL api. Use of this tag will cause any caller of the
function (that isn't removed by dead code elimination) to emit a warning
that the user is making use of an API whos stabilty isn't guaranteed.
It also pla
Add checks during build to ensure that all symbols in the EXPERIMENTAL
version map section have __experimental tags on their definitions, and
enable the warnings needed to announce their use. Also add an
ALLOW_EXPERIMENTAL_APIS define to allow individual libraries and files
to declare the acceptab
Append the __rte_experimental tag to api calls appearing in the EXPERIMENTAL
section of their libraries version map
Signed-off-by: Neil Horman
CC: Thomas Monjalon
CC: "Mcnamara, John"
CC: Bruce Richardson
---
lib/librte_eal/common/eal_common_dev.c | 6 ++-
lib/librte_eal/common/e
This tools reads the given version map for a directory, and checks to
ensure that, for each symbol listed in the export list, the corresponding
definition is tagged as __rte_experimental, erroring out if its not. In this
way, we can ensure that the EXPERIMENTAL api is kept in sync with the tags
S
Document the need to add the __experimental tag to appropriate functions
Signed-off-by: Neil Horman
CC: Thomas Monjalon
CC: "Mcnamara, John"
CC: Bruce Richardson
---
doc/guides/contributing/versioning.rst | 14 ++
1 file changed, 14 insertions(+)
diff --git a/doc/guides/contribut
Hey all-
A few days ago, I was lamenting the fact that, when reviewing patches I
would frequently complain about ABI changes that were actually considered safe
because they were part of the EXPERIMENTAL api set. John M. asked me then what
I might do to improve the situation, and the follow
22/01/2018 02:34, Neil Horman:
> On Sun, Jan 21, 2018 at 07:54:44PM +0100, Thomas Monjalon wrote:
> > 12/01/2018 13:44, Neil Horman:
> > > On Fri, Jan 12, 2018 at 11:49:57AM +, Ferruh Yigit wrote:
> > > > On 1/11/2018 8:50 PM, Neil Horman wrote:
> > > > > On Thu, Jan 11, 2018 at 08:06:43PM +000
On Sun, Jan 21, 2018 at 07:54:44PM +0100, Thomas Monjalon wrote:
> 12/01/2018 13:44, Neil Horman:
> > On Fri, Jan 12, 2018 at 11:49:57AM +, Ferruh Yigit wrote:
> > > On 1/11/2018 8:50 PM, Neil Horman wrote:
> > > > On Thu, Jan 11, 2018 at 08:06:43PM +, Ferruh Yigit wrote:
> > > >> On 12/13/
On Sun, Jan 21, 2018 at 07:50:08PM +0100, Thomas Monjalon wrote:
> 13/12/2017 16:17, Neil Horman:
> > --- a/lib/librte_eal/linuxapp/eal/Makefile
> > +++ b/lib/librte_eal/linuxapp/eal/Makefile
> > +CFLAGS += -DALLOW_EXPERIMENTAL_APIS
>
I think I addressed this in an earlier thread, but I'm opposed
20/01/2018 17:50, Ferruh Yigit:
> No config option changed, added or removed.
> Only reshuffle PMD config options mostly to help new PMDs where to put
> their new config option.
>
> Ordered as physical, paravirtual and virtual groups. Alphabetical order
> within a group.
>
> Also tried to group v
22/01/2018 01:16, Ferruh Yigit:
> Create a rte_ethdev_driver.h file and move PMD specific APIs here.
> Drivers updated to include this new header file.
>
> There is no update in header content and since ethdev.h included by
> ethdev_driver.h, nothing changed from driver point of view, only
> logic
rte_ethdev_core.h created. Internal data structures are moved here.
These structures are mostly intended to be used by drivers, but they
need to be in the public header file because of the inline functions
in the ethdev.h header, and those inline functions are preferred to
kept because of the perf
Update "port" function argument variable to "port_id" in public
header to be consistent in all APIs.
No functional change.
Signed-off-by: Ferruh Yigit
Acked-by: Thomas Monjalon
---
lib/librte_ether/rte_ethdev.h | 38 +++---
1 file changed, 19 insertions(+), 19 d
Move all inline function to the end of the ethdev.h header file and move
the ethdev_core.h just before inline functions.
Since inline functions need data structures in ethdev_core.h, this
reorder is to group them and make it clear where put further inline
functions.
Signed-off-by: Ferruh Yigit
A
Create a rte_ethdev_driver.h file and move PMD specific APIs here.
Drivers updated to include this new header file.
There is no update in header content and since ethdev.h included by
ethdev_driver.h, nothing changed from driver point of view, only
logically grouping of APIs. From applications poi
21/01/2018 20:25, Ferruh Yigit:
> On 1/21/2018 6:59 PM, Ferruh Yigit wrote:
> > From: Stephen Hemminger
> >
> > To handle atomic update of link status (64 bit), every driver
> > was doing its own version using cmpset.
> > Atomic exchange is a useful primitive in its own right;
> > therefore make
Update "port" function argument variable to "port_id" in public
header to be consistent in all APIs.
No functional change.
Signed-off-by: Ferruh Yigit
Acked-by: Thomas Monjalon
---
lib/librte_ether/rte_ethdev.h | 38 +++---
1 file changed, 19 insertions(+), 19 d
rte_ethdev_core.h created. Internal data structures are moved here.
These structures are mostly intended to be used by drivers, but they
need to be in the public header file because of the inline functions
in the ethdev.h header, and those inline functions are preferred to
kept because of the perf
Move all inline function to the end of the ethdev.h header file and move
the ethdev_core.h just before inline functions.
Since inline functions need data structures in ethdev_core.h, this
reorder is to group them and make it clear where put further inline
functions.
Signed-off-by: Ferruh Yigit
A
Create a rte_ethdev_driver.h file and move PMD specific APIs here.
Drivers updated to include this new header file.
There is no update in header content and since ethdev.h included by
ethdev_driver.h, nothing changed from driver point of view, only
logically grouping of APIs. From applications poi
20/01/2018 17:57, Ferruh Yigit:
> Create a rte_ethdev_driver.h file and move PMD specific APIs here.
> Drivers updated to include this new header file.
>
> There is no update in header content and since ethdev.h included by
> ethdev_driver.h, nothing changed from driver point of view, only
> logic
21/01/2018 23:40, Ferruh Yigit:
> On 1/21/2018 10:32 PM, Thomas Monjalon wrote:
> > Forgot the Fixes: tags,
> >
> > 21/01/2018 23:21, Thomas Monjalon:
> >> Some errors were seen with GCC 4.8 and 4.9.
> >> It looks to be a bug fixed in GCC 5.
> >>
> >> examples/eventdev_pipeline/pipeline_worker_gen
On 1/21/2018 10:32 PM, Thomas Monjalon wrote:
> Forgot the Fixes: tags,
>
> 21/01/2018 23:21, Thomas Monjalon:
>> Some errors were seen with GCC 4.8 and 4.9.
>> It looks to be a bug fixed in GCC 5.
>>
>> examples/eventdev_pipeline/pipeline_worker_generic.c:474:4: error:
>> missing initializer for
Forgot the Fixes: tags,
21/01/2018 23:21, Thomas Monjalon:
> Some errors were seen with GCC 4.8 and 4.9.
> It looks to be a bug fixed in GCC 5.
>
> examples/eventdev_pipeline/pipeline_worker_generic.c:474:4: error:
> missing initializer for field 'queue_id' of 'struct '
>
> examples/eventdev_pip
Some errors were seen with GCC 4.8 and 4.9.
It looks to be a bug fixed in GCC 5.
examples/eventdev_pipeline/pipeline_worker_generic.c:474:4: error:
missing initializer for field 'queue_id' of 'struct '
examples/eventdev_pipeline/pipeline_worker_generic.c:475:3: error:
missing initializer for fiel
On 1/19/2018 6:10 PM, Thomas Monjalon wrote:
> 19/01/2018 18:37, Neil Horman:
>> On Fri, Jan 19, 2018 at 06:09:47PM +0100, Thomas Monjalon wrote:
>>> 19/01/2018 15:32, Neil Horman:
On Fri, Jan 19, 2018 at 03:07:28PM +0100, Thomas Monjalon wrote:
> 19/01/2018 14:57, Neil Horman:
I
On 1/18/2018 6:12 AM, Hemant Agrawal wrote:
> This patch adds following:
> 1. Option to configure the mac address during create. Generate random
>address only if the user has not provided any valid address.
> 2. Inform usespace, if mac address is being changed in linux.
> 3. Implement default h
On Sun, Jan 21, 2018 at 07:31:31PM +0100, Thomas Monjalon wrote:
> Hi Neil,
>
> Sorry for the very late review.
> I thought review had been done by others but it seems not.
> Please find my comments below.
>
> 13/12/2017 16:17, Neil Horman:
> > create mode 100755 buildtools/experimentalsyms.sh
>
> -Original Message-
> From: Zhao1, Wei
> Sent: Friday, January 19, 2018 3:28 AM
> To: dev@dpdk.org
> Cc: Mcnamara, John ; sta...@dpdk.org; Zhao1, Wei
>
> Subject: [PATCH v4] doc: add queue region feature info to release notes
>
> This patch add inforation about i40e queue region realte
On 1/20/2018 9:24 PM, Matan Azrad wrote:
> The ownership of a port is implicit in DPDK.
> Making it explicit is better from the next reasons:
> 1. It will define well who is in charge of the port usage synchronization.
> 2. A library could work on top of a port.
> 3. A port can work on top of anoth
On 1/20/2018 9:24 PM, Matan Azrad wrote:
> The ownership of a port is implicit in DPDK.
> Making it explicit is better from the next reasons:
> 1. It will define well who is in charge of the port usage synchronization.
> 2. A library could work on top of a port.
> 3. A port can work on top of anoth
Hi,
16/01/2018 19:22, Neil Horman:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> Developers and Maintainers Tools
> M: Thomas Monjalon
> +M: Neil Horman
> F: MAINTAINERS
> F: devtools/check-dup-includes.sh
> F: devtools/check-maintainers.sh
> @@ -52,6 +53,7 @@ F: devtools/get-maintainer.sh
> F
On 1/20/2018 9:12 PM, Matan Azrad wrote:
> There is time between the physical removal of the device until sub-device
> PMDs get a RMV interrupt.
> At this time DPDK PMDs and applications still don't know about the removal
> and may call sub-device control operation which should return an error.
13/12/2017 16:17, Neil Horman:
> --- a/doc/guides/contributing/versioning.rst
> +++ b/doc/guides/contributing/versioning.rst
> +Note that marking an API as experimental is a two step process. To mark an
> API
> +as experimental, the symbols which are desired to be exported must be placed
> in
>
On 1/19/2018 4:19 PM, Ferruh Yigit wrote:
> On 1/18/2018 6:10 PM, Matan Azrad wrote:
>> Hi Ferruh
>>
>> From: Ferruh Yigit, Thursday, January 18, 2018 7:31 PM
>>> On 1/18/2018 11:27 AM, Matan Azrad wrote:
rte_eth_dev_is_removed API was added to detect a device removal
synchronously.
On 1/21/2018 6:59 PM, Ferruh Yigit wrote:
> From: Stephen Hemminger
>
> To handle atomic update of link status (64 bit), every driver
> was doing its own version using cmpset.
> Atomic exchange is a useful primitive in its own right;
> therefore make it a EAL routine.
>
> Signed-off-by: Stephen
From: Stephen Hemminger
This driver was not doing atomic update of link status information.
And the return value was different than others.
The hardware also does not do autonegotiation (at least on Linux).
Signed-off-by: Stephen Hemminger
Reviewed-by: Ferruh Yigit
---
drivers/net/enic/enic_e
From: Stephen Hemminger
Use new helper function.
Signed-off-by: Stephen Hemminger
Reviewed-by: Ferruh Yigit
---
drivers/net/thunderx/nicvf_ethdev.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_ethdev.c
b/drivers/net/thund
From: Stephen Hemminger
Common function matches this drivers usage.
Signed-off-by: Stephen Hemminger
Reviewed-by: Ferruh Yigit
---
drivers/net/octeontx/octeontx_ethdev.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev
From: Stephen Hemminger
Yet another driver which was not returing correct value on
link change.
Since this driver can't be built on x86 could not even
do a compile test.
Signed-off-by: Stephen Hemminger
Reviewed-by: Ferruh Yigit
---
drivers/net/szedata2/rte_eth_szedata2.c | 19 ++
From: Stephen Hemminger
Use new rte_eth_linkstatus_get/set helper function.
Signed-off-by: Stephen Hemminger
Signed-off-by: Ferruh Yigit
---
v6:
* Keep logic exact same, only use new APIs to get/set link
---
drivers/net/nfp/nfp_net.c | 70 +--
1 fil
From: Stephen Hemminger
Use the new helper functions from eth_dev for
handling atomic link_info update.
Signed-off-by: Stephen Hemminger
Signed-off-by: Ferruh Yigit
---
v6:
* Keep logic exact same, only use new APIs to get/set link
---
drivers/net/ixgbe/ixgbe_ethdev.c | 87 ---
From: Stephen Hemminger
Use the new link update API, and cleanup the logic in the the
link update routine.
Signed-off-by: Stephen Hemminger
Tested-by: Shijith Thotton
Reviewed-by: Ferruh Yigit
---
drivers/net/liquidio/lio_ethdev.c | 56 +++
1 file changed,
From: Stephen Hemminger
Use new helper function to update the link status.
Signed-off-by: Stephen Hemminger
Signed-off-by: Ferruh Yigit
---
v6:
* Use correct APIs
* Keep logic exact same, only use new APIs to get/set link
---
drivers/net/dpaa2/dpaa2_ethdev.c | 77 +++--
From: Stephen Hemminger
Use new rte_eth_linkstatus_get/set API.
Signed-off-by: Stephen Hemminger
Signed-off-by: Ferruh Yigit
---
v6:
* Keep logic exact same, only use new APIs to get/set link
---
drivers/net/e1000/em_ethdev.c | 63 -
drivers/net/e1000/
From: Stephen Hemminger
Use new rte_linkstatus update API
Signed-off-by: Stephen Hemminger
Signed-off-by: Ferruh Yigit
---
v6:
* Keep logic exact same, only use new APIs to get/set link
---
drivers/net/i40e/i40e_ethdev.c| 39 +--
drivers/net/i40e/i40e_e
From: Stephen Hemminger
Use new rte_eth_link_update helper.
Also remove no longer necessary include of rte_atomic.h
Signed-off-by: Stephen Hemminger
Signed-off-by: Ferruh Yigit
---
v6:
* Keep logic exact same, only use new APIs to get/set link
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 80 +++
From: Stephen Hemminger
Many drivers are all doing copy/paste of the same code to atomically
update the link status. Reduce duplication, and allow for future
changes by having common function for this.
Signed-off-by: Stephen Hemminger
Reviewed-by: Ferruh Yigit
---
lib/librte_ether/rte_ethdev.
From: Stephen Hemminger
Use the new comon code in ethdev to handle link status update.
Signed-off-by: Stephen Hemminger
Signed-off-by: Ferruh Yigit
---
v6:
* Keep logic exact same, only use new APIs to get/set link
---
drivers/net/virtio/virtio_ethdev.c | 53 +
From: Stephen Hemminger
To handle atomic update of link status (64 bit), every driver
was doing its own version using cmpset.
Atomic exchange is a useful primitive in its own right;
therefore make it a EAL routine.
Signed-off-by: Stephen Hemminger
Reviewed-by: Ferruh Yigit
---
v6:
*fix build e
12/01/2018 13:44, Neil Horman:
> On Fri, Jan 12, 2018 at 11:49:57AM +, Ferruh Yigit wrote:
> > On 1/11/2018 8:50 PM, Neil Horman wrote:
> > > On Thu, Jan 11, 2018 at 08:06:43PM +, Ferruh Yigit wrote:
> > >> On 12/13/2017 3:17 PM, Neil Horman wrote:
> > >>> --- a/app/test-eventdev/Makefile
>
13/12/2017 16:17, Neil Horman:
> --- a/lib/librte_eal/linuxapp/eal/Makefile
> +++ b/lib/librte_eal/linuxapp/eal/Makefile
> +CFLAGS += -DALLOW_EXPERIMENTAL_APIS
We can define this flag for the whole DPDK libraries,
in mk/rte.vars.mk
inside the block ifneq ($(BUILDING_RTE_SDK),)
> -
Hi,
I know I should have spotted these comments earlier,
I'm sorry to be late on this review.
13/12/2017 16:17, Neil Horman:
> +#ifndef ALLOW_EXPERIMENTAL_APIS
>
> +#define __experimental \
These macros should be in the DPDK namespace:
RTE_ALLOW_EXPERIMENTAL_API (no need of S)
On 1/19/2018 4:35 PM, Ferruh Yigit wrote:
> On 1/17/2018 4:18 PM, Ferruh Yigit wrote:
>> On 1/17/2018 4:05 PM, Stephen Hemminger wrote:
>>> On Wed, 17 Jan 2018 14:32:17 +
>>> Ferruh Yigit wrote:
>>>
On 1/17/2018 7:56 AM, Andrew Rybchenko wrote:
> On 01/16/2018 09:37 PM, Stephen Hemmin
Hi Neil,
Sorry for the very late review.
I thought review had been done by others but it seems not.
Please find my comments below.
13/12/2017 16:17, Neil Horman:
> create mode 100755 buildtools/experimentalsyms.sh
When adding a new file, you must reference it in MAINTAINERS.
Please add it in th
21/01/2018 18:34, Stephen Hemminger:
> On Sat, 20 Jan 2018 09:44:46 +0100
> Thomas Monjalon wrote:
>
> > 20/01/2018 06:18, Patil, Harish:
> > > Hi,
> > >
> > > I am seeing below compilation errors in drivers/event/opdl/, this is with
> > > cloned latest DPDK (git clone http://dpdk.org/git/dpdk).
On Sat, 20 Jan 2018 09:44:46 +0100
Thomas Monjalon wrote:
> 20/01/2018 06:18, Patil, Harish:
> > Hi,
> >
> > I am seeing below compilation errors in drivers/event/opdl/, this is with
> > cloned latest DPDK (git clone http://dpdk.org/git/dpdk).
> >
> > ..
> > ..
> > /home2/hpatil/e4/jan19-inbox-
From: Ivan Malov
Fixes: a5279180f510 ("eal: change several log levels matching a regexp")
Cc: sta...@dpdk.org
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
---
lib/librte_eal/common/eal_common_log.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/eal_co
On 1/20/2018 9:11 PM, Ophir Munk wrote:
> The patches of TAP RSS eBPF follow the RFC on this issue
> https://dpdk.org/dev/patchwork/patch/31781/
>
> v6 changes with respect to v5
> =
> 1. Reorder thes following commits (source file commit before byte code commit)
> ne
On 1/20/2018 9:25 PM, Ophir Munk wrote:
> Hi Ferruh,
> Thanks for applying v5 patches while changing the order of commits and adding
> "Acked-by: ..."
>
> I have sent v6 which does the same but also updates the commit messages of
> the switched commits to reflect more accurately the new order.
21/01/2018 10:48, Andrew Rybchenko:
> RHEL 7.4 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
>
> ‘for’ loop initial declarations are only allowed in C99 mode
>
> Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library")
>
> Signed-off-by: Andrew Rybchenko
> ---
> Other option is to
RHEL 7.4 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
‘for’ loop initial declarations are only allowed in C99 mode
Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library")
Signed-off-by: Andrew Rybchenko
---
Other option is to move declarations outside of for loop.
I just want it
18/01/2018 08:10, Jerin Jacob:
> http://dpdk.org/git/next/dpdk-next-eventdev
Pulled, thanks
20/01/2018 16:15, Pablo de Lara:
> http://dpdk.org/git/next/dpdk-next-crypto
Pulled, thanks
97 matches
Mail list logo
