On Fri, Jan 12, 2018 at 01:07:34PM +0000, Singh, Jasvinder wrote: > > > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Thursday, January 11, 2018 6:34 PM > > To: Tomasz Duszynski <t...@semihalf.com>; dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Wu, Jingjing > > <jingjing...@intel.com>; Singh, Jasvinder <jasvinder.si...@intel.com> > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > > table > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > > > Sent: Thursday, January 11, 2018 1:49 PM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Wu, Jingjing > > > <jingjing...@intel.com>; Tomasz Duszynski <t...@semihalf.com> > > > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > > > table > > > > > > Since METER action is supported by the testpmd application suitable > > > entry should exist in flow actions information table. > > > > > > Without that testpmd will return error on adding a new flow to the > > > list of flows attached to a given port. > > > > > > Signed-off-by: Tomasz Duszynski <t...@semihalf.com> > > > --- > > > app/test-pmd/config.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > > 0a84481..4ad19fb 100644 > > > --- a/app/test-pmd/config.c > > > +++ b/app/test-pmd/config.c > > > @@ -1038,6 +1038,7 @@ static const struct { > > > MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* > > > +queue[] */ > > > MK_FLOW_ACTION(PF, 0), > > > MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)), > > > + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)), > > > }; > > > > > > /** Compute storage space needed by action configuration. */ > > > -- > > > 2.7.4 > > > > Adding Jasvinder to this thread. > > The above change looks fine to me. > > Acked-by: Jasvinder Singh <jasvinder.si...@intel.com>
Since I cannot see any objections can you pick up this one? -- - Tomasz Duszyński
