On 01/16/2018 04:10 AM, Yongseok Koh wrote:
This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to
guarantee the ordering of coherent shared memory between the CPU and a DMA
capable device.
Signed-off-by: Yongseok Koh
---
lib/librte_eal/common/include/generic/rte_atomic.h | 18 ++
Hi
> > > > @@ -227,6 +227,7 @@ vhost_user_set_vring_num(struct virtio_net
> *dev,
> > > > "zero copy is force disabled\n");
> > > > dev->dequeue_zero_copy = 0;
> > > > }
> > > > + TAILQ_INIT(&vq->zmbuf_list);
> >
Hi Abhinandan,
On 1/16/2018 12:35 PM, Gujjar, Abhinandan S wrote:
Hi Akhil,
-Original Message-
From: Akhil Goyal [mailto:akhil.go...@nxp.com]
Sent: Tuesday, January 16, 2018 11:55 AM
To: Gujjar, Abhinandan S ; Doherty, Declan
Cc: dev@dpdk.org; Vangati, Narender ; Rao,
Nikhil
Subject:
Hi Akhil,
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Tuesday, January 16, 2018 11:55 AM
> To: Gujjar, Abhinandan S ; Doherty, Declan
>
> Cc: dev@dpdk.org; Vangati, Narender ; Rao,
> Nikhil
> Subject: Re: [PATCH 1/2] lib/cryptodev: add support to set ses
Hi Radu,
On 1/15/2018 8:10 PM, Nicolau, Radu wrote:
-Original Message-
From: Akhil Goyal [mailto:akhil.go...@nxp.com]
Sent: Monday, January 15, 2018 12:48 PM
To: dev@dpdk.org
Cc: De Lara Guarch, Pablo ;
hemant.agra...@nxp.com; Nicolau, Radu
Subject: Re: [PATCH] examples/ipsec-secgw: u
Hi Abhinandan,
On 1/16/2018 11:39 AM, Gujjar, Abhinandan S wrote:
diff --git a/lib/librte_cryptodev/rte_crypto.h
b/lib/librte_cryptodev/rte_crypto.h
index bbc510d..3a98cbf 100644
--- a/lib/librte_cryptodev/rte_crypto.h
+++ b/lib/librte_cryptodev/rte_crypto.h
@@ -62,6 +62,18 @@ enum rte_crypto_op_
Hi Akhil,
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Monday, January 15, 2018 5:49 PM
> To: Gujjar, Abhinandan S ; Doherty, Declan
>
> Cc: dev@dpdk.org; Vangati, Narender ; Rao,
> Nikhil
> Subject: Re: [PATCH 1/2] lib/cryptodev: add support to set sessi
Hi Pavan,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh
> Sent: Thursday, December 14, 2017 3:56 AM
> To: jerin.ja...@caviumnetworks.com; Wu, Jingjing ;
> Richardson, Bruce ; hemant.agra...@nxp.com;
> Yigit, Ferruh ; tho...@monjalon.net;
> oliv
Hi Matan,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad
> Sent: Sunday, January 7, 2018 5:46 PM
> To: Thomas Monjalon ; Gaetan Rivet
> ; Wu, Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson,
> Bruce ; Ananyev, Konstantin
>
> Subject: [dpdk-
The 01/15/2018 17:10, Yongseok Koh wrote:
> Polling a new packet is basically sensing the generation bit in a
> completion entry. For some processors not having strongly-ordered memory
> model, there has to be an IO memory barrier between reading the generation
> bit and other fields of the entry i
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li
> Sent: Tuesday, January 9, 2018 10:11 PM
> To: Olivier MATZ ; Thomas Monjalon
> ; Wu, Jingjing ; Yongseok
> Koh
> Cc: Xueming Li ; Shahaf Shuler
> ; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 6/6]
Hi,
> -Original Message-
> From: wei.guo.si...@gmail.com [mailto:wei.guo.si...@gmail.com]
> Sent: Saturday, January 13, 2018 10:35 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Thomas Monjalon ; Simon Guo
>
> Subject: [PATCH v5] app/testpmd: add option ring-bind-lcpu to bind Q with
> CPU
>
>
The 01/15/2018 17:10, Yongseok Koh wrote:
> Cc: Thomas Speier
>
> Signed-off-by: Yongseok Koh
> Acked-by: Thomas Speier
Acked-by: Jianbo Liu
> ---
> lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_eal/common/inclu
The 01/15/2018 17:10, Yongseok Koh wrote:
> Signed-off-by: Yongseok Koh
> ---
> lib/librte_eal/common/include/arch/arm/rte_atomic_32.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
> b/lib/librte_eal/common/include/arch/arm/rt
The 01/15/2018 17:10, Yongseok Koh wrote:
> This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to
> guarantee the ordering of coherent shared memory between the CPU and a DMA
> capable device.
>
> Signed-off-by: Yongseok Koh
Acked-by: Jianbo Liu
> ---
> lib/librte_eal/common/incl
Hi Yongseok,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh
> Sent: Saturday, December 16, 2017 5:11 AM
> To: Wu, Jingjing
> Cc: dev@dpdk.org; Yongseok Koh
> Subject: [dpdk-dev] [PATCH] app/testpmd: make txonly mode generate
> multiple flows
>
>
Hi Wenzuo,
On Mon, Jan 15, 2018 at 08:31:52AM +, Lu, Wenzhuo wrote:
> Hi Simon,
>
>
> > -Original Message-
> > From: wei.guo.si...@gmail.com [mailto:wei.guo.si...@gmail.com]
> > Sent: Wednesday, January 10, 2018 4:00 PM
> > To: Lu, Wenzhuo
> > Cc: dev@dpdk.org; Simon Guo
> > Subject
Thomas,
On Mon, Jan 15, 2018 at 12:30:31AM +0100, Thomas Monjalon wrote:
> 10/01/2018 08:59, wei.guo.si...@gmail.com:
> > This patch adds a new option "--ring-bind-lcpu"(no parameter). With
> > this, testpmd can utilize the PCI-e bus bandwidth on another NUMA
> > nodes.
>
> Waiting for a review.
From: Simon Guo
Currently the rx/tx queue is allocated from the buffer pool on socket of:
- port's socket if --port-numa-config specified
- or ring-numa-config setting per port
All the above will "bind" queue to single socket per port configuration.
But it can actually archieve better performanc
On 1/13/2018 1:09 AM, Thomas Monjalon Wrote:
04/12/2017 02:50, Jia He:
move the common part of rte_ring.h into rte_ring_generic.h.
move the memory barrier part into update_tail().
no functional changes here.
[...]
--- /dev/null
+++ b/lib/librte_ring/rte_ring_generic.h
@@ -0,0 +1,195 @@
+/*-
On Mon, Jan 15, 2018 at 04:15:00PM +0100, Maxime Coquelin wrote:
> Hi Michael,
>
> FYI:
>
> Forwarded Message
> Subject: [dpdk-dev] [PATCH v3 2/2] eal/x86: Use lock-prefixed instructions
> to reduce cost of rte_smp_mb()
> Date: Mon, 15 Jan 2018 15:09:31 +
> From: Konstantin
Signed-off-by: Yongseok Koh
---
drivers/net/mlx5/mlx5_rxtx.c | 4 ++--
drivers/net/mlx5/mlx5_rxtx.h | 2 +-
drivers/net/mlx5/mlx5_rxtx_vec.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 3b8f71c28..
Polling a new packet is basically sensing the generation bit in a
completion entry. For some processors not having strongly-ordered memory
model, there has to be an IO memory barrier between reading the generation
bit and other fields of the entry in order to guarantee data is not stale.
Fixes: 57
As rte_write64() has an IO barrier, there's no need to have a barrier
before the call.
Signed-off-by: Yongseok Koh
---
drivers/net/mlx5/mlx5_rxq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 950472754..11438c86a 100644
--- a/
Cc: Thomas Speier
Signed-off-by: Yongseok Koh
Acked-by: Thomas Speier
---
lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
b/lib/librte_eal/common/include/arch/arm/rte_atomic_6
Signed-off-by: Yongseok Koh
---
lib/librte_eal/common/include/arch/arm/rte_atomic_32.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
b/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
index 14c048640..a45d5aa2a 100644
--- a/l
This patchset is to introduce DMA memory barriers, which could be more
efficient for coherent memory between I/O device and CPU, especially for
ARMv8.
Yongseok Koh (8):
eal: introduce DMA memory barriers
eal/x86: define DMA memory barriers
eal/ppc64: define DMA device memory barriers
eal/a
Signed-off-by: Yongseok Koh
---
lib/librte_eal/common/include/arch/x86/rte_atomic.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic.h
b/lib/librte_eal/common/include/arch/x86/rte_atomic.h
index 8469f97e1..4def21d24 100644
--- a/lib/librte
Signed-off-by: Yongseok Koh
---
lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
index 150810cdb..46490f2b3 100644
--- a/l
This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to
guarantee the ordering of coherent shared memory between the CPU and a DMA
capable device.
Signed-off-by: Yongseok Koh
---
lib/librte_eal/common/include/generic/rte_atomic.h | 18 ++
1 file changed, 18 insertions
> -Original Message-
> From: Chen, Junjie J
> Sent: Monday, January 15, 2018 5:15 PM
> To: Yang, Zhiyong ; y...@fridaylinux.org;
> maxime.coque...@redhat.com
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq
>
> Hi
>
> > > @@ -227,6 +227,7 @@ v
15/01/2018 15:29, Ferruh Yigit:
> On 1/15/2018 7:55 AM, Zhiyong Yang wrote:
> > void * pointer can be assigned to any data type pointer. Unnecessary cast
> > can be removed in order to keep code clearer.
> >
> > Zhiyong Yang (5):
> > lib/librte_lpm: remove unnecessary void * pointer cast
> > l
13/01/2018 06:06, Pavan Nikhilesh:
> On Fri, Jan 12, 2018 at 03:31:05PM -0600, Erik Gabriel Carrillo wrote:
> > The return value of rte_lcore_has_role is misinterpreted in the timer
> > reset function. The return values of rte_lcore_has_role will be changed
> > in a future DPDK release, but this c
> On Jan 7, 2018, at 5:55 PM, Jianbo Liu wrote:
>
> The 12/26/2017 20:28, Yongseok Koh wrote:
>> Instead of using system-wide 'dsb' instruction for IO barriers, 'dmb' is
>> sufficient and could bring better performance. Using 'dmb' with Outer
>> Shareable Domain option is also consistent with li
Bruce, Vladimir,
There was no progress since August.
Is there a plan to benefit from Vladimir's work?
15/08/2017 13:01, Vladimir Medvedkin:
> Moreover rte_rib_v4_node could contain app specific extension (.ext field).
> For example you can implement PIC (prefix independent convergence) by
> linkin
On Mon, Jan 15, 2018 at 10:52:25PM +0100, Thomas Monjalon wrote:
> 15/01/2018 20:05, Neil Horman:
> > Recently, some additional patches were added to allow for programmatic
> > marking of C symbols as experimental. The addition of these markers is
> > dependent on the manual addition of exported s
On Mon, Jan 15, 2018 at 02:20:38PM -0800, Stephen Hemminger wrote:
> On Mon, 15 Jan 2018 14:05:45 -0500
> Neil Horman wrote:
>
> >
> > +build_map_changes()
> > +{
> > + local fname=$1
> > + local mapdb=$2
> > +
> > + cat $fname | filterdiff -i *.map | awk '
>
> You don't need cat, use sh
16/01/2018 00:59, Thomas Monjalon:
> The macros dsb and dmb are defined as an instruction block with braces.
> As a consequence, when it is used in if/else without brace:
> if (cond)
> rte_mb();
> else
> statement;
> the added semicolon is parsed outside of i
15/01/2018 16:04, Konstantin Ananyev:
> Simple functional test for rte_smp_mb() implementations.
> Also when executed on a single lcore could be used as rough
> estimation how many cycles particular implementation of rte_smp_mb()
> might take.
>
> Signed-off-by: Konstantin Ananyev
> ---
> test/t
>
> We need the synchronous way for multi-process communication,
> i.e., blockingly waiting for reply message when we send a request
> to the peer process.
>
> We add two APIs rte_eal_mp_request() and rte_eal_mp_reply() for
> such use case. By invoking rte_eal_mp_request(), a request message
>
The macros dsb and dmb are defined as an instruction block with braces.
As a consequence, when it is used in if/else without brace:
if (cond)
rte_mb();
else
statement;
the added semicolon is parsed outside of if/else,
so the "else" cannot match the "i
> -Original Message-
> From: Xing, Beilei
> Sent: Monday, January 15, 2018 9:51 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH v3] net/i40e: fix packet type parser issue
>
> Ptype mapping table will fail to update when loading PPP profile, fix the
> issue
>
Even though link of a port gets down, device still can receive traffic.
That is the reason why mlx5_set_link_up/down() switches rx/tx_pkt_burst().
However, if link gets down by an external command (e.g. ifconfig), it isn't
effective. It is better to change burst functions when link status change
is
On Mon, 15 Jan 2018 14:05:45 -0500
Neil Horman wrote:
>
> +build_map_changes()
> +{
> + local fname=$1
> + local mapdb=$2
> +
> + cat $fname | filterdiff -i *.map | awk '
You don't need cat, use shell redirection same for later while loop.
> + BEGIN {map="";sym="";ar="
15/01/2018 20:05, Neil Horman:
> Recently, some additional patches were added to allow for programmatic
> marking of C symbols as experimental. The addition of these markers is
> dependent on the manual addition of exported symbols to the EXPERIMENTAL
> section of the corresponding libraries versi
> -Original Message-
> From: Tan, Jianfeng
> Sent: Thursday, January 11, 2018 4:08 AM
> To: dev@dpdk.org
> Cc: Burakov, Anatoly ; Richardson, Bruce
> ; Ananyev, Konstantin
> ; tho...@monjalon.net; Tan, Jianfeng
>
> Subject: [PATCH v2 2/4] eal: add and del secondary processes in the pri
15/01/2018 18:33, Kirill Rybalchenko:
> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -662,9 +662,9 @@ enum rte_fdir_mode {
> RTE_FDIR_MODE_PERFECT_TUNNEL, /**< Enable FDIR filter mode -
> tunnel. */
> };
>
> -#define UINT32_BIT (CHAR_BIT * sizeof(
Hi Jianfeng,
>
> Previouly, there are three channels for multi-process
> (i.e., primary/secondary) communication.
> 1. Config-file based channel, in which, the primary process writes
> info into a pre-defined config file, and the secondary process
> reads the info out.
> 2. vfio sub
Recently, some additional patches were added to allow for programmatic
marking of C symbols as experimental. The addition of these markers is
dependent on the manual addition of exported symbols to the EXPERIMENTAL
section of the corresponding libraries version map file. The consensus
on review i
Hi Matan,
>
> Hi Konstantin
>
> From: Ananyev, Konstantin, Monday, January 15, 2018 1:45 PM
> > Hi Matan,
> >
> > >
> > >
> > > Hi Konstantin
> > >
> > > From: Ananyev, Konstantin, Friday, January 12, 2018 2:02 AM
> > > > Hi Matan,
> > > >
> > > > >
> > > > > Hi Konstantin
> > > > >
> > > > > Fr
On 01/15/2018 08:00 PM, Thomas Monjalon wrote:
15/01/2018 12:33, Avi Kivity:
The 'register' keyword does nothing, and has been removed in C++17.
Remove it for compatibility, like commit 0d5f2ed12f9eb.
Fixes: 0d5f2ed12f9e ("eal: remove use of register keyword")
Signed-off-by: Avi Kivity
A
15/01/2018 12:33, Avi Kivity:
> The 'register' keyword does nothing, and has been removed in C++17.
>
> Remove it for compatibility, like commit 0d5f2ed12f9eb.
Fixes: 0d5f2ed12f9e ("eal: remove use of register keyword")
> Signed-off-by: Avi Kivity
Applied, thanks.
Note that "register" is used
On 1/15/2018 2:49 PM, Maciej Czekaj wrote:
>
>
>
>
> -- Oryginal message --
>> On 1/3/2018 1:12 PM, maciej.cze...@caviumnetworks.com wrote:
>>> From: Maciej Czekaj
>>>
>>> This patch removes all references to old-style offload API
>>> replacing them with new offload flags.
>>>
>>> Signed-off-b
13/12/2017 15:21, Hunt, David:
> On 12/12/2017 10:08 AM, Nikhil Agarwal wrote:
> > This existing code cause the platform to start receiving packet
> > immediately irrespective of interrupts available or not.
> > If the platform does not support Rx interrupt, it shall not start
> > receiving packets
Increase the internal limit for flow types from 32 to 64
to support future flow type extensions.
Change type of variables from uint32_t[] to uint64_t[]:
rte_eth_fdir_info.flow_types_mask
rte_eth_hash_global_conf.sym_hash_enable_mask
rte_eth_hash_global_conf.valid_bit_mask
This modification affects
-Original Message-
> Date: Wed, 10 Jan 2018 23:53:53 +0530
> From: Jerin Jacob
> To: Hemant Agrawal
> CC: Sunil Kumar Kori , "dev@dpdk.org"
> Subject: Re: [dpdk-dev] [PATCH v2 12/12] doc: add DPAA eventdev guide
> User-Agent: Mutt/1.9.2 (2017-12-15)
>
> -Original Message-
> > Da
> > > > > diff --git a/lib/librte_sched/rte_red.c
> > > > > b/lib/librte_sched/rte_red.c
> > > > > +int
> > > > > +rte_red_set_scaling(uint16_t max_red_queue_length) {
> > > > > + int8_t count;
> > > > > +
> > > > > + if (rte_red_init_done)
> > > > > + /**
> > > > > +
On Mon, Jan 15, 2018 at 05:18:37PM +0100, Adrien Mazarguil wrote:
> On Sat, Jan 13, 2018 at 08:14:06PM +0100, Thomas Monjalon wrote:
> > Hi,
> >
> > There is a new compilation error since this commit in LPM:
> > http://dpdk.org/commit/b2e1c99
> > The brace has been removed because unnecessary
Increase the internal limit for flow types from 32 to 64
to support future flow type extensions.
Change type of variables from uint32_t[] to uint64_t[]:
rte_eth_fdir_info.flow_types_mask
rte_eth_hash_global_conf.sym_hash_enable_mask
rte_eth_hash_global_conf.valid_bit_mask
This modification affects
On Mon, 15 Jan 2018 16:16:09 +
alangordonde...@gmail.com wrote:
Looks like a good idea, minor editing feedback.
> - red_cfg->min_th = ((uint32_t) min_th) << (wq_log2 + RTE_RED_SCALING);
> - red_cfg->max_th = ((uint32_t) max_th) << (wq_log2 + RTE_RED_SCALING);
> - red_cfg->pa_cons
Hi Jerin,
>
> Hi Konstantin,
>
> > > > > > > > 2. Make it safe to remove rx/tx callback at runtime.
> > > > > > > > Right now it is not possible for the application to figure out
> > > > > > > > when it is safe to free removed callback handle and
> > > > > > > > associated with it resources(un
Hi Xueming,
On Mon, Jan 15, 2018 at 02:54:19PM +0800, Xueming Li wrote:
> Previously, mempool of multiple memory segments would lead to MR
> registration error "mempool not virtually contiguous". This patch
> support multi-segments mempool by registering each memory segment of
> mempool.
>
> Sign
-Original Message-
> Date: Mon, 15 Jan 2018 20:01:14 +0530
> From: Hemant Agrawal
> To: Jerin Jacob
> CC: dev@dpdk.org, olivier.m...@6wind.com, santosh.shu...@caviumnetworks.com
> Subject: Re: [PATCH v2 2/5] eal: add platform mempool ops name in internal
> config
> User-Agent: Mozilla/5.
-Original Message-
> Date: Mon, 15 Jan 2018 20:05:16 +0530
> From: Hemant Agrawal
> To: Jerin Jacob
> CC: dev@dpdk.org, olivier.m...@6wind.com, santosh.shu...@caviumnetworks.com
> Subject: Re: [PATCH v2 5/5] mbuf: add user command line config mempools ops
> API
> User-Agent: Mozilla/5.0
On Sat, Jan 13, 2018 at 08:14:06PM +0100, Thomas Monjalon wrote:
> Hi,
>
> There is a new compilation error since this commit in LPM:
> http://dpdk.org/commit/b2e1c99
> The brace has been removed because unnecessary with anonymous union.
>
> This union is declared with RTE_STD_C11 for compa
-Original Message-
> Date: Fri, 12 Jan 2018 22:14:16 +0530
> From: Pavan Nikhilesh
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
> harry.van.haa...@intel.com, gage.e...@intel.com, hemant.agra...@nxp.com,
> nipun.gu...@nxp.com, liang.j...@intel.com
> Cc: dev@dpd
From: Alan Dewar
The RED code stores the weighted moving average in a 32-bit integer as
a pseudo fixed-point floating number with 10 fractional bits. Twelve
other bits are used to encode the filter weight, leaving just 10 bits
for the queue length. This limits the maximum queue length supported
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei
> Sent: Monday, January 15, 2018 6:18 PM
> To: Xu, Rosen; Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix issue of pctype doesn't take
> effect in X7
15/01/2018 13:22, Jonas Pfefferle:
>
> On Sat, 13 Jan 2018 23:49:30 +0100
> Thomas Monjalon wrote:
> > 13/01/2018 13:15, Burakov, Anatoly:
> >> On 11-Jan-18 11:45 PM, Thomas Monjalon wrote:
> >> > 07/11/2017 10:50, Jonas Pfefferle1:
> >> >>> Is there something urgent for 17.11?
> >> >>> Or ca
15/01/2018 13:12, Doherty, Declan:
> On 10/01/2018 7:26 PM, Thomas Monjalon wrote:
> > 10/01/2018 14:46, Doherty, Declan:
> >> On 09/01/2018 11:22 PM, Thomas Monjalon wrote:
> >>> Hi,
> >>>
> >>> 08/01/2018 15:37, Remy Horton:
> Port Representors provide a logical presentation in DPDK of VF (v
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei
> Sent: Monday, January 15, 2018 6:19 PM
> To: Igor Ryzhov; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to
> mac_address_write
>
>
>
> > -Or
My remarks for this one are mostly the same,
I will try to repeat them faithfully...
"convert to" -> "use"
On Wed, Jan 10, 2018 at 04:40:23PM +0200, Moti Haimovsky wrote:
...
> +static bool
> +fs_rxq_are_offloads_valid(struct rte_eth_dev *dev, uint64_t offloads)
function name can be shortened
Hi Moti,
Thanks for the patches.
I have some nitpicks, but overall it is good. Sorry for doing the review
so late, the changes should not take long, it's mostly syntax.
For the commit title, I'd prefer "use" instead of "convert to"
[PATCH V3 1/2] net/failsafe: use new Tx offloads API
As the
On 1/15/2018 7:29 PM, Thomas Monjalon wrote:
15/01/2018 11:52, Guo, Jia:
On 1/15/2018 7:24 AM, Thomas Monjalon wrote:
11/01/2018 15:05, Jeff Guo:
+enum rte_dev_subsystem {
+ RTE_DEV_SUBSYSTEM_UIO,
+ RTE_DEV_SUBSYSTEM_VFIO,
+ RTE_DEV_SUBSYSTEM_PCI,
+ RTE_DEV_SUBSYSTEM_
Hi Xueming,
On Mon, Jan 15, 2018 at 02:54:18PM +0800, Xueming Li wrote:
> Secondary process are not alloed to access verbs resources, add check to
> prevent MR registration in data path.
>
> Signed-off-by: Xueming Li
> ---
> doc/guides/nics/mlx5.rst | 1 +
> drivers/net/mlx5/mlx5_mr.c | 3
On 1/15/2018 7:32 PM, Thomas Monjalon wrote:
15/01/2018 11:55, Guo, Jia:
On 1/15/2018 7:16 AM, Thomas Monjalon wrote:
Hi,
11/01/2018 15:05, Jeff Guo:
+/* A genaral callback for all registerd devices */
Typos: genaral, registerd
So the callback is only for registered devices?
What about ho
On 1/10/2018 8:22 PM, Marko Kovacevic wrote:
Added contribution guideline for adding stable
tags when sending patches all fix patches to the
master branch that are candidates for backporting
Signed-off-by: Marko Kovacevic
Acked-by: Hemant Agrawal
..
On 1/10/2018 8:21 PM, Marko Kovacevic wrote:
Added contribution guideline for adding tags
when sending patches that have been raised by
coverity
Signed-off-by: Marko Kovacevic
Acked-by: Hemant Agrawal
On Mon, Jan 15, 2018 at 02:54:17PM +0800, Xueming Li wrote:
> This reverts commit 17fd4a504a4780455f79969803dc231521254ca8.
>
> Fixes: 12ed59b702cc ("net/mlx5: fix Memory Region registration")
> Signed-off-by: Xueming Li
Is it possible to have a more explicit reason why this patch is
reverted?
On x86 it is possible to use lock-prefixed instructions to get
the similar effect as mfence.
As pointed by Java guys, on most modern HW that gives a better
performance than using mfence:
https://shipilev.net/blog/2014/on-the-fence-with-dependencies/
That patch adopts that technique for rte_smp_mb(
On x86 it is possible to use lock-prefixed instructions to get
the similar effect as mfence.
As pointed by Java guys, on most modern HW that gives a better
performance than using mfence:
https://shipilev.net/blog/2014/on-the-fence-with-dependencies/
That patch adopts that technique for rte_smp_mb(
Simple functional test for rte_smp_mb() implementations.
Also when executed on a single lcore could be used as rough
estimation how many cycles particular implementation of rte_smp_mb()
might take.
Signed-off-by: Konstantin Ananyev
---
test/test/Makefile | 1 +
test/test/test_barrier.c |
v3 changes:
Address Thomas and Keith code-review comments:
- for readability, use "barrier" instead of "mb" in function and file naming.
- Use SPDX tag for license header.
v2 changes:
Address Bruce code-review comments:
- get rid of macros to simplify the code
- add more comments to the
> >> Signed-off-by: Ravi Kumar
> >> doc/guides/nics/axgbe.rst | 211
> +
> >> doc/guides/nics/features/axgbe.ini | 14 +++
> >> doc/guides/nics/index.rst | 1 +
> >> 3 files changed, 226 insertions(+)
Acked-by: Marko Kovacevic
-- Oryginal message --
On 1/3/2018 1:12 PM, maciej.cze...@caviumnetworks.com wrote:
From: Maciej Czekaj
This patch removes all references to old-style offload API
replacing them with new offload flags.
Signed-off-by: Maciej Czekaj
<...>
dev_info->default_txconf = (struct rte_eth_
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Monday, January 15, 2018 6:36 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ;
> hemant.agra...@nxp.com; Akhil Goyal
> Subject: [PATCH v3 0/3] crypto/dpaa_sec: performance optimizations
>
> Following change
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Monday, January 15, 2018 12:48 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ;
> hemant.agra...@nxp.com; Nicolau, Radu
> Subject: Re: [PATCH] examples/ipsec-secgw: update incremental checksum
>
> On 1/15/2
> Signed-off-by: Anatoly Burakov
> doc/guides/prog_guide/member_lib.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Marko Kovacevic
-Original Message-
> Date: Mon, 15 Jan 2018 19:54:36 +0530
> From: Hemant Agrawal
> To: Jerin Jacob
> CC: dev@dpdk.org, olivier.m...@6wind.com, santosh.shu...@caviumnetworks.com
> Subject: Re: [PATCH v2 3/5] mbuf: support register mempool Hw ops name APIs
> User-Agent: Mozilla/5.0 (Window
On 1/15/2018 5:59 PM, Jerin Jacob wrote:
-Original Message-
Date: Mon, 15 Jan 2018 11:41:14 +0530
From: Hemant Agrawal
This patch add the user command line configured mempool ops name
API to librte_mbuf and sends a deprecation notice to remove the
similar API from eal.
Signed-off-by
On 1/15/2018 6:01 PM, Jerin Jacob wrote:
Introduce a new helper for pktmbuf pool, which will allow
the application to optionally specify the mempool ops name
as well.
Signed-off-by: Hemant Agrawal
---
lib/librte_mbuf/rte_mbuf.c | 23 ++--
lib/librte_mbuf/rte_mbuf.h
On 1/15/2018 5:54 PM, Jerin Jacob wrote:
static int
diff --git a/lib/librte_eal/common/eal_internal_cfg.h
b/lib/librte_eal/common/eal_internal_cfg.h
index 1169fcc..12c5b8a 100644
--- a/lib/librte_eal/common/eal_internal_cfg.h
+++ b/lib/librte_eal/common/eal_internal_cfg.h
@@ -54,6 +54,8 @@ stru
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Jozwiak
> Sent: Monday, January 15, 2018 1:53 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Jozwiak, TomaszX
> Subject: [dpdk-dev] [PATCH] crypto/qat: fix out-of-bounds compiler error
>
> This commi
On 1/15/2018 7:55 AM, Zhiyong Yang wrote:
> void * pointer can be assigned to any data type pointer. Unnecessary cast
> can be removed in order to keep code clearer.
>
> Zhiyong Yang (5):
> lib/librte_lpm: remove unnecessary void * pointer cast
> lib/librte_efd: remove unnecessary void * point
On 1/15/2018 5:11 PM, Jerin Jacob wrote:
+int
+rte_mbuf_register_platform_mempool_ops(const char *ops_name)
+{
Should we also check the following?
if (internal_config.plat_mbuf_pool_ops_name != NULL &&
strncmp(internal_config.plat_mbuf_pool_ops_name, ops_name, ..) == 0)
return 0;
i.e
This commit fixes
- bpi_cipher_encrypt to prevent before 'array subscript is
above array bounds' error
- bpi_cipher_decrypt to prevent before 'array subscript is
above array bounds' error
- right cast from qat_cipher_get_block_size function.
This function can return -EFAULT in cas
Ptype mapping table will fail to update when loading
PPP profile, fix the issue via modifying metadata and
adding check.
This patch also adds parser for IPV4FRAG and IPV6FRAG.
Fixes: ab2e350c4f4b ("net/i40e: improve packet type parser")
Cc: sta...@dpdk.org
Signed-off-by: Beilei Xing
---
v3 chan
Hi Konstantin
From: Ananyev, Konstantin, Monday, January 15, 2018 1:45 PM
> Hi Matan,
>
> >
> >
> > Hi Konstantin
> >
> > From: Ananyev, Konstantin, Friday, January 12, 2018 2:02 AM
> > > Hi Matan,
> > >
> > > >
> > > > Hi Konstantin
> > > >
> > > > From: Ananyev, Konstantin, Thursday, January 11
00:14.0 Ethernet controller [0200]: Intel Corporation Ethernet Connection
I354 [8086:1f41] (rev 03)
I am not clear on the status of the document I have. Here is a link to a
similar product: https://people.ucsc.edu/~warner/Bufs/AG6248.pdf -- I have
the 7648c which is somewhat similar to the 6248c
On 1/15/2018 6:12 PM, Akhil Goyal wrote:
When TTL is decremented or ecn is updated in IP header
before forwarding the packet, checksum needs to be updated.
In this patch an incremental checksum is added for ipv4 case.
Signed-off-by: Akhil Goyal
---
This patch is an update to a very old patch
1 - 100 of 170 matches
Mail list logo
