Re: [dpdk-dev] [PATCH v3 1/2] net/octeontx: add channel to port id mapping

2018-01-09 Thread Pavan Nikhilesh
On Tue, Jan 09, 2018 at 12:49:20PM +, Ferruh Yigit wrote: > On 1/9/2018 12:47 PM, Ferruh Yigit wrote: > > On 12/19/2017 6:01 PM, Pavan Nikhilesh wrote: > >> The channel to port id map is used by event octeontx to map the received > >> wqe to the respective ethdev port. > >> > >> Signed-off-by:

Re: [dpdk-dev] [PATCH v4 3/5] drivers/net/i40e: add Port Representor functionality

2018-01-09 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Remy Horton > Sent: Monday, January 8, 2018 10:37 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Lu, Wenzhuo > ; Wu, Jingjing ; Doherty, > Declan ; Awal, Mohammad Abdul > > Subject: [dpdk-dev] [PATCH v4 3/5] driver

Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags

2018-01-09 Thread Andrew Rybchenko
On 01/10/2018 10:38 AM, Thomas Monjalon wrote: 10/01/2018 03:15, Yang, Qiming: From: Thomas Monjalon [mailto:tho...@monjalon.net] 07/01/2018 07:32, Shahaf Shuler: Saturday, January 6, 2018 12:22 PM, Andrew Rybchenko: [..] #define ETH_RSS_PORT (1ULL << RTE_ETH_FLOW_PORT) +/*

Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags

2018-01-09 Thread Thomas Monjalon
10/01/2018 03:15, Yang, Qiming: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 07/01/2018 07:32, Shahaf Shuler: > > > Saturday, January 6, 2018 12:22 PM, Andrew Rybchenko: > > > > > > [..] > > > > > > > > #define ETH_RSS_PORT (1ULL << RTE_ETH_FLOW_PORT) > > > > > +/** Enab

Re: [dpdk-dev] [PATCH v4 5/5] app/test-pmd: add Port Representor commands

2018-01-09 Thread Remy Horton
On 09/01/2018 22:10, Ferruh Yigit wrote: [..] +Adding a representor for a VF requires specifying the PF in +``Bus_DomBDF`` format alongside the index number of the VF:: + + testpmd> add representor pci_:81:00.0 0 I am for grouping port related commands under "port" command, these are all

Re: [dpdk-dev] [PATCH v2 0/2] AVX2 Vectorized Rx/Tx functions for i40e

2018-01-09 Thread Zhang, Qi Z
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, January 9, 2018 10:33 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Helin ; Yigit, Ferruh > ; Richardson, Bruce > Subject: [PATCH v2 0/2] AVX2 Vectorized Rx/Tx functions for i40e > > This patch adds an AVX

Re: [dpdk-dev] [PATCH v2 0/2] AVX2 Vectorized Rx/Tx functions for i40e

2018-01-09 Thread Li, Xiaoyun
Hi After perf test, with right setting, the perf can improve about 20%. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, January 9, 2018 22:33 > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Helin ; Yigit, Ferruh >

[dpdk-dev] [PATCH v3 2/2] net/tap: implement RSS with eBPF classifier and action

2018-01-09 Thread Ophir Munk
Add BPF classifier for each TAP queue. According to this classifier packets marked with an RSS queue will be directed to this queue using a traffic control with "skbedit" action. The BPF classifier program is downloaded to the kernel once per TAP Rx queue. Add RSS BPF map entry for each new RSS ru

[dpdk-dev] [PATCH v3 0/2] TAP RSS eBPF cover letter

2018-01-09 Thread Ophir Munk
The patches of TAP RSS eBPF follow the RFC on this issue https://dpdk.org/dev/patchwork/patch/31781/ v3 changes with respect to v2 = * Add support for IPv6 RSS in BPF program * Bug fixes * Updated compatibility to kernel versions: eBPF requires Linux version 4.9 confi

[dpdk-dev] [PATCH v3 1/2] net/tap: add eBPF instructions to TAP device

2018-01-09 Thread Ophir Munk
TAP PMD is required to support RSS queue mapping based on rte_flow API. An example usage for this requirement is failsafe transparent switching from a PCI device to TAP device while keep redirecting packets to the same RSS queues on both devices. TAP RSS implementation is based on eBPF programs se

Re: [dpdk-dev] [PATCH] app/testpmd: add eth peer CLI command

2018-01-09 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wisam Monther > Sent: Thursday, January 4, 2018 5:06 PM > To: Wu, Jingjing ; Raslan Darawsheh > > Cc: dev@dpdk.org; Ori Kam ; Shahaf Shuler > ; Wisam Monther > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: ad

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-09 Thread Xing, Beilei
> -Original Message- > From: Rybalchenko, Kirill > Sent: Monday, November 27, 2017 8:30 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; johnd...@cisco.com; neesc...@cisco.com; > adrien.mazarg...@6wind.com; nelio.laranje...@6wind.com; > ys...@mellanox.com; Lu, Wenzhuo ; Ananyev

[dpdk-dev] [PATCH v3] app/testpmd: add option ring-bind-lcpu to bind Q with CPU

2018-01-09 Thread wei . guo . simon
From: Simon Guo Currently the rx/tx queue is allocated from the buffer pool on socket of: - port's socket if --port-numa-config specified - or ring-numa-config setting per port All the above will "bind" queue to single socket per port configuration. But it can actually archieve better performanc

[dpdk-dev] [PATCH v4] kernel folder for Linux and BSD modules

2018-01-09 Thread Hemant Agrawal
This patch moves the kernel modules code from EAL to a common place. - Separate the kernel module code from user space code. Signed-off-by: Hemant Agrawal --- v4: update the path in MAINTAINERS v3: move contigmem from bsdapp v2: rename kern to kernel, add freebsd modules as well GNUmakefile

Re: [dpdk-dev] [PATCH v3] kni: convert license headers to SPDX tags

2018-01-09 Thread Hemant Agrawal
On 1/9/2018 9:00 PM, Ferruh Yigit wrote: On 1/9/2018 3:24 PM, Thomas Monjalon wrote: 09/01/2018 16:12, Ferruh Yigit: --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h +/* SPDX-License-Identifier: (BSD-3-Clause

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix invalid txq number setting

2018-01-09 Thread Yang, Qiming
I think the name bak is a little bit confused, what do you think just use nd_txq_backup/nd_rxq_backup? And I think it's no need to break the patch into two patch, them fix the same thing and the code amount are not large. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On

Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF

2018-01-09 Thread Yang, Qiming
+1 why we disable interrupt in dev_start twice? > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 9, 2018 4:24 PM > To: Dai, Wei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF > > Hi W

Re: [dpdk-dev] [PATCH v2] net/pcap: convert license headers to SPDX tags

2018-01-09 Thread Hemant Agrawal
On 1/9/2018 6:43 PM, Ferruh Yigit wrote: Signed-off-by: Ferruh Yigit --- v2: Changed syntax for SPDX header --- doc/guides/nics/pcap_ring.rst | 31 ++- drivers/net/pcap/Makefile | 35 --- drivers/net/pcap/rte_eth_pcap.c | 36 ++

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2018-01-09 Thread Anoob Joseph
Hi Nelio, On 01/09/2018 06:18 PM, Nelio Laranjeiro wrote: Hi Anoob, On Fri, Jan 05, 2018 at 11:48:50AM +0530, Anoob Joseph wrote: Hi Adrien, On 12/21/2017 07:52 PM, Adrien Mazarguil wrote: On Thu, Dec 21, 2017 at 12:12:29PM +0200, Boris Pismenny wrote: On 12/21/2017 10:06 AM, Anoob Josep

[dpdk-dev] [PATCH v6 13/14] net/avf: enable bulk allocate Rx func

2018-01-09 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/avf/avf.h| 1 + drivers/net/avf/avf_ethdev.c | 1 + drivers/net/avf/avf_rxtx.c | 300 +++ drivers/net/avf/avf_rxtx.h | 6 + 4 files changed, 308 insertions(+) diff --git a/drivers/net/avf/avf.h b/

[dpdk-dev] [PATCH v6 14/14] net/avf: enable Rx interrupt support

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Update the doc for the AVF features either. Signed-off-by: Jingjing Wu --- doc/guides/nics/features/avf.ini | 1 + doc/guides/nics/features/avf_vec.ini | 1 + doc/guides/nics/intel_vf.rst | 20 +++- doc/guides/rel_notes/release_18_02.rst | 16 +++ driv

[dpdk-dev] [PATCH v6 12/14] net/avf: enable sse vector Rx Tx func

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Signed-off-by: Jingjing Wu --- config/common_base| 1 + doc/guides/nics/features/avf_vec.ini | 36 ++ drivers/net/avf/Makefile | 1 + drivers/net/avf/avf.h | 4 + drivers/net/avf/avf_ethdev.c | 11 + drivers/ne

[dpdk-dev] [PATCH v6 11/14] net/i40e: support AVF basic interface

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Enable Virtchnl offload Caps negotiation and RSS_PF offload to support AVF basic interface. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 69 drivers/net/i40e/i40e_ethdev.h | 5 ++ drivers/net/i40e/i40e_pf.c | 140

[dpdk-dev] [PATCH v6 10/14] net/avf: enable ops to check queue info and status

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu - rxq_info_get - txq_info_get - rx_queue_count - rx_descriptor_status - tx_descriptor_status Signed-off-by: Jingjing Wu --- doc/guides/nics/features/avf.ini | 2 + drivers/net/avf/avf_ethdev.c | 5 ++ drivers/net/avf/avf_rxtx.c | 120 +++

[dpdk-dev] [PATCH v6 09/14] net/avf: enable ops for MTU setting

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Signed-off-by: Jingjing Wu --- doc/guides/nics/features/avf.ini | 1 + drivers/net/avf/avf_ethdev.c | 30 ++ 2 files changed, 31 insertions(+) diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini index 61527d7..cf1b

[dpdk-dev] [PATCH v6 08/14] net/avf: enable ops for RSS setting

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Signed-off-by: Jingjing Wu --- doc/guides/nics/features/avf.ini | 2 + drivers/net/avf/avf_ethdev.c | 142 +++ 2 files changed, 144 insertions(+) diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini index 1

[dpdk-dev] [PATCH v6 06/14] net/avf: support stats

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Signed-off-by: Jingjing Wu --- doc/guides/nics/features/avf.ini | 1 + drivers/net/avf/avf.h| 2 ++ drivers/net/avf/avf_ethdev.c | 27 +++ drivers/net/avf/avf_vchnl.c | 27 +++ 4 files changed, 57 insertion

[dpdk-dev] [PATCH v6 07/14] net/avf: enable MAC VLAN and promisc ops

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu - promiscuous_enable - promiscuous_disable - allmulticast_enable - allmulticast_disable - mac_addr_add - mac_addr_remove - mac_addr_set - vlan_filter_set - vlan_offload_set Signed-off-by: Jingjing Wu --- doc/guides/nics/features/avf.ini | 5 + drivers/net/avf/avf.h

[dpdk-dev] [PATCH v6 04/14] net/avf: enable basic Rx Tx func

2018-01-09 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- MAINTAINERS | 1 + config/common_base | 4 + doc/guides/nics/features/avf.ini | 22 ++ drivers/net/avf/Makefile | 3 + drivers/net/avf/avf_ethdev.c | 36 +- drivers/net/avf/avf_log.h| 21 ++ drivers/net/

[dpdk-dev] [PATCH v6 05/14] net/avf: enable link status update

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Signed-off-by: Jingjing Wu --- doc/guides/nics/features/avf.ini | 3 +++ drivers/net/avf/avf.h| 2 ++ drivers/net/avf/avf_ethdev.c | 51 +++- drivers/net/avf/avf_vchnl.c | 38 +- 4 files cha

[dpdk-dev] [PATCH v6 00/14] dd new AVF PMD

2018-01-09 Thread Wenzhuo Lu
Adaptive Virtual Function (AVF) Driver is VF driver which supports for all future Intel devices without requiring a VM update. It promises the basic high speed connectivity. And since this happens to be an adaptive VF driver, every new drop of the VF driver would add more and more advanced featu

[dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Signed-off-by: Jingjing Wu --- config/common_base | 5 + drivers/net/Makefile| 1 + drivers/net/avf/Makefile| 47 drivers/net/avf/avf.h | 187 ++ drivers/net/avf/avf_ethdev.c

[dpdk-dev] [PATCH v6 03/14] net/avf: enable queue and device

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu enable device and queue setup ops like: - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get - rx_queue_start - rx_queue_stop - tx_queue_start - tx_queue_stop - rx_queue_setup - rx_queue_release - tx_queue_setup - tx_queue_release Signed-off-by: Jing

[dpdk-dev] [PATCH v2] examples/vhost: fix remove dev_info.max_rx_queues checking to solve startup failure

2018-01-09 Thread Zhiyong Yang
For vhost sample, the operation if (dev_info.max_rx_queues > MAX_QUEUES) in the function port_init causes startup failure when using X710(i40e driver). X710 requires that MAX_QUEUES should be defined no less than 320, however it is defined as 128 currently. Such checking is overkill and Removal do

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix invalid rxq number setting

2018-01-09 Thread Dai, Wei
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, January 10, 2018 9:55 AM > To: Dai, Wei ; Lu, Wenzhuo ; > Wu, Jingjing ; Peng, Yuan > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] app/testpmd: fix invalid rxq number > setting > > > > > ---

Re: [dpdk-dev] [PATCH v3 00/24] net/i40e: update base code

2018-01-09 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, January 10, 2018 4:30 AM > To: Xing, Beilei > Cc: dev@dpdk.org; Wu, Jingjing ; Zhang, Qi Z > > Subject: [PATCH v3 00/24] net/i40e: update base code > > The patchset update i40e base code base on latest CID drop cid- > i40e.201

[dpdk-dev] [PATCH v2 0/2] app/testpmd: fix invalid rxq and txq nubmer setting

2018-01-09 Thread Wei Dai
If an invlaid number of RX or TX queues is configured from testpmd command like "port config all rxq number" or "port config all txq number". The global variable rxq or txq is updated by the invalid input. This can cause testpmd crash. For example, if the maximum number of RX or TX queues is 4, tes

[dpdk-dev] [PATCH v2 2/2] app/testpmd: fix invalid txq number setting

2018-01-09 Thread Wei Dai
If an invalid TX queue is configured from testpmd command like "port config all txq number", the global variable txq is updated by this invalid value. It may cause testpmd crash. This patch restores its last correct value when an invalid txq number configured is detected. Fixes: ce8d561418d4 ("app

[dpdk-dev] [PATCH v2 1/2] app/testpmd: fix invalid rxq number setting

2018-01-09 Thread Wei Dai
If an invalid RX queue is configured from testpmd command like "port config all rxq number", the global variable rxq is updated by this invalid value. It may cause testpmd crash. This patch restores its last correct value when an invalid rxq number configured is detected. Fixes: ce8d561418d4 ("app

Re: [dpdk-dev] 回复:RE: 回复:RE: Thread safety in rte_acl

2018-01-09 Thread Ramia, Kannan Babu
The way the application is written assumes there will be a transition phase where few threads will have OLD ACL results for the packets that are currently handled, but once those set is flushed out all the new set of packets will be back to the active set. So the system will be consistent after

[dpdk-dev] [PATCH v3 24/24] net/i40e/base: update README file

2018-01-09 Thread Qi Zhang
Update README file to specify the version of CID drop Signed-off-by: Qi Zhang --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 59e76c216..247ba11d4 100644 --- a/drivers/net/i40e/

[dpdk-dev] [PATCH v3 23/24] net/i40e: rename a field

2018-01-09 Thread Qi Zhang
Rename virtchnl_vf_resource's vf_offload_flags to vf_cap_flags. The new name is more generic, so more than just offloading capabilities can be added. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 4 ++-- drivers/net/i40e/base/virtchnl.h| 4 ++-- drivers/net/i40e/i40e_ethd

[dpdk-dev] [PATCH v3 20/24] net/i40e/base: fix compile issue for GCC 6.3

2018-01-09 Thread Qi Zhang
When using GCC 6.3.0 and EXTRA_CFLAGS=-Og, the compiler is not smart enough to see that when you have an integrated VF that just one of the if statemets has to be true so that ntu is always set. Fix the way that the code is for integrated VFs so that the compiler won't complain. Fixes: 9783eb15eb9

[dpdk-dev] [PATCH v3 22/24] net/i40e/base: fix unaligned data issue

2018-01-09 Thread Qi Zhang
This fix prevents errors or warnings while accessing unaligned 32-bit data words on non-x86 platforms during getting link info from firmware. Fixes: e8228f1a16b7 ("net/i40e/base: report supported link modes") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c |

[dpdk-dev] [PATCH v3 21/24] net/i40e/base: fix reading LLDP configuration

2018-01-09 Thread Qi Zhang
Previous method for reading LLDP config was based on hard-coded offsets. It happened to work, because of structured architecture of the NVM memory. In the new approach, known as FLAT, we need to calculate the absolute address, instead of using relative values. Needed defines for memory location wer

[dpdk-dev] [PATCH v3 19/24] net/i40e/base: add AQ critical error type

2018-01-09 Thread Qi Zhang
The FW has the ability to return a critical error on every AQ command. So add the new return type as critical error to sync with firmware. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c | 17 + drivers/net/i40e/base/i40e_common.c | 2 ++ drivers/net/i40e/base/i4

[dpdk-dev] [PATCH v3 17/24] net/i40e: enhanced loopback AQ command

2018-01-09 Thread Qi Zhang
Enhanced loopback AQ command to allow variety of loopback modes. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 21 +++-- drivers/net/i40e/base/i40e_common.c | 12 drivers/net/i40e/base/i40e_diag.c | 17 +++-- drivers/net/

[dpdk-dev] [PATCH v3 18/24] net/i40e/base: add rearrange process AQ command

2018-01-09 Thread Qi Zhang
Add new AQ command that help to inform software how advanced rearrangement process is. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + drivers/net/i40e/base/i40e_common.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH v3 16/24] net/i40e/base: add defines for flat NVM

2018-01-09 Thread Qi Zhang
New control bits were defined for flat NVM structure. One for pointing which NVM bank is currently used and one used as indicator of structure type. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type

[dpdk-dev] [PATCH v3 15/24] net/i40e/base: fix link LED blink

2018-01-09 Thread Qi Zhang
This fix solves an issue occurring while calling i40e_led_set function from the driver with "blink" parameter set as TRUE. This call resulted in Activity LED blinking instead of Link LED, which may lead to errors in physically identyfying the port, since Activity LED may be blinking for different r

[dpdk-dev] [PATCH v3 14/24] net/i40e/base: enable AQ event get in NVM update

2018-01-09 Thread Qi Zhang
This patch adds new I40E_NVMUPD_GET_AQ_EVENT state to allow retrieval of AdminQ events as a result. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c| 2 +- drivers/net/i40e/base/i40e_nvm.c | 125 + drivers/net/i40e/base/i40e_prototype.h

[dpdk-dev] [PATCH v3 13/24] net/i40e/base: add NVM update preservation flags

2018-01-09 Thread Qi Zhang
Add preservation flags support on X722 devices for NVM update AdminQ function wrapper. Add new parameter and handling to nvm update admin queue function intended to allow nvmupdate tool to configure the preservation flags in the AdminQ command. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i

[dpdk-dev] [PATCH v3 12/24] net/i40e/base: code clean

2018-01-09 Thread Qi Zhang
1. Cleanup logical in __i40e_read_nvm_word and reuse it in i40e_read_nvm_word. 2. Change couple functions to static so we can remove uncessary function declarations 3. Cleanup logical in i40e_validate_nvm_checksum. 4. Add more debug information in PF reset 5. correct comments 6. Minor code style fi

[dpdk-dev] [PATCH v3 11/24] net/i40e/base: fix NVM lock

2018-01-09 Thread Qi Zhang
NVM lock is only required at below situation: 1. its X722 device or 2. API version >= 1.5 or may have issue at firmware downgrade. Fixes: c5846a125b26 ("net/i40e/base: fix NVM access interfering") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c | 6 ++ dr

[dpdk-dev] [PATCH v3 10/24] net/i40e/base: add AQ command for DCB parameters

2018-01-09 Thread Qi Zhang
Add new Adminq command i40e_aqc_opc_set_dcb_parameters that helps to get DCB parameters in data structure i40e_aqc_set_dcb_parameters. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 12 drivers/net/i40e/base/i40e_common.c | 27 +++

[dpdk-dev] [PATCH v3 07/24] net/i40e/base: add macro for 25G device

2018-01-09 Thread Qi Zhang
Add Macro to idenfity 25G device by device ID Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_devids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/base/i40e_devids.h b/drivers/net/i40e/base/i40e_devids.h index f4a878423..66ff1ccfc 100644 --- a/drivers/net/i40e

[dpdk-dev] [PATCH v3 09/24] net/i40e/base: add link speed convert function

2018-01-09 Thread Qi Zhang
Introduce a helper function which can convert the AdminQ link speed definition into a virtchnl definition. This can then be used by host driver implementations in order to safely convert to the interface recognized by the virtual functions. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_

[dpdk-dev] [PATCH v3 08/24] net/i40e/base: code refactoring for LED blink

2018-01-09 Thread Qi Zhang
Code refactory, wrap repeated code in function. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 202 1 file changed, 87 insertions(+), 115 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH v3 06/24] net/i40e/base: add byte swaps in PHY register access

2018-01-09 Thread Qi Zhang
Add byte swap commandwhen transferring data between memory and firmware while using PHY register access functions. Endianness also need to be handled correctly during these swaps. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH v3 04/24] net/i40e/base: release spinlock before function returns

2018-01-09 Thread Qi Zhang
Fix a bug that adminq spin lock is not be released before function i40e_nvmupd_command returns. Fixes: 5a2e46a3e405 ("net/i40e/base: refactor NVM update command processing") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_nvm.c | 10 -- 1 file changed, 8 inser

[dpdk-dev] [PATCH v3 05/24] net/i40e/base: retry AQC to overcome IRCRead hangs

2018-01-09 Thread Qi Zhang
When the I2C is busy, the PHY reads are delayed. The firmware will return EGAIN in these cases with an expectation that the SW will trigger the reads again. This patch retries the operation for a maximum period of 500ms Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 42 +++

[dpdk-dev] [PATCH v3 00/24] net/i40e: update base code

2018-01-09 Thread Qi Zhang
The patchset update i40e base code base on latest CID drop cid-i40e.2018.01.02.tar.gz, couple issues are fixed, include: NVM lock issue, LED blink issue, LLDP configuration read issue unaligned data issue on non-x86 platform and some compile issue with GCC 6.3. Aslo a new AQ command that help softw

[dpdk-dev] [PATCH v3 02/24] net/i40e/base: add capability macros

2018-01-09 Thread Qi Zhang
Add capability macros for 25G AOC/ACC PHYS. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index dca725afd..42b2d9166 100644 --- a/drivers/net/i40e/base/i

[dpdk-dev] [PATCH v3 03/24] net/i40e/base: add (Q)SFP module memory access definitions

2018-01-09 Thread Qi Zhang
Add definations used for accessing and interrupting contents of (Q)SFP module internal EEPROM memory. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_t

[dpdk-dev] [PATCH v3 01/24] net/i40e/base: add new PHY type

2018-01-09 Thread Qi Zhang
Add new PHY type I40E_PHY_TYPE_NOT_SUPPORTED_HIGH_TEMP, it will be set by firmware if device module does not meet the thermal requirements. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/base/i40e_adminq_cm

Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API

2018-01-09 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, January 10, 2018 10:59 AM > To: Zhao1, Wei; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API > > > > > -Original Message- > > From: Zhao1,

[dpdk-dev] [PATCH v2 23/24] net/i40e: rename a field

2018-01-09 Thread Qi Zhang
Rename virtchnl_vf_resource's vf_offload_flags to vf_cap_flags. The new name is more generic, so more than just offloading capabilities can be added. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 4 ++-- drivers/net/i40e/base/virtchnl.h| 4 ++-- drivers/net/i40e/i40e_pf.c

[dpdk-dev] [PATCH v2 24/24] net/i40e/base: update README file

2018-01-09 Thread Qi Zhang
Update README file to specify the version of CID drop Signed-off-by: Qi Zhang --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 59e76c216..247ba11d4 100644 --- a/drivers/net/i40e/

[dpdk-dev] [PATCH v2 21/24] net/i40e/base: fix reading LLDP configuration

2018-01-09 Thread Qi Zhang
Previous method for reading LLDP config was based on hard-coded offsets. It happened to work, because of structured architecture of the NVM memory. In the new approach, known as FLAT, we need to calculate the absolute address, instead of using relative values. Needed defines for memory location wer

[dpdk-dev] [PATCH v2 22/24] net/i40e/base: fix unaligned data issue

2018-01-09 Thread Qi Zhang
This fix prevents errors or warnings while accessing unaligned 32-bit data words on non-x86 platforms during getting link info from firmware. Fixes: e8228f1a16b7 ("net/i40e/base: report supported link modes") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c |

[dpdk-dev] [PATCH v2 20/24] net/i40e/base: fix compile issue for GCC 6.3

2018-01-09 Thread Qi Zhang
When using GCC 6.3.0 and EXTRA_CFLAGS=-Og, the compiler is not smart enough to see that when you have an integrated VF that just one of the if statemets has to be true so that ntu is always set. Fix the way that the code is for integrated VFs so that the compiler won't complain. Fixes: 9783eb15eb9

[dpdk-dev] [PATCH v2 19/24] net/i40e/base: add AQ critical error type

2018-01-09 Thread Qi Zhang
The FW has the ability to return a critical error on every AQ command. So add the new return type as critical error to sync with firmware. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c | 17 + drivers/net/i40e/base/i40e_common.c | 2 ++ drivers/net/i40e/base/i4

[dpdk-dev] [PATCH v2 17/24] net/i40e: enhanced loopback AQ command

2018-01-09 Thread Qi Zhang
Enhanced loopback AQ command to allow variety of loopback modes. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 21 +++-- drivers/net/i40e/base/i40e_common.c | 12 drivers/net/i40e/base/i40e_diag.c | 17 +++-- drivers/net/

[dpdk-dev] [PATCH v2 18/24] net/i40e/base: add rearrange process AQ command

2018-01-09 Thread Qi Zhang
Add new AQ command that help to inform software how advanced rearrangement process is. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + drivers/net/i40e/base/i40e_common.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH v2 16/24] net/i40e/base: add defines for flat NVM

2018-01-09 Thread Qi Zhang
New control bits were defined for flat NVM structure. One for pointing which NVM bank is currently used and one used as indicator of structure type. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type

[dpdk-dev] [PATCH v2 15/24] net/i40e/base: fix link LED blink

2018-01-09 Thread Qi Zhang
This fix solves an issue occurring while calling i40e_led_set function from the driver with "blink" parameter set as TRUE. This call resulted in Activity LED blinking instead of Link LED, which may lead to errors in physically identyfying the port, since Activity LED may be blinking for different r

[dpdk-dev] [PATCH v2 13/24] net/i40e/base: add NVM update preservation flags

2018-01-09 Thread Qi Zhang
Add preservation flags support on X722 devices for NVM update AdminQ function wrapper. Add new parameter and handling to nvm update admin queue function intended to allow nvmupdate tool to configure the preservation flags in the AdminQ command. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i

[dpdk-dev] [PATCH v2 14/24] net/i40e/base: enable AQ event get in NVM update

2018-01-09 Thread Qi Zhang
This patch adds new I40E_NVMUPD_GET_AQ_EVENT state to allow retrieval of AdminQ events as a result. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c| 2 +- drivers/net/i40e/base/i40e_nvm.c | 125 + drivers/net/i40e/base/i40e_prototype.h

[dpdk-dev] [PATCH v2 09/24] net/i40e/base: add link speed convert function

2018-01-09 Thread Qi Zhang
Introduce a helper function which can convert the AdminQ link speed definition into a virtchnl definition. This can then be used by host driver implementations in order to safely convert to the interface recognized by the virtual functions. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_

[dpdk-dev] [PATCH v2 10/24] net/i40e/base: add AQ command for DCB parameters

2018-01-09 Thread Qi Zhang
Add new Adminq command i40e_aqc_opc_set_dcb_parameters that helps to get DCB parameters in data structure i40e_aqc_set_dcb_parameters. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 12 drivers/net/i40e/base/i40e_common.c | 27 +++

[dpdk-dev] [PATCH v2 12/24] net/i40e/base: code clean

2018-01-09 Thread Qi Zhang
1. Cleanup logical in __i40e_read_nvm_word and reuse it in i40e_read_nvm_word. 2. Change couple functions to static so we can remove uncessary function declarations 3. Cleanup logical in i40e_validate_nvm_checksum. 4. Add more debug information in PF reset 5. correct comments 6. Minor code style fi

[dpdk-dev] [PATCH v2 08/24] net/i40e/base: code refactoring for LED blink

2018-01-09 Thread Qi Zhang
Code refactory, wrap repeated code in function. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 202 1 file changed, 87 insertions(+), 115 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH v2 11/24] net/i40e/base: fix NVM lock

2018-01-09 Thread Qi Zhang
NVM lock is only required at below situation: 1. its X722 device or 2. API version >= 1.5 or may have issue at firmware downgrade. Fixes: c5846a125b26 ("net/i40e/base: fix NVM access interfering") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c | 6 ++ dr

[dpdk-dev] [PATCH v2 07/24] net/i40e/base: add macro for 25G device

2018-01-09 Thread Qi Zhang
Add Macro to idenfity 25G device by device ID Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_devids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/base/i40e_devids.h b/drivers/net/i40e/base/i40e_devids.h index f4a878423..66ff1ccfc 100644 --- a/drivers/net/i40e

[dpdk-dev] [PATCH v2 06/24] net/i40e/base: add byte swaps in PHY register access

2018-01-09 Thread Qi Zhang
Add byte swap commandwhen transferring data between memory and firmware while using PHY register access functions. Endianness also need to be handled correctly during these swaps. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH v2 05/24] net/i40e/base: retry AQC to overcome IRCRead hangs

2018-01-09 Thread Qi Zhang
When the I2C is busy, the PHY reads are delayed. The firmware will return EGAIN in these cases with an expectation that the SW will trigger the reads again. This patch retries the operation for a maximum period of 500ms Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 42 +++

[dpdk-dev] [PATCH v2 03/24] net/i40e/base: add (Q)SFP module memory access definitions

2018-01-09 Thread Qi Zhang
Add definations used for accessing and interrupting contents of (Q)SFP module internal EEPROM memory. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_t

[dpdk-dev] [PATCH v2 04/24] net/i40e/base: release spinlock before function returns

2018-01-09 Thread Qi Zhang
Fix a bug that adminq spin lock is not be released before function i40e_nvmupd_command returns. Fixes: 5a2e46a3e405 ("net/i40e/base: refactor NVM update command processing") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_nvm.c | 10 -- 1 file changed, 8 inser

[dpdk-dev] [PATCH v2 02/24] net/i40e/base: add capability macros

2018-01-09 Thread Qi Zhang
Add capability macros for 25G AOC/ACC PHYS. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index dca725afd..42b2d9166 100644 --- a/drivers/net/i40e/base/i

[dpdk-dev] [PATCH v2 00/24] net/i40e: update base code

2018-01-09 Thread Qi Zhang
The patchset update i40e base code base on latest CID drop cid-i40e.2018.01.02.tar.gz, couple issues are fixed, include: NVM lock issue, LED blink issue, LLDP configuration read issue unaligned data issue on non-x86 platform and some compile issue with GCC 6.3. Aslo a new AQ command that help softw

[dpdk-dev] [PATCH v2 01/24] net/i40e/base: add new PHY type

2018-01-09 Thread Qi Zhang
Add new PHY type I40E_PHY_TYPE_NOT_SUPPORTED_HIGH_TEMP, it will be set by firmware if device module does not meet the thermal requirements. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/base/i40e_adminq_cm

Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe : backplane port MDIO support

2018-01-09 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shweta Choudaha > Sent: Monday, November 6, 2017 10:25 PM > To: dev@dpdk.org > Cc: Shweta Choudaha > Subject: [dpdk-dev] [PATCH v2 2/2] net/ixgbe : backplane port MDIO support > > From: Shweta Choudaha > > Init

Re: [dpdk-dev] [PATCH v5 02/14] net/avf: initialization of avf PMD

2018-01-09 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 10, 2018 1:58 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v5 02/14] net/avf: initialization of avf PMD > > On 1/8/2018 5:13 AM, Wenzhuo Lu wrote: > > From: Jingjin

Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API

2018-01-09 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, January 10, 2018 10:10 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v4] net/i40e: move RSS to flow API > > Rte_flow actually defined to include RSS, but till now, RSS is out of > rte_flow. > This patch

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add raw flowtype mode for flow director filter

2018-01-09 Thread Lu, Wenzhuo
Hi Kirill, > -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, January 10, 2018 8:58 AM > To: 'Kirill Rybalchenko' ; dev@dpdk.org > Cc: Rybalchenko, Kirill ; Chilikin, Andrey > ; Xing, Beilei ; Wu, > Jingjing > Subject: RE: [dpdk-dev] [PATCH 1/2] app/testpmd: add raw flowtype mode

[dpdk-dev] ??????RE: ??????RE: Thread safety in rte_acl

2018-01-09 Thread ????????
>Yes, you'll need some sort of synchronization. >Lock (or rwlock) is one option, but as build could take quite long time - >probably not the best one. >Another way - have a struct cthat ontains pointers to 2 ctx and an index for >active one. >Then you can do classify() on active one while doing a

[dpdk-dev] [PATCH v3] bus/pci: fix wrong intr_handle.type with uio_pci_generic

2018-01-09 Thread Zhiyong Yang
For virtio legacy device, testpmd startup fails when using uio_pci_generic. The issue is caused by invoking the function pci_ioport_map. The correct value of intr_handle.type is already set before calling it, we should avoid overwriting the default value "RTE_INTR_HANDLE_UNKNOWN" in this function.

Re: [dpdk-dev] [PATCH v3] doc: add i40e update

2018-01-09 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Wednesday, January 10, 2018 10:02 AM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3] doc: add i40e update > > Update release note to declare MPLSoUDP/MPLSoGRE/ GTP-U/G

Re: [dpdk-dev] [PATCH v6] net/ixgbe: fix tx_q check failed on PF

2018-01-09 Thread Zhang, Helin
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, January 10, 2018 9:57 AM > To: Wu, Yanglong; dev@dpdk.org; Zhang, Helin > Subject: RE: [PATCH v6] net/ixgbe: fix tx_q check failed on PF > > > > > -Original Message- > > From: Wu, Yanglong > > Sent: Wednesday,

[dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API

2018-01-09 Thread Wei Zhao
Rte_flow actually defined to include RSS, but till now, RSS is out of rte_flow. This patch is to move i40e existing RSS to rte_flow. This patch also enable queue region configuration using flow API for i40e. Signed-off-by: Wei Zhao --- v2: -change some code style. v3: -rebase code and add more

  1   2   3   4   5   >