Re: [dpdk-dev] [PATCH v5] net/ixgbe: add flow parser ntuple support

2018-01-04 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhao1, Wei > Sent: Friday, January 5, 2018 2:14 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao1, Wei > > Subject: [PATCH v5] net/ixgbe: add flow parser ntuple support > > Ixgbe ntuple filter in rte_flow need to support diversion data with less than > 5 tu

Re: [dpdk-dev] standardize device identification

2018-01-04 Thread Finn Christensen
-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: 20. december 2017 23:03 To: dev@dpdk.org Cc: Yuanhan Liu ; Adrien Mazarguil ; Ciara Loftus ; Kevin Traynor ; step...@networkplumber.org; ferruh.yi...@intel.com

[dpdk-dev] [PATCH v5] net/ixgbe: add flow parser ntuple support

2018-01-04 Thread Wei Zhao
Ixgbe ntuple filter in rte_flow need to support diversion data with less than 5 tuple parameters.So add this new support in parser code.This patch also add parser vlan pattern code in ntuple filter in order to handle some case including vlan in flow API. Signed-off-by: Wei Zhao --- v2: -fix cod

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2018-01-04 Thread Anoob Joseph
Hi Adrien, On 12/21/2017 07:52 PM, Adrien Mazarguil wrote: On Thu, Dec 21, 2017 at 12:12:29PM +0200, Boris Pismenny wrote: On 12/21/2017 10:06 AM, Anoob Joseph wrote: I can see the benefits of using rte_flow in both rx & tx, but this unnecessarily introduces hardware requirements for suppo

[dpdk-dev] [PATCH v4 2/2] gro: support VxLAN GRO

2018-01-04 Thread Jiayu Hu
This patch adds a framework that allows GRO on tunneled packets. Furthermore, it leverages that framework to provide GRO support for VxLAN-encapsulated packets. Supported VxLAN packets must have an outer IPv4 header, and contain an inner TCP/IPv4 packet. VxLAN GRO doesn't check if input packets ha

[dpdk-dev] [PATCH v4 1/2] gro: code cleanup

2018-01-04 Thread Jiayu Hu
- Remove needless check and variants - For better understanding, update the programmer guide and rename internal functions and variants - For supporting tunneled gro, move common internal functions from gro_tcp4.c to gro_tcp4.h - Comply RFC 6864 to process the IPv4 ID field Signed-off-by: Jiay

[dpdk-dev] [PATCH v4 0/2] Support VxLAN GRO

2018-01-04 Thread Jiayu Hu
VxLAN is one of the most widely used tunneled protocols. Providing GRO support for VxLAN-encapsulated packets can benefit many per-packet based applications, like Open vSwitch. This patchset is to support VxLAN GRO. The first patch cleans up current gro codes for the sake of supporting tunneled GR

Re: [dpdk-dev] [PATCH v4 1/2] net/e1000: move RSS to flow API

2018-01-04 Thread Dai, Wei
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, January 4, 2018 3:46 PM > To: dev@dpdk.org > Cc: Dai, Wei ; Zhao1, Wei > Subject: [PATCH v4 1/2] net/e1000: move RSS to flow API > > Rte_flow actually defined to include RSS, but till now, RSS is out of > rte_flow. > This patch is

Re: [dpdk-dev] [PATCH v4 2/2] net/ixgbe: move RSS to flow API

2018-01-04 Thread Dai, Wei
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, January 4, 2018 3:46 PM > To: dev@dpdk.org > Cc: Dai, Wei ; Zhao1, Wei > Subject: [PATCH v4 2/2] net/ixgbe: move RSS to flow API > > Rte_flow actually defined to include RSS, but till now, RSS is out of > rte_flow. > This patch

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2018-01-04 Thread Anoob Joseph
Hi Boris, On 12/21/2017 03:42 PM, Boris Pismenny wrote: Hi Anoob, On 12/21/2017 10:06 AM, Anoob Joseph wrote: HI Boris, On 12/20/2017 09:49 PM, Boris Pismenny wrote: Hi, On Wed, Dec 13, 2017 at 07:14:19PM, Nelio Laranjeiro wrote: Hi, On Wed, Dec 13, 2017 at 07:23:19PM +0530, Anoob Jos

Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2018-01-04 Thread Wang, Xiao W
Hi, > -Original Message- > From: Chen, Junjie J > Sent: Wednesday, December 27, 2017 1:43 AM > To: Wang, Xiao W ; y...@fridaylinux.org; > maxime.coque...@redhat.com; Bie, Tiwei > Cc: dev@dpdk.org; Chen, Junjie J > Subject: [PATCH v6] vhost: support virtqueue interrupt/notification > supp

Re: [dpdk-dev] [PATCH v3 01/10] app/testpmd: fix port configuration print

2018-01-04 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Tuesday, December 26, 2017 5:44 PM > To: Wu, Jingjing ; Yigit, Ferruh > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3 01/10] app/testpmd:

Re: [dpdk-dev] [sriov] [ixgbevf] We have to down PF and VF port to reconfig a port?

2018-01-04 Thread Sam
This is kernel ixgbevf error log: Dec 27 20:23:22 yf-mos-test-net14 kernel: [103406.865542] [ cut here ] Dec 27 20:23:22 yf-mos-test-net14 kernel: [103406.865556] WARNING: at net/sched/sch_generic.c:297 dev_watchdog+0x276/0x280() Dec 27 20:23:22 yf-mos-test-net14 kernel: [1

[dpdk-dev] [PATCH v7 1/2] net/i40e: support input set configuration

2018-01-04 Thread Beilei Xing
This patch supports getting/setting input set info for RSS/FDIR/FDIR flexible payload. Also add some helper functions for input set configuration. Signed-off-by: Beilei Xing Acked-by: Qi Zhang --- drivers/net/i40e/rte_pmd_i40e.c | 141 ++ drivers/net/i40e/r

[dpdk-dev] [PATCH v7 0/2] support input set configuration

2018-01-04 Thread Beilei Xing
The patchset adds support RSS/FDIR/FDIR flexible payload input set configuration for some pctype. v7 changes: - Add info if NIC doesn't support the function. - Add doc in testpmd_funcs.rst for the new CLIs. v6 changes: - Fix DPDK version for new private API. v5 changes: - Add DPDK version fo

[dpdk-dev] [PATCH v7 2/2] app/testpmd: add configuration for input set

2018-01-04 Thread Beilei Xing
This patch adds command to configure input set for RSS/flow director/flow director flexible payload. Signed-off-by: Beilei Xing --- app/test-pmd/cmdline.c | 239 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 ++ 2 files changed, 255 insertion

Re: [dpdk-dev] [dpdk-dev, RFC, v2] app/testpmd: add option ring-bind-lcpu to bind Q with CPU

2018-01-04 Thread Wenzhuo Lu
Hi Simon, > Currently the rx/tx queue is allocated from the buffer pool on socket of: > - port's socket if --port-numa-config specified > - or ring-numa-config setting per port > > All the above will "bind" queue to single socket per port configuration. > But it can actually archieve better perfo

Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

2018-01-04 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of zhike wang > Sent: Friday, January 5, 2018 8:54 AM > To: dev@dpdk.org > Cc: zhike wang > Subject: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel > > The max_mtu is kept as zero in case no CRT

Re: [dpdk-dev] [PATCH] app/testpmd: register a specific log type

2018-01-04 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Friday, December 8, 2017 9:19 PM > To: dev@dpdk.org; Wu, Jingjing > Subject: [dpdk-dev] [PATCH] app/testpmd: register a specific log type > > Instead of using USERx logs, register a dynam

Re: [dpdk-dev] [PATCH] app/testpmd: fix crash of txonly with multiple segments

2018-01-04 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh > Sent: Wednesday, December 27, 2017 11:52 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Yongseok Koh ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix crash of txonly with multiple > s

Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

2018-01-04 Thread 王志克
Thanks. I just changed the signed-off from wangzhike to "zhike wang". Zhike is given name, while wang is family name. Br, Zhike -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, January 04, 2018 11:16 PM To: Thomas Monjalon; Yuanhan Liu; 王志克

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue

2018-01-04 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu > Sent: Tuesday, January 2, 2018 1:36 PM > To: dev@dpdk.org > Cc: Yang, Zhiyong ; Wu, Yanglong > > Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue > > In the feature of in

[dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

2018-01-04 Thread zhike wang
The max_mtu is kept as zero in case no CRTL channel, which leads to failure when calling virtio_mtu_set(). Signed-off-by: zhike wang --- drivers/net/virtio/virtio_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev

[dpdk-dev] [PATCH] MAINTAINERS fix style

2018-01-04 Thread Stephen Hemminger
Checkpatch is complaining because the DPDK MAINTAINERS file style does not match the Linux style. Linux style is to always have a TAB (not space) after the tag. I don't care just want checkpatch to be quiet. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 1388 +--

[dpdk-dev] [RFC 3/3] net: add hyper-v network device

2018-01-04 Thread Stephen Hemminger
Add VMBUS network device PMD. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). Signed-off-by: Stephen Hemminger --- MAINTAINERS |7 + config/com

[dpdk-dev] [RFC 1/3] bus: add vmbus support

2018-01-04 Thread Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) is used on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported at present, but

[dpdk-dev] [RFC 0/3] Hyper-V bus and network device

2018-01-04 Thread Stephen Hemminger
This is preliminary support for native Hyper-V bus and network device. The code is a rewrite of earlier code done by Brocade/Vyatta with much of it coming from FreeBSD. Only Linux is supported. Stephen Hemminger (3): bus: add vmbus support usertools: add hv_uio_setup script net: add hyper-v

[dpdk-dev] [RFC 2/3] usertools: add hv_uio_setup script

2018-01-04 Thread Stephen Hemminger
From: Stephen Hemminger Small script to rebind netvsc kernel device to Hyper-V networking PMD. The existing dev_bind.py script is PCI specific and won't work with VMBUS. Signed-off-by: Stephen Hemminger --- usertools/hv_uio_setup.sh | 39 +++ 1 file changed,

Re: [dpdk-dev] [PATCH] eal/x86: move header to standard BSD license

2018-01-04 Thread Thomas Monjalon
Andi Kleen, as the original author, please could you ack? 21/12/2017 17:53, Bruce Richardson: > This updates the license on the rte_rtm.h file to be the standard > BSD-3-Clause license used for the rest of DPDK, thus bringing the file in > compliance with the DPDK licensing policy. > > Signed-off

Re: [dpdk-dev] [PATCH v2 0/5] Use SPDX tags on C files

2018-01-04 Thread Thomas Monjalon
20/12/2017 12:21, Bruce Richardson: > This contains the output of a script run to replace the BSD License with > SPDX tags on Intel copyright files. The script should only have modified > files with a single, Intel copyright on them, and ignored all files that > had multiple copyright lines. Due to

Re: [dpdk-dev] [PATCH 0/8] replace BSD headers with SPDX tags

2018-01-04 Thread Thomas Monjalon
19/12/2017 16:48, Bruce Richardson: > Similar to what was done with the .c and .h files, replace BSD license > headers on makefiles and script files which were copyright by Intel alone. > > Bruce Richardson (8): > app: add SPDX tags for Intel copyright Makefiles > tools: add SPDX tags for Inte

Re: [dpdk-dev] [PATCH V2 1/2] net/failsafe: convert to new Tx offloads API

2018-01-04 Thread Stephen Hemminger
On Thu, 4 Jan 2018 21:50:57 +0200 Moti Haimovsky wrote: > .tx_offload_capa = 0x0, > + .tx_queue_offload_capa = 0x0, > .flow_type_rss_offloads = 0x0, Minor nit you don't need to initialize every structure element. Compiler defaults everything to zero.

[dpdk-dev] [PATCH] maintainers: update mlx drivers sub tree

2018-01-04 Thread Shahaf Shuler
Mellanox PMD patches should target the next-net-mlx sub tree. Signed-off-by: Shahaf Shuler --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5a63b40c2..6a1988af5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -429,6 +429,7 @@ F: doc/guides/nics/

[dpdk-dev] [PATCH V2 2/2] net/failsafe: convert to new Rx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit adds support for the new Rx offloads API. Signed-off-by: Moti Haimovsky --- V2: * Fixed coding style warnings. --- drivers/net/failsafe/failsafe_ops.c | 38 ++

[dpdk-dev] [PATCH V2 1/2] net/failsafe: convert to new Tx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit adds support for the new Tx offloads API. Signed-off-by: Moti Haimovsky --- V2: * Fixed coding style warnings. --- drivers/net/failsafe/failsafe_ops.c | 45 ++

[dpdk-dev] [PATCH V2 0/2] net/failsafe: convert to new ethdev offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") The following commits add support the new offloads API for Tx and Rx respectively. Moti Haimovsky (2): net/failsafe: convert to

[dpdk-dev] [PATCH 2/2] net/failsafe: convert to new Rx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit adds support for the new Rx offloads API. Signed-off-by: Moti Haimovsky --- drivers/net/failsafe/failsafe_ops.c | 38 + 1 file changed, 38 ins

[dpdk-dev] [PATCH 0/2] net/failsafe: convert to new ethdev offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") The following commits add support the new offloads API for Tx and Rx respectively. Moti Haimovsky (2): net/failsafe: convert to

[dpdk-dev] [PATCH 1/2] net/failsafe: convert to new Tx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API) This commit adds support to the new Tx offloads API. Signed-off-by: Moti Haimovsky --- drivers/net/failsafe/failsafe_ops.c | 45 + 1 file changed, 45 inser

[dpdk-dev] [PATCH V3 2/2] net/tap: convert to new Rx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Moti Haimovsky --- V3: * Fixed coding style warnings V2: * Fixed coding style warnings --- drivers/net/tap/rte_eth_tap.c | 66 +++

[dpdk-dev] [PATCH V3 1/2] net/tap: convert to new Tx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Moti Haimovsky --- V3: * Fixed coding style warnings V2: * Fixed coding style warnings --- drivers/net/tap/rte_eth_tap.c | 96 +++

[dpdk-dev] [PATCH V3 0/2] net/tap: convert to new ethdev offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") The following commits add support the new offloads API for Tx and Rx respectively. Moti Haimovsky (2): net/tap: convert to new T

[dpdk-dev] [PATCH V2 2/2] net/tap: convert to new Rx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Moti Haimovsky --- drivers/net/tap/rte_eth_tap.c | 66 +-- 1 file changed, 58 insertions(+

[dpdk-dev] [PATCH V2 0/2] net/tap: convert to new ethdev offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") The following commits ass support the new offloads API for Tx and Rx. Signed-off-by: Moti Haimovsky Moti Haimovsky (2): net/ta

[dpdk-dev] [PATCH V2 1/2] net/tap: convert to new Tx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Moti Haimovsky --- drivers/net/tap/rte_eth_tap.c | 96 +-- drivers/net/tap/rte_eth_tap.h |

Re: [dpdk-dev] [PATCH v5 1/4] Introducing SPDX License Identifiers

2018-01-04 Thread Thomas Monjalon
19/12/2017 11:14, Hemant Agrawal: > The DPDK uses the Open Source BSD-3-Clause license for the core libraries > and drivers. The kernel components are naturally GPLv2 licensed. > > Many of the files in the DPDK source code contain the full text of the > applicable license. For example, most of the

[dpdk-dev] [PATCH 1/2] net/tap: convert to new Tx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Tx offloads API has changed since: commit cba7f53 ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Moti Haimovsky --- drivers/net/tap/rte_eth_tap.c | 96 +-- drivers/net/tap/rte_eth_tap.h | 1 +

[dpdk-dev] [PATCH 2/2] net/tap: convert to new Rx offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev Rx offloads API has changed since: commit ce17edd ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Moti Haimovsky --- drivers/net/tap/rte_eth_tap.c | 66 +-- 1 file changed, 58 insertions(+), 8

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2018-01-04 Thread Dumitrescu, Cristian
> -Original Message- > From: Dewar, Alan [mailto:ad7...@intl.att.com] > Sent: Thursday, January 4, 2018 1:35 PM > To: Dumitrescu, Cristian ; > 'alangordonde...@gmail.com' > Cc: 'dev@dpdk.org' ; 'Alan Dewar' > Subject: RE: [PATCH v4] sched: make RED scaling configurable > > > > > > +int

[dpdk-dev] [PATCH 0/2] net/tap: convert to new ethdev offloads API

2018-01-04 Thread Moti Haimovsky
Ethdev offloads API has changed since: commit cba7f53 ("ethdev: introduce Tx queue offloads API") commit ce17edd ("ethdev: introduce Rx queue offloads API") These commits support the new offloads API for Tx and Rx. Signed-off-by: Moti Haimovsky Moti Haimovsky (2): net/tap: convert to new Tx o

[dpdk-dev] [PATCH v2] net/i40e: do not turn on flexible payload on driver init

2018-01-04 Thread Kirill Rybalchenko
Function i40e_GLQF_reg_init() overwrites global register for flexible payload, forcing extraction of first 16 bytes of L2/L3/L4 payload to the field vector even if flexible payload is not used by an application. Such unconditional turn on of flexible payload effectively disables ability to use oute

Re: [dpdk-dev] [PATCH v4] net/mlx5: load libmlx5 and libibverbs in run-time

2018-01-04 Thread Thomas Monjalon
04/01/2018 08:36, Nélio Laranjeiro: > Hi Shachar, > > On Wed, Jan 03, 2018 at 03:00:46PM +, Shachar Beiser wrote: > > > > > --- a/config/common_base > > > > +++ b/config/common_base > > > > @@ -236,6 +236,7 @@ CONFIG_RTE_LIBRTE_MLX4_TX_MP_CACHE=8 > > > > # Compile burst-oriented Mellanox Con

Re: [dpdk-dev] [PATCH v4] net/mlx5: load libmlx5 and libibverbs in run-time

2018-01-04 Thread Thomas Monjalon
Hi, 31/12/2017 08:52, Shachar Beiser: > MLX5 PMD loads libraries: libibverbs and libmlx5. > MLX5 PMD is not linked to external libraries. > > Signed-off-by: Shachar Beiser Please better describe the change, even if it is obvious: how it is before, after and why making this change. > --- /dev/n

Re: [dpdk-dev] [PATCH] devtools: add git log checks for sctp and iova

2018-01-04 Thread Thomas Monjalon
16/12/2017 03:22, Ferruh Yigit: > Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] scripts: enhance error message in get maintainer script

2018-01-04 Thread Thomas Monjalon
14/12/2017 18:36, Ferruh Yigit: > On 12/14/2017 6:21 AM, Olivier Matz wrote: > > When the DPDK_GETMAINTAINER_PATH variable was not set, the error > > message from get-maintainer.sh was quite cheap: > > > > $ devtools/get-maintainer.sh --help > > usage: get-maintainer.sh > > Cannot exe

[dpdk-dev] [PATCH] net/mlx4: verify Tx max sges

2018-01-04 Thread Moti Haimovsky
Max number of Tx scatter-gather entries is a property of the device and is queried at init. This value was not changed in a while and most probably will not be changed in the future, Therefore and in order to enhance Tx performance, the Tx max-sge value is hardcoded in mlx4 PRM code. This patch add

Re: [dpdk-dev] [PATCH v4 5/5] app/testpmd: extend event printing

2018-01-04 Thread Thomas Monjalon
+Cc Wenzhuo and Jingjing for review, thanks 04/01/2018 17:01, Thomas Monjalon: > From: Matan Azrad > > There are new Ethernet device events - NEW and DESTROY, and new option > to register all ports by one call. > > Adjust application to aforementioned changes. > > Signed-off-by: Matan Azrad >

[dpdk-dev] [PATCH v4 4/5] ethdev: add notifications for probing and removal

2018-01-04 Thread Thomas Monjalon
When a PMD finishes probing, it creates the new port by calling the function rte_eth_dev_allocate(). A notification of the new port is sent there to the upper layer. When a PMD finishes removal of a port, it calls the function rte_eth_dev_release_port(). A notification of the destroyed port is sen

[dpdk-dev] [PATCH v4 5/5] app/testpmd: extend event printing

2018-01-04 Thread Thomas Monjalon
From: Matan Azrad There are new Ethernet device events - NEW and DESTROY, and new option to register all ports by one call. Adjust application to aforementioned changes. Signed-off-by: Matan Azrad --- v3: no change v4: no change --- app/test-pmd/parameters.c | 4 app/test-pm

[dpdk-dev] [PATCH v4 3/5] ethdev: free detached port by the dedicated function

2018-01-04 Thread Thomas Monjalon
From: Matan Azrad In the port detach function, use the function to free an ethdev port instead of changing its state directly. Signed-off-by: Matan Azrad Acked-by: Thomas Monjalon --- v2: no change v3: no change v4: no change --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 inserti

[dpdk-dev] [PATCH v4 0/5] ethdev port notifications

2018-01-04 Thread Thomas Monjalon
This patchset aims to add notifications for ethdev ports added or removed. It will be especially useful for hotplug. v2 & v3 changes: gather more patches in the series v4 change: fix a variable wraparound as in Matan's v1 Matan Azrad (3): ethdev: allow event registration for all ports ethdev:

[dpdk-dev] [PATCH v4 1/5] ethdev: remove useless parameter in callback process

2018-01-04 Thread Thomas Monjalon
The pointer to the user parameter of the callback registration is automatically pass to the callback function. There is no point to allow changing this user parameter by a caller. That's why this parameter is always set to NULL by PMDs and set only in ethdev layer before calling the callback functi

[dpdk-dev] [PATCH v4 2/5] ethdev: allow event registration for all ports

2018-01-04 Thread Thomas Monjalon
From: Matan Azrad Add option to register event callback for all ports by one call to rte_eth_dev_callback_register using port_id=RTE_ETH_ALL. In this case the callback is also registered to invalid ports. Signed-off-by: Matan Azrad Acked-by: Thomas Monjalon --- v2: - moved callback li

[dpdk-dev] [PATCH v3] net/tap: add Rx interrupts

2018-01-04 Thread Moti Haimovsky
This patch adds support for registering and waiting for Rx interrupts. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. Signed-off-by: Moti Haimovsky --- V3: Fixed coding style warnings. V2: Modifications according to inputs from Pascal Mazon * Remo

[dpdk-dev] [PATCH v2] net/tap: add Rx interrupts

2018-01-04 Thread Moti Haimovsky
This patch adds support for registering and waiting for Rx interrupts. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. Signed-off-by: Moti Haimovsky --- V2: Modifications according to inputs from Pascal Mazon * Removed unneeded counter limit check.

Re: [dpdk-dev] [PATCH 2/2] service: fix service core launch

2018-01-04 Thread Pavan Nikhilesh
Hi Harry, On Wed, Dec 20, 2017 at 11:21:47AM +, Harry van Haaren wrote: > diff --git a/test/test/test_service_cores.c b/test/test/test_service_cores.c > index 311c704..43f2318 100644 > --- a/test/test/test_service_cores.c > +++ b/test/test/test_service_cores.c > @@ -348,6 +348,7 @@ service_lco

Re: [dpdk-dev] [PATCH 1/2] service: fix del to reset lcore role to rte

2018-01-04 Thread Pavan Nikhilesh
Hi Harry, Comments inline. On Wed, Dec 20, 2017 at 11:21:46AM +, Harry van Haaren wrote: > This patch fixes the reset of the service core, > that when rte_service_lcore_del() is called, the > lcore_role is restored to RTE. > > This issue was reported as when running the unit tests, an > error

Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

2018-01-04 Thread Maxime Coquelin
Hi, On 11/12/2017 07:45 PM, Thomas Monjalon wrote: 07/11/2017 04:44, Yuanhan Liu: On Wed, Oct 25, 2017 at 08:09:06PM -0700, wangzhike wrote: The max_mtu is kept as zero in case no CRTL channel, which leads to failure when calling virtio_mtu_set(). Signed-off-by: wangzhike Acked-by: Yuanhan

[dpdk-dev] [PATCH v2] net/failsafe: add Rx interrupts

2018-01-04 Thread Moti Haimovsky
This patch adds support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single device to be handled by the application while inte

Re: [dpdk-dev] [PATCH 1/2] eal/arm64: modify I/O device memory barriers

2018-01-04 Thread Jerin Jacob
-Original Message- > Date: Tue, 26 Dec 2017 20:28:23 -0800 > From: Yongseok Koh > To: adrien.mazarg...@6wind.com, nelio.laranje...@6wind.com, > jerin.ja...@caviumnetworks.com, jianbo@arm.com > CC: dev@dpdk.org, Yongseok Koh , Thomas Speier > > Subject: [PATCH 1/2] eal/arm64: modify

Re: [dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2018-01-04 Thread Neil Horman
On Sat, Dec 30, 2017 at 12:15:17PM -0500, Neil Horman wrote: > On Tue, Dec 12, 2017 at 02:07:52PM +, Bruce Richardson wrote: > > On Mon, Dec 11, 2017 at 02:36:15PM -0500, Neil Horman wrote: > > > Hey all- > > > A few days ago, I was lamenting the fact that, when reviewing patches I > > > woul

[dpdk-dev] Anybody knows what "i40e_dev_interrupt_handler(): ICR0: malicious programming detected" means?

2018-01-04 Thread Yang, Yi Y
Hi, all I found DPDK 17.11 has the below error information when I run OpenContrail which uses KNI and 25G NIC by DPDK. 2018-01-03 22:47:09,278 i40e_dev_interrupt_handler(): ICR0: malicious programming detected 2018-01-03 22:50:37,397 KNI: Out of memory 2018-01-03 22:50:37,805 KNI: Out of memory

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx4: convert to new Tx offloads API

2018-01-04 Thread Shahaf Shuler
Hi Adrien and Nelio, See below comment regarding your output on the offload check. Rest of the comments were accepted. Wednesday, January 3, 2018 7:29 PM, Adrien Mazarguil : [...] > > > +{ > > + uint64_t port_offloads = priv->dev->data- > >dev_conf.txmode.offloads; > > + uint64_t port_supp

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: improve packet type parser

2018-01-04 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, January 4, 2018 6:46 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Chilikin, Andrey > > Subject: [PATCH v3 2/2] net/i40e: improve packet type parser > > Add support for PPPoE and L2TP packet types parser. > Change pa

[dpdk-dev] [RFC v2] doc compression API for DPDK

2018-01-04 Thread Verma, Shally
This is an RFC v2 document to brief understanding and requirements on compression API proposal in DPDK. It is based on "[RFC v3] Compression API in DPDK http://dpdk.org/dev/patchwork/patch/32331/ ". Intention of this document is to align on concepts built into compression API, its usage and iden

[dpdk-dev] [PATCH] mempool/octeontx: use smp instead of io barrier

2018-01-04 Thread Pavan Nikhilesh
Use smp barrier instead of IO barrier when sending mbox request as the write has to be reflected between cores not IO devices. Signed-off-by: Pavan Nikhilesh --- drivers/mempool/octeontx/octeontx_mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/octeontx/

Re: [dpdk-dev] [PATCH v4 3/3] net/virtio: support GUEST ANNOUNCE

2018-01-04 Thread Tiwei Bie
On Thu, Jan 04, 2018 at 07:59:38AM -0800, Xiao Wang wrote: [...] > +static void > +virtio_notify_peers(struct rte_eth_dev *dev) > +{ > + struct virtio_hw *hw = dev->data->dev_private; > + struct virtnet_tx *txvq = dev->data->tx_queues[0]; > + struct virtnet_rx *rxvq = dev->data->rx_queu

[dpdk-dev] [PATCH v3 1/2] mbuf: add PPPoE and L2TP packet types

2018-01-04 Thread Beilei Xing
Add support of PPPoE and L2TP packet types. Signed-off-by: Beilei Xing Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib/librte_mbuf/rte_mbuf_ptype.h | 26 ++ 2 files changed, 28 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf_ptype.c b/lib/li

[dpdk-dev] [PATCH v3 0/2] support PPPoE and L2TP packet types

2018-01-04 Thread Beilei Xing
v3 changes: - reword commit log v2 changes: - change patch title - rework ptype parser according to new profile meta data Beilei Xing (2): mbuf: add PPPoE and L2TP packet types net/i40e: improve packet type parser drivers/net/i40e/i40e_ethdev.c | 83 +---

[dpdk-dev] [PATCH v3 2/2] net/i40e: improve packet type parser

2018-01-04 Thread Beilei Xing
Add support for PPPoE and L2TP packet types parser. Change parser as new metadata 'OIPV4' and 'OIPV6' added in profile to distinguish outer IP and inner IP. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 83 ++ 1 file changed, 60 insertion

[dpdk-dev] [PATCH] test: fix flow classify test

2018-01-04 Thread Bernard Iremonger
Remove the requirement to have a port bound to igb_uio in order to run this test suite. Fixes: 9c9befea4f57 ("test: add flow classify unit tests") Reported by: Anatoly Burakov Signed-off-by: Bernard Iremonger --- test/test/test_flow_classify.c | 5 + 1 file changed, 1 insertion(+), 4 delet

[dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags

2018-01-04 Thread Qiming Yang
Detail the comment for RSS offload types and added comments for each type. Signed-off-by: Qiming Yang --- lib/librte_ether/rte_ethdev.h | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h

Re: [dpdk-dev] [PATCH v4] arch/arm: optimization for memcpy on AArch64

2018-01-04 Thread Herbert Guan
Thanks for review and comments, Jerin. A new version has been sent out for review with your comments applied and Acked-by added. Best regards, Herbert > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, January 3, 2018 21:35 > To: Herbert

[dpdk-dev] [PATCH v5] arch/arm: optimization for memcpy on AArch64

2018-01-04 Thread Herbert Guan
This patch provides an option to do rte_memcpy() using 'restrict' qualifier, which can induce GCC to do optimizations by using more efficient instructions, providing some performance gain over memcpy() on some AArch64 platforms/enviroments. The memory copy performance differs between different AAr

Re: [dpdk-dev] [PATCH v2 5/7] net/mlx5: convert to new Rx offloads API

2018-01-04 Thread Nelio Laranjeiro
Hi Shahaf, Please see bellow, On Wed, Jan 03, 2018 at 09:16:15AM +0200, Shahaf Shuler wrote: > Ethdev Rx offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > > This commit support the new Rx offloads API. > > Signed-off-by: Shahaf Shuler > Acke

Re: [dpdk-dev] [PATCH 5/6] bus/dpaa2: add flag to configure DCA in QBMAN multi Tx

2018-01-04 Thread Nipun Gupta
Sent this particular patch by mistake. Please ignore. I have rejected this patch in the patchworks. Thanks, Nipun > -Original Message- > From: Nipun Gupta [mailto:nipun.gu...@nxp.com] > Sent: Thursday, January 04, 2018 21:36 > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; Hemant

[dpdk-dev] [PATCH 6/6] net/dpaa2: support atomic queues

2018-01-04 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/Makefile | 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 7 +++ drivers/net/dpaa2/dpaa2_ethdev.h | 5 + drivers/net/dpaa2/dpaa2_rxtx.c | 43 +--- 4 files changed, 53 insertions(+), 3 deletions(-) di

[dpdk-dev] [PATCH 5/6] bus/fslmc: add flag to configure DCA in QBMAN multi Tx

2018-01-04 Thread Nipun Gupta
With the current QBMAN multi-tx API, we need to create separate enqueue descriptors for each of the packet which is required to be enqueued to the hardware, once we support Atomic Queues (with DCA) in dpaa2 drivers. Creating enqueue descriptor for each packet is costly and have significant performa

[dpdk-dev] [PATCH 3/6] event/dpaa2: use dqrr index to cosume the DQRR entry

2018-01-04 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index c6dc5a2..23727f0 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/dri

[dpdk-dev] [PATCH 5/6] bus/dpaa2: add flag to configure DCA in QBMAN multi Tx

2018-01-04 Thread Nipun Gupta
With the current QBMAN multi-tx API, we need to create separate enqueue descriptors for each of the packet which is required to be enqueued to the hardware, once we support Atomic Queues (with DCA) in dpaa2 drivers. Creating enqueue descriptor for each packet is costly and have significant performa

[dpdk-dev] [PATCH 4/6] event/dpaa2: have separate structure to hold dqrr entries

2018-01-04 Thread Nipun Gupta
This patch provides cleaner approach to store the DQRR entries, which are yet to be consumed in case of atomic queues. Also, this patch changes the storage of the DQRR entry index into the mbuf->seqn instead of ev->opaque Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/fslmc_bus.c

[dpdk-dev] [PATCH 2/6] bus/fslmc: introduce API to consume dqrr using index

2018-01-04 Thread Nipun Gupta
A new API qbman_swp_dqrr_idx_consume is defined which takes input as DQRR index to consume corresponding DQRR entry. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 7 +++ drivers/bus/fslmc/qbman/qbman_portal.c | 7 +++ drivers/bus/fslmc/rt

[dpdk-dev] [PATCH 0/6] support atomic queues in dpaa2 ethernet with eventdev

2018-01-04 Thread Nipun Gupta
This patch series supports atomic queues in DPAA2 Ethernet driver with eventdev. Also other changes such as dynamic logging is supported with these changes. Patch 1 - support dynamic logging in eventdev Patch 2,3,4 - Cleanups and performance enhancement for eventdev Patch 5,6 - support atomic queu

[dpdk-dev] [PATCH 1/6] event/dpaa2: replace static with dynamic logging

2018-01-04 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 83 --- drivers/event/dpaa2/dpaa2_eventdev.h | 12 - drivers/event/dpaa2/dpaa2_eventdev_logs.h | 37 ++ drivers/event/dpaa2/dpaa2_hw_dpcon.c | 1 + 4 files changed, 82

Re: [dpdk-dev] [PATCH v2] test: new sched WRR unit-test

2018-01-04 Thread Dewar, Alan
Hi Cristian, In response to your comment at the very end, "Please keep the unit test in the same patch set with the code", any revised change will include the new unit-tests. Regards Alan > -Original Message- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent:

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2018-01-04 Thread Dewar, Alan
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Tuesday, January 02, 2018 4:44 PM > To: alangordonde...@gmail.com > Cc: dev@dpdk.org; Alan Dewar > Subject: RE: [PATCH v4] sched: make RED scaling configurable > > Hi Alan, > > T

Re: [dpdk-dev] [PATCH v2] sched: fix overflow errors in WRR weighting code

2018-01-04 Thread Dewar, Alan
Hi Cristian, Responses in-line below... > -Original Message- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Tuesday, January 02, 2018 4:14 PM > To: alangordonde...@gmail.com > Cc: dev@dpdk.org; Alan Dewar > Subject: RE: [PATCH v2] sched: fix overflow errors

Re: [dpdk-dev] [RFC PATCH 0/3] ethdev: few changes in rte_ethdev layer

2018-01-04 Thread Jerin Jacob
-Original Message- > Date: Wed, 20 Dec 2017 18:23:46 + > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: "dev@dpdk.org" , "shah...@mellanox.com" > > Subject: RE: [dpdk-dev] [RFC PATCH 0/3] ethdev: few changes in rte_ethdev > layer > Hi Konstantin, > > > > > > > 2. Make it s

Re: [dpdk-dev] [PATCH] app/testpmd: add eth peer CLI command

2018-01-04 Thread Wisam Monther
+Raslan. BRs, Wisam Jaddo -Original Message- From: Wisam Jaddo [mailto:wis...@mellanox.com] Sent: Monday, December 25, 2017 2:43 PM To: jingjing...@intel.com Cc: dev@dpdk.org; Ori Kam; Wisam Monther; Shahaf Shuler Subject: [PATCH] app/testpmd: add eth peer CLI command This command will

Re: [dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions

2018-01-04 Thread Nelio Laranjeiro
On Wed, Jan 03, 2018 at 07:21:58AM -0800, Stephen Hemminger wrote: > On Wed, 3 Jan 2018 08:35:23 +0100 > Nelio Laranjeiro wrote: > > > Hi Stephen, > > > > On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > > > Since wait_to_complete is unused, don't pass it to helper functions.

  1   2   >