Re: [dpdk-dev] Your next patch "net/virtio: fix an incorrect behavior..."

2017-12-05 Thread Yuanhan Liu
Thanks for the remind! I have reverted it. --yliu On Wed, Dec 06, 2017 at 03:11:48PM +0800, Tiwei Bie wrote: > Hi Yuanhan, > > Thanks for Antonio's reminder! > > Below patch may break vector Rx in some cases [1]. > > http://dpdk.org/browse/dpdk-stable/commit/drivers/net/virtio?h=17.08&

Re: [dpdk-dev] [PATCH v3 1/2] lib/security: add support for get metadata

2017-12-05 Thread Anoob
Hi Akhil, Radu, Please see inline. Thanks, Anoob On 11/24/2017 05:33 PM, Akhil Goyal wrote: On 11/24/2017 5:29 PM, Radu Nicolau wrote: On 11/24/2017 11:34 AM, Akhil Goyal wrote: Hi Radu, On 11/24/2017 4:47 PM, Radu Nicolau wrote: On 11/24/2017 10:55 AM, Akhil Goyal wrote: On 11/24/20

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix flow type for allmulti rules

2017-12-05 Thread Shahaf Shuler
Tuesday, December 5, 2017 11:57 AM, Nelio Laranjeiro: > On Tue, Dec 05, 2017 at 11:37:50AM +0200, Raslan Darawsheh wrote: > > Chnaged ibv_flow_attr type for allmulti rule to > > IBV_FLOW_ATTR_MC_DEFAULT instead of IBV_FLOW_ATTR_NORMAL, in > case allmulti was enabled. > > > > Fixes: 272733b5 ("net/m

Re: [dpdk-dev] [PATCH] net/mlx4: revert workaround for broken Verbs

2017-12-05 Thread Shahaf Shuler
Monday, December 4, 2017 6:53 PM, Adrien Mazarguil: > On Wed, Nov 29, 2017 at 09:21:26AM +, Matan Azrad wrote: > > This workaround was needed to properly handle device removal with old > > Mellanox OFED releases that are not supported by this PMD anymore. > > > > Starting from rdma-core v16 thi

Re: [dpdk-dev] [PATCH v2 06/10] net/virtio: fix queue setup consistency

2017-12-05 Thread Tiwei Bie
Hi Maxime and Olivier: On Thu, Sep 07, 2017 at 02:13:43PM +0200, Olivier Matz wrote: [...] > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index 8eee3ff80..c7888f103 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethd

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2017-12-05 Thread Wei Wang
On 12/05/2017 10:08 PM, Yuanhan Liu wrote: On Tue, Dec 05, 2017 at 06:59:26AM +, Yang, Zhiyong wrote: Hi all, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang Sent: Thursday, November 30, 2017 5:47 PM To: dev@dpdk.org; y...@fridaylinux.org; maxim

Re: [dpdk-dev] The limitation of VHOST_MEMORY_MAX_NREGIONS in virtio-user with vhost-user backend

2017-12-05 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Tuesday, December 5, 2017 10:42 PM > To: Wang, Wei 5. (NSB - CN/Hangzhou) > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: Re: [dpdk-dev] The limitation of VHOST_MEMORY_MAX_NREGIONS > in virtio-user with vhost-user

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-05 Thread Tan, Jianfeng
On 12/1/2017 8:36 AM, Thomas Monjalon wrote: The scan callback allows to spawn a vdev automatically given some custom scan rules. It is especially useful to create a TAP device automatically connected to a netdevice as remote. Signed-off-by: Thomas Monjalon --- warning: to be tested --- dri

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-05 Thread Tan, Jianfeng
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, December 5, 2017 11:21 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org > Subject: Re: [PATCH] bus/vdev: add custom scan hook > > 05/12/2017 14:56, Tan, Jianfeng: > > > > On 12/5/2017 4:41 PM, Thomas Monjalon wrote: > > > > > > 05/12/2

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Ananyev, Konstantin
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, December 5, 2017 3:50 PM > To: Ananyev, Konstantin > Cc: Matan Azrad ; Neil Horman ; > Gaëtan Rivet ; Wu, > Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership > > 05/12/2017 16:13

[dpdk-dev] [PATCH 2/2] lib: optimize _xstats_by_ids APIs

2017-12-05 Thread Elza Mathew
Introduced a check to detect if the stats IDs being requested are all basic stats IDs. In that case, ensured that only the basic stats would be retrieved. Previously, both basic stats and xstats were being retrieved even if all the IDs were basic stats IDs. Signed-off-by: Elza Mathew --- lib/lib

[dpdk-dev] [PATCH 1/2] lib: refactor basic stats code

2017-12-05 Thread Elza Mathew
Moved the code to get the basic stats names and values into static functions. Signed-off-by: Elza Mathew --- lib/librte_ether/rte_ethdev.c | 156 -- 1 file changed, 91 insertions(+), 65 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_

Re: [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO

2017-12-05 Thread Patil, Harish
-Original Message- From: Shahaf Shuler Date: Monday, December 4, 2017 at 10:05 PM To: Ferruh Yigit , "Mody, Rasesh" , "dev@dpdk.org" Cc: Harish Patil , Dept-Eng DPDK Dev Subject: RE: [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO >Tuesday, December 5, 2017 1

Re: [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO

2017-12-05 Thread Patil, Harish
-Original Message- From: Ferruh Yigit Date: Monday, December 4, 2017 at 3:25 PM To: "Mody, Rasesh" , "dev@dpdk.org" Cc: Harish Patil , Dept-Eng DPDK Dev Subject: Re: [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO >On 11/24/2017 12:35 PM, Rasesh Mody wrote: >

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Neil Horman
On Tue, Dec 05, 2017 at 06:08:35AM +, Matan Azrad wrote: > > Please look at the code again, secondary process cannot take ownership, I > don't allow it! > Actually, I think it must not be like that as no limitation for that in any > other ethdev configurations. > Sure you do. Consider the f

Re: [dpdk-dev] [PATCH] maintainers: claim co maintainership of docs

2017-12-05 Thread Mcnamara, John
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, December 5, 2017 3:22 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Kovacevic, Marko > > Subject: [PATCH] maintainers: claim co maintainership of docs > > Signed-off-by: Marko Kovacevic Welcome aboard. :-) Acked-by: John M

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-05 Thread Adrien Mazarguil
On Tue, Dec 05, 2017 at 04:28:00PM +0100, Thomas Monjalon wrote: > 05/12/2017 14:58, Yuanhan Liu: > > On Tue, Dec 05, 2017 at 02:20:05PM +0100, Thomas Monjalon wrote: > > > 05/12/2017 12:04, Adrien Mazarguil: > > > > > > > Hi Yuanhan, > > > > > > > > > > > > > > On Mon, Dec 04, 2017 at 09:55:31P

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Thomas Monjalon
05/12/2017 16:13, Ananyev, Konstantin: > > Hi Thomas, > > > Hi, > > > I will give my view on locking and synchronization in a different email. > > Let's discuss about the API here. > > > 05/12/2017 12:12, Ananyev, Konstantin: > > >> From: Matan Azrad [mailto:ma...@mellanox.com] > >> > From: A

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-05 Thread Thomas Monjalon
05/12/2017 14:58, Yuanhan Liu: > On Tue, Dec 05, 2017 at 02:20:05PM +0100, Thomas Monjalon wrote: > > 05/12/2017 12:04, Adrien Mazarguil: > > > > > Hi Yuanhan, > > > > > > > > > > On Mon, Dec 04, 2017 at 09:55:31PM +0800, Yuanhan Liu wrote: > > > > rte_devargs is identified by the name (pci id f

[dpdk-dev] [PATCH] maintainers: claim co maintainership of docs

2017-12-05 Thread Marko Kovacevic
Signed-off-by: Marko Kovacevic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..3ed7eb8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -36,6 +36,7 @@ M: maintain...@dpdk.org Documentation (with overlaps) M: John McNamara +M: Marko Ko

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-05 Thread Thomas Monjalon
05/12/2017 14:56, Tan, Jianfeng: > > On 12/5/2017 4:41 PM, Thomas Monjalon wrote: > > > > 05/12/2017 09:27, Tan, Jianfeng: > > > > > > > > > > On 12/4/2017 5:31 PM, Thomas Monjalon wrote: > > > > > > > > > > > > The hook is in bus->scan(). > > > > > > I think we should launch a bus scan when there

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Ananyev, Konstantin
Hi Thomas, > Hi,   > I will give my view on locking and synchronization in a different email. > Let's discuss about the API here.   > 05/12/2017 12:12, Ananyev, Konstantin: > >> From: Matan Azrad [mailto:ma...@mellanox.com] >> > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com]   >

Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload

2017-12-05 Thread Maxime Coquelin
On 11/21/2017 07:56 AM, Jiayu Hu wrote: In virtio, UDP Fragmentation Offload (UFO) includes two parts: host UFO and guest UFO. Guest UFO means the frontend can receive large UDP packets, and host UFO means the backend can receive large UDP packets. This patch supports host UFO and guest UFO for

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Ananyev, Konstantin
>> Just forgot to mention - I don' think it is good idea to disallow secondary >> process to set theowner.   >I think we all agree on that. >My initial suggestion was to use the ownership in secondary processes. >I think Matan forbid it as a first step because there is no >multi-process synchroni

Re: [dpdk-dev] [PATCH v2 4/4] vhost: destroy unused virtqueues when multiqueue not negotiated

2017-12-05 Thread Maxime Coquelin
Hi Laszlo, On 12/05/2017 03:40 PM, Laszlo Ersek wrote: Hi Maxime, On 12/05/17 09:34, Maxime Coquelin wrote: QEMU sends VHOST_USER_SET_VRING_CALL requests for all queues declared in QEMU command line before the guest is started. It has the effect in DPDK vhost-user backend to allocate vrings fo

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Bruce Richardson
On Tue, Dec 05, 2017 at 12:53:36PM +0100, Thomas Monjalon wrote: > 05/12/2017 12:44, Ananyev, Konstantin: > > Just forgot to mention - I don' think it is good idea to disallow secondary > > process to set theowner. > > I think we all agree on that. > My initial suggestion was to use the ownershi

Re: [dpdk-dev] The limitation of VHOST_MEMORY_MAX_NREGIONS in virtio-user with vhost-user backend

2017-12-05 Thread Yuanhan Liu
On Tue, Dec 05, 2017 at 06:58:53AM +, Wang, Wei 5. (NSB - CN/Hangzhou) wrote: > > > Hi, all > > In DPDK document, it it described that Virtio in containers Cannot work when > there are more than VHOST_MEMORY_MAX_NREGIONS(8) hugepages. In another word, > do not use 2MB hugepage so far. Do

Re: [dpdk-dev] [PATCH v2 4/4] vhost: destroy unused virtqueues when multiqueue not negotiated

2017-12-05 Thread Laszlo Ersek
Hi Maxime, On 12/05/17 09:34, Maxime Coquelin wrote: > QEMU sends VHOST_USER_SET_VRING_CALL requests for all queues > declared in QEMU command line before the guest is started. > It has the effect in DPDK vhost-user backend to allocate vrings > for all queues declared by QEMU. > > If the first dr

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2017-12-05 Thread Maxime Coquelin
On 12/05/2017 03:19 PM, Yuanhan Liu wrote: On Tue, Nov 28, 2017 at 01:09:29PM +0100, Maxime Coquelin wrote: On 11/15/2017 12:41 PM, Jianfeng Tan wrote: In a running VM, operations (like device attach/detach) will trigger the QEMU to resend set_mem_table to vhost-user backend. DPDK vhost-us

Re: [dpdk-dev] [PATCH 2/2] net/virtio: support GUEST ANNOUNCE

2017-12-05 Thread Yuanhan Liu
On Thu, Nov 30, 2017 at 02:41:12AM +, Wang, Xiao W wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > > Sent: Monday, November 27, 2017 8:49 PM > > To: Wang, Xiao W > > Cc: dev@dpdk.org > > Subject: Re: [PATCH 2/2] net/virtio: support GUEST ANNOUN

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2017-12-05 Thread Yuanhan Liu
On Tue, Nov 28, 2017 at 01:09:29PM +0100, Maxime Coquelin wrote: > > > On 11/15/2017 12:41 PM, Jianfeng Tan wrote: > >In a running VM, operations (like device attach/detach) will > >trigger the QEMU to resend set_mem_table to vhost-user backend. > > > >DPDK vhost-user handles this message rudely

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2017-12-05 Thread Yuanhan Liu
On Tue, Dec 05, 2017 at 06:59:26AM +, Yang, Zhiyong wrote: > Hi all, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > > Sent: Thursday, November 30, 2017 5:47 PM > > To: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com > > C

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-05 Thread Yuanhan Liu
On Tue, Dec 05, 2017 at 02:20:05PM +0100, Thomas Monjalon wrote: > 05/12/2017 12:04, Adrien Mazarguil: > > > Hi Yuanhan, > > > > > > On Mon, Dec 04, 2017 at 09:55:31PM +0800, Yuanhan Liu wrote: > > > rte_devargs is identified by the name (pci id for pci device). It also > > > includes other driv

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-05 Thread Tan, Jianfeng
On 12/5/2017 4:41 PM, Thomas Monjalon wrote: 05/12/2017 09:27, Tan, Jianfeng: > > On 12/4/2017 5:31 PM, Thomas Monjalon wrote: > > > > The hook is in bus->scan(). > > I think we should launch a bus scan when there is a new device event. > > That's what I'm trying to say. We finally need

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-05 Thread Thomas Monjalon
05/12/2017 12:04, Adrien Mazarguil: > Hi Yuanhan, > > On Mon, Dec 04, 2017 at 09:55:31PM +0800, Yuanhan Liu wrote: > > rte_devargs is identified by the name (pci id for pci device). It also > > includes other driver specific key-value options. It's not clear for the > > user to know which one (or

Re: [dpdk-dev] [PATCH] maintainers: claim responsibility for virtio PMD

2017-12-05 Thread Yuanhan Liu
On Fri, Dec 01, 2017 at 08:06:04PM +0800, Yuanhan Liu wrote: > On Fri, Dec 01, 2017 at 07:04:35PM +0800, Tiwei Bie wrote: > > Add myself as co-maintainer for virtio driver. > > > > Signed-off-by: Tiwei Bie > > --- > > Hi Yuanhan and Maxime, > > > > As there will be more and more virtio related s

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Thomas Monjalon
05/12/2017 12:44, Ananyev, Konstantin: > Just forgot to mention - I don' think it is good idea to disallow secondary > process to set theowner. I think we all agree on that. My initial suggestion was to use the ownership in secondary processes. I think Matan forbid it as a first step because the

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Thomas Monjalon
Hi, I will give my view on locking and synchronization in a different email. Let's discuss about the API here. 05/12/2017 12:12, Ananyev, Konstantin: > From: Matan Azrad [mailto:ma...@mellanox.com] > > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > > > If the goal is just to h

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Tuesday, December 5, 2017 11:12 AM > To: Matan Azrad ; Neil Horman ; > Gaëtan Rivet > Cc: Thomas Monjalon ; Wu, Jingjing > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev

[dpdk-dev] [PATCH v2] virtio_net: kick guest even when virtio queue is full

2017-12-05 Thread Agota Benyhe
From: Patrik Andersson R Changing the vring call file descriptor during virtio device enqueue operation may lead to "kick" on a file descriptor that is closed. As a consequence the guest might not be notified of new packets in the enqueue. The suggested change will add some extra load on DPDK an

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Ananyev, Konstantin
Hi Matan, > -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Sunday, December 3, 2017 1:47 PM > To: Ananyev, Konstantin ; Neil Horman > ; Gaëtan Rivet > > Cc: Thomas Monjalon ; Wu, Jingjing > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/5] ethdev: add port

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-05 Thread Adrien Mazarguil
Hi Yuanhan, On Mon, Dec 04, 2017 at 09:55:31PM +0800, Yuanhan Liu wrote: > On Fri, Dec 01, 2017 at 10:47:50AM +0100, Gaëtan Rivet wrote: > > On Thu, Nov 30, 2017 at 10:44:58PM +0100, Thomas Monjalon wrote: > > > 30/11/2017 22:21, Stephen Hemminger: > > > > On Thu, 30 Nov 2017 18:35:11 +0100 > > >

Re: [dpdk-dev] [PATCH 2/3] lib/librte_flow_classy: add run api for flow classification

2017-12-05 Thread Iremonger, Bernard
Hi Jasvinder, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Iremonger, Bernard > Sent: Monday, December 4, 2017 4:46 PM > To: Singh, Jasvinder ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/3] lib/librte_flow_classy: add run api for > flow > classification

Re: [dpdk-dev] [PATCH 1/3] lib/librte_flow_classify: remove table id parameter from apis

2017-12-05 Thread Iremonger, Bernard
Hi Jasvinder, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Iremonger, Bernard > Sent: Monday, December 4, 2017 4:45 PM > To: Singh, Jasvinder ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] lib/librte_flow_classify: remove table id > parameter from apis

Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk

2017-12-05 Thread Hemant Agrawal
On 12/4/2017 9:25 PM, Neil Horman wrote: Received a note the other day from the Linux Foundation governance board for DPDK indicating that several files I have copyright on need to be relicensed to be compliant with the DPDK licensing guidelines. I have some concerns with some parts of the reque

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-05 Thread Bruce Richardson
On Tue, Dec 05, 2017 at 06:08:35AM +, Matan Azrad wrote: > Hi Neil > > > -Original Message- From: Neil Horman > > [mailto:nhor...@tuxdriver.com] Sent: Tuesday, December 5, 2017 12:31 > > AM To: Matan Azrad Cc: Ananyev, Konstantin > > ; Gaëtan Rivet > > ; Thomas Monjalon ; Wu, > > Jing

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix flow type for allmulti rules

2017-12-05 Thread Nelio Laranjeiro
On Tue, Dec 05, 2017 at 11:37:50AM +0200, Raslan Darawsheh wrote: > Chnaged ibv_flow_attr type for allmulti rule to IBV_FLOW_ATTR_MC_DEFAULT > instead of IBV_FLOW_ATTR_NORMAL, in case allmulti was enabled. > > Fixes: 272733b5 ("net/mlx5: use flow to enable unicast traffic") > > Signed-off-by: Ras

[dpdk-dev] [PATCH v3 7/7] net/mrvl: update MRVL NET PMD documentation

2017-12-05 Thread Tomasz Duszynski
Update MRVL NET PMD documentation. Signed-off-by: Tomasz Duszynski Acked-by: Jianbo Liu --- doc/guides/nics/mrvl.rst | 69 +++- 1 file changed, 45 insertions(+), 24 deletions(-) diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst index f

[dpdk-dev] [PATCH v3 4/7] net/mrvl: check if ppio is initialized

2017-12-05 Thread Tomasz Duszynski
Uninitialized ppio cannot be passed to MUSDK library routines as application will crash. Fix this by first checking whether ppio has been initialized. Signed-off-by: Tomasz Duszynski Acked-by: Jianbo Liu --- drivers/net/mrvl/mrvl_ethdev.c | 42 ++ 1 file

[dpdk-dev] [PATCH v3 3/7] net/mrvl: do not enable port after setting MAC address

2017-12-05 Thread Tomasz Duszynski
Setting enabled port's mac address caused it to stop receiving packets. Now as that issue is fixed in library renabling port is no longer necessary. Signed-off-by: Tomasz Duszynski Acked-by: Jianbo Liu --- drivers/net/mrvl/mrvl_ethdev.c | 15 +++ 1 file changed, 7 insertions(+), 8 d

[dpdk-dev] [PATCH v3 6/7] devtools/test-build: add MRVL NET PMD to test-build

2017-12-05 Thread Tomasz Duszynski
Add MRVL NET PMD to test build tool. Signed-off-by: Tomasz Duszynski Acked-by: Jianbo Liu --- devtools/test-build.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 092d3a7..b551764 100755 --- a/devtools/test-build.sh +++ b/devtools/te

[dpdk-dev] [PATCH v3 5/7] net/mrvl: add extra error logs

2017-12-05 Thread Tomasz Duszynski
Add extra error logs in a few places. Signed-off-by: Tomasz Duszynski Acked-by: Jianbo Liu --- drivers/net/mrvl/mrvl_ethdev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c index 40f2ead..127ce44

[dpdk-dev] [PATCH v3 2/7] net/mrvl: query link status using library API

2017-12-05 Thread Tomasz Duszynski
Up to now link status was updated unconditionally during link_up()/link_down() calls thus one was never sure about it's true status. Using dedicated library api makes sure the true link status is set. Signed-off-by: Tomasz Duszynski Acked-by: Jianbo Liu --- drivers/net/mrvl/mrvl_ethdev.c | 16

[dpdk-dev] [PATCH v3 0/7] Sync with MUSDK-17.10

2017-12-05 Thread Tomasz Duszynski
This patchset brings following changes: o Sync with MUSDK-17.10. Latest version of the library comes with many improvements and fixes thus switching to it is beneficial. o A few code and documentation updates. Changes since v2: o Fix NET PMD conditional compilation in test-build.sh Changes si

[dpdk-dev] [PATCH v3 1/7] net/mrvl: sync compilation with musdk-17.10

2017-12-05 Thread Tomasz Duszynski
Followig changes are needed to switch to musdk-17.10: - With a new version of the musdk library it's no longer necessary to explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT and CONF_PP2_BPOOL_COOKIE_SIZE. Proper defines are autogenerated by ./configure script based on passed options and ava

[dpdk-dev] [PATCH v1] net/mlx5: fix flow type for allmulti rules

2017-12-05 Thread Raslan Darawsheh
Chnaged ibv_flow_attr type for allmulti rule to IBV_FLOW_ATTR_MC_DEFAULT instead of IBV_FLOW_ATTR_NORMAL, in case allmulti was enabled. Fixes: 272733b5 ("net/mlx5: use flow to enable unicast traffic") Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_flow.c | 13 + 1 file ch

[dpdk-dev] [PATCH] virtio_net: kick guest even when virtio queue is full

2017-12-05 Thread Agota Benyhe
From: Patrik Andersson R Changing the vring call file descriptor during virtio device enqueue operation may lead to "kick" on a file descriptor that is closed. As a consequence the guest might not be notified of new packets in the enqueue. The suggested change will add some extra load on DPDK an

Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-12-05 Thread Fischetti, Antonio
> -Original Message- > From: Bie, Tiwei > Sent: Tuesday, December 5, 2017 3:12 AM > To: Fischetti, Antonio > Cc: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com; > jfreim...@redhat.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behav

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-05 Thread Thomas Monjalon
05/12/2017 09:27, Tan, Jianfeng: > > On 12/4/2017 5:31 PM, Thomas Monjalon wrote: > > > > The hook is in bus->scan(). > > I think we should launch a bus scan when there is a new device event. > > That's what I'm trying to say. We finally need to execute a handler as > of a device event to finish

[dpdk-dev] [PATCH] net/i40e: exclude LLDP packet count

2017-12-05 Thread Qi Zhang
When use port stats register to calcuate the packet count, LLDP packets are counted in statistics which is not expected, the patch exclude this number from total number. Fixes: 763de290cbd1 ("net/i40e: fix packet count for PF") Cc sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/i4

Re: [dpdk-dev] [PATCH 6/7] devtools/test-build: add MRVL NET PMD to test-build

2017-12-05 Thread Tomasz Duszynski
On Mon, Dec 04, 2017 at 04:48:51PM -0800, Ferruh Yigit wrote: > On 12/1/2017 7:19 AM, Tomasz Duszynski wrote: > > Add MRVL NET PMD to test build tool. > > > > Signed-off-by: Tomasz Duszynski > > --- > > devtools/test-build.sh | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/devtools

[dpdk-dev] DPDK Amazon AWS ENA driver problem with ping

2017-12-05 Thread Jordan Rhody
Hi, I have been testing the DPDK ENA driver and am hoping that someone can help in assisting an observation I have. Using the DPDK ENA driver, I can send a ping request/reply from client A to client B through an Edge device running DPDK. However, the ping request that I observe always contains a

[dpdk-dev] The limitation of VHOST_MEMORY_MAX_NREGIONS in virtio-user with vhost-user backend

2017-12-05 Thread Wang, Wei 5. (NSB - CN/Hangzhou)
Hi, all In DPDK document, it it described that Virtio in containers Cannot work when there are more than VHOST_MEMORY_MAX_NREGIONS(8) hugepages. In another word, do not use 2MB hugepage so far. Do you know the reason of this limitation? In my envirionment, the pdpe1gb is not set in cpu flag,

[dpdk-dev] [PATCH v2 4/4] vhost: destroy unused virtqueues when multiqueue not negotiated

2017-12-05 Thread Maxime Coquelin
QEMU sends VHOST_USER_SET_VRING_CALL requests for all queues declared in QEMU command line before the guest is started. It has the effect in DPDK vhost-user backend to allocate vrings for all queues declared by QEMU. If the first driver being used does not support multiqueue, the device never chan

[dpdk-dev] [PATCH v2 3/4] vhost: extract virtqueue cleaning and freeing functions

2017-12-05 Thread Maxime Coquelin
This patch extracts needed code for vhost_user.c to be able to clean and free virtqueues unitary. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 22 -- lib/librte_vhost/vhost.h | 3 +++ 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH v2 2/4] vhost: propagate VHOST_USER_SET_FEATURES handling error

2017-12-05 Thread Maxime Coquelin
Not propagating VHOST_USER_SET_FEATURES request handling error may result in unpredictable behavior, as host and guests features may no more be synchronized. This patch fixes this by reporting the error to the upper layer, which would result in the device being destroyed and the connection with th

[dpdk-dev] [PATCH v2 1/4] vhost: prevent features to be changed while device is running

2017-12-05 Thread Maxime Coquelin
As section 2.2 of the Virtio spec states about features negotiation: "During device initialization, the driver reads this and tells the device the subset that it accepts. The only way to renegotiate is to reset the device." This patch implements a check to prevent illegal features change while the

[dpdk-dev] [PATCH v2 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-05 Thread Maxime Coquelin
Hi, This second revision only fixes the bit shifting issue reported by Ladi (patch 1/4). Having QEMU started with mq=on but guest driver not negotiating VIRTIO_NET_F_MQ feature ends up in the vhost device to never start. Indeed, more queues are created in the vhost backend than configured. Guest

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-05 Thread Tan, Jianfeng
On 12/4/2017 5:31 PM, Thomas Monjalon wrote: The hook is in bus->scan(). I think we should launch a bus scan when there is a new device event. That's what I'm trying to say. We finally need to execute a handler as of a device event to finish the job. Then why not just keep the vdev plug i

Re: [dpdk-dev] [RFC 2/2] net/tap: add eBPF instructions

2017-12-05 Thread Pascal Mazon
Indeed, the spirit of the initial work was to publish source code, compiled BPF bytecode, and Makefile for re-generating the latter. I have no clue regarding licensing, I'll trust you guys on that. On 30/11/2017 18:39, Thomas Monjalon wrote: > 30/11/2017 18:20, Stephen Hemminger: >> On Thu, 30 Nov