-----Original Message-----
From: Shahaf Shuler <shah...@mellanox.com>
Date: Monday, December 4, 2017 at 10:05 PM
To: Ferruh Yigit <ferruh.yi...@intel.com>, "Mody, Rasesh"
<rasesh.m...@cavium.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Harish Patil <harish.pa...@cavium.com>, Dept-Eng DPDK Dev
<dept-engdpdk...@cavium.com>
Subject: RE: [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter
to enable LRO
>Tuesday, December 5, 2017 1:25 AM, Ferruh Yigit:
>> On 11/24/2017 12:35 PM, Rasesh Mody wrote:
>> > From: Harish Patil <harish.pa...@cavium.com>
>> >
>> > Add an optional cmdline parameter to enable LRO. This is useful to
>> > test LRO feature by being able to run linux utils like iperf over KNI
>> > interface which generates consistent packet aggregations.
>> >
>> > Signed-off-by: Harish Patil <harish.pa...@cavium.com>
>>
>> Acked-by: Ferruh Yigit <ferruh.yi...@intel.com>
>>
>> I think this patch has no dependency for rest of the patchset and can be
>> separately applied.
>
>Snipped from the patch [1]
>
>Please use the new ethdev offloads API. there is already a series to
>convert the examples including kni[2], I think it is better to work on
>top of it.
>
>[1]
>@@ -611,6 +618,10 @@ struct kni_interface_stats {
> /* Initialise device and RX/TX queues */
> RTE_LOG(INFO, APP, "Initialising port %u ...\n", (unsigned)port);
> fflush(stdout);
>+
>+ if (enable_lro)
>+ port_conf.rxmode.enable_lro = 1;
>+
>
>[2] http://dpdk.org/dev/patchwork/patch/31558/
>
Okay, I will take a look at it.
Thanks,
Harish
>
