Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Hanoch Haim (hhaim)
Hi Oliver, It's hard for me to follow this thread. 1) It is not about clear/not-clear, it is error prone to *replicate* code that has the same logic. "I'm not convinced that: __rte_pktmbuf_reset_nb_segs(m); is clearer than: m->next = NULL; m->nb_segs = 1; Anyway, I agree this s

Re: [dpdk-dev] [PATCH] doc: fix GSO guide as PDF

2017-11-15 Thread Thomas Monjalon
15/11/2017 18:59, Thomas Monjalon: > The PDF cannot be built because of some images integration being > forced as SVG. They are converted for PDF format, so the extension > must be a wildcard in the RST file. > > Fixes: f6010c7655cc ("doc: add GSO programmer's guide") > > Signed-off-by: Thomas Mo

[dpdk-dev] [PATCH] doc: fix GSO guide as PDF

2017-11-15 Thread Thomas Monjalon
The PDF cannot be built because of some images integration being forced as SVG. They are converted for PDF format, so the extension must be a wildcard in the RST file. Fixes: f6010c7655cc ("doc: add GSO programmer's guide") Signed-off-by: Thomas Monjalon --- doc/guides/prog_guide/generic_segmen

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Olivier MATZ
Hi, On Wed, Nov 15, 2017 at 12:46:15PM +, Hanoch Haim (hhaim) wrote: > +Oliver, > Ilia, I assume there is a reason why Oliver did that, I just consolidate the > code. > He didn't want to *write* the same value to mbuf field. > In the common case that pointer was already cleared by the driv

[dpdk-dev] [dpdk-announce] DPDK 17.11 released

2017-11-15 Thread Thomas Monjalon
A new major release is available: http://fast.dpdk.org/rel/dpdk-17.11.tar.xz Some highlights: - IOVA awareness - PCI and VDEV buses moved to drivers - ethdev port id increased to 16 bits - ethdev Rx/Tx offload API reworked - Rx offload API for traffi

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-15 Thread Wiles, Keith
> On Nov 15, 2017, at 12:04 AM, Olivier MATZ wrote: > > Hi, > > On Wed, Nov 15, 2017 at 04:12:07AM +, Wiles, Keith wrote: >> >> >>> On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil >>> wrote: >>> >>> This patch removes all code associated with symbols not internally relied >>> on by other

Re: [dpdk-dev] ugb_uio: r3.8xlarge bind failure

2017-11-15 Thread Gregory Etelson
Hello Ferruh, re-checked igb_uio from dpdk master branch 0384f21dffc9081d1ae30f0a6e49926bfc4be85d OS: CentOS release 6.7 (Final), 2.6.32-573.26.1.el6.x86_64 igb_uio: Use MSIX interrupt by default ixgbevf: eth1: ixgbevf_remove: Remove complete IRQ handler type mismatch for IRQ 0 current handler: t

Re: [dpdk-dev] [PATCH] doc: update oldest supported kernel

2017-11-15 Thread Ferruh Yigit
On 11/11/2017 8:30 PM, Thomas Monjalon wrote: > 26/09/2017 09:17, Stephen Hemminger: >> The DPDK needs to stay up to date with current LTS Linux kernel support. >> If the kernel is older than LTS it is likely to be insecure and buggy. >> Therefore only require DPDK to work on oldest LTS kernel. >>

[dpdk-dev] [PATCH] lib/cmdline: init parse result memeory

2017-11-15 Thread Xueming Li
Initialize binary result memory before parsing to avoid garbage in parsing result. Signed-off-by: Xueming Li --- lib/librte_cmdline/cmdline_parse.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c index 3e12ee54f..9124

[dpdk-dev] [PATCH] lib/cmdline: support backspace key

2017-11-15 Thread Xueming Li
Support windows putty "\b"(Ctrl-H) backspace key. Signed-off-by: Xueming Li --- lib/librte_cmdline/cmdline_rdline.c | 1 + lib/librte_cmdline/cmdline_vt100.c | 1 + lib/librte_cmdline/cmdline_vt100.h | 1 + 3 files changed, 3 insertions(+) diff --git a/lib/librte_cmdline/cmdline_rdline.c b/l

[dpdk-dev] [PATCH 2/3] app/testpmd: support command echo in CLI batch loading

2017-11-15 Thread Xueming Li
Use first bit of verbose_level to enable CLI echo of batch loading. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f5a483ad7..b40fe1ac7 100644 --- a/app/test-pmd/cmdl

[dpdk-dev] [PATCH 3/3] test: update batch loading test

2017-11-15 Thread Xueming Li
Support echo back in batch loading. Signed-off-by: Xueming Li --- test/test/test_cmdline_lib.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/test/test_cmdline_lib.c b/test/test/test_cmdline_lib.c index 65b823a72..c700671d1 100644 --- a/test/test/test_cmdline

[dpdk-dev] [PATCH 0/3] enable echo when CLI loading from file

2017-11-15 Thread Xueming Li
Current "load" command load CLI batch from file and run in silent. This patch set use highest bit of verbose level to enable CLI echo. This will be very helpful to run a set of CLI from file and know which one prints out error message. Xueming Li (3): lib/cmdline: add echo support in batch load

[dpdk-dev] [PATCH 1/3] lib/cmdline: add echo support in batch loading from file

2017-11-15 Thread Xueming Li
Add echo option to echo commandline to screen when running loaded scripts from file. Signed-off-by: Xueming Li --- lib/librte_cmdline/cmdline_socket.c | 5 +++-- lib/librte_cmdline/cmdline_socket.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/librte_cmdline/cmdline

Re: [dpdk-dev] ugb_uio: r3.8xlarge bind failure

2017-11-15 Thread Ferruh Yigit
On 11/9/2017 10:36 PM, Gregory Etelson wrote: > It looks like igb_uio bind failed on servers running CentOS-6.x Hi Gregory, Below backtrace seems coming from old code, can you please confirm that you are using latest igb_uio? And what is the kernel version in that boxes? Thanks, ferruh > Serve

Re: [dpdk-dev] [PATCH] doc: announce API change for ethdev port info

2017-11-15 Thread Thomas Monjalon
15/11/2017 09:13, Olivier MATZ: > On Wed, Nov 15, 2017 at 12:50:55AM +0100, Thomas Monjalon wrote: > > 16/10/2017 16:27, Ivan Boule: > > > To help administrative tasks on ports, new per-port information need > > > to be added into the data structure rte_eth_dev_info supplied by the > > > dev_infos_

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Hanoch Haim (hhaim)
+Oliver, Ilia, I assume there is a reason why Oliver did that, I just consolidate the code. He didn't want to *write* the same value to mbuf field. In the common case that pointer was already cleared by the driver, it is better to just read it. From cache synchronization perspective it will ru

[dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2017-11-15 Thread Jianfeng Tan
In a running VM, operations (like device attach/detach) will trigger the QEMU to resend set_mem_table to vhost-user backend. DPDK vhost-user handles this message rudely by unmap all existing regions and map new ones. This might lead to segfault if there is pmd thread just trying to touch those unm

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Ilya Matveychikov
> On Nov 15, 2017, at 1:14 PM, Hanoh Haim wrote: > > Signed-off-by: Hanoh Haim > --- > lib/librte_mbuf/rte_mbuf.h | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 7e326bb..ab110

Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Ananyev, Konstantin
Hi Hanon, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hanoh Haim > Sent: Wednesday, November 15, 2017 8:36 AM > To: dev@dpdk.org > Cc: Hanoh Haim > Subject: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic > usage > > Signed-off-by: Ha

[dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix usage of incorrect port

2017-11-15 Thread Anoob Joseph
When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port only, and sending the packet on other ports could result in unencrypted packets being sent out. This would have performance improvements too, as the p

[dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Hanoh Haim
Signed-off-by: Hanoh Haim --- lib/librte_mbuf/rte_mbuf.h | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 7e326bb..ab110f8 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/r

Re: [dpdk-dev] [RFC] ethdev: add administrative information in per-port info

2017-11-15 Thread Andrew Rybchenko
On 09/08/2017 12:21 PM, Ivan Boule wrote: To help administrative tasks on DPDK ports, add in the data structure rte_eth_dev_info the following per-port information to be supplied by the dev_infos_get() function exported by a Poll Mode Driver: - the set of supported link modes, - the set of adver

Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Ananyev, Konstantin
Hi Hanon, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hanoh Haim > Sent: Wednesday, November 15, 2017 8:36 AM > To: dev@dpdk.org > Cc: Hanoh Haim > Subject: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic > usage > > Signed-off-by: Hano

Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Olivier MATZ
Hi Hanoh, On Wed, Nov 15, 2017 at 10:30:49AM +0200, Hanoh Haim wrote: > Signed-off-by: Hanoh Haim > --- > lib/librte_mbuf/rte_mbuf.h | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) > Please increase the version number in the title when sending a new verion

[dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Hanoh Haim
Signed-off-by: Hanoh Haim --- lib/librte_mbuf/rte_mbuf.h | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 7e326bb..ab110f8 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/r

[dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Hanoh Haim
Signed-off-by: Hanoh Haim --- lib/librte_mbuf/rte_mbuf.h | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 7e326bb..ab110f8 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/r

[dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Hanoh Haim
Signed-off-by: Hanoh Haim --- lib/librte_mbuf/rte_mbuf.h | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 7e326bb..ab110f8 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/r

[dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-15 Thread Hanoh Haim
Signed-off-by: Hanoh Haim --- lib/librte_mbuf/rte_mbuf.h | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 7e326bb..ab110f8 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/r

Re: [dpdk-dev] [PATCH] doc: announce API change for ethdev port info

2017-11-15 Thread Olivier MATZ
On Wed, Nov 15, 2017 at 12:50:55AM +0100, Thomas Monjalon wrote: > 16/10/2017 16:27, Ivan Boule: > > To help administrative tasks on ports, new per-port information need > > to be added into the data structure rte_eth_dev_info supplied by the > > dev_infos_get() function exported by a Poll Mode Dri

[dpdk-dev] [PATCH] version: 17.11.0

2017-11-15 Thread Thomas Monjalon
Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/rte_version.h | 4 ++-- pkg/dpdk.spec | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/include/rte_version.h b/lib/librte_eal/common/include/rte_version.h in

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow mark action on port start

2017-11-15 Thread Thomas Monjalon
15/11/2017 08:58, Nelio Laranjeiro: > On Wed, Nov 15, 2017 at 09:09:49AM +0200, Shahaf Shuler wrote: > > Mark action flag was not set on the flow, causing the rx burst function > > after port start to ignore the flow mark. > > > > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RS

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-15 Thread Olivier MATZ
Hi, On Wed, Nov 15, 2017 at 04:12:07AM +, Wiles, Keith wrote: > > > > On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil > > wrote: > > > > This patch removes all code associated with symbols not internally relied > > on by other DPDK components, makes struct cmdline opaque and then proceeds >