[dpdk-dev] [PATCH] bus/pci: fix bsd doxygen file description

2017-11-11 Thread Jerin Jacob
Fixes: 764bf26873b9 ("add FreeBSD support") Signed-off-by: Jerin Jacob --- drivers/bus/pci/bsd/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index facc4b12b..3daf5bd55 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/d

Re: [dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

2017-11-11 Thread Ori Kam
Hi, Thanks Adrien and Yongseok for your review. Due to Adrien comment I'm withdrawing the patch. Thanks again, Ori Kam > -Original Message- > From: Yongseok Koh > Sent: Friday, November 10, 2017 11:23 PM > To: Adrien Mazarguil > Cc: Ori Kam ; NĂ©lio Laranjeiro > ; dev@dpdk.org; sta...@

Re: [dpdk-dev] [PATCH] pdump: fix possible mbuf leak

2017-11-11 Thread Thomas Monjalon
10/11/2017 14:55, Ilya V. Matveychikov: > If pdump_pktmbuf_copy_data() fails it's possible to have segment leak > as rte_pktmbuf_free() only handles m_dup chain but not the seg just > allocated and yet not chained. > > Fixes: 278f945402c5 ("pdump: add new library for packet capture") > Cc: reshma.

Re: [dpdk-dev] [PATCH v3] doc: added inline crypto feature

2017-11-11 Thread Thomas Monjalon
09/11/2017 13:29, Radu Nicolau: > Signed-off-by: Radu Nicolau > --- > v2: removed useless anchor and updated ixgbe doc After a better look, re-added for consistency. Sorry for the confusion. > v3: removed trailing whitespaces and added line break Applied with small changes, thanks

Re: [dpdk-dev] [PATCH] doc: move fast mbuf free feature in net guide

2017-11-11 Thread Thomas Monjalon
09/11/2017 01:30, Ferruh Yigit: > On 11/8/2017 12:51 PM, Thomas Monjalon wrote: > > The feature was added at the end of the table. > > And the description was between the anchor _nic_features_timesync > > and its title. > > It is moved near related features with a new anchor. > > > > It is also re

Re: [dpdk-dev] [PATCH v5 0/3] Doc misc

2017-11-11 Thread Thomas Monjalon
> Santosh Shukla (3): > doc: add platform guide > doc: add mempool and octeontx mempool device > doc: use correct mempool ops handle name Applied, thanks

Re: [dpdk-dev] [PATCH 0/3] doc: documentation update for mlx4 PMD

2017-11-11 Thread Thomas Monjalon
09/11/2017 18:37, Adrien Mazarguil: > On Thu, Nov 09, 2017 at 07:30:53PM +0200, Moti Haimovsky wrote: > > The following three commits update the mlx4 documentation to reflect > > the modifications done to the PMD and the new features added to it. > > > > Moti Haimovsky (3): > > doc: fix remove m

Re: [dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2017-11-11 Thread Thomas Monjalon
09/11/2017 07:40, Yulong Pei: > Add tested Intel platforms with Intel NICs to the release note. > > Signed-off-by: Yulong Pei Applied, thanks

Re: [dpdk-dev] [PATCH v1] doc: update release notes for 17.11

2017-11-11 Thread Thomas Monjalon
10/11/2017 13:27, John McNamara: > Fix grammar, spelling and formatting of DPDK 17.11 release notes. > > Signed-off-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: update deprecation of ethdev offload API

2017-11-11 Thread Thomas Monjalon
> > Update deprecation notice for the new ethdev offloads API. > > Deprecation of the old offloads API is set to 18.05. > > > > Signed-off-by: Shahaf Shuler > > Acked-by: Konstantin Ananyev Acked-by: Thomas Monjalon Applied, thanks

Re: [dpdk-dev] [PATCH] doc: update oldest supported kernel

2017-11-11 Thread Thomas Monjalon
26/09/2017 09:17, Stephen Hemminger: > The DPDK needs to stay up to date with current LTS Linux kernel support. > If the kernel is older than LTS it is likely to be insecure and buggy. > Therefore only require DPDK to work on oldest LTS kernel. > > If distribution vendors want to support DPDK on o

Re: [dpdk-dev] [PATCH] doc/guides: mention 17.11 LTS in contributing/stable

2017-11-11 Thread Thomas Monjalon
> > Signed-off-by: Luca Boccassi > > --- [...] > > A stable release can be designated as an LTS release based on community - > > agreement and a commitment from a maintainer. An LTS release will have a - > > maintenance duration of 2 years. > > +agreement and a commitment from a maintainer. The c

Re: [dpdk-dev] [PATCH] maintainers: claim maintainership of VDEV bus

2017-11-11 Thread Thomas Monjalon
08/11/2017 02:12, Thomas Monjalon: > 08/11/2017 02:07, Jianfeng Tan: > > VDEV bus driver > > +M: Jianfeng Tan > > F: drivers/bus/vdev/ > > Acked-by: Thomas Monjalon > > Thanks for your work on vdev bus driver. Applied

Re: [dpdk-dev] [PATCH] maintainers: update for fm10k

2017-11-11 Thread Thomas Monjalon
> > Signed-off-by: Xiao Wang > Acked-by: Helin Zhang > > > --- > > Intel fm10k > > -M: Jing Chen > > +M: Qi Zhang > > +M: Xiao Wang Applied, thanks

Re: [dpdk-dev] [PATCH] maintainers: fill git trees for net and crypto API

2017-11-11 Thread Thomas Monjalon
> > The ethdev API (including rte_flow) is managed in the dpdk-next-net tree. > > The crypto and security API is managed in the dpdk-next-crypto tree. > > > > Signed-off-by: Thomas Monjalon > > --- > > > > Pablo, do you agree to manage rte_security patches in the crypto tree? > > Hi Thomas, >

Re: [dpdk-dev] [dpdk-stable] [PATCH] maintainers: resign from mlx4 maintenance

2017-11-11 Thread Thomas Monjalon
03/11/2017 11:04, Nelio Laranjeiro: > I have been a little too busy these past months and could not follow all > the re-work of this PMD. > > So the best thing for this PMD would be to move the mlx4 maintenance to > more involved people. > > Cc: sta...@dpdk.org > Signed-off-by: Nelio Laranjeiro

Re: [dpdk-dev] [PATCH] maintainers: update job stats library

2017-11-11 Thread Thomas Monjalon
> > Signed-off-by: Pablo de Lara > > --- > > MAINTAINERS | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Job statistics > > -M: Pawel Wodkowski > > +M: Pablo de Lara > > Acked-by: Wodkowski, Pawel Applied

Re: [dpdk-dev] [PATCH] maintainers: update ptp client app

2017-11-11 Thread Thomas Monjalon
> >Signed-off-by: Pablo de Lara > >--- > > M: Pablo de Lara > >-M: Daniel Mrzyglod > > F: examples/ptpclient/ > > Acked-by: Daniel Mrzyglod Applied

Re: [dpdk-dev] [PATCH] examples: fix for incomplete nb_segs type change

2017-11-11 Thread Thomas Monjalon
10/11/2017 14:57, Ilya V. Matveychikov: > Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments") > Cc: olivier.m...@6wind.com > > Signed-off-by: Ilya V. Matveychikov Applied, thanks

Re: [dpdk-dev] [PATCH] test/memory: fixing line parsing in memory autotest

2017-11-11 Thread Thomas Monjalon
09/11/2017 19:14, Radoslaw Biernacki: > This patch fixes three problems in memory autotest: > - the regex for IOVA > - missing validation of second and following output lines > - propagation of error to consecutive tests > - conversion base for mem size (hex indtead of dec) > First fix is for c

Re: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design

2017-11-11 Thread Thomas Monjalon
11/11/2017 18:18, Ilya Matveychikov: > Folks, > > Are you serious with it: No, DPDK is not serious, just a hobby for few crazy folks ;) Usually, we have fun discussions when someone explains clearly an issue. Please do not hesitate to bring your lights, we will check how seriously we can improve

[dpdk-dev] [PATCH 2/3] power: switching to unbuffered access for /sys files

2017-11-11 Thread Radoslaw Biernacki
This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. When using buffered stdio, each fwrite() must use fflush() and the return code must be verified. Also fseek() is needed. Therefore it is better to use unbuffered mode or use

[dpdk-dev] [PATCH 1/3] power: removing code macros

2017-11-11 Thread Radoslaw Biernacki
This fix implements David Hunt suggestion to remove error checking code macros. Together with improved code readability it removes checkpatch warnings. Fixes: 445c6528b55f ("power: common interface for guest and host") CC: sta...@dpdk.org Signed-off-by: Radoslaw Biernacki --- lib/librte_power/

[dpdk-dev] [PATCH 3/3] power: check if userspace governor is available

2017-11-11 Thread Radoslaw Biernacki
Since for new Intel CPU's kernel use intel_pstate driver, which does not offer userspace governor, it is wise to check the userspace governor availability before trying to perform governor switch. The outcome from this patch is direct information for user about the root cause of failure during the

[dpdk-dev] [PATCH 0/3] power: fixes for power ACPI through sysfs

2017-11-11 Thread Radoslaw Biernacki
This series of patches is fixing bug in power ACPI subsystem code as well as improve the debugging messages and cleans the code. V2: - error checking macros removed (checkpatch warning) - using plain open()/read()/write() system functions instead of STDIO - added check for intel_pstate driver t

[dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design

2017-11-11 Thread Ilya Matveychikov
Folks, Are you serious with it: typedef uint16_t (*eth_rx_burst_t)(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts); typedef uint16_t (*eth_tx_burst_t)(void *txq, struct rte_mbuf **tx_p

Re: [dpdk-dev] [PATCH] testpmd: add nanosleep in main loop

2017-11-11 Thread Marcelo Tosatti
On Sat, Nov 11, 2017 at 01:59:21AM -0200, Marcelo Tosatti wrote: > On Fri, Nov 10, 2017 at 08:51:02AM -0500, Luiz Capitulino wrote: > > On Fri, 10 Nov 2017 11:14:51 + > > Bruce Richardson wrote: > > > > > On Fri, Nov 10, 2017 at 11:42:56AM +0100, Daniel Bristot de Oliveira > > > wrote: > > >

Re: [dpdk-dev] [PATCH] testpmd: add nanosleep in main loop

2017-11-11 Thread Marcelo Tosatti
On Fri, Nov 10, 2017 at 10:14:23AM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Friday, November 10, 2017 9:12 AM > > To: Marcelo Tosatti > > Cc: dev@dpdk.org; Luiz Capitulino ; Daniel Bri

Re: [dpdk-dev] [PATCH] testpmd: add nanosleep in main loop

2017-11-11 Thread Marcelo Tosatti
On Fri, Nov 10, 2017 at 10:12:19AM +0100, Adrien Mazarguil wrote: > Hi Marcelo, Hello Adrien, > On Fri, Nov 10, 2017 at 04:02:10AM -0200, Marcelo Tosatti wrote: > > > > This patch allows a configurable pair of values to be set, which > > controls > > the frequency and length of a nanosleep call

Re: [dpdk-dev] [PATCH] testpmd: add nanosleep in main loop

2017-11-11 Thread Marcelo Tosatti
On Fri, Nov 10, 2017 at 11:14:51AM +, Bruce Richardson wrote: > On Fri, Nov 10, 2017 at 11:42:56AM +0100, Daniel Bristot de Oliveira wrote: > > > > > > On 11/10/2017 11:14 AM, Ananyev, Konstantin wrote: > > > Agree with Adrian here - the patch doesn't fix the problem in any case, > > > > I w

Re: [dpdk-dev] [PATCH] testpmd: add nanosleep in main loop

2017-11-11 Thread Marcelo Tosatti
On Fri, Nov 10, 2017 at 08:51:02AM -0500, Luiz Capitulino wrote: > On Fri, 10 Nov 2017 11:14:51 + > Bruce Richardson wrote: > > > On Fri, Nov 10, 2017 at 11:42:56AM +0100, Daniel Bristot de Oliveira wrote: > > > > > > > > > On 11/10/2017 11:14 AM, Ananyev, Konstantin wrote: > > > > Agree

Re: [dpdk-dev] [PATCH] app/testpmd: remove port status check from TM node add cli

2017-11-11 Thread Thomas Monjalon
> > Currently, testpmd CLI doesn't permit to add leaf and non-leaf node when > > port is started. It doesn't work in case of i40e device as DCB > > configuration is > > deleted when port is stopped. Therefore, removes the port status check > > before invoking leaf and nonleaf node API in the cli.

Re: [dpdk-dev] [PATCH] net/mlx4: fix last Tx wqe stamping lack

2017-11-11 Thread Thomas Monjalon
10/11/2017 16:02, Adrien Mazarguil: > On Fri, Nov 10, 2017 at 08:27:18AM +, Matan Azrad wrote: > > When Tx pakcet HW processing is done, SW should stamp all the completion > > burst WQEs. > > > > Stamp missed last completion burst WQE. > > > > Fixes: c3c977bbecbd ("net/mlx4: add Tx bypassing

Re: [dpdk-dev] [PATCH] doc: postpone devargs clean-up

2017-11-11 Thread Thomas Monjalon
08/11/2017 10:53, Gaetan Rivet: > These changes were planned for 17.11 but were proposed too late. > Postpone those to v18.02 instead. > > Signed-off-by: Gaetan Rivet Applied, thanks

Re: [dpdk-dev] [PATCH v6] net/virtio: fix rxq intr config fails using vfio-pci

2017-11-11 Thread Thomas Monjalon
09/11/2017 10:21, Zhiyong Yang: > When running l3fwd-power to test virtio rxq interrupt using vfio > pci noiommu mode, startup fails. In the function virtio_read_caps, > the code if (flags & PCI_MSIX_ENABLE) intends to double check > if vfio msix is enabled or not. However, it is not enable at that

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/memzone: fixing memory leak in memzone autotest

2017-11-11 Thread Thomas Monjalon
08/11/2017 13:33, Radoslaw Biernacki: > This patch fixes the memory leaks in memzone_autotest. Those memory leaks > lead to failures in tests from the same testing group due to out of memory > problems. With introduction of rte_memzone_free() it is now possible to > free the memzone. Fix uses thi

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix use of bit numbers instead of masks

2017-11-11 Thread Thomas Monjalon
10/11/2017 15:49, Nelio Laranjeiro: > On Fri, Nov 10, 2017 at 02:18:04PM +, Edward Makarov wrote: > > The constant ETHTOOL_LINK_MODE_1000baseT_Full_BIT and the others like > > that in mlx5_link_update_unlocked_gs must be bit masks but unfortunately > > they are bit numbers. This commit fixes th

Re: [dpdk-dev] [PATCH] doc: update ABI/API policy

2017-11-11 Thread Thomas Monjalon
06/11/2017 15:48, Mcnamara, John: > From: Richardson, Bruce > > > > Following agreement at the DPDK Technical Board meeting of 2017-10-13 [1], > > update the documentation with the ABI/API policy changes. > > > > [1] http://dpdk.org/ml/archives/dev/2017-October/079961.html > > > > Signed-off-by:

Re: [dpdk-dev] [PATCH] eal/random: fix a wrong comment

2017-11-11 Thread Thomas Monjalon
08/11/2017 08:04, Jerin Jacob: > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH] eal/random: fix a wrong comment

2017-11-11 Thread Thomas Monjalon
08/11/2017 08:04, Jerin Jacob: > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Jerin Jacob Applied, thanks