10/11/2017 16:02, Adrien Mazarguil:
> On Fri, Nov 10, 2017 at 08:27:18AM +0000, Matan Azrad wrote:
> > When Tx pakcet HW processing is done, SW should stamp all the completion
> > burst WQEs.
> >
> > Stamp missed last completion burst WQE.
> >
> > Fixes: c3c977bbecbd ("net/mlx4: add Tx bypassing Verbs")
> >
> > Signed-off-by: Matan Azrad <[email protected]>
>
> This reads like you were in a hurry :)
>
> Took me a while to understand the problem and how you addressed it. So in
> short, wqe_index is consumed but its TXBBs aren't stamped because the loop
> stops at its index without processing it.
>
> Patch looks good but could have been simpler by directly initializing
> nr_txbbs to sq->tail, not use sq->tail as an offset afterward and get rid of
> sq_tail. It's OK as this wouldn't have resulted in a smaller patch anyway.
>
> Commit log rewording suggestion:
>
> net/mlx4: fix missing stamp during Tx completion
>
> After processing completed packets, the owner bit of each TXBB comprised
> in its WQEs must be invalidated. The loop stops short of processing the
> last WQE.
>
> Other than that,
>
> Acked-by: Adrien Mazarguil <[email protected]>
Applied with suggested commit log, thanks
