[dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-12 Thread Shahaf Shuler
Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_RX_OFFLOAD_* flags. To enable per-port offload, the offload should be set on both device

[dpdk-dev] [PATCH v3 2/2] ethdev: introduce Tx queue offloads API

2017-09-12 Thread Shahaf Shuler
Introduce a new API to configure Tx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_TX_OFFLOAD_* flags. To enable per-port offload, the offload should be set on both device

[dpdk-dev] [PATCH v3 0/2] ethdev new offloads API

2017-09-12 Thread Shahaf Shuler
Tx offloads configuration is per queue. Tx offloads are enabled by default, and can be disabled using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with the Rx side where the Rx offloads configuration is per port. Rx offloads are disabled by default and enabled according to bit field

Re: [dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10 native Tx datapath reap

2017-09-12 Thread Andrew Rybchenko
On 09/13/2017 12:51 AM, Stephen Hemminger wrote: On Fri, 8 Sep 2017 15:15:50 +0100 Andrew Rybchenko wrote: + txd->mbuf = NULL; + if (m == NULL) + continue; + + if ((nb == RTE_DIM(bulk)) || +

[dpdk-dev] [PATCH v2 0/2] net/i40e: API to configure queue regions for RSS

2017-09-12 Thread Wei Zhao
The patches mainly finish following functions: 1) Command line for input queue region configure parameters. 2) Set or flush queue region configutation. v2: -fix bug for packet into queue region code. -change code style for DPDK C programing. -change that "flowtype" name to " hw_flowtype " in stru

[dpdk-dev] [PATCH v2 1/2] net/i40e: queue region set and flush

2017-09-12 Thread Wei Zhao
This feature enable queue regions configuration for RSS in PF/VF, so that different traffic classes or different packet classification types can be separated to different queues in different queue regions.This patch can set queue region range, it include queue number in a region and the index of fi

[dpdk-dev] [PATCH v2 2/2] app/testpmd: add API for configuration of queue region

2017-09-12 Thread Wei Zhao
This patch add a API configuration of queue region in rss. It can parse the parameters of region index, queue number, queue start index, user priority, traffic classes and so on. According to commands from command line, it will call i40e private API and start the process of set or flush queue regio

Re: [dpdk-dev] [PATCH 1/3] ethdev: add new eth_dev_ops function for mtr ops get

2017-09-12 Thread Jerin Jacob
-Original Message- > Date: Sat, 26 Aug 2017 01:06:11 +0100 > From: Cristian Dumitrescu > To: dev@dpdk.org > CC: tho...@monjalon.net, adrien.mazarg...@6wind.com, > jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com > Subject: [PATCH 1/3] ethdev: add new eth_dev_ops function for mtr ops

Re: [dpdk-dev] [PATCH v2] net/i40e: fix memory leak if VF init fails

2017-09-12 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, September 13, 2017 11:23 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] net/i40e: fix memory leak if VF init fails > > > > > -Original Message- > > From: Wu, Jingjing > > Sent: We

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-12 Thread Shahaf Shuler
Tuesday, September 12, 2017 9:34 PM, Nélio Laranjeiro: > > On Sep 12, 2017, at 12:24 AM, Nélio Laranjeiro > >>> Is not it dangerous to assume inl will always be 4 bytes long? Why > >>> not writing the real value instead? > >> That was for readability of the code and uint32_t will be always > >> 4b

Re: [dpdk-dev] [PATCH v3] i40e: fix i40evf_add_mac_addr to permit multicast addresses

2017-09-12 Thread Xing, Beilei
> -Original Message- > From: David Harton [mailto:dharton@cpp-rtpbld-31.cpprtplab] > Sent: Wednesday, September 13, 2017 11:21 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; David Harton > Subject: [PATCH v3] i40e: fix i40evf_add_mac_addr to permit multicast > addresses > > F

Re: [dpdk-dev] [PATCH v2] net/i40e: fix memory leak if VF init fails

2017-09-12 Thread Xing, Beilei
> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, September 13, 2017 3:24 AM > To: Xing, Beilei > Cc: dev@dpdk.org; Wu, Jingjing ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix memory leak if VF init fails > > Cc: sta...@dpdk.org > Fixes: 4861cde46116 ("i40e: new poll m

[dpdk-dev] [PATCH v3] i40e: fix i40evf_add_mac_addr to permit multicast addresses

2017-09-12 Thread David Harton
From: David Harton The i40e maintains a single MAC filter table for both unicast and multicast addresses. The i40e_validate_mac_addr function was preventing multicast addresses from being added to the table via i40evf_add_mac_addr. Fixed the issue by adjusting the check in i40evf_add_mac_addr.

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items

2017-09-12 Thread Xing, Beilei
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, September 12, 2017 6:47 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items > >

[dpdk-dev] [Bug 2] Test bugs for checking the bug flow, no need any fix

2017-09-12 Thread bugzilla
http://dpdk.org/tracker/show_bug.cgi?id=2 Qian (qian.q...@intel.com) changed: What|Removed |Added Status|VERIFIED|UNCONFIRMED Resolution|FIXED

[dpdk-dev] [Bug 2] Test bugs for checking the bug flow, no need any fix

2017-09-12 Thread bugzilla
http://dpdk.org/tracker/show_bug.cgi?id=2 Qian (qian.q...@intel.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

[dpdk-dev] [Bug 2] Test bugs for checking the bug flow, no need any fix

2017-09-12 Thread bugzilla
http://dpdk.org/tracker/show_bug.cgi?id=2 Bug ID: 2 Summary: Test bugs for checking the bug flow, no need any fix Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: CONFIRMED Severity: crit

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-12 Thread Jiayu Hu
Hi Konstantin, On Tue, Sep 12, 2017 at 07:17:49PM +0800, Ananyev, Konstantin wrote: > Hi Jayu, > > > -Original Message- > > From: Hu, Jiayu > > Sent: Tuesday, September 12, 2017 3:43 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin ; Kavanagh, Mark B > > ; Tan, Jianfeng > > ; Hu, Jiay

Re: [dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast addresses

2017-09-12 Thread Xing, Beilei
> -Original Message- > From: David Harton (dharton) [mailto:dhar...@cisco.com] > Sent: Wednesday, September 13, 2017 10:38 AM > To: Xing, Beilei ; David Harton 31.cpprtplab>; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast > ad

[dpdk-dev] [PATCH v2] net/i40e: fix memory leak if VF init fails

2017-09-12 Thread Jingjing Wu
Cc: sta...@dpdk.org Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Jingjing Wu --- v2 change: - free aq_resp at err_aq drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf

[dpdk-dev] [PATCH] net/i40e: fix memory leak if VF init fails

2017-09-12 Thread Jingjing Wu
Cc: sta...@dpdk.org Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index f6d8293..9eca9ed 100644 --- a

Re: [dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast addresses

2017-09-12 Thread David Harton (dharton)
Hi Beilei, > -Original Message- > From: Xing, Beilei [mailto:beilei.x...@intel.com] > > Hi Harton, > > > -Original Message- > > From: David Harton [mailto:dharton@cpp-rtpbld-31.cpprtplab] > > > > From: David Harton > > > > The i40e maintains a single MAC filter table for both un

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-12 Thread Yang, Zhiyong
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 11, 2017 6:22 PM > To: Yang, Zhiyong ; dev@dpdk.org; Doherty, Declan > ; Lu, Wenzhuo > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Hunt, David > > Subject: Re: [PATCH v3 1/4] ethdev: increase port_id ran

Re: [dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast addresses

2017-09-12 Thread Xing, Beilei
Hi Harton, > -Original Message- > From: David Harton [mailto:dharton@cpp-rtpbld-31.cpprtplab] > Sent: Tuesday, September 12, 2017 9:02 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; David Harton > Subject: [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast > addresses

Re: [dpdk-dev] [PATCH v3 1/5] gso: add Generic Segmentation Offload API framework

2017-09-12 Thread Jiayu Hu
Hi Konstantin, Thanks for your quick feedbacks. Replies are inline. Thanks, Jiayu On Tue, Sep 12, 2017 at 06:36:41PM +0800, Ananyev, Konstantin wrote: > Hi Jiayu, > Few comments from be inline. > Konstantin > > > diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c > > new file mode

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-12 Thread Thomas Monjalon
12/09/2017 22:29, Aaron Conole: > Thomas Monjalon writes: > > > 12/09/2017 16:50, Aaron Conole: > >> Eelco Chaudron writes: > >> > >> > Call the mlockall() function, to attempt to lock all of its process > >> > memory into physical RAM, and preventing the kernel from paging any > >> > of its me

Re: [dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10 native Tx datapath reap

2017-09-12 Thread Stephen Hemminger
On Fri, 8 Sep 2017 15:15:50 +0100 Andrew Rybchenko wrote: > + txd->mbuf = NULL; > + if (m == NULL) > + continue; > + > + if ((nb == RTE_DIM(bulk)) || > + ((nb != 0) && (m->pool != bulk[

Re: [dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Wiles, Keith
> On Sep 12, 2017, at 2:19 PM, Neil Horman wrote: > > On Tue, Sep 12, 2017 at 01:26:09PM +, Wiles, Keith wrote: >> >>> On Sep 12, 2017, at 8:24 AM, Richardson, Bruce >>> wrote: >>> >>> On Tue, Sep 12, 2017 at 02:21:22PM +0100, Wiles, Keith wrote: > On Sep 12, 2017, at 5:37 AM,

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-12 Thread Aaron Conole
Thomas Monjalon writes: > 12/09/2017 16:50, Aaron Conole: >> Eelco Chaudron writes: >> >> > Call the mlockall() function, to attempt to lock all of its process >> > memory into physical RAM, and preventing the kernel from paging any >> > of its memory to disk. >> > >> > When using testpmd for p

Re: [dpdk-dev] git trees organization

2017-09-12 Thread Thomas Monjalon
12/09/2017 18:32, Ferruh Yigit: > Hi Thomas, > > On 9/11/2017 11:03 PM, Thomas Monjalon wrote: > > I feel it is the good time to move to a slightly different organization. > > I am working closely with Ferruh Yigit for almost one year, as next-net > > maintainer, and I think it would be very effic

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-12 Thread Thomas Monjalon
12/09/2017 16:50, Aaron Conole: > Eelco Chaudron writes: > > > Call the mlockall() function, to attempt to lock all of its process > > memory into physical RAM, and preventing the kernel from paging any > > of its memory to disk. > > > > When using testpmd for performance testing, depending on th

Re: [dpdk-dev] Please add commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572

2017-09-12 Thread Thomas Monjalon
12/09/2017 17:14, ASM: > Hi folks! > > I found that the LTS version does not have the important commit > c12d22f65b132c56db7b4fdbfd5ddce27d1e9572 The title: net/ixgbe: ensure link status is updated The link: http://dpdk.org/commit/c12d22f65b132 > That I need do to add it to the L

Re: [dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Neil Horman
On Tue, Sep 12, 2017 at 01:26:09PM +, Wiles, Keith wrote: > > > On Sep 12, 2017, at 8:24 AM, Richardson, Bruce > > wrote: > > > > On Tue, Sep 12, 2017 at 02:21:22PM +0100, Wiles, Keith wrote: > >> > >>> On Sep 12, 2017, at 5:37 AM, Bruce Richardson > >>> wrote: > >>> > >>> V2 changes: >

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-12 Thread Yongseok Koh
> On Sep 12, 2017, at 12:24 AM, Nélio Laranjeiro > wrote: > > On Mon, Sep 11, 2017 at 03:17:44PM -0700, Yongseok Koh wrote: >> On Mon, Sep 04, 2017 at 04:01:08PM +0200, Nélio Laranjeiro wrote: >>> Hi Yongseok, >>> >>> Please see some comments below, >>> >>> On Thu, Aug 31, 2017 at 09:27:06AM

Re: [dpdk-dev] [PATCH 2/2] net/sfc: free mbufs in bulks on simple EF10 Tx datapath reap

2017-09-12 Thread Ferruh Yigit
On 9/8/2017 3:15 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > --- > doc/guides/nics/sfc_efx.rst | 4 +++- > drivers/net/sfc/sfc_dp_tx.h | 2 ++ > drivers/net/sfc/sfc_ef10_tx.c | 15 ++- > drivers/net/sfc/sfc_

Re: [dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10 native Tx datapath reap

2017-09-12 Thread Ferruh Yigit
On 9/8/2017 3:15 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > --- > drivers/net/sfc/sfc_ef10_tx.c | 48 > --- > drivers/net/sfc/sfc_tweak.h | 3 +++ > 2 files changed, 44 insertions(

Re: [dpdk-dev] multi-process shared memory on PPC

2017-09-12 Thread Xueming(Steven) Li
It works for me after setting nr_overcommit_hugepages correctly, thanks again. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming(Steven) Li > Sent: Tuesday, September 12, 2017 4:13 PM > To: Chao Zhu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] multi-proce

Re: [dpdk-dev] git trees organization

2017-09-12 Thread Ferruh Yigit
On 9/12/2017 9:48 AM, Thomas Monjalon wrote: > 12/09/2017 10:32, Bruce Richardson: >> On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote: > [...] >>> At the same time, we can think how to add more git sub-trees: >> >> In principle, I'm in favour, but I think that the subtrees of the ma

Re: [dpdk-dev] git trees organization

2017-09-12 Thread Ferruh Yigit
Hi Thomas, On 9/11/2017 11:03 PM, Thomas Monjalon wrote: > Hi all, > > As you know I am currently the only maintainer of the master tree. > It is very convenient because I need to synchronize with others > only when pulling "next-*" trees. > But the drawback is that I should be available very oft

Re: [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function

2017-09-12 Thread Kevin Traynor
On 09/12/2017 09:16 AM, Bruce Richardson wrote: > On Mon, Sep 11, 2017 at 06:56:39PM +0100, Ferruh Yigit wrote: >> On 9/5/2017 1:04 PM, Markus Theil wrote: >>> The patch which introduced the usage of pci_alloc_irq_vectors >>> came after the patch which switched to non-threaded ISR (f0d1896fa1), >>>

Re: [dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Bruce Richardson
On Tue, Sep 12, 2017 at 03:00:13PM +0100, Wiles, Keith wrote: > > > On Sep 12, 2017, at 8:26 AM, Wiles, Keith wrote: > > > >> > >> On Sep 12, 2017, at 8:24 AM, Richardson, Bruce > >> wrote: > >> > >> On Tue, Sep 12, 2017 at 02:21:22PM +0100, Wiles, Keith wrote: > >>> > On Sep 12, 2017,

[dpdk-dev] Openstack with DPDK

2017-09-12 Thread abhishek jain
Hi I'm trying to launch VM with Openstack ocata on ubuntu 16.04 using openstack dashboard with OVS DPDK environment,I'm facing below issues while doing the same.. error: Failed to start domain instance-0001 error: internal error: process exited while connecting to monitor: 2017-09-12T05:53:04

[dpdk-dev] Please add commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572

2017-09-12 Thread ASM
Hi folks! I found that the LTS version does not have the important commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572 That I need do to add it to the LTS version? --- Best regards, Leonid Myravjev

[dpdk-dev] [PATCH 1/2] reorder: fix ready buffers not being nulled out

2017-09-12 Thread Pavan Nikhilesh
The ready buffers should be set to NULL when drained else it might result in double free (mempool put) when rte_reorder_free is called. Fixes: b70b56032bff ("reorder: new library") Signed-off-by: Pavan Nikhilesh --- lib/librte_reorder/rte_reorder.c | 1 + 1 file changed, 1 insertion(+) diff --

[dpdk-dev] [PATCH 2/2] test/reorder: fix reorder drain test

2017-09-12 Thread Pavan Nikhilesh
The reorder drain test fails due to mempool corruption caused by freeing packet buffer twice. Fixes: d0c9b58d7156 ("app/test: new reorder unit test") Signed-off-by: Pavan Nikhilesh --- test/test/test_reorder.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletion

Re: [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function

2017-09-12 Thread Stephen Hemminger
Why not have an ongoing sliding window policy? So each release it is set On Sep 12, 2017 1:14 AM, "Bruce Richardson" wrote: > On Mon, Sep 11, 2017 at 03:04:01PM -0700, Stephen Hemminger wrote: > > I wonder if it is time to move the bar forward to oldest LTS which is > > 3.2.92 > > > > That seems

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-12 Thread Aaron Conole
Eelco Chaudron writes: > Call the mlockall() function, to attempt to lock all of its process > memory into physical RAM, and preventing the kernel from paging any > of its memory to disk. > > When using testpmd for performance testing, depending on the code path > taken, we see a couple of page f

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-12 Thread Andrew Rybchenko
On 09/12/2017 05:36 PM, Jerin Jacob wrote: -Original Message- Date: Tue, 12 Sep 2017 14:26:38 + From: "Ananyev, Konstantin" To: Andrew Rybchenko , Shahaf Shuler , Jerin Jacob CC: Stephen Hemminger , Thomas Monjalon , "dev@dpdk.org" , "Zhang, Helin" , "Wu, Jingjing" Subject:

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-12 Thread Jerin Jacob
-Original Message- > Date: Tue, 12 Sep 2017 14:26:38 + > From: "Ananyev, Konstantin" > To: Andrew Rybchenko , Shahaf Shuler > , Jerin Jacob > CC: Stephen Hemminger , Thomas Monjalon > , "dev@dpdk.org" , "Zhang, Helin" > , "Wu, Jingjing" > Subject: RE: [dpdk-dev] [PATCH v2 2/2] eth

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-12 Thread Ananyev, Konstantin
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Tuesday, September 12, 2017 11:28 AM > To: Shahaf Shuler ; Jerin Jacob > > Cc: Ananyev, Konstantin ; Stephen Hemminger > ; Thomas Monjalon > ; dev@dpdk.org; Zhang, Helin ; > Wu, Jingjing > Subjec

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-12 Thread Ananyev, Konstantin
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, September 12, 2017 12:18 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Kavanagh, Mark B ; Tan, Jianfeng > > Subject: RE: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > Hi Jayu, > > > -Original Message- > > From: Hu,

Re: [dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Wiles, Keith
> On Sep 12, 2017, at 8:26 AM, Wiles, Keith wrote: > >> >> On Sep 12, 2017, at 8:24 AM, Richardson, Bruce >> wrote: >> >> On Tue, Sep 12, 2017 at 02:21:22PM +0100, Wiles, Keith wrote: >>> On Sep 12, 2017, at 5:37 AM, Bruce Richardson wrote: V2 changes: * fixed co

Re: [dpdk-dev] [PATCH] net/enic: fix multi-process operation

2017-09-12 Thread Aaron Conole
John Daley writes: > - Use rte_malloc() instead of malloc() for the per device 'vdev' structure > so that it can be shared across processes. > - Only initialize the device if the process type is RTE_PROC_PRIMARY > - Only allow the primary process to do queue setup, start/stop, promisc > allmu

Re: [dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Wiles, Keith
> On Sep 12, 2017, at 8:24 AM, Richardson, Bruce > wrote: > > On Tue, Sep 12, 2017 at 02:21:22PM +0100, Wiles, Keith wrote: >> >>> On Sep 12, 2017, at 5:37 AM, Bruce Richardson >>> wrote: >>> >>> V2 changes: >>> * fixed copyright notices, updated 2016 to 2017 >>> * removed dependency on kco

Re: [dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Bruce Richardson
On Tue, Sep 12, 2017 at 02:21:22PM +0100, Wiles, Keith wrote: > > > On Sep 12, 2017, at 5:37 AM, Bruce Richardson > > wrote: > > > > V2 changes: > > * fixed copyright notices, updated 2016 to 2017 > > * removed dependency on kconfig file in kernel build tree > > * marked pmdinfogen as a "native

Re: [dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Wiles, Keith
> On Sep 12, 2017, at 5:37 AM, Bruce Richardson > wrote: > > V2 changes: > * fixed copyright notices, updated 2016 to 2017 > * removed dependency on kconfig file in kernel build tree > * marked pmdinfogen as a "native" binary, in preparation for future cross- > compilation work > * added in ad

[dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-12 Thread Eelco Chaudron
Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any of its memory to disk. When using testpmd for performance testing, depending on the code path taken, we see a couple of page faults in a row. These faults effect

[dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast addresses

2017-09-12 Thread David Harton
From: David Harton The i40e maintains a single MAC filter table for both unicast and multicast addresses. The i40e_validate_mac_addr function was preventing multicast addresses from being added to the table via i40evf_add_mac_addr. Fixed the issue by adjusting the check in i40evf_add_mac_addr.

Re: [dpdk-dev] git trees organization

2017-09-12 Thread Wiles, Keith
> On Sep 12, 2017, at 3:48 AM, Thomas Monjalon wrote: > > 12/09/2017 10:32, Bruce Richardson: >> On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote: > [...] >>> At the same time, we can think how to add more git sub-trees: >> >> In principle, I'm in favour, but I think that the sub

[dpdk-dev] [PATCH] net/e1000: fix memcpy length error

2017-09-12 Thread Yong Wang
The size of "flex_filter.filter_info.mask" and "filter->mask" is 16 bytes, but the length of memcpy--"RTE_ALIGN(filter->len, sizeof(char)) / sizeof(char)" may reach 128 bytes which may cause array access out of bound. Fix it by replacing "sizeof(char)" by "CHAR_BIT". Signed-off-by: Yong Wang ---

Re: [dpdk-dev] [PATCH 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Bruce Richardson
On Mon, Sep 04, 2017 at 02:23:13PM +0100, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > > Richardson Sent: Friday, September 1, 2017 11:04 AM To: dev@dpdk.org > > Cc: Richardson, Bruce Subject: > > [dpdk-dev] [PATCH 00/17] build DPDK libs and some driver

[dpdk-dev] [PATCH v2 17/17] doc: add documentation on how to add new components to DPDK

2017-09-12 Thread Bruce Richardson
Add to the contributors guide details on how to add libraries and drivers and integrate them with the DPDK build system(s). Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- doc/guides/contributing/coding_style.rst | 214 +++ 1 file changed, 214 inser

[dpdk-dev] [PATCH v2 14/17] app/test-pmd: add test-pmd to meson build

2017-09-12 Thread Bruce Richardson
Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- app/meson.build | 32 + app/test-pmd/meson.build | 74 meson.build | 3 +- 3 files changed, 108 insertions(+), 1 deletion(-) create mode

[dpdk-dev] [PATCH v2 16/17] build: add option to version libs using DPDK version

2017-09-12 Thread Bruce Richardson
Normally, each library has it's own version number based on the ABI. Add an option to have all libs just use the DPDK version number as the .so version. Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- drivers/meson.build | 8 +++- lib/meson.build | 8 +++- meson_op

[dpdk-dev] [PATCH v2 13/17] drivers/net: add drivers for Intel NICs to meson build

2017-09-12 Thread Bruce Richardson
Add the e1000, fm10k, i40e and ixgbe drivers to the meson & ninja build. Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- config/rte_config.h| 12 +++ drivers/net/e1000/base/meson.build | 65 ++ drivers/net/e1000/meson.bui

[dpdk-dev] [PATCH v2 11/17] drivers/net: add net driver support to meson build

2017-09-12 Thread Bruce Richardson
Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- drivers/meson.build | 2 +- drivers/net/meson.build | 35 +++ 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 drivers/net/meson.build diff --git a/drivers/meson.build b/dr

[dpdk-dev] [PATCH v2 12/17] drivers/net: add set of vdev PMDs to build

2017-09-12 Thread Bruce Richardson
Add the af_packet, null, pcap and ring PMDs to the meson build. Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- config/rte_config.h | 4 drivers/net/af_packet/meson.build | 35 + drivers/net/meson.build | 2 +- dri

[dpdk-dev] [PATCH v2 15/17] usertools: add usertools installation to meson build

2017-09-12 Thread Bruce Richardson
Have the "usertools" scripts installed when doing a DPDK install using ninja. They will be copies to $prefix/bin, generally /usr/local/bin, alongside testpmd. Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- meson.build | 3 ++- usertools/meson.build | 32 +++

[dpdk-dev] [PATCH v2 07/17] drivers/mempool: add SW mempool drivers to meson build

2017-09-12 Thread Bruce Richardson
With build infrastructure in place, add in mempool drivers to the build. Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- drivers/mempool/meson.build | 35 +++ drivers/mempool/ring/meson.build | 32 drivers

[dpdk-dev] [PATCH v2 08/17] drivers/crypto: add crypto drv class and null PMD to meson

2017-09-12 Thread Bruce Richardson
Add in a crypto driver class, and implement compiling the null crypto instance. Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- drivers/crypto/meson.build | 35 +++ drivers/crypto/null/meson.build | 33 + dri

[dpdk-dev] [PATCH v2 10/17] crypto/qat: add driver to meson build

2017-09-12 Thread Bruce Richardson
Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- config/rte_config.h| 8 drivers/crypto/meson.build | 2 +- drivers/crypto/qat/meson.build | 41 + 3 files changed, 50 insertions(+), 1 deletion(-) create mode 100

[dpdk-dev] [PATCH v2 06/17] build: add infrastructure for building PMDs

2017-09-12 Thread Bruce Richardson
Add in the top-level drivers meson.build file to start adding in building of PMDs. Since all PMDs are built in pretty much the same way, the logic for building each PMD, including extracting the pmdinfo, is included in the top level build file. This means that each individual driver class only need

[dpdk-dev] [PATCH v2 05/17] build: add buildtools to meson build

2017-09-12 Thread Bruce Richardson
Add the buildtools folder, and more specifically the pmdinfogen binary to the meson and ninja build. This will be needed for building the PMDs in the driver folder later, as the pmd info output from the tool needs to be included in those libs. Signed-off-by: Bruce Richardson Reviewed-by: Harry va

[dpdk-dev] [PATCH v2 09/17] crypto/openssl: add driver to meson build

2017-09-12 Thread Bruce Richardson
Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren --- drivers/crypto/meson.build | 2 +- drivers/crypto/openssl/meson.build | 38 ++ 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/openssl/meson.build d

[dpdk-dev] [PATCH v2 02/17] eal: add eal library to meson build

2017-09-12 Thread Bruce Richardson
Support building the EAL with meson and ninja. This involves a number of different meson.build files for iterating through all the different subdirectories in the EAL. The library itself will be compiled on build but the header files are only copied from their initial location once "ninja install"

[dpdk-dev] [PATCH v2 03/17] igb_uio: add igb_uio kmod to meson build

2017-09-12 Thread Bruce Richardson
Support building igb_uio using meson and ninja. For this, we still use the kernel's kbuild system, by calling out to make, since it's safer and easier than trying to reproduce that in meson. A list of suitable file dependencies is given so that we have a reasonable chance of a rebuild when necessar

[dpdk-dev] [PATCH v2 04/17] build: add DPDK libraries to build

2017-09-12 Thread Bruce Richardson
Add non-EAL libraries to DPDK build. The compat lib is a special case, along with the previously-added EAL, but all other libs can be build using the same set of commands, where the individual meson.build files only need to specify their dependencies, source files, header files and ABI versions. S

[dpdk-dev] [PATCH v2 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-12 Thread Bruce Richardson
To build with meson and ninja, we need some initial infrastructure in place. The build files for meson always need to be called "meson.build", and options get placed in meson_options.txt This commit adds a top-level meson.build file, which sets up the global variables for tracking drivers, librari

[dpdk-dev] [PATCH v2 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-12 Thread Bruce Richardson
V2 changes: * fixed copyright notices, updated 2016 to 2017 * removed dependency on kconfig file in kernel build tree * marked pmdinfogen as a "native" binary, in preparation for future cross- compilation work * added in additional warning flags for compatibility with existing system - Follo

[dpdk-dev] [PATCH] maintainers: update mlx5

2017-09-12 Thread Nelio Laranjeiro
Promote Yongseok as additional maintainer for mlx5 PMD. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: Shahaf Shuler Acked-by: Olga Shern --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a0cd75e..5630dbb 100644 --- a/MAI

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-12 Thread Ananyev, Konstantin
Hi Jayu, > -Original Message- > From: Hu, Jiayu > Sent: Tuesday, September 12, 2017 3:43 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Kavanagh, Mark B > ; Tan, Jianfeng > ; Hu, Jiayu > Subject: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > This patch adds GSO support for TCP/IPv

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items

2017-09-12 Thread Adrien Mazarguil
Hi Beilei, On Tue, Sep 12, 2017 at 06:40:50AM +, Xing, Beilei wrote: > Hi Adrien, > > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Thursday, September 7, 2017 8:20 PM > > To: Xing, Beilei > > Cc: Wu, Jingjing ; Chilikin, Andrey > > ; d

Re: [dpdk-dev] [PATCH v3 1/5] gso: add Generic Segmentation Offload API framework

2017-09-12 Thread Ananyev, Konstantin
Hi Jiayu, Few comments from be inline. Konstantin > diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c > new file mode 100644 > index 000..dda50ee > --- /dev/null > +++ b/lib/librte_gso/rte_gso.c > @@ -0,0 +1,50 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 Intel

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-12 Thread Andrew Rybchenko
On 09/12/2017 11:03 AM, Shahaf Shuler wrote: OK, well understood the requirement for such flags. Thanks for your replies. I think that for simplicity I will add two more flags on the Tx offloads capabilities: DEV_TX_OFFLOADS _MULTI_MEMPOOL <** Device supports transmission of mbufs from multip

Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel_en initialization value

2017-09-12 Thread Adrien Mazarguil
Hi Congwen, On Tue, Sep 12, 2017 at 05:05:50PM +0800, Congwen Zhang wrote: > In function mlx5_pci_probe(), tunnel_en actually be used without > being initialized. Fix it by initializing it to 0. > > Signe-off-by: Congwen Zhang Thanks, however it's already been addressed [1]. The related commit

Re: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-12 Thread Bruce Richardson
On Fri, Sep 08, 2017 at 04:13:58PM +, Richardson, Bruce wrote: > > > > -Original Message- > > From: Van Haaren, Harry > > Sent: Friday, September 8, 2017 5:03 PM > > To: Richardson, Bruce ; dev@dpdk.org > > Cc: Richardson, Bruce > > Subject: RE: [dpdk-dev] [PATCH 01/17] build: add in

[dpdk-dev] [PATCH v2 1/2] app/crypto-perf: add nb-desc parameter

2017-09-12 Thread Anatoly Burakov
This parameter makes number of cryptodev descriptors adjustable and defaults to earlier hardcoded default of 2048. Signed-off-by: Anatoly Burakov --- v2: squashed documentation into code patch fixed commit message fixed documentation app/test-crypto-perf/cperf_options.h | 2 ++

[dpdk-dev] [PATCH v2 2/2] app/crypto-perf: add new PMD benchmarking mode

2017-09-12 Thread Anatoly Burakov
This patch adds a new benchmarking mode, which is intended for microbenchmarking individual parts of the cryptodev framework, specifically crypto ops alloc-build-free, cryptodev PMD enqueue and cryptodev PMD dequeue. It works by first benchmarking crypto operation alloc-build-free loop (no enqueue

[dpdk-dev] [PATCH v2 0/2] New crypto acceleration benchmark mode

2017-09-12 Thread Anatoly Burakov
This patchset adds a new "PMD cyclecount" test mode for test-crypto-perf application. This mode is intended to measure hardware acceleration cost (in terms of cycle count) more accurately than throughput test. The general idea is the following: - Measure build-alloc-free cycle separately - Alloc a

[dpdk-dev] [PATCH v2 2/3] crypto/qat: enable RX head writes coalescing

2017-09-12 Thread Anatoly Burakov
Don't write CSR head until we processed enough RX descriptors. Also delay marking them as free until we are writing CSR head. Signed-off-by: Anatoly Burakov --- v2: fixed commit message doc/guides/rel_notes/release_17_11.rst | 1 + drivers/crypto/qat/qat_crypto.c| 49 ++

[dpdk-dev] [PATCH v2 0/3] performance enhancements for QAT driver

2017-09-12 Thread Anatoly Burakov
A few performance enhancements for QAT crypto driver. These include: - Removing reliance on atomics on hot path - This adds a new limitation, making queue pairs single-threaded - Coalesce RX and TX CSR writes v2: added cover letter fixed commit messages fixed documentation Anatoly Burak

[dpdk-dev] [PATCH v2 3/3] crypto/qat: enable TX tail writes coalescing

2017-09-12 Thread Anatoly Burakov
Don't write CSR tail until we processed enough TX descriptors. To avoid crypto operations sitting in the TX ring indefinitely, the "force write" threshold is used: - on TX, no tail write coalescing will occur if number of inflights is below force write threshold - on RX, check if we have a nu

[dpdk-dev] [PATCH v2 1/3] crypto/qat: remove atomics

2017-09-12 Thread Anatoly Burakov
Replacing atomics in the QAT driver with simple 16-bit integers for number of inflight packets. This adds a new limitation to the QAT driver: each queue pair is now explicitly single-threaded. Signed-off-by: Anatoly Burakov --- v2: fixed commit message fixed documentation doc/guides/crypto

Re: [dpdk-dev] [dpdk-announce] Plan for European and USA DPDK Summits

2017-09-12 Thread O'Driscoll, Tim
The agenda for the DPDK Summit Userspace event in Dublin is available now at: https://dpdksummit.com/. We had far more proposals than we could fit in, so it was difficult to decide which ones to include. We tried to prioritise the key technical topics that should generate some discussion/debate

[dpdk-dev] [PATCH] net/mlx5: fix tunnel_en initialization value

2017-09-12 Thread Congwen Zhang
In function mlx5_pci_probe(), tunnel_en actually be used without being initialized. Fix it by initializing it to 0. Signe-off-by: Congwen Zhang --- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index

[dpdk-dev] [dpdk-techboard] next techboard meeting (15th, September)

2017-09-12 Thread Ananyev, Konstantin
Hi everyone, The next meeting of the tech board will happen on IRC #dpdk-board, at 2pm UTC, on 15th of September(Friday) Agenda: 1) Discussion on Thomas proposal to nominate Ferruh as committer to the main tree and add more sub-trees http://dpdk.org/ml/archives/dev/2017-September/075094.html

Re: [dpdk-dev] git trees organization

2017-09-12 Thread Thomas Monjalon
12/09/2017 10:32, Bruce Richardson: > On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote: [...] > > At the same time, we can think how to add more git sub-trees: > > In principle, I'm in favour, but I think that the subtrees of the master > tree should be at a fairly coarse granularit

Re: [dpdk-dev] git trees organization

2017-09-12 Thread Bruce Richardson
On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote: > Hi all, > > As you know I am currently the only maintainer of the master tree. > It is very convenient because I need to synchronize with others > only when pulling "next-*" trees. > But the drawback is that I should be available v

Re: [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function

2017-09-12 Thread Bruce Richardson
On Mon, Sep 11, 2017 at 06:56:39PM +0100, Ferruh Yigit wrote: > On 9/5/2017 1:04 PM, Markus Theil wrote: > > The patch which introduced the usage of pci_alloc_irq_vectors > > came after the patch which switched to non-threaded ISR (f0d1896fa1), > > but did not use non-threaded ISR, if pci_alloc_irq

Re: [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function

2017-09-12 Thread Bruce Richardson
On Mon, Sep 11, 2017 at 03:04:01PM -0700, Stephen Hemminger wrote: > I wonder if it is time to move the bar forward to oldest LTS which is > 3.2.92 > That seems reasonable. Probably best to do a deprecation notice for it in 17.11 and move the bar in 18.02. /Bruce > > On Sep 11, 2017 10:56 AM,

  1   2   >