[dpdk-dev] [PATCH v2 08/10] mempool/octeontx: implement pool get capability

2017-08-30 Thread Santosh Shukla
Allow mempool HW manager to advertise his pool capability. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- drivers/mempool/octeontx/rte_mempool_octeontx.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/mempool/octeontx/rte_mempool_octeontx.c

[dpdk-dev] [PATCH v2 10/10] doc: add mempool and octeontx mempool device

2017-08-30 Thread Santosh Shukla
This commit adds a section to the docs listing the mempool device PMDs available. It then adds the octeontx fpavf mempool PMD to the listed mempool devices. Cc: John McNamara Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v1 --> v2: - release doc cleanup. - Added Jerin in mainta

[dpdk-dev] [PATCH v2 07/10] mempool/octeontx: implement pool get count

2017-08-30 Thread Santosh Shukla
Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v1 --> v2: - Use new api octeontx_fpa_bufpool_gpool() so to get pool-id. drivers/mempool/octeontx/octeontx_fpavf.c | 27 + drivers/mempool/octeontx/octeontx_fpavf.h | 2 ++ drivers/mempool/octeontx

[dpdk-dev] [PATCH v2 09/10] mempool/octeontx: implement pool update range

2017-08-30 Thread Santosh Shukla
Add support for update range ops in mempool driver. Allow more than one HW pool when using OcteonTx mempool driver: By storing each pool information to the list and find appropriate list element by matching the rte_mempool pointers. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob ---

[dpdk-dev] [PATCH v2 06/10] mempool/octeontx: implement pool enq and deq

2017-08-30 Thread Santosh Shukla
Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v1 --> v2: - Mask the gpool-id from pool handle and pass pool bar to pool enq and deq ops. drivers/mempool/octeontx/Makefile | 13 + drivers/mempool/octeontx/rte_mempool_octeontx.c | 69 - 2 f

[dpdk-dev] [PATCH v2 05/10] mempool/octeontx: implement pool free

2017-08-30 Thread Santosh Shukla
Upon pool free request from application, Octeon FPA free does following: - Uses mbox to reset fpapf pool setup. - frees fpavf resources. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v1 --> v2: - Using newly introduced api 'octeontx_fpa_bufpool_gpool()' for getting the pool-id fro

[dpdk-dev] [PATCH v2 03/10] mempool/octeontx: probe fpavf pcie devices

2017-08-30 Thread Santosh Shukla
A mempool device is set of PCIe vfs. On Octeontx HW, each mempool devices are enumerated as separate SRIOV VF PCIe device. In order to expose as a mempool device: On PCIe probe, the driver stores the information associated with the PCIe device and later upon application pool request (e.g. rte_memp

[dpdk-dev] [PATCH v2 04/10] mempool/octeontx: implement pool alloc

2017-08-30 Thread Santosh Shukla
Upon pool allocation request by application, Octeontx FPA alloc does following: - Gets free pool from pci fpavf array. - Uses mbox to communicate fpapf driver about, * gpool-id * pool block_sz * alignemnt - Programs fpavf pool boundary. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jac

[dpdk-dev] [PATCH v2 02/10] mempool/octeontx: add build and log infrastructure

2017-08-30 Thread Santosh Shukla
Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- config/common_base | 6 +++ drivers/Makefile | 5 +- drivers/mempool/Makefile | 2 + drivers/mempool/octeontx/Makefile | 60

[dpdk-dev] [PATCH v2 01/10] mempool/octeontx: add HW constants

2017-08-30 Thread Santosh Shukla
add HW constants of octeontx fpa mempool device. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- drivers/mempool/octeontx/octeontx_fpavf.h | 71 +++ 1 file changed, 71 insertions(+) create mode 100644 drivers/mempool/octeontx/octeontx_fpavf.h diff --gi

[dpdk-dev] [PATCH v2 00/10] Cavium Octeontx external mempool driver

2017-08-30 Thread Santosh Shukla
v2: Patch implements the HW mempool offload driver for packets buffer. This HW mempool offload driver has dependency on: - IOVA infrastrucure [1]. - Dynamically configure mempool handle (ie.. --mbuf-pool-ops eal arg) [2]. - Infrastructure to support octeontx HW mempool manager [3]. Mempool driver

Re: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dispatch over memcpy

2017-08-30 Thread Li, Xiaoyun
About gcc FMV, I tried it several days ago. But the way that the same function name with different attributions only works in C++. And then I tried GCC6 since it is said that GCC6 would support both C and C++. But it doesn’t work. However, if using different function names with attributions, it

Re: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dispatch over memcpy

2017-08-30 Thread Stephen Hemminger
I was referring to gcc multiversion https://gcc.gnu.org/wiki/FunctionMultiVersioning On Aug 30, 2017 6:24 PM, "Lu, Wenzhuo" wrote: > Hi Stephen, > > > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Thursday, August 31, 2017 2:01 AM > > To

[dpdk-dev] [PATCH v7 8/9] linuxapp/eal_memory: honor iova mode in virt2phy

2017-08-30 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/

[dpdk-dev] [PATCH v7 9/9] eal/rte_malloc: honor iova mode in virt2phy

2017-08-30 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/common/rte_malloc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/li

[dpdk-dev] [PATCH v7 5/9] eal: introduce iova mode helper api

2017-08-30 Thread Santosh Shukla
Introducing rte_eal_iova_mode() helper API. This API used by non-eal library for detecting iova mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/bsdapp/eal/eal.c | 6 ++ lib/librte_eal/bsdapp/eal/rte_eal_version

[dpdk-dev] [PATCH v7 6/9] eal: auto detect iova mode

2017-08-30 Thread Santosh Shukla
For auto detection purpose: * Below calls moved up in the eal initialization order: - eal_option_device_parse - rte_bus_scan Based on the result of rte_bus_scan_iommu_class - select iova mapping mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime C

[dpdk-dev] [PATCH v7 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-08-30 Thread Santosh Shukla
Check iova mode and accordingly map iova to pa or va. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_

[dpdk-dev] [PATCH v7 4/9] bus: get iommu class

2017-08-30 Thread Santosh Shukla
API(rte_bus_get_iommu_class) helps to automatically detect and select appropriate iova mapping scheme for iommu capable device on that bus. Algorithm for iova scheme selection for bus: 0. Iterate through bus_list. 1. Collect each bus iova mode value and update into 'mode' var. 2. Mode selection sc

[dpdk-dev] [PATCH v7 3/9] linuxapp/eal_pci: get iommu class

2017-08-30 Thread Santosh Shukla
Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Patch also introduces RTE_PCI_DRV_IOVA_AS_VA drv flag. Flag used when driver needs to operate in iova=va mode. Algorithm for iova scheme selection for PCI bus: 0. If no device bound then return with RTE

[dpdk-dev] [PATCH v7 1/9] eal/pci: export match function

2017-08-30 Thread Santosh Shukla
Export rte_pci_match() function as it needed in the followup patch. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Acked-by: Maxime Coquelin --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ lib/librte_eal/common/eal_common_pci.c | 10 +- lib/librte_e

[dpdk-dev] [PATCH v7 2/9] eal/pci: get iommu class

2017-08-30 Thread Santosh Shukla
Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova mapping mode for PCI bus. Patch also add rte_pci_get_iommu_class definition for bsdapp, in bsdapp case - api returns default iova mode. Signed-off-by: Santosh Shukla Signed-

[dpdk-dev] [PATCH v7 0/9] Infrastructure to detect iova mapping on the bus

2017-08-30 Thread Santosh Shukla
v7: Includes no major change, minor change detailing: - patch sqashing (Aaron suggestion) - added run_once for device_parse() and bus_scan() in eal init (Aaron suggestion) - Moved rte_eal_device_parse() up in eal initialization order. - Patches rebased on top of version: 17.11-rc0 For v6 in

Re: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dispatch over memcpy

2017-08-30 Thread Lu, Wenzhuo
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, August 31, 2017 2:01 AM > To: Li, Xiaoyun > Cc: Richardson, Bruce ; dev@dpdk.org; Lu, > Wenzhuo ; Wang, Zhihong > ; Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH 1/3] eal/x86:

Re: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dispatch over memcpy

2017-08-30 Thread Lu, Wenzhuo
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Thursday, August 31, 2017 1:52 AM > To: Ananyev, Konstantin > Cc: Li, Xiaoyun ; dev@dpdk.org; Lu, Wenzhuo > ; Wang, Zhihong ; Zhang, > Qi Z > Subject: Re: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dispatch over memcpy > > O

Re: [dpdk-dev] [PATCH v4 5/5] test/cfgfile: add new unit test

2017-08-30 Thread Bruce Richardson
On Mon, Jul 10, 2017 at 02:44:17PM +0200, Jacek Piasecki wrote: > Load huge realloc_sections.ini file to check malloc/realloc > ability of cfgfile library. > > Signed-off-by: Jacek Piasecki > --- This may need some work still. The cfgfile tests fail for me when I run them: RTE>>cfgfile_autotest

Re: [dpdk-dev] [PATCH v4 4/5] cfgfile: rework of load function

2017-08-30 Thread Bruce Richardson
On Mon, Jul 10, 2017 at 02:44:16PM +0200, Jacek Piasecki wrote: > New functions added to cfgfile library make it possible > to significantly simplify the code of rte_cfgfile_load_with_params() > > This patch shows the new body of this function. > > Signed-off-by: Jacek Piasecki > --- > lib/libr

Re: [dpdk-dev] [PATCH v4 3/5] cfgfile: add new functions to API

2017-08-30 Thread Bruce Richardson
Title needs a reword to indicate the types of new API functions e.g.: cfgfile: add APIs for cfgfile modification On Mon, Jul 10, 2017 at 02:44:15PM +0200, Jacek Piasecki wrote: > Extend existing cfgfile library with providing new API functions: > > rte_cfgfile_create() - create new cfgfile object

Re: [dpdk-dev] [PATCH v4 2/5] cfgfile: change existing API functions

2017-08-30 Thread Bruce Richardson
I think the commit title needs rewording. This changes the internals not the API. On Mon, Jul 10, 2017 at 02:44:14PM +0200, Jacek Piasecki wrote: > Change to flat arrays in cfgfile struct force slightly > diffrent data access for most of cfgfile functions. > This patch provides necessary changes i

Re: [dpdk-dev] [PATCH v2 01/15] service: rework probe and get name to use ids

2017-08-30 Thread Pavan Nikhilesh Bhagavatula
On Mon, Aug 21, 2017 at 01:58:02PM +0100, Harry van Haaren wrote: > This commit adds a macro to easily validate a service ID, and then > lookup the service pointer, or return a user-specified error code. > This marco will be heavily used in the following patches as it will > be ID based instead of

[dpdk-dev] [PATCH 11/11] net/sfc: add support for the flow API RSS action

2017-08-30 Thread Andrew Rybchenko
From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/sfc_flow.c | 186 +++- drivers/net/sfc/sfc_flow.h | 15 3 file

[dpdk-dev] [PATCH 07/11] net/sfc/base: update RSS API to take RSS context parameter

2017-08-30 Thread Andrew Rybchenko
From: Mark Spender Update efx_rx_scale_mode_set(), efx_rx_scale_key_set() and efx_rx_scale_tbl_set(). Signed-off-by: Mark Spender Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton --- drivers/net/sfc/base/ef10_impl.h | 3 +++ drive

[dpdk-dev] [PATCH 01/11] net/sfc: fix unused variable warnings in RSS-agnostic build

2017-08-30 Thread Andrew Rybchenko
From: Ivan Malov Unused variables will be found in several places if RSS support is disabled at build time; the patch is to fix it Fixes: 4ec1fc3ba881 ("net/sfc: add basic stubs for RSS support on driver attach") Fixes: d9ff551fc974 ("net/sfc: support RSS hash offload") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH 06/11] net/sfc/base: add API to allocate and free RSS contexts

2017-08-30 Thread Andrew Rybchenko
From: Mark Spender Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton --- drivers/net/sfc/base/ef10_impl.h | 12 +++ drivers/net/sfc/base/ef10_rx.c | 42 + drivers/net/sfc/base/efx.h | 12 +++

[dpdk-dev] [PATCH 09/11] net/sfc/base: add RSS key size define to efx.h

2017-08-30 Thread Andrew Rybchenko
From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/base/ef10_rx.c | 3 +++ drivers/net/sfc/base/efx.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net/sfc/base/ef10_rx.c

[dpdk-dev] [PATCH 10/11] net/sfc: use RSS key size define from base driver

2017-08-30 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc.c| 2 +- drivers/net/sfc/sfc.h| 4 +--- drivers/net/sfc/sfc_ethdev.c | 6 +++--- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c index 08f20dd..cc81fd9 100644 --- a

[dpdk-dev] [PATCH 05/11] net/sfc/base: rename API to check Rx scale and hash support

2017-08-30 Thread Andrew Rybchenko
From: Mark Spender Rename efx_rx_scale_support_get() to efx_rx_scale_default_support_get(), and efx_rx_hash_support_get() to efx_rx_hash_default_support_get(). All these really report is whether an exclusive RSS context was successfully acquired at efx_rx_init(). efx_rx_scale_support_get() soun

[dpdk-dev] [PATCH 08/11] net/sfc/base: add API to set an RSS context for a filter

2017-08-30 Thread Andrew Rybchenko
From: Mark Spender Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton --- drivers/net/sfc/base/ef10_filter.c | 16 +++- drivers/net/sfc/base/efx.h | 7 ++- drivers/net/sfc/base/efx_filter.c | 29

[dpdk-dev] [PATCH 04/11] net/sfc/base: add the max. number of RSS exclusive contexts

2017-08-30 Thread Andrew Rybchenko
From: Mark Spender The patch adds enc_rx_scale_max_exclusive_contexts member to nic_cfg_t structure and sets the corresponding values for Siena, Huntington and Medford Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton --- drivers/n

[dpdk-dev] [PATCH 02/11] net/sfc/base: define a handle to denote default RSS context

2017-08-30 Thread Andrew Rybchenko
From: Mark Spender Make the existing filter-specific define more general. This is the same as MC_CMD_RSS_CONTEXT_ALLOC_OUT_RSS_CONTEXT_ID_INVALID. Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton --- drivers/net/sfc/base/efx.h

[dpdk-dev] [PATCH 03/11] net/sfc/base: fix default RSS context check on Siena

2017-08-30 Thread Andrew Rybchenko
From: Mark Spender Default RSS context check is carried out during filter insertion on Siena and it needs to be fixed Fixes: f7dc06bf35f21 ("net/sfc/base: import 5xxx/6xxx family support") Cc: sta...@dpdk.org Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee

[dpdk-dev] [PATCH 00/11] net/sfc: support flow API RSS action

2017-08-30 Thread Andrew Rybchenko
Few base driver patches have checkpatches.sh errors due to difference in coding conventions. Andrew Rybchenko (1): net/sfc: use RSS key size define from base driver Ivan Malov (3): net/sfc: fix unused variable warnings in RSS-agnostic build net/sfc/base: add RSS key size define to efx.h n

[dpdk-dev] [PATCH 6/6] eal: remove API rte_mem_phy2mch

2017-08-30 Thread Jianfeng Tan
Previously, to get MFN address in dom0, this API is a wrapper to obtain the "physical address". As we removed xen dom0 support, this API is not necessary. Signed-off-by: Jianfeng Tan --- doc/guides/rel_notes/release_17_11.rst | 2 ++ drivers/net/e1000/em_rxtx.c| 4 ++-- driv

[dpdk-dev] [PATCH 4/6] xen: remove xen dependency in drivers, ether, mempool

2017-08-30 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- drivers/crypto/qat/qat_qp.c | 7 +-- drivers/net/i40e/i40e_rxtx.c | 8 ++-- lib/librte_ether/rte_ethdev.c| 7 +-- lib/librte_mempool/rte_mempool.c | 8 ++-- 4 files changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/crypto/

[dpdk-dev] [PATCH 2/6] net/xenvirt: remove

2017-08-30 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- MAINTAINERS | 2 - app/test-pmd/Makefile | 4 - app/test-pmd/testpmd.c | 12 - config/common_base | 5 - config/defconfig_arm-armv7a-linuxapp-

[dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, test

2017-08-30 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- app/test-pmd/testpmd.c | 2 +- examples/ip_pipeline/app.h | 4 -- examples/ip_pipeline/config_parse.c | 19 - examples/ip_pipeline/init.c | 5 --- examples/kni/main.c | 3 -- test/test/process.h

[dpdk-dev] [PATCH 1/6] example/vhost_xen: remove

2017-08-30 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- MAINTAINERS |1 - examples/Makefile |1 - examples/vhost_xen/Makefile | 52 -- examples/vhost_xen/main.c | 1522 --- examples/vhost_xen/main.h | 66 --

[dpdk-dev] [PATCH 0/6] remove xen dom0 support in DPDK

2017-08-30 Thread Jianfeng Tan
Following the calls on the mailing list: http://dpdk.org/ml/archives/dev/2017-June/068151.html The Technical Board decided to drop Xen dom0 support from EAL: http://dpdk.org/ml/archives/dev/2017-June/068615.html This series remove xen dom0 support in DPDK, as well as xenvirt PMD and vhost_

Re: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dispatch over memcpy

2017-08-30 Thread Stephen Hemminger
On Fri, 25 Aug 2017 10:06:11 +0800 Xiaoyun Li wrote: > This patch dynamically selects functions of memcpy at run-time based > on CPU flags that current machine supports. This patch uses function > pointers which are bind to the relative functions at constrctor time. > To make AVX512 instructions

Re: [dpdk-dev] [PATCH v4 1/5] cfgfile: remove EAL dependency

2017-08-30 Thread Bruce Richardson
On Mon, Jul 10, 2017 at 02:44:13PM +0200, Jacek Piasecki wrote: > This patch removes the dependency to EAL in cfgfile library. > > Signed-off-by: Jacek Piasecki Looks ok to me Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dispatch over memcpy

2017-08-30 Thread Bruce Richardson
On Wed, Aug 30, 2017 at 03:56:35PM +0100, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaoyun Li > > Sent: Friday, August 25, 2017 3:06 AM > > To: Richardson, Bruce > > Cc: dev@dpdk.org; Lu, Wenzhuo ; Wang, Zhihong > > ;

Re: [dpdk-dev] [PATCH v3] igb_uio: MSI IRQ mode, irq enable/disable refactored

2017-08-30 Thread Ferruh Yigit
On 8/22/2017 2:28 PM, Markus Theil wrote: > This patch adds MSI IRQ mode and in a way, that should > also work on older kernel versions. The base for my patch > was an attempt to do this in cf705bc36c which was later reverted in > d8ee82745a. Compilation was tested on Linux 3.2, 4.10 and 4.12. > >

[dpdk-dev] [PATCH] net/failsafe: fix errno set on command execution

2017-08-30 Thread Gaetan Rivet
This is unacceptable behavior. Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Fixes: 35ffe4208140 ("net/failsafe: fix missing pclose after popen") Cc: sta...@dpdk.org Reported-by: Matan Azrad Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c | 18 --

Re: [dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-30 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, August 30, 2017 5:25 PM > To: Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: Re: [PATCH] net/failsafe: fix exec parameter parsing error flow > > On Wed,

Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets

2017-08-30 Thread David Harton (dharton)
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Wednesday, August 30, 2017 10:27 AM > To: David Harton (dharton) ; Tahhan, Maryam > > Cc: dev@dpdk.org > Subject: RE: [PATCH] ixgbe: add counter to track sw tx packets > > > > > > > > > -

Re: [dpdk-dev] [PATCH v2 3/6] librte_ether: initialise IPv4 protocol mask for rte_flow

2017-08-30 Thread Iremonger, Bernard
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, August 30, 2017 3:39 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org; Yigit, Ferruh ; Ananyev, > Konstantin ; Dumitrescu, Cristian > > Subject: Re: [PATCH v2 3/6] librte_ether:

Re: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dispatch over memcpy

2017-08-30 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaoyun Li > Sent: Friday, August 25, 2017 3:06 AM > To: Richardson, Bruce > Cc: dev@dpdk.org; Lu, Wenzhuo ; Wang, Zhihong > ; Zhang, Qi Z > ; Li, Xiaoyun > Subject: [dpdk-dev] [PATCH 1/3] eal/x86: run-time dis

[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix clang compilation

2017-08-30 Thread Nelio Laranjeiro
On redhat 7.2 clang reports the following error: CC mlx5_rxmode.o /drivers/net/mlx5/mlx5_ethdev.c:820:32: error: field 'edata' with variable sized type 'struct ethtool_link_settings' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]

[dpdk-dev] [PATCH v2 2/2] net/mlx5: improve stack usage during link update

2017-08-30 Thread Nelio Laranjeiro
Allocate no more memory than necessary for the second call to ETHTOOL_GLINKSETTINGS. Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil -- Changes in v2: Fix the memory space, link_mode_mask_nwords has the size for the three expected arrays. --- drivers/net/mlx5/

Re: [dpdk-dev] [PATCH v2 3/6] librte_ether: initialise IPv4 protocol mask for rte_flow

2017-08-30 Thread Adrien Mazarguil
On Wed, Aug 30, 2017 at 01:28:04PM +, Iremonger, Bernard wrote: > Hi Adrien, > > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Wednesday, August 30, 2017 1:39 PM > > To: Iremonger, Bernard > > Cc: dev@dpdk.org; Yigit, Ferruh ; Ananyev, >

Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets

2017-08-30 Thread Ananyev, Konstantin
> > > > > -Original Message- > > > From: David Harton [mailto:dhar...@cisco.com] > > > Sent: Tuesday, August 29, 2017 4:51 PM > > > To: Ananyev, Konstantin > > > Cc: dev@dpdk.org; David Harton > > > Subject: [PATCH] ixgbe: add counter to track sw tx packets > > > > > > Add counter to tra

Re: [dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-30 Thread Gaëtan Rivet
On Wed, Aug 30, 2017 at 06:11:47AM +, Matan Azrad wrote: > Hi Gaetan > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Tuesday, August 29, 2017 7:34 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > > sta...@dpdk.org > > Subject:

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, August 30, 2017 1:43 PM > To: Ananyev, Konstantin ; Shahaf Shuler > ; Thomas Monjalon > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the > new offloads API > > On 8/30/2017 11:

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix VF device stop issue

2017-08-30 Thread Ferruh Yigit
On 8/29/2017 7:34 PM, Beilei Xing wrote: > i40e HW date is gotten wrongly in i40evf_dev_stop > function, it may cause device can't be stopped. > This patch is to fix the issue. > > Fixes: 185993420249 ("net/i40e: fix VF add/del MAC") > Cc: sta...@dpdk.org > > Signed-off-by: Beilei Xing Applied

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/mlx5: fix clang compilation

2017-08-30 Thread Ferruh Yigit
On 8/29/2017 4:35 PM, Nelio Laranjeiro wrote: > On redhat 7.2 clang reports the following error: >CC mlx5_rxmode.o > /drivers/net/mlx5/mlx5_ethdev.c:820:32: error: field 'edata' with variable > sized type 'struct ethtool_link_settings' not at the end of a struct or > class is a GNU extensi

[dpdk-dev] [PATCH] devtools: rework abi checker script

2017-08-30 Thread Olivier Matz
The intiatial version of the script had some limitations: - cannot work on a non-clean workspace - environment variables are not documented - no compilation log in case of failure - return success even it abi is incompatible This patch addresses these issues and rework the code. Signed-off-by: Ol

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: specify correct scale table size on Rx start

2017-08-30 Thread Ferruh Yigit
On 8/28/2017 1:53 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > efx_rx_scale_tbl_set() takes the number of entries in the scale table > to be set, not the size of the table in bytes; currently this bug does > not make any damage since the size argument is used to wrap the loop > on the input

Re: [dpdk-dev] [PATCH 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK

2017-08-30 Thread Kavanagh, Mark B
>From: Ananyev, Konstantin >Sent: Wednesday, August 30, 2017 11:49 AM >To: Hu, Jiayu >Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, Jianfeng > >Subject: RE: [PATCH 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK > > > >> -Original Message- >> From: Hu, Jiayu >> Sent: Wednesday, August 30, 201

Re: [dpdk-dev] [PATCH] net/thunderx: add device speed capability info

2017-08-30 Thread Ferruh Yigit
On 8/30/2017 12:30 PM, Jerin Jacob wrote: > updated nicvf feature file to mark support. > > Signed-off-by: Jerin Jacob > --- > doc/guides/nics/features/thunderx.ini | 1 + > drivers/net/thunderx/nicvf_ethdev.c | 9 + > 2 files changed, 10 insertions(+) > > diff --git a/doc/guides/nics

Re: [dpdk-dev] [PATCH v2 3/6] librte_ether: initialise IPv4 protocol mask for rte_flow

2017-08-30 Thread Iremonger, Bernard
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, August 30, 2017 1:39 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org; Yigit, Ferruh ; Ananyev, > Konstantin ; Dumitrescu, Cristian > > Subject: Re: [PATCH v2 3/6] librte_ether:

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Kavanagh, Mark B
>From: Ananyev, Konstantin >Sent: Wednesday, August 30, 2017 10:59 AM >To: Ananyev, Konstantin ; Kavanagh, Mark B >; Hu, Jiayu >Cc: dev@dpdk.org; Tan, Jianfeng >Subject: RE: [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support > > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Thomas Monjalon
30/08/2017 14:42, Ferruh Yigit: > On 8/30/2017 11:16 AM, Ananyev, Konstantin wrote: > > Hi Ferruh, > > From: Yigit, Ferruh > >> On 8/30/2017 7:30 AM, Shahaf Shuler wrote: > >>> Tuesday, August 29, 2017 3:55 PM, Ferruh Yigit: > >> Considering the re-configuration is risky, and without other idea

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Ferruh Yigit
On 8/30/2017 11:16 AM, Ananyev, Konstantin wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, August 30, 2017 8:51 AM >> To: Shahaf Shuler ; Thomas Monjalon >> ; Ananyev, Konstantin >> >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [RFC PATCH 4/4] ethd

Re: [dpdk-dev] errors while working with dpdk cuckoo hash

2017-08-30 Thread Shirley Avishour
Hi Pablo, Attached are 2 files. one which contains the results and the other is the c code. I will attach the c file again. I managed to recreate the problem after upgrading to stable version dpdk-stable-16.11.2. Thanks, Shirley. On Wed, Aug 30, 2017 at 3:37 PM, De Lara Guarch, Pablo < pablo.de.l

Re: [dpdk-dev] [PATCH v2 3/6] librte_ether: initialise IPv4 protocol mask for rte_flow

2017-08-30 Thread Adrien Mazarguil
Hi Bernard, On Fri, Aug 25, 2017 at 05:10:35PM +0100, Bernard Iremonger wrote: > Initialise the next_proto_id mask in the default mask for > rte_flow_item_type_ipv4. > > Signed-off-by: Bernard Iremonger > --- > lib/librte_ether/rte_flow.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [dpdk-dev] errors while working with dpdk cuckoo hash

2017-08-30 Thread De Lara Guarch, Pablo
Hi Shirley, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shirley Avishour > Sent: Monday, August 21, 2017 12:37 PM > To: dev@dpdk.org > Subject: [dpdk-dev] errors while working with dpdk cuckoo hash > > Hi, > > I am running an application over dpdk ver 16.0

Re: [dpdk-dev] [PATCH 0/2] virtio: cleanup virtio code

2017-08-30 Thread Maxime Coquelin
Hi Zhiyong, On 08/03/2017 03:21 AM, Zhiyong Yang wrote: This patchset has some trivial changes and make it easier to read code. Zhiyong Yang (2): virtio: fix the wrong indent virtio: use macro to replace magic number drivers/net/virtio/virtio_pci.c | 2 +- drivers/net/virtio/virtqueue

[dpdk-dev] [PATCH] net/thunderx: add device speed capability info

2017-08-30 Thread Jerin Jacob
updated nicvf feature file to mark support. Signed-off-by: Jerin Jacob --- doc/guides/nics/features/thunderx.ini | 1 + drivers/net/thunderx/nicvf_ethdev.c | 9 + 2 files changed, 10 insertions(+) diff --git a/doc/guides/nics/features/thunderx.ini b/doc/guides/nics/features/thunderx.

[dpdk-dev] [dpdk-announce] DPDK 16.11.3 (LTS) released

2017-08-30 Thread Yuanhan Liu
Hi all, Here is a new LTS release, v16.11.3: http://fast.dpdk.org/rel/dpdk-16.11.3.tar.xz The git tree is at: http://dpdk.org/browse/dpdk-stable/ Thanks. --yliu --- app/test/test_cryptodev.c| 20 ++- app/test/test_cryptodev_hash_test_vectors.h |

Re: [dpdk-dev] [PATCH 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK

2017-08-30 Thread Ananyev, Konstantin
> -Original Message- > From: Hu, Jiayu > Sent: Wednesday, August 30, 2017 8:37 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, Jianfeng > > Subject: Re: [PATCH 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK > > Hi Konstantin, > > Thanks for your suggestions

Re: [dpdk-dev] [PATCH] net/virtio: fix an incorrect behavior of device stop/start

2017-08-30 Thread Tiwei Bie
Hi Jens, On Wed, Aug 30, 2017 at 11:13:06AM +0200, Jens Freimann wrote: > Hi Tiwei, > > On Tue, Aug 29, 2017 at 04:26:01PM +0800, Tiwei Bie wrote: > > After starting a device, the driver shouldn't deliver the > > packets that already existed in the device before it is > > started to the applicati

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Ananyev, Konstantin
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, August 30, 2017 8:51 AM > To: Shahaf Shuler ; Thomas Monjalon > ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the > new offloads API > > On 8/3

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Wednesday, August 30, 2017 10:39 AM > To: Kavanagh, Mark B ; Hu, Jiayu > > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support >

Re: [dpdk-dev] [PATCH v2 0/5] Optimize memcpy for AVX512 platforms

2017-08-30 Thread linhaifeng
在 2016/1/18 11:05, Zhihong Wang 写道: > This patch set optimizes DPDK memcpy for AVX512 platforms, to make full > utilization of hardware resources and deliver high performance. > > In current DPDK, memcpy holds a large proportion of execution time in > libs like Vhost, especially for large packets,

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Ananyev, Konstantin
Hi Mark, > >> > + > >> > +void > >> > +gso_parse_packet(struct rte_mbuf *pkt) > >> > >> There is a function rte_net_get_ptype() that supposed to provide similar > >functionality. > >> So we probably don't need to create a new SW parse function here, instead > >would be better > >> to reuse (and up

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Kavanagh, Mark B
>From: Hu, Jiayu >Sent: Wednesday, August 30, 2017 3:56 AM >To: Ananyev, Konstantin >Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, Jianfeng > >Subject: Re: [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support > >Hi Konstantin, > >Thanks for your important suggestions. My feedbacks are inline. > >On Wed, Aug

Re: [dpdk-dev] [PATCH 0/4] care about encapsulated packets on SFN8xxx

2017-08-30 Thread Ferruh Yigit
On 8/28/2017 2:25 PM, Andrew Rybchenko wrote: > checkpatches.sh generates errors etc because of a bit different > coding style in base driver. > > Andrew Rybchenko (1): > net/sfc/base: provide information about supported tunnels > > Mark Spender (3): > net/sfc/base: use proper MCDI command fo

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: specify correct scale table size on Rx start

2017-08-30 Thread Andrew Rybchenko
On 08/29/2017 08:03 PM, Ferruh Yigit wrote: On 8/28/2017 1:53 PM, Andrew Rybchenko wrote: From: Ivan Malov efx_rx_scale_tbl_set() takes the number of entries in the scale table to be set, not the size of the table in bytes; currently this bug does not make any damage since the size argument is

Re: [dpdk-dev] [PATCH] net/virtio: fix an incorrect behavior of device stop/start

2017-08-30 Thread Jens Freimann
Hi Tiwei, On Tue, Aug 29, 2017 at 04:26:01PM +0800, Tiwei Bie wrote: After starting a device, the driver shouldn't deliver the packets that already existed in the device before it is started to the applications. This patch fixes this issue by flushing the Rx queues when starting the device. Fix

[dpdk-dev] [PATCH 2/2] net/sfc: add support for Tx descriptor status API

2017-08-30 Thread Andrew Rybchenko
From: Ivan Malov Support for the feature is added to EFX Tx datapath Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/sfc_efx.ini | 1 + drivers/net/sfc/sfc_dp_tx.h | 7 +++ drivers/net/sfc/sfc_ef10_tx.c| 10 + drivers/net/s

Re: [dpdk-dev] [PATCH v3] net/failsafe: fix failsafe bus uninit return value

2017-08-30 Thread Ferruh Yigit
On 8/29/2017 10:28 AM, Gaëtan Rivet wrote: > On Tue, Aug 29, 2017 at 12:08:08PM +0300, Raslan Darawsheh wrote: >> fs_bus_uninit is always returning 0 no matter what was the status >> of each sub device bus_uninit value. >> >> Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Cc: sta...@dpdk.org >

[dpdk-dev] [PATCH 1/2] net/sfc: add support for Rx descriptor status API

2017-08-30 Thread Andrew Rybchenko
From: Ivan Malov Support for the feature is added to EFX Rx datapath Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/sfc_efx.ini | 1 + drivers/net/sfc/sfc_dp_rx.h | 5 + drivers/net/sfc/sfc_ef10_rx.c| 9 + drivers/net/sfc

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Jiayu Hu
Hi Konstantin, On Wed, Aug 30, 2017 at 09:38:33AM +0800, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Hu, Jiayu > > Sent: Thursday, August 24, 2017 3:16 PM > > To: dev@dpdk.org > > Cc: Kavanagh, Mark B ; Ananyev, Konstantin > > ; Tan, Jianfeng > > ; Hu, Jiayu > > Sub

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix itr setting in PF

2017-08-30 Thread Ferruh Yigit
On 8/24/2017 2:57 AM, Jingjing Wu wrote: > As no matter the PF host driver is DPDK or other kernel drivers, > they are sharing the same virtchnnl interfaces to communicate to > VFs. To follow the generic interface, DPDK PF need to set ITR > index according to the rxitr_idx from virtchnnl instead of

Re: [dpdk-dev] [PATCH 0/3] remove unused code of DPDK version

2017-08-30 Thread Ferruh Yigit
On 8/23/2017 9:44 AM, Beilei Xing wrote: > Since there's no specific version number to distinguish > DPDK pf and Linux kernel pf, DPDK vf won't recognize if > host is DPDK pf or kernel pf. The specific virtual channel > commands for DPDK pf and code of DPDK version can be deleted. > > Beilei Xing

Re: [dpdk-dev] [PATCH 6/6] app/crypto-perf: use single mempool

2017-08-30 Thread Akhil Goyal
Hi Pablo, On 8/18/2017 1:35 PM, Pablo de Lara wrote: In order to improve memory utilization, a single mempool is created, containing the crypto operation and mbufs (one if operation is in-place, two if out-of-place). This way, a single object is allocated and freed per operation, reducing the amo

Re: [dpdk-dev] [PATCH 1/5] lib: add Generic Segmentation Offload API framework

2017-08-30 Thread Jiayu Hu
Hi Konstantin, On Wed, Aug 30, 2017 at 09:38:02AM +0800, Ananyev, Konstantin wrote: > Hi Jiayu, > > > > > Generic Segmentation Offload (GSO) is a SW technique to split large > > packets into small ones. Akin to TSO, GSO enables applications to > > operate on large packets, thus reducing per-pack

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Ferruh Yigit
On 8/30/2017 7:30 AM, Shahaf Shuler wrote: > Tuesday, August 29, 2017 3:55 PM, Ferruh Yigit: Considering the re-configuration is risky, and without other ideas I will >> need to fall back to the error flow case. Are we OK with that? >>> >>> I think we can take the risk of keeping this cal

Re: [dpdk-dev] [PATCH 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK

2017-08-30 Thread Jiayu Hu
Hi Konstantin, Thanks for your suggestions. Feedbacks are inline. Thanks, Jiayu On Wed, Aug 30, 2017 at 09:37:42AM +0800, Ananyev, Konstantin wrote: > > Hi Jiayu, > Few questions/comments from me below in in next few mails. > Thanks > Konstantin > > > > > Generic Segmentation Offload (GSO) is

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: specify correct scale table size on Rx start

2017-08-30 Thread Ferruh Yigit
On 8/29/2017 6:03 PM, Ferruh Yigit wrote: > On 8/28/2017 1:53 PM, Andrew Rybchenko wrote: >> From: Ivan Malov >> >> efx_rx_scale_tbl_set() takes the number of entries in the scale table >> to be set, not the size of the table in bytes; currently this bug does >> not make any damage since the size

  1   2   >