Hi Pablo,
On 8/18/2017 1:35 PM, Pablo de Lara wrote:
In order to improve memory utilization, a single mempool
is created, containing the crypto operation and mbufs
(one if operation is in-place, two if out-of-place).
This way, a single object is allocated and freed
per operation, reducing the amount of memory in cache,
which improves scalability.

Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>
---
  app/test-crypto-perf/cperf_ops.c             |  96 ++++++--
  app/test-crypto-perf/cperf_ops.h             |   2 +-
  app/test-crypto-perf/cperf_test_latency.c    | 350 ++++++++++++--------------
  app/test-crypto-perf/cperf_test_throughput.c | 347 ++++++++++++--------------
  app/test-crypto-perf/cperf_test_verify.c     | 356 ++++++++++++---------------
  5 files changed, 553 insertions(+), 598 deletions(-)

NACK.
This patch replaces rte_pktmbuf_pool_create with the rte_mempool_create for mbufs, which is not a preferred way to allocate memory for pktmbuf.

Any example/test application in DPDK should not be using this, as this kind of usages will not be compatible for all dpdk drivers in general.

This kind of usages of rte_mempool_create will not work for any devices using hw offloaded memory pools for pktmbuf.
one such example is dpaa2.

-Akhil

Reply via email to