Re: [dpdk-dev] [PATCH 1/2] net/mlx5: replace memory barrier type

2017-08-23 Thread Shahaf Shuler
Wednesday, August 23, 2017 4:12 PM, Bruce Richardson: > On Wed, Aug 23, 2017 at 01:39:08PM +0200, Nélio Laranjeiro wrote: > > On Mon, Aug 21, 2017 at 10:47:01AM +0300, Sagi Grimberg wrote: > > > > Acked-by: Nelio Laranjeiro > > > While a compiler barrier may do on platforms with strong ordering, I

Re: [dpdk-dev] [RFC] net/mlx5: support count flow action

2017-08-23 Thread Nélio Laranjeiro
Hi Ori, Please keep the coding style of the file, and pass checkpatch before submitting a patch on the mailing list. It helps the review by having a correct patch respecting the coding style of the file. I won't spot out here all the coding style issues, if you need some help, feel free to ask.

[dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush

2017-08-23 Thread Wei Zhao
This feature enable queue regions configuration for RSS in PF/VF, so that different traffic classes or different packet classification types can be separated to different queues in different queue regions.This patch can set queue region range, it include queue number in a region and the index of fi

[dpdk-dev] [PATCH 0/2] net/i40e: API to configure queue regions for RSS

2017-08-23 Thread Wei Zhao
The patches mainly finish following functions: 1) Command line for input queue region configure parameters. 2) Set or flush queue region configutation. root (2): net/i40e: queue region set and flush app/testpmd: add API for configuration of queue region app/test-pmd/cmdline.c

[dpdk-dev] [PATCH 2/2] app/testpmd: add API for configuration of queue region

2017-08-23 Thread Wei Zhao
This patch add a API configuration of queue region in rss. It can parse the parameters of region index, queue number, queue start index, user priority, traffic classes and so on. According to commands from command line, it will call i40e private API and start the process of set or flush queue regio

[dpdk-dev] [PATCH] vhost: adaptively batch small guest memory copies

2017-08-23 Thread Tiwei Bie
This patch adaptively batches the small guest memory copies. By batching the small copies, the efficiency of executing the memory LOAD instructions can be improved greatly, because the memory LOAD latency can be effectively hidden by the pipeline. We saw great performance boosts for small packets P

[dpdk-dev] [PATCH v3] eal: add counter size for efd clean

2017-08-23 Thread Jingjing Wu
For virtual device, the rte_intr_handle struct is initialized by the virtual device driver, including the event fd assignment. If the event fd need to be read for clean, an argument is required for the proper event fd read. This patch adds efd_counter_size in rte_intr_handle struct to tell the rx

[dpdk-dev] [PATCH] net/i40e: fix itr setting in PF

2017-08-23 Thread Jingjing Wu
As no matter the PF host driver is DPDK or other kernel drivers, they are sharing the same virtchnnl interfaces to communicate to VFs. To follow the generic interface, DPDK PF need to set ITR index according to the rxitr_idx from virtchnnl instead of ITR_NONE. Fixes: 6d59e4ea74a6 ("net/i40e: chang

Re: [dpdk-dev] [PATCH 0/4] Introducing NXP dpaa_sec based cryptodev pmd

2017-08-23 Thread Akhil Goyal
On 8/24/2017 5:31 AM, Akhil Goyal wrote: Based over the DPAA PMD driver [1], this series of patches introduces the DPAA_SEC PMD which provides DPDK crypto driver for NXP's DPAA CAAM Hardware accelerator. SEC is NXP DPAA SoC's security engine for cryptographic acceleration and offloading. It impl

[dpdk-dev] [PATCH 4/4] doc: add NXP DPAA SEC

2017-08-23 Thread Akhil Goyal
Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- MAINTAINERS | 2 + doc/guides/cryptodevs/dpaa_sec.rst | 182 doc/guides/cryptodevs/features/dpaa_sec.ini | 40 ++ doc/guides/cryptodevs/index.rst

[dpdk-dev] [PATCH 2/4] crypto/dpaa_sec: add crypto driver for NXP DPAA platform

2017-08-23 Thread Akhil Goyal
Signed-off-by: Forrest Shi Signed-off-by: Akhil Goyal Signed-off-by: Hemant Agrawal --- MAINTAINERS|5 + config/common_base |8 + config/defconfig_arm64-dpaa-linuxapp-gcc | 14 + drivers/Makefile

[dpdk-dev] [PATCH 0/4] Introducing NXP dpaa_sec based cryptodev pmd

2017-08-23 Thread Akhil Goyal
Based over the DPAA PMD driver [1], this series of patches introduces the DPAA_SEC PMD which provides DPDK crypto driver for NXP's DPAA CAAM Hardware accelerator. SEC is NXP DPAA SoC's security engine for cryptographic acceleration and offloading. It implements block encryption, stream cipher, has

[dpdk-dev] [PATCH 3/4] test/crypto: add dpaa crypto test cases

2017-08-23 Thread Akhil Goyal
Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- test/test/test_cryptodev.c | 203 ++- test/test/test_cryptodev_aes_test_vectors.h | 78 ++ test/test/test_cryptodev_blockcipher.c | 7 + test/test/test_cryptodev_blockcipher.h

[dpdk-dev] [PATCH 1/4] bus/dpaa: scan for DPAA Crypto devices

2017-08-23 Thread Akhil Goyal
Signed-off-by: Shreyansh Jain Signed-off-by: Akhil Goyal --- config/defconfig_arm64-dpaa-linuxapp-gcc | 3 ++ drivers/bus/dpaa/dpaa_bus.c | 51 2 files changed, 54 insertions(+) diff --git a/config/defconfig_arm64-dpaa-linuxapp-gcc b/config/defcon

Re: [dpdk-dev] [RFC PATCH 0/1] eventtimer: introduce event timer wheel

2017-08-23 Thread Carrillo, Erik G
Hi Jerin, Thanks for sharing your proposal. We have implemented something quite similar locally. In applications that utilize the eventdev framework, entities we call "bridge drivers" are configured, and they are analogous to service cores. One such bridge driver, the Timer Bridge Driver, ru

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread David Harton (dharton)
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, August 23, 2017 5:57 PM > To: David Harton (dharton) > Cc: tho...@monjalon.net; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf > by rte_eth_stats

Re: [dpdk-dev] [RFC PATCH 0/4] ethdev new offloads API

2017-08-23 Thread Thomas Monjalon
07/08/2017 12:54, Shahaf Shuler: > The new API does not have an equivalent for the below Tx flags: > > * ETH_TXQ_FLAGS_NOREFCOUNT > * ETH_TXQ_FLAGS_NOMULTMEMP > > The reason is that those flags are not to manage offloads, rather some > guarantee from application on the way it uses mbufs, therefor

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-23 Thread Thomas Monjalon
23/08/2017 15:13, Shahaf Shuler: > Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > > From: Shahaf Shuler > > > In order to enable PMDs to support only one of the APIs, and > > > applications to avoid branching according to the underlying device a > > > copy functions to/from the old/new

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread Stephen Hemminger
On Tue, 22 Aug 2017 22:55:55 -0400 David Harton wrote: > rte_eth_stats_get() unconditonally would set rx_nombuf > even if the device was setting the value. A check has > been added in rte_eth_stats_get() to leave the device > value in-tact when non-zero. > > Signed-off-by: David Harton > --- >

Re: [dpdk-dev] [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API

2017-08-23 Thread Thomas Monjalon
07/08/2017 12:54, Shahaf Shuler: > Introduce a new API to configure Rx offloads. > > The new API will re-use existing DEV_RX_OFFLOAD_* flags > to enable the different offloads. This will ease the process > of adding a new Rx offloads, as no ABI breakage is involved. > In addition, the offload conf

Re: [dpdk-dev] [RFC PATCH 1/4] ethdev: rename Rx and Tx configuration structs

2017-08-23 Thread Thomas Monjalon
07/08/2017 12:54, Shahaf Shuler: > Rename the structs rte_eth_txconf and rte_eth_rxconf to > rte_eth_txq_conf and rte_eth_rxq_conf respectively as those > structs represent per queue configuration. > > Signed-off-by: Shahaf Shuler Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread Thomas Monjalon
23/08/2017 23:27, David Harton (dharton): > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 23/08/2017 14:18, David Harton (dharton): > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 23/08/2017 04:55, David Harton: > > > > > rte_eth_stats_get() unconditonally would set rx_nom

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread David Harton (dharton)
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, August 23, 2017 9:24 AM > To: David Harton (dharton) > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by > rte_eth_stats_get > > 23/08/2017 14:18, David Harton

Re: [dpdk-dev] [PATCH 0/3] *** timer library enhancements ***

2017-08-23 Thread Wiles, Keith
> On Aug 23, 2017, at 2:28 PM, Carrillo, Erik G > wrote: > >> >> -Original Message- >> From: Wiles, Keith >> Sent: Wednesday, August 23, 2017 11:50 AM >> To: Carrillo, Erik G >> Cc: rsanf...@akamai.com; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 0/3] *** timer library enhancements

Re: [dpdk-dev] Request to create dpdk-next-cli tree

2017-08-23 Thread Thomas Monjalon
+ Cc techboard 23/08/2017 19:13, Wiles, Keith: > > Please include this request in the next techboard meeting to create a > dpdk-next-cli tree. > > Also include as a different topic in the meeting a discussion on how the > cmdline is replaced with CLI along with the timelines. I ask for this >

Re: [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin

2017-08-23 Thread Thomas Monjalon
Please could you explain why the asm code was used? Are you sure this builtin is implemented everywhere?

Re: [dpdk-dev] [RFC] remove redundant file header note

2017-08-23 Thread Thomas Monjalon
21/08/2017 15:51, Ferruh Yigit: > Some of the "All rights reserved." note looks like duplicate, there is > one for each copyright note in the same line, and extra one after the > copyright notes. Sample is in below patch. > > Although this looks like a duplication, I am not sure if this is a legal

Re: [dpdk-dev] cuckoo hash in dpdk

2017-08-23 Thread Pragash Vijayaragavan
And yea, mod will take only 1 Clock cycle that way :) Also if divisor is a power of 2, a / b can be done like ( Given a is unsigned, a > b and since our hash values are greater than 0, a is our hash value, b the power of 2) while(b != 1) { a >>= 1; b >>= 1; } which is less clock cycle

Re: [dpdk-dev] 答复: Re: [PATCH] app/testpmd:add bond type description

2017-08-23 Thread Thomas Monjalon
16/08/2017 04:31, xie.rongqi...@zte.com.cn: > I am sorry to reply so late for some reason. > > And i figure out two ways to implement this kind of things inside the > bonding code, > > First,if can the function rte_eth_bond_mode_get() return string, so we can > print No it is better to use int

Re: [dpdk-dev] cuckoo hash in dpdk

2017-08-23 Thread Pragash Vijayaragavan
Hi , The performance will depend on the time taken for calculating the hash1 and hash2 values for each lookup. Can i know which hash functions are used to calculate the hash values for each incoming key. We use CRC32 which uses xxhash i guess. I could not find the implementation of the hash funct

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: support device removal event

2017-08-23 Thread Matan Azrad
Hi Nelio > -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Wednesday, August 23, 2017 12:41 PM > To: Matan Azrad > Cc: Adrien Mazarguil ; dev@dpdk.org > Subject: Re: [PATCH 1/2] net/mlx5: support device removal event > > Hi Matan, > > On Sun, Aug

Re: [dpdk-dev] [PATCH 0/3] *** timer library enhancements ***

2017-08-23 Thread Carrillo, Erik G
> -Original Message- > From: Wiles, Keith > Sent: Wednesday, August 23, 2017 11:50 AM > To: Carrillo, Erik G > Cc: rsanf...@akamai.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/3] *** timer library enhancements *** > > > > On Aug 23, 2017, at 11:19 AM, Carrillo, Erik G > wrote:

Re: [dpdk-dev] cuckoo hash in dpdk

2017-08-23 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pragash > Vijayaragavan > Sent: Wednesday, August 23, 2017 3:16 PM > To: dev@dpdk.org > Cc: Minseok Kwon > Subject: [dpdk-dev] cuckoo hash in dpdk > > Hi, > > I got the chance to look at the cuckoo hash used in

[dpdk-dev] Request to create dpdk-next-cli tree

2017-08-23 Thread Wiles, Keith
Please include this request in the next techboard meeting to create a dpdk-next-cli tree. Also include as a different topic in the meeting a discussion on how the cmdline is replaced with CLI along with the timelines. I ask for this discussion as a different topic as creating the tree should n

Re: [dpdk-dev] [PATCH 0/3] *** timer library enhancements ***

2017-08-23 Thread Wiles, Keith
> On Aug 23, 2017, at 11:19 AM, Carrillo, Erik G > wrote: > > > >> -Original Message- >> From: Wiles, Keith >> Sent: Wednesday, August 23, 2017 10:02 AM >> To: Carrillo, Erik G >> Cc: rsanf...@akamai.com; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 0/3] *** timer library enhanceme

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-08-23 Thread Stephen Hemminger
On Wed, 23 Aug 2017 18:14:44 +0200 Olivier MATZ wrote: > On Wed, Aug 23, 2017 at 08:31:35AM -0700, Stephen Hemminger wrote: > > On Wed, 23 Aug 2017 11:30:26 +0200 > > Olivier MATZ wrote: > > > > > Hello, > > > > > > On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote: > > > > On Fr

Re: [dpdk-dev] [PATCH 0/3] *** timer library enhancements ***

2017-08-23 Thread Carrillo, Erik G
> -Original Message- > From: Wiles, Keith > Sent: Wednesday, August 23, 2017 10:02 AM > To: Carrillo, Erik G > Cc: rsanf...@akamai.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/3] *** timer library enhancements *** > > > > On Aug 23, 2017, at 9:47 AM, Gabriel Carrillo > wrote:

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-23 Thread Thomas Monjalon
23/08/2017 17:09, Gaëtan Rivet: > Hello Raslan, > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > > Added hotplug in testpmd, to be able to test hotplug function > > in the PMD's. > > > > Signed-off-by: Raslan Darawsheh [...] > > --- a/app/test-pmd/cmdline.c > > +++ b/app/t

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-08-23 Thread Olivier MATZ
On Wed, Aug 23, 2017 at 08:31:35AM -0700, Stephen Hemminger wrote: > On Wed, 23 Aug 2017 11:30:26 +0200 > Olivier MATZ wrote: > > > Hello, > > > > On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote: > > > On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > > > > While

[dpdk-dev] [PATCH 6/6] ixgbe: remove unnecessary cast of rte_memcpy

2017-08-23 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_flow.c | 20 ++-- drivers/net/ixgbe/ixgbe_tm.c | 6 +++--- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH 5/6] i40e: remove unnecessary cast of rte_memcpy

2017-08-23 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c| 54 +++ drivers/net/i40e/i40e_ethdev_vf.c | 10 drivers/net/i40e/i40e_fdir.c | 2 +- drivers/net/i40e/i40e_pf.c| 2 +- drivers/net/i40e/i40e_tm.c| 6 ++---

[dpdk-dev] [PATCH 4/6] e1000: remove unnecessary cast of rte_memcpy

2017-08-23 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_flow.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index ed2ecc40ceda..76c0c520f8a1 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1

[dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts

2017-08-23 Thread Stephen Hemminger
The testpmd was doing old BSD lint style casts of rte_memcpy to (void). This is unnecessary. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 14 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.c | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff

[dpdk-dev] [PATCH 3/6] sfc: remove unnecessary cast of rte_memcpy

2017-08-23 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 12bcd6fa7828..3a1e989eff18 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_et

[dpdk-dev] [PATCH 2/6] bnx2x: remove unnecssary void cast of rte_memcpy

2017-08-23 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c| 6 +++--- drivers/net/bnx2x/bnx2x.h| 4 ++-- drivers/net/bnx2x/ecore_sp.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 06733d153280..44222a

[dpdk-dev] [PATCH 0/6] remove unncessary void cast

2017-08-23 Thread Stephen Hemminger
There are many places that cast away the return value from rte_memcpy(). This was a common practice in the Unix BSD days because lint would complain about unused return values, but it is not done in modern Linux style because it clutters the code. Maybe it was done for some Coverity warnings. If

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-08-23 Thread Stephen Hemminger
On Wed, 23 Aug 2017 11:30:26 +0200 Olivier MATZ wrote: > Hello, > > On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote: > > On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > > > While doing code for Hyper-V, noticed that the virtio driver was > > > confused about re

[dpdk-dev] [PATCH] timer: fix reset on service cores

2017-08-23 Thread Pavan Nikhilesh
- API rte_timer_reset() should be able to register timers on service lcores as they are EAL threads. Fixes: af75078fece3 ("first public release") Signed-off-by: Pavan Nikhilesh --- This patch depends on http://dpdk.org/dev/patchwork/patch/27818/ lib/librte_timer/rte_timer.c | 3 ++- 1 file cha

[dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API.

2017-08-23 Thread Pavan Nikhilesh
This API can be used to test if an lcore(EAL thread) is a service lcore. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/include/rte_lcore.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include

Re: [dpdk-dev] [PATCH] net/mlx5: fix xstats functions unlock missing

2017-08-23 Thread Nélio Laranjeiro
On Mon, Aug 14, 2017 at 02:32:24PM +0300, Matan Azrad wrote: > The corrupted code didn't unlock the spinlock in xstats > get and reset functions error flow. > > Hence, if these errors happaned, the device spinlock was > left locked and many mlx5 device functionalities were blocked. > > The fix un

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-23 Thread Gaëtan Rivet
Hello Raslan, On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > Added hotplug in testpmd, to be able to test hotplug function > in the PMD's. > > Signed-off-by: Raslan Darawsheh > --- > app/test-pmd/cmdline.c | 44 > app/test-pmd/te

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: add hardware timestamp

2017-08-23 Thread Nélio Laranjeiro
On Tue, Aug 22, 2017 at 04:46:10PM +0300, Raslan Darawsheh wrote: > Expose a new capapilty of Rx hw timestamp and > added new device args to enable it hw_timestamp. > It will add the raw hw timestamp into the packets. > > Its expected that it will lower down the performance since using it > will d

Re: [dpdk-dev] [PATCH 0/3] *** timer library enhancements ***

2017-08-23 Thread Wiles, Keith
> On Aug 23, 2017, at 9:47 AM, Gabriel Carrillo > wrote: > > In the current implementation of the DPDK timer library, timers can be > created and set to be handled by a target lcore by adding it to a > skiplist that corresponds to that lcore. However, if an application > enables multiple lcore

[dpdk-dev] [PATCH] eal/x86: use cpuid builtin

2017-08-23 Thread Sergio Gonzalez Monroy
GCC does have the __get_cpuid_count builtin which checks for maximum supported leaf, but implementations differ between CLANG and GCC. This change provides an implementation compatible with both GCC and CLANG 3.4+. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/arch/x86/rte_cpu

[dpdk-dev] [PATCH] eal/x86: implement x86 specific tsc hz

2017-08-23 Thread Sergio Gonzalez Monroy
First, try to use CPUID Time Stamp Counter and Nominal Core Crystal Clock Information Leaf to determine the tsc hz on platforms that supports it (does not require priviledge user). If the CPUID leaf is not available, then try to determine the tsc hz by reading the MSR 0xCE (requires priviledge use

Re: [dpdk-dev] [PATCH] eal: add config option to enable asserts

2017-08-23 Thread Wiles, Keith
> On Aug 23, 2017, at 9:09 AM, Gaëtan Rivet wrote: > > Hi, > > On Wed, Aug 23, 2017 at 10:00:08PM +0800, Xueming Li wrote: >> Currently, enabling assertion have to set CONFIG_RTE_LOG_LEVEL to >> RTE_LOG_DEBUG. CONFIG_RTE_LOG_LEVEL is the default log level of control >> path, RTE_LOG_DP_LEVEL is

[dpdk-dev] [PATCH 3/3] doc: update timer lib docs

2017-08-23 Thread Gabriel Carrillo
This change updates the timer library documentation to reflect a change to the organization of the skiplists in the implementation. Signed-off-by: Gabriel Carrillo --- doc/guides/prog_guide/timer_lib.rst | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/doc

[dpdk-dev] [PATCH 2/3] timer: handle timers installed from non-EAL threads

2017-08-23 Thread Gabriel Carrillo
This commit adds support for timers being created from non-EAL threads; it maps timers from all such threads to lcore id RTE_MAX_LCORE, and puts them all in a corresponding skiplist. Signed-off-by: Gabriel Carrillo --- lib/librte_timer/rte_timer.c | 48 ++

[dpdk-dev] [PATCH 1/3] timer: add per-installer pending lists for each lcore

2017-08-23 Thread Gabriel Carrillo
Instead of each priv_timer struct containing a single skiplist, this commit adds a skiplist for each enabled lcore to priv_timer. In the case that multiple lcores repeatedly install timers on the same target lcore, this change reduces lock contention for the target lcore's skiplists and increases p

[dpdk-dev] [PATCH 0/3] *** timer library enhancements ***

2017-08-23 Thread Gabriel Carrillo
In the current implementation of the DPDK timer library, timers can be created and set to be handled by a target lcore by adding it to a skiplist that corresponds to that lcore. However, if an application enables multiple lcores, and each of these lcores repeatedly attempts to install timers on th

[dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-23 Thread Raslan Darawsheh
Added hotplug in testpmd, to be able to test hotplug function in the PMD's. Signed-off-by: Raslan Darawsheh --- app/test-pmd/cmdline.c | 44 app/test-pmd/testpmd.c | 18 ++ app/test-pmd/testpmd.h | 1 + 3 files changed, 63 insertions(

Re: [dpdk-dev] [PATCH v1 1/6] librte_table: move structure to header file

2017-08-23 Thread Iremonger, Bernard
Hi Cristian, > > Subject: [PATCH v1 1/6] librte_table: move structure to header file > > > > Move struct librte_table from the rte_table_acl.c to the > > rte_table_acl.h file. > > > > Signed-off-by: Bernard Iremonger > > --- > > lib/librte_table/rte_table_acl.c | 24 >

Re: [dpdk-dev] [dpdk-announce] Plan for European and USA DPDK Summits

2017-08-23 Thread O'Driscoll, Tim
For anybody attending the DPDK Summit Userspace event in Dublin, we now have a discounted rate of €169 per night set up with the Clayton Hotel. To get this you can book via the hotel website (https://www.claytonhotelballsbridge.com/) and enter a code of KTSE260917. The discounted rate only appli

[dpdk-dev] cuckoo hash in dpdk

2017-08-23 Thread Pragash Vijayaragavan
Hi, I got the chance to look at the cuckoo hash used in dpdk and have a query. would using division and modulo operations be slower than bitwise operations on RTE_HASH_BUCKET_ENTRIES, specially since RTE_HASH_BUCKET_ENTRIES is a power of 2. For example, to do a modulo we can do a "AND" operation

Re: [dpdk-dev] [PATCH v1 1/6] librte_table: move structure to header file

2017-08-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, August 23, 2017 2:51 PM > To: dev@dpdk.org; Yigit, Ferruh ; Ananyev, > Konstantin ; Dumitrescu, Cristian > ; adrien.mazarg...@6wind.com > Cc: Iremonger, Bernard > Subject: [PATCH v1 1/6] librte_table: move structure to he

Re: [dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz

2017-08-23 Thread Bruce Richardson
On Wed, Aug 23, 2017 at 02:57:30PM +0100, Sergio Gonzalez Monroy wrote: > On 23/08/2017 14:17, Bruce Richardson wrote: > > On Wed, Aug 23, 2017 at 01:42:41PM +0100, Sergio Gonzalez Monroy wrote: > > > First, try to use CPUID Time Stamp Counter and Nominal Core Crystal > > > Clock Information Leaf t

Re: [dpdk-dev] [PATCH] eal: add config option to enable asserts

2017-08-23 Thread Gaëtan Rivet
Hi, On Wed, Aug 23, 2017 at 10:00:08PM +0800, Xueming Li wrote: > Currently, enabling assertion have to set CONFIG_RTE_LOG_LEVEL to > RTE_LOG_DEBUG. CONFIG_RTE_LOG_LEVEL is the default log level of control > path, RTE_LOG_DP_LEVEL is the log level of data path. It's a little bit > hard to understa

[dpdk-dev] [PATCH v3 40/40] net/dpaa: support for firmware version get API

2017-08-23 Thread Shreyansh Jain
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 36 2 files changed, 37 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini in

[dpdk-dev] [PATCH v3 37/40] net/dpaa: add support for checksum offload

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 2 + drivers/net/dpaa/dpaa_ethdev.c| 4 ++ drivers/net/dpaa/dpaa_rxtx.c | 89 +++ drivers/net/dpaa/dpaa_rxtx.h | 19 + 4 files changed,

[dpdk-dev] [PATCH v3 39/40] net/dpaa: add packet dump for debugging

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- config/defconfig_arm64-dpaa-linuxapp-gcc | 2 ++ drivers/net/dpaa/dpaa_ethdev.c | 42 drivers/net/dpaa/dpaa_rxtx.c | 26 3 files changed, 70 insertions(+)

[dpdk-dev] [PATCH v3 38/40] net/dpaa: add support for Scattered Rx

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_rxtx.c | 158 ++ drivers/net/dpaa/dpaa_rxtx.h | 9 +++ 3 files changed, 168 insertions(+) diff --git a/doc/guides/nics

[dpdk-dev] [PATCH v3 36/40] net/dpaa: add support for packet type parsing

2017-08-23 Thread Shreyansh Jain
Add support for parsing the packet type and L2/L3 checksum offload capability information. Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 2 + drivers/net/dpaa/dpaa_ethdev.c| 27 + drivers/net/dpaa/dpaa_rxtx.c | 116 ++

[dpdk-dev] [PATCH v3 34/40] net/dpaa: add support for flow control

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 112 ++ 2 files changed, 113 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/feature

[dpdk-dev] [PATCH v3 32/40] net/dpaa: add support for MAC address update

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 55 +++ 2 files changed, 56 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/

[dpdk-dev] [PATCH v3 35/40] net/dpaa: add support for hashed RSS

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 1 + drivers/net/dpaa/dpaa_ethdev.h | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index fddd9ec..55adc04 100644 ---

[dpdk-dev] [PATCH v3 30/40] net/dpaa: add support for promiscuous toggle

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 21 + 2 files changed, 22 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index 19b

[dpdk-dev] [PATCH v3 33/40] net/dpaa: add support for basic stats

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index cdf5

[dpdk-dev] [PATCH v3 28/40] net/dpaa: add support for link status update

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 42 +++ 2 files changed, 43 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/

[dpdk-dev] [PATCH v3 27/40] net/dpaa: add support for jumbo frames

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 13 +++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini i

[dpdk-dev] [PATCH v3 23/40] net/dpaa: add NXP DPAA PMD driver skeleton

2017-08-23 Thread Shreyansh Jain
A skeleton which would be called after bus device scan. It currently fails to identify the device. Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- MAINTAINERS | 1 + drivers/net/dpaa/Makefile | 63 drivers/net/dpaa/dpaa_e

[dpdk-dev] [PATCH v3 25/40] net/dpaa: add support for Tx and Rx queue setup

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/net/dpaa/Makefile | 4 + drivers/net/dpaa/dpaa_ethdev.c | 290 +++- drivers/net/dpaa/dpaa_rxtx.c | 370 + drivers/net/dpaa/dpaa_rxtx.h | 61

[dpdk-dev] [PATCH v3 31/40] net/dpaa: add support for multicast toggle

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index b2df

[dpdk-dev] [PATCH v3 29/40] net/dpaa: add support for device info and speed capability

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index 132f

[dpdk-dev] [PATCH v3 26/40] net/dpaa: add support for MTU update

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 21 + 2 files changed, 22 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index 9e8

[dpdk-dev] [PATCH v3 22/40] bus/dpaa: add DPAA PMD logging macros

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/dpaa_bus.c | 5 + drivers/bus/dpaa/rte_dpaa_logs.h | 36 2 files changed, 41 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index dc2b3ad..7ae5bfa 100644 --- a/

[dpdk-dev] [PATCH v3 21/40] maintainers: claim ownership of DPAA Mempool driver

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 10646a4..74b7aba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -409,6 +409,7 @@ NXP dpaa M: Hemant Agrawal M: Shreyansh Jain F: drivers/bus/dpaa/ +F: drivers/memp

[dpdk-dev] [PATCH v3 20/40] drivers: enable compilation of DPAA Mempool driver

2017-08-23 Thread Shreyansh Jain
This patch also adds configuration necessary for compilation of DPAA Mempool driver into the DPAA specific config file. CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS=dpaa is also configured to allow applications to use DPAA mempool as default. Signed-off-by: Shreyansh Jain --- config/common_base

[dpdk-dev] [PATCH v3 19/40] mempool/dpaa: add support for NXP DPAA Mempool

2017-08-23 Thread Shreyansh Jain
This Mempool driver works with DPAA BMan hardware block. This block manages data buffers in memory, and provides efficient interface with other hardware and software components for buffer requests. This patch adds support for BMan. Compilation would be enabled in subsequent patches. Signed-off-by

[dpdk-dev] [PATCH v3 17/40] doc: add NXP DPAA PMD documentation

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- MAINTAINERS | 2 + doc/guides/nics/dpaa.rst | 374 ++ doc/guides/nics/features/dpaa.ini | 8 + doc/guides/nics/index.rst | 1 + 4 files changed, 385 in

[dpdk-dev] [PATCH v3 24/40] config: enable NXP DPAA PMD compilation

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- config/common_base | 1 + config/defconfig_arm64-dpaa-linuxapp-gcc | 12 drivers/net/Makefile | 2 ++ mk/rte.app.mk| 5 + 4 files changed, 20 insertions(+) diff --git a/con

[dpdk-dev] [PATCH v3 15/40] bus/dpaa: add fman flow control threshold setting

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/base/fman/fman_hw.c | 28 drivers/bus/dpaa/include/fsl_fman.h | 7 +++ 2 files changed, 35 insertions(+) diff --git a/drive

[dpdk-dev] [PATCH v3 14/40] bus/dpaa: add BMan hardware interfaces

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/Makefile | 1 + drivers/bus/dpaa/base/qbman/bman.c| 394 + drivers/bus/dpaa/base/qbman/bman.h| 550 ++

[dpdk-dev] [PATCH v3 09/40] bus/dpaa: add routines for managing a RB tree

2017-08-23 Thread Shreyansh Jain
QMAN frames are managed over a RB tree data structure. This patch introduces necessary routines for implementing a RB tree. Signed-off-by: Geoff Thorpe Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/include/dpaa_rbtree.h | 143 +

[dpdk-dev] [PATCH v3 10/40] bus/dpaa: add QMAN interface driver

2017-08-23 Thread Shreyansh Jain
The Queue Manager (QMan) is a hardware queue management block that allows software and accelerators on the datapath to enqueue and dequeue frames in order to communicate. This part of QBMAN DPAA Block. Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-o

[dpdk-dev] [PATCH v3 01/40] config: add NXP DPAA SoC build configuration

2017-08-23 Thread Shreyansh Jain
This patch adds skeleton build configuration for DPAA platform. Signed-off-by: Shreyansh Jain --- config/defconfig_arm64-dpaa-linuxapp-gcc | 39 mk/machine/dpaa/rte.vars.mk | 61 2 files changed, 100 insertions(+) create mode 10

[dpdk-dev] [PATCH v3 18/40] bus/dpaa: add DPAA mempool logging macros

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/dpaa_bus.c | 5 + drivers/bus/dpaa/rte_dpaa_logs.h | 28 2 files changed, 33 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 8017df3..dc2b3ad 100644 --- a/drivers/

[dpdk-dev] [PATCH v3 16/40] bus/dpaa: integrate DPAA Bus with hardware blocks

2017-08-23 Thread Shreyansh Jain
Now that QBMAN (QMAN, BMAN) and FMAN drivers are available, this patch integrates the DPAA Bus driver for using the drivers for scanning devices and calling the PMD registered probe callbacks. Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/dpaa_bus.c

[dpdk-dev] [PATCH v3 05/40] bus/dpaa: introducing FMan configurations

2017-08-23 Thread Shreyansh Jain
FMan or Frame Manager, inspects traffic, splits it into queueson ingress. It is also responsible for directing traffic on queues on egress. This patch introduces FMan configurational interfaces. This layer is used by Bus driver for configuring the hardware block. Signed-off-by: Geoff Thorpe Sign

[dpdk-dev] [PATCH v3 06/40] bus/dpaa: add FMan hardware operations

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Geoff Thorpe Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/Makefile | 1 + drivers/bus/dpaa/base/fman/fman_hw.c | 606 ++ drivers/bus/dpaa/include/fsl_fman.h | 182 + drivers/bus/d

[dpdk-dev] [PATCH v3 00/40] Introduce NXP DPAA Bus, Mempool and PMD

2017-08-23 Thread Shreyansh Jain
Change Log: v3: - Rebasing over 17.11-rc0 (85238f50) - Checkpatch fixes (There are still 2 errors which I think are false positives) - Implement rte_bus.find_device() interface - Various other minor updates/cleanups v2: - Fixing various comments from Ferruh, but broadly: -)

  1   2   >