[dpdk-dev] [PATCH] doc: add testpmd bonding mode 4 aggregators mode

2017-07-26 Thread Daniel Mrzyglod
Add testpmd commands for setting aggregators mode in mode 4 (IEEE802.3AD). Signed-off-by: Daniel Mrzyglod --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_f

Re: [dpdk-dev] [PATCH v5] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Dai, Wei > Sent: Wednesday, July 26, 2017 9:02 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v5] net/ixgbe: add support of 2.5G and 5G on X550 > > This patch adds support of 2.5G and 5G ethernet interface on

[dpdk-dev] [PATCH v5] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Wei Dai
This patch adds support of 2.5G and 5G ethernet interface on X550. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 27 --- drivers/net/ixgbe/ixgbe_ethdev.h | 8 2 files changed, 32 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe

Re: [dpdk-dev] [PATCH v2] net/i40e: fix sync phy type by adding retry

2017-07-26 Thread Wu, Jingjing
> -Original Message- > From: Hunt, David > Sent: Monday, July 24, 2017 4:49 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; sta...@dpdk.org; Hunt, David > > Subject: [PATCH v2] net/i40e: fix sync phy type by adding retry > > Some phy's take longer than others to come up. Add a retry to give

Re: [dpdk-dev] [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Dai, Wei
> -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, July 27, 2017 12:59 AM > To: Dai, Wei ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550 > > Hi Wei, > > > -Original Message- > > From: Dai, Wei > > Sent:

[dpdk-dev] [PATCH 2/2] net/mlx5: fix L4 packet type support

2017-07-26 Thread Yongseok Koh
TCP/UDP/NONFRAG/FRAG flags aren't counted for both outer and inner header even though device supports it. Fixes: 0603df73a077 ("net/mlx5: fix Rx packet validation and type") Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") Signed-off-by: Yongseok Koh Acked-by: Adrien Mazargui

[dpdk-dev] [PATCH 1/2] net/mlx5: fix missing packet type calculation

2017-07-26 Thread Yongseok Koh
Calculation of packet type is currently enabled only when HW checksum is enabled. This isn't related to HW checksum offload. Enable it regardless. Fixes: 081f7eae242e ("mlx5: process offload flags only when requested") Signed-off-by: Yongseok Koh Acked-by: Adrien Mazarguil --- drivers/net/mlx5

[dpdk-dev] [PATCH 0/2] net/mlx5: fix packet type support

2017-07-26 Thread Yongseok Koh
Even though HW supports more packet types, PMD doesn't parse it. Changed to have more packet_type flags in mbuf. Yongseok Koh (2): net/mlx5: fix missing packet type calculation net/mlx5: fix L4 packet type support drivers/net/mlx5/mlx5.c | 2 + drivers/net/mlx5/mlx5_ethdev.c

[dpdk-dev] [PATCH 3/3] doc: move i40e specific to i40e guide

2017-07-26 Thread Shahaf Shuler
The Linux Getting Started Guide contains parts which are specific for i40e PMD. This results in confusion for users which read the guide at their first try with DPDK. Moving those parts to the i40e NIC manual. Signed-off-by: Shahaf Shuler --- doc/guides/linux_gsg/enable_func.rst | 2

[dpdk-dev] [PATCH 1/3] doc: move kernel drivers to a new chapter

2017-07-26 Thread Shahaf Shuler
The UIO and VFIO sections should not be part of the "Compiling the DPDK Target from Source" chapter, as it is PMD specific and not true for all PMDs. Instead, moving those sections to a new chapter which include all kernel drivers being used along with the different PMDs. Signed-off-by: Shahaf Sh

[dpdk-dev] [PATCH 2/3] doc: cleanup UIO hard requirement

2017-07-26 Thread Shahaf Shuler
UIO is not a must for all PMDs. Cleaning up the Linux Getting Started Guide from this hard requirement. Signed-off-by: Shahaf Shuler --- doc/guides/linux_gsg/build_sample_apps.rst | 10 ++ doc/guides/linux_gsg/sys_reqs.rst | 2 -- 2 files changed, 6 insertions(+), 6 deletions(

Re: [dpdk-dev] [PATCH] bonding: fix link status interrupt when down

2017-07-26 Thread Declan Doherty
On 26/07/2017 4:53 PM, Tomasz Kulasek wrote: RTE_ETH_EVENT_INTR_LSC callbacks are not called when all slaves goes down in bond_ethdev_lsc_event_callback. It causes that link status change of bonded device is not propagated up. Fixes: deba8a2f8b0b ("net/bonding: fix link properties management")

Re: [dpdk-dev] [PATCH] test: fix bonded device name

2017-07-26 Thread Declan Doherty
On 26/07/2017 4:48 PM, Tomasz Kulasek wrote: Bonding devices name must start with "net_bonding" prefix. Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option") Signed-off-by: Tomasz Kulasek --- test/test/test_link_bonding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [dpdk-dev] [PATCH] test: fix virtual device name not set

2017-07-26 Thread Declan Doherty
On 26/07/2017 4:46 PM, Tomasz Kulasek wrote: Device name in device structure in virtual device used in link_bonding_autotest is not set what causes segmentation fault when rte_eth_dev_allocated is called. Fixes: a1e7c17555e8 ("ethdev: use device name from device structure") Signed-off-by: Tomas

Re: [dpdk-dev] [PATCH] bonding: fix segfault when primary slave set

2017-07-26 Thread Declan Doherty
On 26/07/2017 4:50 PM, Tomasz Kulasek wrote: rte_eth_bond_primary_set segfaults for invalid port. This patch moves devices check before use of internal data. Fixes: 4c42498d916d ("net/bonding: allow slaves to also be bonded devices") Signed-off-by: Tomasz Kulasek --- drivers/net/bonding/rte_e

Re: [dpdk-dev] [PATCH] test/bonding: fix namespace of the rss tests

2017-07-26 Thread Declan Doherty
On 26/07/2017 4:44 PM, Daniel Mrzyglod wrote: drivers are looking by name of the device so change namespace to proper one Fixes: 43b630244e7e ("app/test: add dynamic bonding RSS configuration") Signed-off-by: Daniel Mrzyglod --- test/test/test_link_bonding_rssconf.c | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v4 3/3] doc: update mlx guides

2017-07-26 Thread Shahaf Shuler
Update the guides with: * New supported features. * Supported OFED and FW versions. * Quick start guide. * Performance tunning guide. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- On v4: - Fixed missing "." and ":". - Fixed header underline

[dpdk-dev] [PATCH v4 2/3] doc: update release notes for mlx driver

2017-07-26 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/rel_notes/release_17_08.rst | 126 + 1 file changed, 126 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst

[dpdk-dev] [PATCH v4 1/3] doc: update mlx5 supported features

2017-07-26 Thread Shahaf Shuler
Supported features which were not included: * ARMv8 * Extended stats Not supported features which were wrongly included: * Inner L3 checksum * Inner L4 checksum Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/nics/features/mlx5.ini | 4

Re: [dpdk-dev] [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Wednesday, July 26, 2017 11:30 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550 > > This patch adds support of 2.5G and 5G ethernet interfac

[dpdk-dev] [pktgen] Version 3.3.8 pushed

2017-07-26 Thread Wiles, Keith
It appears I created a bug in Pktgen on version 3.3.5 and I have fixed the bug. The bug was pktgen would only send a couple million packets then stop sending. Please pull the latest version, which should work with DPDK 17.08-rc2 If any more bugs, enhancements or suggestions please send and email

[dpdk-dev] [PATCH] bonding: fix link status interrupt when down

2017-07-26 Thread Tomasz Kulasek
RTE_ETH_EVENT_INTR_LSC callbacks are not called when all slaves goes down in bond_ethdev_lsc_event_callback. It causes that link status change of bonded device is not propagated up. Fixes: deba8a2f8b0b ("net/bonding: fix link properties management") Signed-off-by: Tomasz Kulasek --- drivers/net

[dpdk-dev] [PATCH] bonding: fix segfault when primary slave set

2017-07-26 Thread Tomasz Kulasek
rte_eth_bond_primary_set segfaults for invalid port. This patch moves devices check before use of internal data. Fixes: 4c42498d916d ("net/bonding: allow slaves to also be bonded devices") Signed-off-by: Tomasz Kulasek --- drivers/net/bonding/rte_eth_bond_api.c | 5 ++--- 1 file changed, 2 inse

[dpdk-dev] [PATCH] test: fix bonded device name

2017-07-26 Thread Tomasz Kulasek
Bonding devices name must start with "net_bonding" prefix. Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option") Signed-off-by: Tomasz Kulasek --- test/test/test_link_bonding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test/test_link_bonding.c

[dpdk-dev] [PATCH] test/bonding: fix namespace of the rss tests

2017-07-26 Thread Daniel Mrzyglod
drivers are looking by name of the device so change namespace to proper one Fixes: 43b630244e7e ("app/test: add dynamic bonding RSS configuration") Signed-off-by: Daniel Mrzyglod --- test/test/test_link_bonding_rssconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/t

[dpdk-dev] [PATCH] test: fix virtual device name not set

2017-07-26 Thread Tomasz Kulasek
Device name in device structure in virtual device used in link_bonding_autotest is not set what causes segmentation fault when rte_eth_dev_allocated is called. Fixes: a1e7c17555e8 ("ethdev: use device name from device structure") Signed-off-by: Tomasz Kulasek --- test/test/virtual_pmd.c | 1 +

Re: [dpdk-dev] [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Dai, Wei
> -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, July 26, 2017 11:02 PM > To: Dai, Wei ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550 > > Hi Wei, > > > -Original Message- > > From: Dai, Wei > > Sent:

[dpdk-dev] [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Wei Dai
This patch adds support of 2.5G and 5G ethernet interface on X550. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_type.h | 5 + drivers/net/ixgbe/ixgbe_ethdev.c| 27 --- 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ba

Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check

2017-07-26 Thread Wiles, Keith
> On Jul 26, 2017, at 10:20 AM, Wiles, Keith wrote: > >> >> On Jul 26, 2017, at 9:54 AM, Wenzhuo Lu wrote: >> >> If there's no Traffic Management node added, >> not necessary to check if TM is committed. >> >> Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy") >> >> Signed-o

Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check

2017-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, July 26, 2017 3:54 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check > > If there's no Traffic Management node added, > not

Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check

2017-07-26 Thread Wiles, Keith
> On Jul 26, 2017, at 9:54 AM, Wenzhuo Lu wrote: > > If there's no Traffic Management node added, > not necessary to check if TM is committed. > > Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy") > > Signed-off-by: Wenzhuo Lu > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >

[dpdk-dev] [PATCH v2] doc: add how to enable empty cycles profiling

2017-07-26 Thread ilia . kurakin
From: Ilia Kurakin Programmers Guide: section "Profile Your Application" updated with how to enable ITT tasks collection. Based on patch: http://dpdk.org/dev/patchwork/patch/27158/ Signed-off-by: Ilia Kurakin --- -V2 change: Fixes due to review doc/guides/prog_guide/profile_app.rst | 3

Re: [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check

2017-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, July 26, 2017 3:44 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check > > If there's no Traffic Management node added. Not >

Re: [dpdk-dev] [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Wednesday, July 26, 2017 10:43 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550 > > This patch adds support of 2.5G and 5G ethernet interfac

Re: [dpdk-dev] [pktgen PATCH 0/6] fix compilation

2017-07-26 Thread Thomas Monjalon
26/07/2017 17:52, Wiles, Keith: > > On Jul 26, 2017, at 12:39 AM, Thomas Monjalon wrote: > > PS: I've noticed that you are the author of all the pktgen commits. > > Are you using git-am when applying patches from other contributors? > > Yes, I do use git am, but most changes are based on bug repo

Re: [dpdk-dev] hierarchy_commit() message displayed when not using TM

2017-07-26 Thread Lu, Wenzhuo
Hi Keith, Thomas, > -Original Message- > From: Wiles, Keith > Sent: Wednesday, July 26, 2017 10:35 AM > To: Thomas Monjalon > Cc: DPDK ; Dumitrescu, Cristian > ; Lu, Wenzhuo > Subject: hierarchy_commit() message displayed when not using TM > > > > On Jul 26, 2017, at 12:39 AM, Thomas M

[dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check

2017-07-26 Thread Wenzhuo Lu
If there's no Traffic Management node added, not necessary to check if TM is committed. Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy") Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

Re: [dpdk-dev] [pktgen PATCH 0/6] fix compilation

2017-07-26 Thread Wiles, Keith
> On Jul 26, 2017, at 12:39 AM, Thomas Monjalon wrote: > > 26/07/2017 06:54, Wiles, Keith: >> >>> On Jul 25, 2017, at 5:21 PM, Thomas Monjalon wrote: >>> >>> Some errors were seen when trying to compile with gcc 7 or clang, >>> for 32-bit, and with DPDK 17.08-rc2. >>> >>> Thomas Monjalon (6)

[dpdk-dev] [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Wei Dai
This patch adds support of 2.5G and 5G ethernet interface on X550. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_type.h | 5 + drivers/net/ixgbe/ixgbe_ethdev.c| 24 2 files changed, 29 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/

[dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check

2017-07-26 Thread Wenzhuo Lu
If there's no Traffic Management node added. Not necessary to check if TM is committed. Fixes: cac29c3c00a4 ("net/i40e: support committing TM hierarchy") Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i

[dpdk-dev] hierarchy_commit() message displayed when not using TM

2017-07-26 Thread Wiles, Keith
> On Jul 26, 2017, at 12:39 AM, Thomas Monjalon wrote: > >> I noticed a new message: >> i40e_dev_start(): please call hierarchy_commit() before starting the port >> i40e_dev_start(): please call hierarchy_commit() before starting the port >> i40e_dev_start(): please call hierarchy_commit() befor

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Dai, Wei
> -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, July 26, 2017 10:14 PM > To: Dai, Wei ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550 > > Hi Wei, > > > -Original Message- > > From: Dai, Wei > > Sent:

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Wednesday, July 26, 2017 10:10 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550 > > Hi, Wenzhuo > > > speed = 0x0; > > > if (*link_speeds == ET

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Dai, Wei
Hi, Wenzhuo > > speed = 0x0; > > if (*link_speeds == ETH_LINK_SPEED_AUTONEG) { > > - speed = (hw->mac.type != ixgbe_mac_82598EB) ? > > - IXGBE_LINK_SPEED_82599_AUTONEG : > > - IXGBE_LINK_SPEED_82598_AUTONEG; > > + switc

Re: [dpdk-dev] [RFC PATCH 0/1] IPSec Inline and look aside crypto offload

2017-07-26 Thread Declan Doherty
Hey Akhil, I like the proposal of allowing the rte_secruity API to be supported on both NIC and crypto devices as I think it allows us to cover all the protocol offload scenarios in a consist manner. The main concern I have is in regards to the device identification in a consistent manner betw

[dpdk-dev] [PATCH v2 0/6] fix ethdev device detach

2017-07-26 Thread Gaetan Rivet
Device detach in librte_ether is rough right now. - Device hotplug capability is not properly checked - Device state should be set after a successful detach - MLX drivers are lacking the relevant flag - And this flag should actually be removed, thus occuring an API change for v17.11. An ann

[dpdk-dev] [PATCH v2 4/6] net/mlx5: advertize the detach capability

2017-07-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx5/mlx5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 49d4dba..5fd0e76 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -788,6 +788,7 @@ mlx5_pci_probe(struct rte_pci

[dpdk-dev] [PATCH v2 6/6] doc: announce ethdev API change for detach flag

2017-07-26 Thread Gaetan Rivet
The flag RTE_ETH_DEV_DETACHABLE will disappear. This flag is not needed anymore following the hotplug work done for v17.08. It can be removed, its intent is now implicitly made available by the relevant EAL and rte_bus implementations. Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/deprec

[dpdk-dev] [PATCH v2 5/6] app/testpmd: let the user know device detach failed

2017-07-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9142218..9a36e66 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1728,8 +1728,10 @@ detach_

[dpdk-dev] [PATCH v2 3/6] net/mlx4: advertize the detach capability

2017-07-26 Thread Gaetan Rivet
This PMD supports hotplug, it is able to be detached. Signed-off-by: Gaetan Rivet --- drivers/net/mlx4/mlx4.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index d41552b..8451f5b 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/m

[dpdk-dev] [PATCH v2 2/6] ethdev: properly check detach capability

2017-07-26 Thread Gaetan Rivet
This capability is not bound to which driver is handling the device, but whether the bus is able to unplug it. This check is already performed in rte_eal_dev_detach, there is no need to do it in the ether layer. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 10 -- 1 fi

[dpdk-dev] [PATCH v2 1/6] ethdev: fix device state on detach

2017-07-26 Thread Gaetan Rivet
The device state should be handled by the ether layer when possible. Applications should not have to do it. Not setting the state to UNUSED will make the port_id of the device valid for all ether API functions, usually resulting in segfault. Fixes: 284c908cc588 ("app/testpmd: request device remov

[dpdk-dev] [PATCH 5/6] app/testpmd: let the user know device detach failed

2017-07-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9142218..9a36e66 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1728,8 +1728,10 @@ detach_

[dpdk-dev] [PATCH 6/6] doc: announce ethdev API change for detach flag

2017-07-26 Thread Gaetan Rivet
The flag RTE_ETH_DEV_DETACHABLE will disappear. This flag is not needed anymore following the hotplug work done for v17.08. It can be removed, its intent is now implicitly made available by the relevant EAL and rte_bus implementations. Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/deprec

[dpdk-dev] [PATCH 4/6] net/mlx5: advertize the detach capability

2017-07-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx5/mlx5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 49d4dba..5fd0e76 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -788,6 +788,7 @@ mlx5_pci_probe(struct rte_pci

[dpdk-dev] [PATCH 3/6] net/mlx4: advertize the detach capability

2017-07-26 Thread Gaetan Rivet
This PMD supports hotplug, it is able to be detached. Signed-off-by: Gaetan Rivet --- drivers/net/mlx4/mlx4.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index d41552b..8451f5b 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/m

[dpdk-dev] [PATCH 0/6] fix ethdev device detach

2017-07-26 Thread Gaetan Rivet
Device detach in librte_ether is rough right now. - Device hotplug capability is not properly checked - Device state should be set after a successful detach - MLX drivers are lacking the relevant flag - And this flag should actually be removed, thus occuring an API change for v17.11. An ann

[dpdk-dev] [PATCH 1/6] ethdev: fix device state on detach

2017-07-26 Thread Gaetan Rivet
The device state should be handled by the ether layer when possible. Applications should not have to do it. Not setting the state to UNUSED will make the port_id of the device valid for all ether API functions, usually resulting in segfault. Fixes: 284c908cc588 ("app/testpmd: request device remov

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Wednesday, July 26, 2017 5:30 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550 > > This patch adds support of 2.5G and 5G ethernet interface

Re: [dpdk-dev] [PATCH] net/mlx5: fix verification of device context

2017-07-26 Thread Gaëtan Rivet
Hi Shachar, On Wed, Jul 26, 2017 at 09:21:27AM +, Shachar Beiser wrote: > Hi , > >When I say close I mean : " mlx5_dev_close" . This function set the > priv->ctx to NULL. >We think this patch is required because we have an open bug of seg > fault while accessing priv->ctx ==

[dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen

2017-07-26 Thread Pablo de Lara
When calling rte_crypto_op_bulk_alloc, the function may return either a 0, if not enough objects are available in the mempool or the number of operations requested, it there are enough available. However, the Doxygen comments were not matching these two cases. Fixes: c0f87eb5252b ("cryptodev: chan

[dpdk-dev] [PATCH v2] mbuf: fix mbuf bulk alloc Doxygen

2017-07-26 Thread Pablo de Lara
When calling rte_pktmbuf_alloc_bulk, if there are not enough objects in the mempool, it returns a negative value, which should be reflected in the Doxygen comments. Fixes: 9ec201f5d6e7 ("mbuf: provide bulk allocation") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- Changes in v2: - CC sta

[dpdk-dev] [PATCH] mbuf: fix mbuf bulk alloc Doxygen

2017-07-26 Thread Pablo de Lara
When calling rte_pktmbuf_alloc_bulk, if there are not enough objects in the mempool, it returns a negative value, which should be reflected in the Doxygen comments. Fixes: 9ec201f5d6e7 ("mbuf: provide bulk allocation") Signed-off-by: Pablo de Lara --- lib/librte_mbuf/rte_mbuf.h | 1 + 1 file ch

[dpdk-dev] [PATCH] dev: fix dev_attach proceeding with vdev on success

2017-07-26 Thread Gaetan Rivet
When rte_eal_hotplug_add() successfully probe a device, the return value is zero. The check afterward only returns on error different from -EINVAL. It should return also on success, as there is no need to attempt probing the device with vdev. Fixes: 0bba9e605048 ("eal: use new hotplug API in attac

Re: [dpdk-dev] something is wrong with device hotplug with DPDK 17.08

2017-07-26 Thread Gaëtan Rivet
Hi there, On Wed, Jul 26, 2017 at 07:22:40PM +0800, Chillance Zen wrote: > hi ,all > when I pass parameters with the XL710 PCI address :":41:00.1" to > rte_eth_dev_attach(),the > PMD says something like the following and halts and fails > EAL: Cannot find unplugged device (:41:00.1) > EAL:

[dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

2017-07-26 Thread Akhil Goyal
Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/Makefile b/drivers/crypto/dpaa2_sec/Makefile index c2a02ed..ae15c99 100644 --- a/drivers/crypto/dpaa2_sec/Makefile +++ b/drivers/crypto/dpaa2_sec/Makefi

[dpdk-dev] something is wrong with device hotplug with DPDK 17.08

2017-07-26 Thread Chillance Zen
hi ,all when I pass parameters with the XL710 PCI address :":41:00.1" to rte_eth_dev_attach(),the PMD says something like the following and halts and fails EAL: Cannot find unplugged device (:41:00.1) EAL: Driver cannot attach the device (:41:00.1) does anybody know what happens ? than

[dpdk-dev] [PATCH v3] bonding: fix the segfault caused by the race condition between master thread and eal-intr-thread

2017-07-26 Thread zhangsha.zhang
From: Sha Zhang Function slave_configure calls functions bond_ethdev_lsc_event_callback and slave_eth_dev->dev_ops->link_update to fix updating slave link status. But there is a low probability that process may be crashed if the master thread, which create bonding-device, adds the active_slave_co

Re: [dpdk-dev] [PATCH] net/mlx4: fix drop action setting before start

2017-07-26 Thread Adrien Mazarguil
Hi Matan, On Tue, Jul 25, 2017 at 02:18:28PM +0300, Matan Azrad wrote: > The corrupted code causes segmentation fault when user creates > flow with drop action before device starting. Thanks for debugging this issue. This should address the crash but I'm concerned about its root cause, as you've

[dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Wei Dai
This patch adds support of 2.5G and 5G ethernet interface on X550. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.

Re: [dpdk-dev] [PATCH] net/mlx5: fix verification of device context

2017-07-26 Thread Shachar Beiser
Hi , When I say close I mean : " mlx5_dev_close" . This function set the priv->ctx to NULL. We think this patch is required because we have an open bug of seg fault while accessing priv->ctx == NULL. -Shachar Beiser. -Original Message-

Re: [dpdk-dev] [PATCH] net/mlx5: fix verification of device context

2017-07-26 Thread Adrien Mazarguil
Hi Shachar, On Wed, Jul 26, 2017 at 05:43:24AM +, Shachar Beiser wrote: > Get interface name function lacks verification of device context. > It might lead to segmentation fault when trying to query the name > after the device is closed.fixing it by adding the missing verification > Thanks,

[dpdk-dev] [PATCH] doc: complete sample command line for crypto PMDs

2017-07-26 Thread Pablo de Lara
Documentation of some virtual crypto PMDs have a sample command line to show how to initialize the device on a specific application, L2fwd-crypto. This was meant to be used as a reference, but these lines themselves do not work, as the sample application used required more parameters, which are ad

[dpdk-dev] [PATCH v2] bonding: fix the segfault caused by the race condition between master thread and eal-intr-thread

2017-07-26 Thread zhangsha.zhang
From: Sha Zhang Function slave_configure calls functions bond_ethdev_lsc_event_callback and slave_eth_dev->dev_ops->link_update to fix updating slave link status. But there is a low probability that process may be crashed if the master thread, which create bonding-device, adds the active_slave_co

[dpdk-dev] [PATCH] doc: fix l2fwd-crypto sample code

2017-07-26 Thread Pablo de Lara
L2fwd-crypto app was modified with various changes in its code. The application user guide contains some code snippets that needed to be updated. Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters") Signed-off-by: Pablo de Lara --- doc/guides/sample_app_ug/l2_forward_crypto.rst |