> On Jul 26, 2017, at 10:20 AM, Wiles, Keith <keith.wi...@intel.com> wrote:
>
>>
>> On Jul 26, 2017, at 9:54 AM, Wenzhuo Lu <wenzhuo...@intel.com> wrote:
>>
>> If there's no Traffic Management node added,
>> not necessary to check if TM is committed.
>>
>> Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
>>
>> Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com>
>> ---
>> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
>> b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index 194058f..e436dca 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> @@ -2693,7 +2693,7 @@ static int eth_ixgbevf_pci_remove(struct
>> rte_pci_device *pci_dev)
>> ixgbe_l2_tunnel_conf(dev);
>> ixgbe_filter_restore(dev);
>>
>> - if (!tm_conf->committed)
>> + if (tm_conf->root && !tm_conf->committed)
>> PMD_DRV_LOG(WARNING,
>> "please call hierarchy_commit() "
>> "before starting the port”);
>
> This patch may work on ixgbe, but I am using i40e and the message is still
> present. I tried to apply your logic above and that seemed to fix the i40e
> message.
>
> Looks like you need to change all of the drivers that use this logic.
>
> Here is the i40e change:
>
> i40e_dev_start()
> - if (!pf->tm_conf.committed)
> + if (pf->tm_conf.root && !pf->tm_conf.committed)
Just saw the new commit.
>
>> --
>> 1.9.3
>>
>
> Regards,
> Keith
Regards,
Keith
