[dpdk-dev] [PATCH v3 11/11] eal/rte_malloc: honor iova mode in virt2phy

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/common/rte_malloc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c i

[dpdk-dev] [PATCH v3 10/11] linuxapp/eal_memory: honor iova mode in virt2phy

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c inde

[dpdk-dev] [PATCH v3 09/11] linuxapp/eal_vfio: honor iova mode before mapping

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly map iova to pa or va. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linux

[dpdk-dev] [PATCH v3 07/11] linuxapp/eal: auto detect iova mode

2017-07-10 Thread Santosh Shukla
- Moving late bus scanning to up..just after eal_parsing. - Auto detect iova mapping mode, based on the result of rte_bus_scan_iommu_class. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal.c | 16 ++-- 1 file changed, 10 insertions(+), 6

[dpdk-dev] [PATCH v3 08/11] bsdapp/eal: auto detect iova mapping mode

2017-07-10 Thread Santosh Shukla
- Moving late bus scanning to up..just after eal_parsing. - Mapping mode would be default for bsdapp. It supports only one pass through mode (RTE_KDRV_NIC_UIO) Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/bsdapp/eal/eal.c | 16 ++-- 1 file changed, 1

[dpdk-dev] [PATCH v3 06/11] eal: introduce iova mode helper api

2017-07-10 Thread Santosh Shukla
Introducing rte_eal_iova_mode() helper API. This API used by non-eal library for detecting iova mode. Signed-off-by: Santosh Shukla --- lib/librte_eal/bsdapp/eal/eal.c | 6 ++ lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/include/rte_eal.h

[dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-10 Thread Santosh Shukla
Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for PCI bus: 0. Look for device attached to vfio kdrv and has .drv_flag set to RTE_PCI_DRV_NEED_IOVA_VA. 1. Look for any device attached to UIO class of driver. 2. Che

[dpdk-dev] [PATCH v3 05/11] bus: get iommu class

2017-07-10 Thread Santosh Shukla
API(rte_bus_get_iommu_class) helps to automatically detect and select appropriate iova mapping scheme for iommu capable device on that bus. Algorithm for iova scheme selection for bus: 0. Iterate through bus_list. 1. Collect each bus iova mode value and update into 'mode' var. 2. Here value '1' is

[dpdk-dev] [PATCH v3 03/11] bsdapp/eal_pci: get iommu class

2017-07-10 Thread Santosh Shukla
Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova mapping mode for PCI bus. Bsdapp case returns default iova mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/bsdapp/eal/eal_pci.c

[dpdk-dev] [PATCH v3 02/11] eal/pci: export match function

2017-07-10 Thread Santosh Shukla
Export rte_pci_match() function as it needed in the followup patch. Signed-off-by: Santosh Shukla --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_pci.c | 10 +- lib/librte_eal/common/include/rte_pci.h | 15 +++ lib

[dpdk-dev] [PATCH v3 00/11] Infrastructure to detect iova mapping on the bus

2017-07-10 Thread Santosh Shukla
v3: Removed virt2phy translation for mempool (suggested by Olivier [4]). Patch series rebased on 'a6e3149d0c0fac39a6fc970bdadfae14f875c9c6'. v2: Based on the discussion on the thread [3]. Introducing RTE_PCI_DRV_NEED_IOVA_VA flag for autodetection of iova va mapping. If a PCI driver demand for IO

[dpdk-dev] [PATCH v3 01/11] eal/pci: introduce PCI driver iova as va flag

2017-07-10 Thread Santosh Shukla
Introducing RTE_PCI_DRV_NEED_IOVA_VA flag. Flag used when driver needs to operate in iova=va mode. Why driver need iova=va mapping? On NPU style co-processors like Octeontx, the buffer recycling has been done in HW, unlike SW model. Here is the data flow: 1) On control path, Fill the HW mempool w

[dpdk-dev] [PATCH] lib/gro: fix doxygen comment issue

2017-07-10 Thread Jiayu Hu
This patch updates GRO API comments to generate correct API documentation by doxygen. Signed-off-by: Jiayu Hu --- lib/librte_gro/rte_gro.h | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/lib/librte_gro/rte_gro.h b/lib/librte_gro/rte_gro.h inde

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Gregory Etelson
Hello Ferruh, Both patches [1] http://dpdk.org/dev/patchwork/patch/26633/ and [2] http://dpdk.org/dev/patchwork/patch/25061/ have failed the same test. This is kind of strange because [2] has already passed that test numerous times. I'll recalibrate my cluster and run the test again. Besides that

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Tue, 11 Jul 2017 01:57:15 + > From: "Dai, Wei" > To: Jerin Jacob > CC: "tho...@monjalon.net" , "Lu, Wenzhuo" > , "Ananyev, Konstantin" > , "Wu, Jingjing" , > "Xing, Beilei" , "dev@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of

[dpdk-dev] [PATCH] doc: update programmer's guide for the GRO library

2017-07-10 Thread Jiayu Hu
Add description to programmer's guide to explain the design of the GRO library. Signed-off-by: Jiayu Hu --- MAINTAINERS| 1 + .../prog_guide/generic_receive_offload_lib.rst | 163 + doc/guides/prog_guide/index.rst

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-10 Thread Dai, Wei
-Original Message- From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] Sent: Monday, July 10, 2017 7:35 PM To: Dai, Wei Cc: tho...@monjalon.net; Lu, Wenzhuo ; Ananyev, Konstantin ; Wu, Jingjing ; Xing, Beilei ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add suppor

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-10 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Tuesday, July 11, 2017 9:13 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [RFC] pci: force address of mappings in secondary > process > > The PCI memory resources

[dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-10 Thread Stephen Hemminger
The PCI memory resources in the secondary process should be in the exact same location as the primary process. Otherwise there is a risk of a stray pointer. Not sure if this is right, but it looks like a potential problem. --- lib/librte_eal/common/eal_common_pci_uio.c | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v8 10/11] net/failsafe: support link status change event

2017-07-10 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 18 ++ drivers/net/failsafe/failsafe_ops.c | 23 +++ drivers/net/failsafe/failsafe_priv

[dpdk-dev] [PATCH v8 11/11] net/failsafe: support flow API isolation mode

2017-07-10 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 34 +++-- drivers/net/failsafe/failsafe_flow.c| 29 drivers/net/failsafe/failsafe_private.h | 4 3 files changed, 65 insertions(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH v8 08/11] net/failsafe: add fast burst functions

2017-07-10 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- drivers/net/failsafe/failsafe_private.h | 8 +++ drivers/net/failsafe/failsafe_rxtx.c| 124 ++-- 2 files changed, 112 insertions(+), 20 deletions(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/dri

[dpdk-dev] [PATCH v8 09/11] net/failsafe: support device removal

2017-07-10 Thread Gaetan Rivet
Listen to INTR_RMV events issued by slaves. Add atomic flags on slave queues to detect use of slave bursts function. If a removal is detected, set the recollection flag on this slave. During a slave upkeep round, if its recollection flag is set and its burst functions are not in use by any thread,

[dpdk-dev] [PATCH v8 04/11] net/failsafe: add plug-in support

2017-07-10 Thread Gaetan Rivet
Periodically check for the existence of a device. If a device has not been initialized and exists on the system, then it is probed and configured. The configuration process strives to synchronize the states between the plugged-in sub-device and the fail-safe device. Signed-off-by: Gaetan Rivet A

[dpdk-dev] [PATCH v8 06/11] net/failsafe: support flow API

2017-07-10 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/Makefile | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_eal.c | 1 + drivers/net/failsafe/failsafe_ether.c | 70 +

[dpdk-dev] [PATCH v8 07/11] net/failsafe: support offload capabilities

2017-07-10 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 6 ++ drivers/net/failsafe/failsafe_ops.c | 131 +- 2 files changed, 135 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guide

[dpdk-dev] [PATCH v8 05/11] net/failsafe: add flexible device definition

2017-07-10 Thread Gaetan Rivet
Add the "exec" device type. The parameters given to this type of device will be executed in a shell. The output of this command is then used as a definition for a device. That command can be re-interpreted if the related device is not plugged-in. It allows for a device definition to react to syste

[dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

2017-07-10 Thread Gaetan Rivet
Introduce the fail-safe poll mode driver initialization and enable its build infrastructure. This PMD allows for applications to benefit from true hot-plugging support without having to implement it. It intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes

[dpdk-dev] [PATCH v8 02/11] ethdev: count devices consistently

2017-07-10 Thread Gaetan Rivet
Make the rte_eth_dev_count() return the number of available devices even after some are detached by the hotplug API or put in a deferred state. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 16 +--- lib/librte_ether/rte_ethdev.h | 13 ++--- 2 files changed,

[dpdk-dev] [PATCH v8 01/11] ethdev: add deferred intermediate device state

2017-07-10 Thread Gaetan Rivet
This device state means that the device is managed externally, by whichever party has set this state (PMD or application). Note: this new device state is only an information. The related device structure and operators are still valid and can be used normally. It is however made private by device

[dpdk-dev] [PATCH v2 8/8] bus: remove useless plug parameter

2017-07-10 Thread Gaetan Rivet
The prior scan should link the relevant rte_devargs to the newly allocated rte_device. As such, it is useless to pass device arguments to the plug callback. Those arguments are available within the devargs field of the rte_device structure. Fixes: 7c8810f43f6e ("bus: introduce device plug/unplug")

[dpdk-dev] [PATCH v8 00/11] introduce fail-safe PMD

2017-07-10 Thread Gaetan Rivet
This PMD intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes them transparently when brought back so that existing applications do not need to be modified to benefit from true hot-plugging support. The stacked PMD approach shares many similarities with the

[dpdk-dev] [PATCH v2 5/8] pci: use given name as generic name

2017-07-10 Thread Gaetan Rivet
The PCI device is referenced by other DPDK systems by the name of its parameter, not by the system name. Moreover, this name should be set once and for all, as early as possible. This means linking the rte_devargs associated with the PCI device during its scan, making available other metadatas use

[dpdk-dev] [PATCH v2 7/8] pci: fix hotplug operations

2017-07-10 Thread Gaetan Rivet
The device handle is already known and does not have to be infered from the PCI address. The relevant helpers are already available within the PCI bus to avoid searching for a handle already known. Additionally, rte_memcpy.h was erroneously included. Fixes: 00e62aae69c0 ("bus/pci: implement plug/

[dpdk-dev] [PATCH v2 3/8] devargs: introduce insert function

2017-07-10 Thread Gaetan Rivet
This new function expects a fully-formed rte_devargs, previously parsed and allocated. It does not check whether the new rte_devargs is compatible with current bus configuration, but will replace any eventual existing one for the same device. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdap

[dpdk-dev] [PATCH v2 6/8] pci: fix generic driver pointer on probe error

2017-07-10 Thread Gaetan Rivet
The field is set but never resetted on error. This marks the device as being attached while it is not, and forbid further attempts to hotplug it. Fixes: 7917d5f5ea46 ("pci: initialize generic driver pointer") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_p

[dpdk-dev] [PATCH v2 4/8] eal: fix hotplug add / remove

2017-07-10 Thread Gaetan Rivet
New device should be represented by an rte_devargs prior to being plugged. Device parameters are available to rte_devices via their devargs field. This field should be set up as soon as possible, as central information are stored within, such as the device name which is used to search the newly sc

[dpdk-dev] [PATCH v2 2/8] devargs: introduce removal function

2017-07-10 Thread Gaetan Rivet
Hotplug support introduces the possibility of removing devices from the system. Allocated resources must be freed. Extend the rte_devargs API to allow freeing allocated resources. This API is experimental and bound to change. It is currently designed as a symetrical to rte_eal_devargs_add(), but

[dpdk-dev] [PATCH v2 0/8] fix hotplug API

2017-07-10 Thread Gaetan Rivet
Sending those fixes as separate patches as they stand on their own. This series improves usability of the hotplug API and fixes a few issues with existing implementations. The hotplug API can be tested with the fail-safe PMD[1]. Its documentation describes how to declare slaves and how to use it.

[dpdk-dev] [PATCH v2 1/8] vdev: implement plug operation

2017-07-10 Thread Gaetan Rivet
This method must be implemented to allow using a unified, generic API to hotplug devices, including virtual ones. VDEV devices actually exist unattached after performing a scan on the rte_devargs list. As such it makes sense to be able to perform a device hotplug afterward. Finally, missing this

Re: [dpdk-dev] [PATCH v6] doc: release notes 17.08, API change description

2017-07-10 Thread Thomas Monjalon
10/07/2017 13:39, Radu Nicolau: > Added API change description - moved bypass functions > from the rte_ethdev library to ixgbe PMD Fixes: e261265e42a1 ("ethdev: move bypass functions to ixgbe PMD") > Signed-off-by: Radu Nicolau Applied, thanks

[dpdk-dev] [PATCH v3 ] ethdev: introduce lock-free txq capability flag

2017-07-10 Thread Jerin Jacob
Introducing the DEV_TX_OFFLOAD_MT_LOCKFREE TX capability flag. if a PMD advertises DEV_TX_OFFLOAD_MT_LOCKFREE capable, multiple threads can invoke rte_eth_tx_burst() concurrently on the same tx queue without SW lock. This PMD feature will be useful in the following use cases and found in the OCTEON

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Thomas Monjalon
10/07/2017 18:47, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 10/07/2017 17:46, Dumitrescu, Cristian: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 10/07/2017 15:21, Dumitrescu, Cristian: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.n

Re: [dpdk-dev] [PATCH v2] ethdev: introduce lock-free txq capability flag

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Sat, 08 Jul 2017 18:08:57 +0200 > From: Thomas Monjalon > To: Jerin Jacob > Cc: dev@dpdk.org, ferruh.yi...@intel.com, john.mcnam...@intel.com > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce lock-free txq > capability flag > > Hi Jerin, > Hi Thomas. Th

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 10, 2017 4:54 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; Singh, Jasvinder ; > Lu, Wenzhuo ; O'Driscoll, Tim > ; Glynn, Michael J

Re: [dpdk-dev] [PATCH 3/4] mempool: introduce block size align flag

2017-07-10 Thread santosh
On Monday 10 July 2017 06:45 PM, Olivier Matz wrote: > On Wed, 5 Jul 2017 13:05:57 +0530, santosh > wrote: >> Hi Olivier, >> >> On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: >> >>> On Wed, 21 Jun 2017 17:32:47 +, Santosh Shukla >>> wrote: Some mempool hw like octeontx/fpa blo

Re: [dpdk-dev] [PATCH 1/4] mempool: get the external mempool capability

2017-07-10 Thread santosh
On Monday 10 July 2017 07:25 PM, Olivier Matz wrote: > On Wed, 5 Jul 2017 12:11:52 +0530, santosh > wrote: >> Hi Olivier, >> >> On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: >> >>> Hi Santosh, >>> >>> On Wed, 21 Jun 2017 17:32:45 +, Santosh Shukla >>> wrote: Allow external me

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Thomas Monjalon
10/07/2017 17:46, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 10/07/2017 15:21, Dumitrescu, Cristian: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 10/07/2017 12:55, Dumitrescu, Cristian: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.n

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 10, 2017 2:50 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; Singh, Jasvinder ; > Lu, Wenzhuo ; O'Driscoll, Tim > ; Glynn, Michael J

Re: [dpdk-dev] [RFC 3/3] rte_flow: add new action for traffic metering and policing

2017-07-10 Thread Adrien Mazarguil
Hi Cristian, Took me a while to reply and I didn't see any update in the meantime, is this RFC still relevant? More comments below. On Tue, Jun 06, 2017 at 06:37:57PM +, Dumitrescu, Cristian wrote: > Hi Adrien, > > Thanks for reviewing this proposal. > > > -Original Message- > > Fr

Re: [dpdk-dev] [PATCH v4 0/5] Rework cfgfile API to enable apps config file support

2017-07-10 Thread Thomas Monjalon
The maintainer of librte_cfgfile is Cristian (+Cc), please set him as recipient for next time. 10/07/2017 14:44, Jacek Piasecki: > New API for cfgfile library allows to create a cfgfile at runtime, add new > section, add entry in a section, update existing entry and save cfgfile > structure to INI

Re: [dpdk-dev] [PATCH 1/2] test: add unit test case for rte log2

2017-07-10 Thread Thomas Monjalon
10/07/2017 14:29, Olivier Matz: > On Thu, 6 Jul 2017 19:50:24 +0530, Jerin Jacob > wrote: > > add a unit testcase for rte_log2_u32. > > > > Signed-off-by: Jerin Jacob > > Reviewed-by: Olivier Matz Series applied, thanks

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Thomas Monjalon
10/07/2017 16:22, santosh: > On Monday 10 July 2017 07:39 PM, Thomas Monjalon wrote: > > > 10/07/2017 15:56, santosh: > >> On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > >> > >>> 10/07/2017 15:30, santosh: > Hi Olivier, > > On Monday 10 July 2017 05:57 PM, Olivier Matz wr

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
On Monday 10 July 2017 07:39 PM, Thomas Monjalon wrote: > 10/07/2017 15:56, santosh: >> On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: >> >>> 10/07/2017 15:30, santosh: Hi Olivier, On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > I didn't check the patchset in det

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Thomas Monjalon
10/07/2017 15:56, santosh: > On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > > > 10/07/2017 15:30, santosh: > >> Hi Olivier, > >> > >> On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > >>> I didn't check the patchset in detail, but in my understanding, > >>> what we call physaddr in

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > 10/07/2017 15:30, santosh: >> Hi Olivier, >> >> On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: >>> I didn't check the patchset in detail, but in my understanding, >>> what we call physaddr in dpdk is actually a bus address. Shouldn't

Re: [dpdk-dev] [PATCH 1/4] mempool: get the external mempool capability

2017-07-10 Thread Olivier Matz
On Wed, 5 Jul 2017 12:11:52 +0530, santosh wrote: > Hi Olivier, > > On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: > > > Hi Santosh, > > > > On Wed, 21 Jun 2017 17:32:45 +, Santosh Shukla > > wrote: > >> Allow external mempool to advertise its capability. > >> A handler been intro

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Thomas Monjalon
10/07/2017 15:30, santosh: > Hi Olivier, > > On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > > I didn't check the patchset in detail, but in my understanding, > > what we call physaddr in dpdk is actually a bus address. Shouldn't > > we start to rename some of these fields and functions to

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Thomas Monjalon
10/07/2017 15:21, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 10/07/2017 12:55, Dumitrescu, Cristian: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 2/ Some functions are exposed in the API to query the ops. > > > > It seems dangerous and useless

Re: [dpdk-dev] [PATCH] net/tap: remove Linux version check

2017-07-10 Thread Pascal Mazon
Hi Raslan, Your patch looks ok at first glance. However, I couldn't test it as it does not apply on a fresh next-net branch. Can you send a v2 after rebase? Thank you. Pascal On 07/10/2017 10:13 AM, Raslan Darawsheh wrote: Remove checks of Linux kernel version in order to support kernel wit

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
Hi Olivier, On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > On Mon, 10 Jul 2017 11:42:34 +, Santosh Shukla > wrote: >> Check iova mode and accordingly return phy addr. >> >> Signed-off-by: Santosh Shukla >> Signed-off-by: Jerin Jacob >> --- >> lib/librte_mempool/rte_mempool.h | 10

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 10, 2017 1:57 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; Singh, Jasvinder ; > Lu, Wenzhuo ; O'Driscoll, Tim > ; Glynn, Michael J

Re: [dpdk-dev] [PATCH 3/4] mempool: introduce block size align flag

2017-07-10 Thread Olivier Matz
On Wed, 5 Jul 2017 13:05:57 +0530, santosh wrote: > Hi Olivier, > > On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: > > > On Wed, 21 Jun 2017 17:32:47 +, Santosh Shukla > > wrote: > >> Some mempool hw like octeontx/fpa block, demands block size aligned > >> buffer address. > >> >

[dpdk-dev] [PATCH v4 5/5] test/cfgfile: add new unit test

2017-07-10 Thread Jacek Piasecki
Load huge realloc_sections.ini file to check malloc/realloc ability of cfgfile library. Signed-off-by: Jacek Piasecki --- test/test/test_cfgfile.c | 40 +++ test/test/test_cfgfiles/etc/realloc_sections.ini | 128 +++ 2 files changed, 168 insertion

[dpdk-dev] [PATCH v4 4/5] cfgfile: rework of load function

2017-07-10 Thread Jacek Piasecki
New functions added to cfgfile library make it possible to significantly simplify the code of rte_cfgfile_load_with_params() This patch shows the new body of this function. Signed-off-by: Jacek Piasecki --- lib/librte_cfgfile/rte_cfgfile.c | 156 --- 1 file c

[dpdk-dev] [PATCH v4 3/3] app/testpmd: add parse options from JSON cfg file

2017-07-10 Thread Kuba Kozak
This patch shows usage of Jansson library to parse application arguments from JSON config file. https://github.com/akheron/jansson If a --cfgfile-path option is passed into commandline non EAL section, then the disired JSON file is loaded and used by app. In case when JSON doesn't exist an INI f

[dpdk-dev] [PATCH v4 3/5] cfgfile: add new functions to API

2017-07-10 Thread Jacek Piasecki
Extend existing cfgfile library with providing new API functions: rte_cfgfile_create() - create new cfgfile object rte_cfgfile_add_section() - add new section to existing cfgfile object rte_cfgfile_add_entry() - add new entry to existing cfgfile object in specified section rte_cfgfile_set_entry()

[dpdk-dev] [PATCH v4 2/5] cfgfile: change existing API functions

2017-07-10 Thread Jacek Piasecki
Change to flat arrays in cfgfile struct force slightly diffrent data access for most of cfgfile functions. This patch provides necessary changes in existing API. Signed-off-by: Jacek Piasecki --- lib/librte_cfgfile/rte_cfgfile.c | 120 +++ lib/librte_cfgfile/r

[dpdk-dev] [PATCH v4 2/3] app/testpmd: add parse options from cfg file

2017-07-10 Thread Kuba Kozak
This patch shows how to pass arguments to application using config.ini file. If a --cfgfile-path option is passed into commandline non EAL section, then the file is loaded and used by app. If a config.ini file is present in current working directory, and no --cfgfile-path option is passed in, co

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Thomas Monjalon
Hi, 10/07/2017 12:55, Dumitrescu, Cristian: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Hi, > > > > 04/07/2017 17:38, Cristian Dumitrescu: > > > http://dpdk.org/git/next/dpdk-next-tm > > > > I'm sorry to not have considered this tree as a high priority. > > I

[dpdk-dev] [PATCH v4 1/5] cfgfile: remove EAL dependency

2017-07-10 Thread Jacek Piasecki
This patch removes the dependency to EAL in cfgfile library. Signed-off-by: Jacek Piasecki --- lib/Makefile | 3 +-- lib/librte_cfgfile/Makefile | 1 + lib/librte_cfgfile/rte_cfgfile.c | 29 + 3 files changed, 19 insertions(+), 14 deletions(

[dpdk-dev] [PATCH v4 0/3] EAL change for using a config file for DPDK

2017-07-10 Thread Kuba Kozak
This patchset introduce a mechanism for running dpdk application with parameters provided by configuration file. A new API for EAL takes a config file data type - either loaded from file, or built up programmatically in the application - and extracts DPDK parameters from it to be used when eal in

[dpdk-dev] [PATCH v4 1/3] eal: add functions parsing EAL arguments

2017-07-10 Thread Kuba Kozak
added function rte_eal_configure which configure Environment Abstraction Layer (EAL) using configuration structure. Signed-off-by: Kuba Kozak Suggested-by: Bruce Richardson --- lib/Makefile| 3 + lib/librte_eal/bsdapp/eal/Makefile | 4 + lib/

[dpdk-dev] [PATCH v4 0/5] Rework cfgfile API to enable apps config file support

2017-07-10 Thread Jacek Piasecki
New API for cfgfile library allows to create a cfgfile at runtime, add new section, add entry in a section, update existing entry and save cfgfile structure to INI file - opens up the possibility to have applications dynamically build up a proper DPDK configuration, rather than having to have a pre

Re: [dpdk-dev] [PATCH] app/testpmd: add flow isolate all parameter

2017-07-10 Thread Adrien Mazarguil
On Sun, Jul 09, 2017 at 11:08:05AM +0300, Vasily Philipov wrote: > Providing this parameter requests flow API isolated mode on all ports at > initialization time. It ensures all traffic is received through the > configured flow rules only (see flow command). > > Ports that do not support this mode

Re: [dpdk-dev] [PATCH] mbuf: fix comment about vxlan destination port used

2017-07-10 Thread Olivier Matz
On Fri, 7 Jul 2017 15:17:40 +0100, Cian Ferriter wrote: > IANA assigns a destination port of 4789 for the VXLAN in the Service > Name and Transport Protocol Port Number Registry. This is mentioned in > RFC 7348. > > Signed-off-by: Cian Ferriter Fixes: f295a00a2b44 ("mbuf: add definitions of u

Re: [dpdk-dev] [PATCH v2] ether: add support for vtune task tracing

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Thu, 6 Jul 2017 19:42:52 +0300 > From: ilia.kura...@intel.com > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, konstantin.anan...@intel.com, > keith.wi...@intel.com, dmitry.gala...@intel.com, Ilia Kurakin > > Subject: [PATCH v2] ether: add support for v

Re: [dpdk-dev] [PATCH 2/2] net/thunderx: remove libm dependency

2017-07-10 Thread Olivier Matz
On Thu, 6 Jul 2017 19:50:25 +0530, Jerin Jacob wrote: > Used rte_log2_u32() to replace integer log2() to > remove libm dependency. > > Signed-off-by: Jerin Jacob Reviewed-by: Olivier Matz

Re: [dpdk-dev] [PATCH 1/2] test: add unit test case for rte log2

2017-07-10 Thread Olivier Matz
On Thu, 6 Jul 2017 19:50:24 +0530, Jerin Jacob wrote: > add a unit testcase for rte_log2_u32. > > Signed-off-by: Jerin Jacob Reviewed-by: Olivier Matz

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Olivier Matz
On Mon, 10 Jul 2017 11:42:34 +, Santosh Shukla wrote: > Check iova mode and accordingly return phy addr. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > --- > lib/librte_mempool/rte_mempool.h | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --g

[dpdk-dev] [PATCH v3 2/3] cmdline: fix dynamic tokens interface

2017-07-10 Thread Adrien Mazarguil
Support for dynamic tokens was added in order to implement the flow command in testpmd, for which static tokens were not versatile enough due to the large number of possible parameter combinations. However, due to its reliance on a temporary array to store dynamic tokens, this interface suffers fr

[dpdk-dev] [PATCH v3 3/3] app/testpmd: fix token matching in flow command

2017-07-10 Thread Adrien Mazarguil
While matching user input against a token name or any other fixed string, comparison stops at the end of user input if shorter (e.g. "foo" matches token name "foobar"). Although the unintended consequence of this behavior allows users to abbreviate command names and various parameters yet generate

[dpdk-dev] [PATCH v3 1/3] cmdline: fix dynamic tokens initialization

2017-07-10 Thread Adrien Mazarguil
To avoid redundant calls to the token-generating function and provide it with helpful context, a temporary fixed-size array allocated on the stack of cmdline_parse() and cmdline_complete() keeps the address of preceding tokens for the command instance being processed (cmdline_parse_inst_t). Like t

[dpdk-dev] [PATCH v3 0/3] librte_cmdline: fix parsing initialisation

2017-07-10 Thread Adrien Mazarguil
Adding a cover letter to keep the same title for that thread, since I took over the original patch from Bernard, modified it somewhat and made a couple of additional fixes on top of it. Olivier's comment [1] and Bernard's feedback about dynamic tokens made me realize how the interface itself was n

[dpdk-dev] [PATCH v2 12/12] eal/rte_malloc: honor iova mode in virt2phy

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/common/rte_malloc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c i

[dpdk-dev] [PATCH v2 09/12] linuxapp/eal_vfio: honor iova mode before mapping

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly map iova to pa or va. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linux

[dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_mempool/rte_mempool.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index

[dpdk-dev] [PATCH v2 10/12] linuxapp/eal_memory: honor iova mode in virt2phy

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c inde

[dpdk-dev] [PATCH v2 08/12] bsdapp/eal: auto detect iova mapping mode

2017-07-10 Thread Santosh Shukla
- Moving late bus scanning to up..just after eal_parsing. - Mapping mode would be default for bsdapp. It supports only one pass through mode (RTE_KDRV_NIC_UIO) Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/bsdapp/eal/eal.c | 16 ++-- 1 file changed, 1

[dpdk-dev] [PATCH v2 07/12] linuxapp/eal: auto detect iova mode

2017-07-10 Thread Santosh Shukla
- Moving late bus scanning to up..just after eal_parsing. - Auto detect iova mapping mode, based on the result of rte_bus_scan_iommu_class. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal.c | 16 ++-- 1 file changed, 10 insertions(+), 6

[dpdk-dev] [PATCH v2 06/12] eal: introduce iova mode helper api

2017-07-10 Thread Santosh Shukla
Introducing rte_eal_iova_mode() helper API. This API used by non-eal library for detecting iova mode. Signed-off-by: Santosh Shukla --- lib/librte_eal/bsdapp/eal/eal.c | 6 ++ lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/include/rte_eal.h

[dpdk-dev] [PATCH v2 04/12] linuxapp/eal_pci: get iommu class

2017-07-10 Thread Santosh Shukla
Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for PCI bus: 0. Look for device attached to vfio kdrv and has .drv_flag set to RTE_PCI_DRV_NEED_IOVA_VA. 1. Look for any device attached to UIO class of driver. 2. Che

[dpdk-dev] [PATCH v2 03/12] bsdapp/eal_pci: get iommu class

2017-07-10 Thread Santosh Shukla
Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova mapping mode for PCI bus. Bsdapp case returns default iova mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/bsdapp/eal/eal_pci.c

[dpdk-dev] [PATCH v2 05/12] bus: get iommu class

2017-07-10 Thread Santosh Shukla
API(rte_bus_get_iommu_class) helps to automatically detect and select appropriate iova mapping scheme for iommu capable device on that bus. Algorithm for iova scheme selection for bus: 0. Iterate throught bus_list. 1. Collect each bus iova mode value and update into 'mode' var. 2. Here value '1' i

[dpdk-dev] [PATCH v6] doc: release notes 17.08, API change description

2017-07-10 Thread Radu Nicolau
Added API change description - moved bypass functions from the rte_ethdev library to ixgbe PMD Signed-off-by: Radu Nicolau --- v6: changed library name to rte_ethdev and "APIs" to "functions", added newline after section. doc/guides/rel_notes/release_17_08.rst | 26 +++

[dpdk-dev] [PATCH v2 02/12] eal/pci: export match function

2017-07-10 Thread Santosh Shukla
Export rte_pci_match() function as it needed in the followup patch. Signed-off-by: Santosh Shukla --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_pci.c | 10 +- lib/librte_eal/common/include/rte_pci.h | 15 +++ lib

[dpdk-dev] [PATCH v2 01/12] eal/pci: introduce PCI driver iova as va flag

2017-07-10 Thread Santosh Shukla
Introducing RTE_PCI_DRV_NEED_IOVA_VA flag. Flag used when driver needs to operate in iova=va mode. Why driver need iova=va mapping? On NPU style co-processors like Octeontx, the buffer recycling has been done in HW, unlike SW model. Here is the data flow: 1) On control path, Fill the HW mempool w

[dpdk-dev] [PATCH v2 00/12] Infrastructure to detect iova mapping on the bus

2017-07-10 Thread Santosh Shukla
v2: Based on the discussion on the thread [2]. Introducing RTE_PCI_DRV_NEED_IOVA_VA flag for autodetection of iova va mapping. If a PCI driver demand for IOVA as VA scheme then the driver can add it in the PCI driver registration function. Algorithm to select IOVA as VA for PCI bus case: 0. L

Re: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Mon, 10 Jul 2017 08:18:33 + > From: "Van Haaren, Harry" > To: Thomas Monjalon > CC: "dev@dpdk.org" , "jerin.ja...@caviumnetworks.com" > , "Wiles, Keith" , > "Richardson, Bruce" > Subject: RE: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter > > > Fr

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Mon, 10 Jul 2017 18:05:41 +0800 > From: Wei Dai > To: tho...@monjalon.net, wenzhuo...@intel.com, > konstantin.anan...@intel.com, jingjing...@intel.com, beilei.x...@intel.com > CC: dev@dpdk.org, Wei Dai > Subject: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of

  1   2   >