On Thursday 29 June 2017 07:59 PM, Shreyansh Jain wrote:
> Hello Ferruh,
>
[...]
>
>>
>>> +
>>> +if (rte_eal_process_type() == RTE_PROC_PRIMARY)
>>> +rte_free(eth_dev->data->dev_private);
>>> +
>>
>> no pmd uninit() ?
Just to clarify, were you asking about uninit of the driver?
Ther
On Tuesday 20 June 2017 02:24 AM, Thomas Monjalon wrote:
> 19/06/2017 13:03, Shreyansh Jain:
>>> --- a/lib/librte_eal/common/include/rte_log.h
>>> +++ b/lib/librte_eal/common/include/rte_log.h
>>> @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs;
>>> #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log rel
> On Jul 1, 2017, at 8:58 AM, Ferruh Yigit wrote:
>
> On 6/30/2017 7:25 PM, Yongseok Koh wrote:
>>
>>> On Jun 30, 2017, at 11:14 AM, Yongseok Koh wrote:
>>>
>>>
On Jun 30, 2017, at 10:47 AM, Ferruh Yigit wrote:
On 6/30/2017 6:19 PM, Adrien Mazarguil wrote:
> This commit
On Thu, Jun 29, 2017 at 08:01:45AM +, Tan, Jianfeng wrote:
>
>
> > -Original Message-
> > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> > Sent: Thursday, June 29, 2017 3:58 PM
> > To: dev@dpdk.org; y...@fridaylinux.org
> > Cc: i.dyu...@samsung.com; Tan, Jianfeng; sta...@
On Wed, Jun 28, 2017 at 03:40:31PM +0300, Ivan Dyukov wrote:
> To compare enabled features in current device we must use bit
> mask instead of bit position.
>
> CC: sta...@dpdk.org
> Fixes: c843af3aa13e ("vhost: access header only")
>
> Signed-off-by: Ivan Dyukov
Applied to dpdk-next-virtio.
T
On Fri, Jun 30, 2017 at 02:43:47PM +, Mcnamara, John wrote:
>
>
> > -Original Message-
> > From: Yang, Zhiyong
> > Sent: Thursday, May 11, 2017 3:17 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John ; yuanhan@linux.intel.com;
> > maxime.coque...@redhat.com; Yang, Zhiyong
> > Subject
On Wed, Jun 07, 2017 at 09:25:38PM +0200, Maxime Coquelin wrote:
>
>
> On 06/07/2017 08:41 AM, Jianfeng Tan wrote:
> >As PKT_TX_TCP_SEG flag in mbuf->ol_flags implies PKT_TX_TCP_CKSUM,
> >applications, e.g., testpmd, don't set PKT_TX_TCP_CKSUM when TSO
> >is set.
> >
> >This leads to that packets
On Wed, Jun 14, 2017 at 10:19:53AM +0200, Jens Freimann wrote:
> On Mon, Jun 12, 2017 at 02:29:04PM -0700, Daniel Verkamp wrote:
> > vsocket->conn_mutex was allocated with pthread_mutex_init() but never
> > freed with pthread_mutex_destroy(). This is a potential memory leak,
> > depending on how p
Hi Ferruh,
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, June 29, 2017 5:55 AM
>
> On 6/29/2017 10:51 AM, Rasesh Mody wrote:
> > Use rte_pktmbuf_alloc() API instead of rte_mbuf_raw_alloc().
> >
> > Signed-off-by: Rasesh Mody
> > ---
> > drivers/net/qede/qede_rxtx.c |
Update the PMD version and add 32bit support in documentation.
Signed-off-by: Rasesh Mody
---
doc/guides/nics/features/qede.ini |1 +
drivers/net/qede/qede_ethdev.h|2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/features/qede.ini
b/doc/guides/nic
Set allow management FW dump flag during HW prepare.
Signed-off-by: Rasesh Mody
---
drivers/net/qede/base/ecore.h |2 +-
drivers/net/qede/base/ecore_dev.c |1 +
drivers/net/qede/base/ecore_dev_api.h |3 +++
drivers/net/qede/base/ecore_mcp.c |3 +--
drivers/net/qed
Convert DP_NOTICE() to DP_ERR() as appropriate in PMD files.
Change DP_NOTICE() macro to make use of boolean flag to log
it as error message or informational message.
Signed-off-by: Rasesh Mody
---
drivers/net/qede/qede_ethdev.c | 20 +---
drivers/net/qede/qede_logs.h | 23
Add missing check for VNI field while adding unicast filter.
Signed-off-by: Rasesh Mody
---
drivers/net/qede/qede_ethdev.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ad264ba..a0616a4 100644
--- a/drivers/net/qede/q
From: Harish Patil
Since nb_max is a u16 it can store value upto 65535 only (not 64K), but
this value is not a power-of-2. So limit the ring sizes to 32K.
Signed-off-by: Harish Patil
---
drivers/net/qede/qede_ethdev.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
From: Harish Patil
Log HW errmsg on the stdout and do minimal handling to prevent HW
attentions from being reasserted.
Signed-off-by: Harish Patil
Signed-off-by: Rasesh Mody
---
drivers/net/qede/base/bcm_osal.c | 32
drivers/net/qede/base/bcm_osal.h |6
Changes include
- comment modifications
- adds tracing during initialization
- adds/removes new lines
Signed-off-by: Rasesh Mody
---
drivers/net/qede/base/bcm_osal.c | 14 --
drivers/net/qede/qede_ethdev.c | 11 +++
drivers/net/qede/qede_rxtx.c |6 +++---
3 f
Hi Ferruh,
This patch set contains minor enhancements and bug fixes for QEDE PMD.
It updates the driver version to 2.5.1.1. The patch set is tested
against dpdk-next-net.
Please apply to 17.08 tree.
v1..v2 address all review comments
Thanks!
Rasesh
Harish Patil (3):
net/qede: fix DMA memory
From: Harish Patil
Implement the macro OSAL_DMA_FREE_COHERENT to release DMA memories.
Track all DMA memory allocations using an array of memzone pointers and
use that to free memory resoureces along with other resource deallocation.
With this change there is no need to alter the base code to add
On 6/30/2017 7:25 PM, Yongseok Koh wrote:
>
> Hi,
>
>
>
> Thanks,
> Yongseok
>
>> On Jun 30, 2017, at 11:14 AM, Yongseok Koh wrote:
>>
>>
>>> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit wrote:
>>>
>>> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote:
This commit addresses a compilation issue
> > This patch fixes a trivial typo in the sample apps guide.
> > commit 35b09d76f89e ("doc: use corelist instead of coremask") replaced the
> > usage of coremask (-c) with corelist (-l).
> > As a result of this patch, we have
> > ./build/ipv4_multicast -l 0-3 -n 3 -- -p 0x3 -q 1 in the sample app
30/06/2017 14:51, Van Haaren, Harry:
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen
> >
> > This patch fixes a trivial typo in rte_ethdev.h; it should be
> > "RX multicast OFF" and not "RX multicast OF".
> >
> > Signed-off-by: Rami Rosen
>
> Acked-by: Harry van Haaren
Appli
15/06/2017 14:29, Bernard Iremonger:
> From: "Bernard.Iremonger"
>
> Change the rte_eth_dev_callback_process function to return int,
> and add a void *ret_param parameter.
Adding this explanation:
The new parameter is used by ixgbe and i40e instead of abusing
the user data of the
Generic segmentation offload (GSO) is a SW technique to segment large
packets into small ones. The packet types are various (e.g. TCP, UDP).
Like TSO, GSO gains performance by reducing per-packet overhead for
applications. Therefore, we propose to support GSO in DPDK.
DPDK GSO is designed as an ap
Alejandro,
Are you OK to replace log2 by rte_log2_u32?
I'm waiting your ack to apply this patch.
06/04/2017 16:23, Olivier MATZ:
> I forgot to CC Alejandro for nfp.
[...]
> > drivers/net/nfp/nfp_net.c | 6 ++
> > lib/librte_eal/common/include/rte_common.h | 17
21/06/2017 17:49, Sergio Gonzalez Monroy:
> I think following the discussion of libnuma dependency in another thread
> [1], you would need to implement a similar approach and keep the old
> method while providing this alternative if libnuma is present.
Considering that libnuma becomes mandatory
02/06/2017 18:20, Jianfeng Tan:
> Suppose we have 2 virtio devices for a VM, with only the first one,
> virtio0, binding to igb_uio. Start a primary DPDK process, driving
> only virtio0. Then start a secondary DPDK process, it encounters
> segfault at eth_virtio_dev_init() because hw is NULL, when
-Original Message-
> Date: Fri, 30 Jun 2017 02:20:34 +
> From: "Eads, Gage"
> To: Jerin Jacob , "dev@dpdk.org"
>
> CC: "Richardson, Bruce" , "Van Haaren, Harry"
> , "hemant.agra...@nxp.com"
> , "nipun.gu...@nxp.com" ,
> "Vangati, Narender" , "Rao, Nikhil"
>
> Subject: RE: [dpdk-
-Original Message-
> Date: Fri, 30 Jun 2017 14:24:14 +0530
> From: Nipun Gupta
> To: dev@dpdk.org
> CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com,
> harry.van.haa...@intel.com, bruce.richard...@intel.com,
> gage.e...@intel.com, shreyansh.j...@nxp.com, Nipun Gupta
>
> Subje
-Original Message-
> Date: Fri, 30 Jun 2017 12:13:15 +
> From: "Mcnamara, John"
> To: Nipun Gupta , "dev@dpdk.org"
> CC: "hemant.agra...@nxp.com" ,
> "jerin.ja...@caviumnetworks.com" , "Van
> Haaren, Harry" , "Richardson, Bruce"
> , "Eads, Gage" ,
> "shreyansh.j...@nxp.com"
> Sub
01/07/2017 13:14, Thomas Monjalon:
> 30/06/2017 13:36, Olivier Matz:
> > On Fri, 2 Jun 2017 13:12:13 -0700, Daniel Verkamp
> > wrote:
> > > rte_memzone_reserve() provides cache line alignment, but
> > > struct rte_ring may require more than cache line alignment: on x86-64,
> > > it needs 128-byt
30/06/2017 13:36, Olivier Matz:
> On Fri, 2 Jun 2017 13:12:13 -0700, Daniel Verkamp
> wrote:
> > rte_memzone_reserve() provides cache line alignment, but
> > struct rte_ring may require more than cache line alignment: on x86-64,
> > it needs 128-byte alignment due to PROD_ALIGN and CONS_ALIGN, w
This patch enables TCP/IPv4 GRO library in csum forwarding engine.
By default, GRO is turned off. Users can use command "gro (on|off)
(port_id)" to enable or disable GRO for a given port. If a port is
enabled GRO, all TCP/IPv4 packets received from the port are performed
GRO. Besides, users can set
In this patch, we introduce five APIs to support TCP/IPv4 GRO.
- gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used
to merge packets.
- gro_tcp4_tbl_destroy: free memory space of a TCP/IPv4 reassembly table.
- gro_tcp4_tbl_timeout_flush: flush timeout packets from a TCP/IPv4
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains
performance by reassembling small packets into large ones. This
patchset is to support GRO in DPDK. To support GRO, this patch
implements a GRO API framework.
To enable m
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains performance
by reassembling small packets into large ones. Therefore, we propose to
support GRO in DPDK.
To enable more flexibility to applications, DPDK GRO is implement
30/06/2017 18:12, Thomas Monjalon:
> Version 11:
> * Fixed test-build.sh for missing libnuma dependency
>
> Version 10:
> * Fixed typo in DPAA2 config.
>
> Version 9:
> * Removed DPDK_DEP_NUMA from test-build.sh . Not needed
> anymore.
> * Fixed out of bo
07/06/2017 19:20, Ferruh Yigit:
> On 5/11/2017 12:51 PM, Gowrishankar wrote:
> > From: Gowrishankar Muthukrishnan
> >
> > In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf
> > always into alloc_q, which is excessively leading too many rte_pktmbuf_
> > free() when alloc_q is
30/06/2017 16:27, Olivier Matz:
> On Wed, 28 Jun 2017 15:25:12 +0300, Vasily Philipov
> wrote:
> > rte_pktmbuf_headroom() and rte_pktmbuf_tailroom() should be usable
> > with any segment, not only with headered ones, so is_header should be 0
> > when we call for sanity check inside them.
> >
> >
30/06/2017 14:27, Olivier Matz:
> On Tue, 27 Jun 2017 17:27:51 +0530, Jerin Jacob
> wrote:
> > There is no need for initializing the complete
> > packet buffer with zero as the packet data area will be
> > overwritten by the NIC Rx HW anyway.
> >
> > The testpmd configures the packet mempool
> >
39 matches
Mail list logo
