Re: [dpdk-dev] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-20 Thread Pavel Shirshov
Hi Sam, Below I'm saying about KVM. I don't have experience with vbox and others. 1. I'd suggest don't use dpdk inside of VM if you want to see best perfomance on the box. 2. huge pages enabled globally will not have any bad effect to guest OS. Except you have to enable huge pages inside of VM and

Re: [dpdk-dev] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-20 Thread Sam
BTW, we also think about use ovs-dpdk in docker enviroment, but test result said it's not good idea, we don't know why. 2017-06-21 11:32 GMT+08:00 Sam : > Hi all, > > We plan to use DPDK on HP host machine with several core and big memory. > We plan to use qemu-kvm enviroment. The host will carry

[dpdk-dev] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-20 Thread Sam
Hi all, We plan to use DPDK on HP host machine with several core and big memory. We plan to use qemu-kvm enviroment. The host will carry 4 or more guest vm and 1 ovs. Ovs-dpdk is much faster then normal ovs, but to use ovs-dpdk, we have to enable huge page globally. My question is, will huge pag

[dpdk-dev] [RFC 27/29] vhost: various optimizations for Tx

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 049b400..2d111a3 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/v

[dpdk-dev] [RFC 29/29] vhost: update and return descs in batch

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 8344bcb..7f76b1a 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_n

[dpdk-dev] [RFC 26/29] vhost: remove dead code

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 2bd1298..049b400 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/li

[dpdk-dev] [RFC 28/29] vhost: make the code more readable

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 2d111a3..8344bcb 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_net.c

[dpdk-dev] [RFC 25/29] net/virtio: refill descs for vhost in batch

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 93d564f..3dc5eaf 100644 --- a/drivers/net/virtio/virtio_rxt

[dpdk-dev] [RFC 24/29] net/virtio: cleanup txd when free count below threshold

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx_1.1.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/virtio/virtio_rxtx_1.1.c b/drivers/net/virtio/virtio_rxtx_1.1.c index fdc7402..4602e6d 100644 --- a/drivers/net/virtio/virtio_rxtx_1.1.c +++ b/drivers/net/virtio/v

[dpdk-dev] [RFC 23/29] vhost: fix mbuf leak

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index c14582b..2bd1298 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_net.c

[dpdk-dev] [RFC 22/29] vhost: don't copy descs during Rx

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 35 ++- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 7a978b9..c14582b 100644 --- a/lib/librte_vhost/virtio_net.c +++

[dpdk-dev] [RFC 21/29] net/virtio: free mbuf when need to use

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx_1.1.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx_1.1.c b/drivers/net/virtio/virtio_rxtx_1.1.c index 05f9dc7..fdc7402 100644 --- a/drivers/net/virtio/virtio_rxtx_1.1

[dpdk-dev] [RFC 19/29] vhost: VIRTIO_NET_F_MRG_RXBUF is not supported for now

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index f3b7ad5..7976621 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_vhost/vhost.h @@ -146,7 +146,7 @@ struct vhos

[dpdk-dev] [RFC 20/29] vhost: fix vring addr setup

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost.c | 4 lib/librte_vhost/vhost_user.c | 17 +++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index 19c5a43..b7bc1ee 100644 --- a/lib/librte_vhost/vhos

[dpdk-dev] [RFC 18/29] net/virtio: the Rx support for virtio1.1 has been added now

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 8b754ac..334c4b8 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_et

[dpdk-dev] [RFC 15/29] vhost: descriptor length should include vhost header

2017-06-20 Thread Tiwei Bie
From: Jens Freimann Signed-off-by: Jens Freimann --- lib/librte_vhost/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index f7dd4eb..7a978b9 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte

[dpdk-dev] [RFC 16/29] net/virtio: avoid touching packet data

2017-06-20 Thread Tiwei Bie
For performance testing purpose, avoid touching the packet data when receiving packets. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 3be64da..93d

[dpdk-dev] [RFC 17/29] net/virtio: fix virtio1.1 feature negotiation

2017-06-20 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c index 3ff6a05..e3471d1 100644 --- a/drivers

[dpdk-dev] [RFC 14/29] vhost: a rough implementation on enqueue code path

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- lib/librte_vhost/virtio_net.c | 124 +- 1 file changed, 123 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index b4d9031..f7dd4eb 100644 --- a/lib/l

[dpdk-dev] [RFC 11/29] add virtio 1.1 test guide

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- README-virtio-1.1 | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 README-virtio-1.1 diff --git a/README-virtio-1.1 b/README-virtio-1.1 new file mode 100644 index 000..8af3eb3 ---

[dpdk-dev] [RFC 10/29] vhost: prefetch desc

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- lib/librte_vhost/virtio_net.c | 36 +--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index c9e466f..b4d9031 100644 --- a/lib/librte_v

[dpdk-dev] [RFC 13/29] net/virtio: implement the Rx code path

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Just make it stick to the non-mergeable code path now, though it's likely it would be really easy to add such support. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 5 +- drivers/net/virtio/virtio_rxtx.c | 121 ++---

[dpdk-dev] [RFC 12/29] testpmd: add s-txonly

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- app/test-pmd/Makefile | 1 + app/test-pmd/s-txonly.c | 134 app/test-pmd/testpmd.c | 1 + app/test-pmd/testpmd.h | 1 + 4 files changed, 137 insertions(+) create mode 100644 app/test-pmd

[dpdk-dev] [RFC 09/29] xxx: virtio: remove overheads

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu for better performance comparing Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_rxtx.c | 190 +++ 1 file changed, 13 insertions(+), 177 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c

[dpdk-dev] [RFC 05/29] vhost: set desc addr for 1.1

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 208b2eb..f3b7ad5 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/li

[dpdk-dev] [RFC 07/29] vhost: mark desc being used

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- lib/librte_vhost/virtio_net.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index fd6f200..df88e31 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib

[dpdk-dev] [RFC 08/29] xxx: batch the desc_hw update?

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_rxtx_1.1.c | 18 ++ lib/librte_vhost/virtio_net.c| 17 ++--- 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx_1.1.c b/drivers/net/virtio

[dpdk-dev] [RFC 06/29] vhost: implement virtio 1.1 dequeue path

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Build test only; haven't tested it yet Signed-off-by: Yuanhan Liu Signed-off-by: Jens Freimann --- lib/librte_vhost/virtio-1.1.h | 23 ++ lib/librte_vhost/virtio_net.c | 181 ++ 2 files changed, 204 insertions(+) create mode 1006

[dpdk-dev] [RFC 04/29] vhost: enable 1.1 for testing

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Just set the features on, no actual work has been done. Just make sure the virtio PMD could have this feature been enabled, for testing only. Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/vhost

[dpdk-dev] [RFC 03/29] net/virtio-user: add option to enable 1.1

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 9 - drivers/net/virtio/virtio_user/virtio_user_dev.h | 3 ++- drivers/net/virtio/virtio_user_ethdev.c | 14 +- 3 files changed, 23 insertions(+), 3 deletions(-) d

[dpdk-dev] [RFC 01/29] net/virtio: vring init for 1.1

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu Add and initialize descriptor data structures. Signed-off-by: Yuanhan Liu [rename desc_1_1 to vring_desc_1_1, refactor desc init code] Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio-1.1.h| 19 +++ drivers/net/virtio/virtio_ethdev.c | 22 ++

[dpdk-dev] [RFC 00/29] latest virtio1.1 prototype

2017-06-20 Thread Tiwei Bie
This patchset rebased Yuanhan's virtio1.1 prototype [1] to the current master branch of dpdk-next-virtio tree. It also contains Jens' fixes, my fixes and optimizations. After sending each RFC patchset to the mailing list, I'll also collect them to my github repo [2] to give everyone a repo where c

[dpdk-dev] [RFC 02/29] net/virtio: implement 1.1 guest Tx

2017-06-20 Thread Tiwei Bie
From: Yuanhan Liu build only so far Signed-off-by: Yuanhan Liu --- drivers/net/virtio/Makefile | 1 + drivers/net/virtio/virtio_ethdev.c | 24 -- drivers/net/virtio/virtio_ethdev.h | 3 + drivers/net/virtio/virtio_rxtx.c | 3 + drivers/net/virtio/virtio_rxtx_1.1.c |

Re: [dpdk-dev] [RFC] Add hot plug event in rte eal interrupt and inplement it in i40e driver.

2017-06-20 Thread Guo, Jia
hi,gaetan On 6/16/2017 5:22 AM, Gaƫtan Rivet wrote: Hi Jingjing, On Wed, Jun 07, 2017 at 07:40:37AM +, Wu, Jingjing wrote: Secondly, in order to read out the uevent that monitoring, we need to add uevent API in rte layer. We plan add 2 , rte_uevent_connect and rte_get_uevent. All drive

Re: [dpdk-dev] [PATCH] net/fm10k: initialize link status in device start

2017-06-20 Thread Chen, Jing D
Hi, > -Original Message- > From: Wang, Xiao W > Sent: Wednesday, May 31, 2017 7:07 PM > To: Chen, Jing D > Cc: dev@dpdk.org; Wang, Xiao W ; > sta...@dpdk.org > Subject: [PATCH] net/fm10k: initialize link status in device start > > If port LSC interrupt is configured, application will rea

Re: [dpdk-dev] [PATCH v2 2/6] net/vmxnet3: Implement retrieval of extended stats

2017-06-20 Thread Shrikrishna Khare
On Thu, 15 Jun 2017, Charles (Chas) Williams wrote: > From: Robert Shearman > > Implement xstats_get() to allow a number of driver-specific tx and rx > stats to be retrieved. > > Signed-off-by: Robert Shearman Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH v5 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-20 Thread Stephen Hemminger
On Wed, 21 Jun 2017 07:30:08 +0800 "Tan, Jianfeng" wrote: > >>> To process an incoming packet, we need three steps: > >>> a. check if the packet should be processed. Packets with the following > >>> properties won't be processed: > >>> - packets without data; > >>> - packets with wrong

[dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory

2017-06-20 Thread Gaetan Rivet
pmdinfogen has a dependency on the PCI bus. The latter must be built first. Signed-off-by: Gaetan Rivet --- GNUmakefile| 2 +- MAINTAINERS| 2 +- buildtools/Makefile| 36 buildtools/pmdinfogen/Makefile | 47 - bui

[dpdk-dev] [PATCH v3 4/9] bus: properly include rte_debug

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index e9fbc03..7e8d50b 100644 --- a/lib/librte_eal/common/eal_common_bus.c +++ b/lib/librte_e

[dpdk-dev] [PATCH v3 1/9] kni: disabled by default

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- config/common_linuxapp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_linuxapp b/config/common_linuxapp index b3cf41b..cc85cc6 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -38,7 +38,7 @@ CONFIG_RTE_EXEC_ENV_

[dpdk-dev] [PATCH v3 2/9] eal: expose rte_eal_using_phys_addrs

2017-06-20 Thread Gaetan Rivet
This function was previously private to the EAL layer. Other subsystems requires it, such as the PCI bus. This function is only exposed for linuxapps. In order not to force other components to include stdbool, which is incompatible with several NIC drivers, the return type has been changed from b

[dpdk-dev] [PATCH v3 3/9] ethdev: remove useless PCI dependency

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 4a1d0b9..bc4941e 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -47,7 +47,6 @@ #

[dpdk-dev] [PATCH v3 0/9] bus/pci: remove PCI bus from EAL

2017-06-20 Thread Gaetan Rivet
This patchset moves the PCI bus out of the EAL to the drivers/bus subdirectory. Almost all dependencies have been worked out, only remains KNI to be made fully independent from the PCI bus in its lib section. This patchset includes a patch disabling it, that should be removed before integration,

[dpdk-dev] [PATCH v3 8/9] drivers: update eventdev dependencies

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/Makefile b/drivers/Makefile index f3f9417..30c28e4 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -41,5 +41,6 @@ DEPDIRS-net := bus pmdinfogen mempool DIRS-$(CONFIG_RTE_LIBRTE_CR

[dpdk-dev] [PATCH v3 9/9] drivers: update cryptodev dependencies

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/Makefile b/drivers/Makefile index 30c28e4..c94d102 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -39,7 +39,7 @@ DEPDIRS-mempool := bus DIRS-y += net DEPDIRS-net

[dpdk-dev] [PATCH v3 7/9] bus/pci: follow checkpatch

2017-06-20 Thread Gaetan Rivet
As the PCI bus has been moved entirely to drivers/bus, it is possible to use checkpatch for the whole set and fix it, as future fixes and merges should not be impaired any more than by the move itelf. Signed-off-by: Gaetan Rivet --- drivers/bus/pci/bsd/rte_pci.c| 23 drivers/bu

[dpdk-dev] [PATCH v5 16/19] devargs: introduce cleaner parsing helper

2017-06-20 Thread Gaetan Rivet
Introduce a more versatile helper to parse device strings. This helper expects a generic rte_devargs structure as storage in order not to require any API changes in the future, should this structure be updated. The old equivalent function is thus being deprecated, as its API does not allow to acco

[dpdk-dev] [PATCH v5 18/19] devargs: remove function

2017-06-20 Thread Gaetan Rivet
This function is now necessary due to the new unplug rte_bus API. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_devargs.c | 18 ++ lib/librte_eal/common/include/rte_devargs.h | 14 ++

[dpdk-dev] [PATCH v5 19/19] eal: change whitelist / blacklist command line doc

2017-06-20 Thread Gaetan Rivet
The use of these commands have evolved. It is now possible to use whitelist and blacklist on any bus. Update the source code accordingly. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_options.c | 18 +- lib/librte_eal/common/eal_options.h| 8

[dpdk-dev] [PATCH v5 07/19] app/testpmd: properly reference PCI header

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 1838241..90a6568 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -34,6 +34,8 @@ #ifndef _TESTPMD_H_ #define _TES

[dpdk-dev] [PATCH v5 17/19] devargs: clone function

2017-06-20 Thread Gaetan Rivet
This function returns a deep copy of an rte_devargs. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_devargs.c | 20 lib/librte_eal/common/include/rte_devargs.h | 12 lib/librte_ea

[dpdk-dev] [PATCH v5 15/19] devargs: generic device types

2017-06-20 Thread Gaetan Rivet
rte_devargs now represents any device from any bus. The related devtypes do not identify a bus anymore, only which scan policy the device subscribes to. The bus itself is identified by a bus handle previously introduced. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c

[dpdk-dev] [PATCH v5 14/19] net/virtio: do not reference device type

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/virtio/virtio_pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index b7b3d61..cd48fb5 100644 --- a/drivers/net/virtio/virtio_pci.c +++ b/drivers/net/virtio/v

[dpdk-dev] [PATCH v5 13/19] pci: update device name

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 441466d..eed6589 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_e

[dpdk-dev] [PATCH v5 12/19] devargs: generic device representation

2017-06-20 Thread Gaetan Rivet
Remove the dependency of this subsystem upon bus specific device representation. Devargs only validates that a device declaration is correct and handled by a bus. The device interpretation is done afterward within the bus. Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v5 11/19] devargs: parse bus policies

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index d5f297d..ac51b19 100644 --- a/lib/librte_eal/common/eal_co

[dpdk-dev] [PATCH v5 09/19] dev: device kernel module is a device attribute

2017-06-20 Thread Gaetan Rivet
It is used in generic device structures and must not be tied to a bus. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_dev.h | 12 lib/librte_eal/common/include/rte_pci.h | 9 - 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v5 10/19] bus: introduce bus scan policies

2017-06-20 Thread Gaetan Rivet
Scan policies describe the way a bus should scan the system to search for possible devices. Three flags are introduced: RTE_BUS_SCAN_UNDEFINED: Configuration is irrelevant for this bus RTE_BUS_SCAN_WHITELIST: Scanning should be limited to declared devices RTE_BUS_SCAN_BLACKLIST: Scanning sho

[dpdk-dev] [PATCH v5 08/19] test: properly reference PCI header

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- test/test/virtual_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c index e9dd8ac..f3ee82f 100644 --- a/test/test/virtual_pmd.c +++ b/test/test/virtual_pmd.c @@ -33,6 +33,7 @@ #include #include +#inclu

[dpdk-dev] [PATCH v5 05/19] net/ixgbe: properly reference PCI header

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/ixgbe/ixgbe_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h index 10b9967..bcbd62d 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.h +++ b/drivers/net/ixgbe/ixgbe_ethdev.h @@ -

[dpdk-dev] [PATCH v5 06/19] net/sfc: properly reference PCI header

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/sfc/sfc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h index 007ed24..41dff48 100644 --- a/drivers/net/sfc/sfc.h +++ b/drivers/net/sfc/sfc.h @@ -34,6 +34,7 @@ #include +#include #include #in

[dpdk-dev] [PATCH v5 01/19] net/bonding: properly reference PCI header

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/bonding/rte_eth_bond_args.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index dc468d2..ed217fb 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/

[dpdk-dev] [PATCH v5 00/19] Generic devargs parsing

2017-06-20 Thread Gaetan Rivet
The second part of the work outlined in [1] and [2]. The first part is at [3]. In this patchset, the representation of devices in rte_devargs is made generic to remove some dependencies of the EAL on specific buses implementations. Following the device types being characterized by their bus, the D

[dpdk-dev] [PATCH v5 04/19] net/e1000: properly reference PCI header

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/e1000/e1000_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h index 85fd1a0..5668910 100644 --- a/drivers/net/e1000/e1000_ethdev.h +++ b/drivers/net/e1000/e1000_ethdev.h @@ -

[dpdk-dev] [PATCH v5 03/19] net/mlx5: properly reference PCI header

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx5/mlx5.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index aa8a1a0..f16f778 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -54,6 +54,7 @@ #ifdef PEDANTIC #pragma GCC d

[dpdk-dev] [PATCH v5 02/19] net/bnxt: properly reference PCI header

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/bnxt/bnxt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 1538aa5..07279f7 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -38,6 +38,7 @@ #include #include +#inclu

[dpdk-dev] [PATCH v5 7/7] devargs: parse bus info

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 15 ++- lib/librte_eal/common/eal_common_vdev.c | 6 -- lib/librte_eal/common/include/rte_devargs.h | 3 +++ 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/ea

[dpdk-dev] [PATCH v5 6/7] vdev: expose bus name

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 2 +- lib/librte_eal/common/include/rte_vdev.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 8dd4c88..221146e

[dpdk-dev] [PATCH v5 5/7] bus: add helper to find a bus from a device name

2017-06-20 Thread Gaetan Rivet
Find which bus should be able to parse this device name into an internal device representation. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 15 +++ lib/librte_eal/common/include/rte_bus.h

[dpdk-dev] [PATCH v5 4/7] pci: implement parse bus operation

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ lib/librte_eal/common/eal_common_bus.c | 16 lib/librte_eal/common/eal_common_pci.c | 19 +++ lib/librte_eal/common/include/rte_bus.h | 14 +

[dpdk-dev] [PATCH v5 3/7] vdev: implement parse bus operation

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 60 + 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 22e4640..8dd4c88 100644 --- a/li

[dpdk-dev] [PATCH v5 0/7] rte_bus parse API

2017-06-20 Thread Gaetan Rivet
Following the evolutions announced in [1], here is the first part of the rte_devargs rework planned for 17.08. The rationale has been partially explained in [2]. This first part covers the introduction of the necessary facilities in rte_bus to allow for generic device parsing. This API is implemen

[dpdk-dev] [PATCH v5 2/7] bus: introduce parsing functionality

2017-06-20 Thread Gaetan Rivet
This operation can be used either to validate that a device representation can be understood by a bus, as well as store the resulting specialized device representation in any format determined by the bus. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 21 ++

[dpdk-dev] [PATCH v4 9/9] ethdev: use embedded rte_device to detach driver

2017-06-20 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_dev.c| 43 --- lib/librte_eal/common/include/rte_dev.h | 11 +++ lib/librte_ether/rte_ethd

[dpdk-dev] [PATCH v5 1/7] bus: fix bus name registration

2017-06-20 Thread Gaetan Rivet
The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insert

[dpdk-dev] [PATCH v4 8/9] eal: make virtual driver probe and remove take rte_vdev_device

2017-06-20 Thread Gaetan Rivet
From: Jan Blunck This is a preparation to embed the generic rte_device into the rte_eth_dev also for virtual devices. Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 93 ++ 1 file changed, 71 insertions(+), 22

Re: [dpdk-dev] [PATCH v5 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-20 Thread Tan, Jianfeng
Hi Jiayu, On 6/20/2017 11:22 AM, Jiayu Hu wrote: Hi Jianfeng, On Mon, Jun 19, 2017 at 11:43:20PM +0800, Tan, Jianfeng wrote: On 6/18/2017 3:21 PM, Jiayu Hu wrote: In this patch, we introduce six APIs to support TCP/IPv4 GRO. Those functions are not used outside of this library. Don't make

[dpdk-dev] [PATCH v4 7/9] vdev: implement hotplug functionality

2017-06-20 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 36 + 1 file changed, 36 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 52528ef..22e4640 100644 --- a/lib/librte_eal/comm

[dpdk-dev] [PATCH v4 6/9] vdev: implement find_device bus operation

2017-06-20 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 0037a64..52528ef 100644

[dpdk-dev] [PATCH v4 3/9] bus: add helper to find bus for a particular device

2017-06-20 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 24 lib/librte_eal/common/include/rte_bus.h | 5 + lib/librte_eal/linuxapp/

[dpdk-dev] [PATCH v4 5/9] bus: introduce hotplug functionality

2017-06-20 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 2 ++ lib/librte_eal/common/include/rte_bus.h | 31 +++ 2 files changed, 33 insertions(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/li

[dpdk-dev] [PATCH v4 4/9] bus: add bus helper iterator to find a particular device

2017-06-20 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 24 lib/librte_eal/common/include/rte_bus.h | 23 +++ lib/li

[dpdk-dev] [PATCH v4 2/9] bus: add device iterator

2017-06-20 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 7 +++ lib/librte_eal/common/include/rte_dev.h | 17 + 2 files changed, 24 insertions(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte

[dpdk-dev] [PATCH v4 1/9] bus: add bus iterator to find a particular bus

2017-06-20 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 20 lib/librte_eal/common/include/rte_bus.h | 41 + lib/librte_eal/l

[dpdk-dev] [PATCH v4 0/9] bus: attach / detach API

2017-06-20 Thread Gaetan Rivet
Following the work from Jan: This patchset introduces the attach / detach API to rte_bus. The rte_device structure is used as the generic device representation. This API is implemented for the virtual bus. The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to use this new interfa

Re: [dpdk-dev] [PATCH 06/12] cryptodev: move vdev functions to a separate file

2017-06-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty > Sent: Tuesday, June 20, 2017 3:37 PM > To: De Lara Guarch, Pablo ; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 06/12] cryptodev: move vdev functions to a > separate f

[dpdk-dev] [RFC PATCH] mk: symlink every headers first

2017-06-20 Thread Thomas Monjalon
If a library or a build tool uses a definition from a driver, there is a build ordering issue, like seen when moving PCI code into a bus driver. One option is to keep PCI helpers and some common definitions in EAL. The other option is to symlink every headers at the beginning of the build so they

Re: [dpdk-dev] [PATCH 04/12] cryptodev: simplify device list retrieval logic

2017-06-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty > Sent: Tuesday, June 20, 2017 3:36 PM > To: De Lara Guarch, Pablo ; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 04/12] cryptodev: simplify device list > retrieval > l

Re: [dpdk-dev] [PATCH 01/12] cryptodev: store device pointer in virtual devices

2017-06-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: Doherty, Declan > Sent: Tuesday, June 20, 2017 3:34 PM > To: De Lara Guarch, Pablo ; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [PATCH 01/12] cryptodev: store device pointer in virtual devices > > On 24/05/2017 4:27 PM, Pablo de Lara wrote: > > O

Re: [dpdk-dev] [PATCH 03/12] cryptodev: rename device retrieval argument

2017-06-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: Doherty, Declan > Sent: Tuesday, June 20, 2017 3:35 PM > To: De Lara Guarch, Pablo ; > tho...@monjalon.net > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH 03/12] cryptodev: rename device retrieval argument > > On 24/05/2017 4:27 PM, Pablo de Lara wr

[dpdk-dev] [PATCH 18/18] examples/performance-thread: remove non-SSE4 fallbacks

2017-06-20 Thread Bruce Richardson
Since this example is for x86_64 platforms only, and since SSE4 is now a mandatory requirement, we can remove the ifdefs checking for that instruction set level, and the fallbacks if it is not present. Signed-off-by: Bruce Richardson --- examples/performance-thread/l3fwd-thread/main.c | 25 -

[dpdk-dev] [PATCH 17/18] examples/l3fwd: remove checks for SSE4

2017-06-20 Thread Bruce Richardson
Since SSE4 is now part of the minimum requirements for DPDK, we don't need to check for its presence any more. Signed-off-by: Bruce Richardson --- examples/l3fwd-power/main.c | 2 +- examples/l3fwd-vf/main.c| 2 +- examples/l3fwd/l3fwd_em.c | 6 +++--- examples/l3fwd/l3fwd_lpm.c | 6 +++--

[dpdk-dev] [PATCH 15/18] net/ixgbe: remove fallback code for non-SSE4 systems

2017-06-20 Thread Bruce Richardson
Since SSE4 is now part of minimum requirements for DPDK on x86, we no longer need this fallback code. Signed-off-by: Bruce Richardson --- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/n

[dpdk-dev] [PATCH 14/18] net/i40e: remove checks for SSE4

2017-06-20 Thread Bruce Richardson
Since SSE4 is now part of the minimum requirements for DPDK, we no longer need these checks. Signed-off-by: Bruce Richardson --- drivers/net/i40e/Makefile| 5 - drivers/net/i40e/i40e_rxtx_vec_sse.c | 6 -- 2 files changed, 11 deletions(-) diff --git a/drivers/net/i40e/Makefi

[dpdk-dev] [PATCH 16/18] examples/ip_pipeline: remove macro check for SSE4

2017-06-20 Thread Bruce Richardson
Since SSE4 is now part of the minimum requirements for DPDK, we don't need to check for its presence any more. Signed-off-by: Bruce Richardson --- examples/ip_pipeline/pipeline/hash_func.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ip_pipeline/pipeline/hash_func

[dpdk-dev] [PATCH 13/18] net/enic: replace check for SSE4 with check for x86

2017-06-20 Thread Bruce Richardson
Since SSE4 is now minimum requirement for x86 platforms we can replace the check for SSE4 with a check for x86 Signed-off-by: Bruce Richardson --- drivers/net/enic/enic_clsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic

[dpdk-dev] [PATCH 12/18] crypto/zuc: remove check for SSE4

2017-06-20 Thread Bruce Richardson
Since SSE4 is now part of the minimum requirements for DPDK, we don't need to check for its presence any more. Signed-off-by: Bruce Richardson --- drivers/crypto/zuc/rte_zuc_pmd.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/crypto/zuc/rte_zuc_pmd.c b/dri

[dpdk-dev] [PATCH 11/18] crypto/snow3g: remove check for SSE4

2017-06-20 Thread Bruce Richardson
Since SSE4 is now part of the minimum requirements for DPDK, we don't need to check for its presence any more. Signed-off-by: Bruce Richardson --- drivers/crypto/snow3g/rte_snow3g_pmd.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/crypto/snow3g/rte_snow3g

[dpdk-dev] [PATCH 10/18] crypto/kasumi: remove check for SSE4

2017-06-20 Thread Bruce Richardson
Since SSE4 is now part of the minimum requirements for DPDK, we don't need to check for its presence any more. Signed-off-by: Bruce Richardson --- drivers/crypto/kasumi/rte_kasumi_pmd.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.

[dpdk-dev] [PATCH 09/18] crypto/aesni_mb: remove check for SSE4

2017-06-20 Thread Bruce Richardson
Since SSE4 is now part of the minimum requirements for DPDK, we don't need to check for its presence any more. Signed-off-by: Bruce Richardson --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni

  1   2   >