> -----Original Message-----
> From: Doherty, Declan
> Sent: Tuesday, June 20, 2017 3:35 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>;
> tho...@monjalon.net
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH 03/12] cryptodev: rename device retrieval argument
>
> On 24/05/2017 4:27 PM, Pablo de Lara wrote:
> > rte_cryptodev_devices_get() function was parsing a crypto device name
> > as an argument, but the function actually returns device identifiers
> > of devices that share the same crypto driver, so the argument should
> > be driver name, instead.
> >
> > Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info")
> > CC: sta...@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>
> > ---
> > lib/librte_cryptodev/rte_cryptodev.c | 2 +-
> > lib/librte_cryptodev/rte_cryptodev.h | 7 ++++---
> > 2 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/librte_cryptodev/rte_cryptodev.c
> > b/lib/librte_cryptodev/rte_cryptodev.c
> > index a5a5c36..6880661 100644
> > --- a/lib/librte_cryptodev/rte_cryptodev.c
> > +++ b/lib/librte_cryptodev/rte_cryptodev.c
> > @@ -523,7 +523,7 @@ rte_cryptodev_count_devtype(enum
> > rte_cryptodev_type type) }
> >
> > uint8_t
> > -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices,
> > +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices,
> > uint8_t nb_devices)
> > {
> > uint8_t i, count = 0;
>
> Compilation breaks after this change, needs next patch to build
Yes, I forgot to change the variable name within the implementation.
I should better fix this and have it separated from the next one, though,
because this patch should be backported, but the following patch changes
the implementation, which requires patch 2.
So, I will send a v2 with the fix for this patch.
