we need to update dev->data->dev_link before handling lsc event.
Otherwise it will still have the initial value after the startup of
the program before interrupt callback was executed.
Signed-off-by: wang wei
---
drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++-
1 file changed, 3 insertions(+), 1
we need to update dev->data->dev_link before handling lsc event.
Otherwise it will still have the initial value after the startup of
the program before interrupt callback was executed.
Signed-off-by: wang wei
---
drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++-
1 file changed, 3 insertions(+), 1
Fix array bounds when set default ptype mapping.
Fixes: 62e94f7f66fb ("net/i40e: configure packet type mapping")
Signed-off-by: Jingjing Wu
---
drivers/net/i40e/i40e_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rx
Ok.
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, April 24, 2017 4:05 PM
> To: Zhao1, Wei
> Cc: dev@dpdk.org; Yuanhan Liu ; Ananyev,
> Konstantin ; Mcnamara, John
> ; Lu, Wenzhuo ; Liu,
> Yu Y
> Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte
When parsing a CLI, all the CLI instances are checked
one by one. Even if an instance already matches the CLI,
the parsing will not stop for ambiguous check.
The problem is that the following check may change the
parsing result of the previous one even if the following
instance doesn't match.
Use
On Mon, Apr 24, 2017 at 05:52:59PM +0200, Adrien Mazarguil wrote:
> Exported headers must allow compilation with the strictest flags. This
> commit addresses the following errors:
>
> In file included from /tmp/check-includes.sh.20132.c:1:0:
> build/include/rte_vhost.h:73:30: error: ISO C forbid
Hi Srini,
> -Original Message-
> From: Srinivasan J [mailto:srinid...@gmail.com]
> Sent: Monday, April 24, 2017 6:51 PM
> To: Lu, Wenzhuo
> Cc: Ananyev, Konstantin; dev@dpdk.org
> Subject: Re: [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+
>
> Hi Wenzhuo,
>
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Monday, April 24, 2017 11:53 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei
> Subject: [PATCH 12/13] ethdev: fix C++ errors in flow API (MPLS, GRE)
>
> This commit addresses the following compilation error
Hi Olivier,
> -Original Message-
> From: Olivier Matz [mailto:olivier.m...@6wind.com]
> Sent: Monday, April 24, 2017 6:12 PM
> To: Lu, Wenzhuo
> Cc: 'dev@dpdk.org'
> Subject: Re: CLI parsing issue
>
> I checked in detail, and you're right there is a bug here. Your proposed
> patch looks g
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Monday, April 24, 2017 11:53 AM
<...>
> diff --git a/drivers/net/avp/rte_avp_common.h
> b/drivers/net/avp/rte_avp_common.h
> index 31d763e..6cdaca9 100644
> --- a/drivers/net/avp/rte_avp_common.h
> ++
E-Tag and NVGRE pattern items have been added hastily without updating
documentation nor testpmd.
This commit also adds default masks for these items based on the ixgbe
implementation.
Fixes: 99e7003831c3 ("net/ixgbe: parse L2 tunnel filter")
Cc: sta...@dpdk.org
Cc: Wei Zhao
Cc: Wenzhuo Lu
Sig
This commit addresses the following compilation errors:
In file included from build/include/rte_flow_driver.h:50:0,
from /tmp/check-includes.sh.1397.cc:1:
build/include/rte_flow.h:631:1: error: C99 designator 'label_tc_s' outside
aggregate initializer
[...]
build/include/
This commit addresses the following compilation errors:
In file included from build/include/rte_flow_driver.h:50:0,
from /tmp/check-includes.sh.1397.cc:1:
build/include/rte_flow.h:428:2: error: expected primary-expression before
'.' token
[...]
build/include/rte_flow.h:46
This commit addresses the following compilation errors:
In file included from /tmp/check-includes.sh.21060.c:1:0:
build/include/rte_metrics.h:91:2: error: unknown type name 'uint16_t'
[...]
It also adds C++ awareness to rte_metrics.h.
Fixes: 349950ddb9c5 ("metrics: add information metrics lib
This commit addresses several errors related to missing includes such as:
In file included from /tmp/check-includes.sh.15315.c:1:0:
build/include/rte_avp_fifo.h:77:22: error: 'struct rte_avp_fifo' declared
inside parameter list [-Werror]
[...]
build/include/rte_avp_fifo.h: In function 'avp
This commit addresses the following compilation errors:
In file included from /tmp/check-includes.sh.8373.c:1:0:
build/include/rte_efd.h:133:9: error: unknown type name 'uint8_t'
[...]
Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
Cc: sta...@dpdk.org
Cc: Byron Marohn
Cc:
This commit addresses the following error:
In file included from /tmp/check-includes.sh.28023.c:1:0:
build/include/rte_bitrate.h:82:2: error: unknown type name 'uint8_t'
[...]
It also adds C++ awareness to rte_bitrate.h.
Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
Cc: Rem
This commit addresses the following errors:
In file included from /tmp/check-includes.sh.681.c:1:0:
build/include/rte_mbuf_ptype.h:587:35: error: unknown type name 'uint32_t'
[...]
build/include/rte_mbuf_ptype.h:662:51: error: unknown type name 'size_t'
[...]
Fixes: 288541c8ff9e ("mbuf: add
Exported headers must allow compilation with the strictest flags. This
commit addresses the following errors:
In file included from /tmp/check-includes.sh.20132.c:1:0:
build/include/rte_vhost.h:73:30: error: ISO C forbids zero-size array
'regions' [-Werror=pedantic]
[...]
Also:
- Add C++
This commit addresses the following errors:
In file included from /tmp/check-includes.sh.18889.c:1:0:
build/include/rte_net_crc.h:86:1: error: unknown type name 'uint32_t'
[...]
Fixes: 986ff526fb84 ("net: add CRC computation API")
Cc: Jasvinder Singh
Signed-off-by: Adrien Mazarguil
---
lib
This commit addresses the following errors:
In file included from build/include/rte_latencystats.h:43:0,
from /tmp/check-includes.sh.6580.c:1:
build/include/rte_metrics.h:91:2: error: unknown type name 'uint16_t'
[...]
In file included from /tmp/check-includes.sh.6580.c:1:0:
Exported headers must allow compilation with the strictest flags. This
commit addresses the following errors:
In file included from build/include/rte_eventdev_pmd.h:55:0,
from /tmp/check-includes.sh.25816.c:1:
build/include/rte_eventdev.h:908:8: error: struct has no named membe
This commit addresses the following compilation errors:
In file included from build/include/rte_cryptodev_scheduler.h:37:0,
from /tmp/check-includes.sh.5355.c:1:
build/include/rte_cryptodev_scheduler_operations.h:43:30: error: unknown
type name 'uint8_t' struct rte_cryptode
This series addresses the remaining issues seen by check-includes.sh in
exported headers. Most of them may cause compilation errors in user
applications:
- Dependencies on missing includes.
- Non-standard C/C++ constructs usage without associated safeties.
- Missing C++ awareness blocks.
It also
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, April 24, 2017 1:41 PM
> To: Kozak, KubaX
> Cc: dev@dpdk.org; Olivier Matz ; Van Haaren, Harry
> ; Jain, Deepak K ;
> Piasecki, JacekX
> Subject: Re: [dpdk-dev] [PATCH v6 0/5] Exten
Hi everyone,
The release 17.05 will be closed in less than 2 weeks.
It is the good time to check why some patches are still pending.
Some wait for more inputs, others need to be reviewed.
Even worse, some patches are pending for several releases now.
You probably can help. One URL:
http://
Hi,
02/03/2017 14:05, Andrew Rybchenko:
> From: Roman Zhukov
>
> Check that numbers of Rx and Tx descriptors satisfy descriptors limits
> from the Ethernet device information, otherwise adjust them to boundaries.
>
> Signed-off-by: Roman Zhukov
> Signed-off-by: Andrew Rybchenko
I think this
Hey Thomas,
On 21.04.2017 00:25, Thomas Monjalon wrote:
The hardware is different, there is not much we can do about it.
We can return an error if the max_rx_pkt_len cannot be set in the NIC.
Yes, we pass the value to the PMD, which might check the value and
return an error.
>> Neverthele
24/04/2017 14:44, Olivier Matz:
> Signed-off-by: Olivier Matz
Applied, thanks
Vector PMD does not support i686, it should not be compiled.
Fixes: a6ce64a97520 ("fm10k: introduce vector driver")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
drivers/net/fm10k/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/fm10k/Makefile b/drivers/net/fm10k/Mak
Vector PMD does not support i686, so do not compile it.
Fixes: 429c6d86b371 ("ixgbe: prepare for vector pmd")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
drivers/net/ixgbe/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/i
Vector PMD does not support i686, it should not be compiled
Fixes: 8e109464c02292 ("i40e: allow vector Rx and Tx usage")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
drivers/net/i40e/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/Makefile b/driv
Vector PMD does not support i686, it should not be compiled with i686 arch.
Though there is no compile error and sometimes it does works, but it is not
designed for i686 orignally.
We saw some test failed when vPMD is invovled on i686, so it is necessary to
fix.
Qi Zhang (3):
net/i40e: disable v
24/04/2017 15:04, Pablo de Lara:
> From: Bruce Richardson
>
> Fixes following compilation error, using uint64_t type,
> instead of int128_t unnecessarily:
>
> In file included from ./common/lthread.c:82:0:
> ./common/lthread_timer.h: In function ‘_ns_to_clks’:
> ./common/lthread_timer.h:49:20: e
From: Bruce Richardson
Fixes following compilation error, using uint64_t type,
instead of int128_t unnecessarily:
In file included from ./common/lthread.c:82:0:
./common/lthread_timer.h: In function ‘_ns_to_clks’:
./common/lthread_timer.h:49:20: error: expected ‘=’, ‘,’, ‘;’,
‘asm’ or ‘__attrib
Signed-off-by: Olivier Matz
---
lib/librte_ether/rte_ethdev.h | 66 +--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 2c107a853..e0f7ee596 100644
--- a/lib/librte_ether/rt
24/04/2017 14:32, Olivier Matz:
> Hi,
>
> On Thu, 20 Apr 2017 22:31:35 +0200, Thomas Monjalon
wrote:
> > 13/04/2017 16:59, Kuba Kozak:
> > > Extended xstats API in ethdev library to allow grouping of stats
> > > logically
> > > so they can be retrieved per logical grouping managed by the
> > >
21/04/2017 14:22, Jerin Jacob:
> if this flag is advertised by a PMD, Multiple threads can
> invoke rte_eth_tx_burst() concurrently on the same tx queue
> without SW lock. This is an HW feature found in some NICs
> and useful in the following use cases if HW supports it.
Which hardware supports it
The number of mbufs in pools is not consistent depending on the
options passed by the user and the number of ports, especially
in numa mode, when the number of mbuf is specified by the user.
When the user specifies the number of mbuf (per pool), it should
overrides the default value.
- before the
Since
commit 999b2ee0fe45 ("app/testpmd: enable NUMA support by default"),
testpmd is started with numa enabled by default. This highlights a
floating point exception when started with --total-num-mbufs without any
port (division by 0). This bug was already triggered before this commit
if the --no-
Hi,
On Thu, 20 Apr 2017 22:31:35 +0200, Thomas Monjalon wrote:
> 13/04/2017 16:59, Kuba Kozak:
> > Extended xstats API in ethdev library to allow grouping of stats logically
> > so they can be retrieved per logical grouping managed by the application.
> > Changed existing functions rte_eth_xstat
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Monday, April 24, 2017 1:47 AM
<...>
> > nmb = rte_mbuf_raw_alloc(rxq->mp);
> > - if (unlikely(!nmb))
> > + if (unlikely(!nmb)) {
> > + PMD_RX_LOG(DEBUG, "RX m
Hi Wenzhuo,
Port hot-plug would require the DPDK app to
dynamically mange ports and the kernel to support PCI hot-plugging.
When multiple ports are detached/attached (SFP's plugged in/out),
would the DPDK port id's remain same? If not, app needs to handle port
id change for a gi
Check port is stopped before configuring it for QinQ,
with the "vlan set qinq on " command.
The above command sets the hw_vlan_extend flag.
When the port is started it calls the
i40e_rx_vec_dev_conf_condition_check_default function to
decide whether or not to select the vector mode driver
dependin
Hi Wenzhuo,
On Mon, 24 Apr 2017 01:49:38 +, "Lu, Wenzhuo" wrote:
> Hi Olivier,
>
>
> > -Original Message-
> > From: Lu, Wenzhuo
> > Sent: Friday, April 21, 2017 9:18 AM
> > To: Olivier MATZ
> > Cc: dev@dpdk.org
> > Subject: RE: CLI parsing issue
> >
> > Hi Olivier,
> >
> > > ---
Hi Alexey,
> > DPDK tries to allocate all hugepages that are available to find the
> > smallest amount of physically contiguous memory segments to cover the
> > specified memory size. It then releases all those hugepages that it
> > did not need not sure how this is related to orig=1/0 though.
>
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alexey
> Kardashevskiy
> Sent: Thursday, April 20, 2017 8:24 AM
> To: dev@dpdk.org
> Cc: Alexey Kardashevskiy ; j...@zurich.ibm.com;
> Gowrishankar Muthukrishnan
> Subject: [dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver
> pointe
Hi Alejandro,
> I have tested this approach and it works for the single device per group
> case, which is the one I can test by now. But I'm not sure I understood this
> comment about using a old kernel for testing the multiple devices per group
> case. Can you confirm if I understood this corr
This patch demonstrates the usage of GRO library in testpmd. By default,
GRO is turned off. Command, "gro on (port_id)", turns on GRO for the
given port; command, "gro off (port_id)", turns off GRO for the given
port. Note that, current GRO only supports TCP IPv4 packets.
Once the feature is turne
Introduce three new functions to support TCP/IPv4 GRO.
- rte_gro_tcp4_tbl_create: create a TCP/IPv4 hashing table;
- rte_gro_tcp4_reassemble: try to reassemble an incoming TCP/IPv4 packet
with existed TCP/IPv4 packets;
- rte_gro_tcp4_cksum_update: update TCP and IPv4 checksums.
rte_gro_tcp4_re
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains performance
by reassembling small packets into large ones. This patchset is to
support GRO in DPDK. To support GRO, this patch implements a GRO API
framework.
DPDK GRO is
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains performance
by reassembling small packets into large ones. Therefore, we propose to
add GRO support in DPDK.
DPDK GRO is designed as a device ability, which is turned off
24/04/2017 05:39, Zhao1, Wei:
> Hi, yuanhan & thomas
> From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
> > On Fri, Apr 21, 2017 at 11:28:37AM +0200, Thomas Monjalon wrote:
> > > > Maybe I should add some words in doc\guides\nics\i40e.rst to Record
> > > > which configurations are saved and
Hi Srini,
> -Original Message-
> From: Srinivasan J [mailto:srinid...@gmail.com]
> Sent: Monday, April 24, 2017 2:24 PM
> To: Lu, Wenzhuo
> Cc: Ananyev, Konstantin; dev@dpdk.org
> Subject: Re: [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+
>
> Hi Wenzhuo,
>
54 matches
Mail list logo
