> -----Original Message----- > From: dev [mailto:[email protected]] On Behalf Of Thomas Monjalon > Sent: Monday, April 24, 2017 1:41 PM > To: Kozak, KubaX <[email protected]> > Cc: [email protected]; Olivier Matz <[email protected]>; Van Haaren, Harry > <[email protected]>; Jain, Deepak K <[email protected]>; > Piasecki, JacekX <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v6 0/5] Extended xstats API in ethdev > library to allow grouping of stats > > 24/04/2017 14:32, Olivier Matz: > > Hi, > > > ... > > So, I wonder if it wouldn't be more simple to keep the old API intact > > (it would avoid unannounced breakage). The new feature can be > > implemented in an additional API: > > > > rte_eth_xstats_get_by_id(uint8_t port_id, const uint64_t *ids, > > uint64_t *values, unsigned int size) > > rte_eth_xstats_get_names_by_id(uint8_t port_id, const uint64_t *ids, > > struct rte_eth_xstat_name *xstats_names, unsigned int size) > > > > Or: > > > > rte_eth_xstats_get_by_id(uint8_t port_id, const uint64_t *ids, > > struct rte_eth_xstat *values, unsigned int size) > > rte_eth_xstats_get_names_by_id(uint8_t port_id, const uint64_t *ids, > > struct rte_eth_xstat_name *xstats_names, unsigned int size) > > > > (which would allow to deprecate the old API, but I'm not sure > > we need to) > > > > > > Can we fix that for 17.05? > > ... > > Back to the issues, please try to fix it quickly or we should revert it > for 17.05-rc3.
Hi, We'll submit a patch to change the APIs for rte_eth_xstats_get() and rte_eth_xstats_get_names() back to their previous signature, without symbol versions, and add the APIs suggested by Olivier. We'll work on that as soon as possible. John
