Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-18 Thread Gopakumar Choorakkot Edakkunni
I ended up implementing a mechanism to do the equivalent of a vtpci_reset() as soon as the dpdk-app dies and just before it comes back up. I am "hoping" that is sufficient to let the host know that the virtio rings etc.. are unconfigured, so that when the dpdk app comes up again in guest and does h

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-18 Thread Gopakumar Choorakkot Edakkunni
I mean vtpci_reset is called from rte_eal_pci_probe() which is the *last* thing in rte_eal_init(), *after* hugepage init, so if I can somehow get that done *before* hugepage init maybe all will be well (because I cant do anything to fix the host side) Rgds, Gopa. On Sat, Mar 18, 2017 at 2:32 PM,

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-18 Thread Gopakumar Choorakkot Edakkunni
Hi Yuan, As a "hack"/"workaround", in rte_eal_init(), if I can call vtpci_reset() just before rte_eal_memory_init(), that should take care of the problem of host zeroing out hugepages right ? As of today vtpci_reset() is called in rte_eal_dev_init() which comes *after* rte_eal_memory_init() Rgds,

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-18 Thread Neil Horman
On Fri, Mar 17, 2017 at 11:56:21AM +0100, Gaëtan Rivet wrote: > On Thu, Mar 16, 2017 at 04:50:43PM -0400, Neil Horman wrote: > > On Wed, Mar 15, 2017 at 03:25:37PM +0100, Gaëtan Rivet wrote: > > > On Wed, Mar 15, 2017 at 12:15:56PM +0100, Thomas Monjalon wrote: > > > > 2017-03-15 03:28, Bruce Richa

Re: [dpdk-dev] ip_pipeline firewall port range filtering

2017-03-18 Thread Shyam Shrivastav
I took older versions dpdk-stable-16.07.2 & dpdk-16.04(almost one year old), went through code changes in relevant libraries librte_table(acl part only) and librte_acl, looks like no changes to acl compilation and matching part since then. Has anyone got specific port filtering working with ACLs?

Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset for VF

2017-03-18 Thread Vincent Jardin
Le 18 mars 2017 00:03:08 Thomas Monjalon a écrit : 2017-03-17 21:14, Vincent Jardin: Please, can you bring it to the next tech board? This dispersion of VF/PF make the DPDK unusable into open products with many parties since behavior becomes VF/PF specific. Already requested earlier in thi

Re: [dpdk-dev] [PATCH 00/61] net/qede/base: qede PMD enhancements

2017-03-18 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, March 03, 2017 2:25 AM > > On 2/27/2017 7:56 AM, Rasesh Mody wrote: > > Hi, > > > > This patch set adds support for new firmware 8.18.9.0, new features > > and bug fixes. > > This looks like depends other qede driver patchset [1

[dpdk-dev] [PATCH v2 54/61] net/qede/base: add udp ports in bulletin board message

2017-03-18 Thread Rasesh Mody
Add udp ports in bulletin board message. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_iov_api.h |2 ++ drivers/net/qede/base/ecore_sriov.c | 33 + drivers/net/qede/base/ecore_vf.c | 12 drivers/net/qede/base/ecore_vf_api.h

[dpdk-dev] [PATCH v2 48/61] net/qede/base: set max values for soft resoruces

2017-03-18 Thread Rasesh Mody
Add support for the new interface with the Management FW for setting max values of "soft" resoruces. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |2 + drivers/net/qede/base/ecore_dev.c | 282 ++-- drivers/net/qede/base/ecore_mcp.c | 287

[dpdk-dev] [PATCH v2 60/61] net/qede: add ntuple and flow director filter support

2017-03-18 Thread Rasesh Mody
From: Harish Patil Add limited support for ntuple filter and flow director configuration. The filtering is based on 4-tuples viz src-ip, dst-ip, src-port, dst-port. The mask fields, tcp_flags, flex masks, priority fields, Rx queue drop etc are not supported. Signed-off-by: Harish Patil --- doc

[dpdk-dev] [PATCH v2 57/61] net/qede/base: prevent race condition during unload

2017-03-18 Thread Rasesh Mody
Merge hw_stop and hw_reset into one function. Prevent race condition between MFW attentions and pf stop command during unload flow that causes an ASSERT. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |1 + drivers/net/qede/base/ecore_dev.c | 175 --

[dpdk-dev] [PATCH v2 39/61] net/qede/base: use L2-handles for RSS configuration

2017-03-18 Thread Rasesh Mody
Move RSS configuration into using L2-handles instead of queue-ids. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_l2.c | 48 ++--- drivers/net/qede/base/ecore_l2.h |2 ++ drivers/net/qede/base/ecore_l2_api.h |4 ++- drivers/net/qede/base/ecore_sr

[dpdk-dev] [PATCH v2 51/61] net/qede/base: move code bits

2017-03-18 Thread Rasesh Mody
Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_vf.h | 41 +++--- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/net/qede/base/ecore_vf.h b/drivers/net/qede/base/ecore_vf.h index 228bbf0..f471388 100644 --- a/drivers/net/qede/b

[dpdk-dev] [PATCH v2 45/61] net/qede/base: add macro got resource value message

2017-03-18 Thread Rasesh Mody
Add macro got resource value message Signed-off-by: Rasesh Mody --- drivers/net/qede/base/mcp_public.h |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/mcp_public.h b/drivers/net/qede/base/mcp_public.h index 7f94ba1..6f0e2f9 100644 --- a/drivers/

[dpdk-dev] [PATCH v2 27/61] net/qede/base: make L2 queues handle based

2017-03-18 Thread Rasesh Mody
L2 handler changes: This is change to remove the queue-id/qzone difference for Tx queues. It does that by mainly doing: a. VFs queues are no longer determined by the SBs they're using. Instead, the ecore-client needs to maintain those and choose the values to be used by VF when initializing it.

[dpdk-dev] [PATCH v2 36/61] net/qede/base: add API for using MFW resource lock

2017-03-18 Thread Rasesh Mody
Add base driver API for using the Management FW resource lock Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |9 +++ drivers/net/qede/base/ecore_dcbx.h |3 - drivers/net/qede/base/ecore_mcp.c | 143 drivers/net/qede/base/ecore_mcp

[dpdk-dev] [PATCH v2 42/61] net/qede/base: add non-L2 dcbx tlv application support

2017-03-18 Thread Rasesh Mody
Add non-l2 dcbx tlv application support. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c | 30 ++ drivers/net/qede/base/ecore_dcbx.h |1 + drivers/net/qede/base/ecore_dcbx_api.h |4 +++- drivers/net/qede/base/ecore_proto_if.h |3

[dpdk-dev] [PATCH v2 33/61] net/qede/base: formatting changes

2017-03-18 Thread Rasesh Mody
Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 14 +-- drivers/net/qede/base/mcp_public.h | 176 ++-- 2 files changed, 96 insertions(+), 94 deletions(-) diff --git a/drivers/net/qede/base/ecore.h b/drivers/net/qede/base/ecore.h index f86f7c

[dpdk-dev] [PATCH v2 30/61] net/qede/base: infrastructure changes for VF tunnelling

2017-03-18 Thread Rasesh Mody
Infrastructure changes for VF tunnelling. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |3 +- drivers/net/qede/base/ecore.h | 14 - drivers/net/qede/base/ecore_sp_commands.c | 87 +++-- drivers/net/qede/qede_if.h

[dpdk-dev] [PATCH v2 16/61] net/qede/base: read card personality via MFW commands

2017-03-18 Thread Rasesh Mody
Add support to read NIC personality via management FW for non-L2 protocols. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 16 +- drivers/net/qede/base/ecore_dev.c | 17 +-- drivers/net/qede/base/ecore_mcp.c | 41 +++

[dpdk-dev] [PATCH v2 13/61] net/qede/base: change queue/sb-id from 8 bit to 16 bit

2017-03-18 Thread Rasesh Mody
Change the queue/sb-id values from 8 bit fields to 16 bit fields. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |8 drivers/net/qede/base/ecore_dev_api.h |4 ++-- drivers/net/qede/base/ecore_l2.c |2 +- drivers/net/qede/base/ecore_l2_api.h |2

[dpdk-dev] [PATCH v2 19/61] net/qede/base: allow only trusted VFs to be promisc

2017-03-18 Thread Rasesh Mody
Allow only trusted VFs to be promisc/multi-promisc. The reasonable thing is to use the 'trusted' node instead of simply allowing VFs to become promiscuous. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_l2.c|8 drivers/net/qede/base/ecore_sriov.c |2 -- 2 files c

[dpdk-dev] [PATCH v2 24/61] net/qede/base: prevent driver laod with invalid resources

2017-03-18 Thread Rasesh Mody
Prevent storage drivers from attempting to load with invalid resources. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index

[dpdk-dev] [PATCH v2 10/61] net/qede/base: add nvram options

2017-03-18 Thread Rasesh Mody
Add a bunch of NVRAM options like MCOT, FEC selection, temperature threshold, Reset On Lan, etc. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/nvm_cfg.h | 465 ++- 1 file changed, 461 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/nv

[dpdk-dev] [PATCH v2 08/61] net/qede/base: move mask constants defining NIC type

2017-03-18 Thread Rasesh Mody
Move mask constants defining NIC type to ecore.h Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |4 drivers/net/qede/base/ecore_dev.c |4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore.h b/drivers/net/qede/base/ecore

[dpdk-dev] [PATCH v2 59/61] net/qede/base: add support for arfs mode

2017-03-18 Thread Rasesh Mody
From: Harish Patil Add base driver APIs to enable accelerated RFS[aRFS] mode and ramrod to configure rfs and ntuple filter. Signed-off-by: Harish Patil --- drivers/net/qede/base/ecore_cxt.c | 49 +++- drivers/net/qede/base/ecore_init_fw_funcs.c | 31 ++ driver

[dpdk-dev] [PATCH v2 49/61] net/qede/base: add return code check

2017-03-18 Thread Rasesh Mody
Add a check of the return code of ecore_mcp_cmd_and_union() in ecore_mcp_send_protocol_stats() Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ec

[dpdk-dev] [PATCH v2 61/61] net/qede: add LRO/TSO offloads support

2017-03-18 Thread Rasesh Mody
From: Harish Patil This patch includes slowpath configuration and fastpath changes to support LRO and TSO. A bit of revamping is needed in order to make use of existing packet classification schemes in Rx fastpath and for SG element processing in Tx. Signed-off-by: Harish Patil --- doc/guides/

[dpdk-dev] [PATCH v2 58/61] net/qede/base: semantic changes

2017-03-18 Thread Rasesh Mody
Make APIs static and other semantic changes. A step toward cleaning 'make C=1' with GCC 4.8.3. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_cxt.c |5 +- drivers/net/qede/base/ecore_cxt.h | 11 drivers/net/qede/base/ecore_dcbx.c |2 +- drivers/net/qede/base/ecore_de

[dpdk-dev] [PATCH v2 55/61] net/qede/base: prevent DMAE transactions during recovery

2017-03-18 Thread Rasesh Mody
Prevent DMA engine transactions during recovery phase. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_hw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/qede/base/ecore_hw.c b/drivers/net/qede/base/ecore_hw.c index 396edc2..280925f 100644 --- a/driver

[dpdk-dev] [PATCH v2 56/61] net/qede/base: multi-Txq support on same queue-zone for VFs

2017-03-18 Thread Rasesh Mody
A step toward having multi-Txq support on same queue-zone for VFs. This change takes care of: - VFs assume a single CID per-queue, where queue X receives CID X. Switch to a model similar to that of PF - I.e., Use different CIDs for Rx/Tx, and use mapping to acquire/release those. Each VF

[dpdk-dev] [PATCH v2 50/61] net/qede/base: zero out MFW mailbox data

2017-03-18 Thread Rasesh Mody
Zero the whole union data of the Management FW mailbox before copying the actual union member Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |4 +- drivers/net/qede/base/ecore_mcp.c | 296 - drivers/net/qede/base/ecore_mcp.h | 19 ++-

[dpdk-dev] [PATCH v2 52/61] net/qede/base: add PF parameter

2017-03-18 Thread Rasesh Mody
Add a common enum to pf_params for RDMA. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_cxt.c |1 + drivers/net/qede/base/ecore_proto_if.h |7 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/qede/base/ecore_cxt.c b/drivers/net/qede/base/ecore_cxt.c in

[dpdk-dev] [PATCH v2 53/61] net/qede/base: allow PMD to control vport and RSS engine ids

2017-03-18 Thread Rasesh Mody
Let PMD have control over the vport-id and rss-eng-id of a given VF during initializaion. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_iov_api.h | 15 --- drivers/net/qede/base/ecore_sriov.c | 46 + drivers/net/qede/base/ecore_sriov.h

[dpdk-dev] [PATCH v2 46/61] net/qede/base: add mailbox for resource allocation

2017-03-18 Thread Rasesh Mody
Add the Management FW mailbox for getting non-l2 resource allocation information. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |1 + drivers/net/qede/base/ecore_dev.c | 60 drivers/net/qede/base/mcp_public.h |1 + 3 files chang

[dpdk-dev] [PATCH v2 47/61] net/qede/base: add macro for unsupported command

2017-03-18 Thread Rasesh Mody
Add a macro for upsupported management FW command Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c |6 ++ drivers/net/qede/base/mcp_public.h |1 + 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/bas

[dpdk-dev] [PATCH v2 43/61] net/qede/base: update bulletin board during VF init

2017-03-18 Thread Rasesh Mody
Updated bulletin board with link state during VF initialization. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sriov.c | 88 --- 1 file changed, 51 insertions(+), 37 deletions(-) diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/

[dpdk-dev] [PATCH v2 44/61] net/qede/base: add coalescing support for VFs

2017-03-18 Thread Rasesh Mody
Add coalescing support for VFs. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 83 ++--- drivers/net/qede/base/ecore_dev_api.h | 43 ++--- drivers/net/qede/base/ecore_sriov.c | 66 +- drivers/net/qede

[dpdk-dev] [PATCH v2 41/61] net/qede/base: add support for previous driver unload

2017-03-18 Thread Rasesh Mody
New driver/management fw load request sequence for handling previous driver unload. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 13 ++ drivers/net/qede/base/ecore_dev.c | 43 ++-- drivers/net/qede/base/ecore_dev_api.h | 30 ++- drivers/net/qede/base/ecore_mcp

[dpdk-dev] [PATCH v2 40/61] net/qede/base: change valloc to vzalloc

2017-03-18 Thread Rasesh Mody
Change OSAL_VALLOC() into OSAL_VZALLOC() which would also zero memory. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |2 +- drivers/net/qede/base/ecore_dev.c |3 +-- drivers/net/qede/base/ecore_l2.c |3 +-- drivers/net/qede/base/ecore_mng_tlv.c |5

[dpdk-dev] [PATCH v2 37/61] net/qede/base: remove clock slowdown option

2017-03-18 Thread Rasesh Mody
Remove clock slowdown NVM config option as this is not supported for current chipsets. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/nvm_cfg.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/nvm_cfg.h b/drivers/net/qede/base/nvm_cfg.h

[dpdk-dev] [PATCH v2 38/61] net/qede/base: add new image types

2017-03-18 Thread Rasesh Mody
Add new image types - RECOVERY and PK (Public Key) towards the second phase of NVRAM security support. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/mcp_public.h |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/qede/base/mcp_public.h b/drivers/net/qede/base/mcp_pub

[dpdk-dev] [PATCH v2 34/61] net/qede/base: prevent transmitter stuck condition

2017-03-18 Thread Rasesh Mody
Change OOO TC properly to prevent transmitter stuck condition due to credit underruns. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |4 +--- drivers/net/qede/base/ecore_dcbx.c |6 ++ drivers/net/qede/base/ecore_dev.c | 19 ++- drivers/net/qede/

[dpdk-dev] [PATCH v2 35/61] net/qede/base: add mask/shift defines for resource command

2017-03-18 Thread Rasesh Mody
Add several mask/shift defines for the resource command Signed-off-by: Rasesh Mody --- drivers/net/qede/base/mcp_public.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/qede/base/mcp_public.h b/drivers/net/qede/base/mcp_public.h index bd34557..1b1ecd2 100644

[dpdk-dev] [PATCH v2 32/61] net/qede/base: add tunnelling support for VFs

2017-03-18 Thread Rasesh Mody
Add new tunnelling support for VFs. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |3 +- drivers/net/qede/base/ecore_dev.c | 15 ++- drivers/net/qede/base/ecore_sp_commands.c | 15 ++- drivers/net/qede/base/ecore_sriov.c | 144 +++

[dpdk-dev] [PATCH v2 28/61] net/qede/base: add support for handling TLV request from MFW

2017-03-18 Thread Rasesh Mody
Add support for handling the TLV request from Management FW. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |3 + drivers/net/qede/base/ecore_mcp.c |6 - drivers/net/qede/base/ecore_mcp.h |8 + drivers/net/qede/base/ecore_mcp_api.h | 44 +- drivers/net

[dpdk-dev] [PATCH v2 29/61] net/qede/base: optimize cache-line access

2017-03-18 Thread Rasesh Mody
Optimize cache-line access in ecore_chain - re-arrange fields so that fields that are needed for fastpath [mostly produce/consume and their derivatives] are in the first cache line, and the rest are in the second. This is true for both PBL and NEXT_PTR kind of chains. Advancing a page in a SINGLE_

[dpdk-dev] [PATCH v2 31/61] net/qede/base: revise tunnel APIs/structs

2017-03-18 Thread Rasesh Mody
Revise tunnel APIs/structs. - Unite tunnel start and update params in single struct "ecore_tunnel_info" - Remove A0 chip tunnelling support. - Added per tunnel info - removed bitmasks. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 57 ++--- drivers/net/qede/b

[dpdk-dev] [PATCH v2 26/61] net/qede/base: code refactoring of SP queues

2017-03-18 Thread Rasesh Mody
Maintain slowpath event queue and consumer queue within HW function structure, update corresponding alloc and free APIs accordingly. Cleanup unused code under CONFIG_ECORE_LL2 ifdef. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 43 +++-- drivers/ne

[dpdk-dev] [PATCH v2 25/61] net/qede/base: add interfaces for MFW TLV request processing

2017-03-18 Thread Rasesh Mody
Add new base driver interfaces for Management FW TLV request processing. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c |6 + drivers/net/qede/base/ecore_mcp_api.h | 301 + 2 files changed, 307 insertions(+) diff --git a/drivers/net/qed

[dpdk-dev] [PATCH v2 23/61] net/qede/base: set driver type before sending load request

2017-03-18 Thread Rasesh Mody
Set the drv_type before sending LOAD_REQ and remove the ver_str which is not used by the MFW Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |3 +-- drivers/net/qede/base/ecore_mcp.c |3 --- drivers/net/qede/qede_ethdev.c|2 +- drivers/net/qede/qede_if.h|

[dpdk-dev] [PATCH v2 22/61] net/qede/base: check active VF queues before stopping

2017-03-18 Thread Rasesh Mody
Make sure VF queue are closed before stopping vport. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sriov.c | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sri

[dpdk-dev] [PATCH v2 17/61] net/qede/base: allow probe to succeed with minor HW-issues

2017-03-18 Thread Rasesh Mody
Allow probe to succeed with various 'minor' HW-issues [if requested] Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 71 +++-- drivers/net/qede/base/ecore_dev_api.h | 40 --- 2 files changed, 94 insertions(+), 17 deletions(-)

[dpdk-dev] [PATCH v2 21/61] net/qede/base: print firmware MFW and MBI versions

2017-03-18 Thread Rasesh Mody
Add a printout of the FW, Management FW and MBI versions. Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_if.h |9 - drivers/net/qede/qede_main.c | 14 ++ 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/net/qede/qede_if.h b/drivers/net/qed

[dpdk-dev] [PATCH v2 18/61] net/qede/base: remove unneeded step in HW init

2017-03-18 Thread Rasesh Mody
There is no need to close the OUT_EN NIG registers, so remove that. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index 907566c..e2d4132 10

[dpdk-dev] [PATCH v2 20/61] net/qede/base: qm initialization revamp

2017-03-18 Thread Rasesh Mody
This patch revamps queue initialization. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h|2 + drivers/net/qede/base/ecore.h | 34 +- drivers/net/qede/base/ecore_cxt.c | 14 +- drivers/net/qede/base/ecore_dev.c | 869 --- driv

[dpdk-dev] [PATCH v2 15/61] net/qede/base: prevent device init failure

2017-03-18 Thread Rasesh Mody
Device initialization flow should not be failed because the FW interface command is not available. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/ne

[dpdk-dev] [PATCH v2 14/61] net/qede/base: update MFW when default MTU is changed

2017-03-18 Thread Rasesh Mody
Send mailbox command to Management FW when MTU changes. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 11 +++ drivers/net/qede/base/ecore_mcp.c |3 --- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/

[dpdk-dev] [PATCH v2 12/61] net/qede/base: use default MTU from shared memory

2017-03-18 Thread Rasesh Mody
Read and use the default MTU value from shared-memory. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |2 ++ drivers/net/qede/base/ecore_dev.c |3 +++ drivers/net/qede/base/ecore_mcp.c | 10 ++ drivers/net/qede/base/ecore_mcp_api.h |2 ++ drive

[dpdk-dev] [PATCH v2 11/61] net/qede/base: add comment

2017-03-18 Thread Rasesh Mody
Add a comment for the endianness manipulation in ecore_mcp_send_drv_version(). Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c index 245d478..df6ebd2 100

[dpdk-dev] [PATCH v2 03/61] net/qede/base: mask Rx buffer attention bits

2017-03-18 Thread Rasesh Mody
Mask the BRB "RC0_EOP_OUT_SYNC_FIFO_PUSH_ERROR" attention. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |6 ++ drivers/net/qede/base/reg_addr.h |3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore

[dpdk-dev] [PATCH v2 09/61] net/qede/base: remove attribute from update current config

2017-03-18 Thread Rasesh Mody
Remove attribute field from update_current_config() API, Management FW need to know only the last entity who configured the device. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c |5 ++--- drivers/net/qede/base/ecore_mcp_api.h |8 2 files changed, 2 inserti

[dpdk-dev] [PATCH v2 07/61] net/qede/base: decrease maximum HW func per device

2017-03-18 Thread Rasesh Mody
Decrease MAX_HWFNS_PER_DEVICE from 4 to 2 Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/base/ecore.h b/drivers/net/qede/base/ecore.h index b2f4910..d14f99c 100644 --- a/drivers/net/qede/base/ec

[dpdk-dev] [PATCH v2 04/61] net/qede/base: print various indication on Tx-timeouts

2017-03-18 Thread Rasesh Mody
Print various indication on Tx-timeouts. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_int.c | 27 +++ drivers/net/qede/base/ecore_int_api.h | 21 + drivers/net/qede/base/reg_addr.h |3 +++ drivers/net/qede/qede_main.c

[dpdk-dev] [PATCH v2 02/61] net/qede/base: send FW version driver state to MFW

2017-03-18 Thread Rasesh Mody
Add support to send FW version and driver state to Management FW. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 31 --- drivers/net/qede/base/ecore_mcp.c |7 +-- drivers/net/qede/base/ecore_mcp_api.h |3 ++- drivers/net/qede/

[dpdk-dev] [PATCH v2 01/61] net/qede/base: return an initialized return value

2017-03-18 Thread Rasesh Mody
Make sure ecore_iov_mark_vf_flr() always returns an initialized return value. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sriov.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sriov.c index

[dpdk-dev] [PATCH v2 00/61] net/qede/base: qede PMD enhancements

2017-03-18 Thread Rasesh Mody
Hi, This patch set adds support for new firmware 8.18.9.0, new features and bug fixes. Please apply to dpdk-net-next for 17.05 release. Note that this patch set depends on http://dpdk.org/dev/patchwork/patch/21896. v1..v2 - address all the review comments received so far Thanks! Rasesh Harish

Re: [dpdk-dev] [PATCH 02/21] net/qede/base: fix to set pointers to NULL after freeing

2017-03-18 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, March 02, 2017 5:05 AM > > On 2/27/2017 7:51 AM, Rasesh Mody wrote: > > Set pointers to NULL after freeing the allocations on ecore_resc_free(). > > > > Fixes: 26ae839d06e9 ("qede: add DCBX support") > > Fixes: ec94dbc57362 ("q

[dpdk-dev] [PATCH v2 20/21] net/qede/base: fix resource lock minimum value

2017-03-18 Thread Rasesh Mody
Fixes: ababb5203de2 ("net/qede/base: semantic/formatting changes") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/mcp_public.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/base/mcp_public.h b/drivers/net/qede/base/mcp_public.h index 308b7fe..969d

[dpdk-dev] [PATCH v2 17/21] net/qede/base: fix typo

2017-03-18 Thread Rasesh Mody
Fixes: 22d07d939c3c ("net/qede/base: update") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/mcp_public.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/base/mcp_public.h b/drivers/net/qede/base/mcp_public.h index 81567d1..308b7fe 100644 --- a/driv

[dpdk-dev] [PATCH v2 21/21] net/qede/base: fix to use NULL pointer

2017-03-18 Thread Rasesh Mody
Use OSAL NULL where appropriate Fixes: 22d07d939c3c ("net/qede/base: update") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c ind