Re: [dpdk-dev] [PATCH 3/5] net/virtio-user: support to report net status

2017-03-16 Thread Yuanhan Liu
On Fri, Mar 03, 2017 at 05:56:41PM +, Jianfeng Tan wrote: > Signed-off-by: Jianfeng Tan Yet again, not a single work on explanation. > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 1 + > drivers/net/virtio/virtio_user_ethdev.c | 13 +++-- > 2 files changed, 8 i

Re: [dpdk-dev] [PATCH 2/5] net/virtio-user: add rxq interrupt mode support

2017-03-16 Thread Yuanhan Liu
On Fri, Mar 03, 2017 at 05:56:40PM +, Jianfeng Tan wrote: > Signed-off-by: Jianfeng Tan I don't see a single word to explain how this patch works :/ > --- > drivers/net/virtio/virtio_ethdev.c | 17 ++-- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 25 > +++

[dpdk-dev] ip_pipeline firewall : fragmented ipv4 packets handling

2017-03-16 Thread Shyam Shrivastav
Again sending this issue as no response on original post. As per my understanding if we are supporting ACL on tcp/usp port ranges then ipv4 packets must be reassembled before checking against ACL, then fragmented if required during forwarding. So there are three cases 1) My understanding is wrong

Re: [dpdk-dev] [PATCH 01/17] vhost: introduce driver features related APIs

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 10:18:21AM +0100, Maxime Coquelin wrote: > > > On 03/16/2017 08:08 AM, Yuanhan Liu wrote: > >On Tue, Mar 14, 2017 at 10:53:23AM +0100, Maxime Coquelin wrote: > >> > >> > >>On 03/14/2017 10:46 AM, Maxime Coquelin wrote: > >>> > >>> > >>>On 03/03/2017 10:51 AM, Yuanhan Liu w

Re: [dpdk-dev] [PATCH 06/17] vhost: introduce API to fetch negotiated features

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 10:22:27AM +0100, Maxime Coquelin wrote: > > > On 03/16/2017 08:35 AM, Yuanhan Liu wrote: > >On Tue, Mar 14, 2017 at 12:02:59PM +0100, Maxime Coquelin wrote: > >>>+uint64_t > >>>+rte_vhost_get_negotiated_features(int vid) > >>>+{ > >>>+ struct virtio_net *dev; > >>>+ > >>

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Gopakumar Choorakkot Edakkunni
Thanks again Yuanhan, you are the true expert!! Rgds, Gopa. On Thu, Mar 16, 2017 at 10:40 PM, Yuanhan Liu wrote: > On Thu, Mar 16, 2017 at 10:30:09PM -0700, Gopakumar Choorakkot Edakkunni > wrote: > > Thanks for the confirmation, glad I reached the person who knows the > nuts and > > bolts of v

Re: [dpdk-dev] [PATCH 03/17] vhost: use new APIs to handle features

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 10:39:00AM +0100, Maxime Coquelin wrote: > > > On 03/16/2017 08:43 AM, Yuanhan Liu wrote: > >On Tue, Mar 14, 2017 at 11:43:44AM +0100, Maxime Coquelin wrote: > >>>diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > >>>index 8433a54..f7227bf 100644

Re: [dpdk-dev] [PATCH] vhost: fix virtio_net cache sharing of broadcast_rarp

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 10:10:05AM +, Kevin Traynor wrote: > On 03/16/2017 06:21 AM, Yuanhan Liu wrote: > > On Wed, Mar 15, 2017 at 07:10:49PM +, Kevin Traynor wrote: > >> The virtio_net structure is used in both enqueue and dequeue datapaths. > >> broadcast_rarp is checked with cmpset in t

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 10:30:09PM -0700, Gopakumar Choorakkot Edakkunni wrote: > Thanks for the confirmation, glad I reached the person who knows the nuts and > bolts of virtio :-). So if the host is not in our control (ie if I am just > running as a VM on host provided by thirdparty vendor), is t

Re: [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 12:37:23PM +0100, Maxime Coquelin wrote: > > > On 03/16/2017 09:00 AM, Yuanhan Liu wrote: > >On Sun, Mar 12, 2017 at 05:34:01PM +0100, Maxime Coquelin wrote: > >>This patch implements the function for the application to > >>get the MTU value. > > > >I'm thinking the other

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Gopakumar Choorakkot Edakkunni
Thanks for the confirmation, glad I reached the person who knows the nuts and bolts of virtio :-). So if the host is not in our control (ie if I am just running as a VM on host provided by thirdparty vendor), is there any workaround I can do from the guest side to prevent problems from happening on

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 10:20:30PM -0700, Gopakumar Choorakkot Edakkunni wrote: > >> When I was saying dpdk version, I meant the DPDK version with OVS. > > Oh I see! My apologies for the misuderstanding. The dpdk version used by host > ovs should be dpdk2.2, the guest process uses dpdk16.07. The O

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Gopakumar Choorakkot Edakkunni
>> When I was saying dpdk version, I meant the DPDK version with OVS. Oh I see! My apologies for the misuderstanding. The dpdk version used by host ovs should be dpdk2.2, the guest process uses dpdk16.07. The OVS process is not getting restarted, what is getting restarted is the guest process usin

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 09:56:01PM -0700, Gopakumar Choorakkot Edakkunni wrote: > Hi Yuanhan, > > Thanks for the confirmation about not having to do anything special to close > the ports on dpdk going down or coming up. > > As for the question about if I met any issue of ovs getting stuck - yes,

Re: [dpdk-dev] Getting crash in rte_pktmbuf_alloc with 16.11 DPDK

2017-03-16 Thread Yuanhan Liu
On Fri, Mar 17, 2017 at 03:46:53AM +, Dey, Souvik wrote: > Hi , > I am trying to do rte_pktmbuf_alloc from a mempool within a > secondary process after doing a rte_mempool_lookup for the same mempool. But > the rte_pktmbuf_alloc crashes with the below backtrace I believe it's y

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Gopakumar Choorakkot Edakkunni
Hi Yuanhan, Thanks for the confirmation about not having to do anything special to close the ports on dpdk going down or coming up. As for the question about if I met any issue of ovs getting stuck - yes, my guest process runs dpdk 16.07 as I mentioned earlier - and if I kill my guest process, th

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 07:48:28PM -0700, Gopakumar Choorakkot Edakkunni wrote: > Thanks a lot for the response Yuanhan. I am using dpdk v16.07. So what you are > saying is that in 16.07, we dont really need to call rte_eth_dev_close() on > exit, It's not about "don't really need", it's more like

[dpdk-dev] Getting crash in rte_pktmbuf_alloc with 16.11 DPDK

2017-03-16 Thread Dey, Souvik
Hi , I am trying to do rte_pktmbuf_alloc from a mempool within a secondary process after doing a rte_mempool_lookup for the same mempool. But the rte_pktmbuf_alloc crashes with the below backtrace #0 0x in ?? () #1 0x00423da2 in rte_mempool_ops_dequeue_bul

Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset for VF

2017-03-16 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, March 17, 2017 12:04 AM > To: Zhang, Qi Z; techbo...@dpdk.org > Cc: dev@dpdk.org; Wu, Jingjing; Zhang, Helin; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset fo

[dpdk-dev] Getting crash in rte_pktmbuf_alloc with 16.11 DPDK

2017-03-16 Thread Dey, Souvik
Hi , I am trying to do rte_pktmbuf_alloc from a mempool within a secondary process after doing a rte_mempool_lookup for the same mempool. But the rte_pktmbuf_alloc crashes with the below backtrace #0 0x in ?? () #1 0x00423da2 in rte_mempool_ops_dequeue_bul

Re: [dpdk-dev] [PATCH v3] eventdev: add errno-style return values

2017-03-16 Thread Jerin Jacob
On Thu, Mar 16, 2017 at 03:12:19PM -0500, Gage Eads wrote: > This commit adds rte_errno return values to rte_event_enqueue_burst() and > rte_event_dequeue_burst(). > > These return values allows user software to differentiate between an > invalid argument (such as an invalid queue_id or sched_type

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Gopakumar Choorakkot Edakkunni
Thanks a lot for the response Yuanhan. I am using dpdk v16.07. So what you are saying is that in 16.07, we dont really need to call rte_eth_dev_close() on exit, because dpdk will ensure that it will do virtio reset before init when it comes up right ? Regarding the vhost commits you mentioned - do

Re: [dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 12:39:16PM -0700, Gopakumar Choorakkot Edakkunni wrote: > So the doc says we should call rte_eth_dev_close() *before* going down. And I > know that especially in dpdk-virtionet  in the guest + ovs-dpdk in the host, > the ovs ends up getting stalled/stuck (!!) if I dont close

Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset for VF

2017-03-16 Thread Zhang, Qi Z
Hi Thomas: > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, March 17, 2017 12:04 AM > To: Zhang, Qi Z ; techbo...@dpdk.org > Cc: dev@dpdk.org; Wu, Jingjing ; Zhang, Helin > ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] net/i40e:

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back

2017-03-16 Thread Wiles, Keith
> On Mar 17, 2017, at 8:31 AM, Vincent JARDIN wrote: > > Le 17/03/2017 à 01:11, Wiles, Keith a écrit : >> it seems like some other hidden agenda is at play here, but I am a paranoid >> person :-) > > Keith, please stop such invalid argument! It is non sense. > > We need to understand the bene

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back

2017-03-16 Thread Vincent JARDIN
Le 17/03/2017 à 01:11, Wiles, Keith a écrit : it seems like some other hidden agenda is at play here, but I am a paranoid person :-) Keith, please stop such invalid argument! It is non sense. We need to understand the benefits of diverging from virtio since here it is about creating new devi

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back

2017-03-16 Thread O'Driscoll, Tim
> From: Wiles, Keith > > > > On Mar 17, 2017, at 7:41 AM, Vincent JARDIN > wrote: > > > > Let's be back to 2014 with Qemu's thoughts on it, > > +Stefan > > https://lists.linuxfoundation.org/pipermail/virtualization/2014- > June/026767.html > > > > and > > +Markus > > https://lists.linuxfoundatio

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back

2017-03-16 Thread Stephen Hemminger
On Fri, 17 Mar 2017 00:11:10 + "Wiles, Keith" wrote: > > On Mar 17, 2017, at 7:41 AM, Vincent JARDIN > > wrote: > > > > Let's be back to 2014 with Qemu's thoughts on it, > > +Stefan > > https://lists.linuxfoundation.org/pipermail/virtualization/2014-June/026767.html > > > > and > > +Marku

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back

2017-03-16 Thread Wiles, Keith
> On Mar 17, 2017, at 7:41 AM, Vincent JARDIN wrote: > > Let's be back to 2014 with Qemu's thoughts on it, > +Stefan > https://lists.linuxfoundation.org/pipermail/virtualization/2014-June/026767.html > > and > +Markus > https://lists.linuxfoundation.org/pipermail/virtualization/2014-June/026713

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back

2017-03-16 Thread Wiles, Keith
> On Mar 17, 2017, at 7:41 AM, Vincent JARDIN wrote: > > Let's be back to 2014 with Qemu's thoughts on it, > +Stefan > https://lists.linuxfoundation.org/pipermail/virtualization/2014-June/026767.html > > and > +Markus > https://lists.linuxfoundation.org/pipermail/virtualization/2014-June/026713

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back

2017-03-16 Thread Vincent JARDIN
Let's be back to 2014 with Qemu's thoughts on it, +Stefan https://lists.linuxfoundation.org/pipermail/virtualization/2014-June/026767.html and +Markus https://lists.linuxfoundation.org/pipermail/virtualization/2014-June/026713.html 6. Device models belong into QEMU Say you build an actual

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-16 Thread Stephen Hemminger
On Wed, 15 Mar 2017 04:10:56 + "O'Driscoll, Tim" wrote: > I've included a couple of specific comments inline below, and a general > comment here. > > We have somebody proposing to add a new driver to DPDK. It's standalone and > doesn't affect any of the core libraries. They're willing to m

[dpdk-dev] [PATCH 3/3] net/mlx5: rebuild flows on updating RETA

2017-03-16 Thread Yongseok Koh
Currently mlx5_dev_rss_reta_update() just updates tables in the host, therefore it isn't immediately effective until restarting the device by calling mlx5_dev_stop()/mlx5_dev_start() to update the changes in the device side. This patch adds rebuilding the device-specific datastructure and applying

[dpdk-dev] [PATCH 1/3] lib/librte_ether: remove requirement of aligned RETA size

2017-03-16 Thread Yongseok Koh
In rte_eth_check_reta_mask(), it is required to align the size of the RETA table to RTE_RETA_GROUP_SIZE but as the size can be less than the limit, this should be removed. The change is also applied to a command of testpmd. Signed-off-by: Yongseok Koh --- app/test-pmd/cmdline.c| 4 +++-

[dpdk-dev] [PATCH 2/3] net/mlx5: use correct RETA table size

2017-03-16 Thread Yongseok Koh
When querying and updating RSS RETA table, it always uses the max size of the device instead of configured value. This patch fixes it and removed the related comments in the code. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 8 ++-- drivers/net/mlx5/mlx5_rss.c| 13 ++

[dpdk-dev] [PATCH 0/3] net/mlx5: fix updating RETA

2017-03-16 Thread Yongseok Koh
Currently rte_eth_dev_rss_reta_update() doesn't work properly for mlx5 PMD. This patchset fixes the issue. This also enables testing the API with testpmd. Yongseok Koh (3): lib/librte_ether: remove requirement of aligned RETA size net/mlx5: use correct RETA table size net/mlx5: rebuild flows

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-16 Thread Neil Horman
On Wed, Mar 15, 2017 at 03:25:37PM +0100, Gaëtan Rivet wrote: > On Wed, Mar 15, 2017 at 12:15:56PM +0100, Thomas Monjalon wrote: > > 2017-03-15 03:28, Bruce Richardson: > > > On Tue, Mar 14, 2017 at 03:49:47PM +0100, Gaëtan Rivet wrote: > > > > - In the bonding, the init and configuration steps are

[dpdk-dev] [PATCH v3] eventdev: add errno-style return values

2017-03-16 Thread Gage Eads
This commit adds rte_errno return values to rte_event_enqueue_burst() and rte_event_dequeue_burst(). These return values allows user software to differentiate between an invalid argument (such as an invalid queue_id or sched_type in an enqueued event) and backpressure from the event device. The p

[dpdk-dev] virtio "how to restart applications" - //dpdk.org/doc/virtio-net-pmd

2017-03-16 Thread Gopakumar Choorakkot Edakkunni
So the doc says we should call rte_eth_dev_close() *before* going down. And I know that especially in dpdk-virtionet in the guest + ovs-dpdk in the host, the ovs ends up getting stalled/stuck (!!) if I dont close the port before starting() it when the guest dpdk process comes back up. Considering

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Thursday, March 16, 2017 6:11 PM > To: Dumitrescu, Cristian ; Ananyev, > Konstantin > Cc: O'Driscoll, Tim ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hema

Re: [dpdk-dev] [PATCH v2] SDK: Add scripts to initialize DPDK runtime

2017-03-16 Thread Thomas Monjalon
2017-01-12 15:43, Christian Ehrhardt: > On Mon, Dec 19, 2016 at 4:15 PM, Thomas Monjalon > wrote: > > > Thanks for sending your Debian/Ubuntu work. > > > > 2016-12-13 16:47, Luca Boccassi: > > > From: Christian Ehrhardt > > > > > > A tools/init directory is added with dpdk-init, a script that ca

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Thomas Monjalon
2017-03-16 17:40, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-03-16 16:23, Dumitrescu, Cristian: > > > ... > > > > > > > > Thomas, given Tim's confirmation of Intel's plans to implement this > > > > > API > > for > > > > the ixgbe and i40e drivers in

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-16 Thread Francois Ozog
On 16 March 2017 at 11:32, Chas Williams <3ch...@gmail.com> wrote: > > On Thu, 2017-03-16 at 03:18 +, O'Driscoll, Tim wrote: > > > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > > > > > > Le 15/03/2017 à 11:55, Thomas Monjalon a écrit : > > > >> I'd suggest that this is a good topic f

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Thursday, March 16, 2017 5:30 PM > To: Dumitrescu, Cristian > Cc: O'Driscoll, Tim ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > sh

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Thomas Monjalon
2017-03-04 01:10, Cristian Dumitrescu: > This patch introduces the generic ethdev API for the traffic manager > capability, which includes: hierarchical scheduling, traffic shaping, > congestion management, packet marking. > > Main features: > - Exposed as ethdev plugin capability (similar to rte_

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Thomas Monjalon
2017-03-16 16:23, Dumitrescu, Cristian: > ... > > > > Thomas, given Tim's confirmation of Intel's plans to implement this API > > > for > > the ixgbe and i40e drivers in DPDK release 17.8, are you in favour of > > including > > this API in 17.5 with experimental tag (subject to full API agreeme

Re: [dpdk-dev] [PATCH v2] mk: Provide option to set Major ABI version

2017-03-16 Thread Thomas Monjalon
2017-03-01 15:35, Jan Blunck: > On Wed, Mar 1, 2017 at 10:34 AM, Christian Ehrhardt > wrote: > > Downstreams might want to provide different DPDK releases at the same > > time to support multiple consumers of DPDK linked against older and newer > > sonames. > > > > Also due to the interdependencie

Re: [dpdk-dev] FW: Issues with ixgbe and rte_flow

2017-03-16 Thread Le Scouarnec Nicolas
Hi Adrien, >On Wed, Mar 15, 2017 at 02:29:44PM +, Le Scouarnec Nicolas wrote: >> Overall, as a user, I feel one difficulty/complexity in using the API comes >> from the need to >> specify both the stack of protocol (in type) and at each level the "next >> protocol type" of the header (in sp

[dpdk-dev] [PATCH] eal/linux: fix multi-process cannot work

2017-03-16 Thread Jianfeng Tan
When binding with vfio-pci, secondary process cannot be started with an error message: cannot find TAILQ entry for PCI device. It's due to: struct rte_pci_addr is padded with 1 byte for alignment by compiler. Then below comparison in commit 2f4adfad0a69 ("vfio: add multiprocess support") will

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: add CL for ptype mapping configure

2017-03-16 Thread Ferruh Yigit
On 3/12/2017 12:08 PM, Qi Zhang wrote: > Add below command line to configure ptype mapping. > ptype mapping get . > ptype mapping replace. > ptype mapping reset . > ptype mapping update . > > Signed-off-by: Qi Zhang > --- > app/test-pmd/cmdline.c | 372 > +

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Dumitrescu, Cristian
... > > Thomas, given Tim's confirmation of Intel's plans to implement this API for > the ixgbe and i40e drivers in DPDK release 17.8, are you in favour of > including > this API in 17.5 with experimental tag (subject to full API agreement being > reached)? > > I think starting a branch in a de

Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset for VF

2017-03-16 Thread Thomas Monjalon
2017-02-23 13:27, Qi Zhang: > static void > +i40evf_dev_stats_reset(struct rte_eth_dev *dev) > +{ > + struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > + /* only DPDK PF support this */ > + if (vf->version_major == I40E_DPDK_VERSION_MAJOR) { > + if (i

Re: [dpdk-dev] [PATCH v10 02/18] lib: create private header file

2017-03-16 Thread Thomas Monjalon
2017-03-16 10:43, Hunt, David: > On 15/3/2017 5:18 PM, Thomas Monjalon wrote: > > 2017-03-15 06:19, David Hunt: > >> +/** > >> + * Number of packets to deal with in bursts. Needs to be 8 so as to > >> + * fit in one cache line. > >> + */ > >> +#define RTE_DIST_BURST_SIZE (sizeof(rte_xmm_t) / sizeof

Re: [dpdk-dev] [PATCH v4 17/17] doc: adds information related to the AVP PMD

2017-03-16 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, March 16, 2017 10:53 AM <...> > +; > > +[Features] > > +Link status = Y > > +Queue start/stop = Y > > +Jumbo frame = Y > > +Scattered Rx = Y > > +Promiscuous mode

Re: [dpdk-dev] [PATCH v4 07/17] net/avp: driver registration

2017-03-16 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, March 16, 2017 10:53 AM <...> > I am for removing static function declarations by reordering functions, and > for this case even reordering not required I think, you can remove them. Ok. Will do

Re: [dpdk-dev] [PATCH v4 04/17] net/avp: add PMD version map file

2017-03-16 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, March 16, 2017 10:53 AM <..> > Hi Allain, > > Instead of adding files per patch, may I suggest different ordering: > First add skeleton files in a patch, later add functional pieces one by one,

Re: [dpdk-dev] [PATCH v4 07/17] net/avp: driver registration

2017-03-16 Thread Ferruh Yigit
On 3/13/2017 7:16 PM, Allain Legacy wrote: > Adds the initial framework for registering the driver against the support > PCI device identifiers. > > Signed-off-by: Allain Legacy > Signed-off-by: Matt Peters <...> > +static int eth_avp_dev_init(struct rte_eth_dev *eth_dev); > +static int eth_av

Re: [dpdk-dev] [PATCH v4 17/17] doc: adds information related to the AVP PMD

2017-03-16 Thread Ferruh Yigit
On 3/13/2017 7:16 PM, Allain Legacy wrote: > Updates the documentation and feature lists for the AVP PMD device. > > Signed-off-by: Allain Legacy > Signed-off-by: Matt Peters > Acked-by: John McNamara <...> > diff --git a/doc/guides/nics/features/avp.ini > b/doc/guides/nics/features/avp.ini

Re: [dpdk-dev] [PATCH v4 04/17] net/avp: add PMD version map file

2017-03-16 Thread Ferruh Yigit
On 3/13/2017 7:16 PM, Allain Legacy wrote: > Adds a default ABI version file for the AVP PMD. > > Signed-off-by: Allain Legacy > Signed-off-by: Matt Peters > --- > drivers/net/avp/rte_pmd_avp_version.map | 4 > 1 file changed, 4 insertions(+) > create mode 100644 drivers/net/avp/rte_pmd_a

Re: [dpdk-dev] [PATCH] net/sfc: add missing BSD license line and update year

2017-03-16 Thread Ferruh Yigit
On 3/16/2017 12:41 PM, Andrew Rybchenko wrote: > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-16 Thread Ferruh Yigit
On 3/15/2017 11:55 PM, Yongseok Koh wrote: > This patchset is to add the Enhanced Multi-Packet Send feature which is > newly introduced for ConnectX-5 families of adaptors. > > v3: > * Fix indentation > * Fix typo in comment > * Change name of variables and functions > > v2: > * Resolves conflict

Re: [dpdk-dev] [PATCH] net/mlx5: limit flow API rules to one tunnel

2017-03-16 Thread Ferruh Yigit
On 3/15/2017 12:32 PM, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: add advanced function to extract FW version

2017-03-16 Thread Ferruh Yigit
On 3/16/2017 11:01 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Some libefx-based drivers might need this functionality to > indicate DPCPU FW IDs as part of FW version info to assist > experienced users. > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andr

Re: [dpdk-dev] [PATCH] net/i40e: fix broadcast promiscuous mode setting

2017-03-16 Thread Ferruh Yigit
On 3/16/2017 3:09 AM, Wenzhuo Lu wrote: > When setting up the VSIs, MAC filter is used for > receiving MAC broadcast packets. > We should follow it to implement the broadcast > promiscuous mode setting. > > Fixes: 61fff9b4c68b (net/i40e: set VF broadcast mode from PF) > > Signed-off-by: Wenzhuo L

[dpdk-dev] [PATCH] net/sfc: add missing BSD license line and update year

2017-03-16 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/Makefile | 4 +++- drivers/net/sfc/efsys.h | 4 +++- drivers/net/sfc/sfc.c| 4 +++- drivers/net/sfc/sfc.h| 4 +++- drivers/net/sfc/sfc_debug.h | 4 +++- drivers/net/sfc/sfc_ethdev.c | 4 +++- drivers/net/sfc/sfc_ev.c

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-16 Thread Ferruh Yigit
On 3/15/2017 6:19 PM, Jan Blunck wrote: > On Wed, Mar 15, 2017 at 1:35 PM, Charles (Chas) Williams > wrote: >> If the user reconfigures the queue size, then the previously allocated >> memzone may potentially be too small. Release the memzone when a queue >> is released and allocate a new one eac

Re: [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-16 Thread Maxime Coquelin
On 03/16/2017 09:00 AM, Yuanhan Liu wrote: On Sun, Mar 12, 2017 at 05:34:01PM +0100, Maxime Coquelin wrote: This patch implements the function for the application to get the MTU value. I'm thinking the other way. As we are making vhost being generic, it doesn't make too much sense now to sto

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-16 Thread Adrien Mazarguil
On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote: > Most ConnectX-3 adapters expose two physical ports on a single PCI bus > address. > > Add a new port parameter allowing the user to choose > either or both physical ports to be used by the application. > > This parameter is used as f

[dpdk-dev] [PATCH 2/2] net/sfc: add callback to retrieve FW version

2017-03-16 Thread Andrew Rybchenko
From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee --- doc/guides/nics/features/sfc_efx.ini | 1 + drivers/net/sfc/sfc_ethdev.c | 49 2 files changed, 50 insertions(+) diff --git a/doc/guides/nics/f

[dpdk-dev] [PATCH 1/2] net/sfc/base: add advanced function to extract FW version

2017-03-16 Thread Andrew Rybchenko
From: Ivan Malov Some libefx-based drivers might need this functionality to indicate DPCPU FW IDs as part of FW version info to assist experienced users. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton --- drivers/net/sfc/base/ef10

[dpdk-dev] [PATCH] vfio: add hotplug support

2017-03-16 Thread Alejandro Lucero
Current device hotplug is just when using UIO. This patch adds same functionality with VFIO. It has been validated through tests using IOMMU and also with VFIO and no-iommu mode. Signed-off-by: Alejandro Lucero --- lib/librte_eal/common/eal_common_pci.c | 2 +- lib/librte_eal/linuxapp

[dpdk-dev] [PATCH] maintainers: resign from eal maintenance

2017-03-16 Thread David Marchand
I have been a little too busy these past months and could not really do any real maintainer stuff for dpdk for a while now. I have no clear idea when I could dedicate more time to dpdk. So the best thing for the dpdk community would be to move the eal maintenance to more involved people. Signed-o

Re: [dpdk-dev] [PATCH v10 02/18] lib: create private header file

2017-03-16 Thread Hunt, David
On 15/3/2017 5:18 PM, Thomas Monjalon wrote: 2017-03-15 06:19, David Hunt: +/** + * Number of packets to deal with in bursts. Needs to be 8 so as to + * fit in one cache line. + */ +#define RTE_DIST_BURST_SIZE (sizeof(rte_xmm_t) / sizeof(uint16_t)) error: 'rte_xmm_t' undeclared here (arm compil

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-16 Thread Chas Williams
On Thu, 2017-03-16 at 03:18 +, O'Driscoll, Tim wrote: > > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > > > > Le 15/03/2017 à 11:55, Thomas Monjalon a écrit : > > >> I'd suggest that this is a good topic for the next Tech Board > > meeting. > > > I agree Tim. > > > CC'ing techboard

Re: [dpdk-dev] [PATCH v2] eventdev: Add rte_errno return values to the enqueue and dequeue functions

2017-03-16 Thread Jerin Jacob
On Wed, Feb 15, 2017 at 11:09:54AM -0600, Gage Eads wrote: > This change allows user software to differentiate between an invalid argument > (such as an invalid queue_id or sched_type in an enqueued event) and > backpressure from the event device. > > The port and device ID checks are placed in RT

[dpdk-dev] [dpdk-dev 1/4] examples: enable HW CRC strip by default

2017-03-16 Thread Jeff Guo
Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers, and for most case of kernel driver default enable HW CRC strip, if disable HW CRC strip in example app's rxmode, VF driver will return fail and result the VF launch failure. So this patch default to enable HW CRC strip

[dpdk-dev] [dpdk-dev 4/4] net/i40evf: add notify to correct CRC strip config

2017-03-16 Thread Jeff Guo
Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers in i40e, if HW CRC strip config in example app's rxmode is not match with the kernel PF default config, VF driver will return fail. The patch just add notify to let user know how to correctly re-config it to let the VF s

[dpdk-dev] [dpdk-dev 3/4] test: enable HW CRC strip by default

2017-03-16 Thread Jeff Guo
Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers, and for most case of kernel driver default enable HW CRC strip, if disable HW CRC strip in test app's rxmode, VF driver will return fail and result the VF launch failure. So this patch default to enable HW CRC strip to

[dpdk-dev] [dpdk-dev 2/4] app: enable HW CRC strip by default

2017-03-16 Thread Jeff Guo
Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers, and for most case of kernel driver default enable HW CRC strip, if disable HW CRC strip in app's rxmode, VF driver will return fail and result the VF launch failure. So this patch default to enable HW CRC strip to let V

Re: [dpdk-dev] [PATCH] vhost: fix virtio_net cache sharing of broadcast_rarp

2017-03-16 Thread Kevin Traynor
On 03/16/2017 06:21 AM, Yuanhan Liu wrote: > On Wed, Mar 15, 2017 at 07:10:49PM +, Kevin Traynor wrote: >> The virtio_net structure is used in both enqueue and dequeue datapaths. >> broadcast_rarp is checked with cmpset in the dequeue datapath regardless >> of whether descriptors are available

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-16 Thread Wiles, Keith
Sent from my iPhone > On Mar 16, 2017, at 4:53 PM, Francois Ozog wrote: > > Hi, > > Virtio is special in many ways: > - it is a multi-vendor supported specification > - it is a multi-vendor opensource implementation in guest OSes > (Windows, Linux, FreeBSD...) > - it is a multi-vendor, opens

Re: [dpdk-dev] [PATCH 03/17] vhost: use new APIs to handle features

2017-03-16 Thread Maxime Coquelin
On 03/16/2017 08:43 AM, Yuanhan Liu wrote: On Tue, Mar 14, 2017 at 11:43:44AM +0100, Maxime Coquelin wrote: diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 8433a54..f7227bf 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -143,9

Re: [dpdk-dev] [PATCH 06/17] vhost: introduce API to fetch negotiated features

2017-03-16 Thread Maxime Coquelin
On 03/16/2017 08:35 AM, Yuanhan Liu wrote: On Tue, Mar 14, 2017 at 12:02:59PM +0100, Maxime Coquelin wrote: +uint64_t +rte_vhost_get_negotiated_features(int vid) +{ + struct virtio_net *dev; + + dev = get_device(vid); + if (!dev) + return -1; + + return de

Re: [dpdk-dev] [PATCH 07/17] vhost: export vhost vring info

2017-03-16 Thread Maxime Coquelin
On 03/16/2017 08:24 AM, Yuanhan Liu wrote: On Tue, Mar 14, 2017 at 01:11:24PM +0100, Maxime Coquelin wrote: +int +rte_vhost_get_vhost_vring(int vid, uint16_t vring_idx, + struct rte_vhost_vring *vring) +{ + struct virtio_net *dev; + struct vhost_virtqueue *v

Re: [dpdk-dev] [PATCH 01/17] vhost: introduce driver features related APIs

2017-03-16 Thread Maxime Coquelin
On 03/16/2017 08:08 AM, Yuanhan Liu wrote: On Tue, Mar 14, 2017 at 10:53:23AM +0100, Maxime Coquelin wrote: On 03/14/2017 10:46 AM, Maxime Coquelin wrote: On 03/03/2017 10:51 AM, Yuanhan Liu wrote: Introduce few APIs to set/get/enable/disable driver features. Signed-off-by: Yuanhan Liu

[dpdk-dev] [PATCH v2] net/tap: support segmented mbufs

2017-03-16 Thread Pascal Mazon
Support for segmented packets (scatter/gather) is mandatory for most purposes, regardless of the MTU size. Tx packets are often the result of mbuf concatenation, and an mbuf is not necessarily large enough for Rx packets to fit in a single one. Signed-off-by: Pascal Mazon Acked-by: Keith Wiles -

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-16 Thread Francois Ozog
Hi, Virtio is special in many ways: - it is a multi-vendor supported specification - it is a multi-vendor opensource implementation in guest OSes (Windows, Linux, FreeBSD...) - it is a multi-vendor, opensource implementation in hypervisors So, the great benefit of virtio is that with a SINGLE d

Re: [dpdk-dev] [PATCH 01/39] eventdev: update PMD dequeue timeout conversion callback

2017-03-16 Thread Jerin Jacob
On Wed, Mar 15, 2017 at 05:27:15PM +, Van Haaren, Harry wrote: > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Friday, March 3, 2017 5:28 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 01/39] eventdev: update PMD dequeue timeout > > conversion > > callback > >

Re: [dpdk-dev] [PATCH] net/virtio: disable LSC interrupt if MSIX not enabled

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 09, 2017 at 03:28:02PM -0500, Allain Legacy wrote: > From: Matt Peters > > The link state change interrupt can only be configured if the virtio device > supports MSIX. Prior to this change the writing of the vector to the PCI > config space was causing it to overwrite the initial par

Re: [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-16 Thread Yuanhan Liu
On Sun, Mar 12, 2017 at 05:34:01PM +0100, Maxime Coquelin wrote: > This patch implements the function for the application to > get the MTU value. I'm thinking the other way. As we are making vhost being generic, it doesn't make too much sense now to store a net specific value at vhost layer. I'm t

Re: [dpdk-dev] [PATCH 04/17] vhost: make notify ops per vhost driver

2017-03-16 Thread Yuanhan Liu
On Tue, Mar 14, 2017 at 11:55:20AM +0100, Maxime Coquelin wrote: > >diff --git a/examples/tep_termination/main.c > >b/examples/tep_termination/main.c > >index 8c45128..03c0fbe 100644 > >--- a/examples/tep_termination/main.c > >+++ b/examples/tep_termination/main.c > >@@ -1258,7 +1258,8 @@ static i

Re: [dpdk-dev] [PATCH 03/17] vhost: use new APIs to handle features

2017-03-16 Thread Yuanhan Liu
On Tue, Mar 14, 2017 at 11:43:44AM +0100, Maxime Coquelin wrote: > >diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > >index 8433a54..f7227bf 100644 > >--- a/lib/librte_vhost/vhost_user.c > >+++ b/lib/librte_vhost/vhost_user.c > >@@ -143,9 +143,9 @@ > > * The features th

Re: [dpdk-dev] [PATCH 06/17] vhost: introduce API to fetch negotiated features

2017-03-16 Thread Yuanhan Liu
On Tue, Mar 14, 2017 at 12:02:59PM +0100, Maxime Coquelin wrote: > >+uint64_t > >+rte_vhost_get_negotiated_features(int vid) > >+{ > >+struct virtio_net *dev; > >+ > >+dev = get_device(vid); > >+if (!dev) > >+return -1; > >+ > >+return dev->features; > >+} > Are we sure

Re: [dpdk-dev] [PATCH 07/17] vhost: export vhost vring info

2017-03-16 Thread Yuanhan Liu
On Tue, Mar 14, 2017 at 01:11:24PM +0100, Maxime Coquelin wrote: > >+int > >+rte_vhost_get_vhost_vring(int vid, uint16_t vring_idx, > >+ struct rte_vhost_vring *vring) > >+{ > >+struct virtio_net *dev; > >+struct vhost_virtqueue *vq; > >+ > >+dev = get_device(vid);

Re: [dpdk-dev] [PATCH 01/17] vhost: introduce driver features related APIs

2017-03-16 Thread Yuanhan Liu
On Tue, Mar 14, 2017 at 10:53:23AM +0100, Maxime Coquelin wrote: > > > On 03/14/2017 10:46 AM, Maxime Coquelin wrote: > > > > > >On 03/03/2017 10:51 AM, Yuanhan Liu wrote: > >>Introduce few APIs to set/get/enable/disable driver features. > >> > >>Signed-off-by: Yuanhan Liu > >>--- > >> lib/librt