Re: [dpdk-dev] [PATCH v4 07/17] net/avp: driver registration

[Legacy, Allain]

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, March 16, 2017 10:53 AM

<...>

> I am for removing static function declarations by reordering functions, and
> for this case even reordering not required I think, you can remove them.
Ok.  Will do


> > +   /* Get a mac from device config */
> > +   ether_addr_copy(&avp->ethaddr, &eth_dev->data->mac_addrs[0]);
> 
> This copies MAC address from avp->ethaddr to eth_dev.
> But at this point avp->ethaddr is all zero, is this the intention?

This is because of the patch splitting.  The avp_dev_create() call sets this 
up.  I didn't notice that I had them in separate patches.  I will try to fix 
this up.