Re: [dpdk-dev] [PATCH 1/2] ethdev: add capability control API

2017-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2017 at 02:05:49PM +, Cristian Dumitrescu wrote: > The rte_flow feature breaks the current monolithic approach for ethdev and > introduces the new generic flow API to ethdev using a plugin-like approach. > > Basically, the rte_flow API is still logically part of ethdev: > - It

Re: [dpdk-dev] [PATCH] eventdev: clarify nb_unlinks description

2017-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2017 at 01:04:33PM -0600, Gage Eads wrote: > This commit clarifies the usage of nb_unlinks when passing a NULL pointer > as the queues argument. > > Signed-off-by: Gage Eads > --- > lib/librte_eventdev/rte_eventdev.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [dpdk-dev] [PATCH] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-02-10 Thread gowrishankar muthukrishnan
Hi Thomas, I see rc3 out. Could this patch also go in 17.02 (rc4 ?). This patch is ppc64le specific (w/o affecting other arch) and it enables pmd over vfio-pci be useful for this arch. Thanks, Gowrishankar On Friday 10 February 2017 11:48 AM, Gowrishankar wrote: From: Gowrishankar Muthukrish

[dpdk-dev] GSO/GRO support

2017-02-10 Thread Kiran KN
We, at Juniper Opencontrail have added software support for TCP send offload and receive offload to DPDK. If the community is interested, we can publish/upstream it. Pl let us know what you think of it. Thanks, Kiran

[dpdk-dev] [PATCH] eventdev: Add rte_errno return values to the enqueue and dequeue functions

2017-02-10 Thread Gage Eads
This change allows user software to differentiate between an invalid argument (such as an invalid queue_id or sched_type in an enqueued event) and backpressure from the event device. The port and device ID checks are placed in RTE_LIBRTE_EVENTDEV_DEBUG header guards to avoid the performance hit in

Re: [dpdk-dev] [PATCH 1/2] ethdev: add capability control API

2017-02-10 Thread Wiles, Keith
> On Feb 10, 2017, at 8:06 AM, Cristian Dumitrescu > wrote: > > The rte_flow feature breaks the current monolithic approach for ethdev and > introduces the new generic flow API to ethdev using a plugin-like approach. > > Basically, the rte_flow API is still logically part of ethdev: > - It ex

[dpdk-dev] [PATCH] net/bnx2x: Fix transmit queue free threshold

2017-02-10 Thread Charles (Chas) Williams
The default tx_free_thresh is potentially larger than the allocated queue which will result in TX queue cleanup never happening. To fix this, lower the default free threshold and ensure that the free threshold is never greater than the maximum outstanding transmit buffers. Fixes: 827ed2a118cc ("n

Re: [dpdk-dev] [PATCH] igb_uio: map dummy dma forcing iommu domain attachment

2017-02-10 Thread Ferruh Yigit
On 2/10/2017 7:03 PM, Ferruh Yigit wrote: > On 2/8/2017 11:54 AM, Alejandro Lucero wrote: >> Hi Ferruh, >> >> On Tue, Feb 7, 2017 at 3:59 PM, Ferruh Yigit > > wrote: >> >> Hi Alejandro, >> >> On 1/18/2017 12:27 PM, Alejandro Lucero wrote: >> > For using a

[dpdk-dev] [PATCH] eventdev: clarify nb_unlinks description

2017-02-10 Thread Gage Eads
This commit clarifies the usage of nb_unlinks when passing a NULL pointer as the queues argument. Signed-off-by: Gage Eads --- lib/librte_eventdev/rte_eventdev.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_ev

Re: [dpdk-dev] [PATCH] igb_uio: map dummy dma forcing iommu domain attachment

2017-02-10 Thread Ferruh Yigit
On 2/8/2017 11:54 AM, Alejandro Lucero wrote: > Hi Ferruh, > > On Tue, Feb 7, 2017 at 3:59 PM, Ferruh Yigit > wrote: > > Hi Alejandro, > > On 1/18/2017 12:27 PM, Alejandro Lucero wrote: > > For using a DPDK app when iommu is enabled, it requires to >

Re: [dpdk-dev] [dpdk-techboard] decision process and DPDK scope

2017-02-10 Thread Thomas Monjalon
2017-02-10 15:54, Bruce Richardson: > On Thu, Feb 09, 2017 at 02:49:05PM -0800, Stephen Hemminger wrote: > > On Thu, 9 Feb 2017 12:20:47 + > > Bruce Richardson wrote: > > > > > > I think we can use this case to avoid seeing it again in the future. > > > > I suggest that the technical board sh

[dpdk-dev] [dpdk-announce] release candidate 17.02-rc3

2017-02-10 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v17.02-rc3 It is February 10th, the third RC is out, bringing a lot of fixes. A new release must be available every three months, preferably at the beginning of the month. It means it is time to close th

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2017 11:53:06 +0100 Thomas Monjalon wrote: > 2017-02-10 10:39, Hunt, David: > > > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote: > > > 2016-11-06 22:09, Thomas Monjalon: > > >> 2016-09-29 18:34, Thomas Monjalon: > > >>> 2016-09-30 02:54, Nikhil Rao: > > The original co

Re: [dpdk-dev] [PATCH] net/bonding: improve non-ip packets RSS

2017-02-10 Thread Declan Doherty
On 18/11/16 09:08, haifeng.lin at huawei.com (Haifeng Lin) wrote: Most ethernet not support non-ip packets RSS and only first queue can used to receive. In this scenario lacp bond can only use one queue even if multi queue configured. We use below formula to change the map between bond_qid and s

Re: [dpdk-dev] [dpdk-techboard] decision process and DPDK scope

2017-02-10 Thread Bruce Richardson
On Thu, Feb 09, 2017 at 02:49:05PM -0800, Stephen Hemminger wrote: > On Thu, 9 Feb 2017 12:20:47 + > Bruce Richardson wrote: > > > > I think we can use this case to avoid seeing it again in the future. > > > I suggest that the technical board should check whether every new proposed > > > feat

Re: [dpdk-dev] [PATCH] doc: clarify Multi-Buffer library version support

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Friday, February 10, 2017 1:01 PM > To: De Lara Guarch, Pablo; Mcnamara, John > Cc: dev@dpdk.org; De Lara Guarch, Pablo; Doherty, Declan > Subject: RE: [dpdk-dev] [PATCH] doc: clarify Multi-Buffer library version > support > > > >

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, February 10, 2017 1:49 PM > To: Zhang, Roy Fan; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization > > > > > -Original Message

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix session backup

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, February 10, 2017 1:37 PM > To: Zhang, Roy Fan; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: fix session backup > > > > > -Original Message- >

[dpdk-dev] [PATCH 2/2] ethdev: add hierarchical scheduler API

2017-02-10 Thread Cristian Dumitrescu
This patch introduces the generic ethdev API for the hierarchical scheduler capability. Main features: - Exposed as ethdev plugin capability (similar to rte_flow approach) - Capability query API per port and per hierarchy node - Scheduling algorithms: strict priority (SP), Weighed Fair Queuing (WF

[dpdk-dev] [PATCH 0/2] ethdev: abstraction layer for QoS hierarchical scheduler

2017-02-10 Thread Cristian Dumitrescu
This patch set introduces an ethdev-based abstraction layer for Quality of Service (QoS) hierarchical scheduler. The goal is to provide a simple generic API that is agnostic of the underlying HW, SW or mixed HW-SW implementation. Patch 1 builds on the mechanism introduced by rte_flow in DPDK and g

[dpdk-dev] [PATCH 1/2] ethdev: add capability control API

2017-02-10 Thread Cristian Dumitrescu
The rte_flow feature breaks the current monolithic approach for ethdev and introduces the new generic flow API to ethdev using a plugin-like approach. Basically, the rte_flow API is still logically part of ethdev: - It extends the ethdev functionality: rte_flow is a new feature/capability of eth

[dpdk-dev] [PATCH v3] doc: use corelist instead of coremask

2017-02-10 Thread Keith Wiles
The coremask option in DPDK is difficult to use and we should be promoting the use of the corelist (-l) option. The patch adjusts the docs to use -l EAL option instead of the -c option. The patch only changes the docs and not the code as the -c option will continue to exist unless it is removed in

Re: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure

2017-02-10 Thread Trahe, Fiona
Hi Fan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Friday, February 10, 2017 11:39 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > structure > > Signed-off-by: F

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, February 09, 2017 6:50 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH v3] crypto/scheduler: fix initialization > > Fixes the wrong slave initialization issue on start-up > > Fixes: 100e4f7e44ab ("crypto/s

Re: [dpdk-dev] [PATCH v2 00/11] moving away from coremask to corelist

2017-02-10 Thread Wiles, Keith
> On Feb 10, 2017, at 2:46 AM, Thomas Monjalon > wrote: > > Hi Keith, > > 2017-02-09 17:42, Keith Wiles: >> The coremask option in DPDK is difficult to use and we should be >> promoting the use of the corelist (-l) option. The patch series >> adjusts the docs to use -l EAL option instead of th

Re: [dpdk-dev] [PATCH v2] app/crypto-perf: fix dereference null return value

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, February 10, 2017 1:25 PM > To: Mrozowicz, SlawomirX; Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: Re: [dpdk-dev] [PATCH v2] app/crypto-perf: fix dere

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix session backup

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, February 09, 2017 6:46 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] crypto/scheduler: fix session backup > > Fixes the missed session backup during enqueue. > > Fixes: 100e4f7e44ab ("crypto/scheduler:

Re: [dpdk-dev] [PATCH v2] app/crypto-perf: fix dereference null return value

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Friday, February 10, 2017 2:23 PM > To: Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: [dpdk-dev] [PATCH v2] app/crypto-perf: fix dereference null return > value >

Re: [dpdk-dev] [PATCH] eal/linux: fix fd check before close

2017-02-10 Thread Thomas Monjalon
2017-02-10 08:53, Yong Wang: > The "dev->intr_handle.fd" is possibly a negative value while it is > passed as an argument to function "close". Fix the check to the fd. > > Signed-off-by: Yong Wang pci: fix UIO interrupt file descriptor check before close Fixes: 5a60a7ffc801 ("pci: introduce fun

Re: [dpdk-dev] [PATCH] doc: fix unreadable images

2017-02-10 Thread Thomas Monjalon
2017-02-10 11:18, Jianfeng Tan: > The images by below two commits are very unclear. Fix it. > > Fixes: 50665deebda ("doc: add guide to use virtio-user for container > networking") > Fixes: 0ba3870e755 ("doc: add guide to use virtio-user as exceptional path") > > Suggested-by: Thomas Monjalon >

Re: [dpdk-dev] [PATCH] doc: clarify Multi-Buffer library version support

2017-02-10 Thread Jain, Deepak K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, February 10, 2017 12:34 PM > To: dec...@intel.com; Mcnamara, John > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] doc: clarify Multi-Buffer library version su

Re: [dpdk-dev] [PATCH v2] cryptodev: fix segmentation fault

2017-02-10 Thread Mrozowicz, SlawomirX
>-Original Message- >From: De Lara Guarch, Pablo >Sent: Thursday, February 9, 2017 11:21 PM >To: De Lara Guarch, Pablo ; Mrozowicz, >SlawomirX ; Doherty, Declan > >Cc: dev@dpdk.org; Mrozowicz, SlawomirX >Subject: RE: [dpdk-dev] [PATCH v2] cryptodev: fix segmentation fault > > > >> -Or

[dpdk-dev] [PATCH] eal/linux: fix fd check before close

2017-02-10 Thread Yong Wang
The "dev->intr_handle.fd" is possibly a negative value while it is passed as an argument to function "close". Fix the check to the fd. Signed-off-by: Yong Wang --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxap

[dpdk-dev] [PATCH] doc: clarify Multi-Buffer library version support

2017-02-10 Thread Pablo de Lara
AES-NI MB PMD uses external Multi-Buffer library, which is hosted in github, but the version was not specified in the documentation. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_mb.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/guides/cryptodevs

[dpdk-dev] [PATCH v2] app/crypto-perf: fix dereference null return value

2017-02-10 Thread Slawomir Mrozowicz
Dereferencing a pointer that might be null key_token when calling strstr. Check if the pointer is null before. Coverity issue: 141071 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Slawomir Mrozowicz --- v2 changes: - print message only if key_toke

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 Thread Hunt, David
On 10/2/2017 10:53 AM, Thomas Monjalon wrote: 2017-02-10 10:39, Hunt, David: On 9/2/2017 4:53 PM, Thomas Monjalon wrote: 2016-11-06 22:09, Thomas Monjalon: 2016-09-29 18:34, Thomas Monjalon: 2016-09-30 02:54, Nikhil Rao: The original code used movl instead of xchgl, this caused rte_atomic6

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix segmentation fault when use qat pmd

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, February 10, 2017 11:26 AM > To: Mrozowicz, SlawomirX; Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fi

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix incorrect size of expression

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, February 10, 2017 11:29 AM > To: Piasecki, JacekX; Doherty, Declan > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix incorrect size of > expr

[dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure

2017-02-10 Thread Fan Zhang
Signed-off-by: Fan Zhang --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 755dc65..564d93a 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_note

Re: [dpdk-dev] [PATCH] net/i40e: fix wrong definition of TC bandwidth

2017-02-10 Thread Ferruh Yigit
On 2/10/2017 5:25 AM, Wenzhuo Lu wrote: > The range of TC bandwidth is 0 ~ 800, it's 16bits not 8bits. > > Fixes: c8b9a3e3fe1b ("i40e: support DCB mode") > CC: sta...@dpdk.org > > Signed-off-by: Wenzhuo Lu Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix incorrect size of expression

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Piasecki, JacekX > Sent: Friday, February 10, 2017 1:26 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo; Piasecki, JacekX > Subject: [PATCH v2] app/test-crypto-perf: fix incorrect size of expression > > Fix problem of passing a pointer to s

Re: [dpdk-dev] [PATCH] net/ixgbe: fix tci mask check in fdir pasrer

2017-02-10 Thread Ferruh Yigit
On 2/10/2017 1:37 AM, Wei Zhao wrote: > It must use big endian when check on the tci mask of vlan > and vxlan parser in fdir filter rule pattern parser.Because > rte layer send out tci mask using big endian mode. > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > Fixes: cc83320af2

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix segmentation fault when use qat pmd

2017-02-10 Thread De Lara Guarch, Pablo
Hi Slawomir, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Thursday, February 09, 2017 1:57 PM > To: Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix segmentation f

[dpdk-dev] [PATCH v2] app/test-crypto-perf: fix incorrect size of expression

2017-02-10 Thread Jacek Piasecki
Fix problem of passing a pointer to sizeof() function. Now the size of enabled_cdevs structure is passed by RTE_CRYPTO_MAX_DEVS. Coverity issue: 141068 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Jacek Piasecki --- v2: * RTE_CRYPTO_MAX_DEVS is p

Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance

2017-02-10 Thread Yang, Qiming
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, February 10, 2017 6:25 PM > To: Yang, Qiming ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance > > On 2/10/2017 1:26 AM, Qiming Yang wrote: > > This patch removed usele

Re: [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio

2017-02-10 Thread Tan, Jianfeng
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, February 10, 2017 6:44 PM > To: Tan, Jianfeng > Cc: Yigit, Ferruh; dev@dpdk.org; Mcnamara, John; > yuanhan@linux.intel.com; step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 3/

Re: [dpdk-dev] [PATCH v2] net/virtio: add speed capability

2017-02-10 Thread Thomas Monjalon
2017-02-10 12:05, Thomas Monjalon: > From: Ido Barnea > > The chosen fake capability (10G) is consistent with the reported > link speed in virtio_dev_link_update(): > link.link_speed = SPEED_10G; > > The feature is not marked in doc/guides/nics/features/virtio.ini > as it is only a fake va

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix uninitialized scalar variable

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, February 10, 2017 9:47 AM > To: Gajewski, AleksanderX; Doherty, Declan > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix uninitialized > scal

[dpdk-dev] [PATCH v2] net/virtio: add speed capability

2017-02-10 Thread Thomas Monjalon
From: Ido Barnea The chosen fake capability (10G) is consistent with the reported link speed in virtio_dev_link_update(): link.link_speed = SPEED_10G; The feature is not marked in doc/guides/nics/features/virtio.ini as it is only a fake value. Signed-off-by: Ido Barnea [Thomas: comment

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 Thread Thomas Monjalon
2017-02-10 10:39, Hunt, David: > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote: > > 2016-11-06 22:09, Thomas Monjalon: > >> 2016-09-29 18:34, Thomas Monjalon: > >>> 2016-09-30 02:54, Nikhil Rao: > The original code used movl instead of xchgl, this caused > rte_atomic64_cmpset to use ebx a

Re: [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio

2017-02-10 Thread Thomas Monjalon
2017-02-09 17:40, Ferruh Yigit: > On 2/9/2017 4:06 PM, Jianfeng Tan wrote: > > This ABI changes to remove iomem and ioport mapping in igb_uio. The > > purpose of this changes was to fix a bug: when DPDK app crashes, > > those devices by igb_uio are not stopped either DPDK PMD driver or > > igb_uio

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 Thread Hunt, David
On 9/2/2017 4:53 PM, Thomas Monjalon wrote: 2016-11-06 22:09, Thomas Monjalon: 2016-09-29 18:34, Thomas Monjalon: 2016-09-30 02:54, Nikhil Rao: The original code used movl instead of xchgl, this caused rte_atomic64_cmpset to use ebx as the lower dword of the source to cmpxchg8b instead of the

Re: [dpdk-dev] [PATCH v2] eventdev: amend comments for events limit and threshold

2017-02-10 Thread Van Haaren, Harry
> From: Nipun Gupta [mailto:nipun.gu...@nxp.com] > Sent: Friday, February 10, 2017 3:50 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; Eads, Gage ; Van Haaren, > Harry > ; Nipun Gupta > Subject: [PATCH v2] eventdev: amend comments for eve

Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance

2017-02-10 Thread Ferruh Yigit
On 2/10/2017 1:26 AM, Qiming Yang wrote: > This patch removed useless tx_flags in vlan insertion. Overall this looks good, I wonder what was the initial intention of this code, understanding it helps to figure out if there is a hidden defect. This code not fixes a defect, but improves the code, i

[dpdk-dev] [PATCH v3] eventdev: amend timeout criteria comment for burst dequeue

2017-02-10 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Harry van Haaren --- Changes for v2: - Fix errors reported by check-git-log.sh Changes for v3: - Corrected comment's language lib/librte_eventdev/rte_eventdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_eve

Re: [dpdk-dev] [PATCH] eal: fix max number of interrupt request

2017-02-10 Thread Thomas Monjalon
2017-02-09 14:59, Qi Zhang: > The max number of interrupt request is possible > be changed after rte_intr_callback_register, so > in get_max_intr, we need to check if nessesary to > update the max_intr. So you are using rte_intr_enable() to update the max_intr field in the case of VFIO_MSIX. What

Re: [dpdk-dev] Hotplug support for VFIO

2017-02-10 Thread Alejandro Lucero
On Thu, Feb 9, 2017 at 3:16 AM, Tetsuya Mukawa wrote: > 2017-02-09 0:48 GMT+09:00 Alejandro Lucero >: > > I just wanted to clarify the hotplug VFIO is not the problem, as I can > see > > it, but the unplug. When attaching a device the current VFIO code will be > > used, but there is no code for

Re: [dpdk-dev] [PATCH v2 2/2] mk: move PMD libraries to applications

2017-02-10 Thread Thomas Monjalon
2017-01-31 15:04, Ferruh Yigit: > Some PMDs provide device specific APIs. Bond and xenvirt are existing > samples for this. > > And since these are PMD libraries, there are two options on how to link > them for shared library build: > > 1- They can be linked to all applications by default, using

Re: [dpdk-dev] [PATCH] net/i40e: fix wrong handle when enable interrupt

2017-02-10 Thread Ferruh Yigit
On 2/9/2017 8:02 PM, Qi Zhang wrote: > In i40e_dev_interrupt_handler, when call rte_intr_enable, > We should parse dev->intr_handle but not intr_handle. > intr_handle is the copy of dev->intr_handle when > it is registered, but parameter of dev->intr_handle is > possible to be modifed later in i40e

Re: [dpdk-dev] [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue

2017-02-10 Thread Van Haaren, Harry
> -Original Message- > From: Nipun Gupta [mailto:nipun.gu...@nxp.com] > Sent: Friday, February 10, 2017 3:48 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; Eads, Gage ; Van Haaren, > Harry > ; Nipun Gupta > Subject: [PATCH v2] eve

[dpdk-dev] [PATCH v2] eventdev: amend comments for events limit and threshold

2017-02-10 Thread Nipun Gupta
Updated the comments on 'nb_events_limit' of 'struct rte_event_dev_config' and 'new_event_threshold' of 'struct rte_event_port_conf' for open system configuration. Signed-off-by: Nipun Gupta --- Changes for v2: - Fix errors reported by check-git-log.sh lib/librte_eventdev/rte_eventdev.h | 12 +

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix uninitialized scalar variable

2017-02-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Gajewski, AleksanderX > Sent: Friday, February 10, 2017 9:23 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo; Gajewski, AleksanderX > Subject: [PATCH v2] app/test-crypto-perf: fix uninitialized scalar variable > > Fix problem with uninitial

[dpdk-dev] [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue

2017-02-10 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- Changes for v2: - Fix errors reported by check-git-log.sh lib/librte_eventdev/rte_eventdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h index c2f9310..49a4739 100644

[dpdk-dev] [PATCH v2] app/test-crypto-perf: fix uninitialized scalar variable

2017-02-10 Thread Aleksander Gajewski
Fix problem with uninitialized nb_cryptodevs variable by initialize it with 0 value. Program could jump to err label without running cperf_initialize_cryptodev() function. Also assign 0 value to nb_cryptodevs after cperf_initialize_cryptodev() when value is negative. Coverity issue: 141073 Fixes:

[dpdk-dev] [PATCH] eventdev: amend comments for nb_events_limit and new_event_threshold

2017-02-10 Thread Nipun Gupta
Updated the comments on 'nb_events_limit' of 'struct rte_event_dev_config' and 'new_event_threshold' of 'struct rte_event_port_conf' for open system configuration. Signed-off-by: Nipun Gupta --- lib/librte_eventdev/rte_eventdev.h | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-)

Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option

2017-02-10 Thread Liu, Yong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, February 10, 2017 4:36 PM > To: Liu, Yong > Cc: Tan, Jianfeng ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse- > ptype option > > 2017-02-10 07:53, L

[dpdk-dev] [PATCH] eventdev: amend comment for timeout_ticks in rte_event_dequeue_burst()

2017-02-10 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- lib/librte_eventdev/rte_eventdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h index c2f9310..49a4739 100644 --- a/lib/librte_eventdev/rte_eventdev.h +++ b/lib/librte_ev

Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option

2017-02-10 Thread Tan, Jianfeng
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, February 10, 2017 4:36 PM > To: Liu, Yong > Cc: Tan, Jianfeng; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse- > ptype option > > 2017-02-10

Re: [dpdk-dev] [PATCH v2 00/11] moving away from coremask to corelist

2017-02-10 Thread Thomas Monjalon
Hi Keith, 2017-02-09 17:42, Keith Wiles: > The coremask option in DPDK is difficult to use and we should be > promoting the use of the corelist (-l) option. The patch series > adjusts the docs to use -l EAL option instead of the -c option. > > The patch series doc change only and is not required

Re: [dpdk-dev] [PATCH] Fill speed_capa for virtio

2017-02-10 Thread Thomas Monjalon
2017-02-10 07:49, Ido Barnea: > On 09/02/2017, 6:19 PM, "Thomas Monjalon" wrote: > >2017-02-02 12:05, Ido Barnea: > >> From: Ido Barnea > >> > >> Signed-off-by: Ido Barnea > >> --- > >> drivers/net/virtio/virtio_ethdev.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/driver

Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option

2017-02-10 Thread Thomas Monjalon
2017-02-10 07:53, Liu, Yong: > From: Thomas Monjalon > > 2017-02-09 22:25, Marvin Liu: > > > Add new option parse-ptype in this sample in case of pmd driver > > > not provide packet type info. If this option enabled, packet type > > > will be analyzed in Rx callback function. > > [...] > > > +