> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, February 10, 2017 6:44 PM > To: Tan, Jianfeng > Cc: Yigit, Ferruh; dev@dpdk.org; Mcnamara, John; > yuanhan....@linux.intel.com; step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio > > 2017-02-09 17:40, Ferruh Yigit: > > On 2/9/2017 4:06 PM, Jianfeng Tan wrote: > > > This ABI changes to remove iomem and ioport mapping in igb_uio. The > > > purpose of this changes was to fix a bug: when DPDK app crashes, > > > those devices by igb_uio are not stopped either DPDK PMD driver or > > > igb_uio driver. > > > > > > Then it has been pointed out by Stephen Hemminger that it has > > > backward compatibility issue: cannot run old version DPDK on > > > modified igb_uio. > > > > > > However, we still have not figure out a new way to fix this bug > > > without this change. Let's postpone this deprecation announcement > > > in case this change cannot be avoided. > > > > > > Fixes: 3bac1dbc1ed ("doc: announce iomem and ioport removal from > igb_uio") > > > > > > Suggested-by: Stephen Hemminger <step...@networkplumber.org> > > > Suggested-by: Ferruh Yigit <ferruh.yi...@intel.com> > > > Suggested-by: Thomas Monjalon <thomas.monja...@6wind.com> > > > Signed-off-by: Jianfeng Tan <jianfeng....@intel.com> > > > > Acked-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Applied, thanks > > The images are not real vector images and are almost unreadable. > Please make the effort to use inkscape in order to have images > we can update.
Apologies for that. I've submitted a patch to changes the images. And thank you for the solution. > > I did some changes: s/virtio_user/virtio-user/ in order to be consistent. > Like for vhost-user, we use the underscore only in code. Thank you for that. Regards, Jianfeng