Re: [dpdk-dev] [PATCH v3 01/10] doc: add NXP dpaa2_sec in cryptodev

2017-01-30 Thread Akhil Goyal
On 1/24/2017 9:03 PM, De Lara Guarch, Pablo wrote: Hi, -Original Message- From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] Sent: Friday, January 20, 2017 2:05 PM To: dev@dpdk.org Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; Mcnamara, John; nhor...@tuxdriv

[dpdk-dev] [dpdk-announce] release candidate 17.02-rc2

2017-01-30 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v17.02-rc2 What's new in RC2? - a crypto scheduler driver - a crypto performance test application - a lot of fixes The release notes have been updated: http://dpdk.org/do

[dpdk-dev] [dpdk-pdump] Problem with dpdk-pdump

2017-01-30 Thread Clarylin L
Hi all, I just started to use dpdk-pdump and got some problem with it. Appreciate your help! By following the document, I got testpmd running with pdump framework initialized and tried to start dpdk-pdump as a secondary process. However, I failed to start dpdk-pdump. My testpmd was running like:

Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics library

2017-01-30 Thread Remy Horton
Some points addressed. Will cover other ones later. On 30/01/2017 15:50, Thomas Monjalon wrote: [..] +CONFIG_RTE_LIBRTE_METRICS=y I know the config file is not so well sorted. However it would be a bit more logical below CONFIG_RTE_LIBRTE_JOBSTATS. Done. Rebase merging doesn't help with sor

Re: [dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor

2017-01-30 Thread Ferruh Yigit
On 1/30/2017 8:57 PM, Wiles, Keith wrote: > >> On Jan 30, 2017, at 2:54 PM, Yigit, Ferruh wrote: >> >> From: Keith Wiles >> >> Rx and Tx queues share the common tap file descriptor, but save this >> value separately. >> >> Setting up Rx/Tx queue sets up both queues, release_queue close the >> ta

[dpdk-dev] [PATCH v7] net/kni: add KNI PMD

2017-01-30 Thread Ferruh Yigit
Add KNI PMD which wraps librte_kni for ease of use. KNI PMD can be used as any regular PMD to send / receive packets to the Linux networking stack. Signed-off-by: Ferruh Yigit Reviewed-by: Yong Wang --- v7: * Add dependency to CONFIG_RTE_LIBRTE_KNI config v6: * documentation typos fixed v5:

Re: [dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor

2017-01-30 Thread Wiles, Keith
> On Jan 30, 2017, at 2:54 PM, Yigit, Ferruh wrote: > > From: Keith Wiles > > Rx and Tx queues share the common tap file descriptor, but save this > value separately. > > Setting up Rx/Tx queue sets up both queues, release_queue close the > tap file but update file descriptor only for that qu

[dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor

2017-01-30 Thread Ferruh Yigit
From: Keith Wiles Rx and Tx queues share the common tap file descriptor, but save this value separately. Setting up Rx/Tx queue sets up both queues, release_queue close the tap file but update file descriptor only for that queue. This makes other queue's file descriptor invalid. As a workaroun

Re: [dpdk-dev] [PATCH v3] doc: add device specific API

2017-01-30 Thread Thomas Monjalon
2017-01-30 20:27, Ferruh Yigit: > On 1/30/2017 8:25 PM, Thomas Monjalon wrote: > > 2017-01-30 21:21, Thomas Monjalon: > >> 2017-01-30 18:27, Ferruh Yigit: > >>> Signed-off-by: Ferruh Yigit > >> > >> Applied, thanks > > > > Actually no, there are a lot of doxygen errors in ixgbe and i40e API. > >

Re: [dpdk-dev] [PATCH v3] doc: add device specific API

2017-01-30 Thread Ferruh Yigit
On 1/30/2017 8:25 PM, Thomas Monjalon wrote: > 2017-01-30 21:21, Thomas Monjalon: >> 2017-01-30 18:27, Ferruh Yigit: >>> Signed-off-by: Ferruh Yigit >> >> Applied, thanks > > Actually no, there are a lot of doxygen errors in ixgbe and i40e API. > I cannot be merged as is. I already fixed and mer

Re: [dpdk-dev] [PATCH v3] doc: add device specific API

2017-01-30 Thread Thomas Monjalon
2017-01-30 21:21, Thomas Monjalon: > 2017-01-30 18:27, Ferruh Yigit: > > Signed-off-by: Ferruh Yigit > > Applied, thanks Actually no, there are a lot of doxygen errors in ixgbe and i40e API. I cannot be merged as is.

Re: [dpdk-dev] [PATCH v3] doc: add device specific API

2017-01-30 Thread Thomas Monjalon
2017-01-30 18:27, Ferruh Yigit: > Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH 25/25] rte_eal_init: add info about rte_errno codes

2017-01-30 Thread Thomas Monjalon
2017-01-30 13:38, Aaron Conole: > Stephen Hemminger writes: > > Bruce Richardson wrote: > >> On Fri, Jan 27, 2017 at 08:33:46AM -0800, Stephen Hemminger wrote: > >> > Why use rte_errno? > >> > Most DPDK calls just return negative value on error which > >> > corresponds to error number. > >> > Are

[dpdk-dev] [PATCH v6] net/kni: add KNI PMD

2017-01-30 Thread Ferruh Yigit
Add KNI PMD which wraps librte_kni for ease of use. KNI PMD can be used as any regular PMD to send / receive packets to the Linux networking stack. Signed-off-by: Ferruh Yigit Reviewed-by: Yong Wang --- v6: * documentation typos fixed v5: * add kvargs "no_request_thread" to disable a specific

Re: [dpdk-dev] [PATCH v5] net/kni: add KNI PMD

2017-01-30 Thread Ferruh Yigit
On 1/30/2017 7:05 PM, Yong Wang wrote: >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Monday, January 30, 2017 8:58 AM >> To: Thomas Monjalon ; Yong Wang >> >> Cc: dev@dpdk.org; Ferruh Yigit >> Subject: [PATCH v5] net/kni: add KNI PMD >> >> Add KNI PM

Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup

2017-01-30 Thread Ferruh Yigit
On 1/30/2017 6:20 PM, Wiles, Keith wrote: > >> On Jan 30, 2017, at 11:42 AM, Yigit, Ferruh wrote: >> >> On 1/30/2017 2:34 PM, Wiles, Keith wrote: >>> On Jan 30, 2017, at 5:00 AM, Yigit, Ferruh wrote: On 1/29/2017 2:12 AM, Keith Wiles wrote: > The tap driver setup both rx and t

Re: [dpdk-dev] [PATCH v5] net/kni: add KNI PMD

2017-01-30 Thread Yong Wang
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, January 30, 2017 8:58 AM > To: Thomas Monjalon ; Yong Wang > > Cc: dev@dpdk.org; Ferruh Yigit > Subject: [PATCH v5] net/kni: add KNI PMD > > Add KNI PMD which wraps librte_kni for ease of use. > >

Re: [dpdk-dev] [PATCH 25/25] rte_eal_init: add info about rte_errno codes

2017-01-30 Thread Aaron Conole
Stephen Hemminger writes: > On Fri, 27 Jan 2017 16:47:40 + > Bruce Richardson wrote: > >> On Fri, Jan 27, 2017 at 08:33:46AM -0800, Stephen Hemminger wrote: >> > On Fri, 27 Jan 2017 09:57:03 -0500 >> > Aaron Conole wrote: >> > >> > > diff --git a/lib/librte_eal/common/include/rte_eal.h

[dpdk-dev] [PATCH v3] doc: add device specific API

2017-01-30 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- v3: * remove "," after [PCI] --- doc/api/doxy-api-index.md | 6 +- doc/api/doxy-api.conf | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index f9958c4..eb39f69 100644 --- a/doc/api

[dpdk-dev] [PATCH v2] doc: add device specific API

2017-01-30 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/api/doxy-api-index.md | 6 +- doc/api/doxy-api.conf | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index f9958c4..ff57784 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api/d

Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup

2017-01-30 Thread Wiles, Keith
> On Jan 30, 2017, at 11:42 AM, Yigit, Ferruh wrote: > > On 1/30/2017 2:34 PM, Wiles, Keith wrote: >> >>> On Jan 30, 2017, at 5:00 AM, Yigit, Ferruh wrote: >>> >>> On 1/29/2017 2:12 AM, Keith Wiles wrote: The tap driver setup both rx and tx file descriptors when the rte_eth_rx_queue

Re: [dpdk-dev] [PATCH v2] mk: parallelize make config

2017-01-30 Thread Thomas Monjalon
2017-01-30 10:21, Ferruh Yigit: > make config dependency resolving was always running serial, > parallelize it for better performance. > > $ time make T=x86_64-native-linuxapp-gcc config > real0m12.633s > > $ time make -j8 T=x86_64-native-linuxapp-gcc config > real0m1.826s > > When confi

Re: [dpdk-dev] [PATCH] doc: update release notes for I/O device memory access API

2017-01-30 Thread Thomas Monjalon
> > Signed-off-by: Jerin Jacob > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add PMD specific API

2017-01-30 Thread Thomas Monjalon
2017-01-27 12:27, Ferruh Yigit: > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -153,3 +153,7 @@ There are many libraries, so their headers may be grouped > by topics: >[ABI compat] (@ref rte_compat.h), >[keepalive] (@ref rte_keepalive.h), >[ve

Re: [dpdk-dev] [PATCH 3/3] doc: remove ABI changes in igb_uio

2017-01-30 Thread Thomas Monjalon
2017-01-24 13:35, Ferruh Yigit: > On 1/24/2017 7:34 AM, Jianfeng Tan wrote: > > We announced ABI changes to remove iomem and ioport mapping in > > igb_uio. But it has potential backward compatibility issue: cannot > > run old version DPDK on modified igb_uio. > > > > The purpose of this changes wa

Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup

2017-01-30 Thread Ferruh Yigit
On 1/30/2017 2:34 PM, Wiles, Keith wrote: > >> On Jan 30, 2017, at 5:00 AM, Yigit, Ferruh wrote: >> >> On 1/29/2017 2:12 AM, Keith Wiles wrote: >>> The tap driver setup both rx and tx file descriptors when the >>> rte_eth_rx_queue_setup() causing the tx to be closed when tx setup >>> was called.

Re: [dpdk-dev] rte_eth_from_rings

2017-01-30 Thread Sridhar Pitchai
Thanks Bruce, Hi Ferruh, I experimented the following to get the KNI interface up, but not able to get it up yet. rte_kni_alloc(..) // with rte_eth_dev_info = NULL ; ; rte_kni_register_handlers // with rte_eth_dev_info set with right call_back for port_up_down and if_mtu ; ; ; I also

Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup

2017-01-30 Thread Ferruh Yigit
On 1/30/2017 2:38 PM, Pascal Mazon wrote: > On 01/30/2017 12:00 PM, Ferruh Yigit wrote:> On 1/29/2017 2:12 AM, Keith > Wiles wrote: >>> The tap driver setup both rx and tx file descriptors when the >>> rte_eth_rx_queue_setup() causing the tx to be closed when tx setup >>> was called. >> >> Can you

Re: [dpdk-dev] [PATCH] config: add default MPIPE PMD config to common base

2017-01-30 Thread Ferruh Yigit
On 1/30/2017 10:46 AM, Thomas Monjalon wrote: > 2017-01-30 10:40, Ferruh Yigit: >> --- a/config/common_base >> +++ b/config/common_base >> @@ -219,6 +219,12 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n >> CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8 >> >> # >> +# MPIPE PMD >> +# >> +CONFIG_RTE_LIBRTE_MPIPE_PMD=n

[dpdk-dev] [PATCH v5] net/kni: add KNI PMD

2017-01-30 Thread Ferruh Yigit
Add KNI PMD which wraps librte_kni for ease of use. KNI PMD can be used as any regular PMD to send / receive packets to the Linux networking stack. Signed-off-by: Ferruh Yigit --- v5: * add kvargs "no_request_thread" to disable a specific pthread creation to handle control requests. * add docum

Re: [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init

2017-01-30 Thread Aaron Conole
Bruce Richardson writes: > On Fri, Jan 27, 2017 at 08:31:55AM -0800, Stephen Hemminger wrote: >> On Fri, 27 Jan 2017 09:56:53 -0500 >> Aaron Conole wrote: >> >> > + if (rte_eal_alarm_init() < 0) { >> > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); >> > + /*

Re: [dpdk-dev] [PATCH 14/25] eal: do not panic on tailq init

2017-01-30 Thread Aaron Conole
Stephen Hemminger writes: > On Fri, 27 Jan 2017 09:56:52 -0500 > Aaron Conole wrote: > >> + /* no need to TAILQ_REMOVE, we are going to disallow re-attemtps >> + * for rte_eal_init(). */ > > Please put multi-line comments in form: > /* > * this is

Re: [dpdk-dev] [PATCH 07/25] eal: Signal error when CPU isn't supported

2017-01-30 Thread Aaron Conole
Stephen Hemminger writes: > On Fri, 27 Jan 2017 09:56:45 -0500 > Aaron Conole wrote: > >> It's now possible to gracefully exit the application, or for >> applications which support non-dpdk datapaths working in concert with >> DPDK datapaths, there no longer is the possibility of exiting for >>

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix name parameter parsing

2017-01-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, January 30, 2017 11:19 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] crypto/scheduler: fix name parameter parsing > > This patch fixes the name parsing issue. Originally, the unique > scheduler name create

Re: [dpdk-dev] [PATCH v2] tools: fix active interface detection in dpdk-devbind.py

2017-01-30 Thread Thomas Monjalon
2017-01-10 17:14, Yoni Gilad: > When adding crypto devices, the "Active" and "Ssh_if" attributes of > existing network devices were reset. This causes the following issues: > > - Network interfaces aren't marked as "*Active*" in the --status output. > - Active network interfaces can be unbound wit

Re: [dpdk-dev] [PATCH] examples/flow-distributor: rename to server_node_efd

2017-01-30 Thread Thomas Monjalon
2017-01-24 09:06, Pablo de Lara: > To avoid confusion with distributor app, this commit > renames the flow-distributor sample app to server_node_efd, > since it shows how to use the EFD library and it is based > on a server/nodes model. > > Signed-off-by: Pablo de Lara Are you sure of the name?

Re: [dpdk-dev] [PATCH] app/test: fix overflow in EFD test

2017-01-30 Thread Thomas Monjalon
2017-01-25 11:29, Pablo de Lara: > When RTE_EFD_VALUE_NUM_BITS is 32, there was a compilation issue > because of an overflow: > > app/test/test_efd.c:157:55: error: overflow in expression; > result is 2147483647 with type 'int' [-Werror,-Winteger-overflow] > data[0] = mrand48() & ((1 << RT

Re: [dpdk-dev] [PATCH] app/test: make PCI device id struct const

2017-01-30 Thread Thomas Monjalon
2017-01-27 09:53, Ferruh Yigit: > Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] pdump: fix nb_rx_q may be used uninitialized warning

2017-01-30 Thread Thomas Monjalon
2017-01-18 07:26, Andrew Rybchenko: > Fix GCC 4.8.2 20140120 (Red Hat 4.8.2-16) (RHEL 7.0) false warning > when build with EXTRA_CFLAGS='--coverage'. > > Fixes: 278f945402c5 ("pdump: add new library for packet capture") > > Signed-off-by: Andrew Rybchenko Applied, thanks

Re: [dpdk-dev] [PATCH v7] app/testpmd: supported offload capabilities query

2017-01-30 Thread Thomas Monjalon
> > Add two new commands "show port cap " and "show > > port cap all"to diaplay what offload capabilities supported > > in ports. It will not only display all the capabilities of > > the port, but also the enabling condition for each capability > > in the running time. > > > > Signed-off-by: Qimin

Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics library

2017-01-30 Thread Thomas Monjalon
Hi Remy, > This patch adds a new information metric library that allows other > modules to register named metrics and update their values. It is > intended to be independent of ethdev, rather than mixing ethdev > and non-ethdev information in xstats. I'm still not convinced by this library, and t

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix link status query

2017-01-30 Thread Nélio Laranjeiro
On Wed, Jan 25, 2017 at 02:42:58PM +0200, Shahaf Shuler wrote: > Trying to query the link status through new kernel ioctl API > ETHTOOL_GLINKSETTINGS was always failing due to kernel bug. > The bug was fixed on version 4.9 > this patch uses the legacy ioctl API for lower kernels. > > Fixes: 188408

Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup

2017-01-30 Thread Wiles, Keith
> On Jan 30, 2017, at 8:38 AM, Pascal Mazon wrote: > > On 01/30/2017 12:00 PM, Ferruh Yigit wrote:> On 1/29/2017 2:12 AM, Keith > Wiles wrote: >>> The tap driver setup both rx and tx file descriptors when the >>> rte_eth_rx_queue_setup() causing the tx to be closed when tx setup >>> was called.

Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup

2017-01-30 Thread Pascal Mazon
On 01/30/2017 12:00 PM, Ferruh Yigit wrote:> On 1/29/2017 2:12 AM, Keith Wiles wrote: The tap driver setup both rx and tx file descriptors when the rte_eth_rx_queue_setup() causing the tx to be closed when tx setup was called. Can you please describe the problem more. Without this patch rx->fd

Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup

2017-01-30 Thread Wiles, Keith
> On Jan 30, 2017, at 5:00 AM, Yigit, Ferruh wrote: > > On 1/29/2017 2:12 AM, Keith Wiles wrote: >> The tap driver setup both rx and tx file descriptors when the >> rte_eth_rx_queue_setup() causing the tx to be closed when tx setup >> was called. > > Can you please describe the problem more. >

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-30 Thread Yuanhan Liu
On Mon, Jan 30, 2017 at 02:54:16PM +0100, Maxime Coquelin wrote: > >OTOH, again, testing is welcome, if it's later proved to be worse on > >ARM (which I highly doubt), I could revert them. > Or have a per-architecture definition of ASSIGN_UNLESS_EQUAL if it > proved to regress on ARM? Yes, we coul

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-30 Thread Maxime Coquelin
On 01/30/2017 02:30 PM, Yuanhan Liu wrote: On Mon, Jan 16, 2017 at 12:26:41PM +0100, Michal Orsák wrote: For such workload, I don't think it would behaviour worse on ARM. No reply yet; I will treat it as no objections, and please shout out if any. Both applied to dpdk-next-virtio. -

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-30 Thread Yuanhan Liu
On Mon, Jan 16, 2017 at 12:26:41PM +0100, Michal Orsák wrote: > >>For such workload, I don't think it would behaviour worse on ARM. > >No reply yet; I will treat it as no objections, and please shout out if > >any. > > > >Both applied to dpdk-next-virtio. > > > > --yliu

Re: [dpdk-dev] [PATCH] net/vhost: fix unix socket not removed as closing

2017-01-30 Thread Yuanhan Liu
On Tue, Jan 24, 2017 at 08:37:38AM +, Jianfeng Tan wrote: > The commit aed0b12930b ("net/vhost: fix socket file deleted on stop") > moves rte_vhost_driver_register and rte_vhost_driver_unregister from > dev_start() and dev_stop() into driver's probe() and remove(). > > Apps, like testpmd, usin

Re: [dpdk-dev] buf->hash.rss always empty with i40e

2017-01-30 Thread tom . barbette
That solved it ! Thanks. However I think this should be documented somewhere, especially as the behaviour is different between i40e and ixgbe. Tom - Mail original - De: "Bruce Richardson" À: "tom barbette" Cc: dev@dpdk.org Envoyé: Lundi 30 Janvier 2017 11:46:30 Objet: Re: [dpdk-dev]

[dpdk-dev] Unable to run test_pmd_perf

2017-01-30 Thread Priyanka
Hi All, We have VMs on a physical server with both VMs having 1 core 7 GB RAM with DPDK 16.04. The VMs are communicating using SR-IOV (per VM 1 VF is assigned). We thought of running the test_pmd_perf to test the number of cycles taken for RX/TX. But we are unable to get it working. Even if w

Re: [dpdk-dev] [PATCH] vhost: remove unneeded variable assignment

2017-01-30 Thread Yuanhan Liu
On Tue, Jan 24, 2017 at 09:31:29PM +0100, Emmanuel Roullit wrote: > Found with clang static analysis: > lib/librte_vhost/vhost_user.c:996:3: warning: > Value stored to 'ret' is never read > ret = vhost_user_get_vring_base(dev, &msg.payload.state); > ^ ~~~

Re: [dpdk-dev] [PATCH] net/virtio: do not gso when no header is present

2017-01-30 Thread Yuanhan Liu
On Tue, Jan 24, 2017 at 09:36:03PM +0100, Emmanuel Roullit wrote: > Found with clang static analysis: > lib/librte_vhost/virtio_net.c:723:17: warning: > Access to field 'data_off' results in a dereference of a null pointer > (loaded from variable 'tcp_hdr') > m->l4_len = (tcp_hdr->data_off

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak

2017-01-30 Thread De Lara Guarch, Pablo
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday, January 30, 2017 9:33 AM > To: De Lara Guarch, Pablo > Cc: Wu, Jingjing; dev@dpdk.org > Subject: Re: [PATCH v2] app/testpmd: fix memory leak > > Hi Pablo, > > On Fri, Jan 27, 2017

Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get

2017-01-30 Thread Ferruh Yigit
On 1/25/2017 5:24 AM, Tiwei Bie wrote: > On Wed, Jan 25, 2017 at 01:13:32PM +0800, Lu, Wenzhuo wrote: >> Hi Tiwei, >> >>> -Original Message- >>> From: Bie, Tiwei >>> Sent: Wednesday, January 25, 2017 11:17 AM >>> To: Lu, Wenzhuo >>> Cc: dev@dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH] net/i

[dpdk-dev] [PATCH] crypto/scheduler: fix name parameter parsing

2017-01-30 Thread Fan Zhang
This patch fixes the name parsing issue. Originally, the unique scheduler name created by system is not passed to vdev initializer. Fixes: 8b483eae ("crypto/scheduler: register scheduler vdev driver") Signed-off-by: Fan Zhang --- drivers/crypto/scheduler/scheduler_pmd.c | 7 +-- 1 file chan

Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset

2017-01-30 Thread Remy Horton
On 28/01/2017 13:14, Yuanhan Liu wrote: [..] I'll apply the patch from Remy which fixes a case where process creates I would ask you not to apply that. IMO, his patch may have "fixed" a crash he saw, but it doesn't looks like to me it really fixes anything: the driver may reference rte_eth_dat

Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup

2017-01-30 Thread Ferruh Yigit
On 1/29/2017 2:12 AM, Keith Wiles wrote: > The tap driver setup both rx and tx file descriptors when the > rte_eth_rx_queue_setup() causing the tx to be closed when tx setup > was called. Can you please describe the problem more. Without this patch rx->fd == tx->fd, with this patch rx and tx has d

Re: [dpdk-dev] [PATCH] config: add default MPIPE PMD config to common base

2017-01-30 Thread Thomas Monjalon
2017-01-30 10:40, Ferruh Yigit: > --- a/config/common_base > +++ b/config/common_base > @@ -219,6 +219,12 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n > CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8 > > # > +# MPIPE PMD > +# > +CONFIG_RTE_LIBRTE_MPIPE_PMD=n > +CONFIG_RTE_LIBRTE_MPIPE_PMD_DEBUG=n NACK I think the

Re: [dpdk-dev] buf->hash.rss always empty with i40e

2017-01-30 Thread Bruce Richardson
On Sat, Jan 28, 2017 at 11:48:36AM +0100, tom.barbe...@ulg.ac.be wrote: > Hi all, > > No matter the number of queues or the ETH_RSS_X parameter the mbuf->hash.rss > field is empty using XL710 NICs. The exact same configuration gives me good > hash value values with ixgbe/82599 cards. > > Any id

Re: [dpdk-dev] [PATCH v4 1/6] eventdev: introduce event driven programming model

2017-01-30 Thread Jerin Jacob
On Thu, Jan 26, 2017 at 08:39:57PM +, Eads, Gage wrote: > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Thursday, January 26, 2017 3:39 AM > > To: Eads, Gage > > Cc: Richardson, Bruce ; 'dev@dpdk.org' > > ; 'thomas.monja...@6wi

[dpdk-dev] [PATCH] config: add default MPIPE PMD config to common base

2017-01-30 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- config/common_base | 6 ++ 1 file changed, 6 insertions(+) diff --git a/config/common_base b/config/common_base index 00a91b9..f44d4e4 100644 --- a/config/common_base +++ b/config/common_base @@ -219,6 +219,12 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n CONFIG_RTE_LIBR

Re: [dpdk-dev] [PATCH 1/9] net/ixgbe: remove redundant EOL character from logs

2017-01-30 Thread Ferruh Yigit
On 1/27/2017 5:49 PM, Stephen Hemminger wrote: > On Fri, 27 Jan 2017 17:46:11 + > Ferruh Yigit wrote: > >> Signed-off-by: Ferruh Yigit > > Thanks for fixing this. > > Acked-by: Stephen Hemminger > Applied to dpdk-next-net/master, thanks. (all squashed into single commit: "drivers/net:

Re: [dpdk-dev] rte_eth_from_rings

2017-01-30 Thread Bruce Richardson
On Fri, Jan 27, 2017 at 10:31:52PM +, Sridhar Pitchai wrote: > Thanks Bruce. > > > I have created eth_dev from the rings as below. > rt = rte_eth_from_rings(port_p->name, > (struct rte_ring * const*)port_p->rx_ring_p, 2, > (struct rte_ring * const*)por

[dpdk-dev] [PATCH v2] mk: parallelize make config

2017-01-30 Thread Ferruh Yigit
make config dependency resolving was always running serial, parallelize it for better performance. $ time make T=x86_64-native-linuxapp-gcc config real0m12.633s $ time make -j8 T=x86_64-native-linuxapp-gcc config real0m1.826s When config creation done under a single make target, using a

Re: [dpdk-dev] [PATCH 05/13] acl: fix acl_flow_data comments

2017-01-30 Thread Thomas Monjalon
> > Signed-off-by: Michał Mirosław > > Acked-by: Konstantin Ananyev Applied, thanks

Re: [dpdk-dev] [PATCH 0/2] Enable zero verdicts in ACLs

2017-01-30 Thread Thomas Monjalon
> > This set enables one to have ACL matches return 0 where the distinction > > from no-match case is not needed. > > > > This is a resubmission of the patches as a series, rebased on net-next tree, > > no other changes vs v2. > > > > v2: fixes to prog_guide and ACL tests > > > > Michał Mirosław

Re: [dpdk-dev] [PATCH] efd: fix compilation by removing dep to libmath

2017-01-30 Thread Thomas Monjalon
2017-01-27 14:45, De Lara Guarch, Pablo: > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > > When we compile the dpdk with: > > CONFIG_RTE_LIBRTE_EFD=y > > CONFIG_RTE_LIBRTE_NFP_PMD=n > > CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n > > CONFIG_RTE_LIBRTE_SCHED=n > > CONFIG_RTE_LIBRTE_

Re: [dpdk-dev] [PATCH 03/13] rte_ether: set PKT_RX_VLAN_STRIPPED in rte_vlan_strip()

2017-01-30 Thread Thomas Monjalon
It is fixing the introduction of the new flag PKT_RX_VLAN_STRIPPED. Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") This patch is applying the flag to the software emulation case (currently only for virtio). So the comment of this flag should be changed: /** * A vlan has been s

Re: [dpdk-dev] [PATCH] mk: parallelize make config

2017-01-30 Thread Ferruh Yigit
On 1/29/2017 3:29 PM, Thomas Monjalon wrote: > 2017-01-22 01:50, Ferruh Yigit: >> make config dependency resolving was always running serial, >> parallelize it for better performance. > > It could be interesting to explain why it was not parallelized, > and how you made it possible. I will try to

Re: [dpdk-dev] [PATCH] mk: parallelize make config

2017-01-30 Thread Ferruh Yigit
On 1/23/2017 7:03 PM, Michał Mirosław wrote: > 2017-01-22 2:50 GMT+01:00 Ferruh Yigit : >> make config dependency resolving was always running serial, >> parallelize it for better performance. >> >> $ time make T=x86_64-native-linuxapp-gcc config >> real0m12.633s >> >> $ time make -j8 T=x86_64-

Re: [dpdk-dev] [PATCH] ethdev: remove useless pointer initialization

2017-01-30 Thread Thomas Monjalon
2017-01-24 21:28, Emmanuel Roullit: > Found with clang static analysis: > lib/librte_ether/rte_ethdev.c:2467:22: > warning: Value stored to 'dev' during its initialization is never read > struct rte_eth_dev *dev = &rte_eth_devices[port_id]; > ^~~ ~ > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak

2017-01-30 Thread Adrien Mazarguil
Hi Pablo, On Fri, Jan 27, 2017 at 02:54:58PM +, Pablo de Lara wrote: > Free memory when port flow entry creation fails. > > Coverity issue: 139600 > Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") > > Signed-off-by: Pablo de Lara > --- > Changes in v2: > > - Remov

Re: [dpdk-dev] [PATCH v5] ethdev: fix MAC address replay

2017-01-30 Thread Thomas Monjalon
2017-01-27 09:57, Steve Shin: > This patch fixes a bug in replaying MAC address to the hardware > in rte_eth_dev_config_restore() routine. Added default MAC replay as well. > > Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements") > > --- > v2: Added default MAC replay & Code optimization. > v3: Cove

Re: [dpdk-dev] [PATCH] mbuf: remove redundant line in rte_pktmbuf_attach

2017-01-30 Thread Thomas Monjalon
> > > >> mi->next will be assigned to NULL few lines later, trivial patch > > > >> > > > >> Signed-off-by: Ilya V. Matveychikov > > Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure") > > Acked-by: Olivier Matz Applied, thanks