On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote:
> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> > Found with clang static analysis:
> > drivers/net/cxgbe/sge.c:900:3: warning:
> > Value stored to 'in_use' is never read
> > in_use += q->size;
> > ^
Value returned from malloc is not checked for errors before being used.
This patch fixes following coverity issue.
static struct vhost_memory_kernel *
prepare_vhost_memory_kernel(void)
{
...
vm = malloc(sizeof(struct vhost_memory_kernel) +
max_region
> -Original Message-
> From: Eads, Gage
> Sent: Wednesday, January 25, 2017 10:54 AM
> To: Richardson, Bruce ; Jerin Jacob
> ; dev@dpdk.org
> Cc: thomas.monja...@6wind.com; hemant.agra...@nxp.com; Van Haaren,
> Harry ; McDaniel, Timothy
>
> Subject: RE: [dpdk-dev] [PATCH v4 1/6]
> On Jan 25, 2017, at 9:57 AM, Richardson, Bruce
> wrote:
>
> On Wed, Jan 25, 2017 at 03:59:55PM +, Wiles, Keith wrote:
>>
>>
>> Sent from my iPhone
>>
>>> On Jan 25, 2017, at 7:48 AM, Bruce Richardson
>>> wrote:
>>>
On Wed, Jan 25, 2017 at 01:54:04PM +, Bruce Richardson wrot
Thomas Monjalon writes:
> Hi Aaron,
>
> 2016-12-30 10:25, Aaron Conole:
>> In many cases, it's enough to simply let the application know that the
>> call to initialize DPDK has failed. A complete halt can then be
>> decided by the application based on error returned (and the app could
>> even at
Hi Thomas,
Thanks for the hints.
I will improve the patch and resubmit.
Comments are present inline.
Regards,
- Emmanuel
On Wed, Jan 25, 2017 at 11:08 AM, Thomas Monjalon wrote:
> 2017-01-24 22:04, Emmanuel Roullit:
> > Found with clang build:
> > error: taking address of packed member 'mlock
On 1/19/2017 4:46 AM, Sergey Vyazmitinov wrote:
> Optimized kni_allocate_mbufs and kni_free_mbufs by using mbuf
> bulk functions. This can improve performance more than two times.
>
> Signed-off-by: Sergey Vyazmitinov
> ---
> v5:
> * use rte_pktmbuf_free_bulk for removing packets which was not
>
On 1/19/2017 4:46 AM, Sergey Vyazmitinov wrote:
> Optimized kni_allocate_mbufs and kni_free_mbufs by using mbuf bulk functions
Hi Sergey,
Although I found this patch and its idea useful, performance test result
is showing a performance lose after this patch.
In my test setup [1] the performance
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Wednesday, January 25, 2017 4:58 PM
> To: Wiles, Keith
> Cc: Olivier MATZ ; dev@dpdk.org
> Subject: Re: [dpdk-dev] rte_ring features in use (or not)
>
> On Wed, Jan 25, 2017 at 03:59:55P
On Wed, Jan 25, 2017 at 03:59:55PM +, Wiles, Keith wrote:
>
>
> Sent from my iPhone
>
> > On Jan 25, 2017, at 7:48 AM, Bruce Richardson
> > wrote:
> >
> >> On Wed, Jan 25, 2017 at 01:54:04PM +, Bruce Richardson wrote:
> >>> On Wed, Jan 25, 2017 at 02:20:52PM +0100, Olivier MATZ wrote:
> -Original Message-
> From: Richardson, Bruce
> Sent: Wednesday, January 25, 2017 10:36 AM
> To: Eads, Gage ; Jerin Jacob
> ; dev@dpdk.org
> Cc: thomas.monja...@6wind.com; hemant.agra...@nxp.com; Van Haaren,
> Harry ; McDaniel, Timothy
>
> Subject: RE: [dpdk-dev] [PATCH v4 1/6]
On Wed, 25 Jan 2017 14:20:52 +0100
Olivier MATZ wrote:
> > * Who uses the watermarks feature as is? I know we have a sample app
> > that uses it, but there are better ways I think to achieve the same
> > goal while simplifying the ring implementation. Rather than have a
> > set watermark on e
> -Original Message-
> From: Eads, Gage
> Sent: Wednesday, January 25, 2017 4:32 PM
> To: Jerin Jacob ; dev@dpdk.org
> Cc: thomas.monja...@6wind.com; Richardson, Bruce
> ; hemant.agra...@nxp.com; Van Haaren, Harry
> ; McDaniel, Timothy
>
> Subject: RE: [dpdk-dev] [PATCH v4 1/6] eventdev:
Hi Jerin,
See the bottom of this email for a proposed tweak to the
rte_event_enqueue_burst() return value.
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Wednesday, December 21, 2016 3:25 AM
> To: dev@dpdk.org
> Cc: thomas.monja...@6wind.com
Sent from my iPhone
> On Jan 25, 2017, at 7:48 AM, Bruce Richardson
> wrote:
>
>> On Wed, Jan 25, 2017 at 01:54:04PM +, Bruce Richardson wrote:
>>> On Wed, Jan 25, 2017 at 02:20:52PM +0100, Olivier MATZ wrote:
>>> On Wed, 25 Jan 2017 12:14:56 +, Bruce Richardson
>>> wrote:
Hi al
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir
> Mrozowicz
> Sent: Wednesday, January 25, 2017 4:28 PM
> To: dev@dpdk.org
> Cc: Mrozowicz, SlawomirX
> Subject: [dpdk-dev] [PATCH v4 0/4] Introduce new performance test
> application
>
...
>
> Declan D
On 1/25/2017 3:29 PM, Ferruh Yigit wrote:
> On 1/24/2017 5:28 PM, Thomas Monjalon wrote:
>> 2017-01-24 20:07, Hemant Agrawal:
>>> On 1/24/2017 4:19 PM, Ferruh Yigit wrote:
On 1/24/2017 9:12 AM, Shreyansh Jain wrote:
> On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
>> On 1/23/2
On 1/24/2017 5:28 PM, Thomas Monjalon wrote:
> 2017-01-24 20:07, Hemant Agrawal:
>> On 1/24/2017 4:19 PM, Ferruh Yigit wrote:
>>> On 1/24/2017 9:12 AM, Shreyansh Jain wrote:
On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
> On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
>> +# lib
On Wed, Jan 25, 2017 at 01:34:47PM +, Shreyansh Jain wrote:
>
>
> > -Original Message-
> > From: Neil Horman [mailto:nhor...@tuxdriver.com]
> > Sent: Wednesday, January 25, 2017 5:53 PM
> > To: Thomas Monjalon
> > Cc: Hemant Agrawal ; Ferruh Yigit
> > ; Shreyansh Jain ;
> > dev@dpdk.
2017-01-25 13:53, Van Haaren, Harry:
> There was an idea (from Thomas) to better document the Acked-by and
> Reviewed-By in the above thread, which I think is worth doing to make the
> process clearer. I'll kick off a thread*, and offer to submit a patch for the
> documentation when a consensus
On Wed, Jan 25, 2017 at 01:54:04PM +, Bruce Richardson wrote:
> On Wed, Jan 25, 2017 at 02:20:52PM +0100, Olivier MATZ wrote:
> > On Wed, 25 Jan 2017 12:14:56 +, Bruce Richardson
> > wrote:
> > > Hi all,
> > >
> > > while looking at the rte_ring code, I'm wondering if we can simplify
> >
On 1/25/2017 1:42 AM, Dai, Wei wrote:
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dai, Wei
>> Sent: Wednesday, January 25, 2017 9:40 AM
>> To: Yuanhan Liu ; Yi Zhang
>>
>> Cc: Zhang, Helin ; Ananyev, Konstantin
>> ; dev@dpdk.org; Lu, Wenzhuo
>>
>> Subject
On 25/01/2017 14:31, Thomas Monjalon wrote:
2017-01-25 14:02, Remy Horton:
[..]
Self-NAK: Condition is now tautology on code path that was causing crashes
What do you mean exactly?
There is an if(rte_eal_process_type() == RTE_PROC_PRIMARY) in a calling
function, so the one my patch was in
The rte_eth_dev_stop function is not called if the port_status is
not RTE_PORT_STARTED. This can happen if the rte_eth_dev_start
function is called directly, ie not through the start_port function.
Make sure rte_eth_dev_stop is always called in stop_port function.
Fixes: ce8d561418d4 ("app/testpm
Change the order of releasing the vsi's.
Release the vmdq vsi's first, then release the main vsi.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
CC: sta...@dpdk.org
Signed-off-by: Bernard Iremonger
Acked-by: Jingjing Wu
---
drivers/net/i40e/i40e_ethdev.c | 14 --
1 file change
Add the following command to configure VMDq:
port config vmdq
Add the following command to set number of pools:
set nbpool
Add new commands to testpmd user guide.
Signed-off-by: Bernard Iremonger
---
app/test-pmd/cmdline.c | 72 -
app/test-pmd/config.c
Changes in v5:
Rebase to latest dpdk-next-net
Reworked init_port_vmdq_config() function in testpmd.
Added patch 3, fix to stop_port() function in testpmd.
Changes in v4:
Rebase to latest dpdk-next-net
Replaced I40E_ERR_BAD_PTR with -EFAULT.
Changes in v3
Fix checkpatch warning in testpmd.c
Tidy
Add documentation to describe using the new performance test application.
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Piotr Azarewicz
---
v4 changes:
- split the documentation to separate patch
---
doc/guides/rel_notes/release_17_02.rst | 5 +
doc/guides/tools/cryptoperf.rst| 397
Add test vectors example files to the performance test application.
Signed-off-by: Marcin Kerlin
---
v4 changes:
- split the test vectors files to separate patch
---
app/test-crypto-perf/data/aes_cbc_128_sha.data | 503
app/test-crypto-perf/data/aes_cbc_192_sha.data | 50
2017-01-25 14:02, Remy Horton:
>
> On 24/01/2017 15:01, Remy Horton wrote:
> > Secondary processes were blanket zeroing ethernet device memory,
> > resulting in NULL dereference crashes in multi-process setups.
> >
> > Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
> >
> > Signe
This patch adds helper functions for new performance application which
provide identifiers and number of crypto device and
provide and check capabilities available for defined device and algorithm.
The performance application can be used to measure throughput and latency
of cryptography operation p
This patchset introduce new application which allows measuring
performance parameters of PMDs available in crypto tree. The goal of
this application is to replace existing performance tests in app/test.
Parameters available are: throughput (--ptest throughput) and latency
(--ptest latency). User ca
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Tuesday, January 24, 2017 4:30 PM
> To: Zhang, Roy Fan; dev@dpdk.org
> Cc: Doherty, Declan
> Subject: Re: [dpdk-dev] [PATCH v7 00/11] crypto/scheduler: add driver for
> scheduler cr
> -Original Message-
> From: Zhang, Roy Fan
> Sent: Wednesday, January 25, 2017 10:59 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH v2] maintainers: add crypto scheduler PMD maintainer
>
> Signed-off-by: Fan Zhang
Applied to dpdk-next-crypto.
Thanks,
Pablo
On 24/01/2017 15:01, Remy Horton wrote:
Secondary processes were blanket zeroing ethernet device memory,
resulting in NULL dereference crashes in multi-process setups.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Signed-off-by: Remy Horton
Self-NAK: Condition is now tau
On 1/24/2017 7:06 PM, Qi Zhang wrote:
> When no error reported in Rx descriptor, we should set
> CKSUM_GOOD flag before return.
>
> Fixes: 9966a00a0688 ("net/i40e: enable bad checksum flags in vector Rx")
>
> Signed-off-by: Qi Zhang
Cc: sta...@dpdk.org
Applied to dpdk-next-net/master, thanks.
On Wed, Jan 25, 2017 at 02:20:52PM +0100, Olivier MATZ wrote:
> On Wed, 25 Jan 2017 12:14:56 +, Bruce Richardson
> wrote:
> > Hi all,
> >
> > while looking at the rte_ring code, I'm wondering if we can simplify
> > that a bit by removing some of the code it in that may not be used.
> > Specif
( Was [dpdk-dev] [PATCH v4] ethdev: fix MAC address replay, CC-ed are
participants of that thread
http://dpdk.org/ml/archives/dev/2017-January/056278.html )
Hi All,
There was an idea (from Thomas) to better document the Acked-by and Reviewed-By
in the above thread, which I think is worth doi
On Wed, Jan 25, 2017 at 01:34:47PM +, Shreyansh Jain wrote:
>
>
> > -Original Message-
> > From: Neil Horman [mailto:nhor...@tuxdriver.com]
> > Sent: Wednesday, January 25, 2017 5:53 PM
> > To: Thomas Monjalon
> > Cc: Hemant Agrawal ; Ferruh Yigit
> > ; Shreyansh Jain ;
> > dev@dpdk.
> -Original Message-
> From: Neil Horman [mailto:nhor...@tuxdriver.com]
> Sent: Wednesday, January 25, 2017 5:53 PM
> To: Thomas Monjalon
> Cc: Hemant Agrawal ; Ferruh Yigit
> ; Shreyansh Jain ;
> dev@dpdk.org; bruce.richard...@intel.com; john.mcnam...@intel.com;
> jerin.ja...@caviumnetw
On Wed, 25 Jan 2017 12:14:56 +, Bruce Richardson
wrote:
> Hi all,
>
> while looking at the rte_ring code, I'm wondering if we can simplify
> that a bit by removing some of the code it in that may not be used.
> Specifically:
>
> * Does anyone use the NIC stats functionality for debugging? I'
On Wednesday 25 January 2017 06:07 PM, Neil Horman wrote:
On Tue, Jan 24, 2017 at 02:39:56PM +, Shreyansh Jain wrote:
Hello,
We are facing a peculiar problem with respect to symbol namespace in DPDK. I
think Ferruh and Thomas would have fair idea about it as they have already
reviewed and c
Query the link status can ends up in an inconsist state where the port is
down but it is reporting speed. For that another query is sceduled for a
later time.
A race condition is possible between the scheduled call and the next
link status interrupt from the device. On some sceraios it will cause t
Trying to query the link status through new kernel ioctl API
ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
The bug was fixed on version 4.9
this patch uses the legacy ioctl API for lower kernels.
Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
CC: sta...@dpdk.org
On Tue, Jan 24, 2017 at 02:39:56PM +, Shreyansh Jain wrote:
> Hello,
>
> We are facing a peculiar problem with respect to symbol namespace in DPDK. I
> think Ferruh and Thomas would have fair idea about it as they have already
> reviewed and commented on it. I was hoping to get some input to t
On Tue, Jan 24, 2017 at 06:28:59PM +0100, Thomas Monjalon wrote:
> 2017-01-24 20:07, Hemant Agrawal:
> > On 1/24/2017 4:19 PM, Ferruh Yigit wrote:
> > > On 1/24/2017 9:12 AM, Shreyansh Jain wrote:
> > >> On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
> > >>> On 1/23/2017 11:59 AM, Hemant A
On 1/18/2017 5:49 PM, Ferruh Yigit wrote:
<...>
>>>
>>
>> OK for these definitions, however API documentation
>> (doc/guides/prog_guide/rte_flow.rst) must be kept up to date, and it
>> would be great if testpmd support for these new items was added
>> simultaneously (change
On Wed, Jan 25, 2017 at 12:14:56PM +, Bruce Richardson wrote:
> Hi all,
>
> while looking at the rte_ring code, I'm wondering if we can simplify
> that a bit by removing some of the code it in that may not be used.
> Specifically:
>
> * Does anyone use the NIC stats functionality for debuggin
On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
>
> Signed-off-by: Emmanuel Roullit
> ---
> drivers/net/cxgbe/sge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/cxgbe/sge.c b/drivers/
Hi all,
while looking at the rte_ring code, I'm wondering if we can simplify
that a bit by removing some of the code it in that may not be used.
Specifically:
* Does anyone use the NIC stats functionality for debugging? I've
certainly never seen it used, and it's presence makes the rest less
On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> Found with clang static analysis:
> drivers/net/cxgbe/sge.c:900:3: warning:
> Value stored to 'in_use' is never read
> in_use += q->size;
> ^ ~~~
>
> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
On 25/01/2017 11:56, Thomas Monjalon wrote:
[..]
It does not describe exactly the use-case it is fixing (same in commit message).
I guess you saw an issue when creating a vdev in the primary process and
another one in a secondary process, erasing the data of the first one.
In my use-case the s
On 1/24/2017 9:15 PM, Emmanuel Roullit wrote:
> Found with clang static analysis:
> drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
> warning: Value stored to 'num_not_send' is never read
> num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
> ^ ~~~
On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> data value could have been garbage if VPD access timed out for VPD read
> request could not been issued.
>
> Found with clang static analysis:
> drivers/net/cxgbe/base/t4_hw.c:1577:22:
> warning: The left operand of '&' is a garbage value
> }
2017-01-24 15:01, Remy Horton:
> Secondary processes were blanket zeroing ethernet device memory,
> resulting in NULL dereference crashes in multi-process setups.
>
> Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
>
> Signed-off-by: Remy Horton
> ---
> doc/guides/rel_notes/re
Hello Ferruh,
On Tuesday 24 January 2017 09:54 PM, Ferruh Yigit wrote:
On 1/24/2017 2:39 PM, Shreyansh Jain wrote:
Hello,
We are facing a peculiar problem with respect to symbol namespace in DPDK. I
think Ferruh and Thomas would have fair idea about it as they have already
reviewed and comment
When RTE_EFD_VALUE_NUM_BITS is 32, there was a compilation issue
because of an overflow:
app/test/test_efd.c:157:55: error: overflow in expression;
result is 2147483647 with type 'int' [-Werror,-Winteger-overflow]
data[0] = mrand48() & ((1 << RTE_EFD_VALUE_NUM_BITS) - 1);
This commit fixe
2017-01-23 13:06, Ananyev, Konstantin:
>
> > -Original Message-
> > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
> > Sent: Monday, January 23, 2017 12:53 PM
> > To: Ananyev, Konstantin
> > Cc: Yigit, Ferruh ; dev@dpdk.org; Thomas Monjalon
> > ; Horton, Remy
> >
> > Subject: Re
Signed-off-by: Fan Zhang
---
v2:
Changed the name of the PMD in the MAINTAINERS file
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f071138..5881bcd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -469,6 +469,11 @@ M: Declan Doherty
F: driver
2017-01-24 13:21, Ferruh Yigit:
> On 1/24/2017 10:09 AM, Igor Ryzhov wrote:
> > Thank you Steve.
> >
>
> > I never did it before and I don't know if I have rights for that, but:
> >
> > Acked-by: Igor Ryzhov mailto:iryz...@nfware.com>>
>
> Unrelated to the patch itself, but since it has been me
2017-01-24 22:04, Emmanuel Roullit:
> Found with clang build:
> error: taking address of packed member 'mlock' of class or structure
> 'rte_mem_config' may result in an unaligned pointer value
> [-Werror,-Waddress-of-packed-member]
>
> Fixes: 29361d4c91ed ("mk: fix build with clang < 3.5")
> Fixes
> -Original Message-
> From: Wiles, Keith
> Sent: Wednesday, January 25, 2017 3:40 AM
> To: Stephen Hemminger
> Cc: Ananyev, Konstantin ; Hu, Jiayu
> ; dev@dpdk.org; Kinsella, Ray
> ; Gilmore, Walter E ;
> Venkatesan, Venky ;
> yuanhan@linux.intel.com
> Subject: Re: [dpdk-dev] [RFC
> -Original Message-
> From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com]
> Sent: Wednesday, January 25, 2017 4:48 AM
> To: dev@dpdk.org
> Cc: Hemant Agrawal; thomas.monja...@6wind.com; Doherty, Declan; De
> Lara Guarch, Pablo; jblu...@infradead.org
> Subject: Re: [PATCH] cryptodev: dec
63 matches
Mail list logo
