Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior

2017-01-20 Thread Yang, Zhiyong
From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Friday, January 20, 2017 6:26 PM To: Yang, Zhiyong ; dev@dpdk.org Cc: thomas.monja...@6wind.com; Richardson, Bruce ; Ananyev, Konstantin Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior On 01/20/201

Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior

2017-01-20 Thread Yang, Zhiyong
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, January 20, 2017 7:25 PM > To: Andrew Rybchenko ; Yang, Zhiyong > ; dev@dpdk.org > Cc: thomas.monja...@6wind.com; Richardson, Bruce > > Subject: RE: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching > behavior > >

Re: [dpdk-dev] [PATCH] igb_uio: use non-threaded ISR

2017-01-20 Thread Stephen Hemminger
On Fri, 20 Jan 2017 15:08:19 -0800 David Su wrote: > This eliminates the overhead of a task switch when an interrupt arrives. > > Signed-off-by: David Su > --- > lib/librte_eal/linuxapp/igb_uio/igb_uio.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/lib/librt

[dpdk-dev] [PATCH] net/ixgbe: keep interrupt throttling disabled

2017-01-20 Thread David Su
The code being removed would enable time-based interrupt throttling for the first MSI-X interrupt vector. This would throttle link status change interrupts for NICs bound to vfio_pci driver; but for igb_uio driver, rx queue 0 interrupts would be throttled. This resulted in inconsistent latencies

[dpdk-dev] [PATCH] igb_uio: use non-threaded ISR

2017-01-20 Thread David Su
This eliminates the overhead of a task switch when an interrupt arrives. Signed-off-by: David Su --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/i

[dpdk-dev] [PATCH v2] ethdev: fix MAC address replay

2017-01-20 Thread Steve Shin
This patch fixes a bug in replaying MAC address to the hardware in rte_eth_dev_config_restore() routine. Added default MAC replay as well. Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements") --- v2: Added default MAC replay & Code optimization Signed-off-by: Steve Shin --- lib/librte_ether/rte_e

Re: [dpdk-dev] drops while transmitting to the kni using rte_kni_tx_burst()

2017-01-20 Thread Jason Kwon
Sorry to hijack the thread, but I was wondering, is the binding of the KNI kernel thread only applicable in multiple kthread mode? Does it apply in single kernel thread mode? Looking at the 16.07.2 source, I saw the following: /** * Create a new kernel thread for multiple mode,

Re: [dpdk-dev] [PATCH v3 03/10] crypto/dpaa2_sec: add dpaa2_sec poll mode driver

2017-01-20 Thread Neil Horman
On Fri, Jan 20, 2017 at 06:47:49PM +0530, Akhil Goyal wrote: > On 1/20/2017 6:02 PM, Neil Horman wrote: > > On Fri, Jan 20, 2017 at 07:35:02PM +0530, akhil.go...@nxp.com wrote: > > > From: Akhil Goyal > > > > > > Signed-off-by: Hemant Agrawal > > > Signed-off-by: Akhil Goyal > > > --- > > > co

Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address replay

2017-01-20 Thread Steve Shin (jonshin)
Dear Igor, That makes sense to use mac_addr_set() for default MAC address replay. As default MAC is kept in dev->data->mac_addrs[0], we may not need to create a separate variable for default one. Will run some unit test with new change and upload a new diff for your review. FYI: Ferruh recommen

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix Rx packet validation and type

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 4:48 PM, Adrien Mazarguil wrote: > On Fri, Jan 20, 2017 at 04:27:29PM +0100, Nelio Laranjeiro wrote: >> Rx checksum validation and packet type offloads are read from the wrong >> location. >> >> Fixes: 501505c5608a ("net/mlx: fix IPv4 and IPv6 packet type") >> Fixes: 350f4c482e46 ("net

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix flow API mark combined with drop

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 4:47 PM, Adrien Mazarguil wrote: > On Fri, Jan 20, 2017 at 04:27:28PM +0100, Nelio Laranjeiro wrote: >> Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") >> >> Signed-off-by: Nelio Laranjeiro >> --- >> drivers/net/mlx5/mlx5_flow.c | 5 +++-- >> 1 file changed, 3 insertions(+

Re: [dpdk-dev] [PATCH] net/mlx5: fix queue wrap-around of multi-packet send

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 4:56 PM, Adrien Mazarguil wrote: > On Tue, Jan 17, 2017 at 04:51:55PM -0800, Yongseok Koh wrote: >> When the WQ is wrapped around, it wrongly checks the condition when >> resetting the pointer. It should be compared against the end of the queue, >> not the beginning of the queue. And t

Re: [dpdk-dev] [PATCH] net/mlx5: add prefetching Rx completion queue

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 4:56 PM, Adrien Mazarguil wrote: > On Mon, Jan 16, 2017 at 06:09:40PM -0800, Yongseok Koh wrote: >> On receiving a compressed session of Rx completion, prefetch every entries >> to be invalidated. Also, invalidate consumed completions per every 8 >> mini-completions, not to wait until

Re: [dpdk-dev] [PATCH v2] net/mlx5: lift Rx RSS indirection table size limit

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 4:57 PM, Adrien Mazarguil wrote: > On Tue, Jan 17, 2017 at 04:39:29PM -0800, Yongseok Koh wrote: >> The size of Rx RSS indirection table was limited by 256, but it is not >> required anymore for all Mellanox NICs. However, the librte_ether still >> limits the size by 512. >> >> Signed-

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix Rx checksum flag

2017-01-20 Thread Ferruh Yigit
On 1/19/2017 5:39 AM, Xiao Wang wrote: > When no error reported in Rx descriptor, we should set CKSUM_GOOD flag > before return. > > Fixes: b704f9071b09 ("net/i40e: implement new Rx checksum flag") CC: sta...@dpdk.org > > Signed-off-by: Xiao Wang Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-20 Thread Thomas Monjalon
2017-01-11 02:42, Remy Horton: > +* **ethdev: Fixed crash with multi-processing.** > + > + Even though only primary processes should setup PMDs, secondary > + processes were also blanket zeroing ethernet device memory. The > + result was NULL dereference crashes in multi-process setups. > + 3 c

Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset

2017-01-20 Thread Thomas Monjalon
2017-01-20 18:34, Yuanhan Liu: > On Fri, Jan 20, 2017 at 11:20:06AM +0100, Thomas Monjalon wrote: > > 2017-01-20 16:04, Yuanhan Liu: > > > Fix an silly error by auto-complete while managing the merge conflicts. > > > It's the eth_dev_data (but not eth_dev) entry should be memset. > > > > > > Fixes

Re: [dpdk-dev] [PATCH] net/i40e: no more initial VF MAC address

2017-01-20 Thread Ferruh Yigit
On 1/18/2017 1:45 AM, Qi Zhang wrote: > During PF initialization, PF will generate an initial mac > address for VFs, the purpose is to help VF keep a constant > mac address between startup/shutdown cycles. I believe below does not provide permanent MAC address, PF assign a random mac address to i

Re: [dpdk-dev] [PATCH] net/tap: fix IFF_MULTI_QUEUE in older kernels not found

2017-01-20 Thread Thomas Monjalon
2017-01-20 16:11, Ferruh Yigit: > On 1/20/2017 2:30 PM, Keith Wiles wrote: > > Signed-off-by: Keith Wiles > > Reviewed-by: Ferruh Yigit > > Hi Thomas, > > Although this is a driver patch, would you mind getting it to the main > tree to fix build error asap (instead of waiting next integration)

[dpdk-dev] RX/TX call back

2017-01-20 Thread Sridhar Pitchai
Hi, I am trying to implement IP pipeline for the slowpath (punt to CPU path) for a forwarding vendor chip. I have a TX/RX call back registered for packets punted to CPU from the vendor chip. I want to implement a driver which will be putting the packet into the dpdk eth RX/TX ring buffer.

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix interrupt block issue

2017-01-20 Thread Ferruh Yigit
On 1/16/2017 7:23 PM, Qi Zhang wrote: > When handle link status change interrupt, interrupt > will be blocked until delayed handler finish, the > duration is at least 1 second, this may cause following > VF to PF mailbox traffic be blocked and sometimes PF > can't ack to VF in time before VF think

Re: [dpdk-dev] [PATCH] net/mlx5: add prefetching Rx completion queue

2017-01-20 Thread Adrien Mazarguil
On Mon, Jan 16, 2017 at 06:09:40PM -0800, Yongseok Koh wrote: > On receiving a compressed session of Rx completion, prefetch every entries > to be invalidated. Also, invalidate consumed completions per every 8 > mini-completions, not to wait until the last entry is consumed. This helps > to reduce

Re: [dpdk-dev] [PATCH v2] net/mlx5: lift Rx RSS indirection table size limit

2017-01-20 Thread Adrien Mazarguil
On Tue, Jan 17, 2017 at 04:39:29PM -0800, Yongseok Koh wrote: > The size of Rx RSS indirection table was limited by 256, but it is not > required anymore for all Mellanox NICs. However, the librte_ether still > limits the size by 512. > > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5

Re: [dpdk-dev] [PATCH] net/mlx5: fix queue wrap-around of multi-packet send

2017-01-20 Thread Adrien Mazarguil
On Tue, Jan 17, 2017 at 04:51:55PM -0800, Yongseok Koh wrote: > When the WQ is wrapped around, it wrongly checks the condition when > resetting the pointer. It should be compared against the end of the queue, > not the beginning of the queue. And this isn't even needed when the length > of the copy

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix flow API mark combined with drop

2017-01-20 Thread Adrien Mazarguil
On Fri, Jan 20, 2017 at 04:27:28PM +0100, Nelio Laranjeiro wrote: > Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") > > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Acked-by: Adrien Mazarguil -- A

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix Rx packet validation and type

2017-01-20 Thread Adrien Mazarguil
On Fri, Jan 20, 2017 at 04:27:29PM +0100, Nelio Laranjeiro wrote: > Rx checksum validation and packet type offloads are read from the wrong > location. > > Fixes: 501505c5608a ("net/mlx: fix IPv4 and IPv6 packet type") > Fixes: 350f4c482e46 ("net/mlx5: fix Rx checksum macros") > Fixes: 6218063b39a

Re: [dpdk-dev] [PATCH] devtools: check stable tag in fixes

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 10:23 AM, Yuanhan Liu wrote: > On Fri, Jan 20, 2017 at 11:10:54AM +0100, Thomas Monjalon wrote: >> 2017-01-20 15:59, Yuanhan Liu: >>> On Thu, Jan 19, 2017 at 12:00:23PM +, Ferruh Yigit wrote: To highlight, and double check, the process will be updated as following: -

[dpdk-dev] [PATCH v5 6/6] doc: distributor library changes for new burst API

2017-01-20 Thread David Hunt
Signed-off-by: David Hunt --- doc/guides/prog_guide/packet_distrib_lib.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/prog_guide/packet_distrib_lib.rst b/doc/guides/prog_guide/packet_distrib_lib.rst index b5bdabb..dffd4ad 100644 --- a/doc/guides/prog_guide/packet_distrib_

[dpdk-dev] [PATCH v5 0/6] distributor library performance enhancements

2017-01-20 Thread David Hunt
This patch aims to improve the throughput of the distributor library. It uses a similar handshake mechanism to the previous version of the library, in that bits are used to indicate when packets are ready to be sent to a worker and ready to be returned from a worker. One main difference is that in

[dpdk-dev] [PATCH v5 4/6] test: add distributor perf autotest

2017-01-20 Thread David Hunt
Signed-off-by: David Hunt --- app/test/test_distributor_perf.c | 150 +++ 1 file changed, 138 insertions(+), 12 deletions(-) diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c index 7947fe9..9132010 100644 --- a/app/test/test_dist

[dpdk-dev] [PATCH v5 5/6] examples/distributor_app: showing burst API

2017-01-20 Thread David Hunt
Signed-off-by: David Hunt --- examples/distributor/main.c | 509 ++-- 1 file changed, 391 insertions(+), 118 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index e7641d2..4c134d5 100644 --- a/examples/distributor/main.c

[dpdk-dev] [PATCH v5 2/6] lib: add distributor vector flow matching

2017-01-20 Thread David Hunt
Signed-off-by: David Hunt --- lib/librte_distributor/Makefile| 7 ++ lib/librte_distributor/rte_distributor_burst.c | 12 ++- lib/librte_distributor/rte_distributor_burst.h | 6 +- .../rte_distributor_match_generic.c| 43 lib/librte_distr

[dpdk-dev] [PATCH v5 1/6] lib: distributor performance enhancements

2017-01-20 Thread David Hunt
Now sends bursts of up to 8 mbufs to each worker, and tracks the in-flight flow-ids (atomic scheduling) New file with a new api, similar to the old API except with _burst at the end of the function names. This is to preserve the original API (and code) for backward compatibility. It uses a simila

[dpdk-dev] [PATCH v5 3/6] test: unit tests for new distributor burst API

2017-01-20 Thread David Hunt
Signed-off-by: David Hunt --- app/test/test_distributor.c | 501 ++-- 1 file changed, 392 insertions(+), 109 deletions(-) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 85cb8f3..3871f86 100644 --- a/app/test/test_distributor.c

Re: [dpdk-dev] [PATCH] net/tap: fix IFF_MULTI_QUEUE in older kernels not found

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 2:30 PM, Keith Wiles wrote: > Signed-off-by: Keith Wiles Reviewed-by: Ferruh Yigit Hi Thomas, Although this is a driver patch, would you mind getting it to the main tree to fix build error asap (instead of waiting next integration)? Thanks, ferruh

[dpdk-dev] [PATCH v3 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-01-20 Thread Billy McFall
Add a new API to force free consumed buffers on Tx ring. API will return the number of packets freed (0-n) or error code if feature not supported (-ENOTSUP) or input invalid (-ENODEV). Signed-off-by: Billy McFall --- lib/librte_ether/rte_ethdev.c | 14 ++ lib/librte_ether/rte_ethdev.

[dpdk-dev] [PATCH v3 2/3] net/e1000: e1000 igb support to free consumed buffers

2017-01-20 Thread Billy McFall
Add support to the e1000 igb driver for the new API to force free consumed buffers on Tx ring. e1000 igb driver does not implement a tx_rs_thresh to free mbufs, it frees a slot in the ring as needed, so a new function needed to be written. Signed-off-by: Billy McFall --- drivers/net/e1000/e1000_

[dpdk-dev] [PATCH v3 3/3] net/vhost: vHost support to free consumed buffers

2017-01-20 Thread Billy McFall
Add support to the vHostdriver for the new API to force free consumed buffers on Tx ring. vHost does not cache the mbufs so there is no work to do. Signed-off-by: Billy McFall --- drivers/net/vhost/rte_eth_vhost.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/vhost

[dpdk-dev] [PATCH v3 0/3] new API to free consumed buffers in Tx ring

2017-01-20 Thread Billy McFall
Based on a request from Damjan Marion and seconded by Keith Wiles, see dpdk-dev mailing list from 11/21/2016, add a new API to free consumed buffers on TX ring. This addresses two scenarios: 1) Flooding a packet and want to reuse existing mbuf to avoid a packet copy. Increment the reference count o

Re: [dpdk-dev] [PATCH v2 3/3] net/vhost: vHost support to free consumed buffers

2017-01-20 Thread Billy McFall
rte_eth_tx_done_cleanup(..) checks to see if .tx_done_cleanup is set, so in that since it is optional. The reason for this function does no work and returns 0 is to indicate to the application calling it that the mbufs are free and the application can continue. The application needs to know if the

[dpdk-dev] [PATCH 1/2] net/mlx5: fix flow API mark combined with drop

2017-01-20 Thread Nelio Laranjeiro
Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index d7ed686..7b97a61 100644 --- a/dri

Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 11:21 AM, Ferruh Yigit wrote: > On 1/20/2017 8:04 AM, Yuanhan Liu wrote: >> Fix an silly error by auto-complete while managing the merge conflicts. >> It's the eth_dev_data (but not eth_dev) entry should be memset. >> >> Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multipl

[dpdk-dev] [PATCH 2/2] net/mlx5: fix Rx packet validation and type

2017-01-20 Thread Nelio Laranjeiro
Rx checksum validation and packet type offloads are read from the wrong location. Fixes: 501505c5608a ("net/mlx: fix IPv4 and IPv6 packet type") Fixes: 350f4c482e46 ("net/mlx5: fix Rx checksum macros") Fixes: 6218063b39a6 ("net/mlx5: refactor Rx data path") Cc: sta...@dpdk.org Signed-off-by: Neli

[dpdk-dev] [PATCH v3] net/sfc: enable TSO by default

2017-01-20 Thread Andrew Rybchenko
Remove RTE_LIBRTE_SFC_EFX_TSO config option since it is not required any more: - unreasonable limit on number of Tx queues when TSO is not actually required should be solved using per-device parameter - performance difference with and without TSO compiled in is small Signed-off-by: Andrew Ryb

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: add command to configure VMDq

2017-01-20 Thread Iremonger, Bernard
Hi Jingjing, > > Subject: [PATCH v4 2/2] app/testpmd: add command to configure VMDq > > > > Add the following command to configure VMDq: > > port config vmdq > > > > Add new command to testpmd user guide. > > > > Signed-off-by: Bernard Iremonger > > --- > > app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v2] mempool: Introduce _populate_mz_range api

2017-01-20 Thread santosh.shukla
From: Santosh Shukla HW pool manager e.g. Cavium SoC need s/w to program start and end address of pool. Currently there is no such api in ext-mempool. So introducing _populate_mz_range API which will let HW(pool manager) know about hugepage mapped virtual start and end address. Signed-off-by: Sa

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter

2017-01-20 Thread Thomas Monjalon
2017-01-20 02:14, Lu, Wenzhuo: > Hi Adrien, Thomas, Yong, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Friday, January 20, 2017 2:46 AM > > To: Thomas Monjalon > > Cc: Liu, Yong; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] net/sfc: enable TSO by default

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 2:37 PM, Andrew Rybchenko wrote: > On 01/20/2017 05:29 PM, Thomas Monjalon wrote: >> 2017-01-19 15:52, Andrew Rybchenko: >>> Signed-off-by: Andrew Rybchenko >>> --- >>> It is a mistake that TSO support is compiled out by default. >>> We would be happy to enable it by deafult, but stri

Re: [dpdk-dev] [PATCH] net/sfc: enable TSO by default

2017-01-20 Thread Andrew Rybchenko
On 01/20/2017 05:29 PM, Thomas Monjalon wrote: 2017-01-19 15:52, Andrew Rybchenko: Signed-off-by: Andrew Rybchenko --- It is a mistake that TSO support is compiled out by default. We would be happy to enable it by deafult, but strictly speaking it is not a bug fix. Arguments to enable are: -

Re: [dpdk-dev] [PATCH] mempool: Introduce _populate_mz_range api

2017-01-20 Thread Jerin Jacob
On Fri, Jan 20, 2017 at 07:50:17PM +0530, santosh.shu...@caviumnetworks.com wrote: > From: Santosh Shukla > > +/* > + * wrapper to populate mz's pa/va addr range and len info to external > + * mempool. HW mempool implementation to cache-in this inforamation > + * in their local data structure.

Re: [dpdk-dev] FW: [PATCH v7] app/testpmd: supported offload capabilities query

2017-01-20 Thread Thomas Monjalon
2017-01-20 02:04, Yang, Qiming: > Hi, Thomas > Does this patch be forget? Or still have something need to amend? Yes it has been forgotten in RC1. RC2 should contain this kind of patches.

[dpdk-dev] [PATCH] net/tap: fix IFF_MULTI_QUEUE in older kernels not found

2017-01-20 Thread Keith Wiles
Signed-off-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index d5e2fc3..cb96e99 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -139,

Re: [dpdk-dev] [PATCH] net/sfc: enable TSO by default

2017-01-20 Thread Thomas Monjalon
2017-01-19 15:52, Andrew Rybchenko: > Signed-off-by: Andrew Rybchenko > --- > It is a mistake that TSO support is compiled out by default. > We would be happy to enable it by deafult, but strictly speaking > it is not a bug fix. > > Arguments to enable are: > - be more feature-rich (and user-fri

[dpdk-dev] [PATCH] net/tap: fix IFF_MULTI_QUEUE in older kernels not found

2017-01-20 Thread Keith Wiles
Signed-off-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index d5e2fc3..5cf9831 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -139,

[dpdk-dev] [PATCH] mempool: Introduce _populate_mz_range api

2017-01-20 Thread santosh.shukla
From: Santosh Shukla HW pool manager e.g. Cavium SoC need s/w to program start and end address of pool. Currently there is no such api in ext-mempool. So introducing _populate_mz_range API which will let HW(pool manager) know about hugepage mapped virtual start and end address. Signed-off-by: Sa

Re: [dpdk-dev] [PATCHv5 13/33] net/dpaa2: introducing NXP dpaa2 pmd driver

2017-01-20 Thread Shreyansh Jain
Hello Ferruh, On Friday 20 January 2017 12:45 AM, Ferruh Yigit wrote: On 1/19/2017 1:23 PM, Hemant Agrawal wrote: add support for fsl-mc bus based dpaa2 pmd driver. Signed-off-by: Hemant Agrawal <...> diff --git a/drivers/common/Makefile b/drivers/common/Makefile index e5bfecb..76ec2d1 10

[dpdk-dev] [PATCH 1/2] net/sfc: use eal I/O device memory read/write API

2017-01-20 Thread Andrew Rybchenko
Use relaxed version of these functions to guarantee no changes on the step. Signed-off-by: Andrew Rybchenko --- Due to late stage when the API appears and small time for testing, I prefer conservative way: use relaxed version right now and cleanup neighbour rte_*mb() calls later with switching to

[dpdk-dev] [PATCH 2/2] net/sfc: use eal I/O device memory barriers API

2017-01-20 Thread Andrew Rybchenko
The previous version relied on the fact that DMA sync for device and PIO write barrier in pair. Now each does its job. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/efsys.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/e

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: add command to configure VMDq

2017-01-20 Thread Wu, Jingjing
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, January 18, 2017 12:39 AM > To: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing > ; Zhang, Helin > Cc: Iremonger, Bernard > Subject: [PATCH v4 2/2] app/testpmd: add command to configure VMDq > > Add the following command to co

Re: [dpdk-dev] [PATCH v3 03/10] crypto/dpaa2_sec: add dpaa2_sec poll mode driver

2017-01-20 Thread Akhil Goyal
On 1/20/2017 6:02 PM, Neil Horman wrote: On Fri, Jan 20, 2017 at 07:35:02PM +0530, akhil.go...@nxp.com wrote: From: Akhil Goyal Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- config/common_base | 8 + config/defconfig_arm64-dpaa2-linuxapp-gcc

Re: [dpdk-dev] [PATCH v4 1/2] net/i40e: fix segmentation fault in close

2017-01-20 Thread Wu, Jingjing
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, January 18, 2017 12:39 AM > To: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing > ; Zhang, Helin > Cc: Iremonger, Bernard ; sta...@dpdk.org > Subject: [PATCH v4 1/2] net/i40e: fix segmentation fault in close > > Change the orde

Re: [dpdk-dev] [PATCH v2] net/sfc: do not panic if alarms are not supported

2017-01-20 Thread Andrew Rybchenko
On 01/20/2017 03:36 PM, Ferruh Yigit wrote: On 1/19/2017 11:12 AM, Andrew Rybchenko wrote: Alarms are not supported on the FreeBSD. Application must poll link status periodically itself using rte_eth_link_get_nowait() to avoid management event queue overflow. Fixes: 2de39f4e1310 ("net/sfc: peri

Re: [dpdk-dev] [PATCH v2] net/sfc: do not panic if alarms are not supported

2017-01-20 Thread Ferruh Yigit
On 1/19/2017 11:12 AM, Andrew Rybchenko wrote: > Alarms are not supported on the FreeBSD. > Application must poll link status periodically itself using > rte_eth_link_get_nowait() to avoid management event queue overflow. > > Fixes: 2de39f4e1310 ("net/sfc: periodic management EVQ polling using ala

Re: [dpdk-dev] [PATCH v3 03/10] crypto/dpaa2_sec: add dpaa2_sec poll mode driver

2017-01-20 Thread Neil Horman
On Fri, Jan 20, 2017 at 07:35:02PM +0530, akhil.go...@nxp.com wrote: > From: Akhil Goyal > > Signed-off-by: Hemant Agrawal > Signed-off-by: Akhil Goyal > --- > config/common_base | 8 + > config/defconfig_arm64-dpaa2-linuxapp-gcc | 12 + > drivers/bu

Re: [dpdk-dev] [PATCH] cryptodev: decouple from PCI device

2017-01-20 Thread De Lara Guarch, Pablo
Hi Hemant, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Thursday, January 19, 2017 1:28 PM > To: Hemant Agrawal; dev@dpdk.org > Cc: thomas.monja...@6wind.com; Richardson, Bruce; Shreyansh Jain; > Mcnamara, John; Yigit, Ferruh; jerin.ja.

Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address replay

2017-01-20 Thread Igor Ryzhov
Hello Steve, I think it's not the right solution, because if we want to restore default MAC address, it should be done using dev->dev_ops->mac_addr_set(), not using dev->dev_ops->mac_addr_add(). I think that right solution may be to store default MAC address in separate variable dev->data->defaul

Re: [dpdk-dev] [PATCH v12] net/tap: new TUN/TAP device PMD

2017-01-20 Thread Ferruh Yigit
On 12/13/2016 1:54 PM, Ferruh Yigit wrote: > On 12/12/2016 2:38 PM, Keith Wiles wrote: >> The PMD allows for DPDK and the host to communicate using a raw >> device interface on the host and in the DPDK application. The device >> created is a Tap device with a L2 packet header. >> >> v12- Fixup mino

Re: [dpdk-dev] [PATCH] mbuf: remove redundant line in rte_pktmbuf_attach

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 12:19 AM, Ilya Matveychikov wrote: > mi->next will be assigned to NULL few lines later, trivial patch > > Signed-off-by: Ilya V. Matveychikov > --- > lib/librte_mbuf/rte_mbuf.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_

Re: [dpdk-dev] [PATCHv5 06/33] bus/fslmc: add mc dpni object support

2017-01-20 Thread Hemant Agrawal
On 1/19/2017 10:44 PM, Thomas Monjalon wrote: 2017-01-19 18:53, Hemant Agrawal: This patch add support for dpni object support in MC driver. DPNI represent a network interface object in DPAA2. I really think you need to provide a design doc for this bus, event if it a collection of links to s

Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior

2017-01-20 Thread Bruce Richardson
On Fri, Jan 20, 2017 at 11:24:40AM +, Ananyev, Konstantin wrote: > > > > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > > Sent: Friday, January 20, 2017 10:26 AM > > To: Yang, Zhiyong ; dev@dpdk.org > > Cc: thomas.monja...@6wind.com; Richardson, Bruce > > ; Ananyev, Konstantin >

Re: [dpdk-dev] [PATCHv5 04/33] bus/fslmc: introducing fsl-mc bus driver

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 5:05 AM, Shreyansh Jain wrote: > On Friday 20 January 2017 12:38 AM, Ferruh Yigit wrote: >> On 1/19/2017 1:23 PM, Hemant Agrawal wrote: >>> The fslmc bus driver is a rte_bus driver which scans the fsl-mc bus >>> for NXP DPAA2 SoCs. >>> >>> Signed-off-by: Hemant Agrawal >>> --- >> >> <

Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior

2017-01-20 Thread Ananyev, Konstantin
> > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Friday, January 20, 2017 10:26 AM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: thomas.monja...@6wind.com; Richardson, Bruce > ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching > beh

Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 8:04 AM, Yuanhan Liu wrote: > Fix an silly error by auto-complete while managing the merge conflicts. > It's the eth_dev_data (but not eth_dev) entry should be memset. > > Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process > model") > > Reported-by: Ferruh Yi

Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset

2017-01-20 Thread Ferruh Yigit
On 1/20/2017 10:34 AM, Yuanhan Liu wrote: > On Fri, Jan 20, 2017 at 11:20:06AM +0100, Thomas Monjalon wrote: >> 2017-01-20 16:04, Yuanhan Liu: >>> Fix an silly error by auto-complete while managing the merge conflicts. >>> It's the eth_dev_data (but not eth_dev) entry should be memset. >>> >>> Fixe

Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset

2017-01-20 Thread Yuanhan Liu
On Fri, Jan 20, 2017 at 11:20:06AM +0100, Thomas Monjalon wrote: > 2017-01-20 16:04, Yuanhan Liu: > > Fix an silly error by auto-complete while managing the merge conflicts. > > It's the eth_dev_data (but not eth_dev) entry should be memset. > > > > Fixes: d948f596fee2 ("ethdev: fix port data mism

Re: [dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior

2017-01-20 Thread Andrew Rybchenko
On 01/20/2017 12:51 PM, Zhiyong Yang wrote: The rte_eth_tx_burst() function in the file Rte_ethdev.h is invoked to transmit output packets on the output queue for DPDK applications as follows. static inline uint16_t rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id, struct rt

[dpdk-dev] [RFC 2/2] prgdev: introduce generic prgdev API

2017-01-20 Thread Chen Jing D(Mark)
A new file to define prgdev API prototype and corresponding data structures. Signed-off-by: Chen Jing D(Mark) --- lib/librte_prgdev/rte_prgdev.h | 242 1 files changed, 242 insertions(+), 0 deletions(-) create mode 100644 lib/librte_prgdev/rte_prgdev.h

[dpdk-dev] [RFC 1/2] doc: introduction to prgdev

2017-01-20 Thread Chen Jing D(Mark)
This is the documentation to describe what prgdev is, how to use prgdev API and accomplish an image download. Signed-off-by: Chen Jing D(Mark) --- doc/guides/prog_guide/prgdev_lib.rst | 457 ++ 1 files changed, 457 insertions(+), 0 deletions(-) create mode 10064

[dpdk-dev] [RFC 0/2] Prgdev API

2017-01-20 Thread Chen Jing D(Mark)
This RFC patch intends to introduce an new abstraction layer API called prgdev to program programmable devices. Please refer to doc and API for details. Chen Jing D(Mark) (2): doc: introduction to prgdev prgdev: introduce generic prgdev API doc/guides/prog_guide/prgdev_lib.rst | 457 +++

Re: [dpdk-dev] [PATCH] devtools: check stable tag in fixes

2017-01-20 Thread Yuanhan Liu
On Fri, Jan 20, 2017 at 11:10:54AM +0100, Thomas Monjalon wrote: > 2017-01-20 15:59, Yuanhan Liu: > > On Thu, Jan 19, 2017 at 12:00:23PM +, Ferruh Yigit wrote: > > > To highlight, and double check, the process will be updated as following: > > > > > > - Author may or may not have "CC: sta...@d

Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset

2017-01-20 Thread Thomas Monjalon
2017-01-20 16:04, Yuanhan Liu: > Fix an silly error by auto-complete while managing the merge conflicts. > It's the eth_dev_data (but not eth_dev) entry should be memset. > > Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process > model") You should describe the impact on th

Re: [dpdk-dev] [PATCH] devtools: check stable tag in fixes

2017-01-20 Thread Thomas Monjalon
2017-01-20 15:59, Yuanhan Liu: > On Thu, Jan 19, 2017 at 12:00:23PM +, Ferruh Yigit wrote: > > To highlight, and double check, the process will be updated as following: > > > > - Author may or may not have "CC: sta...@dpdk.org" for fixes. > > > > - Maintainer/Committer may add "CC: sta...@dpd

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-20 Thread George Prekas
Nice to see that the community is finally interested in this bug. For the record, we have fixed this bug in our project (IX). Check out our kernel module here: https://github.com/ix-project/pcidma I will be interested to know when and how DPDK will resolve this situation so that we can actual

[dpdk-dev] [RFC] lib/librte_ether: consistent PMD batching behavior

2017-01-20 Thread Zhiyong Yang
The rte_eth_tx_burst() function in the file Rte_ethdev.h is invoked to transmit output packets on the output queue for DPDK applications as follows. static inline uint16_t rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id, struct rte_mbuf **tx_pkts, uint16_t nb_pkts); Note: The

[dpdk-dev] [PATCH v3 09/10] app/test: add dpaa2_sec crypto performance test

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- app/test/test_cryptodev_perf.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/app/test/test_cryptodev_perf.c b/app/test/test_cryptodev_perf.c index 7f1adf8..9cdbc39 100644 --- a/app/test/

Re: [dpdk-dev] [PATCH v1] doc: add guidelines on stable and lts releases

2017-01-20 Thread Yuanhan Liu
On Fri, Jan 13, 2017 at 01:06:22PM +, John McNamara wrote: > Add document explaining the current Stable and LTS process. John, great doc! Thanks. Here I got one more thing to discuss about the stable release: the release cycle. (I may better start a new thread, but I hope it would be a short

[dpdk-dev] [PATCH v3 10/10] app/test: add dpaa2_sec crypto functional test

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- app/test/test_cryptodev.c | 106 ++ app/test/test_cryptodev_blockcipher.c | 3 + app/test/test_cryptodev_blockcipher.h | 1 + 3 files changed, 110 insertions(+) diff --

[dpdk-dev] [PATCH v3 08/10] crypto/dpaa2_sec: update MAINTAINERS entry for dpaa2_sec pmd

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d79e1a5..c930b12 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -477,6 +477,12 @@ M: Declan Doherty F: drivers/crypto/null/ F: doc/guides/cryp

[dpdk-dev] [PATCH v3 07/10] crypto/dpaa2_sec: statistics support

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 76 + 1 file changed, 76 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 26ece22..c863bd0 10064

[dpdk-dev] [PATCH v3 06/10] crypto/dpaa2_sec: add crypto operation support

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 25 + drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1210 +++ drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 143 3 files changed, 1378 in

[dpdk-dev] [PATCH v3 01/10] doc: add NXP dpaa2_sec in cryptodev

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal Reviewed-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa2_sec.rst | 233 doc/guides/cryptodevs/index.rst | 1 + 2 files changed, 234 insertions(+) create mode 100644 doc/guides/cryptodevs/dpaa2_sec.rst

[dpdk-dev] [PATCH v3 03/10] crypto/dpaa2_sec: add dpaa2_sec poll mode driver

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- config/common_base | 8 + config/defconfig_arm64-dpaa2-linuxapp-gcc | 12 + drivers/bus/Makefile | 3 + drivers/common/Makefile

[dpdk-dev] [PATCH v3 02/10] cryptodev: add cryptodev type for dpaa2_sec

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal --- lib/librte_cryptodev/rte_cryptodev.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 0836273..2e9cc36 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++

[dpdk-dev] [PATCH v3 00/10] Introducing NXP dpaa2_sec based cryptodev pmd

2017-01-20 Thread akhil.goyal
From: Akhil Goyal Based over the DPAA2 PMD driver [1], this series of patches introduces the DPAA2_SEC PMD which provides DPDK crypto driver for NXP's DPAA2 CAAM Hardware accelerator. SEC is NXP DPAA2 SoC's security engine for cryptographic acceleration and offloading. It implements block encryp

[dpdk-dev] [PATCH] ethdev: fix wrong memset

2017-01-20 Thread Yuanhan Liu
Fix an silly error by auto-complete while managing the merge conflicts. It's the eth_dev_data (but not eth_dev) entry should be memset. Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model") Reported-by: Ferruh Yigit Signed-off-by: Yuanhan Liu --- lib/librte_ether/