[dpdk-dev] [PATCH v5 06/10] net/virtio: setup rxq interrupts

2017-01-16 Thread Jianfeng Tan
This patch mainly allocates structure to store queue/irq mapping, and configure queue/irq mapping down through PCI ops. It also creates eventfds for each Rx queue and tell the kernel about the eventfd/intr binding. Note: So far, we hard-code 1:1 queue/irq mapping (each rx queue has one exclusive i

Re: [dpdk-dev] [PATCH v5] crypto/aesni_gcm: migration from MB library to ISA-L

2017-01-16 Thread Azarewicz, PiotrX T
> 2017-01-16 13:37, Piotr Azarewicz: > > app/test/test_cryptodev.c| 753 > > +++--- > > app/test/test_cryptodev_gcm_test_vectors.h | 491 +- > > devtools/test-build.sh |4 +- > > doc/guides/cryptodevs/aesni_

Re: [dpdk-dev] [PATCH v7 5/6] lib: added new library for latency stats

2017-01-16 Thread Jerin Jacob
On Tue, Jan 17, 2017 at 06:48:30AM +, Remy Horton wrote: > > On 17/01/2017 04:29, Jerin Jacob wrote: > [..] > > It is a value added feature for DPDK. But what is the plan for incorporating > > the mbuf change? I have 8 month old mbuf change for ARM for natural > > alignment. If we are acceptin

Re: [dpdk-dev] [PATCH v6 8/8] eal: enable hotplugging of devices on bus

2017-01-16 Thread Shreyansh Jain
On Monday 16 January 2017 09:08 PM, Shreyansh Jain wrote: Given a bus, attach and detach callbacks allow the implementation to handles calls from EAL for attaching or detaching a named device. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 + lib/librte_eal/comm

[dpdk-dev] [PATCH v4 29/29] net/vmxnet3: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Yong Wang Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- drivers/net/vmxnet3/vmxne

[dpdk-dev] [PATCH v4 27/29] net/thunderx: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. Signed-off-by: Jerin Jacob --- drivers/net/thunderx/base/nicvf_plat.h | 36 -- 1 file changed

[dpdk-dev] [PATCH v4 25/29] net/nfp: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Alejandro Lucero Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Acked-by: Alejandro Luc

[dpdk-dev] [PATCH v4 28/29] net/virtio: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Huawei Xie CC: Yuanhan Liu Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Acked-by: Yu

[dpdk-dev] [PATCH v4 26/29] net/qede: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Harish Patil CC: Rasesh Mody Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- drive

[dpdk-dev] [PATCH v4 24/29] net/ixgbe: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Helin Zhang CC: Konstantin Ananyev Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob ---

[dpdk-dev] [PATCH v4 21/29] net/enic: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: John Daley CC: Nelson Escobar Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- driv

[dpdk-dev] [PATCH v4 20/29] net/ena: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Jan Medala CC: Jakub Palider Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Acked-by:

[dpdk-dev] [PATCH v4 23/29] net/i40e: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Helin Zhang CC: Jingjing Wu Signed-off-by: Santosh Shukla Signed-off-by: Satha Rao Signed-off-by

[dpdk-dev] [PATCH v4 22/29] net/fm10k: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Jing Chen Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- drivers/net/fm10k/base/fm

[dpdk-dev] [PATCH v4 19/29] net/e1000: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Wenzhuo Lu Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- drivers/net/e1000/base/e

[dpdk-dev] [PATCH v4 18/29] net/cxgbe: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Rahul Lakkireddy Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- drivers/net/cxgbe/

[dpdk-dev] [PATCH v4 17/29] net/bnx2x: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Harish Patil CC: Rasesh Mody Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- drive

[dpdk-dev] [PATCH v4 16/29] net/bnxt: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: Stephen Hurd CC: Ajit Khaparde Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- dri

[dpdk-dev] [PATCH v4 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-16 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. CC: John Griffin CC: Fiona Trahe CC: Deepak Kumar Jain Signed-off-by: Santosh Shukla Signed-off-by:

[dpdk-dev] [PATCH v4 11/29] eal: generic implementation for I/O device read/write access

2017-01-16 Thread Jerin Jacob
This patch implements the generic version of rte_read[b/w/l/q]_[relaxed] and rte_write[b/w/l/q]_[relaxed] using rte_io_wmb() and rte_io_rmb() Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/generic/rte_io.h | 118 + 1 file changed, 118 insertions(+) diff --g

[dpdk-dev] [PATCH v4 10/29] eal: introduce I/O device memory read/write operations

2017-01-16 Thread Jerin Jacob
This commit introduces 8-bit, 16-bit, 32bit, 64bit I/O device memory read/write operations along with the relaxed versions. The weakly-ordered machine like ARM needs additional I/O barrier for device memory read/write access over PCI bus. By introducing the eal abstraction for I/O device memory re

[dpdk-dev] [PATCH v4 14/29] eal/arm64: change barrier definitions to macros

2017-01-16 Thread Jerin Jacob
Change rte_*wb definitions to macros in order to keep consistent with other barrier definitions in the file. Suggested-by: Jianbo Liu Signed-off-by: Jerin Jacob --- .../common/include/arch/arm/rte_atomic_64.h| 36 ++ 1 file changed, 3 insertions(+), 33 deletions(-)

[dpdk-dev] [PATCH v4 13/29] eal/arm64: override I/O device read/write access for arm64

2017-01-16 Thread Jerin Jacob
Override the generic I/O device memory read/write access and implement it using armv8 instructions for arm64. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_io.h| 4 + lib/librte_eal/common/include/arch/arm/rte_io_64.h | 199 + 2 files changed

[dpdk-dev] [PATCH v4 12/29] eal: let all architectures use generic I/O implementation

2017-01-16 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_io.h| 47 ++ lib/librte_eal/common/include/arch/ppc_64/rte_io.h | 47 ++ lib/librte_eal/common/include/arch/tile/rte_io.h | 47 ++ lib/librte_eal/common/incl

[dpdk-dev] [PATCH v4 08/29] eal/arm64: define smp barrier definition for arm64

2017-01-16 Thread Jerin Jacob
dmb instruction based barrier is used for smp version of memory barrier. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/l

[dpdk-dev] [PATCH v4 09/29] eal/arm64: define I/O device memory barriers for arm64

2017-01-16 Thread Jerin Jacob
CC: Jianbo Liu Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h index 78ebea2..ef0efc7 1

[dpdk-dev] [PATCH v4 05/29] eal/arm: separate smp barrier definition for ARMv7 and ARMv8

2017-01-16 Thread Jerin Jacob
Separate the smp barrier definition for arm and arm64 for fine control on smp barrier definition for each architecture. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_atomic.h| 6 -- lib/librte_eal/common/include/arch/arm/rte_atomic_32.h | 6 ++ lib/librte_

[dpdk-dev] [PATCH v4 07/29] eal/arm64: fix memory barrier definition for arm64

2017-01-16 Thread Jerin Jacob
dsb instruction based barrier is used for non smp version of memory barrier. Fixes: d708f01b7102 ("eal/arm: add atomic operations for ARMv8") CC: Jianbo Liu CC: sta...@dpdk.org Signed-off-by: Jerin Jacob Acked-by: Jianbo Liu --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 9 +

[dpdk-dev] [PATCH v4 06/29] eal/armv7: define I/O device memory barriers for ARMv7

2017-01-16 Thread Jerin Jacob
The patch does not provide any functional change for ARMv7. I/O barriers are mapped to existing smp barriers. CC: Jan Viktorin CC: Jianbo Liu Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_atomic_32.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/libr

[dpdk-dev] [PATCH v4 03/29] eal/tile: define I/O device memory barriers for tile

2017-01-16 Thread Jerin Jacob
The patch does not provide any functional change for tile. I/O barriers are mapped to existing smp barriers. CC: Zhigang Lu Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/tile/rte_atomic.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/common/include

[dpdk-dev] [PATCH v4 04/29] eal/ppc64: define I/O device memory barriers for ppc64

2017-01-16 Thread Jerin Jacob
The patch does not provide any functional change for ppc_64. I/O barriers are mapped to existing smp barriers. CC: Chao Zhu Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/common/inclu

[dpdk-dev] [PATCH v4 01/29] eal: introduce I/O device memory barriers

2017-01-16 Thread Jerin Jacob
This commit introduce rte_io_mb(), rte_io_wmb() and rte_io_rmb(), in order to enable memory barriers between I/O device and CPU. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/generic/rte_atomic.h | 27 ++ 1 file changed, 27 insertions(+) diff --git a/lib/librt

[dpdk-dev] [PATCH v4 02/29] eal/x86: define I/O device memory barriers for IA

2017-01-16 Thread Jerin Jacob
The patch does not provide any functional change for IA. I/O barriers are mapped to existing smp barriers. CC: Bruce Richardson CC: Konstantin Ananyev Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/x86/rte_atomic.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/li

[dpdk-dev] [PATCH v4 00/29] introduce I/O device memory read/write operations

2017-01-16 Thread Jerin Jacob
v4: 1) Changed rte_[read/write]8/16/32/64_[relaxed] definition to inline function from macros 2) net/bnxt: removed duplicate "*(volatile uint32_t *)bar = 0" v3: 1) Changed I40E_PCI_REG_WRITE to I40E_PCI_REG_WRITE_RELAXED in fastpath i40e_rx_alloc_bufs function(Tiwei) 2) Changed rte_?wb to rte_*wb

[dpdk-dev] [PATCH v4 09/10] examples/l3fwd-power: add parse-ptype option

2017-01-16 Thread Jianfeng Tan
To support those devices that do not provide packet type info when receiving packets, add a new option, --parse-ptype, to analyze packet type in the Rx callback. Signed-off-by: Jianfeng Tan Tested-by: Lei Yao --- examples/l3fwd-power/main.c | 109 +++- 1

[dpdk-dev] [PATCH v4 07/10] net/virtio: unbind intr/eventfd when stop device

2017-01-16 Thread Jianfeng Tan
When virtio devices get stopped, tell the kernel to unbind the mapping between interrupts and eventfds. Note: it behaves differently from other NICs which close eventfds, free struct. In virtio, we do those things when close device in following patch. Signed-off-by: Jianfeng Tan Tested-by: Lei Y

[dpdk-dev] [PATCH v4 10/10] examples/l3fwd-power: fix not stop and close device

2017-01-16 Thread Jianfeng Tan
As it gets killed, in SIGINT signal handler, device is not stopped and closed. In virtio's case, vector assignment in the KVM is not deassigned. This patch will invoke dev_stop() and dev_close() in signal handler. Fixes: d7937e2e3d12 ("power: initial import") Signed-off-by: Jianfeng Tan Tested-

[dpdk-dev] [PATCH v4 05/10] net/virtio: add Rx queue intr enable/disable functions

2017-01-16 Thread Jianfeng Tan
This patch implements interrupt enable/disable functions for each Rx queue. And we rely on flags of avail queue as the hint for virtio device to interrupt virtio driver or not. Signed-off-by: Jianfeng Tan Tested-by: Lei Yao --- drivers/net/virtio/virtio_ethdev.c | 22 ++ dri

[dpdk-dev] [PATCH v4 06/10] net/virtio: setup rxq interrupts

2017-01-16 Thread Jianfeng Tan
This patch mainly allocates structure to store queue/irq mapping, and configure queue/irq mapping down through PCI ops. It also creates eventfds for each Rx queue and tell the kernel about the eventfd/intr binding. Note: So far, we hard-code 1:1 queue/irq mapping (each rx queue has one exclusive i

[dpdk-dev] [PATCH v4 08/10] net/virtio: unmapping queue/irq when close device

2017-01-16 Thread Jianfeng Tan
When closing virtio devices, close eventfds, free the struct to store queue/irq mapping. Signed-off-by: Jianfeng Tan Tested-by: Lei Yao --- drivers/net/virtio/virtio_ethdev.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/dr

[dpdk-dev] [PATCH v4 02/10] net/virtio: clean up wrapper of set_config_irq

2017-01-16 Thread Jianfeng Tan
We need to define a prototype for such wrapper, which makes thing too complicated. Remove wrapper and call set_config_irq directly. Suggested-by: Yuanhan Liu Signed-off-by: Jianfeng Tan Tested-by: Lei Yao --- drivers/net/virtio/virtio_ethdev.c | 6 -- drivers/net/virtio/virtio_pci.c| 8

[dpdk-dev] [PATCH v4 03/10] net/virtio: add Rx descriptor check

2017-01-16 Thread Jianfeng Tan
Under interrupt mode, rx_descriptor_done is used as an indicator for applications to check if some number of packets are ready to be received. This patch enables this by checking used ring's local consumed idx with shared (with backend) idx. Signed-off-by: Jianfeng Tan Tested-by: Lei Yao --- d

[dpdk-dev] [PATCH v4 04/10] net/virtio: add PCI ops for queue/irq binding

2017-01-16 Thread Jianfeng Tan
Add handler in virtio_pci_ops to set queue/irq bind. Signed-off-by: Jianfeng Tan Tested-by: Lei Yao --- drivers/net/virtio/virtio_pci.c | 23 +++ drivers/net/virtio/virtio_pci.h | 3 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/net/virtio/virtio_pci.c b/drive

[dpdk-dev] [PATCH v4 01/10] net/virtio: fix rewriting LSC flag

2017-01-16 Thread Jianfeng Tan
The LSC flag is decided according to if VIRTIO_NET_F_STATUS feature is negotiated. Copy the PCI info after the judgement will rewrite the correct result. Fixes: 198ab33677c9 ("net/virtio: move device initialization in a function") CC: sta...@dpdk.org Signed-off-by: Jianfeng Tan Tested-by: Lei Y

[dpdk-dev] [PATCH v4 00/10] rxq interrupt mode for virtio PMD

2017-01-16 Thread Jianfeng Tan
v4: - Update documents: * doc/guides/nics/features/virtio.ini * doc/guides/nics/features/virtio_vec.ini * doc/guides/nics/virtio.rst - Remove unneeded parenthesis in return statement. - Change c++ comment style. v3: - Use hw->max_queue_pairs instead of dev->data->nb_rx_queues t

Re: [dpdk-dev] [PATCH v7 5/6] lib: added new library for latency stats

2017-01-16 Thread Remy Horton
On 17/01/2017 04:29, Jerin Jacob wrote: [..] It is a value added feature for DPDK. But what is the plan for incorporating the mbuf change? I have 8 month old mbuf change for ARM for natural alignment. If we are accepting any mbuf change then we need to include outstanding mbuf changes to avoid f

Re: [dpdk-dev] [PATCH v2 0/4] eal/common: introduce rte_memset and related test

2017-01-16 Thread Yang, Zhiyong
Hi, Thomas: Does this patchset have chance to be applied for 1702 release? Thanks Zhiyong > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Zhiyong > Sent: Monday, January 9, 2017 5:49 PM > To: thomas.monja...@6wind.com; Richardson, Bruce > ; Ananye

Re: [dpdk-dev] [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype option

2017-01-16 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Tuesday, January 17, 2017 1:16 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; step...@networkplumber.org; Yao, Lei A > Subject: Re: [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype > option > > On Mon

Re: [dpdk-dev] [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype option

2017-01-16 Thread Yuanhan Liu
On Mon, Jan 16, 2017 at 02:47:01PM +, Jianfeng Tan wrote: > +#if (APP_LOOKUP_METHOD == APP_LOOKUP_LPM) > + if (ptype_l3_ipv4) > +#else > + // APP_LOOKUP_EXACT_MATCH No c++ comment. Besides, this patchset misses the release note. Also bear in mind I think this feature deserves a howto

Re: [dpdk-dev] [PATCH v6 0/8] Introducing EAL Bus-Device-Driver Model

2017-01-16 Thread Shreyansh Jain
On Monday 16 January 2017 11:57 PM, Stephen Hemminger wrote: On Mon, 16 Jan 2017 21:08:19 +0530 Shreyansh Jain wrote: Link to v5: [15] :: Introduction :: DPDK has been inherently a PCI inclined framework. Because of this, the design of device tree (or list) within DPDK is also PCI inclined.

Re: [dpdk-dev] [PATCH v6 0/8] Introducing EAL Bus-Device-Driver Model

2017-01-16 Thread Shreyansh Jain
On Monday 16 January 2017 11:57 PM, Stephen Hemminger wrote: On Mon, 16 Jan 2017 21:08:19 +0530 Shreyansh Jain wrote: Link to v5: [15] :: Introduction :: DPDK has been inherently a PCI inclined framework. Because of this, the design of device tree (or list) within DPDK is also PCI inclined.

Re: [dpdk-dev] [PATCH v6 7/8] eal: enable PCI bus

2017-01-16 Thread Shreyansh Jain
On Tuesday 17 January 2017 01:28 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain --- <...> -/* Init the PCI EAL subsystem */ -int -rte_eal_pci_init(void) -{ - /* f

Re: [dpdk-dev] [PATCH v6 5/8] eal: introduce bus scan and probe in EAL

2017-01-16 Thread Shreyansh Jain
On Tuesday 17 January 2017 01:28 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Each bus implementation defines their own callbacks for scanning bus and probing devices available on the bus. Enable EAL to call bus specific scan and probe functions during DPDK initialization.

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-16 Thread Shreyansh Jain
Hello Ferruh, On Tuesday 17 January 2017 01:23 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitti

Re: [dpdk-dev] [PATCH v5 02/20] eal: Allow passing const rte_intr_handle

2017-01-16 Thread Tan, Jianfeng
Hi Jan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jan Blunck > Sent: Friday, December 23, 2016 11:58 PM > To: dev@dpdk.org > Cc: shreyansh.j...@nxp.com; david.march...@6wind.com; > step...@networkplumber.org > Subject: [dpdk-dev] [PATCH v5 02/20] eal: Allo

Re: [dpdk-dev] [PATCH v7 5/6] lib: added new library for latency stats

2017-01-16 Thread Jerin Jacob
On Mon, Jan 16, 2017 at 04:19:32PM +, Remy Horton wrote: > From: Reshma Pattan > > Add a library designed to calculate latency statistics and report them > to the application when queried. The library measures minimum, average and > maximum latencies, and jitter in nano seconds. The current i

Re: [dpdk-dev] [PATCH v3 03/10] net/virtio: add Rx descriptor check

2017-01-16 Thread Yuanhan Liu
On Mon, Jan 16, 2017 at 11:16:03AM -0800, Stephen Hemminger wrote: > On Mon, 16 Jan 2017 14:46:55 + > Jianfeng Tan wrote: > > > + return (VIRTQUEUE_NUSED(vq) >= offset); > > Unneeded parenthesis in return statement. > This is a style thing, Linux folks see it as unnecessary. BSD folks like

Re: [dpdk-dev] [PATCH v3 05/10] net/virtio: add Rx queue intr enable/disable functions

2017-01-16 Thread Jason Wang
On 2017年01月16日 22:46, Jianfeng Tan wrote: This patch implements interrupt enable/disable functions for each Rx queue. And we rely on flags of avail queue as the hint for virtio device to interrupt virtio driver or not. Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_ethdev.c | 22

[dpdk-dev] [PATCH v11 26/26] doc: update doc for VFD

2017-01-16 Thread Wenzhuo Lu
Update the doc and release note. Signed-off-by: Wenzhuo Lu --- doc/guides/contributing/design.rst | 14 ++ doc/guides/nics/i40e.rst | 1 + doc/guides/rel_notes/release_17_02.rst | 29 + 3 files changed, 44 insertions(+) diff --git a/doc

[dpdk-dev] [PATCH v11 25/26] net/i40e: set/clear VF stats from PF

2017-01-16 Thread Wenzhuo Lu
From: Qi Zhang This patch add support to get/clear VF statistics from PF side. Two APIs are added: rte_pmd_i40e_get_vf_stats. rte_pmd_i40e_reset_vf_stats. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 79 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v11 24/26] net/i40e: enhance in sanity check of MAC

2017-01-16 Thread Wenzhuo Lu
From: "Chen Jing D(Mark)" When VF sends request to add a new MAC address, PF host will check if it's a non-zero or unicast address, or it will return with error. In fact, VF still can set multicast address. This change remove to check if it's a unicast address. Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [PATCH v11 23/26] app/testpmd: handle i40e in VF VLAN filter command

2017-01-16 Thread Wenzhuo Lu
From: Bernard Iremonger modify set_vf_rx_vlan function to handle the i40e PMD. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 38 +++--- app/test-pmd/config.c | 13 - app/test-pmd/testpmd.h | 2 -- 3 files changed, 31 insertions(+),

[dpdk-dev] [PATCH v11 22/26] app/testpmd: add command to test VF VLAN tag on i40e

2017-01-16 Thread Wenzhuo Lu
From: Bernard Iremonger command is: set vf vlan tag port_id vf_id on|off Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 99 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ 2 files changed, 106 insertions(+) diff --git a/ap

[dpdk-dev] [PATCH v11 19/26] app/testpmd: use unicast promiscuous mode on i40e

2017-01-16 Thread Wenzhuo Lu
Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 93 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 102 insertions(+) diff --git a/app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v11 21/26] app/testpmd: add command to test VF broadcast mode on i40e

2017-01-16 Thread Wenzhuo Lu
From: Bernard Iremonger Add command to call rte_pmd_i40e_set_vf_broadcast. Add set vf broadcast in testpmd_funcs.rst file. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 93 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++

[dpdk-dev] [PATCH v11 16/26] net/i40e: set VF VLAN tag from PF

2017-01-16 Thread Wenzhuo Lu
From: Bernard Iremonger Add rte_pmd_i40e_set_vf_vlan_tag API. User can call the API on PF to enable/disable a specific VF's VLAN tag. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 68 +++ drivers/net/i40e/rte_pmd_i40e.h |

[dpdk-dev] [PATCH v11 20/26] app/testpmd: use multicast promiscuous mode on i40e

2017-01-16 Thread Wenzhuo Lu
Add testpmd CLI to set VF multicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 93 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 102 insertions(+) diff --git a/app/test-pmd/cmdline.

[dpdk-dev] [PATCH v11 17/26] net/i40e: set VF VLAN filter from PF

2017-01-16 Thread Wenzhuo Lu
From: Bernard Iremonger add rte_pmd_i40e_set_vf_vlan_filter API. User can call the API on PF to enable/disable a set of VF's VLAN filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 63 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v11 18/26] app/testpmd: use VFD APIs on i40e

2017-01-16 Thread Wenzhuo Lu
The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd code to use them, including VF MAC anti-spoofing, VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. Signed-off-by: Wenzhuo Lu Signed-off-by: Chen Jing D(Mark) Signed-off-by: Bernard Iremonger --- app/test-pmd/

[dpdk-dev] [PATCH v11 14/26] net/i40e: set VF VLAN insertion from PF

2017-01-16 Thread Wenzhuo Lu
From: Bernard Iremonger Support inserting VF VLAN id from PF. User can call the API on PF to insert a VLAN id to a specific VF. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 65 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v11 13/26] net/i40e: set VF VLAN strip from PF

2017-01-16 Thread Wenzhuo Lu
From: "Chen Jing D(Mark)" Add a function to configure vlan strip enable/disable for specific SRIOV VF device. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_ethdev.c| 37 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 dr

[dpdk-dev] [PATCH v11 15/26] net/i40e: set VF broadcast mode from PF

2017-01-16 Thread Wenzhuo Lu
From: Bernard Iremonger Support enabling/disabling VF broadcast mode from PF. User can call the API on PF to enable/disable a specific VF's broadcast mode. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 56 +++ drivers/net/i40e/rte_

[dpdk-dev] [PATCH v11 12/26] net/i40e: fix VF MAC address assignment

2017-01-16 Thread Wenzhuo Lu
From: Ferruh Yigit If PF sets vf->mac_addr, in VF initialization hw->mac.addr will be set to that same value. It is possible to check if PF set a MAC address or not through the hw->mac.addr variable. hw->mac.addr set by i40e_vf_parse_hw_config(), call stack is: In PF side i40e_pf_host_process_c

[dpdk-dev] [PATCH v11 11/26] net/i40e: set VF MAC from VF support

2017-01-16 Thread Wenzhuo Lu
From: Ferruh Yigit Support changing VF default MAC address. This function is not supported if PF set the MAC address for the PF. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.h| 4 +++- drivers/net/i40e/i40e_ethdev_vf.c | 49 +-- 2 files

[dpdk-dev] [PATCH v11 10/26] net/i40e: set VF MAC from PF support

2017-01-16 Thread Wenzhuo Lu
From: Ferruh Yigit Support setting VF MAC address from PF. User can call the API on PF to set a specific VF's MAC address. PF should set MAC address before VF initialized, if PF sets the MAC address after VF initialized, new MAC address won't be effective until VF reinitialized. This will remov

[dpdk-dev] [PATCH v11 09/26] net/i40e: fix VF reset flow

2017-01-16 Thread Wenzhuo Lu
From: Qi Zhang Add missing step during VF reset: PF should set I40E_VFGEN_RSTAT to ACTIVE at end of the VF reset operation or VF driver may not able to detect that reset is already completed. This patch also remove the unnecessary enum for vfr state. Fixes: 4861cde46116 ("i40e: new poll mode dri

[dpdk-dev] [PATCH v11 08/26] net/i40e: enable VF MTU change

2017-01-16 Thread Wenzhuo Lu
From: Qi Zhang This patch implement mtu_set ops for i40e VF. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index f50ac2d

[dpdk-dev] [PATCH v11 07/26] net/i40e: set VF multicast promisc mode from PF

2017-01-16 Thread Wenzhuo Lu
Support enabling/disabling VF multicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's multicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 41 +++ drivers/net/i40e/rte_pmd_i40e.

[dpdk-dev] [PATCH v11 05/26] net/i40e: set Tx loopback from PF

2017-01-16 Thread Wenzhuo Lu
Support enabling/disabling TX loopback from PF. User can call the API on PF to enable/disable TX loopback for all the PF and VFs. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 241 ++ drivers/net/i40e/rte_pmd_i40e.h | 16 ++ driv

[dpdk-dev] [PATCH v11 06/26] net/i40e: set VF unicast promisc mode from PF

2017-01-16 Thread Wenzhuo Lu
Support enabling/disabling VF unicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's unicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 41 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v11 01/26] net/i40e: support link status notification

2017-01-16 Thread Wenzhuo Lu
Add an API to expose the ability, that PF can notify VF when link status changes, to APP. So if PF APP doesn't want to enable interruption but check link status by itself, PF APP can let VF know link status changed. Signed-off-by: Wenzhuo Lu --- MAINTAINERS | 1 +

[dpdk-dev] [PATCH v11 02/26] net/i40e: add callback to user on VF to PF mbox msg

2017-01-16 Thread Wenzhuo Lu
The callback asks the user application if it is allowed to perform the mailbox messages. If the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED then continue. If ACK or NACK, do nothing and send not_supported to VF. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_pf.c | 230 +++

[dpdk-dev] [PATCH v11 04/26] net/i40e: set VF VLAN anti-spoofing from PF

2017-01-16 Thread Wenzhuo Lu
Support enabling/disabling VF VLAN anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's VLAN anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 140 -- drivers/net/i40e/i40e_ethdev.h|

[dpdk-dev] [PATCH v11 03/26] net/i40e: set VF MAC anti-spoofing from PF

2017-01-16 Thread Wenzhuo Lu
Support enabling/disabling VF MAC anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's MAC anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 65 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 +

[dpdk-dev] [PATCH v11 00/26] Support VFD on i40e - EXPERIMENTAL

2017-01-16 Thread Wenzhuo Lu
1, VF Daemon (VFD) VFD is an idea to control all the VFs from PF. As we need to support the scenario kernel PF + DPDK VF, DPDK follows the interface between kernel PF + kernel VF. We don't want to introduce too many new messages between PF and VF. So this patch set adds some new APIs to control VFs

[dpdk-dev] [PATCH v3] net/ixgbe: fix interrupt block issue

2017-01-16 Thread Qi Zhang
When handle link status change interrupt, interrupt will be blocked until delayed handler finish, the duration is at least 1 second, this may cause following VF to PF mailbox traffic be blocked and sometimes PF can't ack to VF in time before VF think it's time out. This patch remove this limitation

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix interrupt block issue

2017-01-16 Thread Zhang, Qi Z
Hi Helin: > -Original Message- > From: Zhang, Helin > Sent: Tuesday, January 17, 2017 9:31 AM > To: Zhang, Qi Z ; Lu, Wenzhuo > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: fix interrupt block issue > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Tuesday

Re: [dpdk-dev] [PATCH v3 00/10] rxq interrupt mode for virtio PMD

2017-01-16 Thread Yao, Lei A
Tested-by: Lei Yao Apply patch to dpdk_next_virtio branch. Qemu version: 2.5.0 Kernel version in VM: 4.8.1 Following TCs are tested and passed: Test Case1: Basic Virtio Interrupt test Test Case2: Interrupted received in VM with different Virtio version(0.95 and 1.0) Test Case3: Interrupted by p

[dpdk-dev] [PATCH] net/mlx5: add prefetching Rx completion queue

2017-01-16 Thread Yongseok Koh
On receiving a compressed session of Rx completion, prefetch every entries to be invalidated. Also, invalidate consumed completions per every 8 mini-completions, not to wait until the last entry is consumed. This helps to reduce jitter in rx_burst. Signed-off-by: Yongseok Koh --- drivers/net/mlx

[dpdk-dev] [PATCH] net/mlx5: lift Rx RSS indirection table size limit

2017-01-16 Thread Yongseok Koh
The size of Rx RSS indirection table was limited by 256, but it is not needed anymore. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 4 drivers/net/mlx5/mlx5_defs.h | 3 --- 2 files changed, 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c inde

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix interrupt block issue

2017-01-16 Thread Zhang, Helin
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, January 17, 2017 2:02 AM > To: Lu, Wenzhuo; Zhang, Helin > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2] net/ixgbe: fix interrupt block issue > > When handle link status change interrupt, interrupt will be blocked until > de

[dpdk-dev] [PATCH v2] net/ixgbe: fix interrupt block issue

2017-01-16 Thread Qi Zhang
When handle link status change interrupt, interrupt will be blocked until delayed handler finish, the duration is at least 1 second, this may cause following VF to PF mailbox traffic be blocked and sometimes PF can't ack to VF in time before VF think it's time out. This patch remove this limitation

Re: [dpdk-dev] [PATCH v10 26/26] doc: update doc for VFD

2017-01-16 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, January 16, 2017 6:05 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v10 26/26] doc: update doc for VFD > > 2017-01-16 13:51, Wenzhuo Lu: > > --- a/doc/gui

Re: [dpdk-dev] [PATCH v2] doc: add known uio_pci_generic issue for i40e

2017-01-16 Thread Ferruh Yigit
On 2/12/2016 4:39 PM, Jeff Guo wrote: > From: "Guo, Jia" > > When bind with uio_pci_generic in X710/XL710/XXV710, the result > is failed. uio_pci_generic is not supported by X710/XL710/XXV710. Hi Jeff, There is a Linux commit causing the issue, right. Commit done because of the reasons mentione

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx: fix IPv4 and IPv6 packet type

2017-01-16 Thread Ferruh Yigit
On 1/16/2017 2:03 PM, Adrien Mazarguil wrote: > On Wed, Jan 11, 2017 at 05:44:33PM +0100, Olivier Matz wrote: >> From: Matthieu Ternisien d'Ouville >> >> Mellanox PMDs do not differentiate IP header with or without options, so >> the advertised packet type for an IPv4 should not be RTE_PTYPE_L3_IP

Re: [dpdk-dev] [PATCH v3 0/2] crypto: add user defined name initializing parameter

2017-01-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, January 16, 2017 2:15 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH v3 0/2] crypto: add user defined name initializing > parameter > > This patchset adds a user defined name initializing parameter to all >

Re: [dpdk-dev] [PATCH v6 7/8] eal: enable PCI bus

2017-01-16 Thread Ferruh Yigit
On 1/16/2017 3:38 PM, Shreyansh Jain wrote: > Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. > > Signed-off-by: Shreyansh Jain > --- <...> > -/* Init the PCI EAL subsystem */ > -int > -rte_eal_pci_init(void) > -{ > - /* for debug purposes, PCI can be disabled */ > -

Re: [dpdk-dev] [PATCH v6 5/8] eal: introduce bus scan and probe in EAL

2017-01-16 Thread Ferruh Yigit
On 1/16/2017 3:38 PM, Shreyansh Jain wrote: > Each bus implementation defines their own callbacks for scanning bus > and probing devices available on the bus. Enable EAL to call bus specific > scan and probe functions during DPDK initialization. > > Existing PCI scan/probe continues to exist. It w

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-16 Thread Ferruh Yigit
On 1/16/2017 3:38 PM, Shreyansh Jain wrote: > Matching of PCI device address and driver ID table is being done at two > discreet locations duplicating the code. (rte_eal_pci_probe_one_driver > and rte_eal_pci_detach_dev). > > Splitting the matching function into a public fn rte_pci_match. > > Sig

[dpdk-dev] [PATCH v6 5/5] doc: add flow distributor guide

2017-01-16 Thread Pablo de Lara
Signed-off-by: Sameh Gobriel Signed-off-by: Pablo de Lara Acked-by: Christian Maciocco --- MAINTAINERS |1 + doc/guides/sample_app_ug/flow_distributor.rst | 494 doc/guides/sample_app_ug/img/flow_distributor.svg | 1254

  1   2   3   >