[dpdk-dev] [PATCH v8 25/25] net/i40e: set/clear VF stats from PF

2017-01-09 Thread Wenzhuo Lu
From: Qi Zhang This patch add support to get/clear VF statistics from PF side. Two APIs are added: rte_pmd_i40e_get_vf_stats. rte_pmd_i40e_reset_vf_stats. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 73 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v8 24/25] net/i40e: enhance in sanity check of MAC

2017-01-09 Thread Wenzhuo Lu
From: "Chen Jing D(Mark)" When VF sends request to add a new MAC address, PF host will check if it's a non-zero or unicast address, or it will return with error. In fact, VF still can set multicast address. This change remove to check if it's a unicast address. Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [PATCH v8 21/25] app/testpmd: add command to test VF broadcast mode on i40e

2017-01-09 Thread Wenzhuo Lu
From: Bernard Iremonger Add command to call rte_pmd_i40e_set_vf_broadcast. Add set vf broadcast in testpmd_funcs.rst file. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 97 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++

[dpdk-dev] [PATCH v8 23/25] app/testpmd: handle i40e in VF VLAN filter command

2017-01-09 Thread Wenzhuo Lu
From: Bernard Iremonger modify set_vf_rx_vlan function to handle the i40e PMD. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 41 ++--- app/test-pmd/config.c | 13 - app/test-pmd/testpmd.h | 2 -- 3 files changed, 34 insertions(+

[dpdk-dev] [PATCH v8 22/25] app/testpmd: add command to test VF VLAN tag on i40e

2017-01-09 Thread Wenzhuo Lu
From: Bernard Iremonger command is: set vf vlan tag port_id vf_id on|off Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 103 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ 2 files changed, 110 insertions(+) diff --git a/a

[dpdk-dev] [PATCH v8 20/25] app/testpmd: use multicast promiscuous mode on i40e

2017-01-09 Thread Wenzhuo Lu
Add testpmd CLI to set VF multicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 97 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 106 insertions(+) diff --git a/app/test-pmd/cmdline.

[dpdk-dev] [PATCH v8 19/25] app/testpmd: use unicast promiscuous mode on i40e

2017-01-09 Thread Wenzhuo Lu
Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 97 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 106 insertions(+) diff --git a/app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v8 18/25] app/testpmd: use VFD APIs on i40e

2017-01-09 Thread Wenzhuo Lu
The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd code to use them, including VF MAC anti-spoofing, VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. Signed-off-by: Wenzhuo Lu Signed-off-by: Chen Jing D(Mark) Signed-off-by: Bernard Iremonger --- app/test-pmd/

[dpdk-dev] [PATCH v8 17/25] net/i40e: set VF VLAN filter from PF

2017-01-09 Thread Wenzhuo Lu
From: Bernard Iremonger add rte_pmd_i40e_set_vf_vlan_filter API. User can call the API on PF to enable/disable a set of VF's VLAN filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 60 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v8 16/25] net/i40e: set VF VLAN tag from PF

2017-01-09 Thread Wenzhuo Lu
From: Bernard Iremonger Add rte_pmd_i40e_set_vf_vlan_tag API. User can call the API on PF to enable/disable a specific VF's VLAN tag. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 65 +++ drivers/net/i40e/rte_pmd_i40e.h |

[dpdk-dev] [PATCH v8 15/25] net/i40e: set VF broadcast mode from PF

2017-01-09 Thread Wenzhuo Lu
From: Bernard Iremonger Support enabling/disabling VF broadcast mode from PF. User can call the API on PF to enable/disable a specific VF's broadcast mode. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 53 +++ drivers/net/i40e/rte_

[dpdk-dev] [PATCH v8 14/25] net/i40e: set VF VLAN insertion from PF

2017-01-09 Thread Wenzhuo Lu
From: Bernard Iremonger Support inserting VF VLAN id from PF. User can call the API on PF to insert a VLAN id to a specific VF. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 62 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v8 13/25] net/i40e: set VF VLAN strip from PF

2017-01-09 Thread Wenzhuo Lu
From: "Chen Jing D(Mark)" Add a function to configure vlan strip enable/disable for specific SRIOV VF device. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_ethdev.c| 33 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v8 12/25] net/i40e: fix VF MAC address assignment

2017-01-09 Thread Wenzhuo Lu
From: Ferruh Yigit If PF sets vf->mac_addr, in VF initialization hw->mac.addr will be set to that same value. It is possible to check if PF set a MAC address or not through the hw->mac.addr variable. hw->mac.addr set by i40e_vf_parse_hw_config(), call stack is: In PF side i40e_pf_host_process_c

[dpdk-dev] [PATCH v8 11/25] net/i40e: set VF MAC from VF support

2017-01-09 Thread Wenzhuo Lu
From: Ferruh Yigit Support changing VF default MAC address. This function is not supported if PF set the MAC address for the PF. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.h| 4 +++- drivers/net/i40e/i40e_ethdev_vf.c | 49 +-- 2 files

[dpdk-dev] [PATCH v8 10/25] net/i40e: set VF MAC from PF support

2017-01-09 Thread Wenzhuo Lu
From: Ferruh Yigit Support setting VF MAC address from PF. User can call the API on PF to set a specific VF's MAC address. PF should set MAC address before VF initialized, if PF sets the MAC address after VF initialized, new MAC address won't be effective until VF reinitialized. This will remov

[dpdk-dev] [PATCH v8 09/25] net/i40e: fix VF reset flow

2017-01-09 Thread Wenzhuo Lu
From: Qi Zhang Add missing step during VF reset: PF should set I40E_VFGEN_RSTAT to ACTIVE at end of the VF reset operation or VF driver may not able to detect that reset is already completed. This patch also remove the unnecessary enum for vfr state. Fixes: 4861cde46116 ("i40e: new poll mode dri

[dpdk-dev] [PATCH v8 08/25] net/i40e: enable VF MTU change

2017-01-09 Thread Wenzhuo Lu
From: Qi Zhang This patch implement mtu_set ops for i40e VF. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 12da0ec

[dpdk-dev] [PATCH v8 07/25] net/i40e: set VF multicast promisc mode from PF

2017-01-09 Thread Wenzhuo Lu
Support enabling/disabling VF multicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's multicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 38 +++ drivers/net/i40e/rte_pmd_i40e.

[dpdk-dev] [PATCH v8 06/25] net/i40e: set VF unicast promisc mode from PF

2017-01-09 Thread Wenzhuo Lu
Support enabling/disabling VF unicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's unicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 38 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v8 05/25] net/i40e: set Tx loopback from PF

2017-01-09 Thread Wenzhuo Lu
Support enabling/disabling TX loopback from PF. User can call the API on PF to enable/disable TX loopback for all the PF and VFs. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 238 ++ drivers/net/i40e/rte_pmd_i40e.h | 16 ++ driv

[dpdk-dev] [PATCH v8 04/25] net/i40e: set VF VLAN anti-spoofing from PF

2017-01-09 Thread Wenzhuo Lu
Support enabling/disabling VF VLAN anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's VLAN anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 137 -- drivers/net/i40e/i40e_ethdev.h|

[dpdk-dev] [PATCH v8 02/25] net/i40e: add callback to user on VF to PF mbox msg

2017-01-09 Thread Wenzhuo Lu
The callback asks the user application if it is allowed to perform the mailbox messages. If the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED then continue. If ACK or NACK, do nothing and send not_supported to VF. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_pf.c | 230 +++

[dpdk-dev] [PATCH v8 03/25] net/i40e: set VF MAC anti-spoofing from PF

2017-01-09 Thread Wenzhuo Lu
Support enabling/disabling VF MAC anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's MAC anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 62 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 +

[dpdk-dev] [PATCH v8 01/25] net/i40e: support link status notification

2017-01-09 Thread Wenzhuo Lu
Add an API to expose the ability, that PF can notify VF when link status changes, to APP. So if PF APP doesn't want to enable interruption but check link status by itself, PF APP can let VF know link status changed. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/Makefile | 4 ++-

[dpdk-dev] [PATCH v8 00/25] Support VFD on i40e

2017-01-09 Thread Wenzhuo Lu
1, VF Daemon (VFD) VFD is an idea to control all the VFs from PF. As we need to support the scenario kernel PF + DPDK VF, DPDK follows the interface between kernel PF + kernel VF. We don't want to introduce too many new messages between PF and VF. So this patch set adds some new APIs to control VFs

Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter

2017-01-09 Thread Zhao1, Wei
Hi, yigit > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 12:26 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter > > On 12/22/2016 9:48 AM, Zhao1, Wei wrote: > > Hi, Yigit > > > >> -O

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-09 Thread Tan, Jianfeng
Hi Jason, On 1/9/2017 12:39 PM, Jason Wang wrote: On 2016年12月23日 15:14, Jianfeng Tan wrote: This patch add support vhost kernel as the backend for virtio_user. Three main hook functions are added: - vhost_kernel_setup() to open char device, each vq pair needs one vhostfd; - vhost_

Re: [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent filter

2017-01-09 Thread Zhao1, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 1:27 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent filter > > On 12/30/2016 7:53 AM, Wei Zhao wrote: > > This patch adds a function

Re: [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter

2017-01-09 Thread Zhao1, Wei
Hi, Yigit > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 1:20 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter > > On 12/30/2016 7:53 AM, Wei Zhao wrote: > > check if the rule is

Re: [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter

2017-01-09 Thread Zhao1, Wei
Hi, yigit > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 12:29 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter > > On 12/30/2016 7:52 AM, Wei Zhao wrote: > > Add support for storing

Re: [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter

2017-01-09 Thread Zhao1, Wei
Hi, yigit > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 12:31 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter > > On 12/30/2016 7:52 AM, Wei Zhao wrote: > > Add support fo

[dpdk-dev] Why MLX4 can only generate 6Mpp/s (64B pkt) by one core?

2017-01-09 Thread Royce Niu
Dear all, My Mellanox 3 Pro can only generate packet at maximum of 6Mpp/s (64B) by one core. This is too slow for a 40Gbps port. Could anyone give me a hint please? Configuration: Followed: http://dpdk.org/doc/guides/nics/mlx4.html 1. install MLNX_OFED_LINUX-3.4-2.0.0.0 2. Added CONFIG_RTE_LIB

Re: [dpdk-dev] [PATCH v3 00/33] NXP DPAA2 PMD

2017-01-09 Thread Shreyansh Jain
On Monday 09 January 2017 11:12 PM, Ferruh Yigit wrote: On 12/29/2016 5:16 AM, Shreyansh Jain wrote: ** Sending v3 on behalf of Hemant Agrawal ** <...> Hi, Getting compile error for shared library [1] build. Not investigated, copying here. Thanks, ferruh [1] == Build drivers/net/dpaa2

Re: [dpdk-dev] [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove

2017-01-09 Thread Shreyansh Jain
On Monday 09 January 2017 09:48 PM, Ferruh Yigit wrote: On 1/9/2017 3:19 PM, Ferruh Yigit wrote: On 12/26/2016 1:24 PM, Shreyansh Jain wrote: These callbacks now act as first layer of PCI interfaces from the Bus. Bus probe would enter the PMDs through the rte_driver->probe/remove callbacks, fal

Re: [dpdk-dev] [PATCH v5 01/12] eal/bus: introduce bus abstraction

2017-01-09 Thread Shreyansh Jain
Hello Ferruh, On Monday 09 January 2017 08:52 PM, Ferruh Yigit wrote: On 12/26/2016 1:23 PM, Shreyansh Jain wrote: <...> + +DPDK_17.02 { + global: + + rte_bus_list; + rte_eal_bus_add_device; + rte_eal_bus_add_driver; + rte_eal_bus_get; + rte_eal_bus_dump; +

Re: [dpdk-dev] MSI-X vector #1 seems to be stalled sometimes after VF reset (ixgbe)

2017-01-09 Thread Ruslan Nikolaev
dpdk_vfreset.patch: diff -urN dpdk-16.07/doc/guides/nics/overview.rst dpdk-16.07-new/doc/guides/nics/overview.rst --- dpdk-16.07/doc/guides/nics/overview.rst 2016-07-28 11:48:41.0 -0700 +++ dpdk-16.07-new/doc/guides/nics/overview.rst 2016-12-15 17:32:27.436425563 -0800 @@ -89,6 +89,

Re: [dpdk-dev] MSI-X vector #1 seems to be stalled sometimes after VF reset (ixgbe)

2017-01-09 Thread Ruslan Nikolaev
interrupts_excerpts.patch: drivers/net/ixgbe/ixgbe_ethdev.c eth_ixgbevf_dev_init: @@ -1462,8 +1467,9 @@ rte_intr_callback_register(&pci_dev->intr_handle, ixgbevf_dev_interrupt_handler, (void *)eth_dev); - rte_int

[dpdk-dev] MSI-X vector #1 seems to be stalled sometimes after VF reset (ixgbe)

2017-01-09 Thread Ruslan Nikolaev
Attached are 2 patches, and the discussion below is related to the slightly modified version of the dpdk 16.07 library: interrupts_excerpt.patch and dpdk_vfreset.patch 1. We use a single-shot interrupt mechanism for the RX queue (vector #1, intr_handle.efds[0]file descriptor). When we receive

[dpdk-dev] [PATCH v2] ixgbe: fix wrong VMDq function name

2017-01-09 Thread Wenzhuo Lu
The function name ixgbe_vmdq_mode_check is not right. This function checks if Virtualization Technology is enabled. It's for both VMDq and IOV. Others may be misled by the current name. Fixes: fe3a45fd4104 ("ixgbe: add VMDq support") CC: sta...@dpdk.org Signed-off-by: Wenzhuo Lu Acked-by: Bernar

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-09 Thread Tiwei Bie
On Mon, Jan 09, 2017 at 12:26:53PM +0100, Thomas Monjalon wrote: > 2017-01-09 11:57, Tiwei Bie: > > On Sun, Jan 08, 2017 at 08:39:55PM +0800, Ananyev, Konstantin wrote: > > > > Well my first reply to this thread was asking why isn't the whole API > > > > global > > > > from the start then? > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name

2017-01-09 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, January 10, 2017 1:37 AM > To: Iremonger, Bernard; Lu, Wenzhuo; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name > > On 1/9/2017 5:06 PM, Iremonger, Bernard w

[dpdk-dev] [PATCH 7/7] igb: remove useless return's

2017-01-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_pf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index 67da3c24..15bf8bfe 100644 --- a/drivers/net/e1000/igb_pf.c +++ b/drivers/net/e1000/igb_pf.c @@ -125,8 +125,6 @@ void i

[dpdk-dev] [PATCH 6/7] ixgbe: remove useless return

2017-01-09 Thread Stephen Hemminger
If all goto's lead to a return, then better to get rid of goto. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_82599_bypass.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_82599_bypass.c b/drivers/net/ixgbe/ixgbe_82599_bypas

[dpdk-dev] [PATCH 5/7] i40e: remove useless return

2017-01-09 Thread Stephen Hemminger
No need for return at end of void function. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev_vf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 0dc0af52..482b339c 100644 --- a/drivers/net/i40e/i

[dpdk-dev] [PATCH 3/7] bnx2x: remove useless return's

2017-01-09 Thread Stephen Hemminger
Don't need empty return; at end of void function. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c| 2 -- drivers/net/bnx2x/bnx2x_ethdev.c | 2 -- drivers/net/bnx2x/elink.c| 1 - 3 files changed, 5 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/b

[dpdk-dev] [PATCH 4/7] kni: remove useless return statements

2017-01-09 Thread Stephen Hemminger
A return statement at end of void function is unnecessary. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_82575.c | 4 lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_i210.c| 2 -- lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_mac.c | 4 l

[dpdk-dev] [PATCH v2 0/7] minor cleanup

2017-01-09 Thread Stephen Hemminger
Mostly things found while inspecting other code. Stephen Hemminger (7): bonding,malloc,bitmap: remove useless return ethdev: reduce goto's in attach/detach bnx2x: remove useless return's kni: remove useless return statements i40e: remove useless return ixgbe: remove useless return ig

[dpdk-dev] [PATCH 2/7] ethdev: reduce goto's in attach/detach

2017-01-09 Thread Stephen Hemminger
Extra goto's to just a return are unnecessary. Don't do unnecessary initialization. Propgate return value. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 52 +-- 1 file changed, 21 insertions(+), 31 deletions(-) diff --git a/lib/libr

[dpdk-dev] [PATCH 1/7] bonding, malloc, bitmap: remove useless return

2017-01-09 Thread Stephen Hemminger
return statements at end of void functions are unnecessary and unwanted. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- lib/librte_eal/common/rte_malloc.c | 1 - lib/librte_sched/rte_bitmap.h | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-

[dpdk-dev] [PATCH v3] net/enic: add support for TSO

2017-01-09 Thread John Daley
The enic TSO implementation requires that the length of the Eth/IP/TCP headers be passed to the NIC. Other than that, it's just a matter of setting the mss and offload mode on a per packet basis. In TSO mode, IP and TCP checksums are offloaded even if not requested with mb->ol_flags. Signed-off-b

[dpdk-dev] [PATCH v2] net/enic: add support for TSO

2017-01-09 Thread John Daley
The enic TSO implementation requires that the length of the Eth/IP/TCP headers be passed to the NIC. Other than that, it's just a matter of setting the mss and offload mode on a per packet basis. In TSO mode, IP and TCP checksums are offloaded even if not requested with mb->ol_flags. Signed-off-b

Re: [dpdk-dev] [PATCH v2 0/5] Elastic Flow Distributor

2017-01-09 Thread Maciocco, Christian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, January 06, 2017 5:06 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH v2 0/5] Elastic Flow Distributor > > EFD is a distributor library that uses perf

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-09 Thread Stephen Hemminger
On Thu, 24 Nov 2016 09:56:38 +0100 Olivier Matz wrote: > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 22d97a4..577c775 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -211,43 +211,73 @@ virtqueue_enqueue_

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-09 Thread Olivier Matz
Hi Yuanhan, On Wed, 14 Dec 2016 15:27:50 +0800, Yuanhan Liu wrote: > Firstly sorry for late response! No problem, I fully understand ;) > On Thu, Nov 24, 2016 at 09:56:38AM +0100, Olivier Matz wrote: > > With virtio, doing tso requires to modify the network > > packet data: > > I thought mor

Re: [dpdk-dev] [PATCH v3 00/33] NXP DPAA2 PMD

2017-01-09 Thread Ferruh Yigit
On 12/29/2016 5:16 AM, Shreyansh Jain wrote: > ** Sending v3 on behalf of Hemant Agrawal ** > <...> Hi, Getting compile error for shared library [1] build. Not investigated, copying here. Thanks, ferruh [1] == Build drivers/net/dpaa2 LD librte_pmd_dpaa2.so.1.1 /usr/bin/ld: cannot find -lr

Re: [dpdk-dev] [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 5:06 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Lu, Wenzhuo >> Sent: Friday, January 6, 2017 2:31 AM >> To: dev@dpdk.org >> Cc: Iremonger, Bernard ; Lu, Wenzhuo >> ; sta...@dpdk.org >> Subject: [PATCH] ixgbe: fix wrong VMDq function name >> >> The function name

Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability

2017-01-09 Thread Stephen Hemminger
On Mon, 09 Jan 2017 14:18:58 +0100 Thomas Monjalon wrote: > 2017-01-09 12:02, Bruce Richardson: > > On Wed, Dec 28, 2016 at 03:51:56AM +, Wu, Jingjing wrote: > > > > > > > > > > -Original Message- > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > > >

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-09 Thread Stephen Hemminger
On Mon, 9 Jan 2017 10:01:40 + Remy Horton wrote: > On 09/01/2017 07:16, Yang, Qiming wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > [..] > >> void > >> +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int > >> +fw_lengt

Re: [dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources.

2017-01-09 Thread Thomas Monjalon
2017-01-04 18:39, Thomas Monjalon: > 2016-12-21 17:19, Thomas Monjalon: > > 2016-11-25 14:51, Shreyansh Jain: > > > On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > > > > If resources were mapped prior to probe, unmap them > > > > if probe fails. > > > > > > > > This does not handle the c

Re: [dpdk-dev] [PATCH 0/2] minor cleanups

2017-01-09 Thread Thomas Monjalon
Hi Stephen, This series is still pending. Would you mind to make a v2, please? 2016-12-07 17:47, Stephen Hemminger: > Saw this while reviewing other changes > > Stephen Hemminger (2): > eth: get rid of goto's in rte_eth_dev_detach > sched/malloc: remove unnecesary return statements

Re: [dpdk-dev] [PATCH v4] ethdev: fix port data mismatched in multiple process model

2017-01-09 Thread Thomas Monjalon
Hi Yuanhan, Nit: the title should be "v4 1/6" Except that, good patch :) > Signed-off-by: Yuanhan Liu Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH] ixgbe: fix wrong VMDq function name

2017-01-09 Thread Iremonger, Bernard
> -Original Message- > From: Lu, Wenzhuo > Sent: Friday, January 6, 2017 2:31 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; Lu, Wenzhuo > ; sta...@dpdk.org > Subject: [PATCH] ixgbe: fix wrong VMDq function name > > The function name ixgbe_vmdq_mode_check is not right. > This function ch

Re: [dpdk-dev] [PATCH] net/bnxt: Add support for new PCI IDs

2017-01-09 Thread Stephen Hemminger
fine BROADCOM_DEV_ID_57416_MF 0x16ee > > static struct rte_pci_id bnxt_pci_id_map[] = { > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) }, > @@ -95,6 +110,21 @@ static struct rte_pci_id bnxt_pci_id_map[] = { > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID

Re: [dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Royce Niu
It is a simple L2FWD. It can be 14mpps in x520 nics. So, do you think where should I check? Thanks On Tue, 10 Jan 2017 at 12:13 AM, Adrien Mazarguil < adrien.mazarg...@6wind.com> wrote: > On Mon, Jan 09, 2017 at 11:23:56PM +0800, Royce Niu wrote: > > > Hi, Adrien, > > > > > > Actually, I tested

[dpdk-dev] [PATCH] tools: fix active interface detection in dpdk-devbind.py

2017-01-09 Thread Yoni Gilad
When adding crypto devices, the "Active" and "Ssh_if" attributes of existing network devices were reset. This causes the follwing issues: - Network interfaces aren't marked as "*Active*" in the --status output. - Active network interfaces can be unbound without the --force option, causing loss o

[dpdk-dev] [PATCH v2 2/2] app/testpmd: add command to configure VMDq

2017-01-09 Thread Bernard Iremonger
Add the following command to configure VMDq: port config vmdq Add new command to testpmd user guide. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 60 + app/test-pmd/testpmd.c | 126 app/test-pm

[dpdk-dev] [PATCH v2 1/2] net/i40e: fix segmentation fault in close

2017-01-09 Thread Bernard Iremonger
Change the order of releasing the vsi's. Release the vmdq vsi's first, then release the main vsi. Fixes: 4861cde46116 ("i40e: new poll mode driver") CC: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 del

[dpdk-dev] [PATCH v2 0/2] net/i40e: fix segmentation fault

2017-01-09 Thread Bernard Iremonger
Changes in v2: These two patches were previously part of the following patchset: [PATCH v7 00/27] Support VFD on i40e They are being submitted seperately as they are not needed for VFD. The net/i40e patch has been revised. The testpmd patch is needed to setup VMDq in order to test the fix. Bernar

Re: [dpdk-dev] [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 3:19 PM, Ferruh Yigit wrote: > On 12/26/2016 1:24 PM, Shreyansh Jain wrote: >> These callbacks now act as first layer of PCI interfaces from the Bus. >> Bus probe would enter the PMDs through the rte_driver->probe/remove >> callbacks, falling to rte_xxx_driver->probe/remove (Currently,

Re: [dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Adrien Mazarguil
On Mon, Jan 09, 2017 at 11:23:56PM +0800, Royce Niu wrote: > Hi, Adrien, > > Actually, I tested using the original kernel module without binding. It > works. > > However, it is only 6Mpps for 64B in pkt-gen, which is so slow for a 40Gbps > NIC. > > Is that right? That's difficult to say without

Re: [dpdk-dev] [PATCH v2 07/11] crypto/dpaa2_sec: Add DPAA2_SEC PMD into build system

2017-01-09 Thread Thomas Monjalon
2016-12-23 01:46, Akhil Goyal: > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_COMMON),y) > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_sec > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_qbman > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_dpio > +_LD

Re: [dpdk-dev] [PATCH v5 2/6] net/mlx5: support basic flow items and actions

2017-01-09 Thread Adrien Mazarguil
Hi Ferruh, On Fri, Jan 06, 2017 at 01:52:53PM +, Ferruh Yigit wrote: > On 1/4/2017 6:42 PM, Adrien Mazarguil wrote: > > Hi Ferruh, > > > > On Wed, Jan 04, 2017 at 05:49:46PM +, Ferruh Yigit wrote: > >> Hi Nelio, > >> > >> A quick question. > > > > I'll reply since it's related to the API

Re: [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce new performance test application

2017-01-09 Thread Thomas Monjalon
2017-01-05 17:50, Slawomir Mrozowicz: > --- a/app/Makefile > +++ b/app/Makefile > @@ -38,5 +38,6 @@ DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd > DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_test > DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info > DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump > +DIRS-$

Re: [dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Royce Niu
Hi, Adrien, Actually, I tested using the original kernel module without binding. It works. However, it is only 6Mpps for 64B in pkt-gen, which is so slow for a 40Gbps NIC. Is that right? On Mon, Jan 9, 2017 at 11:13 PM, Adrien Mazarguil < adrien.mazarg...@6wind.com> wrote: > Hi Royce, > > On

Re: [dpdk-dev] [PATCH] crypto test: add integrity check for mbuf data

2017-01-09 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe > Sent: Thursday, December 22, 2016 4:51 PM > To: dev@dpdk.org > Cc: Griffin, John ; Jain, Deepak K > ; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [dpdk-dev] [PATCH] crypto test: add integrity

Re: [dpdk-dev] [PATCH v5 01/12] eal/bus: introduce bus abstraction

2017-01-09 Thread Ferruh Yigit
On 12/26/2016 1:23 PM, Shreyansh Jain wrote: <...> > + > +DPDK_17.02 { > + global: > + > + rte_bus_list; > + rte_eal_bus_add_device; > + rte_eal_bus_add_driver; > + rte_eal_bus_get; > + rte_eal_bus_dump; > + rte_eal_bus_register; > + rte_eal_bus_insert_device; Th

Re: [dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Adrien Mazarguil
Hi Royce, On Mon, Jan 09, 2017 at 10:53:37PM +0800, Royce Niu wrote: > Dear all, > > I cannot use my Mellanox 3 Pro, after I binded it with igb_uio driver. > > It always shows when I use my DPDK application. > > EAL: Detected 32 lcore(s) > EAL: Probing VFIO support... > PMD: bnxt_rte_pmd_init()

Re: [dpdk-dev] [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove

2017-01-09 Thread Ferruh Yigit
On 12/26/2016 1:24 PM, Shreyansh Jain wrote: > These callbacks now act as first layer of PCI interfaces from the Bus. > Bus probe would enter the PMDs through the rte_driver->probe/remove > callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the > drivers are rte_pci_driver). > > Th

[dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Royce Niu
Dear all, I cannot use my Mellanox 3 Pro, after I binded it with igb_uio driver. It always shows when I use my DPDK application. EAL: Detected 32 lcore(s) EAL: Probing VFIO support... PMD: bnxt_rte_pmd_init() called for (null) EAL: PCI device :02:00.0 on NUMA socket 0 EAL: probe driver: 80

Re: [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce new performance test application

2017-01-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Thursday, January 05, 2017 4:50 PM > To: dev@dpdk.org > Cc: Mrozowicz, SlawomirX; Doherty, Declan; Azarewicz, PiotrX T; Kerlin, > Marcin; Kobylinski, MichalX > Subject: [dpdk-dev] [PAT

[dpdk-dev] [PATCH v4 5/6] example: distributor app showing burst api

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- examples/distributor/main.c | 508 ++-- 1 file changed, 390 insertions(+), 118 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index e7641d2..eebfb74 100644 --- a/examples/distributor/main.c

[dpdk-dev] [PATCH v4 6/6] doc: distributor library changes for new burst api

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- doc/guides/prog_guide/packet_distrib_lib.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/prog_guide/packet_distrib_lib.rst b/doc/guides/prog_guide/packet_distrib_lib.rst index b5bdabb..dffd4ad 100644 --- a/doc/guides/prog_guide/packet_distrib_

[dpdk-dev] [PATCH v4 4/6] test: add distributor_perf autotest

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- app/test/test_distributor_perf.c | 148 --- 1 file changed, 137 insertions(+), 11 deletions(-) diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c index 7947fe9..b273bf9 100644 --- a/app/test/test_dist

[dpdk-dev] [PATCH v4 3/6] test: unit tests for new distributor burst api

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- app/test/test_distributor.c | 501 ++-- 1 file changed, 392 insertions(+), 109 deletions(-) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 85cb8f3..3871f86 100644 --- a/app/test/test_distributor.c

[dpdk-dev] [PATCH v4 2/6] lib: add distributor vector flow matching

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- lib/librte_distributor/Makefile| 4 + lib/librte_distributor/rte_distributor_burst.c | 11 +- lib/librte_distributor/rte_distributor_match_sse.c | 113 + lib/librte_distributor/rte_distributor_priv.h | 6 ++ 4 fil

[dpdk-dev] [PATCH v4 0/6] distributor library performance enhancements

2017-01-09 Thread David Hunt
This patch aims to improve the throughput of the distributor library. It uses a similar handshake mechanism to the previous version of the library, in that bits are used to indicate when packets are ready to be sent to a worker and ready to be returned from a worker. One main difference is that in

[dpdk-dev] [PATCH v4 1/6] lib: distributor performance enhancements

2017-01-09 Thread David Hunt
Now sends bursts of up to 8 mbufs to each worker, and tracks the in-flight flow-ids (atomic scheduling) New file with a new api, similar to the old API except with _burst at the end of the function names Signed-off-by: David Hunt --- lib/librte_distributor/Makefile| 2 + l

[dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check

2017-01-09 Thread Piotr Azarewicz
EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is unneeded. Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") Signed-off-by: Piotr Azarewicz --- drivers/crypto/openssl/rte_openssl_pmd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-09 Thread george . dit
Hi Shahaf, Thanks for the clarification! Is there a plan for this functionality to be provided (soon)? (or any technical limitation that stands in this way) Thanks and best regards, Georgios On Mon, Jan 9, 2017 at 2:32 PM, Shahaf Shuler wrote: > Hi Georgios, > > It is not support on Mellanox P

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-09 Thread Adrien Mazarguil
Hi Konstantin, On Sun, Jan 08, 2017 at 12:39:55PM +, Ananyev, Konstantin wrote: > > Hi Adrien, > > > > > Hi Konstantin, > > > > On Thu, Jan 05, 2017 at 11:32:38AM +, Ananyev, Konstantin wrote: > > > Hi Adrien, [...] > > > > PMD-specific symbols have nothing to do in the global namespac

Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability

2017-01-09 Thread Ferruh Yigit
On 12/13/2016 1:08 AM, Michał Mirosław wrote: > Signed-off-by: Michał Mirosław > --- <...> > if (ret) > - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control " > - " frames from VSIs."); > + PMD_INIT_LOG(ERR, "Failed to add fil

Re: [dpdk-dev] [PATCH] app/test: fix aad padding size in SGL operation

2017-01-09 Thread Kusztal, ArkadiuszX
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, January 09, 2017 1:39 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; Griffin, John > ; Jain, Deepak K > Subject: RE: [PATCH] app/test: fix aad padding size in SGL operation > > Hi Arek, > > > -Orig

Re: [dpdk-dev] [PATCH v3 0/7] virtio_user as an alternative exception path

2017-01-09 Thread Bruce Richardson
On Wed, Jan 04, 2017 at 03:59:19AM +, Jianfeng Tan wrote: > v3: > - Drop the patch to postpone driver ok sending patch, superseded it > with a bug fix to disable all virtqueues and re-init the device. > (you might wonder why not just send reset owner msg. Under my test, > it caus

Re: [dpdk-dev] [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for Descriptor formation

2017-01-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, December 22, 2016 8:17 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > hemant.agra...@nxp.com; Mcnamara, John; nhor...@tuxdriver.com; > Akhil Goyal; Hor

Re: [dpdk-dev] [PATCH] app/test: fix aad padding size in SGL operation

2017-01-09 Thread De Lara Guarch, Pablo
Hi Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, January 03, 2017 3:39 PM > To: dev@dpdk.org > Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K; > Kusztal, ArkadiuszX > Subject: [PATCH] app/test: fix aad padding size in SGL operation > > Thi

Re: [dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device pointer in cryptodevice

2017-01-09 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, December 22, 2016 8:17 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > hemant.agra...@nxp.com; Mcnamara, John; nhor...@tuxdriver.co

Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-09 Thread Shahaf Shuler
Hi Georgios, It is not support on Mellanox PMD to read the primary process counters from a secondary process. --Shahaf -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of george@gmail.com Sent: Sunday, January 8, 2017 3:38 PM To: dev@dpdk.org Subject: [dpdk-dev

Re: [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 1:30 PM, Ferruh Yigit wrote: > On 1/9/2017 1:48 PM, Yong Wang wrote: >> In function "reassemble_packets()", the statement "end = secondlast;" >> is redundant since there is another assignment "start = end = NULL;" >> 3 lines below. BTW, I removed the redundant braces in the conditional

Re: [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 1:48 PM, Yong Wang wrote: > In function "reassemble_packets()", the statement "end = secondlast;" > is redundant since there is another assignment "start = end = NULL;" > 3 lines below. BTW, I removed the redundant braces in the conditional > statement "if (end->data_len > rxq->crc_len)

  1   2   >