Re: [dpdk-dev] [PATCH v2 09/29] eal/arm64: define I/O device memory barriers for arm64

2017-01-04 Thread Jerin Jacob
On Thu, Jan 05, 2017 at 02:47:27PM +0800, Jianbo Liu wrote: > On 5 January 2017 at 14:24, Jerin Jacob > wrote: > > On Thu, Jan 05, 2017 at 01:31:44PM +0800, Jianbo Liu wrote: > >> On 4 January 2017 at 18:01, Jerin Jacob > >> wrote: > >> > On Tue, Jan 03, 2017 at 03:48:32PM +0800, Jianbo Liu wro

Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2017-01-04 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, January 03, 2017 7:41 AM > > On 12/31/2016 7:41 AM, Mody, Rasesh wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Friday, December 23, 2016 7:42 AM > >> > >> On 12/3/2016 9:11 AM, Rasesh Mody wrote: > >>

[dpdk-dev] [PATCH v2 25/26] net/qede/base: dcbx changes for base driver

2017-01-04 Thread Rasesh Mody
This patch includes changes for DCBX like: - Return empty parameters for oper-params query when negotiation is not complete - Use the ieee specific mask value for reading the ethtype value in the ieee dcbx mode - Endian-ness conversion is not needed for priority<->TC field, as the data

[dpdk-dev] [PATCH v2 26/26] net/qede: update PMD version to 2.0.0.1

2017-01-04 Thread Rasesh Mody
Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h index 9701d73..be54f31 100644 --- a/drivers/net/qede/qede_ethdev.h +++ b/drivers/net/qede/qede_e

[dpdk-dev] [PATCH v2 24/26] net/qede/base: refactor some code bits

2017-01-04 Thread Rasesh Mody
Bits of code refactoring in ecore_hw_bar_size(), ecore_get_hw_info() and ecore_init_cmd_*. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 39 drivers/net/qede/base/ecore_init_ops.c | 19 +++- 2 files changed, 28 insertions

[dpdk-dev] [PATCH v2 20/26] net/qede: add PCI ids for new chip variant

2017-01-04 Thread Rasesh Mody
Add PCI IDs for new asic type (defined as CHIP_NUM_AH_xxx). It supports 50G, 40G, 25G and 10G speeds. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |7 +- drivers/net/qede/qede_ethdev.c| 29 +-- drivers/net/qede/qede_ethdev.h| 47 +++

[dpdk-dev] [PATCH v2 22/26] net/qede/base: add support for new firmware

2017-01-04 Thread Rasesh Mody
Add support for 8.14.x.x firmware. The new firmware adds support for external PHY BCM8485x; configures fixed link speed with transceiver/cable not supporting negotiation; supports engine swap; supports overriding PCIe preset equalization value; checks pause too long for ports and reads die tempera

[dpdk-dev] [PATCH v2 21/26] net/qede: add 50G device PCI id

2017-01-04 Thread Rasesh Mody
Add 50G device support for 57980 series Signed-off-by: Rasesh Mody --- config/common_base |2 +- doc/guides/nics/qede.rst |4 ++-- drivers/net/qede/qede_ethdev.c |3 +++ drivers/net/qede/qede_ethdev.h |2 ++ 4 files changed, 8 insertions(+), 3 deletions(-) diff

[dpdk-dev] [PATCH v2 23/26] net/qede/base: semantic/formatting changes

2017-01-04 Thread Rasesh Mody
This patch consists of semantic/formatting changes. It also includes comment additions. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/common_hsi.h |5 +- drivers/net/qede/base/ecore_dev.c| 14 +- drivers/net/qede/base/ecore_hsi_common.h | 14 +- drivers/net/qede/base

[dpdk-dev] [PATCH v2 18/26] net/qede/base: add support for external PHY

2017-01-04 Thread Rasesh Mody
Add support for external PHY BCM8485x. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c |6 +-- drivers/net/qede/base/mcp_public.h | 88 ++-- 2 files changed, 87 insertions(+), 7 deletions(-) diff --git a/drivers/net/qede/base/ecore_mcp.c

[dpdk-dev] [PATCH v2 17/26] net/qede/base: retrieve FW crash dump info

2017-01-04 Thread Rasesh Mody
As part of device probe, check if management FW crash dump logs are available. If available, then log an warning message and update the epoch value too. A new struct ecore_mdump_info is added to populate dump info including the new "reason" field by reading shared memory region. Signed-off-by: Ras

[dpdk-dev] [PATCH v2 19/26] net/qede/base: add support for 2x10G mode

2017-01-04 Thread Rasesh Mody
Add support for 2x10G mode Signed-off-by: Rasesh Mody --- doc/guides/nics/qede.rst |2 +- drivers/net/qede/base/ecore.h |1 + drivers/net/qede/base/ecore_dev.c |3 +++ drivers/net/qede/base/nvm_cfg.h |2 ++ 4 files changed, 7 insertions(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH v2 15/26] net/qede: add new host ring type option

2017-01-04 Thread Rasesh Mody
Add new option called external PBL (page base list) to ecore_chain_alloc for future use. Mark chain as external if external PBL is provided. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_chain.h |9 - drivers/net/qede/base/ecore_dev.c | 27 ---

[dpdk-dev] [PATCH v2 14/26] net/qede/base: add macros for converting pointer

2017-01-04 Thread Rasesh Mody
Add macros PTR_LO and PTR_HI (for converting pointer to HI and LOW bits for passing to FW hsi handles). Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_utils.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/qede/base/ecore_utils.h b/drivers/net/qede/base/eco

[dpdk-dev] [PATCH v2 16/26] net/qede/base: add check for get nvm info return code

2017-01-04 Thread Rasesh Mody
Fail ecore_get_hw_info() in case ecore_hw_get_nvm_info() fails. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index f29b3c

[dpdk-dev] [PATCH v2 13/26] net/qede/base: add new enum member to status codes

2017-01-04 Thread Rasesh Mody
Add ECORE_CONN_RESET to enum ecore_status. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_status.h |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/qede/base/ecore_status.h b/drivers/net/qede/base/ecore_status.h index 6277bc8..c77ec26 100644 --- a/drivers/net/qede/

[dpdk-dev] [PATCH v2 10/26] net/qede/base: semantic change

2017-01-04 Thread Rasesh Mody
Semantic change: No reason to have p_ prefix to non-pointers Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sriov.c | 36 +-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base

[dpdk-dev] [PATCH v2 12/26] net/qede/base: enhance resource info set printouts

2017-01-04 Thread Rasesh Mody
Add the resources names in the ecore_hw_set_resc_info() printouts. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 100 ++--- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/

[dpdk-dev] [PATCH v2 07/26] net/qede/base: add check to validate txq

2017-01-04 Thread Rasesh Mody
Make sure VF tx_qid and the status block index is in the allocated range, else fail the request. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sriov.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/qede/base/ecore_sriov

[dpdk-dev] [PATCH v2 11/26] net/qede: remove unused struct member

2017-01-04 Thread Rasesh Mody
Remove b_hw_channel from struct ecore_dev. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h|2 -- drivers/net/qede/base/ecore_vf.c | 10 -- drivers/net/qede/qede_main.c |5 ++--- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/qed

[dpdk-dev] [PATCH v2 09/26] net/qede/base: improve Tx-switching performance

2017-01-04 Thread Rasesh Mody
In order to improve Tx switching performance an additional HSI parameter called same-as-last-id is introduced. This resource allows FW caching the txqs packet properties. Driver needs to set same-as-last-id to be equal to the qzone. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_l2.c

[dpdk-dev] [PATCH v2 08/26] net/qede/base: fix updating VF queue zone id

2017-01-04 Thread Rasesh Mody
Pass the absolute qzone_id when creating queues. Fixes: 5cdd769a26ec ("qede: add L2 support") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c|9 ++--- drivers/net/qede/base/ecore_l2.c | 10 +- drivers/net/qede/base/ecore_l2_api.h | 11 +-- dr

[dpdk-dev] [PATCH v2 02/26] net/qede/base: improve set field macro

2017-01-04 Thread Rasesh Mody
Improve robustness of the SET_FIELD macro by using a mask. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/base/ecore.h b/drivers/net/qede/base/ecore.h index 907b35b..c9f3b00 100644 --- a/drivers

[dpdk-dev] [PATCH v2 05/26] net/qede/base: make API non-static

2017-01-04 Thread Rasesh Mody
Move ecore_set_fw_mac_addr from ecore_l2.c to ecore_dev.c to facilitate future code reuse. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |2 ++ drivers/net/qede/base/ecore_dev.c | 13 + drivers/net/qede/base/ecore_l2.c | 11 --- 3 files changed, 15

[dpdk-dev] [PATCH v2 03/26] net/qede/base: add handling of malicious VF

2017-01-04 Thread Rasesh Mody
Receive indication that VFs are malicious and pass it to the caller/clients and stop serving those VF's additional resource requests. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |1 + drivers/net/qede/base/ecore_iov_api.h |4 +- drivers/net/qede/base/ecore_l2.c

[dpdk-dev] [PATCH v2 06/26] net/qede/base: rename macro

2017-01-04 Thread Rasesh Mody
Rename OOO_LB_TC to PKT_LB_TC to give better meaning. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h|2 +- drivers/net/qede/base/ecore_hw.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/base/ecore.h b/drivers/net/qede/base/ecore.

[dpdk-dev] [PATCH v2 04/26] net/qede/base: change return codes in SR-IOV

2017-01-04 Thread Rasesh Mody
Change return codes in VF/SR-IOV base driver from int to enum _ecore_status_t. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sriov.c | 19 +++ drivers/net/qede/base/ecore_sriov.h |4 ++-- drivers/net/qede/base/ecore_vf.c| 33 ++

[dpdk-dev] [PATCH v2 01/26] net/qede/base: add request for PF FLR before load request

2017-01-04 Thread Rasesh Mody
Add a request for PF Function Level Reset(FLR) before a load request Fix the location of the PF FLR initiation to be after ecore_get_hw_info() (which invokes ecore_hw_info_port_num()) Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 16 ++-- drivers/net/qede/

[dpdk-dev] [PATCH v2 00/26] net/qede: update qede pmd to 2.0.0.1

2017-01-04 Thread Rasesh Mody
Hi, This patch set consists of enhancements, new 8.14.x.x firmware support and semantic changes. It update the QEDE PMD version to 2.0.0.1. v1..v2 - addresses all the review comments Please include in DPDK 17.02 release. Thanks! Rasesh Rasesh Mody (26): net/qede/base: add request for PF FLR

Re: [dpdk-dev] [PATCH v2 09/29] eal/arm64: define I/O device memory barriers for arm64

2017-01-04 Thread Jianbo Liu
On 5 January 2017 at 14:24, Jerin Jacob wrote: > On Thu, Jan 05, 2017 at 01:31:44PM +0800, Jianbo Liu wrote: >> On 4 January 2017 at 18:01, Jerin Jacob >> wrote: >> > On Tue, Jan 03, 2017 at 03:48:32PM +0800, Jianbo Liu wrote: >> >> On 27 December 2016 at 17:49, Jerin Jacob >> >> wrote: >> >> >

Re: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC anti-spoofing from PF

2017-01-04 Thread Lu, Wenzhuo
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Thursday, January 5, 2017 2:42 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC anti-spoofing > from PF > > > > > -Original Message- > > From: dev

Re: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC anti-spoofing from PF

2017-01-04 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 3, 2017 2:54 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC anti-spoofing from > PF > > Support enabling/disabling VF MAC

Re: [dpdk-dev] [PATCH v2 09/29] eal/arm64: define I/O device memory barriers for arm64

2017-01-04 Thread Jerin Jacob
On Thu, Jan 05, 2017 at 01:31:44PM +0800, Jianbo Liu wrote: > On 4 January 2017 at 18:01, Jerin Jacob > wrote: > > On Tue, Jan 03, 2017 at 03:48:32PM +0800, Jianbo Liu wrote: > >> On 27 December 2016 at 17:49, Jerin Jacob > >> wrote: > >> > CC: Jianbo Liu > >> > Signed-off-by: Jerin Jacob > >>

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: fix port data mismatched in multiple process model

2017-01-04 Thread Yuanhan Liu
On Wed, Jan 04, 2017 at 06:34:40PM +0100, Thomas Monjalon wrote: > +Cc Sergio (maintainer of the secondary process thing) > > 2016-12-28 19:02, Yuanhan Liu: > > --- a/lib/librte_ether/rte_ethdev.c > > +++ b/lib/librte_ether/rte_ethdev.c > > @@ -201,9 +201,6 @@ rte_eth_dev_allocate(const char *name

Re: [dpdk-dev] [PATCH v7 01/27] net/i40e: support link status notification

2017-01-04 Thread Lu, Wenzhuo
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Thursday, January 5, 2017 1:58 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v7 01/27] net/i40e: support link status > notification > > > > > -Original Message- > > From: dev

Re: [dpdk-dev] [PATCH v7 02/27] net/i40e: add callback to user on VF to PF mbox msg

2017-01-04 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 3, 2017 2:54 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v7 02/27] net/i40e: add callback to user on VF to > PF > mbox msg > > The callback asks the

Re: [dpdk-dev] [PATCH v5 07/17] net/i40e: add flow validate function

2017-01-04 Thread Xing, Beilei
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, January 5, 2017 2:57 AM > To: Xing, Beilei ; Wu, Jingjing > ; Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 07/17] net/i40e: add flow validate > function > > On 1/4/2017 3:22 AM, Beilei Xing wro

Re: [dpdk-dev] [PATCH v7 01/27] net/i40e: support link status notification

2017-01-04 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 3, 2017 2:54 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v7 01/27] net/i40e: support link status > notification > > Add an API to expose the ability,

Re: [dpdk-dev] [PATCH v2 09/29] eal/arm64: define I/O device memory barriers for arm64

2017-01-04 Thread Jianbo Liu
On 4 January 2017 at 18:01, Jerin Jacob wrote: > On Tue, Jan 03, 2017 at 03:48:32PM +0800, Jianbo Liu wrote: >> On 27 December 2016 at 17:49, Jerin Jacob >> wrote: >> > CC: Jianbo Liu >> > Signed-off-by: Jerin Jacob >> > --- >> > lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 +

Re: [dpdk-dev] [PATCH v2 14/18] net/ixgbe: parse L2 tunnel filter

2017-01-04 Thread Zhao1, Wei
Hi, adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, January 3, 2017 10:08 PM > To: Zhao1, Wei > Cc: dev@dpdk.org; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 14/18] net/ixgbe: parse L2 tunnel filter > > Hi Wei, > > On Fri, D

Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw version get

2017-01-04 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, December 22, 2016 11:31 PM > To: Yigit, Ferruh > Cc: Yang, Qiming; dev@dpdk.org; Horton, Remy > Subject: Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw > versi

[dpdk-dev] [PATCH] net/mlx5: add support for ConnectX-5 NICs

2017-01-04 Thread Yongseok Koh
Add PCI device ID for ConnectX-5 and enable multi-packet send for PF and VF. Signed-off-by: Yongseok Koh --- ConnectX-5 is a newly announced NIC of Mellanox. This patch includes basic enablement of ConnectX-5. drivers/net/mlx5/mlx5.c| 42 +- driv

Re: [dpdk-dev] [PATCH v4] ethtool: dispaly bus information

2017-01-04 Thread Yang, Qiming
-Original Message- From: Mcnamara, John Sent: Wednesday, January 4, 2017 10:49 PM To: Yang, Qiming ; dev@dpdk.org Cc: Yigit, Ferruh ; Zhang, Helin ; Horton, Remy ; Yang, Qiming Subject: RE: [dpdk-dev] [PATCH v4] ethtool: dispaly bus information > -Original Message- > From: d

Re: [dpdk-dev] [PATCH v4 2/5] net/e1000: add firmware version get

2017-01-04 Thread Yang, Qiming
-Original Message- From: Yigit, Ferruh Sent: Wednesday, January 4, 2017 10:00 PM To: Yang, Qiming ; dev@dpdk.org Cc: Zhang, Helin ; Horton, Remy Subject: Re: [PATCH v4 2/5] net/e1000: add firmware version get On 1/4/2017 12:03 PM, Qiming Yang wrote: > This patch adds a new function eth

Re: [dpdk-dev] [PATCH v4 5/5] ethtool: dispaly firmware version

2017-01-04 Thread Yang, Qiming
-Original Message- From: Yigit, Ferruh Sent: Wednesday, January 4, 2017 10:01 PM To: Yang, Qiming ; dev@dpdk.org Cc: Zhang, Helin ; Horton, Remy Subject: Re: [PATCH v4 5/5] ethtool: dispaly firmware version On 1/4/2017 12:03 PM, Qiming Yang wrote: > This patch enhances the ethtool exam

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-04 Thread Wu, Jingjing
> > Different HW may have different version format, so it is better to use > > string. > > > > And I prefer the API definition in your v2 patch like > > > > rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int > > fw_length); > > The problem with this is the format and content of the stri

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-04 Thread Tiwei Bie
On Thu, Jan 05, 2017 at 01:44:18AM +0800, Ananyev, Konstantin wrote: [...] > > > > > > I understand that. > > > My question was: suppose user would like to create a bonded device over 2 > > > NICs. > > > One of them is ixgbe, while other would be some other type. > > > In future get_dev_info() for

Re: [dpdk-dev] Running DPDK as an unprivileged user

2017-01-04 Thread Walker, Benjamin
On Wed, 2017-01-04 at 11:11 +0100, Thomas Monjalon wrote: > 2017-01-03 22:50, Walker, Benjamin: > > 1) Physical addresses cannot be exposed to unprivileged users due to > > security > > concerns (the fallout of rowhammer). Therefore, systems without an IOMMU can > > only support privileged users. I

Re: [dpdk-dev] Running DPDK as an unprivileged user

2017-01-04 Thread Walker, Benjamin
On Wed, 2017-01-04 at 19:39 +0800, Tan, Jianfeng wrote: > Hi Benjamin, > > > On 12/30/2016 4:41 AM, Walker, Benjamin wrote: > > DPDK today begins by allocating all of the required > > hugepages, then finds all of the physical addresses for > > those hugepages using /proc/self/pagemap, sorts the >

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2017-01-04 Thread Scott Daniels
> Vincent, > > Sorry, I missed this reply. > >> >> Le 22/12/2016 à 09:10, Chen, Jing D a écrit : >> > In the meanwhile, we have some test models ongoing to validate >> > combination of Linux and DPDK drivers for VF and PF. We'll fully support >> below 4 cases going forward. >> > 1. DPDK PF + DPD

Re: [dpdk-dev] [PATCH] eal: define generic vector types

2017-01-04 Thread Thomas Monjalon
> > Add common vector type definitions to all CPU architectures. > > > > Signed-off-by: Nelio Laranjeiro > > Acked-by: Chao Zhu < chao...@linux.vnet.ibm.com> Applied, thanks It is a first important step to use vector instructions with generic C code when possible.

Re: [dpdk-dev] [PATCH 0/3] buildtools/devtools/usertools

2017-01-04 Thread Thomas Monjalon
2016-12-20 15:24, Ferruh Yigit: > On 12/15/2016 9:59 PM, Thomas Monjalon wrote: > > The current tools/ and scripts/ directory names are not > > self describing. > > These patches create devtools/ and usertools/ directories. > > I think classifying scripts is a good idea. > > > > > Thomas Monjalo

Re: [dpdk-dev] [PATCH v4 0/3] app: make python apps python2/3 compliant

2017-01-04 Thread Thomas Monjalon
2016-12-21 15:03, John McNamara: > These patches refactor the DPDK Python applications to make them Python 2/3 > compatible. > > In order to do this the patchset starts by making the apps PEP8 compliant in > accordance with the DPDK Coding guidelines: > > http://dpdk.org/doc/guides/contributi

Re: [dpdk-dev] [PATCH] mk: disable ICC warning 188

2017-01-04 Thread Thomas Monjalon
2017-01-03 18:19, Adrien Mazarguil: > On Tue, Jan 03, 2017 at 04:15:42PM +, Ferruh Yigit wrote: > > error #188: enumerated type mixed with another type > > > > This is get when an integer assigned to an enum variable. > > > > Since this usage is common and causing many ICC compilation errors,

Re: [dpdk-dev] [PATCH v15 0/8] add Tx preparation

2017-01-04 Thread Thomas Monjalon
2016-12-23 19:40, Tomasz Kulasek: > v15 changes: > - marked rte_eth_tx_prepare api as experimental > - improved doxygen comments for nb_seg_max and nb_mtu_seg_max fields > - removed unused "uint8_t tx_prepare" declaration from testpmd No you didn't remove this useless declaration. I did it for

Re: [dpdk-dev] [PATCH v2 00/25] Generic flow API (rte_flow)

2017-01-04 Thread John Fastabend
[...] >>> Well, it should be easier to answer if you have a specific use-case in mind >>> you would like to support but that cannot be expressed with the API as >>> defined in [1], in which case please share it with the community. >> >> A use-case would be implementing OvS DPIF flow offload using

Re: [dpdk-dev] [PATCH v5 07/17] net/i40e: add flow validate function

2017-01-04 Thread Ferruh Yigit
On 1/4/2017 3:22 AM, Beilei Xing wrote: > This patch adds i40e_flow_validation function to check if > a flow is valid according to the flow pattern. > i40e_parse_ethertype_filter is added first, it also gets > the ethertype info. > i40e_flow.c is added to handle all generic filter events. > > Sign

Re: [dpdk-dev] [PATCH v5 2/6] net/mlx5: support basic flow items and actions

2017-01-04 Thread Adrien Mazarguil
Hi Ferruh, On Wed, Jan 04, 2017 at 05:49:46PM +, Ferruh Yigit wrote: > Hi Nelio, > > A quick question. I'll reply since it's related to the API. > On 12/29/2016 3:15 PM, Nelio Laranjeiro wrote: > > Introduce initial software for rte_flow rules. > > > > VLAN, VXLAN are still not supported.

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: clarify xstats Api documentation

2017-01-04 Thread Thomas Monjalon
2017-01-03 10:03, Remy Horton: > > On 23/12/2016 20:35, Olivier Matz wrote: > > Reword the Api documentation of xstats ethdev. > > > > CC: sta...@dpdk.org > > Signed-off-by: Olivier Matz > > Acked-by: Remy Horton Series applied, thanks

Re: [dpdk-dev] [PATCH v2 00/25] Generic flow API (rte_flow)

2017-01-04 Thread Adrien Mazarguil
On Wed, Jan 04, 2017 at 10:53:50AM +0100, Simon Horman wrote: > On Thu, Dec 22, 2016 at 01:48:04PM +0100, Adrien Mazarguil wrote: > > On Wed, Dec 21, 2016 at 05:19:16PM +0100, Simon Horman wrote: > > > On Fri, Dec 16, 2016 at 05:24:57PM +0100, Adrien Mazarguil wrote: [...] > > > I would like to ask

Re: [dpdk-dev] [PATCH v5 2/6] net/mlx5: support basic flow items and actions

2017-01-04 Thread Ferruh Yigit
Hi Nelio, A quick question. On 12/29/2016 3:15 PM, Nelio Laranjeiro wrote: > Introduce initial software for rte_flow rules. > > VLAN, VXLAN are still not supported. > > Signed-off-by: Nelio Laranjeiro > Acked-by: Adrien Mazarguil <...> > +static int > +priv_flow_validate(struct priv *priv,

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-04 Thread Ananyev, Konstantin
> -Original Message- > From: Bie, Tiwei > Sent: Wednesday, January 4, 2017 5:00 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; adrien.mazarg...@6wind.com; Lu, Wenzhuo > ; Mcnamara, John ; > olivier.m...@6wind.com; thomas.monja...@6wind.com; Zhang, Helin > ; Dai, Wei ; Wang, > Xiao W

Re: [dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources.

2017-01-04 Thread Thomas Monjalon
2016-12-21 17:19, Thomas Monjalon: > 2016-11-25 14:51, Shreyansh Jain: > > On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > > > If resources were mapped prior to probe, unmap them > > > if probe fails. > > > > > > This does not handle the case where the kernel driver was > > > forcibly un

[dpdk-dev] [PATCH v3 8/8] app/test: add ARMv8 crypto tests and test vectors

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek Introduce unit tests for ARMv8 crypto PMD. Add test vectors for short cases such as 160 bytes. These test cases are ARMv8 specific since the code provides different processing paths for different input data sizes. User can validate correctness of algorithms' implementation u

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: fix port data mismatched in multiple process model

2017-01-04 Thread Thomas Monjalon
+Cc Sergio (maintainer of the secondary process thing) 2016-12-28 19:02, Yuanhan Liu: > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -201,9 +201,6 @@ rte_eth_dev_allocate(const char *name) > return NULL; > } > > - if (rte_eth_dev_data ==

[dpdk-dev] [PATCH v3 6/8] crypto/armv8: enable ARMv8 PMD in the configuration

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek Add CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO option to the common configuration file. Don't enable it by default for ARM64 as it requires external library to build. Signed-off-by: Zbigniew Bodek --- config/common_base | 6 ++ 1 file changed, 6 insertions(+) diff --git a/con

[dpdk-dev] [PATCH v3 7/8] crypto/armv8: update MAINTAINERS entry for ARMv8 crypto

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek Signed-off-by: Zbigniew Bodek --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ebc97b8..89b5179 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -447,6 +447,12 @@ M: Declan Doherty F: drivers/crypto/openssl/ F: doc/gu

[dpdk-dev] [PATCH v3 5/8] doc/armv8: update documentation about crypto PMD

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek Add documentation about the driver and update release notes. Signed-off-by: Zbigniew Bodek --- doc/guides/cryptodevs/armv8.rst| 96 ++ doc/guides/cryptodevs/index.rst| 1 + doc/guides/rel_notes/release_17_02.rst | 5 ++ 3 f

[dpdk-dev] [PATCH v3 4/8] mk/crypto/armv8: add PMD to the build system

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek Build ARMv8 crypto PMD if compiling for ARM64 and CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO option is enable in the configuration file. ARMV8_CRYPTO_LIB_PATH environment variable will point to the appropriate library directory. Signed-off-by: Zbigniew Bodek --- drivers/crypto/Mak

[dpdk-dev] [PATCH v3 3/8] crypto/armv8: add PMD optimized for ARMv8 processors

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek This patch introduces crypto poll mode driver using ARMv8 cryptographic extensions. CPU compatibility with this driver is detected in run-time and virtual crypto device will not be created if CPU doesn't provide: AES, SHA1, SHA2 and NEON. This PMD is optimized to provide per

[dpdk-dev] [PATCH v3 0/8] Add crypto PMD optimized for ARMv8

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek Introduce crypto poll mode driver using ARMv8 cryptographic extensions. This PMD is optimized to provide performance boost for chained crypto operations processing, such as: * encryption + HMAC generation * decryption + HMAC validation. In particular, cipher only or hash only

[dpdk-dev] [PATCH v3 2/8] lib: add cryptodev type for the upcoming ARMv8 PMD

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek Add type and name for ARMv8 crypto PMD Signed-off-by: Zbigniew Bodek --- lib/librte_cryptodev/rte_cryptodev.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 8f63e8f..6f34f22 100644 -

[dpdk-dev] [PATCH v3 1/8] mk: fix build of assembly files for ARM64

2017-01-04 Thread zbigniew.bodek
From: Zbigniew Bodek Avoid using incorrect assembler (nasm) and unsupported flags when building for ARM64. Fixes: af75078fece3 ("first public release") b3ce00e5fe36 ("mk: introduce ARMv8 architecture") Signed-off-by: Zbigniew Bodek --- mk/arch/arm64/rte.vars.mk| 1 - mk/toolchain

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-04 Thread Tiwei Bie
On Wed, Jan 04, 2017 at 11:14:25PM +0800, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Bie, Tiwei > > Sent: Wednesday, January 4, 2017 2:39 PM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org; adrien.mazarg...@6wind.com; Lu, Wenzhuo > > ; Mcnamara, John ; > > olivier.

Re: [dpdk-dev] [PATCH v2 23/29] net/i40e: use eal I/O device memory read/write API

2017-01-04 Thread Santosh Shukla
On Wed, Jan 04, 2017 at 09:53:40PM +0800, Tiwei Bie wrote: > On Tue, Dec 27, 2016 at 03:19:29PM +0530, Jerin Jacob wrote: > > From: Santosh Shukla > > /* Update the tx tail register */ > > rte_wmb(); > > - I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail); > > + I40E_PCI_REG_WRITE_REL

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-04 Thread Ananyev, Konstantin
> -Original Message- > From: Bie, Tiwei > Sent: Wednesday, January 4, 2017 2:39 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; adrien.mazarg...@6wind.com; Lu, Wenzhuo > ; Mcnamara, John ; > olivier.m...@6wind.com; thomas.monja...@6wind.com; Zhang, Helin > ; Dai, Wei ; Wang, > Xiao W

Re: [dpdk-dev] [PATCH] nfp: add support for new metadata api

2017-01-04 Thread Ferruh Yigit
On 1/4/2017 2:43 PM, Alejandro Lucero wrote: > Hi Ferruh, > > On Wed, Jan 4, 2017 at 3:15 PM, Ferruh Yigit > wrote: > > On 12/20/2016 2:13 PM, Alejandro Lucero wrote: > > NFP is a smart programmable NIC and firmware is deployed for specific > > system n

Re: [dpdk-dev] [PATCH] nfp: add support for new metadata api

2017-01-04 Thread Alejandro Lucero
Hi Ferruh, On Wed, Jan 4, 2017 at 3:15 PM, Ferruh Yigit wrote: > On 12/20/2016 2:13 PM, Alejandro Lucero wrote: > > NFP is a smart programmable NIC and firmware is deployed for specific > > system needs, like offloading OVS, vRouter, contrack or eBPF into the > > hardware. This often requires to

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-04 Thread Tiwei Bie
On Wed, Jan 04, 2017 at 10:21:08PM +0800, Ananyev, Konstantin wrote: > Hi Twei, > > > -Original Message- > > From: Bie, Tiwei > > Sent: Wednesday, January 4, 2017 7:22 AM > > To: dev@dpdk.org > > Cc: adrien.mazarg...@6wind.com; Lu, Wenzhuo ; > > Mcnamara, John ; > > olivier.m...@6wind.com

Re: [dpdk-dev] [PATCH v5 0/6] net/mlx5: support flow API

2017-01-04 Thread Ferruh Yigit
On 12/29/2016 3:15 PM, Nelio Laranjeiro wrote: > Changes in v5: > > - Fix masking when only spec is present in item structure. > - Fix first element of flow items array. > > Changes in v4: > > - Simplify flow parsing by using a graph. > - Add VXLAN flow item. > - Add mark flow action. > -

Re: [dpdk-dev] [PATCH v4] ethtool: dispaly bus information

2017-01-04 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Wednesday, January 4, 2017 12:18 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Zhang, Helin > ; Horton, Remy ; Yang, > Qiming > Subject: [dpdk-dev] [PATCH v4] ethtool: dispaly bus information

Re: [dpdk-dev] [PATCH] net/ena: use correct field for Rx offload features

2017-01-04 Thread Ferruh Yigit
On 1/4/2017 1:58 PM, Jakub Palider wrote: > Previously the capability bitmap for Rx offloads was mistakenly taken > from Tx capability bitmap field. This patch fixes the problem. > > Signed-off-by: Jakub Palider Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-04 Thread Ananyev, Konstantin
Hi Twei, > -Original Message- > From: Bie, Tiwei > Sent: Wednesday, January 4, 2017 7:22 AM > To: dev@dpdk.org > Cc: adrien.mazarg...@6wind.com; Lu, Wenzhuo ; Mcnamara, > John ; > olivier.m...@6wind.com; thomas.monja...@6wind.com; Ananyev, Konstantin > ; Zhang, Helin > ; Dai, Wei ; Wang,

Re: [dpdk-dev] [PATCH] nfp: add support for new metadata api

2017-01-04 Thread Ferruh Yigit
On 12/20/2016 2:13 PM, Alejandro Lucero wrote: > NFP is a smart programmable NIC and firmware is deployed for specific > system needs, like offloading OVS, vRouter, contrack or eBPF into the > hardware. This often requires to give metadata to the host within > packets delivered. Last NFP firmware i

Re: [dpdk-dev] [PATCH v4 5/5] ethtool: dispaly firmware version

2017-01-04 Thread Ferruh Yigit
On 1/4/2017 12:03 PM, Qiming Yang wrote: > This patch enhances the ethtool example to support to show > firmware version, in the same way that the Linux kernel > ethtool does. > > Signed-off-by: Qiming Yang <...> > > @@ -61,6 +67,12 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct > ethtool_

Re: [dpdk-dev] [PATCH v4 4/5] net/i40e: add firmware version get

2017-01-04 Thread Ferruh Yigit
On 1/4/2017 12:03 PM, Qiming Yang wrote: > This patch add a new function i40e_fw_version_get. > > Signed-off-by: Qiming Yang > --- <...> > > diff --git a/doc/guides/nics/features/i40e.ini > b/doc/guides/nics/features/i40e.ini > index 0d143bc..6dab9f7 100644 > --- a/doc/guides/nics/features/i40e

Re: [dpdk-dev] [PATCH v4 2/5] net/e1000: add firmware version get

2017-01-04 Thread Ferruh Yigit
On 1/4/2017 12:03 PM, Qiming Yang wrote: > This patch adds a new function eth_igb_fw_version_get. > > Signed-off-by: Qiming Yang > --- <...> > > static void > +eth_igb_fw_version_get(struct rte_eth_dev *dev, u32 *fw_major, u32 *fw_minor, > + u32 *fw_patch, u32 *etrack_id) >

[dpdk-dev] [PATCH] net/ena: use correct field for Rx offload features

2017-01-04 Thread Jakub Palider
Previously the capability bitmap for Rx offloads was mistakenly taken from Tx capability bitmap field. This patch fixes the problem. Signed-off-by: Jakub Palider --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/dr

Re: [dpdk-dev] [PATCH v2 23/29] net/i40e: use eal I/O device memory read/write API

2017-01-04 Thread Tiwei Bie
On Tue, Dec 27, 2016 at 03:19:29PM +0530, Jerin Jacob wrote: > From: Santosh Shukla > > Replace the raw I/O device memory read/write access with eal abstraction > for I/O device memory read/write access to fix portability issues across > different architectures. > [...] > diff --git a/drivers/ne

Re: [dpdk-dev] [PATCH v2 3/5] test: add distributor_perf autotest

2017-01-04 Thread Jerin Jacob
On Mon, Jan 02, 2017 at 04:24:01PM +, Hunt, David wrote: > > > On 22/12/2016 12:19 PM, Jerin Jacob wrote: > > On Thu, Dec 22, 2016 at 04:37:06AM +, David Hunt wrote: > > > + struct rte_distributor_burst *d = arg; > > > + unsigned int count = 0; > > > + unsigned int num = 0; > > > + unsign

Re: [dpdk-dev] [PATCH v2 14/29] eal/arm64: change barrier definitions to macros

2017-01-04 Thread Jerin Jacob
On Wed, Jan 04, 2017 at 07:00:30PM +0800, Tiwei Bie wrote: > On Wed, Jan 04, 2017 at 03:39:14PM +0530, Jerin Jacob wrote: > > On Tue, Jan 03, 2017 at 03:55:45PM +0800, Jianbo Liu wrote: > > > On 27 December 2016 at 17:49, Jerin Jacob > > > wrote: > > > > Change rte_?wb definitions to macros in ord

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: remove explicit ixgbe link request

2017-01-04 Thread Jerin Jacob
On Wed, Jan 04, 2017 at 11:44:21AM +, Ferruh Yigit wrote: > On 1/4/2017 11:01 AM, Jerin Jacob wrote: > > On Tue, Jan 03, 2017 at 01:30:26PM +, Ferruh Yigit wrote: > >> On 12/27/2016 10:09 AM, Jerin Jacob wrote: > >>> Removed explicit ixgbe driver linkage request from > >>> app/testpmd makef

Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: enablement of avx512 support in IPsec_mb library

2017-01-04 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, December 22, 2016 8:27 AM > To: Doherty, Declan; dev@dpdk.org > Cc: Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: enablement of > avx512 support in

Re: [dpdk-dev] XL710 with i40e driver drops packets on RX even on a small rates.

2017-01-04 Thread Martin Weiser
Hello, I have performed some more thorough testing on 3 different machines to illustrate the strange results with XL710. Please note that all 3 systems were able to forward the traffic of Test 1 and Test 2 without packet loss when a 82599ES NIC was installed in the same PCI slot as the XL710 in th

Re: [dpdk-dev] [PATCH] nfp: add tso support

2017-01-04 Thread Ferruh Yigit
On 12/20/2016 10:18 AM, Alejandro Lucero wrote: > This patch implements NFP PMD support for TSO but it also requires > a firmware advertising the capability. > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] nfp: add support for new metadata api

2017-01-04 Thread Ferruh Yigit
On 12/20/2016 2:13 PM, Alejandro Lucero wrote: > NFP is a smart programmable NIC and firmware is deployed for specific > system needs, like offloading OVS, vRouter, contrack or eBPF into the > hardware. This often requires to give metadata to the host within > packets delivered. Last NFP firmware i

[dpdk-dev] [PATCH v4] ethtool: dispaly bus information

2017-01-04 Thread Qiming Yang
This patch enhances the ethtool example to support to show bus information, in the same way that the Linux kernel ethtool does. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- v4 changes: * split bus info print from patch set ethdev: add firmware version get --- --- examples/ethtool/ethto

[dpdk-dev] [PATCH v4 4/5] net/i40e: add firmware version get

2017-01-04 Thread Qiming Yang
This patch add a new function i40e_fw_version_get. Signed-off-by: Qiming Yang --- v3 changes: * use i40e_fw_version_get(struct rte_eth_dev *dev, u32 *fw_major, u32 *fw_minor, __rte_unused u32 *fw_patch, u32 *etrack_id) instead of i40e_fw_version_get(struct rte_eth_dev *dev, char *fw_ver

[dpdk-dev] [PATCH v4 5/5] ethtool: dispaly firmware version

2017-01-04 Thread Qiming Yang
This patch enhances the ethtool example to support to show firmware version, in the same way that the Linux kernel ethtool does. Signed-off-by: Qiming Yang --- v4 changes: * split bus info print from this patch set --- --- examples/ethtool/ethtool-app/ethapp.c | 1 + examples/ethtool/lib/rte_e

[dpdk-dev] [PATCH v4 3/5] net/ixgbe: add firmware version get

2017-01-04 Thread Qiming Yang
This patch add a new function ixgbe_fw_version_get. Signed-off-by: Qiming Yang --- v3 changes: * use ixgbe_fw_version_get(struct rte_eth_dev *dev, __rte_unused u32 *fw_major, __rte_unused u32 *fw_minor, __rte_unused u32 *fw_patch, u32 *etrack_id) instead of ixgbe_fw_version_get(struct

  1   2   >