> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 3, 2017 2:54 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo...@intel.com> > Subject: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC anti-spoofing from > PF > > Support enabling/disabling VF MAC anti-spoofing from PF. > User can call the API on PF to enable/disable a specific VF's MAC > anti-spoofing. > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > --- > drivers/net/i40e/i40e_ethdev.c | 63 > +++++++++++++++++++++++++++++++ > drivers/net/i40e/rte_pmd_i40e.h | 19 ++++++++++ > drivers/net/i40e/rte_pmd_i40e_version.map | 1 + > 3 files changed, 83 insertions(+) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index fc7e987..68c07de 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -9723,3 +9723,66 @@ static void i40e_set_default_mac_addr(struct > rte_eth_dev *dev, > > return 0; > } > + > +int > +rte_pmd_i40e_set_vf_mac_anti_spoof(uint8_t port, uint16_t vf_id, > +uint8_t on) { > + struct rte_eth_dev *dev; > + struct rte_eth_dev_info dev_info; > + struct i40e_pf *pf; > + struct i40e_vsi *vsi; > + struct i40e_hw *hw; > + struct i40e_vsi_context ctxt; > + int ret; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev = &rte_eth_devices[port]; > + rte_eth_dev_info_get(port, &dev_info); > + Why need to call rte_eth_dev_info_get in driver?
> + if (vf_id >= dev_info.max_vfs) > + return -EINVAL; > + Vf_id is already be checked by below, even I prefer : if (vf_id > pf->vf_num - 1 || !pf->vfs) to be if (!pf->vfs || vf_id > pf->vf_num - 1) or if (!pf->vfs || vf_id >= pf->vf_num) > + pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > +
